Re: [PATCH] ARM: dts: OMAP: Add usb_otg and glue data to OMAP3+ boards

2013-05-14 Thread Kishon Vijay Abraham I
On Saturday 11 May 2013 08:05 AM, Tony Lindgren wrote: Commit ad871c10 (ARM: dts: OMAP: Add usb_otg and glue data to OMAP3+ boards) added support for MUSB on omap3 for device tree, but added the interrupts the wrong way probably as they were copied from the omap4.dtsi file. On omap3 we have TI sp

Re: [OPW kernel] xhci.c: dma_set_mask

2013-05-14 Thread Sarah Sharp
[Please leave Alan and the Linux USB mailing list Cc'ed, since I asked for Alan's advice on this.] On Wed, May 15, 2013 at 07:50:39AM +0300, Xenia Ragiadakou wrote: > I will try to clarify more my question. > > In xhci.c: 4665 states that: > > if (HCC_64BIT_ADDR(temp)) { > xhci_dbg(x

Re: [OPW kernel] dma_set_coherent_mask

2013-05-14 Thread Sarah Sharp
On Wed, May 15, 2013 at 05:41:12AM +0300, Xenia Ragiadakou wrote: > Hi Sarah, (again) > > Also I noticed that dma_set_coherent_mask() is not called somewhere, > which according to DMA-API-HOWTO.txt, means the even if the DMA mask > is set to 64 bits by dma_set_mask, dma_alloc_coherent and > dma_p

Re: [OPW kernel] xhci.c: dma_set_mask

2013-05-14 Thread Sarah Sharp
On Wed, May 15, 2013 at 04:56:00AM +0300, Xenia Ragiadakou wrote: > Hi Sarah, Hi Ksenia! > In xhci.c line 4665, the function dma_set_mask is used to enable > 64-bit DMA addressing > (if i understood correctly). > > However, accordingly to the Documentation/DMA-API-HOWTO.txt, there > is possibili

Re: [PATCH] usb: xhci: Consolidate XHCI TD Size calculation

2013-05-14 Thread Sarah Sharp
On Thu, May 09, 2013 at 09:42:51PM -0700, Julius Werner wrote: > The TD Size field in an XHCI TRB is calculated in two different ways, > depending on the XHCI version. The current code does this version check > in every caller, which makes it easy to forget (such as in the function > for control tr

Re: [RFT 0/2] TI compliance mode fixes

2013-05-14 Thread Sarah Sharp
On Tue, May 14, 2013 at 03:49:40PM -0400, Tony Camuso wrote: > > On 05/09/2013 07:31 PM, Sarah Sharp wrote: > > Hi Tony, Don, and Oliver, > > > > Can one of you double check these two patches resolve the resume from S3 > > issue on effected HP systems with the TI compliance mode quirk? > > > > O

RE: [PATCH] usb: chipidea: udc: configure iso endpoints

2013-05-14 Thread Chen Peter-B29397
> > This patch adds iso endpoint support to the device controller. > It makes use of the multiplication bits in the maxpacket field > of the endpoint and calculates the multiplier bits for each > transfer description on every request. > > Signed-off-by: Michael Grzeschik > --- > drivers/usb/c

Re: [RFT 0/2] TI compliance mode fixes

2013-05-14 Thread Tony Camuso
On 05/09/2013 07:31 PM, Sarah Sharp wrote: > Hi Tony, Don, and Oliver, > > Can one of you double check these two patches resolve the resume from S3 > issue on effected HP systems with the TI compliance mode quirk? > > Oliver has confirmed that the first patch works, but no one has tested > the p

[PATCH] USB: OHCI: fix logic for scheduling isochronous URBs

2013-05-14 Thread Alan Stern
The isochronous scheduling logic in ohci-hcd has a bug. The calculation for skipping TDs that are too late should be carried out only in the !URB_ISO_ASAP case. When URB_ISO_ASAP is set, the URB is pushed back so that none of the TDs are too late, which would cause the calculation to overflow. T

[PATCH] USB: fix latency in uhci-hcd and ohci-hcd

2013-05-14 Thread Alan Stern
Commits c44b225077bb1fb25ed5cd5c4f226897b91bedd4 (UHCI: implement new semantics for URB_ISO_ASAP) and 6a41b4d3fe8cd4cc95181516fc6fba7b1747a27c (OHCI: implement new semantics for URB_ISO_ASAP) increased the latency for isochronous URBs in uhci-hcd and ohci-hcd respectively to 2 milliseconds, in an a

[PATCH] USB: UHCI: fix for suspend of virtual HP controller

2013-05-14 Thread Alan Stern
HP's virtual UHCI host controller takes a long time to suspend (several hundred microseconds), even when no devices are attached. This provokes a warning message from uhci-hcd in the auto-stop case. To prevent this from happening, this patch adds a test to avoid performing an auto-stop when the wa

[PATCH] USB: fix Kconfig logic for USB_UHCI_HCD

2013-05-14 Thread Alan Stern
The Kconfig settings for uhci-hcd are too permissive; they allow the driver to be built without any bus-glue modules configured (USB_UHCI_HCD enabled, PCI disabled, SPARC_LEON disabled, ARCH_VT8500 enabled, and USB_UHCI_PLATFORM disabled). This patch fixes the problem by rearranging the dependenci

Re: [PATCH] usb: chipidea: udc: configure iso endpoints

2013-05-14 Thread Sergei Shtylyov
Hello. On 05/14/2013 09:31 PM, Michael Grzeschik wrote: This patch adds iso endpoint support to the device controller. It makes use of the multiplication bits in the maxpacket field of the endpoint and calculates the multiplier bits for each transfer description on every request. Signed-off-by

[PATCH] usb: chipidea: udc: configure iso endpoints

2013-05-14 Thread Michael Grzeschik
This patch adds iso endpoint support to the device controller. It makes use of the multiplication bits in the maxpacket field of the endpoint and calculates the multiplier bits for each transfer description on every request. Signed-off-by: Michael Grzeschik --- drivers/usb/chipidea/core.c | 2 +

Re: [PATCH] usb: chipidea: udc: configure iso endpoints

2013-05-14 Thread Michael Grzeschik
Hi, On Tue, May 14, 2013 at 07:22:56PM +0200, Michael Grzeschik wrote: > The implementation is derived from the fsl_udc_core code in > fsl_ep_enable and makes basic iso handling possible. > > Signed-off-by: Michael Grzeschik > Signed-off-by: Marc Kleine-Budde > Reviewed-by: Felipe Balbi > ---

[PATCH] usb: chipidea: udc: configure iso endpoints

2013-05-14 Thread Michael Grzeschik
The implementation is derived from the fsl_udc_core code in fsl_ep_enable and makes basic iso handling possible. Signed-off-by: Michael Grzeschik Signed-off-by: Marc Kleine-Budde Reviewed-by: Felipe Balbi --- drivers/usb/chipidea/core.c | 2 +- drivers/usb/chipidea/udc.c | 19 +++

Re: Linux USB file storage gadget with new UDC

2013-05-14 Thread Alan Stern
On Tue, 14 May 2013, victor yeo wrote: > Just curious. The crash log shows the following UDC driver code which > is responsible to receive endpoint 0 setup data. However, the host PC > is sending SCSI_WRITE_10 command at the time of the crash. These two > does not correlate, right? > >

Re: Linux USB file storage gadget with new UDC

2013-05-14 Thread victor yeo
Hi, >> Thanks. I will add more printk statements gradually. Now i discover if >> i write to a large text file (> 48k) on USB gadget, linux will crash. >> The full log of UDC and gadget driver when linux crashes, and >> corresponding usbmon trace are attached. If these logs are not >> helpful, i sh

[PATCH v2 5/8] usb/isp116x-hcd: take msecs_to_jiffies_timeout into use

2013-05-14 Thread Imre Deak
Use msecs_to_jiffies_timeout instead of open-coding the same. Signed-off-by: Imre Deak --- drivers/usb/host/isp116x-hcd.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/isp116x-hcd.c b/drivers/usb/host/isp116x-hcd.c index b64e661..de5807a 100644 --- a/dri

Re: Linux USB file storage gadget with new UDC

2013-05-14 Thread Alan Stern
On Tue, 14 May 2013, victor yeo wrote: > Thanks. I will add more printk statements gradually. Now i discover if > i write to a large text file (> 48k) on USB gadget, linux will crash. > The full log of UDC and gadget driver when linux crashes, and > corresponding usbmon trace are attached. If thes

Re: [PATCH 01/13] usb: chipidea: ci13xxx_imx: Let device core handle pinctrl

2013-05-14 Thread Alexander Shishkin
Fabio Estevam writes: > Since commit ab78029 (drivers/pinctrl: grab default handles from device core), > we can rely on device core for handling pinctrl. > > So remove devm_pinctrl_get_select_default() from the driver. I'm taking this patch into my tree unless there are objections. Regards, --

[PATCH] usb: dwc3: Fix compilation break when building with USB_DWC3_DUAL_ROLE=y

2013-05-14 Thread Vivek Gautam
The commit: 388e5c5 usb: dwc3: remove dwc3 dependency on host AND gadget breaks compilation when USB=y, USB_GADGET=m, USB_DWC3=y and USB_DWC3_DUAL_ROLE=y. drivers/built-in.o: In function `dwc3_gadget_giveback': drivers/usb/dwc3/gadget.c:271: undefined reference to `usb_gadget_unmap_request' driver

Re: undefined reference to `usb_gadget_unmap_request' regression

2013-05-14 Thread Vivek Gautam
Hi, On Fri, May 10, 2013 at 8:35 PM, Vivek Gautam wrote: > Hi Felipe, > > > On Thu, May 9, 2013 at 8:18 PM, Felipe Balbi wrote: >> Hi, >> >> On Wed, May 08, 2013 at 10:04:56PM +0530, Vivek Gautam wrote: >>> Commit 388e5c51135f817f01177c42261f1116a6d7f2ad usb: dwc3: remove >>> dwc3 dependency on

Re: Linux USB file storage gadget with new UDC

2013-05-14 Thread victor yeo
Hi, > All I can tell is that the gadget got hung after receiving the second > WRITE command. Can you figure out where it got hung and why? > > Victor, you don't seem to get the big pattern that keeps repeating > here. Every time something does wrong, you tell me about it. Then I > point out tha