Re: [PATCH] Raise the maximum number of usb-serial devices to 256

2013-05-28 Thread Rob Landley
On 05/27/2013 04:30:12 AM, Tobias Winter wrote: Raise the maximum number of usb-serial devices to 256, which is the actual limit supported by the codebase. Signed-off-by: Jakob-Tobias Winter tob...@linuxdingsda.de Tested-by: Jakob-Tobias Winter tob...@linuxdingsda.de ---

Re: [PATCH v6 0/9] Generic PHY Framework

2013-05-28 Thread Kishon Vijay Abraham I
Hi, On Tuesday 21 May 2013 10:31 AM, Kishon Vijay Abraham I wrote: Hi, On Monday 29 April 2013 03:33 PM, Kishon Vijay Abraham I wrote: Added a generic PHY framework that provides a set of APIs for the PHY drivers to create/destroy a PHY and APIs for the PHY users to obtain a reference to the

[PATCH v2 00/17] Equivalent of g_ether.ko with configfs

2013-05-28 Thread Andrzej Pietrasiewicz
Here I present the conversion of everything that is required to provide the equivalent of g_ether.ko with configfs. A branch will be available here (from 28th May 2013, afternoon UTC): git://git.infradead.org/users/kmpark/linux-samsung usb-gadget-configfs v1..v2: - fixed compilation error if

[PATCH v2 01/17] usb/gadget: u_ether: allow getting binary-form host address

2013-05-28 Thread Andrzej Pietrasiewicz
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/usb/gadget/u_ether.c |9 + drivers/usb/gadget/u_ether.h | 10 ++ 2 files changed, 19 insertions(+), 0 deletions(-) diff --git

[PATCH v2 06/17] usb/gadget: f_eem: use usb_gstrings_attach

2013-05-28 Thread Andrzej Pietrasiewicz
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/usb/gadget/f_eem.c | 17 ++--- 1 files changed, 6 insertions(+), 11 deletions(-) diff --git a/drivers/usb/gadget/f_eem.c b/drivers/usb/gadget/f_eem.c index

[PATCH v2 03/17] usb/gadget: f_eem: convert to new function interface with backward compatibility

2013-05-28 Thread Andrzej Pietrasiewicz
Converting eem to the new function interface requires converting the USB eem's function code and its users. This patch converts the f_eem.c to the new function interface. The file is now compiled into a separate usb_f_eem.ko module. The old function interface is provided by means of a preprocessor

[PATCH v2 02/17] usb/gadget: ether: convert to new interface of f_ecm

2013-05-28 Thread Andrzej Pietrasiewicz
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/usb/gadget/Kconfig |1 + drivers/usb/gadget/ether.c | 73 2 files changed, 61 insertions(+), 13 deletions(-) diff --git

[PATCH v2 05/17] usb/gadget: f_eem: remove compatibility layer

2013-05-28 Thread Andrzej Pietrasiewicz
There are no old function interface users left, so the old interface can be removed. Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/usb/gadget/f_eem.c | 59 --

[PATCH v2 08/17] usb/gadget: multi: Remove unused include

2013-05-28 Thread Andrzej Pietrasiewicz
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/usb/gadget/multi.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/usb/gadget/multi.c b/drivers/usb/gadget/multi.c index f9e07c0..66f756f

[PATCH v2 07/17] usb/gadget: f_eem: add configfs support

2013-05-28 Thread Andrzej Pietrasiewicz
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- Documentation/ABI/testing/configfs-usb-gadget-eem | 14 ++ drivers/usb/gadget/Kconfig| 15 ++ drivers/usb/gadget/f_eem.c

[PATCH v2 11/17] usb/gadget: f_subset: use usb_gstrings_attach

2013-05-28 Thread Andrzej Pietrasiewicz
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/usb/gadget/f_subset.c | 18 -- 1 files changed, 8 insertions(+), 10 deletions(-) diff --git a/drivers/usb/gadget/f_subset.c

[PATCH v2 10/17] usb/gadget: ether: convert to new interface of f_subset

2013-05-28 Thread Andrzej Pietrasiewicz
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/usb/gadget/Kconfig |1 + drivers/usb/gadget/ether.c | 104 2 files changed, 58 insertions(+), 47 deletions(-) diff --git

[PATCH v2 12/17] usb/gadget: f_subset: add configfs support

2013-05-28 Thread Andrzej Pietrasiewicz
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- .../ABI/testing/configfs-usb-gadget-subset | 14 ++ drivers/usb/gadget/Kconfig | 10 drivers/usb/gadget/f_subset.c

[PATCH v2 14/17] usb/gadget: ether: convert to new interface of f_rndis

2013-05-28 Thread Andrzej Pietrasiewicz
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/usb/gadget/Kconfig |1 + drivers/usb/gadget/ether.c | 56 ++-- 2 files changed, 34 insertions(+), 23 deletions(-) diff --git

[PATCH v2 15/17] usb/gadget: rndis: init exit rndis at module load/unload

2013-05-28 Thread Andrzej Pietrasiewicz
This is required in preparation for using usb_gstrings_attach. The rndis initialization so far has been performed on the first occurence of rndis_bind(), but the condition to check it (first or not first) was borrowed from strings handling. Signed-off-by: Andrzej Pietrasiewicz

[PATCH v2 17/17] usb/gadget: f_rndis: add configfs support

2013-05-28 Thread Andrzej Pietrasiewicz
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- .../ABI/testing/configfs-usb-gadget-rndis | 14 ++ drivers/usb/gadget/Kconfig | 16 ++ drivers/usb/gadget/f_rndis.c

[PATCH v2 04/17] usb/gadget: ether: convert to new interface of f_eem

2013-05-28 Thread Andrzej Pietrasiewicz
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/usb/gadget/Kconfig |1 + drivers/usb/gadget/ether.c | 54 --- 2 files changed, 46 insertions(+), 9 deletions(-) diff --git

[PATCH v2 09/17] usb/gadget: f_subset: convert to new function interface with backward compatibility

2013-05-28 Thread Andrzej Pietrasiewicz
Converting ecm subset to the new function interface requires converting the USB subset's function code and its users. This patch converts the f_subset.c to the new function interface. The file is now compiled into a separate usb_f_subset.ko module. The old function interface is provided by means

[PATCH v2 13/17] usb/gadget: f_rndis: convert to new function interface with backward compatibility

2013-05-28 Thread Andrzej Pietrasiewicz
Converting rndis to the new function interface requires converting the USB rndis' function code and its users. This patch converts the f_rndis.c to the new function interface. The file is now compiled into a separate usb_f_rndis.ko module. The old function interface is provided by means of a

[PATCH v2 16/17] usb/gadget: f_rndis: use usb_gstrings_attach

2013-05-28 Thread Andrzej Pietrasiewicz
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/usb/gadget/f_rndis.c | 22 -- 1 files changed, 8 insertions(+), 14 deletions(-) diff --git a/drivers/usb/gadget/f_rndis.c

[PATCH] usb: dwc3: cleanup DWC3_DCTL_LSFTRST bit

2013-05-28 Thread Huang Rui
This bit is removed and set as reserved in 2.50a spec. Signed-off-by: Huang Rui ray.hu...@amd.com --- drivers/usb/dwc3/core.h |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h index b69d322..4e6e0f9 100644 --- a/drivers/usb/dwc3/core.h +++

Re: [PATCH] xhci: Add BayTrail to list of Intel switchable hosts

2013-05-28 Thread Heikki Krogerus
Hi Sarah, On Fri, May 24, 2013 at 09:55:25AM -0700, Sarah Sharp wrote: At this point the port switchover quirk is getting unwieldy. I know of at least two more platforms that will need the switchover quirk, and it's silly to keep adding them to the list. Heikki, can you change the code to

[PATCH v2] usb: musb: fix clock naming

2013-05-28 Thread yegorslists
From: Yegor Yefremov yegorsli...@googlemail.com 'ick' was changed to 'hsotgusb_ick' 'fck' was changed to 'hsotgusb_fck' Signed-off-by: Jan Luebbe j...@pengutronix.de Signed-off-by: Yegor Yefremov yegorsli...@googlemail.com --- v2: CC linux-usb mailing list drivers/usb/musb/am35x.c |4 ++--

Re: [PATCH] ARM: OMAP4: USB_EHCI_HCD needs USB_PHY and NOP_USB_XCEIV

2013-05-28 Thread Roger Quadros
On 05/27/2013 09:23 PM, Arnd Bergmann wrote: On Saturday 25 May 2013, Adrien Vergé wrote: On OMAP4 platforms, EHCI HCD needs the physical layer signalling activated, along with the NOP USB Transceiver driver. Otherwise, the kernel boots without registering any USB device. This does not

Re: [PATCH] ARM: OMAP4: USB_EHCI_HCD needs USB_PHY and NOP_USB_XCEIV

2013-05-28 Thread Arnd Bergmann
On Tuesday 28 May 2013 11:14:37 Roger Quadros wrote: depends on USB_ARCH_HAS_EHCI + select USB_PHY if ARCH_OMAP4 + select NOP_USB_XCEIV if ARCH_OMAP4 ---help--- The Enhanced Host Controller Interface (EHCI) is standard for USB 2.0 high

Re: Linux USB file storage gadget with new UDC

2013-05-28 Thread victor yeo
Hi, Yes, it is silly. The hardware interrupt is not being generated for every SCSI command received, so the driver has to poll. I put the polling code in a thread, and this dilemma is fixed. Are you sure about this? If it is correct, you should _fix_ the interrupt problem. Don't try to

[PATCH] usb: phy: samsung: Add support for EXYNOS4210

2013-05-28 Thread Jingoo Han
Add support for EXYNOS4210 that includes USB EHCI/OHCI. Previous PHY initialization code is not correct; thus, it is modifed to support EXYNOS4210 PHY. Also, after common clock framework for Samsung is added, clock name is defined as 'usb_device'. Signed-off-by: Jingoo Han jg1@samsung.com ---

Re: [PATCH] ARM: OMAP4: USB_EHCI_HCD needs USB_PHY and NOP_USB_XCEIV

2013-05-28 Thread Roger Quadros
On 05/28/2013 11:40 AM, Arnd Bergmann wrote: On Tuesday 28 May 2013 11:14:37 Roger Quadros wrote: depends on USB_ARCH_HAS_EHCI + select USB_PHY if ARCH_OMAP4 + select NOP_USB_XCEIV if ARCH_OMAP4 ---help--- The Enhanced Host Controller Interface (EHCI) is

[PATCH] usb: serial: dump small buffers with help of %*ph

2013-05-28 Thread Andy Shevchenko
There is a specifier we may use to dump small buffers. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/usb/serial/keyspan.c | 13 ++--- drivers/usb/serial/pl2303.c | 6 ++ 2 files changed, 4 insertions(+), 15 deletions(-) diff --git

[PATCH] uwb: use %*ph specifier to dump buffer

2013-05-28 Thread Andy Shevchenko
In kernel we have nice specifier %*ph to dump small buffers. Let's use it. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/uwb/est.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/uwb/est.c b/drivers/uwb/est.c index

[PATCH] net/usb/kalmia: use %*phC to dump small buffers

2013-05-28 Thread Andy Shevchenko
Instead of dereferencing pointer and put values on stack we could use nice %*phC specifier. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/net/usb/kalmia.c | 46 -- 1 file changed, 16 insertions(+), 30 deletions(-) diff

Re: [PATCH v2] usb: omap2430: fix memleak in err case

2013-05-28 Thread Libo Chen
ping... On 2013/5/22 11:30, Libo Chen wrote: when omap_get_control_dev faild, we should release related platform_device * Changelog from v1: * fix spell: s/fail/fails/, s/relational/related/ , thank Sergei sergei.shtyl...@cogentembedded.com Signed-off-by: Libo Chen

[PATCH V8 0/3] USB: OHCI: Start splitting up the driver

2013-05-28 Thread Manjunath Goudar
This series of patches begins the process of splitting ohci-hcd up into a core library module and independent pci driver modules. Patch 1/3 prepares the way by exporting a few functions from ohci-hcd and adding a new mechanism for platform-specific drivers to initialize their hc_driver

[PATCH V8 1/3] USB: OHCI: prepare to make ohci-hcd a library module

2013-05-28 Thread Manjunath Goudar
This patch prepares ohci-hcd for being split up into a core library and separate platform driver modules. A generic ohci_hc_driver structure is created, containing all the standard values, and a new mechanism is added whereby a driver module can specify a set of overrides to those values. In

[PATCH V8 2/3] USB: OHCI: Generic changes to make ohci-pci a separate driver

2013-05-28 Thread Manjunath Goudar
Note that this changes is part of separating the ohci pci host controller driver from ohci-hcd host code. This contains : -Moved sb800_prefetch() function from ohci-pci.c to pci-quirks.c file and EXPORTed, this is part of the effort to move the ohci pci related code to generic pci

[PATCH V8 3/3] USB: OHCI: make ohci-pci a separate driver

2013-05-28 Thread Manjunath Goudar
This patch splits the PCI portion of ohci-hcd out into its own separate driver module, called ohci-pci. The major point of difficulty lies in ohci-pci's many vendor- and device-specific workarounds. Some of them have to be applied before calling ohci_start() some after, which necessitates a fair

Re: [PATCH] ARM: OMAP4: USB_EHCI_HCD needs USB_PHY and NOP_USB_XCEIV

2013-05-28 Thread Adrien Vergé
Dear Arnd and Roger, thank you for your answers. 2013/5/28 Roger Quadros rog...@ti.com Selecting NOP_USB_XCEIV is wrong as it in turn depends on USB_PHY. I'm not for depends as it would hide USB_EHCI_HCD_OMAP in menuconfig. I'm for explicitly selecting both, as it makes the user's life much

Re: [regression] USB: EHCI: changes related to qh_refresh()

2013-05-28 Thread Alan Stern
On Mon, 27 May 2013, Oleksij Rempel wrote: Hmmm. Maybe we can narrow this down. What happens if you apply only parts of the commit? For example, on top of c97041a, try applying only the hunks that change ehci-sched.c. If that works, try applying also only the last hunk affecting

Re: [PATCH] ARM: OMAP4: USB_EHCI_HCD needs USB_PHY and NOP_USB_XCEIV

2013-05-28 Thread Roger Quadros
Adrien, On 05/28/2013 04:30 PM, Adrien Vergé wrote: Dear Arnd and Roger, thank you for your answers. 2013/5/28 Roger Quadros rog...@ti.com Selecting NOP_USB_XCEIV is wrong as it in turn depends on USB_PHY. I'm not for depends as it would hide USB_EHCI_HCD_OMAP in menuconfig. I'm for

Re: [PATCH V8 3/3] USB: OHCI: make ohci-pci a separate driver

2013-05-28 Thread Alan Stern
On Tue, 28 May 2013, Manjunath Goudar wrote: This patch splits the PCI portion of ohci-hcd out into its own separate driver module, called ohci-pci. The major point of difficulty lies in ohci-pci's many vendor- and device-specific workarounds. Some of them have to be applied before

Re: Linux USB file storage gadget with new UDC

2013-05-28 Thread Alan Stern
On Tue, 28 May 2013, victor yeo wrote: Now the UDC driver is working on both Linux and Windows host, meaning the read/write operation is ok. I still use the polling method, because waiting for interrupt is not reliable. Why aren't the interrupts reliable? Is this a known erratum for your

Re: [PATCH v2] usb: omap2430: fix memleak in err case

2013-05-28 Thread Andy Shevchenko
No go. Check the 4b7e450fb5cefb5865c77999a675330206ab3b8a And update you tree, please. -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCh V10 04/12] usb: ehci: ehci-mv: use PHY driver for ehci

2013-05-28 Thread Felipe Balbi
Hi, On Mon, May 13, 2013 at 10:13:44AM -0400, Alan Stern wrote: On Mon, 13 May 2013, Chao Xie wrote: Originaly, ehci driver will call the callbacks in platform data for PHY initialization and shut down. With PHY driver, it will call the APIs provided by PHY driver for PHY

Re: [PATCH 20/39] usb: musb: ux500: move channel number knowledge into the driver

2013-05-28 Thread Felipe Balbi
Hi, On Wed, May 15, 2013 at 07:18:01PM +0200, Linus Walleij wrote: On Wed, May 15, 2013 at 11:51 AM, Lee Jones lee.jo...@linaro.org wrote: For all ux500 based platforms the maximum number of end-points are used. Move this knowledge into the driver so we can relinquish the burden from

Re: MUSB multiplatform work?

2013-05-28 Thread Felipe Balbi
Hi, On Mon, May 27, 2013 at 05:02:09PM +0200, Arnd Bergmann wrote: Hi Felipe, We've gone through remaining work items for getting the ARM kernel to full multiplatform support again, and MUSB came up. I'm sure you have your own thoughts on this, but I'd like to know if there is already a

Re: [PATCH 20/39] usb: musb: ux500: move channel number knowledge into the driver

2013-05-28 Thread Lee Jones
Hi Felipe For all ux500 based platforms the maximum number of end-points are used. Move this knowledge into the driver so we can relinquish the burden from platform data. This also removes quite a bit of complexity from the driver and will aid us when we come to enable the driver for

Re: [GIT PULL] ARM: tegra: DT-related fixes needed by the USB tree

2013-05-28 Thread Stephen Warren
On 05/17/2013 04:50 PM, Stephen Warren wrote: Felipe, (and Alan, Greg), These are the changes from the Tegra tree that need to be merged before the Tegra USB driver patches 4-8 from Venu can be applied. Recall that we had previously agreed on this approach for v3.9, but Venu's patches

[PATCH v2] usb: dwc3: gadget: free trb pool only from epnum 2

2013-05-28 Thread Felipe Balbi
From: George Cherian george.cher...@ti.com we never allocate a TRB pool for physical endpoints 0 and 1 so trying to free it (a invalid TRB pool pointer) will lead us in a warning while removing dwc3.ko module. In order to fix the situation, all we have to do is skip dwc3_free_trb_pool() for

Re: [PATCH] usb: dwc3: cleanup DWC3_DCTL_LSFTRST bit

2013-05-28 Thread Felipe Balbi
On Tue, May 28, 2013 at 03:42:50PM +0800, Huang Rui wrote: This bit is removed and set as reserved in 2.50a spec. Signed-off-by: Huang Rui ray.hu...@amd.com so ? This driver also works on older versions of the core. What you should do is, perhaps, add a comment saying that this bit shouldn't

Re: [PATCH 3/3] usb: dwc3: omap Modify dwc3_omap_readl/writel with offsets

2013-05-28 Thread Felipe Balbi
Hi, On Mon, May 27, 2013 at 01:32:57PM +0530, George Cherian wrote: This patch modifies dwc3_omap_readl/writel calls to accomodate both OMAP5 and AM437x reg maps (It uses the cached register offsets). Also renames OMAP5 IRQ1 as IRQMISC, IRQ1 bits as IRQMISC bits. Signed-off-by: George

Re: [PATCH] usb: phy: samsung: Add support for EXYNOS4210

2013-05-28 Thread Felipe Balbi
On Tue, May 28, 2013 at 06:04:07PM +0900, Jingoo Han wrote: @@ -165,6 +174,18 @@ static void samsung_usb2phy_enable(struct samsung_usbphy *sphy) u32 phyclk; u32 rstcon; + switch (sphy-drv_data-cpu_type) { + case TYPE_EXYNOS4210: +

Re: [PATCH 0/3] palmas usb driver

2013-05-28 Thread Felipe Balbi
On Fri, May 24, 2013 at 08:01:33PM +0530, Kishon Vijay Abraham I wrote: This patch series adds driver for palmas usb which is used to detect attach/detach events of usb device and usb host. [PATCH v5 2/3] extcon: Palmas Extcon Driver which was sent previously is added in this patch series

Re: [PATCH v2] usb: musb: fix clock naming

2013-05-28 Thread Felipe Balbi
On Tue, May 28, 2013 at 09:21:01AM +0200, yegorsli...@googlemail.com wrote: From: Yegor Yefremov yegorsli...@googlemail.com 'ick' was changed to 'hsotgusb_ick' 'fck' was changed to 'hsotgusb_fck' Signed-off-by: Jan Luebbe j...@pengutronix.de Signed-off-by: Yegor Yefremov

Re: [PATCH v2] usb: omap2430: fix memleak in err case

2013-05-28 Thread Sergei Shtylyov
Hello. On 22-05-2013 7:30, Libo Chen wrote: when omap_get_control_dev faild, we should release related platform_device * Changelog from v1: * fix spell: s/fail/fails/, s/relational/related/ , thank Sergei sergei.shtyl...@cogentembedded.com It seems you've actually replaced

Re: [PATCH v1 0/9] adding dual instance and usb-phy support for am335x platform

2013-05-28 Thread Felipe Balbi
Hi, On Thu, May 23, 2013 at 11:31:19AM +0530, Ravi Babu wrote: This patch set series - adds dual musb instances support for am335x platform - adds phy-dsps-usb driver based on TI's gs70 driver - adds DT bindings for am33xx usb-phy - removed references to

Re: [GIT PULL] ARM: tegra: DT-related fixes needed by the USB tree

2013-05-28 Thread Felipe Balbi
On Tue, May 28, 2013 at 11:15:25AM -0600, Stephen Warren wrote: On 05/17/2013 04:50 PM, Stephen Warren wrote: Felipe, (and Alan, Greg), These are the changes from the Tegra tree that need to be merged before the Tegra USB driver patches 4-8 from Venu can be applied. Recall that we had

Re: xhci_hcd and Canon Lide 110 not playing well together

2013-05-28 Thread Holger Hans Peter Freyther
On Mon, Oct 22, 2012 at 10:01:04AM -0700, Sarah Sharp wrote: Good Evening, Maybe Sarah can give you some pointers on where to look next. I've asked for a physical bus trace from one of our QA folks with the same scanner. I think that will shed some light on whether this is a host-side

[PATCH] USB: revert periodic scheduling bugfix

2013-05-28 Thread Alan Stern
This patch reverts commit 3e619d04159be54b3daa0b7036b0ce9e067f4b5d (USB: EHCI: fix bug in scheduling periodic split transfers). The commit was valid -- it fixed a real bug -- but the periodic scheduler in ehci-hcd is in such bad shape (especially the part that handles split transactions) that

Re: [PATCH] net/usb/kalmia: use %*phC to dump small buffers

2013-05-28 Thread Sergei Shtylyov
Hello. On 28-05-2013 13:56, Andy Shevchenko wrote: Instead of dereferencing pointer and put values on stack we could use nice %*phC specifier. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/net/usb/kalmia.c | 46 --

Re: [PATCH] net/usb/kalmia: use %*phC to dump small buffers

2013-05-28 Thread Andy Shevchenko
On Tue, May 28, 2013 at 9:14 PM, Sergei Shtylyov sergei.shtyl...@cogentembedded.com wrote: On 28-05-2013 13:56, Andy Shevchenko wrote: @@ -263,32 +260,24 @@ kalmia_rx_fixup(struct usbnet *dev, struct sk_buff *skb) sizeof(EXPECTED_UNKNOWN_HEADER_1)) || !memcmp(

[PATCH v2 1/2] usb: dwc3: pci: PHY should be deleted later than dwc3 core

2013-05-28 Thread Felipe Balbi
From: Peter Chen peter.c...@freescale.com If the glue layer is removed first (core layer later), it deletes the phy device first, then the core device. But at core's removal, it still uses PHY's resources, it may cause kernel's oops. It is much like the problem Paul Zimmerman reported at:

[PATCH v2 2/2] usb: dwc3: exynos: PHY should be deleted later than dwc3 core

2013-05-28 Thread Felipe Balbi
From: Peter Chen peter.c...@freescale.com If the glue layer is removed first (core layer later), it deletes the phy device first, then the core device. But at core's removal, it still uses PHY's resources, it may cause kernel's oops. It is much like the problem Paul Zimmerman reported at:

Re: [PATCH 2/2] usb-serial: Moxa UPORT 12XX/14XX/16XX driver

2013-05-28 Thread Andrew Lunn
On Sun, May 26, 2013 at 06:04:24PM +0200, Johan Hovold wrote: On Sun, May 26, 2013 at 01:00:51PM +0200, Andrew Lunn wrote: +/* + * mxuport_write_room + * + * Return how much space is available in the buffer. + */ +static int mxuport_write_room(struct tty_struct *tty) +{ + struct

RE: [PATCH] staging: dwc2: fix value of dma_mask

2013-05-28 Thread Paul Zimmerman
From: Matthijs Kooijman [mailto:matth...@stdin.nl] Sent: Friday, May 24, 2013 11:47 PM On Fri, May 24, 2013 at 04:27:56PM -0700, Paul Zimmerman wrote: Passing the value DMA_BIT_MASK(31) to dma_set_mask() causes the dwc2-pci driver to sometimes fail (cannot enumerate the connected

Re: [PATCH V8 0/3] USB: OHCI: Start splitting up the driver

2013-05-28 Thread Arnd Bergmann
On Tuesday 28 May 2013, Manjunath Goudar wrote: This series of patches begins the process of splitting ohci-hcd up into a core library module and independent pci driver modules. Seems to basically work now, but I'm getting run-time errors after loading the driver, with patch 1/3 applied:

Re: [PATCH] usb: xhci: Disable runtime PM suspend for quirky controllers.

2013-05-28 Thread Sarah Sharp
On Sat, May 25, 2013 at 09:57:57AM -0700, Shawn Nematbakhsh wrote: Hi Sarah and Alan, Thanks for the comments. I will make the following revisions: 1. Call pm_runtime_get_noresume only when the first device is connected, and call pm_runtime_put when the last device is disconnected. 2.

Re: [PATCH 2/2] usb-serial: Moxa UPORT 12XX/14XX/16XX driver

2013-05-28 Thread Johan Hovold
On Tue, May 28, 2013 at 09:41:08PM +0200, Andrew Lunn wrote: On Sun, May 26, 2013 at 06:04:24PM +0200, Johan Hovold wrote: On Sun, May 26, 2013 at 01:00:51PM +0200, Andrew Lunn wrote: +/* + * mxuport_write_room + * + * Return how much space is available in the buffer. + */

[GIT PULL] USB patches

2013-05-28 Thread Felipe Balbi
Hi Greg, Here's a new set of 4 fixes for v3.10-rc. Let me know if you want anything to be changed. cheers The following changes since commit e4aa937ec75df0eea0bee03bffa3303ad36c986b: Linux 3.10-rc3 (2013-05-26 16:00:47 -0700) are available in the git repository at:

Re: [PATCH 2/2] usb-serial: Moxa UPORT 12XX/14XX/16XX driver

2013-05-28 Thread Andrew Lunn
On Tue, May 28, 2013 at 11:08:54PM +0200, Johan Hovold wrote: On Tue, May 28, 2013 at 09:41:08PM +0200, Andrew Lunn wrote: On Sun, May 26, 2013 at 06:04:24PM +0200, Johan Hovold wrote: On Sun, May 26, 2013 at 01:00:51PM +0200, Andrew Lunn wrote: +/* + * mxuport_write_room + *

Re: [PATCH] usb: xhci: Disable runtime PM suspend for quirky controllers.

2013-05-28 Thread Julius Werner
The policy we want to achieve is to disable runtime PM iff there is a device connected that doesn't have persist_enabled or a reset_resume() handler and whose parent/root hub resets on resume, right? So couldn't we remove the HCD-specific XHCI_RESET_ON_RESUME and set the (existing) generic

Re: [PATCH v6 1/9] drivers: phy: add generic PHY framework

2013-05-28 Thread Sylwester Nawrocki
Hi Kishon, On 04/29/2013 12:03 PM, Kishon Vijay Abraham I wrote: The PHY framework provides a set of APIs for the PHY drivers to create/destroy a PHY and APIs for the PHY users to obtain a reference to the PHY with or without using phandle. For dt-boot, the PHY drivers should also register *PHY

USB3 SSD/HD device file disappears after eject

2013-05-28 Thread Grant
I just got one of these: http://www.newegg.com/Product/Product.aspx?Item=N82E16820208913 It seems to work fine except I get the following after ejecting it in Thunar: sd 8:0:0:0: [sdb] Synchronizing SCSI cache sd 8:0:0:0: Device offlined - not ready after error recovery The only way I've found

Re: USB3 SSD/HD device file disappears after eject

2013-05-28 Thread Greg KH
On Tue, May 28, 2013 at 05:27:22PM -0700, Grant wrote: I just got one of these: http://www.newegg.com/Product/Product.aspx?Item=N82E16820208913 It seems to work fine except I get the following after ejecting it in Thunar: sd 8:0:0:0: [sdb] Synchronizing SCSI cache sd 8:0:0:0: Device

Re: [GIT PULL] USB patches

2013-05-28 Thread Greg KH
On Wed, May 29, 2013 at 12:08:56AM +0300, Felipe Balbi wrote: Hi Greg, Here's a new set of 4 fixes for v3.10-rc. Let me know if you want anything to be changed. cheers The following changes since commit e4aa937ec75df0eea0bee03bffa3303ad36c986b: Linux 3.10-rc3 (2013-05-26 16:00:47

Re: [Pull Request] xhci: Misc bug fixes for 3.10

2013-05-28 Thread Greg Kroah-Hartman
On Fri, May 24, 2013 at 04:07:51PM -0700, Sarah Sharp wrote: The following changes since commit 2a0ebf80aa95cc758d4725f74a7016e992606a39: USB: cxacru: potential underflow in cxacru_cm_get_array() (2013-05-20 11:35:47 -0700) are available in the git repository at:

Re: [RFC 0/6] xHCI and USB security bug fixes

2013-05-28 Thread Greg Kroah-Hartman
On Fri, May 24, 2013 at 05:42:52PM -0700, Sarah Sharp wrote: This patchset address some (but not all) of the security issues found with the Klockwork static analysis tool. I have not reviewed these in detail to see if these could be used by attackers, so someone with more security experience

Re: [RFC 1/6] xhci: Remove BUG_ON() in xhci_alloc_container_ctx.

2013-05-28 Thread Greg Kroah-Hartman
On Fri, May 24, 2013 at 05:42:54PM -0700, Sarah Sharp wrote: It's horrible coding style to panic the kernel when someone passes you an argument value you didn't expect. I agree, but why is this a stable issue? Who can pass in a bad pointer? Can't we just drop the check entirely? thanks, greg

Re: [RFC 2/6] xhci: Remove BUG_ON in xhci_get_input_control_ctx.

2013-05-28 Thread Greg Kroah-Hartman
On Fri, May 24, 2013 at 05:42:56PM -0700, Sarah Sharp wrote: Fail gracefully, instead of causing the kernel to panic, if the input control context doesn't have the right type (XHCI_CTX_TYPE_INPUT). Push finding the pointer to the input control context up into functions that can fail. This

Re: [RFC 2/6] xhci: Remove BUG_ON in xhci_get_input_control_ctx.

2013-05-28 Thread Greg Kroah-Hartman
On Fri, May 24, 2013 at 05:42:56PM -0700, Sarah Sharp wrote: Fail gracefully, instead of causing the kernel to panic, if the input control context doesn't have the right type (XHCI_CTX_TYPE_INPUT). Push finding the pointer to the input control context up into functions that can fail. I fail

Re: [RFC 3/6] xhci: Remove BUG in xhci_setup_addressable_virt_dev

2013-05-28 Thread Greg Kroah-Hartman
On Fri, May 24, 2013 at 05:42:59PM -0700, Sarah Sharp wrote: From: Mathias Nyman mathias.ny...@linux.intel.com We may have more speed types in the future, so fail gracefully, rather than causing the kernel to panic. BUG() was called if the device speed was unknown when setting max packet

Re: [RFC 4/6] xhci: remove BUG() in xhci_get_endpoint_type()

2013-05-28 Thread Greg Kroah-Hartman
On Fri, May 24, 2013 at 05:43:01PM -0700, Sarah Sharp wrote: From: Mathias Nyman mathias.ny...@linux.intel.com If the endpoint type is unknown, set it to 0 and fail gracefully instead of causing a kernel panic. How can the endpoint type be unknown? thanks, greg k-h -- To unsubscribe from

Re: [PATCH 2/4] chipidea: ci13xxx_imx: Remove reg_vbus

2013-05-28 Thread Shawn Guo
On Mon, May 27, 2013 at 09:51:28AM -0300, Fabio Estevam wrote: There is no need to keep a 'reg_vbus' indirection, so get rid of it. The motivation for doing this change is that in the case of error, the current code only sets the local reg_vbus to NULL instead of updating the private

Re: [PATCH v2] usb: omap2430: fix memleak in err case

2013-05-28 Thread Libo Chen
On 2013/5/29 1:40, Sergei Shtylyov wrote: Hello. On 22-05-2013 7:30, Libo Chen wrote: when omap_get_control_dev faild, we should release related platform_device * Changelog from v1: * fix spell: s/fail/fails/, s/relational/related/ , thank Sergei sergei.shtyl...@cogentembedded.com

Re: USB3 SSD/HD device file disappears after eject

2013-05-28 Thread Grant
I just got one of these: http://www.newegg.com/Product/Product.aspx?Item=N82E16820208913 It seems to work fine except I get the following after ejecting it in Thunar: sd 8:0:0:0: [sdb] Synchronizing SCSI cache sd 8:0:0:0: Device offlined - not ready after error recovery That's to be

RE: [PATCH v1 0/9] adding dual instance and usb-phy support for am335x platform

2013-05-28 Thread B, Ravi
Felipe Subject: Re: [PATCH v1 0/9] adding dual instance and usb-phy support for am335x platform Hi, On Thu, May 23, 2013 at 11:31:19AM +0530, Ravi Babu wrote: This patch set series - adds dual musb instances support for am335x platform - adds phy-dsps-usb driver based on

Re: [PATCh V10 04/12] usb: ehci: ehci-mv: use PHY driver for ehci

2013-05-28 Thread Chao Xie
On Wed, May 29, 2013 at 12:24 AM, Felipe Balbi ba...@ti.com wrote: Hi, On Mon, May 13, 2013 at 10:13:44AM -0400, Alan Stern wrote: On Mon, 13 May 2013, Chao Xie wrote: Originaly, ehci driver will call the callbacks in platform data for PHY initialization and shut down. With PHY driver,

Re: [PATCH v6 1/9] drivers: phy: add generic PHY framework

2013-05-28 Thread Kishon Vijay Abraham I
Hi, On Wednesday 29 May 2013 04:07 AM, Sylwester Nawrocki wrote: Hi Kishon, On 04/29/2013 12:03 PM, Kishon Vijay Abraham I wrote: The PHY framework provides a set of APIs for the PHY drivers to create/destroy a PHY and APIs for the PHY users to obtain a reference to the PHY with or without