Re: Linux USB file storage gadget with new UDC

2013-06-24 Thread victor yeo
Hi, The problem is in UDC driver. i made the change, it is ok now. Good. I noticed that the usb_ep_set_wedge routine still isn't working right. You might try to fix that. Alan Stern Ok, is the usb_ep_set_wedge routine not working? I can't see that in the log file. Now, in USB 2.0 CV

Re: [PATCH v7 7/9] usb: musb: omap2430: use the new generic PHY framework

2013-06-24 Thread Felipe Balbi
Hi, On Mon, Jun 24, 2013 at 11:01:56AM +0530, Kishon Vijay Abraham I wrote: @@ -397,9 +407,10 @@ static int omap2430_musb_init(struct musb *musb) if (glue-status != OMAP_MUSB_UNKNOWN) omap_musb_set_mailbox(glue); - usb_phy_init(musb-xceiv); + phy_init(musb-phy);

Re: [PATCH v7 1/9] drivers: phy: add generic PHY framework

2013-06-24 Thread Kishon Vijay Abraham I
On Wednesday 19 June 2013 02:52 AM, Sylwester Nawrocki wrote: Hi Kishon, I've noticed there is a little inconsistency between the code and documentation. On 06/13/2013 10:43 AM, Kishon Vijay Abraham I wrote: +3. Creating the PHY + +The PHY driver should create the PHY in order for other

Re: Chipidea usb otg support for IMX/MXS (device functionality)

2013-06-24 Thread Shawn Guo
On Mon, Jun 24, 2013 at 01:37:59AM +, Chen Peter-B29397 wrote: Add shawn. Marek, have you tried mx23 evk? Shawn, marek reported the udc function at mx23 works abnormal, but it works good at mx28. Have you tried mx23 udc recently? Sorry, I never tried usb on my imx23-evk due to some

Re: [RESEND PATCH v2 1/1] usb: fix build error without CONFIG_USB_PHY

2013-06-24 Thread Alexander Shishkin
Peter Chen peter.c...@freescale.com writes: on i386: drivers/built-in.o: In function `ci_hdrc_probe': core.c:(.text+0x20446b): undefined reference to `of_usb_get_phy_mode' Signed-off-by: Peter Chen peter.c...@freescale.com Reported-by: Randy Dunlap rdun...@infradead.org Acked-by: Randy

[PATCH v2 0/4] USB: HCD/EHCI: giveback of URB in tasklet context

2013-06-24 Thread Ming Lei
Hi, The patchset supports to run giveback of URB in tasklet context, so that DMA unmapping/mapping on transfer buffer and compelte() callback can be run with interrupt enabled, then time of HCD interrupt handler(IRQs disabled time) can be saved much. Also this approach may simplify HCD since HCD

[PATCH v2 1/4] USB: HCD: support giveback of URB in tasklet context

2013-06-24 Thread Ming Lei
This patch implements the mechanism of giveback of URB in tasklet context, so that hardware interrupt handling time for usb host controller can be saved much, and HCD interrupt handling can be simplified. Motivations: 1), on some arch(such as ARM), DMA mapping/unmapping is a bit time-consuming,

[PATCH v2 4/4] USB: EHCI: support running URB giveback in tasklet context

2013-06-24 Thread Ming Lei
All 4 transfer types can work well on EHCI HCD after switching to run URB giveback in tasklet context, so mark all HCD drivers to support it. At the same time, don't release ehci-lock during URB giveback, and remove the check on HCD_BH in ehci_disable_event(). From below test results on 3

[PATCH v2 3/4] USB: EHCI: improve interrupt qh unlink

2013-06-24 Thread Ming Lei
Given interrupt URB will be resubmitted from tasklet context which is scheduled by ehci hardware interrupt handler, and commonly only one interrupt URB is scheduled on qh, so the qh may be unlinked immediately once qh_completions() returns from ehci_irq(), then the intr URB to be resubmitted in

[PATCH v2 2/4] USB: URB documentation: claim complete() will be run with IRQs enabled

2013-06-24 Thread Ming Lei
There is no good reason to run complete() in hard interrupt disabled context. After switch to run complete() in tasklet, we will enable local IRQs when calling complete() since we can do it at that time. Even though we still disable IRQs now when calling complete() in tasklet, the URB

Re: [v2] usb: UHCI: fix pkt size in TD for a non-aligned sg element

2013-06-24 Thread Konstantin Filatov
On 06/23/2013 07:05 PM, Alan Stern wrote: That's why, if the check is checked, I feel it should be added to each HCD driver separately. Maybe I'm wrong. But before doing anything, you should check with Thomas Pugliese. He recently added SG support to the wireless USB driver. Suppose wireless

Re: [PATCH v2 4/4] USB: EHCI: support running URB giveback in tasklet context

2013-06-24 Thread Oliver Neukum
On Monday 24 June 2013 17:42:05 Ming Lei wrote: All 4 transfer types can work well on EHCI HCD after switching to run URB giveback in tasklet context, so mark all HCD drivers to support it. At the same time, don't release ehci-lock during URB giveback, and remove the check on HCD_BH in

Re: [PATCH v2 3/4] USB: EHCI: improve interrupt qh unlink

2013-06-24 Thread Oliver Neukum
On Monday 24 June 2013 17:42:04 Ming Lei wrote: This patch improves this above situation, and the qh will wait for 5 milliseconds before being unlinked from hardware, if one URB is submitted during the period, the qh is move out of unlink wait list and the interrupt transfer can be scheduled

[PATCH / RFC] qcserial: Add support for ONYX 3G (Alfa network)

2013-06-24 Thread Enrico Mioso
Hello guys! Description: This patch adds support for the ONYX 3G device (first version). Both the Mangementand the Modem interfaces seem to work fine, still can't figure out if the Qualcomm Binary interface does work. And that's why this is also an RFC mail. The device is cheap and small, the

Re: [PATCH v5] usb: dwc3: use extcon fwrk to receive connect/disconnect

2013-06-24 Thread Chanwoo Choi
On 06/21/2013 08:58 PM, Kishon Vijay Abraham I wrote: Modified dwc3-omap to receive connect and disconnect notification using extcon framework. Also did the necessary cleanups required after adapting to extcon framework. Signed-off-by: Kishon Vijay Abraham I kis...@ti.com Acked-by: Felipe

Re: [PATCH v2 3/4] USB: EHCI: improve interrupt qh unlink

2013-06-24 Thread Ming Lei
On Mon, Jun 24, 2013 at 6:28 PM, Oliver Neukum oli...@neukum.org wrote: On Monday 24 June 2013 17:42:04 Ming Lei wrote: This patch improves this above situation, and the qh will wait for 5 milliseconds before being unlinked from hardware, if one URB is submitted during the period, the qh is

Re: [v2] usb: UHCI: fix pkt size in TD for a non-aligned sg element

2013-06-24 Thread Ming Lei
On Mon, Jun 24, 2013 at 6:10 PM, Konstantin Filatov kfila...@parallels.com wrote: On 06/23/2013 07:05 PM, Alan Stern wrote: That's why, if the check is checked, I feel it should be added to each HCD driver separately. Maybe I'm wrong. But before doing anything, you should check with Thomas

Re: [PATCH 20/20] usb: chipidea: drop 13xxx infix

2013-06-24 Thread Alexander Shishkin
Greg KH gre...@linuxfoundation.org writes: On Thu, Jun 13, 2013 at 06:00:04PM +0300, Alexander Shishkin wrote: ci13xxx is bad for at least the following reasons: * people often mistype it * it doesn't add any informational value to the names it's used in * it needlessly attracts mail

Re: [PATCH v2 1/4] USB: HCD: support giveback of URB in tasklet context

2013-06-24 Thread Ming Lei
On Mon, Jun 24, 2013 at 5:42 PM, Ming Lei ming@canonical.com wrote: + +static void init_giveback_urb_bh(struct usb_hcd *hcd) +{ + if (!hcd_giveback_urb_in_bh(hcd)) + return; Sorry, the above check isn't needed, and the below check isn't needed too. I will fix it in

Re: [PATCH v2 3/4] USB: EHCI: improve interrupt qh unlink

2013-06-24 Thread Oliver Neukum
On Monday 24 June 2013 19:16:43 Ming Lei wrote: On Mon, Jun 24, 2013 at 6:28 PM, Oliver Neukum oli...@neukum.org wrote: On Monday 24 June 2013 17:42:04 Ming Lei wrote: This patch improves this above situation, and the qh will wait for 5 milliseconds before being unlinked from hardware, if

Re: [RESEND PATCH v2 1/1] usb: fix build error without CONFIG_USB_PHY

2013-06-24 Thread Felipe Balbi
On Mon, Jun 24, 2013 at 11:15:35AM +0300, Alexander Shishkin wrote: Peter Chen peter.c...@freescale.com writes: on i386: drivers/built-in.o: In function `ci_hdrc_probe': core.c:(.text+0x20446b): undefined reference to `of_usb_get_phy_mode' Signed-off-by: Peter Chen

Re: [PATCH v2 4/4] USB: EHCI: support running URB giveback in tasklet context

2013-06-24 Thread Ming Lei
On Mon, Jun 24, 2013 at 6:24 PM, Oliver Neukum oli...@neukum.org wrote: On Monday 24 June 2013 17:42:05 Ming Lei wrote: All 4 transfer types can work well on EHCI HCD after switching to run URB giveback in tasklet context, so mark all HCD drivers to support it. At the same time, don't

Re: [PATCH v2 4/4] USB: EHCI: support running URB giveback in tasklet context

2013-06-24 Thread Oliver Neukum
On Monday 24 June 2013 20:58:26 Ming Lei wrote: On Mon, Jun 24, 2013 at 6:24 PM, Oliver Neukum oli...@neukum.org wrote: On Monday 24 June 2013 17:42:05 Ming Lei wrote: All 4 transfer types can work well on EHCI HCD after switching to run URB giveback in tasklet context, so mark all HCD

Re: [PATCH v2 4/4] USB: EHCI: support running URB giveback in tasklet context

2013-06-24 Thread Ming Lei
On Mon, Jun 24, 2013 at 9:06 PM, Oliver Neukum oli...@neukum.org wrote: On Monday 24 June 2013 20:58:26 Ming Lei wrote: On Mon, Jun 24, 2013 at 6:24 PM, Oliver Neukum oli...@neukum.org wrote: On Monday 24 June 2013 17:42:05 Ming Lei wrote: All 4 transfer types can work well on EHCI HCD after

Re: Chipidea usb otg support for IMX/MXS (device functionality)

2013-06-24 Thread Marek Vasut
Hello Peter, Hi Peter, Peter, I dunno if you are already aware of it, but the USB peripheral mode hangs on MX233. It's easy to replicate for example if you try to run CDC ethernet over the USB peripheral mode, then telnet into the board and run dmesg . This will

Re: Linux USB file storage gadget with new UDC

2013-06-24 Thread Alan Stern
On Mon, 24 Jun 2013, victor yeo wrote: Hi, The problem is in UDC driver. i made the change, it is ok now. Good. I noticed that the usb_ep_set_wedge routine still isn't working right. You might try to fix that. Alan Stern Ok, is the usb_ep_set_wedge routine not working? I

Re: [PATCH] usb: host: xhci-plat: release mem region while removing module

2013-06-24 Thread Felipe Balbi
On Fri, Jun 21, 2013 at 01:59:08PM +0530, George Cherian wrote: Do a release_mem_region of the hcd resource. Without this the subsequent insertion of module fails in request_mem_region. Signed-off-by: George Cherian george.cher...@ti.com very nice catch. Acked-by: Felipe Balbi ba...@ti.com

Re: [PATCH 8/8] usb: musb: omap2430: make it compile again

2013-06-24 Thread Felipe Balbi
Hi, On Wed, Jun 19, 2013 at 05:38:16PM +0200, Sebastian Andrzej Siewior wrote: it does not compile since 09fc7d (usb: musb: fix incorrect usage of resource pointer). What makes me wonder most is if source of the Tested-by tag :) Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de

From: Konstantin Filatov kfila...@parallels.com

2013-06-24 Thread Denis V. Lunev
with a length that isn't multiply by max pkt size for this endpoint. The commit 689d6eac (USB: UHCI: add native scatter-gather support(v1)) introduced an implementation of scatter-gather list for UHCI. This implementation has a bug when the size of a non-last sg element was not multiply by TD's

[v4] usb: UHCI: fix pkt size in TD for a sg element

2013-06-24 Thread Denis V. Lunev
From: Konstantin Filatov kfila...@parallels.com with a length that isn't multiply by max pkt size for this endpoint. The commit 689d6eac (USB: UHCI: add native scatter-gather support(v1)) introduced an implementation of scatter-gather list for UHCI. This implementation has a bug when the size of

Re: [PATCH 8/8] usb: musb: omap2430: make it compile again

2013-06-24 Thread Sebastian Andrzej Siewior
On 06/24/2013 04:27 PM, Felipe Balbi wrote: Hi, Hi Felipe, which tree are you using as your base ? I don't have that hunk below on my v3.10-rc7. $ git grep -e struct resource drivers/usb/musb/omap2430.c $ echo $? 1 I have here git merge fel/master gusb/usb-linus gusb/usb-next where

Re: From: Konstantin Filatov kfila...@parallels.com

2013-06-24 Thread Felipe Balbi
Hi, On Mon, Jun 24, 2013 at 06:31:07PM +0400, Denis V. Lunev wrote: with a length that isn't multiply by max pkt size for this endpoint. The commit 689d6eac (USB: UHCI: add native scatter-gather support(v1)) introduced an implementation of scatter-gather list for UHCI. This implementation

Re: URB completion order, normal behavior or bug?

2013-06-24 Thread Daniel Santos
Well, our project needs more than two USB ports, and we were looking at the model A anyway, so maybe I should just find some nice USB hub chip and/or PIC that uses SPI and has a good stable driver and hook it up via the Pi's SPI interface? I know that sounds kinda stupid when it already has the

Re: [PATCH 8/8] usb: musb: omap2430: make it compile again

2013-06-24 Thread Felipe Balbi
On Wed, Jun 19, 2013 at 05:38:16PM +0200, Sebastian Andrzej Siewior wrote: it does not compile since 09fc7d (usb: musb: fix incorrect usage of resource pointer). What makes me wonder most is if source of the Tested-by tag :) Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de

Re: [PATCH 8/8] usb: musb: omap2430: make it compile again

2013-06-24 Thread Felipe Balbi
On Mon, Jun 24, 2013 at 04:33:42PM +0200, Sebastian Andrzej Siewior wrote: On 06/24/2013 04:27 PM, Felipe Balbi wrote: Hi, Hi Felipe, which tree are you using as your base ? I don't have that hunk below on my v3.10-rc7. $ git grep -e struct resource drivers/usb/musb/omap2430.c $

Re: [v2] usb: UHCI: fix pkt size in TD for a non-aligned sg element

2013-06-24 Thread Alan Stern
On Mon, 24 Jun 2013, Konstantin Filatov wrote: On 06/23/2013 07:05 PM, Alan Stern wrote: That's why, if the check is checked, I feel it should be added to each HCD driver separately. Maybe I'm wrong. But before doing anything, you should check with Thomas Pugliese. He recently added SG

Re: [PATCH 8/8] usb: musb: omap2430: make it compile again

2013-06-24 Thread Felipe Balbi
Hi, On Mon, Jun 24, 2013 at 04:42:52PM +0200, Sebastian Andrzej Siewior wrote: On 06/24/2013 04:38 PM, Felipe Balbi wrote: it's in my tree, but not in v3.10-rc7 clean, so that typo is going on v3.11 merge window... Looks like I forgot to update the patch, I had seen that problem before and

Re: From: Konstantin Filatov kfila...@parallels.com

2013-06-24 Thread Felipe Balbi
On Mon, Jun 24, 2013 at 06:42:28PM +0400, Denis V. Lunev wrote: On 6/24/13 6:35 PM, Felipe Balbi wrote: Hi, On Mon, Jun 24, 2013 at 06:31:07PM +0400, Denis V. Lunev wrote: with a length that isn't multiply by max pkt size for this endpoint. The commit 689d6eac (USB: UHCI: add native

Re: [v4] usb: UHCI: fix pkt size in TD for a sg element

2013-06-24 Thread Ming Lei
On Mon, Jun 24, 2013 at 10:33 PM, Denis V. Lunev d...@openvz.org wrote: From: Konstantin Filatov kfila...@parallels.com This patch shortens TD's packet not only for the last TD in sg list, but also for the last TD in sg element. Signed-off-by: Konstantin Filatov kfila...@parallels.com

Re: [PATCH 8/8] usb: musb: omap2430: make it compile again

2013-06-24 Thread Sebastian Andrzej Siewior
On 06/24/2013 04:38 PM, Felipe Balbi wrote: it's in my tree, but not in v3.10-rc7 clean, so that typo is going on v3.11 merge window... Looks like I forgot to update the patch, I had seen that problem before and had fixed it :-( Looks like your patch needs to go in fast, I'll ack it. So you

Re: [v4] usb: UHCI: fix pkt size in TD for a sg element

2013-06-24 Thread Felipe Balbi
On Mon, Jun 24, 2013 at 10:56:30PM +0800, Ming Lei wrote: On Mon, Jun 24, 2013 at 10:33 PM, Denis V. Lunev d...@openvz.org wrote: From: Konstantin Filatov kfila...@parallels.com This patch shortens TD's packet not only for the last TD in sg list, but also for the last TD in sg element.

Re: [RFC PATCH 4/6] USB: ehci-omap: Suspend the controller during bus suspend

2013-06-24 Thread Roger Quadros
Hi Alan, On 06/20/2013 08:33 PM, Alan Stern wrote: On Thu, 20 Jun 2013, Roger Quadros wrote: runtime_resume(dev) { ... if (omap-flags OMAP_EHCI_IRQ_PENDING) { process_pending_irqs(omap); OK, thanks. But I'm not sure if the generic ehci_irq handler is able to

Re: [v4] usb: UHCI: fix pkt size in TD for a sg element

2013-06-24 Thread Sebastian Andrzej Siewior
On 06/24/2013 05:04 PM, Felipe Balbi wrote: - the change violates USB spec(1.1/2.0/3.0) I can't see how this would violate USB spec. USB specifications have no knowledge of scatter-gather. It really doesn't matter how the data gets into the HW's FIFO, as long as it *does* get there. IOW

Re: From: Konstantin Filatov kfila...@parallels.com

2013-06-24 Thread Denis V. Lunev
On 6/24/13 6:35 PM, Felipe Balbi wrote: Hi, On Mon, Jun 24, 2013 at 06:31:07PM +0400, Denis V. Lunev wrote: with a length that isn't multiply by max pkt size for this endpoint. The commit 689d6eac (USB: UHCI: add native scatter-gather support(v1)) introduced an implementation of

Re: [PATCH v2 1/4] USB: HCD: support giveback of URB in tasklet context

2013-06-24 Thread Alan Stern
On Mon, 24 Jun 2013, Ming Lei wrote: This patch implements the mechanism of giveback of URB in tasklet context, so that hardware interrupt handling time for usb host controller can be saved much, and HCD interrupt handling can be simplified. Changes from v1 to v2? +static void

Re: [PATCH v2 2/4] USB: URB documentation: claim complete() will be run with IRQs enabled

2013-06-24 Thread Alan Stern
On Mon, 24 Jun 2013, Ming Lei wrote: There is no good reason to run complete() in hard interrupt disabled context. After switch to run complete() in tasklet, we will enable local IRQs when calling complete() since we can do it at that time. Even though we still disable IRQs now when

Re: [v4] usb: UHCI: fix pkt size in TD for a sg element

2013-06-24 Thread Felipe Balbi
Hi, On Mon, Jun 24, 2013 at 05:12:50PM +0200, Sebastian Andrzej Siewior wrote: On 06/24/2013 05:04 PM, Felipe Balbi wrote: - the change violates USB spec(1.1/2.0/3.0) I can't see how this would violate USB spec. USB specifications have no knowledge of scatter-gather. It really

Re: [v4] usb: UHCI: fix pkt size in TD for a sg element

2013-06-24 Thread Ming Lei
On Mon, Jun 24, 2013 at 11:04 PM, Felipe Balbi ba...@ti.com wrote: On Mon, Jun 24, 2013 at 10:56:30PM +0800, Ming Lei wrote: On Mon, Jun 24, 2013 at 10:33 PM, Denis V. Lunev d...@openvz.org wrote: From: Konstantin Filatov kfila...@parallels.com This patch shortens TD's packet not only for

[PATCH 7/7] usb: phy: msm: Lindent the code

2013-06-24 Thread Ivan T. Ivanov
From: Ivan T. Ivanov iiva...@mm-sol.com Cc: Felipe Balbi ba...@ti.com Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Cc: linux-usb@vger.kernel.org Cc: linux-ker...@vger.kernel.org Signed-off-by: Ivan T. Ivanov iiva...@mm-sol.com --- drivers/usb/phy/phy-msm-usb.c | 99

[PATCH 6/7] usb: phy: msm: Fix WARNING: Prefer seq_puts to seq_printf

2013-06-24 Thread Ivan T. Ivanov
From: Ivan T. Ivanov iiva...@mm-sol.com This fixes checkpatch.pl warnings. Cc: Felipe Balbi ba...@ti.com Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Cc: linux-usb@vger.kernel.org Cc: linux-ker...@vger.kernel.org Signed-off-by: Ivan T. Ivanov iiva...@mm-sol.com ---

[PATCH 5/7] usb: phy: msm: Fix WARNING: quoted string split across lines

2013-06-24 Thread Ivan T. Ivanov
From: Ivan T. Ivanov iiva...@mm-sol.com This fixes checkpatch.pl warnings. Cc: Felipe Balbi ba...@ti.com Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Cc: linux-usb@vger.kernel.org Cc: linux-ker...@vger.kernel.org Signed-off-by: Ivan T. Ivanov iiva...@mm-sol.com ---

[PATCH 2/7] usb: phy: msm: Migrate to Managed Device Resource allocation

2013-06-24 Thread Ivan T. Ivanov
From: Ivan T. Ivanov iiva...@mm-sol.com Cc: Felipe Balbi ba...@ti.com Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Cc: linux-usb@vger.kernel.org Cc: linux-ker...@vger.kernel.org Signed-off-by: Ivan T. Ivanov iiva...@mm-sol.com --- drivers/usb/phy/phy-msm-usb.c | 78

[PATCH 4/7] usb: phy: msm: Remove unnecessarily check for valid regulators.

2013-06-24 Thread Ivan T. Ivanov
From: Ivan T. Ivanov iiva...@mm-sol.com Whether regulators are available or not is checked at driver probe. If they are not available driver will refuse to load, so no need to check them again. Cc: Felipe Balbi ba...@ti.com Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Cc:

Re: [v4] usb: UHCI: fix pkt size in TD for a sg element

2013-06-24 Thread Alan Stern
On Mon, 24 Jun 2013, Felipe Balbi wrote: Hi, On Mon, Jun 24, 2013 at 05:12:50PM +0200, Sebastian Andrzej Siewior wrote: On 06/24/2013 05:04 PM, Felipe Balbi wrote: - the change violates USB spec(1.1/2.0/3.0) I can't see how this would violate USB spec. USB specifications have

Re: [v4] usb: UHCI: fix pkt size in TD for a sg element

2013-06-24 Thread Sebastian Andrzej Siewior
On 06/24/2013 05:18 PM, Felipe Balbi wrote: It is a little. The first USB packet has 512 vs 502 bytes on the wire. you wouldn't notice the difference. The DMA engine is the one which would read the sgtable to figure where the data is scattered, at the end of the day, SW only knows of a

Re: Linux USB file storage gadget with new UDC

2013-06-24 Thread victor yeo
Hi, Ok, is the usb_ep_set_wedge routine not working? I can't see that in the log file. It is not working. This can be seen in the usbmon log. I re-attach the usbmon log. If possible, please show me which line indicates that usb_ep_set_wedge routine is not working, or how to look for the

Re: [v4] usb: UHCI: fix pkt size in TD for a sg element

2013-06-24 Thread Felipe Balbi
Hi, On Mon, Jun 24, 2013 at 11:32:16AM -0400, Alan Stern wrote: - the change violates USB spec(1.1/2.0/3.0) I can't see how this would violate USB spec. USB specifications have no knowledge of scatter-gather. It really doesn't matter how the data gets into the HW's FIFO,

Re: [v4] usb: UHCI: fix pkt size in TD for a sg element

2013-06-24 Thread Felipe Balbi
On Mon, Jun 24, 2013 at 06:42:05PM +0300, Felipe Balbi wrote: On Mon, Jun 24, 2013 at 11:32:16AM -0400, Alan Stern wrote: - the change violates USB spec(1.1/2.0/3.0) I can't see how this would violate USB spec. USB specifications have no knowledge of scatter-gather.

Re: [v4] usb: UHCI: fix pkt size in TD for a sg element

2013-06-24 Thread Felipe Balbi
On Mon, Jun 24, 2013 at 05:35:42PM +0200, Sebastian Andrzej Siewior wrote: On 06/24/2013 05:18 PM, Felipe Balbi wrote: It is a little. The first USB packet has 512 vs 502 bytes on the wire. you wouldn't notice the difference. The DMA engine is the one which would read the sgtable to

Re: [v4] usb: UHCI: fix pkt size in TD for a sg element

2013-06-24 Thread Sebastian Andrzej Siewior
On 06/24/2013 05:46 PM, Felipe Balbi wrote: The DMA engines (intern or extern) do not merge transfers. Some of them are clever enough to transfer a single 1024 as two 512 requests. But two 256 bytes requests are not merged into one 512 request. I believe the device side of dwc3 is able to

Re: [PATCH] xhci: Compute last_ctx from complete set of configured endpoints.

2013-06-24 Thread Sarah Sharp
On Tue, Jun 18, 2013 at 02:09:13PM -0700, Reilly Grant wrote: The context entries field of the slot context must be set to one more than the highest endpoint index currently active. The previous logic only included the set of endpoints currently being added, meaning that if an endpoint where

Re: [v4] usb: UHCI: fix pkt size in TD for a sg element

2013-06-24 Thread Felipe Balbi
Hi, On Mon, Jun 24, 2013 at 05:53:25PM +0200, Sebastian Andrzej Siewior wrote: On 06/24/2013 05:46 PM, Felipe Balbi wrote: The DMA engines (intern or extern) do not merge transfers. Some of them are clever enough to transfer a single 1024 as two 512 requests. But two 256 bytes requests

Re: [v4] usb: UHCI: fix pkt size in TD for a sg element

2013-06-24 Thread Alan Stern
On Mon, 24 Jun 2013, Felipe Balbi wrote: you wouldn't notice the difference. The DMA engine is the one which would read the sgtable to figure where the data is scattered, at the end of the day, SW only knows of a single 1044bytes URB and controller is required to generate proper USB

Re: [Bug] USB 2.0 Ports Dont Work on Sony Vaio Laptop

2013-06-24 Thread Sarah Sharp
On Wed, Jun 19, 2013 at 11:52:10AM -0400, Alan Stern wrote: On Wed, 19 Jun 2013, Ming Lei wrote: There's a good chance this problem was caused by a change in the xhci-hcd driver. I am wondering why xhci-hcd may cause the problem since the affected hub is 'Intel Corp. Integrated

Re: [v4] usb: UHCI: fix pkt size in TD for a sg element

2013-06-24 Thread Ming Lei
On Mon, Jun 24, 2013 at 11:44 PM, Felipe Balbi ba...@ti.com wrote: BTW, EHCI can handle short SGs in the first page. See page 97 of EHCI 1.0 spec. That isn't enough, EHCI requires that size of the 3 middle buffers are 4K. Thanks, -- Ming Lei -- To unsubscribe from this list: send the line

Re: [v4] usb: UHCI: fix pkt size in TD for a sg element

2013-06-24 Thread Felipe Balbi
Hi, On Mon, Jun 24, 2013 at 12:04:19PM -0400, Alan Stern wrote: On Mon, 24 Jun 2013, Felipe Balbi wrote: you wouldn't notice the difference. The DMA engine is the one which would read the sgtable to figure where the data is scattered, at the end of the day, SW only knows of a single

Re: [v4] usb: UHCI: fix pkt size in TD for a sg element

2013-06-24 Thread Alan Stern
On Mon, 24 Jun 2013, Felipe Balbi wrote: BTW, EHCI can handle short SGs in the first page. See page 97 of EHCI 1.0 spec. I'm not sure what you're talking about. SG is used for bulk transfers, whereas p. 97 is about interrupt transfers. It's true that the hardware's abilities aren't fully

Re: [v4] usb: UHCI: fix pkt size in TD for a sg element

2013-06-24 Thread Felipe Balbi
On Tue, Jun 25, 2013 at 12:09:38AM +0800, Ming Lei wrote: On Mon, Jun 24, 2013 at 11:44 PM, Felipe Balbi ba...@ti.com wrote: BTW, EHCI can handle short SGs in the first page. See page 97 of EHCI 1.0 spec. That isn't enough, EHCI requires that size of the 3 middle buffers are 4K. right,

Re: Fwd: Re: Bug#704242: Driver for PL-2303 HX not working

2013-06-24 Thread Greg KH
On Mon, Jun 24, 2013 at 10:41:07AM +0200, Karsten Malcher wrote: Hello Greg, have you buyed one of this jinxed PL-2303 HX adapters? No, I have not been able to find one. Does anyone know where I can purchase one? Yesterday i got this interesting mail from Aric, who has analyzed a similar

Re: [Bug] USB 2.0 Ports Dont Work on Sony Vaio Laptop

2013-06-24 Thread Ming Lei
On Tue, Jun 25, 2013 at 12:06 AM, Sarah Sharp sarah.a.sh...@linux.intel.com wrote: On Wed, Jun 19, 2013 at 11:52:10AM -0400, Alan Stern wrote: On Wed, 19 Jun 2013, Ming Lei wrote: There's a good chance this problem was caused by a change in the xhci-hcd driver. I am wondering why

Re: Linux USB file storage gadget with new UDC

2013-06-24 Thread Alan Stern
On Mon, 24 Jun 2013, victor yeo wrote: Hi, Ok, is the usb_ep_set_wedge routine not working? I can't see that in the log file. It is not working. This can be seen in the usbmon log. I re-attach the usbmon log. If possible, please show me which line indicates that usb_ep_set_wedge

Re: [PATCH] xhci: Compute last_ctx from complete set of configured endpoints.

2013-06-24 Thread Reilly Grant
On Mon, Jun 24, 2013 at 08:59AM -0700, Sarah Sharp wrote: On Tue, Jun 18, 2013 at 02:09:13PM -0700, Reilly Grant wrote: The context entries field of the slot context must be set to one more than the highest endpoint index currently active. The previous logic only included the set of

Re: [v4] usb: UHCI: fix pkt size in TD for a sg element

2013-06-24 Thread Alan Stern
On Mon, 24 Jun 2013, Felipe Balbi wrote: MUSB shouldn't be copying data to and from bounce buffers just to be able to handle SG tranfers. well, if we can assume all SG elements to be wMaxPacketSize aligned, we could just break it up into smaller URBs and avoid the copy, but I wasn't

Subject: [v3.8 Regression] UHCI: OHCI: implement new semantics for URB_ISO_ASAP

2013-06-24 Thread Joseph Salisbury
Hi Alan, A bug was opened against the Ubuntu distro[0]. It is believed that the following commits introduced the regression: commit c44b225077bb1fb25ed5cd5c4f226897b91bedd4 Author: Alan Stern st...@rowland.harvard.edu Date: Mon Oct 1 10:32:09 2012 -0400 UHCI: implement new semantics for

Re: Hardware bug in Intel USB-2 hub?

2013-06-24 Thread Sarah Sharp
On Wed, Jun 19, 2013 at 03:03:23PM -0400, Alan Stern wrote: Sarah: This report surfaced in Bugzilla #59011 (see especially comments #38 and #39). Toralf reports, among other things, that the integrated rate-matching hub in his ThinkPad T420 (6 Series/C200 Series chipset) isn't behaving the

Re: Fwd: Re: Bug#704242: Driver for PL-2303 HX not working

2013-06-24 Thread Karsten Malcher
Hello Greg, Am 24.06.2013 18:17, schrieb Greg KH: On Mon, Jun 24, 2013 at 10:41:07AM +0200, Karsten Malcher wrote: Hello Greg, have you buyed one of this jinxed PL-2303 HX adapters? No, I have not been able to find one. Does anyone know where I can purchase one? Just take this one:

Re: Bug#704242: Driver for PL-2303 HX not working

2013-06-24 Thread Aric Fedida
I will gladly ship you one. Give me address details, and I'll go to the post office to send it. Personally, I have resolved to abandon the PL2303 chip, and move to FTDI instead. But for the sake of other Linux users who might buy that adapter by mistake, I am willing to donate the hardware to

Re: Bug#704242: Driver for PL-2303 HX not working

2013-06-24 Thread Karsten Malcher
Am 24.06.2013 18:38, schrieb Aric Fedida: I will gladly ship you one. Give me address details, and I'll go to the post office to send it. Personally, I have resolved to abandon the PL2303 chip, and move to FTDI instead. But for the sake of other Linux users who might buy that adapter by

[PATCH] USB: HWA: fix device probe failure

2013-06-24 Thread Thomas Pugliese
This patch fixes a race condition that caused the HWA_HC interface probe function to occasionally fail. The HWA_HC would attempt to register itself with the HWA_RC by searching for a uwb_rc class device with the same parent device ptr. If the probe function for the HWA_RC interface had yet

Re: Hardware bug in Intel USB-2 hub?

2013-06-24 Thread Alan Stern
On Mon, 24 Jun 2013, Sarah Sharp wrote: On Wed, Jun 19, 2013 at 03:03:23PM -0400, Alan Stern wrote: Sarah: This report surfaced in Bugzilla #59011 (see especially comments #38 and #39). Toralf reports, among other things, that the integrated rate-matching hub in his ThinkPad T420 (6

Re: Fwd: Re: Bug#704242: Driver for PL-2303 HX not working

2013-06-24 Thread Greg KH
On Mon, Jun 24, 2013 at 06:41:38PM +0200, Karsten Malcher wrote: Hello Greg, Am 24.06.2013 18:17, schrieb Greg KH: On Mon, Jun 24, 2013 at 10:41:07AM +0200, Karsten Malcher wrote: Hello Greg, have you buyed one of this jinxed PL-2303 HX adapters? No, I have not been able to find one.

[PATCH] staging: dwc2: fix thinko in dwc2_hc_set_even_odd_frame()

2013-06-24 Thread Paul Zimmerman
I screwed up the sense of this if() statement while porting our vendor driver to create the dwc2 driver. This caused frame overrun errors on periodic transfers when there were other transfers active in the same (micro)frame. With this fix, the dwc2 driver now works on the Raspberry Pi platform

Re: Fwd: Re: Bug#704242: Driver for PL-2303 HX not working

2013-06-24 Thread Karsten Malcher
Am 24.06.2013 20:18, schrieb Greg KH: On Mon, Jun 24, 2013 at 06:41:38PM +0200, Karsten Malcher wrote: Hello Greg, Am 24.06.2013 18:17, schrieb Greg KH: On Mon, Jun 24, 2013 at 10:41:07AM +0200, Karsten Malcher wrote: Hello Greg, have you buyed one of this jinxed PL-2303 HX adapters? No, I

Re: [PATCH v2 3/4] USB: EHCI: improve interrupt qh unlink

2013-06-24 Thread Alan Stern
On Mon, 24 Jun 2013, Ming Lei wrote: Given interrupt URB will be resubmitted from tasklet context which is scheduled by ehci hardware interrupt handler, and commonly only one interrupt URB is scheduled on qh, so the qh may be unlinked immediately once qh_completions() returns from ehci_irq(),

Re: Fwd: Re: Bug#704242: Driver for PL-2303 HX not working

2013-06-24 Thread Greg KH
On Mon, Jun 24, 2013 at 08:37:59PM +0200, Karsten Malcher wrote: Am 24.06.2013 20:18, schrieb Greg KH: On Mon, Jun 24, 2013 at 06:41:38PM +0200, Karsten Malcher wrote: Hello Greg, Am 24.06.2013 18:17, schrieb Greg KH: On Mon, Jun 24, 2013 at 10:41:07AM +0200, Karsten Malcher wrote: Hello

Re: [PATCH] USB: HWA: fix device probe failure

2013-06-24 Thread Greg KH
On Mon, Jun 24, 2013 at 12:18:04PM -0500, Thomas Pugliese wrote: This patch fixes a race condition that caused the HWA_HC interface probe function to occasionally fail. The HWA_HC would attempt to register itself with the HWA_RC by searching for a uwb_rc class device with the same parent

Re: [PATCH] USB: HWA: fix device probe failure

2013-06-24 Thread Thomas Pugliese
On Mon, 24 Jun 2013, Greg KH wrote: On Mon, Jun 24, 2013 at 12:18:04PM -0500, Thomas Pugliese wrote: This patch fixes a race condition that caused the HWA_HC interface probe function to occasionally fail. The HWA_HC would attempt to register itself with the HWA_RC by searching for a

Re: Bug#704242: Driver for PL-2303 HX not working

2013-06-24 Thread Greg KH
On Mon, Jun 24, 2013 at 12:38:17PM -0400, Aric Fedida wrote: I will gladly ship you one. Give me address details, and I'll go to the post office to send it. I'll send it off-list, thanks. Personally, I have resolved to abandon the PL2303 chip, and move to FTDI instead. But for the sake of

[PATCH] chipidea: ci13xxx_imx: Access phy via private data

2013-06-24 Thread Fabio Estevam
commit ea1418b5f1a (usb: chipidea: i.MX: use devm_usb_get_phy_by_phandle to get phy) causes the USB host to miss the disconnect/connect events. In order to reproduce this problem: - Insert a USB thumb into the USB host port (connection is detected) - Remove it (no disconnect event will be

Re: [PATCH] USB: HWA: fix device probe failure

2013-06-24 Thread Greg KH
On Mon, Jun 24, 2013 at 02:00:06PM -0500, Thomas Pugliese wrote: On Mon, 24 Jun 2013, Greg KH wrote: On Mon, Jun 24, 2013 at 12:18:04PM -0500, Thomas Pugliese wrote: This patch fixes a race condition that caused the HWA_HC interface probe function to occasionally fail. The HWA_HC

[PATCH] USB: HWA: fix device probe failure (resubmit)

2013-06-24 Thread Thomas Pugliese
This patch fixes a race condition that caused the HWA_HC interface probe function to occasionally fail. The HWA_HC would attempt to register itself with the HWA_RC by searching for a uwb_rc class device with the same parent device ptr. If the probe function for the HWA_RC interface had yet

Re: [PATCH v7 0/9] Generic PHY Framework

2013-06-24 Thread Sylwester Nawrocki
Hi, On 06/18/2013 11:49 AM, Felipe Balbi wrote: On Mon, Jun 17, 2013 at 12:16:35PM +0200, Sylwester Nawrocki wrote: I have already used this API for our MIPI CSI-2/DSIM DPHYs driver, the RFC patch series can be found at [1]. Thanks, Sylwester [1]

Re: [PATCH] staging: usbip: replace pr_warning() with pr_warn()

2013-06-24 Thread Greg KH
On Fri, Jun 21, 2013 at 03:01:04PM +0530, navin patidar wrote: pr_warn() is preferred over pr_warning(). And dev_warn() is preferred over both of them, can you convert the code to use that instead? thanks, greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-usb in the

Re: [RESEND PATCH v2 1/1] usb: fix build error without CONFIG_USB_PHY

2013-06-24 Thread Greg KH
On Mon, Jun 24, 2013 at 03:23:25PM +0300, Felipe Balbi wrote: On Mon, Jun 24, 2013 at 11:15:35AM +0300, Alexander Shishkin wrote: Peter Chen peter.c...@freescale.com writes: on i386: drivers/built-in.o: In function `ci_hdrc_probe': core.c:(.text+0x20446b): undefined reference to

Re: [PATCH] build some drivers only when compile-testing

2013-06-24 Thread Greg Kroah-Hartman
On Wed, Jun 19, 2013 at 08:50:08AM +0200, Jiri Slaby wrote: On 06/18/2013 06:04 PM, Greg Kroah-Hartman wrote: So currently I have what is attached... Comments? Looks good to me, want me to queue it up through my char/misc driver tree for 3.11? If there are no objections... Whoever

Re: URB completion order, normal behavior or bug?

2013-06-24 Thread Daniel Santos
On 06/23/2013 09:08 PM, Alan Stern wrote: On Sun, 23 Jun 2013, Daniel Santos wrote: So I'm working on this MCP2210 driver which talks in 64-byte request/response pairs using interrupt URBs (it can be used with hid-generic, but I don't want to do that). I'm testing on a Raspberry Pi Model B

Re: [PATCH V2] USB: initialize or shutdown PHY when add or remove host controller

2013-06-24 Thread Chao Xie
On Tue, Jun 25, 2013 at 3:45 AM, Felipe Balbi ba...@ti.com wrote: Hi, On Fri, Jun 21, 2013 at 09:07:59AM +0800, Chao Xie wrote: On Fri, Jun 21, 2013 at 1:25 AM, Alan Stern st...@rowland.harvard.edu wrote: On Thu, 20 Jun 2013, Felipe Balbi wrote: In fact, the PHY setting and handling

RE: Chipidea usb otg support for IMX/MXS (device functionality)

2013-06-24 Thread Chen Peter-B29397
No, I don't have this one available right now. I tried both MX23 Olinuxino maxi (I just mutilated the board so that I cut traces to the USB devices on the board and routed out USB gadget connector) and a custom MX23 board. Note that both have working USB peripheral mode in U-Boot too,

Re: [PATCH] chipidea: ci13xxx_imx: Access phy via private data

2013-06-24 Thread Peter Chen
On Tue, Jun 25, 2013 at 2:58 AM, Fabio Estevam fabio.este...@freescale.com wrote: commit ea1418b5f1a (usb: chipidea: i.MX: use devm_usb_get_phy_by_phandle to get phy) causes the USB host to miss the disconnect/connect events. In order to reproduce this problem: - Insert a USB thumb into

Re: [PATCH V2] USB: initialize or shutdown PHY when add or remove host controller

2013-06-24 Thread Felipe Balbi
Hi, On Tue, Jun 25, 2013 at 09:25:30AM +0800, Chao Xie wrote: It is same as clk, irq requested by ehci-xxx driver. clocks could be handled generically in some cases, we have pm_clk_add() for a reason ;-) Also, clock handling can be hidden under pm_runtime callbacks (say,

  1   2   >