[PATCH 1/1] usb,uhci: add a new tag for virtual uhci devices

2013-06-26 Thread Li, Zhen-Hua
From: Li, Zhen-Hua zhen-h...@hp.com There's another patch trying to fix this warning: Controller not stopped yet!. It is : 997ff893603c6455da4c5e26ba1d0f81adfecdfc . I don't think it is appropriate to avoid auto-stop for all HP uhci devices. So add one tag for the virtual uhci devices, it is

Re: [PATCH] staging: usbip: replace pr_warning() with pr_warn()

2013-06-26 Thread navin patidar
On Tue, Jun 25, 2013, Greg KH gre...@linuxfoundation.org said: On Tue, Jun 25, 2013 at 04:27:18PM +0530, navin patidar wrote: On Tue, Jun 25, 2013, Greg KH gre...@linuxfoundation.org said: On Fri, Jun 21, 2013 at 03:01:04PM +0530, navin patidar wrote: pr_warn() is preferred over

Re: [PATCH 2/4] ARM: dts: exynos4: Add node for hsotg

2013-06-26 Thread Jingoo Han
On Wednesday, June 26, 2013 12:38 AM, Tomasz Figa wrote: This patch adds device tree node for USB HSOTG controller present on Exynos4 SoCs. Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com It looks good. Reviewed-by: Jingoo Han

Re: [PATCH 3/4] ARM: dts: exynos4: Add nodes for USB PHY block

2013-06-26 Thread Jingoo Han
On Wednesday, June 26, 2013 12:38 AM, Tomasz Figa wrote: This patch adds device tree nodes for USB OTG PHYs of Exynos4210 and Exynos4x12 SoCs. Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com It looks good. Reviewed-by: Jingoo Han

[RFC] [PATCH] Debugfs support for EHCI testing modes

2013-06-26 Thread Tim Sander
Hi I have just written a ehci testing driver which enables the testing modes used for hw testing via a file in debugfs. This patch is for 3.4.47 not any usb branch. But if this driver is ready for mainline i will be happy to port it to whatever branch you wish. The only problem with the patch

[PATCH v2] USB: check sg buffer size in usb_submit_urb

2013-06-26 Thread Ming Lei
USB spec stats that short packet can only appear at the end of transfer. Because lost of HC(EHCI/UHCI/OHCI/...) can't build a full packet from discontinuous buffers, we introduce the limit in usb_submit_urb() to avoid such kind of bad sg buffers coming from driver. The limit might be a bit

Re: [PATCH v1 1/3] usb: musb: core: added musb_restart() API to handle babble condition

2013-06-26 Thread Felipe Balbi
On Wed, May 29, 2013 at 06:37:02PM +0530, Ravi Babu wrote: Added musb_restart() API, used for restart of the musb controller by the glue layer, when there is babble condition occured on the bus. During babble condition, the musb controller will remove the session and no longer in host-mode.

Re: [PATCH v1 2/3] usb: musb: core: added babble recovery func-ptr to musb-ops

2013-06-26 Thread Felipe Balbi
Hi, On Wed, May 29, 2013 at 06:37:03PM +0530, Ravi Babu wrote: Adding babble_recovery operation as part of musb-ops, used to recover from babble condition during babble interrupt. Signed-off-by: Ravi Babu ravib...@ti.com --- drivers/usb/musb/musb_core.c |6 ++

Re: [PATCH v1 3/3] usb: musb: dsps: handle babble condition for dsps platform

2013-06-26 Thread Felipe Balbi
Hi, On Wed, May 29, 2013 at 06:37:04PM +0530, Ravi Babu wrote: @@ -428,6 +436,29 @@ static int dsps_musb_exit(struct musb *musb) return 0; } +static void dsps_musb_restart(struct musb *musb) +{ + struct device *dev = musb-controller; + struct dsps_glue *glue =

Re: [PATCH 0/2] *** SUBJECT HERE ***

2013-06-26 Thread Anders Hammarquist
In a message of Tue, 25 Jun 2013 16:39:11 -0700, Greg KH writes: Indeed. I'd already had some (failed) thoughts about how to handle it nicely. Now I've had another think through, and I have something which deals with it and at least complains if TI_EXTRA_VID_PID_COUNT is changed without

RE: [PATCH v1 2/3] usb: musb: core: added babble recovery func-ptr to musb-ops

2013-06-26 Thread B, Ravi
Felipe On Wed, May 29, 2013 at 06:37:03PM +0530, Ravi Babu wrote: Adding babble_recovery operation as part of musb-ops, used to recover from babble condition during babble interrupt. Signed-off-by: Ravi Babu ravib...@ti.com --- drivers/usb/musb/musb_core.c |6 ++

Re: [PATCH v1 2/3] usb: musb: core: added babble recovery func-ptr to musb-ops

2013-06-26 Thread Felipe Balbi
On Wed, Jun 26, 2013 at 10:37:39AM +0200, B, Ravi wrote: Felipe On Wed, May 29, 2013 at 06:37:03PM +0530, Ravi Babu wrote: Adding babble_recovery operation as part of musb-ops, used to recover from babble condition during babble interrupt. Signed-off-by: Ravi Babu

[PATCH] usb: host: xhci-plat: Enable XHCI_SPURIOUS_SUCCESS quirk for xhci-plat

2013-06-26 Thread George Cherian
Synopsis xhci controllers with hci_version 0.96 gives spurious success events on short packet completion. During webcam capture the ERROR Transfer event TRB DMA ptr not part of current TD was observed. The same application works fine with synopsis controllers hci_version 0.96. Signed-off-by:

Re: [PATCH] usb: host: xhci-plat: Enable XHCI_SPURIOUS_SUCCESS quirk for xhci-plat

2013-06-26 Thread Felipe Balbi
Hi, On Wed, Jun 26, 2013 at 02:28:57PM +0530, George Cherian wrote: Synopsis xhci controllers with hci_version 0.96 gives spurious success events on short packet completion. During webcam capture the ERROR Transfer event TRB DMA ptr not part of current TD was observed. The same application

RE: [PATCH v1 2/3] usb: musb: core: added babble recovery func-ptr to musb-ops

2013-06-26 Thread B, Ravi
Hi Felipe @@ -213,6 +213,8 @@ struct musb_platform_ops { int (*adjust_channel_params)(struct dma_channel *channel, u16 packet_sz, u8 *mode, dma_addr_t *dma_addr, u32 *len); + + void

[PATCH] usb: dwc3: core: continue probe even if usb3 phy is not available

2013-06-26 Thread George Cherian
There can be configurations in which DWC3 is hoooked up only to USB2 PHY. In such cases we should not return -EPROBE_DEFER, rather continue probe even if there is no USB3 PHY. Signed-off-by: George Cherian george.cher...@ti.com --- drivers/usb/dwc3/core.c | 31 --- 1

[PATCH v2] staging: usbip: replace pr_warning() with dev_warn().

2013-06-26 Thread navin patidar
dev_warn() is preferred over pr_warning(). container_of() is used to get usb_driver pointer from usbip_device container (stub_device or vhci_device), to get device structure required for dev_warn(). Signed-off-by: navin patidar nav...@cdac.in --- drivers/staging/usbip/usbip_event.c | 14

[PATCH 1/4] usb: phy: tegra: Add support for device tree-based vbus regulator control

2013-06-26 Thread Mikko Perttunen
After this patch, usb vbus regulators for tegra usb phy devices can be specified with the device tree attribute vbus-supply = x where x is a regulator defined in the device tree. Signed-off-by: Mikko Perttunen mperttu...@nvidia.com --- drivers/usb/phy/phy-tegra-usb.c | 24

[PATCH 0/4] usb: tegra: Replace nvidia,vbus-gpio property with vbus-supply

2013-06-26 Thread Mikko Perttunen
This patchset removes the ehci-tegra device tree property nvidia,vbus-gpio and adds support for the vbus-supply property to phy-tegra-usb. Mikko Perttunen (4): usb: phy: tegra: Add support for device tree-based vbus regulator control usb: host: tegra: Remove direct vbus regulator control

[PATCH 4/4] ARM: dts: tegra20: Remove obsolete vbus-gpio properties

2013-06-26 Thread Mikko Perttunen
USB VBUS regulators are now specified with the vbus-supply property instead of vbus-gpio, so remove the obsolete properties. Signed-off-by: Mikko Perttunen mperttu...@nvidia.com --- arch/arm/boot/dts/tegra20-seaboard.dts | 1 - arch/arm/boot/dts/tegra20-trimslice.dts | 1 -

[PATCH 3/4] Documentation: devicetree: phy-tegra-usb: Add vbus-supply property for host mode PHYs

2013-06-26 Thread Mikko Perttunen
Signed-off-by: Mikko Perttunen mperttu...@nvidia.com --- Documentation/devicetree/bindings/usb/nvidia,tegra20-usb-phy.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings/usb/nvidia,tegra20-usb-phy.txt

Re: Proposed modification to PL2303 driver

2013-06-26 Thread Reinhard Max
On Tue, 25 Jun 2013 at 19:14, Greg KH wrote: On Tue, Jun 25, 2013 at 11:54:37AM +0200, Reinhard Max wrote: So, how about starting to get rid of the baud rate list by skipping it for HX chips only until someone with a type_0 or type_1 devices can confirm that it works there as well? How

[PATCH 2/4] usb: host: tegra: Remove direct vbus regulator control using GPIOs

2013-06-26 Thread Mikko Perttunen
The tegra ehci driver has enabled USB vbus regulators directly using GPIOs and the device tree attribute nvidia,vbus-gpio. This is ugly and causes error messages on boot when both the regulator driver and the ehci driver want access to the same GPIO. This patch removes this mechanism of vbus

Re: [PATCH] usb: dwc3: core: continue probe even if usb3 phy is not available

2013-06-26 Thread Felipe Balbi
Hi, On Wed, Jun 26, 2013 at 02:59:14PM +0530, George Cherian wrote: There can be configurations in which DWC3 is hoooked up only to USB2 PHY. In such cases we should not return -EPROBE_DEFER, rather continue probe even if there is no USB3 PHY. Signed-off-by: George Cherian

Re: [PATCH 4/4] ARM: dts: tegra20: Remove obsolete vbus-gpio properties

2013-06-26 Thread Felipe Balbi
On Wed, Jun 26, 2013 at 12:59:41PM +0300, Mikko Perttunen wrote: USB VBUS regulators are now specified with the vbus-supply property instead of vbus-gpio, so remove the obsolete properties. Signed-off-by: Mikko Perttunen mperttu...@nvidia.com --- arch/arm/boot/dts/tegra20-seaboard.dts | 1

Re: [PATCH 4/4] ARM: dts: tegra20: Remove obsolete vbus-gpio properties

2013-06-26 Thread Mikko Perttunen
On Wed, 26 Jun 2013 13:17:58 +0300, Felipe Balbi ba...@ti.com wrote: * PGP Signed by an unknown key On Wed, Jun 26, 2013 at 12:59:41PM +0300, Mikko Perttunen wrote: USB VBUS regulators are now specified with the vbus-supply property instead of vbus-gpio, so remove the obsolete properties.

Re: [PATCH 4/4] ARM: dts: tegra20: Remove obsolete vbus-gpio properties

2013-06-26 Thread Felipe Balbi
Hi, On Wed, Jun 26, 2013 at 01:22:07PM +0300, Mikko Perttunen wrote: On Wed, 26 Jun 2013 13:17:58 +0300, Felipe Balbi ba...@ti.com wrote: * PGP Signed by an unknown key On Wed, Jun 26, 2013 at 12:59:41PM +0300, Mikko Perttunen wrote: USB VBUS regulators are now specified with the

Re: [PATCH 0/2] *** SUBJECT HERE ***

2013-06-26 Thread Johan Hovold
On Wed, Jun 26, 2013 at 10:29:59AM +0200, Anders Hammarquist wrote: In a message of Tue, 25 Jun 2013 16:39:11 -0700, Greg KH writes: Indeed. I'd already had some (failed) thoughts about how to handle it nicely. Now I've had another think through, and I have something which deals with it and

[PATCH v9 8/8] usb: phy: twl4030-usb: remove *set_suspend* and *phy_init* ops

2013-06-26 Thread Kishon Vijay Abraham I
Now that twl4030-usb is adapted to the new generic PHY framework, *set_suspend* and *phy_init* ops can be removed from twl4030-usb driver. Signed-off-by: Kishon Vijay Abraham I kis...@ti.com Acked-by: Felipe Balbi ba...@ti.com Reviewed-by: Sylwester Nawrocki s.nawro...@samsung.com ---

[PATCH v9 5/8] ARM: dts: omap: update usb_otg_hs data

2013-06-26 Thread Kishon Vijay Abraham I
Updated the usb_otg_hs dt data to include the *phy* and *phy-names* binding in order for the driver to use the new generic PHY framework. Also updated the Documentation to include the binding information. The PHY binding information can be found at

[PATCH v9 7/8] usb: phy: omap-usb2: remove *set_suspend* callback from omap-usb2

2013-06-26 Thread Kishon Vijay Abraham I
Now that omap-usb2 is adapted to the new generic PHY framework, *set_suspend* ops can be removed from omap-usb2 driver. Signed-off-by: Kishon Vijay Abraham I kis...@ti.com Acked-by: Felipe Balbi ba...@ti.com Reviewed-by: Sylwester Nawrocki s.nawro...@samsung.com ---

[PATCH v9 4/8] ARM: OMAP: USB: Add phy binding information

2013-06-26 Thread Kishon Vijay Abraham I
In order for controllers to get PHY in case of non dt boot, the phy binding information (phy device name) should be added in the platform data of the controller. Signed-off-by: Kishon Vijay Abraham I kis...@ti.com Reviewed-by: Sylwester Nawrocki s.nawro...@samsung.com Acked-by: Felipe Balbi

[PATCH v9 6/8] usb: musb: omap2430: use the new generic PHY framework

2013-06-26 Thread Kishon Vijay Abraham I
Use the generic PHY framework API to get the PHY. The usb_phy_set_resume and usb_phy_set_suspend is replaced with power_on and power_off to align with the new PHY framework. musb-xceiv can't be removed as of now because musb core uses xceiv.state and xceiv.otg. Once there is a separate state

[PATCH v9 1/8] drivers: phy: add generic PHY framework

2013-06-26 Thread Kishon Vijay Abraham I
The PHY framework provides a set of APIs for the PHY drivers to create/destroy a PHY and APIs for the PHY users to obtain a reference to the PHY with or without using phandle. For dt-boot, the PHY drivers should also register *PHY provider* with the framework. PHY drivers should create the PHY by

[PATCH v9 2/8] usb: phy: omap-usb2: use the new generic PHY framework

2013-06-26 Thread Kishon Vijay Abraham I
Used the generic PHY framework API to create the PHY. Now the power off and power on are done in omap_usb_power_off and omap_usb_power_on respectively. However using the old USB PHY library cannot be completely removed because OTG is intertwined with PHY and moving to the new framework will break

[PATCH v9 3/8] usb: phy: twl4030: use the new generic PHY framework

2013-06-26 Thread Kishon Vijay Abraham I
Used the generic PHY framework API to create the PHY. For powering on and powering off the PHY, power_on and power_off ops are used. Once the MUSB OMAP glue is adapted to the new framework, the suspend and resume ops of usb phy library will be removed. However using the old usb phy library cannot

[PATCH v9 0/8] Generic PHY Framework

2013-06-26 Thread Kishon Vijay Abraham I
Added a generic PHY framework that provides a set of APIs for the PHY drivers to create/destroy a PHY and APIs for the PHY users to obtain a reference to the PHY with or without using phandle. This framework will be of use only to devices that uses external PHY (PHY functionality is not embedded

Re: [PATCH] staging: ozwpan: Use normal Makefile, convert oz_trace to oz_dbg

2013-06-26 Thread Rupesh Gujare
On 26/06/13 02:00, Joe Perches wrote: Use a normal Makefile. Convert oz_trace and oz_trace2 to a more normal oz_dbg. Consolidate oztrace and ozconfig files to ozdbg.h Update #include files. Reflow modified lines, fit to 80 cols, align arguments. Add a couple more oz_foo_dbg macros to show how

[PATCH 1/2] ARM: dts: tegra20: Rename USB UTMI parameters according to new definitions

2013-06-26 Thread Mikko Perttunen
Signed-off-by: Mikko Perttunen mperttu...@nvidia.com --- arch/arm/boot/dts/tegra20.dtsi | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/arch/arm/boot/dts/tegra20.dtsi b/arch/arm/boot/dts/tegra20.dtsi index 9653fd8..e457083 100644 ---

[PATCH 2/2] usb: phy: tegra: Read UTMIP parameters from device tree

2013-06-26 Thread Mikko Perttunen
UTMIP parameters used to be hardcoded into tables in the PHY driver. This patch moves them into the device tree in accordance with the phy-tegra-usb DT documentation. Signed-off-by: Mikko Perttunen mperttu...@nvidia.com --- drivers/usb/phy/phy-tegra-usb.c | 129

Re: [PATCH] usb: dwc3: core: continue probe even if usb3 phy is not available

2013-06-26 Thread George Cherian
On 6/26/2013 3:46 PM, Felipe Balbi wrote: Hi, On Wed, Jun 26, 2013 at 02:59:14PM +0530, George Cherian wrote: There can be configurations in which DWC3 is hoooked up only to USB2 PHY. In such cases we should not return -EPROBE_DEFER, rather continue probe even if there is no USB3 PHY.

Re: [PATCH v9 1/8] drivers: phy: add generic PHY framework

2013-06-26 Thread Felipe Balbi
On Wed, Jun 26, 2013 at 05:17:29PM +0530, Kishon Vijay Abraham I wrote: The PHY framework provides a set of APIs for the PHY drivers to create/destroy a PHY and APIs for the PHY users to obtain a reference to the PHY with or without using phandle. For dt-boot, the PHY drivers should also

Re: [PATCH] usb: dwc3: core: continue probe even if usb3 phy is not available

2013-06-26 Thread Felipe Balbi
On Wed, Jun 26, 2013 at 05:37:19PM +0530, George Cherian wrote: On 6/26/2013 3:46 PM, Felipe Balbi wrote: Hi, On Wed, Jun 26, 2013 at 02:59:14PM +0530, George Cherian wrote: There can be configurations in which DWC3 is hoooked up only to USB2 PHY. In such cases we should not return

Re: [PATCH] usb: host: xhci-plat: Enable XHCI_SPURIOUS_SUCCESS quirk for xhci-plat

2013-06-26 Thread George Cherian
On 6/26/2013 2:32 PM, Felipe Balbi wrote: Hi, On Wed, Jun 26, 2013 at 02:28:57PM +0530, George Cherian wrote: Synopsis xhci controllers with hci_version 0.96 gives spurious success events on short packet completion. During webcam capture the ERROR Transfer event TRB DMA ptr not part of

Re: [PATCH 1/2] ARM: dts: tegra20: Rename USB UTMI parameters according to new definitions

2013-06-26 Thread Mikko Perttunen
On Wed, 26 Jun 2013 15:14:42 +0300, Felipe Balbi ba...@ti.com wrote: * PGP Signed by an unknown key On Wed, Jun 26, 2013 at 02:58:46PM +0300, Mikko Perttunen wrote: Signed-off-by: Mikko Perttunen mperttu...@nvidia.com you need a commit log, sorry. Even if obvious Ok, I'll send V2 -- To

build warning on chipidea core

2013-06-26 Thread Felipe Balbi
Hi, just below warnings when building greg/usb-next for x86: drivers/usb/chipidea/core.c: In function ‘hw_phymode_configure’: drivers/usb/chipidea/core.c:226:3: warning: large integer implicitly truncated to unsigned type [-Woverflow] drivers/usb/chipidea/core.c:230:3: warning: large integer

Re: [PATCH] usb: host: xhci-plat: Enable XHCI_SPURIOUS_SUCCESS quirk for xhci-plat

2013-06-26 Thread Felipe Balbi
Hi, On Wed, Jun 26, 2013 at 05:46:29PM +0530, George Cherian wrote: @@ -25,6 +25,16 @@ static void xhci_plat_quirks(struct device *dev, struct xhci_hcd *xhci) * dev struct in order to setup MSI */ xhci-quirks |= XHCI_BROKEN_MSI; + + /* +* In some xhci controllers

[PATCH v2 2/2] usb: phy: tegra: Read UTMIP parameters from device tree

2013-06-26 Thread Mikko Perttunen
UTMIP parameters used to be hardcoded into tables in the PHY driver. This patch reads them from the device tree instead in accordance with the phy-tegra-usb DT documentation. Signed-off-by: Mikko Perttunen mperttu...@nvidia.com --- drivers/usb/phy/phy-tegra-usb.c | 129

[PATCH v2 1/2] ARM: dts: tegra20: Rename USB UTMI parameters according to new definitions

2013-06-26 Thread Mikko Perttunen
This patch changes the Tegra20 USB PHY nodes to use the UTMI configuration parameter names as specified in the device tree binding documentation after patch ARM: tegra: finalize USB EHCI and PHY bindings. Signed-off-by: Mikko Perttunen mperttu...@nvidia.com --- arch/arm/boot/dts/tegra20.dtsi |

[PATCH v2 0/2] usb: phy: tegra: Read UTMI parameters from device tree

2013-06-26 Thread Mikko Perttunen
This patchset moves the USB UTMI interface parameters from hardcoded tables in the PHY driver to device tree and adds code to read them from there. Mikko Perttunen (2): ARM: dts: tegra20: Rename USB UTMI parameters according to new definitions usb: phy: tegra: Read UTMIP parameters from

[RFC/PATCH] usb: dwc3: make glue layers selectable

2013-06-26 Thread Felipe Balbi
Glue layers are starting to have separate requirements. For example, OMAP's glue layer is starting to use extcon framework which no one else needs. In order to make it clear the proper dependencies, we are now allowing glue layers to be selectable so that each glue layer can list their own

Re: [PATCH] usb: dwc3: core: continue probe even if usb3 phy is not available

2013-06-26 Thread Alexander Shishkin
Felipe Balbi ba...@ti.com writes: On Wed, Jun 26, 2013 at 05:37:19PM +0530, George Cherian wrote: On 6/26/2013 3:46 PM, Felipe Balbi wrote: Hi, On Wed, Jun 26, 2013 at 02:59:14PM +0530, George Cherian wrote: There can be configurations in which DWC3 is hoooked up only to USB2 PHY. In such

Re: [PATCH v2] staging: usbip: replace pr_warning() with dev_warn().

2013-06-26 Thread Sergei Shtylyov
Hello. On 26-06-2013 13:41, navin patidar wrote: dev_warn() is preferred over pr_warning(). container_of() is used to get usb_driver pointer from usbip_device container (stub_device or vhci_device), to get device structure required for dev_warn(). Signed-off-by: navin patidar

Re: [RFC/PATCH] usb: dwc3: make glue layers selectable

2013-06-26 Thread Sebastian Andrzej Siewior
On 06/26/2013 02:41 PM, Felipe Balbi wrote: Note that this will require defconfig changes unless someone knows about a choice-like Kconfig construct which allows defaults. You can default y so it will be always selected if it is possible which was the default and drop it after a few kernel

Re: [RFC/PATCH] usb: dwc3: make glue layers selectable

2013-06-26 Thread George Cherian
On 6/26/2013 6:11 PM, Felipe Balbi wrote: Glue layers are starting to have separate requirements. For example, OMAP's glue layer is starting to use extcon framework which no one else needs. In order to make it clear the proper dependencies, we are now allowing glue layers to be selectable so

Re: [RFC PATCH 4/6] USB: ehci-omap: Suspend the controller during bus suspend

2013-06-26 Thread Roger Quadros
On 06/25/2013 08:38 PM, Alan Stern wrote: On Tue, 25 Jun 2013, Roger Quadros wrote: On 06/24/2013 10:34 PM, Alan Stern wrote: On Mon, 24 Jun 2013, Roger Quadros wrote: OK I've tried to handle all this in an alternate way. Now the controller suspend/resume and runtime suspend/resume is

Re: [RFC/PATCH] usb: dwc3: make glue layers selectable

2013-06-26 Thread Felipe Balbi
On Wed, Jun 26, 2013 at 06:40:22PM +0530, George Cherian wrote: On 6/26/2013 6:11 PM, Felipe Balbi wrote: Glue layers are starting to have separate requirements. For example, OMAP's glue layer is starting to use extcon framework which no one else needs. In order to make it clear the proper

Re: [PATCH] staging: ozwpan: Use normal Makefile, convert oz_trace to oz_dbg

2013-06-26 Thread Joe Perches
On Wed, 2013-06-26 at 12:53 +0100, Rupesh Gujare wrote: On 26/06/13 02:00, Joe Perches wrote: Use a normal Makefile. Convert oz_trace and oz_trace2 to a more normal oz_dbg. Consolidate oztrace and ozconfig files to ozdbg.h Update #include files. Reflow modified lines, fit to 80 cols,

Re: URB completion order, normal behavior or bug?

2013-06-26 Thread Daniel Santos
On 06/25/2013 05:42 PM, Daniel Santos wrote: On 06/25/2013 09:45 AM, Alan Stern wrote: static __always_inline int init_endpoint(struct mcp2210_device *dev, const struct usb_host_endpoint *ep) { int is_dir_in = !!usb_endpoint_dir_in(ep-desc); struct

Re: [RFC/PATCH] usb: dwc3: make glue layers selectable

2013-06-26 Thread Sebastian Andrzej Siewior
On 06/26/2013 03:34 PM, Felipe Balbi wrote: adding any default to any of those choices gives Kconfig warnings: Wait but why is it a choice in the first place? Why not making a plain tristate symbol? You still want to enable all of them at once, don't you? Sebastian -- To unsubscribe from this

Re: [PATCH] staging: ozwpan: Use normal Makefile, convert oz_trace to oz_dbg

2013-06-26 Thread Joe Perches
On Wed, 2013-06-26 at 06:56 -0700, Joe Perches wrote: On Wed, 2013-06-26 at 12:53 +0100, Rupesh Gujare wrote: Above macros look good, however Greg have objection to define new macros he had suggested to use dev_dbg() pr_debug(). These macros already use pr_debug and should use dev_dbg and

[PATCH 12/24] USB: oti6858: do not call set_termios with uninitialised data

2013-06-26 Thread Johan Hovold
Make sure set_termios is not called with uninitialised data at open. The old termios struct is currently not used, but pass NULL instead to avoid future problems (e.g. stack data leak). Signed-off-by: Johan Hovold jhov...@gmail.com --- drivers/usb/serial/oti6858.c | 3 +-- 1 file changed, 1

[PATCH 07/24] USB: console: remove unnecessary operations test

2013-06-26 Thread Johan Hovold
Remove unnecessary tests for open and write operations as these are set to the generic implementations by usb-serial core if left unset by a subdriver. Signed-off-by: Johan Hovold jhov...@gmail.com --- drivers/usb/serial/console.c | 18 +++--- 1 file changed, 3 insertions(+), 15

[PATCH 05/24] USB: serial: remove generic vendor/product module parameters

2013-06-26 Thread Johan Hovold
Remove the vendor and product module parameters which were added a long time ago when we did not have the dynamic sysfs interface to add new device ids (and which isn't limited to a single new vid/pid pair). A vid/pid pair can be added dynamically using sysfs, for example: echo 1234 5678

[PATCH 08/24] USB: pl2303: refactor baud-rate handling

2013-06-26 Thread Johan Hovold
Break out baud-rate handling from set_termios. Signed-off-by: Johan Hovold jhov...@gmail.com --- drivers/usb/serial/pl2303.c | 127 1 file changed, 69 insertions(+), 58 deletions(-) diff --git a/drivers/usb/serial/pl2303.c

[PATCH 09/24] USB: pl2303: clean up baud-rate handling

2013-06-26 Thread Johan Hovold
Clean up baud-rate handling somewhat. Signed-off-by: Johan Hovold jhov...@gmail.com --- drivers/usb/serial/pl2303.c | 90 + 1 file changed, 41 insertions(+), 49 deletions(-) diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c index

[PATCH 06/24] USB: console: use dev_dbg

2013-06-26 Thread Johan Hovold
Use dev_dbg for debugging. Signed-off-by: Johan Hovold jhov...@gmail.com --- drivers/usb/serial/console.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/usb/serial/console.c b/drivers/usb/serial/console.c index afb50ea..bfad2cd 100644 ---

[PATCH 01/24] USB: serial: remove defensive test from set_termios

2013-06-26 Thread Johan Hovold
Remove defensive test from set_termios which is never called with a NULL tty. Signed-off-by: Johan Hovold jhov...@gmail.com --- drivers/usb/serial/cp210x.c | 3 --- drivers/usb/serial/oti6858.c | 3 --- 2 files changed, 6 deletions(-) diff --git a/drivers/usb/serial/cp210x.c

[PATCH 04/24] USB: serial: set drain delay at port probe

2013-06-26 Thread Johan Hovold
The port drain delay is constant and should be set at port probe rather than open. Signed-off-by: Johan Hovold jhov...@gmail.com --- drivers/usb/serial/cypress_m8.c | 4 +++- drivers/usb/serial/f81232.c | 3 ++- drivers/usb/serial/io_ti.c| 3 +--

[PATCH 24/24] USB: ti_usb_3410_5052: remove vendor/product module parameters

2013-06-26 Thread Johan Hovold
Remove the vendor and product module parameters which were added a long time ago when we did not have the dynamic sysfs interface to add new device ids (and which isn't limited to five new vid/pid pair). A vid/pid pair can be added dynamically using sysfs, for example: echo 0451 1234

[PATCH 20/24] USB: mos7840: remove broken chase implementation

2013-06-26 Thread Johan Hovold
Remove broken chase implementation which was supposed to be used to drain the write buffers at break. The chase implementation slept on a wait queue which was never woken up (i.e. no hardware buffers were queried), and thus amounted to nothing more than polling chars_in_buffer, something which

[PATCH 00/24] USB: serial: patches for v3.12

2013-06-26 Thread Johan Hovold
Here's a first round of patches for v3.12 (which I did not get ready in time for 3.11...). Note that I'm dropping the vendor/product parameters from all usb-serial modules which had them (generic, ftdi_sio, safe_serial and ti_usb_3410_5052) in favour of the more flexible sysfs interface. Thanks,

[PATCH 13/24] USB: ftdi_sio: clean up device initialisation

2013-06-26 Thread Johan Hovold
Do not use zeroed termios data to determine when to unconditionally configure the device at open. Signed-off-by: Johan Hovold jhov...@gmail.com --- drivers/usb/serial/ftdi_sio.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/usb/serial/ftdi_sio.c

[PATCH 02/24] USB: serial: remove hupping check from tiocmiwait

2013-06-26 Thread Johan Hovold
Since commit 31ca020b (TTY: wake up processes last at hangup) there no longer any need to check the hupping flag in the generic tiocmiwait implementation, so remove it. Signed-off-by: Johan Hovold jhov...@gmail.com --- drivers/usb/serial/generic.c | 13 ++--- 1 file changed, 2

[PATCH 23/24] USB: ti_usb_3410_5052: remove unused wait queue

2013-06-26 Thread Johan Hovold
The write wait queue is never added to since commit f1175daa5 (USB: ti_usb_3410_5052: kill custom closing_wait). Remove it completely. Signed-off-by: Johan Hovold jhov...@gmail.com --- drivers/usb/serial/ti_usb_3410_5052.c | 7 --- 1 file changed, 7 deletions(-) diff --git

[PATCH 03/24] USB: serial: clean up dtr_rts

2013-06-26 Thread Johan Hovold
Since commit 957dacae (TTY: fix DTR not being dropped on hang up) dtr_rts is no longer called for uninitialised ports (e.g. after a disconnect), which removes the need to grab the disconnect mutex. Signed-off-by: Johan Hovold jhov...@gmail.com --- drivers/usb/serial/usb-serial.c | 14

[PATCH 19/24] USB: io_ti: move port initialisation to probe

2013-06-26 Thread Johan Hovold
Move port initialisation code from open to probe where it belongs. Signed-off-by: Johan Hovold jhov...@gmail.com --- drivers/usb/serial/io_ti.c | 46 ++ 1 file changed, 26 insertions(+), 20 deletions(-) diff --git a/drivers/usb/serial/io_ti.c

[PATCH 10/24] USB: pl2303: clean up set_termios

2013-06-26 Thread Johan Hovold
Clean up set_termios somewhat. Signed-off-by: Johan Hovold jhov...@gmail.com --- drivers/usb/serial/pl2303.c | 39 ++- 1 file changed, 18 insertions(+), 21 deletions(-) diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c index

[PATCH 18/24] USB: io_ti: kill private fifo

2013-06-26 Thread Johan Hovold
Kill private write fifo and use the already allocated port write fifo instead. Signed-off-by: Johan Hovold jhov...@gmail.com --- drivers/usb/serial/io_ti.c | 22 +- 1 file changed, 5 insertions(+), 17 deletions(-) diff --git a/drivers/usb/serial/io_ti.c

[PATCH 15/24] USB: ftdi_sio: remove vendor/product module parameters

2013-06-26 Thread Johan Hovold
Remove the vendor and product module parameters which were added a long time ago when we did not have the dynamic sysfs interface to add new device ids (and which isn't limited to a single new vid/pid pair). A vid/pid pair can be added dynamically using sysfs, for example: echo 0403 1234

[PATCH 22/24] USB: ti_usb_3410_5052: kill private fifo

2013-06-26 Thread Johan Hovold
Kill private write fifo and use the already allocated port write fifo instead. Signed-off-by: Johan Hovold jhov...@gmail.com --- drivers/usb/serial/ti_usb_3410_5052.c | 20 ++-- 1 file changed, 6 insertions(+), 14 deletions(-) diff --git a/drivers/usb/serial/ti_usb_3410_5052.c

[PATCH 21/24] USB: safe_serial: remove vendor/product module parameters

2013-06-26 Thread Johan Hovold
Remove the vendor and product module parameters which were added a long time ago when we did not have the dynamic sysfs interface to add new device ids (and which isn't limited to a single new vid/pid pair). A vid/pid pair can be added dynamically using sysfs, for example: echo 04dd 1234

[PATCH 11/24] USB: pl2303: remove debugging noise

2013-06-26 Thread Johan Hovold
Only log the tty_flags in process_read_urb on errors. Signed-off-by: Johan Hovold jhov...@gmail.com --- drivers/usb/serial/pl2303.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c index 91f14c6..299a0ff 100644 ---

[PATCH 16/24] USB: ftdi_sio: remove unused defines

2013-06-26 Thread Johan Hovold
Remove some unused defines. Signed-off-by: Johan Hovold jhov...@gmail.com --- drivers/usb/serial/ftdi_sio.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c index 9bd1f6f..bebf3ef 100644 --- a/drivers/usb/serial/ftdi_sio.c

[RFC] am33xx: create child nodes for the two musb controllers

2013-06-26 Thread Sebastian Andrzej Siewior
I've been thinkig about creating two child nodes for the independent musb controllers on the am33. I've been thinking about the following: diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi index 8e1248f..6aa9506 100644 --- a/arch/arm/boot/dts/am33xx.dtsi +++

Re: Linux USB file storage gadget with new UDC

2013-06-26 Thread victor yeo
Hi, I re-attach the usbmon log. If possible, please show me which line indicates that usb_ep_set_wedge routine is not working, or how to look for the clue. Is it from the control transfer line? Here's an example: f4148f80 308532 S Bo:1:011:1 -115 31 = 55534243 0600 c000

Re: [PATCH] usb: host: xhci-plat: Enable XHCI_SPURIOUS_SUCCESS quirk for xhci-plat

2013-06-26 Thread Sarah Sharp
On Wed, Jun 26, 2013 at 02:28:57PM +0530, George Cherian wrote: Synopsis xhci controllers with hci_version 0.96 gives spurious success events on short packet completion. During webcam capture the ERROR Transfer event TRB DMA ptr not part of current TD was observed. The same application works

[PATCH 1/2] usb: dwc3: clean up redundant parameter comment

2013-06-26 Thread Huang Rui
@list is not as a parameter of dwc3_event_buffer, so remove it in comments. Signed-off-by: Huang Rui ray.hu...@amd.com --- drivers/usb/dwc3/core.h |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h index b69d322..c4b5127 100644 ---

Re: [PATCH 1/4] usb: phy: tegra: Add support for device tree-based vbus regulator control

2013-06-26 Thread Stephen Warren
On 06/26/2013 03:59 AM, Mikko Perttunen wrote: After this patch, usb vbus regulators for tegra usb phy devices can be specified with the device tree attribute vbus-supply = x where x is a regulator defined in the device tree. diff --git a/drivers/usb/phy/phy-tegra-usb.c

Re: [PATCH 2/4] usb: host: tegra: Remove direct vbus regulator control using GPIOs

2013-06-26 Thread Stephen Warren
On 06/26/2013 03:59 AM, Mikko Perttunen wrote: The tegra ehci driver has enabled USB vbus regulators directly using GPIOs and the device tree attribute nvidia,vbus-gpio. This is ugly and causes error messages on boot when both the regulator driver and the ehci driver want access to the same

Re: [PATCH 3/4] Documentation: devicetree: phy-tegra-usb: Add vbus-supply property for host mode PHYs

2013-06-26 Thread Stephen Warren
On 06/26/2013 03:59 AM, Mikko Perttunen wrote: Patch description? diff --git a/Documentation/devicetree/bindings/usb/nvidia,tegra20-usb-phy.txt b/Documentation/devicetree/bindings/usb/nvidia,tegra20-usb-phy.txt +Optional properties for dr_mode == host: + - vbus-supply: regulator for VBUS

[PATCH 2/2] usb: dwc3: fix wrong bit mask in dwc3_event_type

2013-06-26 Thread Huang Rui
Per dwc3 2.50a spec, the is_devspec bit is used to distinguish the Device Endpoint-Specific Event or Device-Specific Event (DEVT). If the bit is 1, the event is represented Device-Specific Event, then use [7:1] bits as Device Specific Event to marked the type. It has 7 bits, and we can see the

Re: [PATCH 4/4] ARM: dts: tegra20: Remove obsolete vbus-gpio properties

2013-06-26 Thread Stephen Warren
On 06/26/2013 03:59 AM, Mikko Perttunen wrote: USB VBUS regulators are now specified with the vbus-supply property instead of vbus-gpio, so remove the obsolete properties. As far as patch scheduling goes, I might be simpler to send one series to convert the driver to the new properties, then

Re: [RFC] [PATCH] Debugfs support for EHCI testing modes

2013-06-26 Thread Greg KH
On Wed, Jun 26, 2013 at 09:32:47AM +0200, Tim Sander wrote: Hi I have just written a ehci testing driver which enables the testing modes used for hw testing via a file in debugfs. This patch is for 3.4.47 not any usb branch. But if this driver is ready for mainline i will be happy to port

Re: [PATCH 1/2] ARM: dts: tegra20: Rename USB UTMI parameters according to new definitions

2013-06-26 Thread Stephen Warren
On 06/26/2013 05:58 AM, Mikko Perttunen wrote: Signed-off-by: Mikko Perttunen mperttu...@nvidia.com Damn. I thought that Venu had converted the *.dts files completely to match the new binding definition in the last series he sent. I guess he missed these because the driver doesn't use them yet

Re: [PATCH] staging: ozwpan: Convert printk to dev_dbg()

2013-06-26 Thread Jason Baron
On 06/25/2013 01:29 PM, Joe Perches wrote: On Tue, 2013-06-25 at 10:02 -0700, Greg KH wrote: On Tue, Jun 25, 2013 at 05:30:02PM +0100, Rupesh Gujare wrote: convert all debug messages from printk to dev_dbg() add kernel config to enable/disable these messages during compilation. No, just use

Re: [PATCH] staging: ozwpan: Convert printk to dev_dbg()

2013-06-26 Thread Jason Baron
On 06/25/2013 02:03 PM, Joe Perches wrote: (Using Jason Baron's most current email address) On Tue, 2013-06-25 at 10:56 -0700, Joe Perches wrote: On Tue, 2013-06-25 at 10:38 -0700, Greg KH wrote: On Tue, Jun 25, 2013 at 10:29:50AM -0700, Joe Perches wrote: a long needed extension to dev_dbg

Re: [PATCH v2 2/2] usb: phy: tegra: Read UTMIP parameters from device tree

2013-06-26 Thread Stephen Warren
On 06/26/2013 06:34 AM, Mikko Perttunen wrote: UTMIP parameters used to be hardcoded into tables in the PHY driver. This patch reads them from the device tree instead in accordance with the phy-tegra-usb DT documentation. This looks fine, although I'd like to have a chance to test all these

[PATCH] chipidea: bits: Cast PORTSC_PTS and DEVLC_PTS macros

2013-06-26 Thread Fabio Estevam
Fix the following build warnings on x86: drivers/usb/chipidea/core.c: In function 'hw_phymode_configure': drivers/usb/chipidea/core.c:226:3: warning: large integer implicitly truncated to unsigned type [-Woverflow] drivers/usb/chipidea/core.c:230:3: warning: large integer implicitly truncated

Re: [PATCH] staging: dwc2: fix thinko in dwc2_hc_set_even_odd_frame()

2013-06-26 Thread Stephen Warren
On 06/24/2013 12:34 PM, Paul Zimmerman wrote: I screwed up the sense of this if() statement while porting our vendor driver to create the dwc2 driver. This caused frame overrun errors on periodic transfers when there were other transfers active in the same (micro)frame. With this fix, the

  1   2   >