Re: sleeping while atomic in dwc3_gadget_start

2013-06-26 Thread Felipe Balbi
On Wed, Jun 26, 2013 at 02:52:56PM -0700, Stephen Boyd wrote: > Hi, > > I'm getting the folllowing BUG message on bootup with 3.10-rc5 > > BUG: sleeping function called from invalid context at mm/slub.c:926 > in_atomic(): 1, irqs_disabled(): 128, pid: 1, name: swapper/0 > CPU: 0 PID: 1 Comm: swap

Re: [RFC] am33xx: create child nodes for the two musb controllers

2013-06-26 Thread Felipe Balbi
Hi, On Wed, Jun 26, 2013 at 05:33:26PM +0200, Sebastian Andrzej Siewior wrote: > I've been thinkig about creating two child nodes for the independent musb > controllers on the am33. I've been thinking about the following: > > diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.d

Re: [PATCH 1/2] ARM: dts: tegra20: Rename USB UTMI parameters according to new definitions

2013-06-26 Thread Felipe Balbi
On Wed, Jun 26, 2013 at 11:44:58AM -0600, Stephen Warren wrote: > On 06/26/2013 05:58 AM, Mikko Perttunen wrote: > > Signed-off-by: Mikko Perttunen > > Damn. I thought that Venu had converted the *.dts files completely to > match the new binding definition in the last series he sent. I guess he >

Re: [PATCH 4/4] ARM: dts: tegra20: Remove obsolete vbus-gpio properties

2013-06-26 Thread Felipe Balbi
On Wed, Jun 26, 2013 at 11:19:45AM -0600, Stephen Warren wrote: > On 06/26/2013 03:59 AM, Mikko Perttunen wrote: > > USB VBUS regulators are now specified with the vbus-supply property > > instead of vbus-gpio, so remove the obsolete properties. > > As far as patch scheduling goes, I might be simp

[PATCH v2] usb: dwc3: make glue layers selectable

2013-06-26 Thread Felipe Balbi
Glue layers are starting to have separate requirements. For example, OMAP's glue layer is starting to use extcon framework which no one else needs. In order to make it clear the proper dependencies, we are now allowing glue layers to be selectable so that each glue layer can list their own depende

Re: [RFC/PATCH] usb: dwc3: make glue layers selectable

2013-06-26 Thread Felipe Balbi
On Wed, Jun 26, 2013 at 04:04:05PM +0200, Sebastian Andrzej Siewior wrote: > On 06/26/2013 03:34 PM, Felipe Balbi wrote: > > adding any default to any of those choices gives Kconfig warnings: > > Wait but why is it a choice in the first place? Why not making a plain > tristate symbol? You still wa

Re: [PATCH] usb: dwc3: core: continue probe even if usb3 phy is not available

2013-06-26 Thread Felipe Balbi
Hi, On Thu, Jun 27, 2013 at 08:14:16AM +0200, Michael Grzeschik wrote: > > > right, but in DT you will define both instances and each instance will > > > have a seaparate snps,maximum_speed attribute :-) > > > > > > I'm now considering if we should make maximum_speed a generic attribute, > > > Kis

Re: [PATCH] usb: dwc3: core: continue probe even if usb3 phy is not available

2013-06-26 Thread Michael Grzeschik
On Wed, Jun 26, 2013 at 03:46:45PM +0300, Alexander Shishkin wrote: > Felipe Balbi writes: > > > On Wed, Jun 26, 2013 at 05:37:19PM +0530, George Cherian wrote: > >> On 6/26/2013 3:46 PM, Felipe Balbi wrote: > >> >Hi, > >> > > >> >On Wed, Jun 26, 2013 at 02:59:14PM +0530, George Cherian wrote: >

Re: Proposed modification to PL2303 driver

2013-06-26 Thread Greg KH
On Wed, Jun 26, 2013 at 12:03:23PM +0200, Reinhard Max wrote: > On Tue, 25 Jun 2013 at 19:14, Greg KH wrote: > > >On Tue, Jun 25, 2013 at 11:54:37AM +0200, Reinhard Max wrote: > > > >>So, how about starting to get rid of the baud rate list by > >>skipping it for HX chips only until someone with a

Re: [PATCH v3] staging: usbip: replace pr_warning() with dev_warn().

2013-06-26 Thread Joe Perches
On Thu, 2013-06-27 at 10:05 +0530, navin patidar wrote: > dev_warn() is preferred over pr_warning(). [] > diff --git a/drivers/staging/usbip/usbip_event.c > b/drivers/staging/usbip/usbip_event.c [] > @@ -85,7 +87,20 @@ int usbip_start_eh(struct usbip_device *ud) > > ud->eh = kthread_run(eve

[PATCH v3] staging: usbip: replace pr_warning() with dev_warn().

2013-06-26 Thread navin patidar
dev_warn() is preferred over pr_warning(). container_of() is used to get usb_driver pointer from usbip_device container (stub_device or vhci_device), to get device structure required for dev_warn(). Signed-off-by: navin patidar --- drivers/staging/usbip/usbip_event.c | 17 - 1

Re: [PATCH 1/1] usb,uhci: add a new tag for virtual uhci devices

2013-06-26 Thread Li, Zhen-Hua (USL-China)
Hi Alan, I don't have a machine that this makes action different. No matter whether it makes different, there is one thing will never change: We create a patch to FIX a problem, not to avoid a problem. Only when we can not fix it, we try to avoid it. Thanks ZhenHua On 06/27/2013 03:17 AM, Alan

Re: [PATCH] staging: ozwpan: Convert printk to dev_dbg()

2013-06-26 Thread Joe Perches
On Wed, 2013-06-26 at 13:46 -0400, Jason Baron wrote: > echo "grouping control_var level N +p" > /debugfs/dynamic_debug/control > > or > > echo "grouping control_var mask 0xN +p" > /debugfs/dynamic_debug/control > > So we can think of the 'control_var' as 'grouping' debug statements > together.

[PATCH 03/10] USB: legousbtower: remove custom debug macro

2013-06-26 Thread Greg Kroah-Hartman
Don't use a custom debug macro for just one driver, instead rely on the in-kernel dynamic debugging logic, which can handle this much better. Cc: Juergen Stuber Signed-off-by: Greg Kroah-Hartman --- drivers/usb/misc/legousbtower.c | 27 +++ 1 file changed, 15 insertions(

[PATCH 06/10] USB: adutux: remove unneeded tracing macros

2013-06-26 Thread Greg Kroah-Hartman
Remove the unneeded tracing macros in this driver. The kernel has a built-in trace function that can be used if this is really still needed. Signed-off-by: Greg Kroah-Hartman --- drivers/usb/misc/adutux.c | 41 + 1 file changed, 1 insertion(+), 40 deletio

[PATCH 02/10] USB: legotower: remove unneeded tracing macros

2013-06-26 Thread Greg Kroah-Hartman
Remove the unneeded tracing macros in this driver. The kernel has a built-in trace function that can be used if this is really still needed. Cc: Juergen Stuber Signed-off-by: Greg Kroah-Hartman --- drivers/usb/misc/legousbtower.c | 42 + 1 file changed,

[PATCH 09/10] USB: adutux: remove direct calls to printk()

2013-06-26 Thread Greg Kroah-Hartman
Use the pr_* calls instead, which are much more descriptive. Signed-off-by: Greg Kroah-Hartman --- drivers/usb/misc/adutux.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/usb/misc/adutux.c b/drivers/usb/misc/adutux.c index b152581..3105f18 100644 --- a/

[PATCH 05/10] USB: legotower: remove direct calls to printk()

2013-06-26 Thread Greg Kroah-Hartman
Use the pr_* calls instead, which are much more descriptive. Cc: Juergen Stuber Signed-off-by: Greg Kroah-Hartman --- drivers/usb/misc/legousbtower.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/usb/misc/legousbtower.c b/drivers/usb/misc/legousbtower.

[PATCH 08/10] USB: adutux: remove custom debug macro and module parameter

2013-06-26 Thread Greg Kroah-Hartman
Now that we don't use the dbg() macro, remove it, and the module parameter. Also fix up the "dump_data" function to properly use the dynamic debug core and the correct printk options, and don't call it twice per function, as the data doesn't change from the beginning and the end of the call. Sign

[PATCH 04/10] USB: legotower: remove custom debug macro and module parameter

2013-06-26 Thread Greg Kroah-Hartman
Now that we don't use the dbg() macro, remove it, and the module parameter. Also fix up the "dump_data" function to properly use the dynamic debug core and the correct printk options, and don't call it twice per function, as the data doesn't change from the beginning and the end of the call. Cc:

[PATCH 07/10] USB: adutux: remove custom debug macro

2013-06-26 Thread Greg Kroah-Hartman
Don't use a custom debug macro for just one driver, instead rely on the in-kernel dynamic debugging logic, which can handle this much better. Signed-off-by: Greg Kroah-Hartman --- drivers/usb/misc/adutux.c | 97 --- 1 file changed, 58 insertions(+), 39

[PATCH 10/10] USB: misc: remove CONFIG_USB_DEBUG from Makefile

2013-06-26 Thread Greg Kroah-Hartman
Now that no usb misc driver is looking for CONFIG_USB_DEBUG, or DEBUG, don't enable it in the Makefile, as that's pointless. Signed-off-by: Greg Kroah-Hartman --- drivers/usb/misc/Makefile | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/usb/misc/Makefile b/drivers/usb/misc/Makefile

[PATCH 01/10] USB: ldusb: remove custom dbg_info() macro

2013-06-26 Thread Greg Kroah-Hartman
We want to get rid of CONFIG_USB_DEBUG, so remove the reliance of the ldusb driver on it. Don't use the custom macro, or a special module parameter, instead, rely on the in-kernel dynamic debugging infrastructure, which is much easier to use, and consistant across the whole kernel. Signed-off-by:

sleeping while atomic in dwc3_gadget_start

2013-06-26 Thread Stephen Boyd
Hi, I'm getting the folllowing BUG message on bootup with 3.10-rc5 BUG: sleeping function called from invalid context at mm/slub.c:926 in_atomic(): 1, irqs_disabled(): 128, pid: 1, name: swapper/0 CPU: 0 PID: 1 Comm: swapper/0 Not tainted 3.10.0-rc5-gee3e35b-09316-ge78f3b35 #643 [] (unwind_backt

Re: [RFC] [PATCH] Debugfs support for EHCI testing modes

2013-06-26 Thread Alan Stern
On Wed, 26 Jun 2013, Tim Sander wrote: > Hi > > I have just written a ehci testing driver which enables the testing modes used > for hw testing via a file in debugfs. This patch is for 3.4.47 not any usb > branch. But if this driver is ready for mainline i will be happy to port it to > whatever

Sound Blaster USB X-Fi configuration problem

2013-06-26 Thread Mariusz Grecki
The problem relates directly to the old one: http://thread.gmane.org/gmane.linux.usb.general/20816/focus=20850 The problem is, that usually (in fact all the time with one! exception so far) the card is recognized by operating system as a full-speed (FS) device not the high-speed (HS) one. This is

Re: [PATCH] staging: dwc2: fix thinko in dwc2_hc_set_even_odd_frame()

2013-06-26 Thread Stephen Warren
On 06/26/2013 02:20 PM, Paul Zimmerman wrote: >> From: Stephen Warren [mailto:swar...@wwwdotorg.org] >> Sent: Wednesday, June 26, 2013 12:13 PM >> >> On 06/24/2013 12:34 PM, Paul Zimmerman wrote: >>> I screwed up the sense of this if() statement while porting our >>> vendor driver to create the dwc

RE: [PATCH] staging: dwc2: fix thinko in dwc2_hc_set_even_odd_frame()

2013-06-26 Thread Paul Zimmerman
> From: Stephen Warren [mailto:swar...@wwwdotorg.org] > Sent: Wednesday, June 26, 2013 12:13 PM > > On 06/24/2013 12:34 PM, Paul Zimmerman wrote: > > I screwed up the sense of this if() statement while porting our > > vendor driver to create the dwc2 driver. This caused frame overrun > > errors on

Re: Hub disconnect after XactErrs

2013-06-26 Thread Alan Stern
On Tue, 25 Jun 2013, hobbe...@gmail.com wrote: > I am using an smsc 4-port IC hub that keeps disconnecting with a bunch > of XactErrs. I am using three high-speed mpeg encoders, and one USB > SD-card reader. The hub is wired into the host port of an SBC. > > If I use the same devices, kernel, d

Re: [PATCH 1/1] usb,uhci: add a new tag for virtual uhci devices

2013-06-26 Thread Alan Stern
On Wed, 26 Jun 2013, Li, Zhen-Hua wrote: > From: "Li, Zhen-Hua" > > There's another patch trying to fix this warning: > "Controller not stopped yet!". > It is : 997ff893603c6455da4c5e26ba1d0f81adfecdfc . > > I don't think it is appropriate to avoid auto-stop for all HP uhci > devices. So add

Re: Linux USB file storage gadget with new UDC

2013-06-26 Thread Alan Stern
On Wed, 26 Jun 2013, victor yeo wrote: > The fsg->state in gadget driver, is used for exception handling. Is > there any variable to track the USB device state of Figure 9-1 of the > USB 2.0 Spec? Now the gadget driver does not pass the "USB2.0 CV - Get > Device Descriptor - Address State test".

Re: [PATCH] staging: dwc2: fix thinko in dwc2_hc_set_even_odd_frame()

2013-06-26 Thread Stephen Warren
On 06/24/2013 12:34 PM, Paul Zimmerman wrote: > I screwed up the sense of this if() statement while porting our > vendor driver to create the dwc2 driver. This caused frame overrun > errors on periodic transfers when there were other transfers > active in the same (micro)frame. > > With this fix,

[PATCH] chipidea: bits: Cast PORTSC_PTS and DEVLC_PTS macros

2013-06-26 Thread Fabio Estevam
Fix the following build warnings on x86: drivers/usb/chipidea/core.c: In function 'hw_phymode_configure': drivers/usb/chipidea/core.c:226:3: warning: large integer implicitly truncated to unsigned type [-Woverflow] drivers/usb/chipidea/core.c:230:3: warning: large integer implicitly truncated to

Re: [PATCH v2 2/2] usb: phy: tegra: Read UTMIP parameters from device tree

2013-06-26 Thread Stephen Warren
On 06/26/2013 06:34 AM, Mikko Perttunen wrote: > UTMIP parameters used to be hardcoded into tables in the > PHY driver. This patch reads them from the device tree instead > in accordance with the phy-tegra-usb DT documentation. This looks fine, although I'd like to have a chance to test all these

Re: [PATCH] staging: ozwpan: Convert printk to dev_dbg()

2013-06-26 Thread Jason Baron
On 06/25/2013 02:03 PM, Joe Perches wrote: > (Using Jason Baron's most current email address) > > On Tue, 2013-06-25 at 10:56 -0700, Joe Perches wrote: >> On Tue, 2013-06-25 at 10:38 -0700, Greg KH wrote: >>> On Tue, Jun 25, 2013 at 10:29:50AM -0700, Joe Perches wrote: a long needed extension

Re: [PATCH] staging: ozwpan: Convert printk to dev_dbg()

2013-06-26 Thread Jason Baron
On 06/25/2013 01:29 PM, Joe Perches wrote: > On Tue, 2013-06-25 at 10:02 -0700, Greg KH wrote: >> On Tue, Jun 25, 2013 at 05:30:02PM +0100, Rupesh Gujare wrote: >>> convert all debug messages from printk to dev_dbg() & add kernel config to >>> enable/disable these messages during compilation. >> No

Re: [PATCH 1/2] ARM: dts: tegra20: Rename USB UTMI parameters according to new definitions

2013-06-26 Thread Stephen Warren
On 06/26/2013 05:58 AM, Mikko Perttunen wrote: > Signed-off-by: Mikko Perttunen Damn. I thought that Venu had converted the *.dts files completely to match the new binding definition in the last series he sent. I guess he missed these because the driver doesn't use them yet and he wasn't paying a

Re: [RFC] [PATCH] Debugfs support for EHCI testing modes

2013-06-26 Thread Greg KH
On Wed, Jun 26, 2013 at 09:32:47AM +0200, Tim Sander wrote: > Hi > > I have just written a ehci testing driver which enables the testing modes used > for hw testing via a file in debugfs. This patch is for 3.4.47 not any usb > branch. But if this driver is ready for mainline i will be happy to po

Re: [PATCH 4/4] ARM: dts: tegra20: Remove obsolete vbus-gpio properties

2013-06-26 Thread Stephen Warren
On 06/26/2013 03:59 AM, Mikko Perttunen wrote: > USB VBUS regulators are now specified with the vbus-supply property > instead of vbus-gpio, so remove the obsolete properties. As far as patch scheduling goes, I might be simpler to send one series to convert the driver to the new properties, then o

[PATCH 2/2] usb: dwc3: fix wrong bit mask in dwc3_event_type

2013-06-26 Thread Huang Rui
Per dwc3 2.50a spec, the is_devspec bit is used to distinguish the Device Endpoint-Specific Event or Device-Specific Event (DEVT). If the bit is 1, the event is represented Device-Specific Event, then use [7:1] bits as Device Specific Event to marked the type. It has 7 bits, and we can see the rese

Re: [PATCH 3/4] Documentation: devicetree: phy-tegra-usb: Add vbus-supply property for host mode PHYs

2013-06-26 Thread Stephen Warren
On 06/26/2013 03:59 AM, Mikko Perttunen wrote: Patch description? > diff --git a/Documentation/devicetree/bindings/usb/nvidia,tegra20-usb-phy.txt > b/Documentation/devicetree/bindings/usb/nvidia,tegra20-usb-phy.txt > +Optional properties for dr_mode == host: > + - vbus-supply: regulator for VB

Re: [PATCH 2/4] usb: host: tegra: Remove direct vbus regulator control using GPIOs

2013-06-26 Thread Stephen Warren
On 06/26/2013 03:59 AM, Mikko Perttunen wrote: > The tegra ehci driver has enabled USB vbus regulators directly using > GPIOs and the device tree attribute nvidia,vbus-gpio. This is ugly > and causes error messages on boot when both the regulator driver > and the ehci driver want access to the same

Re: [PATCH 1/4] usb: phy: tegra: Add support for device tree-based vbus regulator control

2013-06-26 Thread Stephen Warren
On 06/26/2013 03:59 AM, Mikko Perttunen wrote: > After this patch, usb vbus regulators for tegra usb phy devices can be > specified > with the device tree attribute vbus-supply = <&x> where x is a regulator > defined > in the device tree. > diff --git a/drivers/usb/phy/phy-tegra-usb.c b/drivers/

[PATCH 1/2] usb: dwc3: clean up redundant parameter comment

2013-06-26 Thread Huang Rui
@list is not as a parameter of dwc3_event_buffer, so remove it in comments. Signed-off-by: Huang Rui --- drivers/usb/dwc3/core.h |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h index b69d322..c4b5127 100644 --- a/drivers/usb/dwc3/core.h +++

Re: [PATCH] usb: host: xhci-plat: Enable XHCI_SPURIOUS_SUCCESS quirk for xhci-plat

2013-06-26 Thread Sarah Sharp
On Wed, Jun 26, 2013 at 02:28:57PM +0530, George Cherian wrote: > Synopsis xhci controllers with hci_version > 0.96 gives spurious success > events on short packet completion. During webcam capture the > "ERROR Transfer event TRB DMA ptr not part of current TD" was observed. > The same application

Re: Linux USB file storage gadget with new UDC

2013-06-26 Thread victor yeo
Hi, >> I re-attach the usbmon log. If possible, please show me which line >> indicates that usb_ep_set_wedge routine is not working, or how to look >> for the clue. Is it from the control transfer line? > > Here's an example: > > f4148f80 308532 S Bo:1:011:1 -115 31 = 55534243 0600 c00

[RFC] am33xx: create child nodes for the two musb controllers

2013-06-26 Thread Sebastian Andrzej Siewior
I've been thinkig about creating two child nodes for the independent musb controllers on the am33. I've been thinking about the following: diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi index 8e1248f..6aa9506 100644 --- a/arch/arm/boot/dts/am33xx.dtsi +++ b/arch/arm/boo

Re: [PATCH 00/24] USB: serial: patches for v3.12

2013-06-26 Thread Greg KH
On Wed, Jun 26, 2013 at 04:47:19PM +0200, Johan Hovold wrote: > Here's a first round of patches for v3.12 (which I did not get ready in > time for 3.11...). > > Note that I'm dropping the vendor/product parameters from all usb-serial > modules which had them (generic, ftdi_sio, safe_serial and > t

[PATCH 16/24] USB: ftdi_sio: remove unused defines

2013-06-26 Thread Johan Hovold
Remove some unused defines. Signed-off-by: Johan Hovold --- drivers/usb/serial/ftdi_sio.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c index 9bd1f6f..bebf3ef 100644 --- a/drivers/usb/serial/ftdi_sio.c +++ b/drivers/usb/se

[PATCH 11/24] USB: pl2303: remove debugging noise

2013-06-26 Thread Johan Hovold
Only log the tty_flags in process_read_urb on errors. Signed-off-by: Johan Hovold --- drivers/usb/serial/pl2303.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c index 91f14c6..299a0ff 100644 --- a/drivers/usb/seria

[PATCH 21/24] USB: safe_serial: remove vendor/product module parameters

2013-06-26 Thread Johan Hovold
Remove the vendor and product module parameters which were added a long time ago when we did not have the dynamic sysfs interface to add new device ids (and which isn't limited to a single new vid/pid pair). A vid/pid pair can be added dynamically using sysfs, for example: echo 04dd 1234 >/sys/

[PATCH 22/24] USB: ti_usb_3410_5052: kill private fifo

2013-06-26 Thread Johan Hovold
Kill private write fifo and use the already allocated port write fifo instead. Signed-off-by: Johan Hovold --- drivers/usb/serial/ti_usb_3410_5052.c | 20 ++-- 1 file changed, 6 insertions(+), 14 deletions(-) diff --git a/drivers/usb/serial/ti_usb_3410_5052.c b/drivers/usb/seri

[PATCH 15/24] USB: ftdi_sio: remove vendor/product module parameters

2013-06-26 Thread Johan Hovold
Remove the vendor and product module parameters which were added a long time ago when we did not have the dynamic sysfs interface to add new device ids (and which isn't limited to a single new vid/pid pair). A vid/pid pair can be added dynamically using sysfs, for example: echo 0403 1234

[PATCH 17/24] USB: io_edgeport: remove unused defines

2013-06-26 Thread Johan Hovold
Remove unused timeout defines. Signed-off-by: Johan Hovold --- drivers/usb/serial/io_edgeport.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/usb/serial/io_edgeport.c b/drivers/usb/serial/io_edgeport.c index dc2803b..c91481d 100644 --- a/drivers/usb/serial/io_edgeport.c +++ b/driv

[PATCH 10/24] USB: pl2303: clean up set_termios

2013-06-26 Thread Johan Hovold
Clean up set_termios somewhat. Signed-off-by: Johan Hovold --- drivers/usb/serial/pl2303.c | 39 ++- 1 file changed, 18 insertions(+), 21 deletions(-) diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c index dd59c64..91f14c6 100644 --- a/d

[PATCH 18/24] USB: io_ti: kill private fifo

2013-06-26 Thread Johan Hovold
Kill private write fifo and use the already allocated port write fifo instead. Signed-off-by: Johan Hovold --- drivers/usb/serial/io_ti.c | 22 +- 1 file changed, 5 insertions(+), 17 deletions(-) diff --git a/drivers/usb/serial/io_ti.c b/drivers/usb/serial/io_ti.c index d43a

[PATCH 19/24] USB: io_ti: move port initialisation to probe

2013-06-26 Thread Johan Hovold
Move port initialisation code from open to probe where it belongs. Signed-off-by: Johan Hovold --- drivers/usb/serial/io_ti.c | 46 ++ 1 file changed, 26 insertions(+), 20 deletions(-) diff --git a/drivers/usb/serial/io_ti.c b/drivers/usb/serial/io_ti

[PATCH 23/24] USB: ti_usb_3410_5052: remove unused wait queue

2013-06-26 Thread Johan Hovold
The write wait queue is never added to since commit f1175daa5 ("USB: ti_usb_3410_5052: kill custom closing_wait"). Remove it completely. Signed-off-by: Johan Hovold --- drivers/usb/serial/ti_usb_3410_5052.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/usb/serial/ti_usb_3410_

[PATCH 03/24] USB: serial: clean up dtr_rts

2013-06-26 Thread Johan Hovold
Since commit 957dacae ("TTY: fix DTR not being dropped on hang up") dtr_rts is no longer called for uninitialised ports (e.g. after a disconnect), which removes the need to grab the disconnect mutex. Signed-off-by: Johan Hovold --- drivers/usb/serial/usb-serial.c | 14 ++ 1 file chan

[PATCH 00/24] USB: serial: patches for v3.12

2013-06-26 Thread Johan Hovold
Here's a first round of patches for v3.12 (which I did not get ready in time for 3.11...). Note that I'm dropping the vendor/product parameters from all usb-serial modules which had them (generic, ftdi_sio, safe_serial and ti_usb_3410_5052) in favour of the more flexible sysfs interface. Thanks,

[PATCH 13/24] USB: ftdi_sio: clean up device initialisation

2013-06-26 Thread Johan Hovold
Do not use zeroed termios data to determine when to unconditionally configure the device at open. Signed-off-by: Johan Hovold --- drivers/usb/serial/ftdi_sio.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c

[PATCH 01/24] USB: serial: remove defensive test from set_termios

2013-06-26 Thread Johan Hovold
Remove defensive test from set_termios which is never called with a NULL tty. Signed-off-by: Johan Hovold --- drivers/usb/serial/cp210x.c | 3 --- drivers/usb/serial/oti6858.c | 3 --- 2 files changed, 6 deletions(-) diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c index

[PATCH 20/24] USB: mos7840: remove broken chase implementation

2013-06-26 Thread Johan Hovold
Remove broken "chase" implementation which was supposed to be used to drain the write buffers at break. The chase implementation slept on a wait queue which was never woken up (i.e. no hardware buffers were queried), and thus amounted to nothing more than polling chars_in_buffer, something which h

[PATCH 09/24] USB: pl2303: clean up baud-rate handling

2013-06-26 Thread Johan Hovold
Clean up baud-rate handling somewhat. Signed-off-by: Johan Hovold --- drivers/usb/serial/pl2303.c | 90 + 1 file changed, 41 insertions(+), 49 deletions(-) diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c index c15d64d..dd59c64 1

[PATCH 06/24] USB: console: use dev_dbg

2013-06-26 Thread Johan Hovold
Use dev_dbg for debugging. Signed-off-by: Johan Hovold --- drivers/usb/serial/console.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/usb/serial/console.c b/drivers/usb/serial/console.c index afb50ea..bfad2cd 100644 --- a/drivers/usb/serial/console.c +++ b/

[PATCH 02/24] USB: serial: remove hupping check from tiocmiwait

2013-06-26 Thread Johan Hovold
Since commit 31ca020b ("TTY: wake up processes last at hangup") there no longer any need to check the hupping flag in the generic tiocmiwait implementation, so remove it. Signed-off-by: Johan Hovold --- drivers/usb/serial/generic.c | 13 ++--- 1 file changed, 2 insertions(+), 11 deletion

[PATCH 04/24] USB: serial: set drain delay at port probe

2013-06-26 Thread Johan Hovold
The port drain delay is constant and should be set at port probe rather than open. Signed-off-by: Johan Hovold --- drivers/usb/serial/cypress_m8.c | 4 +++- drivers/usb/serial/f81232.c | 3 ++- drivers/usb/serial/io_ti.c| 3 +-- drivers/usb/serial/oti6858.c |

[PATCH 24/24] USB: ti_usb_3410_5052: remove vendor/product module parameters

2013-06-26 Thread Johan Hovold
Remove the vendor and product module parameters which were added a long time ago when we did not have the dynamic sysfs interface to add new device ids (and which isn't limited to five new vid/pid pair). A vid/pid pair can be added dynamically using sysfs, for example: echo 0451 1234 >/sys/bus/

[PATCH 05/24] USB: serial: remove generic vendor/product module parameters

2013-06-26 Thread Johan Hovold
Remove the vendor and product module parameters which were added a long time ago when we did not have the dynamic sysfs interface to add new device ids (and which isn't limited to a single new vid/pid pair). A vid/pid pair can be added dynamically using sysfs, for example: echo 1234 5678 >/sys/

[PATCH 08/24] USB: pl2303: refactor baud-rate handling

2013-06-26 Thread Johan Hovold
Break out baud-rate handling from set_termios. Signed-off-by: Johan Hovold --- drivers/usb/serial/pl2303.c | 127 1 file changed, 69 insertions(+), 58 deletions(-) diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c index ed9edb2..

[PATCH 14/24] USB: ftdi_sio: remove redundant raise of DTR/RTS at open

2013-06-26 Thread Johan Hovold
Do not raise DTR/RTS a second time in set_termios at open -- this has already been taken care of by the tty layer. Signed-off-by: Johan Hovold --- drivers/usb/serial/ftdi_sio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/

[PATCH 07/24] USB: console: remove unnecessary operations test

2013-06-26 Thread Johan Hovold
Remove unnecessary tests for open and write operations as these are set to the generic implementations by usb-serial core if left unset by a subdriver. Signed-off-by: Johan Hovold --- drivers/usb/serial/console.c | 18 +++--- 1 file changed, 3 insertions(+), 15 deletions(-) diff --g

[PATCH 12/24] USB: oti6858: do not call set_termios with uninitialised data

2013-06-26 Thread Johan Hovold
Make sure set_termios is not called with uninitialised data at open. The old termios struct is currently not used, but pass NULL instead to avoid future problems (e.g. stack data leak). Signed-off-by: Johan Hovold --- drivers/usb/serial/oti6858.c | 3 +-- 1 file changed, 1 insertion(+), 2 deleti

Re: [PATCH] staging: ozwpan: Use normal Makefile, convert oz_trace to oz_dbg

2013-06-26 Thread Joe Perches
On Wed, 2013-06-26 at 06:56 -0700, Joe Perches wrote: > On Wed, 2013-06-26 at 12:53 +0100, Rupesh Gujare wrote: > > Above macros look good, however Greg have objection to define new macros > > & he had suggested to use dev_dbg() & pr_debug(). These macros already use pr_debug and should use dev_d

Re: [RFC/PATCH] usb: dwc3: make glue layers selectable

2013-06-26 Thread Sebastian Andrzej Siewior
On 06/26/2013 03:34 PM, Felipe Balbi wrote: > adding any default to any of those choices gives Kconfig warnings: Wait but why is it a choice in the first place? Why not making a plain tristate symbol? You still want to enable all of them at once, don't you? Sebastian -- To unsubscribe from this l

Re: URB completion order, normal behavior or bug?

2013-06-26 Thread Daniel Santos
On 06/25/2013 05:42 PM, Daniel Santos wrote: On 06/25/2013 09:45 AM, Alan Stern wrote: static __always_inline int init_endpoint(struct mcp2210_device *dev, const struct usb_host_endpoint *ep) { int is_dir_in = !!usb_endpoint_dir_in(&ep->desc); struct mcp2210_en

Re: [PATCH] staging: ozwpan: Use normal Makefile, convert oz_trace to oz_dbg

2013-06-26 Thread Joe Perches
On Wed, 2013-06-26 at 12:53 +0100, Rupesh Gujare wrote: > On 26/06/13 02:00, Joe Perches wrote: > > Use a normal Makefile. > > Convert oz_trace and oz_trace2 to a more normal oz_dbg. > > Consolidate oztrace and ozconfig files to ozdbg.h > > Update #include files. > > Reflow modified lines, fit to 8

Re: [RFC/PATCH] usb: dwc3: make glue layers selectable

2013-06-26 Thread Felipe Balbi
On Wed, Jun 26, 2013 at 06:40:22PM +0530, George Cherian wrote: > On 6/26/2013 6:11 PM, Felipe Balbi wrote: > >Glue layers are starting to have separate > >requirements. For example, OMAP's glue layer > >is starting to use extcon framework which > >no one else needs. > > > >In order to make it clea

Re: [RFC PATCH 4/6] USB: ehci-omap: Suspend the controller during bus suspend

2013-06-26 Thread Roger Quadros
On 06/25/2013 08:38 PM, Alan Stern wrote: > On Tue, 25 Jun 2013, Roger Quadros wrote: > >> On 06/24/2013 10:34 PM, Alan Stern wrote: >>> On Mon, 24 Jun 2013, Roger Quadros wrote: >>> OK I've tried to handle all this in an alternate way. Now the controller suspend/resume and runtime

Re: [RFC/PATCH] usb: dwc3: make glue layers selectable

2013-06-26 Thread Felipe Balbi
On Wed, Jun 26, 2013 at 02:58:46PM +0200, Sebastian Andrzej Siewior wrote: > On 06/26/2013 02:41 PM, Felipe Balbi wrote: > > > Note that this will require defconfig changes unless someone > > knows about a choice-like Kconfig construct which allows defaults. > > You can "default y" so it will be

Re: [RFC/PATCH] usb: dwc3: make glue layers selectable

2013-06-26 Thread George Cherian
On 6/26/2013 6:11 PM, Felipe Balbi wrote: Glue layers are starting to have separate requirements. For example, OMAP's glue layer is starting to use extcon framework which no one else needs. In order to make it clear the proper dependencies, we are now allowing glue layers to be selectable so tha

Re: [RFC/PATCH] usb: dwc3: make glue layers selectable

2013-06-26 Thread Sebastian Andrzej Siewior
On 06/26/2013 02:41 PM, Felipe Balbi wrote: > Note that this will require defconfig changes unless someone > knows about a choice-like Kconfig construct which allows defaults. You can "default y" so it will be always selected if it is possible which was the default and drop it after a few kernel

Re: [PATCH v2] staging: usbip: replace pr_warning() with dev_warn().

2013-06-26 Thread Sergei Shtylyov
Hello. On 26-06-2013 13:41, navin patidar wrote: dev_warn() is preferred over pr_warning(). container_of() is used to get usb_driver pointer from usbip_device container (stub_device or vhci_device), to get device structure required for dev_warn(). Signed-off-by: navin patidar --- drive

Re: [PATCH] usb: dwc3: core: continue probe even if usb3 phy is not available

2013-06-26 Thread Alexander Shishkin
Felipe Balbi writes: > On Wed, Jun 26, 2013 at 05:37:19PM +0530, George Cherian wrote: >> On 6/26/2013 3:46 PM, Felipe Balbi wrote: >> >Hi, >> > >> >On Wed, Jun 26, 2013 at 02:59:14PM +0530, George Cherian wrote: >> >>There can be configurations in which DWC3 is hoooked up only to USB2 PHY. >> >>

[RFC/PATCH] usb: dwc3: make glue layers selectable

2013-06-26 Thread Felipe Balbi
Glue layers are starting to have separate requirements. For example, OMAP's glue layer is starting to use extcon framework which no one else needs. In order to make it clear the proper dependencies, we are now allowing glue layers to be selectable so that each glue layer can list their own depende

[PATCH v2 0/2] usb: phy: tegra: Read UTMI parameters from device tree

2013-06-26 Thread Mikko Perttunen
This patchset moves the USB UTMI interface parameters from hardcoded tables in the PHY driver to device tree and adds code to read them from there. Mikko Perttunen (2): ARM: dts: tegra20: Rename USB UTMI parameters according to new definitions usb: phy: tegra: Read UTMIP parameters from de

[PATCH v2 1/2] ARM: dts: tegra20: Rename USB UTMI parameters according to new definitions

2013-06-26 Thread Mikko Perttunen
This patch changes the Tegra20 USB PHY nodes to use the UTMI configuration parameter names as specified in the device tree binding documentation after patch "ARM: tegra: finalize USB EHCI and PHY bindings". Signed-off-by: Mikko Perttunen --- arch/arm/boot/dts/tegra20.dtsi | 28 ++

[PATCH v2 2/2] usb: phy: tegra: Read UTMIP parameters from device tree

2013-06-26 Thread Mikko Perttunen
UTMIP parameters used to be hardcoded into tables in the PHY driver. This patch reads them from the device tree instead in accordance with the phy-tegra-usb DT documentation. Signed-off-by: Mikko Perttunen --- drivers/usb/phy/phy-tegra-usb.c | 129 +++- 1 file

Re: [PATCH] usb: host: xhci-plat: Enable XHCI_SPURIOUS_SUCCESS quirk for xhci-plat

2013-06-26 Thread Felipe Balbi
Hi, On Wed, Jun 26, 2013 at 05:46:29PM +0530, George Cherian wrote: > >>@@ -25,6 +25,16 @@ static void xhci_plat_quirks(struct device *dev, struct > >>xhci_hcd *xhci) > >> * dev struct in order to setup MSI > >> */ > >>xhci->quirks |= XHCI_BROKEN_MSI; > >>+ > >>+ /* > >>+* In so

build warning on chipidea core

2013-06-26 Thread Felipe Balbi
Hi, just below warnings when building greg/usb-next for x86: drivers/usb/chipidea/core.c: In function ‘hw_phymode_configure’: drivers/usb/chipidea/core.c:226:3: warning: large integer implicitly truncated to unsigned type [-Woverflow] drivers/usb/chipidea/core.c:230:3: warning: large integer imp

Re: [PATCH 1/2] ARM: dts: tegra20: Rename USB UTMI parameters according to new definitions

2013-06-26 Thread Mikko Perttunen
On Wed, 26 Jun 2013 15:14:42 +0300, Felipe Balbi wrote: * PGP Signed by an unknown key On Wed, Jun 26, 2013 at 02:58:46PM +0300, Mikko Perttunen wrote: Signed-off-by: Mikko Perttunen you need a commit log, sorry. Even if obvious Ok, I'll send V2 -- To unsubscribe from this list: send th

Re: [PATCH] usb: host: xhci-plat: Enable XHCI_SPURIOUS_SUCCESS quirk for xhci-plat

2013-06-26 Thread George Cherian
On 6/26/2013 2:32 PM, Felipe Balbi wrote: Hi, On Wed, Jun 26, 2013 at 02:28:57PM +0530, George Cherian wrote: Synopsis xhci controllers with hci_version > 0.96 gives spurious success events on short packet completion. During webcam capture the "ERROR Transfer event TRB DMA ptr not part of curre

Re: [PATCH 1/2] ARM: dts: tegra20: Rename USB UTMI parameters according to new definitions

2013-06-26 Thread Felipe Balbi
On Wed, Jun 26, 2013 at 02:58:46PM +0300, Mikko Perttunen wrote: > Signed-off-by: Mikko Perttunen you need a commit log, sorry. Even if obvious -- balbi signature.asc Description: Digital signature

Re: [PATCH] usb: dwc3: core: continue probe even if usb3 phy is not available

2013-06-26 Thread Felipe Balbi
On Wed, Jun 26, 2013 at 05:37:19PM +0530, George Cherian wrote: > On 6/26/2013 3:46 PM, Felipe Balbi wrote: > >Hi, > > > >On Wed, Jun 26, 2013 at 02:59:14PM +0530, George Cherian wrote: > >>There can be configurations in which DWC3 is hoooked up only to USB2 PHY. > >>In such cases we should not ret

Re: [PATCH v9 1/8] drivers: phy: add generic PHY framework

2013-06-26 Thread Felipe Balbi
On Wed, Jun 26, 2013 at 05:17:29PM +0530, Kishon Vijay Abraham I wrote: > The PHY framework provides a set of APIs for the PHY drivers to > create/destroy a PHY and APIs for the PHY users to obtain a reference to the > PHY with or without using phandle. For dt-boot, the PHY drivers should > also re

Re: [PATCH] usb: dwc3: core: continue probe even if usb3 phy is not available

2013-06-26 Thread George Cherian
On 6/26/2013 3:46 PM, Felipe Balbi wrote: Hi, On Wed, Jun 26, 2013 at 02:59:14PM +0530, George Cherian wrote: There can be configurations in which DWC3 is hoooked up only to USB2 PHY. In such cases we should not return -EPROBE_DEFER, rather continue probe even if there is no USB3 PHY. Signed-o

[PATCH 2/2] usb: phy: tegra: Read UTMIP parameters from device tree

2013-06-26 Thread Mikko Perttunen
UTMIP parameters used to be hardcoded into tables in the PHY driver. This patch moves them into the device tree in accordance with the phy-tegra-usb DT documentation. Signed-off-by: Mikko Perttunen --- drivers/usb/phy/phy-tegra-usb.c | 129 +++- 1 file changed

[PATCH 1/2] ARM: dts: tegra20: Rename USB UTMI parameters according to new definitions

2013-06-26 Thread Mikko Perttunen
Signed-off-by: Mikko Perttunen --- arch/arm/boot/dts/tegra20.dtsi | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/arch/arm/boot/dts/tegra20.dtsi b/arch/arm/boot/dts/tegra20.dtsi index 9653fd8..e457083 100644 --- a/arch/arm/boot/dts/tegra20.dtsi +

Re: [PATCH] staging: ozwpan: Use normal Makefile, convert oz_trace to oz_dbg

2013-06-26 Thread Rupesh Gujare
On 26/06/13 02:00, Joe Perches wrote: Use a normal Makefile. Convert oz_trace and oz_trace2 to a more normal oz_dbg. Consolidate oztrace and ozconfig files to ozdbg.h Update #include files. Reflow modified lines, fit to 80 cols, align arguments. Add a couple more oz__dbg macros to show how more

[PATCH v9 3/8] usb: phy: twl4030: use the new generic PHY framework

2013-06-26 Thread Kishon Vijay Abraham I
Used the generic PHY framework API to create the PHY. For powering on and powering off the PHY, power_on and power_off ops are used. Once the MUSB OMAP glue is adapted to the new framework, the suspend and resume ops of usb phy library will be removed. However using the old usb phy library cannot

  1   2   >