Re: [PATCH] USBIP:stub_dev.c fixing string splitted into multiple line issue

2013-08-01 Thread Julia Lawall
> Thanks you all for suggestions. I'll try finding some other way. If the strings don't fit, you can just go over 80 characters. julia -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.

Re: [PATCH v2] usb-gadget-audio-file-wake-up-sleep-thread

2013-08-01 Thread Qiao Zhou
On 08/01/2013 06:21 PM, Qiao Zhou wrote: v2->v1: stop pcm stream instead of wake up the sleep thread, which is more reasonable. Qiao Zhou (1): usb: gadget: audio file: wake up sleep thread when device unbind drivers/usb/gadget/f_audio_source.c | 11 +-- 1 files changed, 9 insert

[PATCH resend] MAINTAINERS: Add separate section for USB NETWORKING DRIVERS

2013-08-01 Thread Joe Perches
There are several drivers in drivers/net/usb/ that do not have specific MAINTAINERS that should have emails forwarded to the linux-usb mailing list. Add a section for those drivers. Signed-off-by: Joe Perches --- > In the future, you do not need to send drivers/net/usb/ patches to me, > netdev a

Re: [PATCH] MAINTAINERS: Add separate section for USB NETWORKING DRIVERS

2013-08-01 Thread Greg KH
On Thu, Aug 01, 2013 at 08:50:10PM -0700, Joe Perches wrote: > On Fri, 2013-08-02 at 11:30 +0800, Greg KH wrote: > > On Thu, Aug 01, 2013 at 01:09:55AM -0700, Joe Perches wrote: > > > Lots of "maintainers" don't apply patches. > > I have no idea what you are meaning here. > > Just that maintainers

Re: [PATCH] MAINTAINERS: Add separate section for USB NETWORKING DRIVERS

2013-08-01 Thread Joe Perches
On Fri, 2013-08-02 at 11:30 +0800, Greg KH wrote: > On Thu, Aug 01, 2013 at 01:09:55AM -0700, Joe Perches wrote: > > Lots of "maintainers" don't apply patches. > I have no idea what you are meaning here. Just that maintainers aren't necessarily appliers. In fact, most aren't. > Add netdev to the

Re: [PATCH v5 1/5] USB: HCD: support giveback of URB in tasklet context

2013-08-01 Thread Greg Kroah-Hartman
On Fri, Aug 02, 2013 at 11:30:54AM +0800, Ming Lei wrote: > On Fri, Aug 2, 2013 at 11:28 AM, Greg Kroah-Hartman > wrote: > > On Wed, Jul 03, 2013 at 10:53:07PM +0800, Ming Lei wrote: > >> 1), for drivers, they don't care if the complete() is called in hard irq > >> context or softirq context > > >

Re: [PATCH v5 1/5] USB: HCD: support giveback of URB in tasklet context

2013-08-01 Thread Ming Lei
On Fri, Aug 2, 2013 at 11:28 AM, Greg Kroah-Hartman wrote: > On Wed, Jul 03, 2013 at 10:53:07PM +0800, Ming Lei wrote: >> 1), for drivers, they don't care if the complete() is called in hard irq >> context or softirq context > > What about those 50+ patches you had that changed the locking for urb

Re: [PATCH] MAINTAINERS: Add separate section for USB NETWORKING DRIVERS

2013-08-01 Thread Greg KH
On Thu, Aug 01, 2013 at 01:09:55AM -0700, Joe Perches wrote: > On Thu, 2013-08-01 at 15:56 +0800, Greg KH wrote: > > On Thu, Aug 01, 2013 at 12:48:48AM -0700, Joe Perches wrote: > > > There are several drivers in drivers/net/usb/ that > > > do not have specific MAINTAINERS that should have > > > em

Re: [PATCH v5 1/5] USB: HCD: support giveback of URB in tasklet context

2013-08-01 Thread Greg Kroah-Hartman
On Wed, Jul 03, 2013 at 10:53:07PM +0800, Ming Lei wrote: > 1), for drivers, they don't care if the complete() is called in hard irq > context or softirq context What about those 50+ patches you had that changed the locking for urb callbacks? Aren't they needed before this patch can go in? > ---

Re: [PATCHv2 1/2][usbutils] lsusb: port to hwdb

2013-08-01 Thread Greg KH
On Wed, Jul 24, 2013 at 12:37:30PM +0200, Tom Gundersen wrote: > Most of the information in usb.ids is now contained in udev's hwdb. Read the > information from the hwdb instead of usb.ids. > > This would allow distributions to no longer ship (most of) usb.ids by default, > but rather keep all the

Re: [PATCH] usb: chipidea: udc: fix potential kernel panic

2013-08-01 Thread Peter Chen
On Tue, Jun 04, 2013 at 08:17:57PM +0800, 21cn...@gmail.com wrote: > From: Rong Wang > > If global_phy is used when CONFIG_USB_PHY is not defined, > usb_get_phy() returns ERR_PTR(-ENXIO). If we only check > ci->transceiver is NULL or not in vbus_draw callback, it > will return true and continue t

Re: question: do we have any UML like design diagram for usb core and driver model?

2013-08-01 Thread Greg KH
On Fri, Aug 02, 2013 at 09:56:17AM +0800, Chen Wang wrote: > On Thu, 2013-08-01 at 10:34 -0400, Alan Stern wrote: > > On Thu, 1 Aug 2013, Oliver Neukum wrote: > > > > > On Thu, 2013-08-01 at 17:13 +0800, Chen Wang wrote: > > > > hello, > > > > I'm reading code of usb core and driver model/sysfs. I

Re: [PATCH] USBIP:stub_dev.c fixing string splitted into multiple line issue

2013-08-01 Thread Kumar Gaurav
On Thursday 01 August 2013 10:27 AM, Jiany Wu wrote: I have the same idea with julia. It is more difficult to check the log if we use MACRO instead of the strings. If we search in the system log, according to the string, we will find out the macro first. later we also need to find out where the

Re: question: do we have any UML like design diagram for usb core and driver model?

2013-08-01 Thread Chen Wang
On Thu, 2013-08-01 at 10:34 -0400, Alan Stern wrote: > On Thu, 1 Aug 2013, Oliver Neukum wrote: > > > On Thu, 2013-08-01 at 17:13 +0800, Chen Wang wrote: > > > hello, > > > I'm reading code of usb core and driver model/sysfs. I believe they are > > > designed with OOP. > > > > Yes, much of the co

[PATCH] USB: Removing the use of VLAIS from the gadget driver

2013-08-01 Thread behanw
From: Behan Webster The use of variable length arrays in structs (VLAIS) in the Linux Kernel code precludes the use of compilers which don't implement VLAIS (for instance the Clang compiler). This patch removes the use of VLAIS in the gadget driver. Signed-off-by: Mark Charlebois Signed-off-by:

Re: I've now caught up on my pending USB patches

2013-08-01 Thread Ming Lei
Hi Greg, On Sat, Jul 27, 2013 at 5:17 AM, Greg KH wrote: > Hi all, > > I've now caught up on all pending USB patches that were sent to me, with > the exception of Ming's EHCI patches, which I need to test further next > week. Gentle ping on these patches, :-) Thanks, -- Ming Lei -- To unsubs

Re: USB Interrupt Transaction Scheduling

2013-08-01 Thread Peter Chen
On Tue, Jul 30, 2013 at 09:33:39PM +, Stoddard, Nate (GE Healthcare) wrote: > > > > > The driver has to set up the data structures for the transfers, which > > includes > > scheduling when the SSPLIT and CSPLIT transactions will occur and figuring > > out how much bandwidth they will consume

[PATCH 1/3] usb: phy-samsung-usb: Simplify PMU register handling

2013-08-01 Thread Julius Werner
This patch simplifies the way the phy-samsung-usb code finds the correct power management register to enable PHY clock gating. Previously, the code would calculate the register address from a device tree supplied base address and add an offset based on the PHY type. Since every PHY has its own dev

[PATCH 3/3] usb: phy-samsung-usb: Remove USB_PHY_TYPE from Samsung PHY driver

2013-08-01 Thread Julius Werner
Since the PMU register handling was simplified, the last reason to differentiate between HOST and DEVICE PHYs in the Samsung USB PHY driver has disappeared. This patch removes that variable and reworks surrounding code to live without it to make the driver a little smaller and cleaner. Signed-off-

Re: USB Interrupt Transaction Scheduling

2013-08-01 Thread Peter Chen
On Thu, Aug 01, 2013 at 12:14:18PM -0300, Fabio Estevam wrote: > Hi Nate, > > On Tue, Jul 30, 2013 at 6:33 PM, Stoddard, Nate (GE Healthcare) > wrote: > > > So you would expect a temporary CPU increase when a device is connected or > > reset since the scheduler will need to set up when the pack

[PATCH 2/3] usb: phy-samsung-usb: trivial: rename pmuregs variable

2013-08-01 Thread Julius Werner
Now that the sphy->pmuregs variable always points to only a single register, let's rename it to make that more clear. Signed-off-by: Julius Werner --- drivers/usb/phy/phy-samsung-usb.c | 14 +++--- drivers/usb/phy/phy-samsung-usb.h | 4 ++-- drivers/usb/phy/phy-samsung-usb2.c | 4 ++-

[PATCH 0/3] usb: phy-samsung-usb: Simplify and cleanup

2013-08-01 Thread Julius Werner
This patch series cleans up and simplifies some of the Samsung USB PHY driver code. It changes the PMU register handling to carry the register address directly in the device tree and avoid a lot of special-cased address arithmatic in the code. Then it removes the USB_PHY_TYPE HOST/DEVICE distinctio

[PATCH V3 0/3] networking: Use ETH_ALEN where appropriate

2013-08-01 Thread Joe Perches
Convert the uses mac addresses to ETH_ALEN so it's easier to find and verify where mac addresses need to be __aligned(2) Change in V2: - Remove include/acpi/actbl2.h conversion It's a file copied from outside ACPI sources Changes in V3: - Don't move the pasemi_mac.h mac address to be aligned(2)

[PATCH V3 2/3] include: Convert ethernet mac address declarations to use ETH_ALEN

2013-08-01 Thread Joe Perches
It's convenient to have ethernet mac addresses use ETH_ALEN to be able to grep for them a bit easier and also to ensure that the addresses are __aligned(2). Add #include as necessary. Signed-off-by: Joe Perches Acked-by: Mauro Carvalho Chehab --- include/linux/dm9000.h | 4 ++- incl

Re: [PATCH 6/6] usb: host: tegra: Tegra30 support

2013-08-01 Thread Stephen Warren
On 07/31/2013 11:42 AM, Tuomas Tynkkynen wrote: > The Tegra30 EHCI controller is mostly compatible with the Tegra20 > controller, except Tegra30 includes the HOSTPC register extension. > The has_hostpc capability bit must be set in the ehci_hcd structure if > the controller has such extensions. The

Re: [PATCH 5/6] Documentation: New DT parameters for tegra30-usb-phy

2013-08-01 Thread Stephen Warren
On 07/31/2013 11:42 AM, Tuomas Tynkkynen wrote: > Document the new device tree parameters for Tegra30 USB PHY. Very minor nit: It would make sense to move this patch before the previous patch (or squash them together) so that the documentation is updated first. But, it makes no difference to the c

Re: [PATCH 4/6] usb: phy: tegra: Program new PHY parameters

2013-08-01 Thread Stephen Warren
On 07/31/2013 11:42 AM, Tuomas Tynkkynen wrote: > The Tegra30 TRM recommends configuration of certain PHY parameters for > optimal quality. Program the following registers based on device tree > parameters: > > - UTMIP_XCVR_HSSLEW: HS slew rate control. > - UTMIP_HSSQUELCH_LEVEL: HS squelch detect

[PATCH 2/2] USB: EHCI: don't depend on hardware for tracking port resets and resumes

2013-08-01 Thread Alan Stern
In theory, an EHCI controller can turn off the PORT_RESUME or PORT_RESET bits in a port status register all by itself (and some controllers actually do this). We shouldn't depend on these bits being set correctly. This patch rearranges the code in ehci-hcd that handles completion of port resets a

Re: [PATCH 2/6] usb: phy: tegra: Fix wrong PHY parameters

2013-08-01 Thread Stephen Warren
On 07/31/2013 11:41 AM, Tuomas Tynkkynen wrote: > Some of the PHY parameters are not set according to the TRMs: > > - UTMIP_FS_PREABMLE_J should be set, not cleared > - UTMIP_XCVR_LSBIAS_SEL should be cleared, not set > - UTMIP_PD_CHRG should be set in host mode and cleared in device mode > - UTMI

[PATCH 1/2] USB: EHCI: keep better track of resuming ports

2013-08-01 Thread Alan Stern
The ehci-hcd driver isn't as careful as it should be about the way it uses ehci->resuming_ports. One of the omissions was fixed recently by commit 47a64a13d54 (USB: EHCI: Fix resume signalling on remote wakeup), but there are other places that need attention: When a port's suspend feature

Re: [PATCH V5] usb: Add Device Tree support to XHCI Platform driver

2013-08-01 Thread Sarah Sharp
On Wed, Jul 31, 2013 at 11:45:48PM +0400, Sergei Shtylyov wrote: > Hello. > > On 07/31/2013 10:48 PM, Sarah Sharp wrote: > >Sergei, Felipe, do you have a strong preference on this name? Or should > >I take the patch as is? > >I've already said I don't have a strong preference. Ok, I will ta

Re: [PATCH 2/4] USB: XHCI: mark no_sg_limit

2013-08-01 Thread Sarah Sharp
On Thu, Aug 01, 2013 at 10:15:51AM +0200, Oliver Neukum wrote: > On Thu, 2013-08-01 at 15:30 +0800, Greg Kroah-Hartman wrote: > > On Wed, Jul 31, 2013 at 09:40:26AM -0700, Sarah Sharp wrote: > > > On Wed, Jul 31, 2013 at 06:51:47PM +0800, Ming Lei wrote: > > > > This patch marks all xHCI controller

[PATCH V2 2/3] include: Convert ethernet mac address declarations to use ETH_ALEN

2013-08-01 Thread Joe Perches
It's convenient to have ethernet mac addresses use ETH_ALEN to be able to grep for them a bit easier and also to ensure that the addresses are __aligned(2). Add #include as necessary. Signed-off-by: Joe Perches Acked-by: Mauro Carvalho Chehab --- include/linux/dm9000.h | 4 ++- incl

[PATCH V2 0/3] networking: Use ETH_ALEN where appropriate

2013-08-01 Thread Joe Perches
Convert the uses mac addresses to ETH_ALEN so it's easier to find and verify where mac addresses need to be __aligned(2) Change from initial submission: - Remove include/acpi/actbl2.h conversion It's a file copied from outside ACPI sources Joe Perches (3): uapi: Convert some uses of 6 to ETH_

[PATCH] usb: gadget: amd5536udc: unconditionally use GFP_ATOMIC in udc_queue()

2013-08-01 Thread Alexey Khoroshilov
As far as prep_dma() is called with spinlock held, we have to pass GFP_ATOMIC regardless of gfp argument. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/usb/gadget/amd5536udc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-

Re: [RFC] usb: gadget: start to drop endpoint naming conventions

2013-08-01 Thread Felipe Balbi
Hi, On Thu, Aug 01, 2013 at 11:58:30AM -0400, Alan Stern wrote: > > > The endpoint naming convention currently determines type and direction. > > > It works okay for simple cases but not for more complicated ones. For > > > example, it can't handle endpoints that support bulk or interrupt but

Re: Audio I/O parameters

2013-08-01 Thread Clemens Ladisch
Alan Stern wrote: > On Thu, 1 Aug 2013, Clemens Ladisch wrote: >>> It seems likely that the error is caused by an SMI taking too much >>> time. At least, we seem to have ruled out everything else. Besides, >>> this change has to be made eventually in any case -- underruns can >>> occur at any tim

Re: [PATCH 2/6] staging: ozwpan: Mark string as const

2013-08-01 Thread Joe Perches
On Thu, 2013-08-01 at 18:40 +0100, Rupesh Gujare wrote: > Make sure that we mark const string so that it does not get modified. [] > diff --git a/drivers/staging/ozwpan/ozproto.h > b/drivers/staging/ozwpan/ozproto.h [] > -void oz_binding_add(char *net_dev); > -void oz_binding_remove(char *net_dev)

Re: [PATCH 2/3] include: Convert ethernet mac address declarations to use ETH_ALEN

2013-08-01 Thread Mauro Carvalho Chehab
Em Sun, 28 Jul 2013 22:29:04 -0700 Joe Perches escreveu: > It's convenient to have ethernet mac addresses use > ETH_ALEN to be able to grep for them a bit easier and > also to ensure that the addresses are __aligned(2). > > Add #include as necessary. > > Signed-off-by: Joe Perches > --- > in

[PATCH 6/6] staging: ozwpan: Set farewell report length.

2013-08-01 Thread Rupesh Gujare
Fixes a bug where we were not setting length field causing wrong report size to be copied. Signed-off-by: Rupesh Gujare --- drivers/staging/ozwpan/ozproto.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/ozwpan/ozproto.c b/drivers/staging/ozwpan/ozproto.c index ec60286..0

[PATCH 5/6] staging: ozwpan: Increase farewell report size.

2013-08-01 Thread Rupesh Gujare
Farewell report size can be bigger than one byte, increase array size to accomodate maximum 32 bytes of farewell report. Signed-off-by: Rupesh Gujare --- drivers/staging/ozwpan/ozpd.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ozwpan/ozpd.h b/drivers/s

[PATCH 4/6] staging: ozwpan: Drop oldest ISOC frame instead of dropping latest.

2013-08-01 Thread Rupesh Gujare
In case of ISOC transfer, if TX queue is full then we start dropping latest frame, instead we should drop oldest frame & add latest frame to TX queue. Signed-off-by: Rupesh Gujare --- drivers/staging/ozwpan/ozpd.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git

[PATCH 0/6] staging: ozwpan: Use Kernel API & Bug fixes

2013-08-01 Thread Rupesh Gujare
This patch series removes duplicate code, & replaces it with kernel library functions, and few bug fixes. Rupesh Gujare (6): staging: ozwpan: Use kernel list function for managing interface list. staging: ozwpan: Mark string as const staging: ozwpan: Use kernel strncmp function. stagin

[PATCH 1/6] staging: ozwpan: Use kernel list function for managing interface list.

2013-08-01 Thread Rupesh Gujare
Managing interface list, is easier if we use kernel list_* API than managing it on our own. Signed-off-by: Rupesh Gujare --- drivers/staging/ozwpan/ozproto.c | 29 + 1 file changed, 13 insertions(+), 16 deletions(-) diff --git a/drivers/staging/ozwpan/ozproto.c b/d

[PATCH 3/6] staging: ozwpan: Use kernel strncmp function.

2013-08-01 Thread Rupesh Gujare
Use kernel's strncmp() function instead of defining same within driver. Signed-off-by: Rupesh Gujare --- drivers/staging/ozwpan/ozproto.c | 17 + 1 file changed, 1 insertion(+), 16 deletions(-) diff --git a/drivers/staging/ozwpan/ozproto.c b/drivers/staging/ozwpan/ozproto.c in

[PATCH 2/6] staging: ozwpan: Mark string as const

2013-08-01 Thread Rupesh Gujare
Make sure that we mark const string so that it does not get modified. Signed-off-by: Rupesh Gujare --- drivers/staging/ozwpan/ozproto.c |6 +++--- drivers/staging/ozwpan/ozproto.h |4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/ozwpan/ozproto.c b/d

Re: [PATCH] USB: ohci-at91: add usb_clk for transition to common clk framework

2013-08-01 Thread Alan Stern
On Thu, 1 Aug 2013, Sergei Shtylyov wrote: > > Yes. However, a more elegant approach is to protect the relevant > > statements with: if (defined(CONFIG_COMMON_CLK)). This preprocessor > > You probably meant IS_ENABLED() or IS_BUIILTIN()? Or is there something I > don't know about gcc prepr

Re: [PATCH v2] USB: ohci-at91: add usb_clk for transition to common clk framework

2013-08-01 Thread Alan Stern
On Thu, 1 Aug 2013, Boris BREZILLON wrote: > The AT91 PMC (Power Management Controller) provides an USB clock used by > USB Full Speed host (ohci) and USB Full Speed device (udc). > The usb drivers (ohci and udc) must configure this clock to 48Mhz. > This configuration was formely done in mach-at9

Re: Buffer size for ALSA USB PCM audio

2013-08-01 Thread Alan Stern
On Mon, 29 Jul 2013, Clemens Ladisch wrote: > Alan Stern wrote: > > Clemens remarked some time ago that keeping the queue full would be > > trivial, if only he knew how full it needed to be. The answer to that > > is given above. I have been trying to make the appropriate changes, > > but I'm no

Re: [PATCH] USB: ohci-at91: add usb_clk for transition to common clk framework

2013-08-01 Thread Sergei Shtylyov
Hello. On 08/01/2013 07:56 PM, Alan Stern wrote: What happens if uclk isn't found but it is needed? It will not fail but I guess the usb host won't work as the clock won't be correctly configured. I agree with you: this is not a good solution. Another option is to keep the previous ver

Re: [alsa-devel] Buffer size for ALSA USB PCM audio

2013-08-01 Thread Eldad Zack
On Tue, 30 Jul 2013, Takashi Iwai wrote: > At Mon, 29 Jul 2013 21:23:15 +0200, > Daniel Mack wrote: > > > > On 29.07.2013 20:20, Alan Stern wrote: > > > data_ep_set_params() checks snd_usb_endpoint_implicit_feedback_sink() > > > in three places. It looks like only the second place is correct.

[PATCH v2] USB: ohci-at91: add usb_clk for transition to common clk framework

2013-08-01 Thread Boris BREZILLON
The AT91 PMC (Power Management Controller) provides an USB clock used by USB Full Speed host (ohci) and USB Full Speed device (udc). The usb drivers (ohci and udc) must configure this clock to 48Mhz. This configuration was formely done in mach-at91/clock.c, but this implementation will be removed w

[PATCH v2] usb: gadget: at91_udc: add usb_clk for transition to common clk framework

2013-08-01 Thread Boris BREZILLON
The AT91 PMC (Power Management Controller) provides an USB clock used by USB Full Speed host (ohci) and USB Full Speed device (udc). The usb drivers (ohci and udc) must configure this clock to 48Mhz. This configuration was formely done in mach-at91/clock.c, but this implementation will be removed w

Re: Audio I/O parameters

2013-08-01 Thread Alan Stern
On Thu, 1 Aug 2013, James Stone wrote: > > SMIs are controlled by the BIOS, not by the kernel. I don't think > > changing the kernel would affect their timings. > > > > Hmm.. ok. So do I need to see if there is a bios update/report this to > motherboard manufacturer? If there's an update availa

Re: [PATCH v2 1/2] ARM: DTS: tegra: Add USB entries for Tegra30

2013-08-01 Thread Stephen Warren
On 08/01/2013 09:00 AM, Tuomas Tynkkynen wrote: > Add device tree entries for the 3 USB controllers and PHYs and > enable the third controller on Cardhu and Beaver boards. > > Fix VBUS regulator entries on Beaver. The GPIO pins were wrong. > Also, internal pullups need to be enabled on those pins.

Re: [PATCH 0/6] USB tree changes for Tegra30 and Tegra114 USB Host support

2013-08-01 Thread Stephen Warren
On 08/01/2013 07:02 AM, Tuomas Tynkkynen wrote: > On 08/01/2013 02:22 AM, Stephen Warren wrote: >> On 07/31/2013 11:41 AM, Tuomas Tynkkynen wrote: >>> Hi all, >>> >>> Here are the patches for the USB tree to enable USB Host support on Tegra30 >>> and >>> Tegra114. These are based on my and Mikko's

Re: lsusb doesn't handle 32 bits Usage tags.

2013-08-01 Thread Paul Chavent
On 08/01/2013 03:54 AM, Greg KH wrote: On Sun, Jul 07, 2013 at 09:32:55PM +0200, pchavent wrote: On Sun, 7 Jul 2013 10:37:59 -0700, Greg KH wrote: On Sun, Jul 07, 2013 at 07:17:40PM +0200, pchavent wrote: Hi. lsusb doesn't handle 32 bits Usage tags. I've tried to do a patch but i'm not confi

Re: [PATCH 4/4] USBNET: ax88179_178a: enable tso if host supports sg dma

2013-08-01 Thread Grant Grundler
On Thu, Aug 1, 2013 at 8:36 AM, Eric Dumazet wrote: ... >> IIRC, cpu_to_leXX() macros return the endian "corrected" value. >> In other words, they need to be assigned to something, no? > > Nope, this in in-place byte swapping (for Big Endian only) Ah ok - thanks for clarifying. I couldn't find th

Re: [RFC] usb: gadget: start to drop endpoint naming conventions

2013-08-01 Thread Alan Stern
On Thu, 1 Aug 2013, Felipe Balbi wrote: > > The endpoint naming convention currently determines type and direction. > > It works okay for simple cases but not for more complicated ones. For > > example, it can't handle endpoints that support bulk or interrupt but > > not isochronous. If you

Re: [PATCH] USB: ohci-at91: add usb_clk for transition to common clk framework

2013-08-01 Thread Alan Stern
On Thu, 1 Aug 2013, boris brezillon wrote: > > What happens if uclk isn't found but it is needed? > It will not fail but I guess the usb host won't work as the clock won't > be correctly > configured. > > I agree with you: this is not a good solution. > > Another option is to keep the previous

Re: Ejected Nook (usb mass storage) prevents suspend

2013-08-01 Thread Alan Stern
On Thu, 1 Aug 2013, Oliver Neukum wrote: > On Wed, 2013-07-31 at 11:13 -0400, Alan Stern wrote: > > > More importantly, if we already know that the medium is not present or > > has been changed since it was last used, then there's no reason to call > > sd_sync_cache() at all. > > Like this? Yes

Re: [RFC] usb: gadget: start to drop endpoint naming conventions

2013-08-01 Thread Felipe Balbi
Hi, On Thu, Aug 01, 2013 at 11:44:59AM -0400, Alan Stern wrote: > On Thu, 1 Aug 2013, Felipe Balbi wrote: > > > Hi folks, > > > > as we all know naming conventions are fragile and easy to break. We've > > had weird endpoint naming conventions for far too long in the gadget > > framework. > > >

Re: [RFC] usb: gadget: start to drop endpoint naming conventions

2013-08-01 Thread Alan Stern
On Thu, 1 Aug 2013, Felipe Balbi wrote: > Hi folks, > > as we all know naming conventions are fragile and easy to break. We've > had weird endpoint naming conventions for far too long in the gadget > framework. > > I'm trying to come up with means to get rid of that and, one of the > ideas, was

Re: [PATCH 4/4] USBNET: ax88179_178a: enable tso if host supports sg dma

2013-08-01 Thread Eric Dumazet
On Thu, 2013-08-01 at 08:30 -0700, Grant Grundler wrote: > http://lxr.free-electrons.com/source/include/linux/byteorder/generic.h#L111 > http://lxr.free-electrons.com/ident?i=__cpu_to_le32s > > IIRC, cpu_to_leXX() macros return the endian "corrected" value. > In other words, they need to be assig

Re: [PATCH 4/4] USBNET: ax88179_178a: enable tso if host supports sg dma

2013-08-01 Thread Grant Grundler
On Wed, Jul 31, 2013 at 3:51 AM, Ming Lei wrote: > This patch enables 'can_dma_sg' flag for ax88179_178a device > if the attached host controller supports building packet from > discontinuous buffers(DMA SG is possible), so both frame header > and skb data buffers can be passed to usb stack via ur

Re: Audio I/O parameters

2013-08-01 Thread Alan Stern
On Thu, 1 Aug 2013, Clemens Ladisch wrote: > > It seems likely that the error is caused by an SMI taking too much > > time. At least, we seem to have ruled out everything else. Besides, > > this change has to be made eventually in any case -- underruns can > > occur at any time, in principle, an

Re: Audio I/O parameters

2013-08-01 Thread Alan Stern
On Thu, 1 Aug 2013, James Stone wrote: > I've got some error messages written to syslog now - with no audible > effect on audio processing: > Aug 1 01:12:36 blueberry kernel: [ 6233.028335] ehci-pci > :00:12.2: iso underrun 8800c872db00 (1407+0 < 1471) That's an impressive one. It indi

Re: [PATCH 1/2] ARM: DTS: tegra: Add USB entries for Tegra30

2013-08-01 Thread Tuomas Tynkkynen
On 08/01/2013 01:13 AM, Stephen Warren wrote: > On 07/31/2013 11:42 AM, Tuomas Tynkkynen wrote: >> Add device tree entries for the 3 USB controllers and PHYs and >> enable the third controller on Cardhu and Beaver boards. >> >> Fix VBUS regulator entries on Beaver. The GPIO pins were wrong. > > Th

Re: [PATCH] USB: ohci-at91: add usb_clk for transition to common clk framework

2013-08-01 Thread boris brezillon
On 01/08/2013 16:39, Alan Stern wrote: On Thu, 1 Aug 2013, Boris BREZILLON wrote: The AT91 PMC (Power Management Controller) provides an USB clock used by USB Full Speed host (ohci) and USB Full Speed device (udc). The usb drivers (ohci and udc) must configure this clock to 48Mhz. This configur

Re: USB Interrupt Transaction Scheduling

2013-08-01 Thread Fabio Estevam
Hi Nate, On Tue, Jul 30, 2013 at 6:33 PM, Stoddard, Nate (GE Healthcare) wrote: > So you would expect a temporary CPU increase when a device is connected or > reset since the scheduler will need to set up when the packets will be > transferred. Once this is complete, the CPU should return to

[PATCH v2 1/2] ARM: DTS: tegra: Add USB entries for Tegra30

2013-08-01 Thread Tuomas Tynkkynen
Add device tree entries for the 3 USB controllers and PHYs and enable the third controller on Cardhu and Beaver boards. Fix VBUS regulator entries on Beaver. The GPIO pins were wrong. Also, internal pullups need to be enabled on those pins. Signed-off-by: Tuomas Tynkkynen --- v2: Use internal pu

[PATCH v2 0/2] Device tree changes for Tegra30 and Tegra114 USB Host support

2013-08-01 Thread Tuomas Tynkkynen
Hi all, Here's the device tree changes required for USB Host support on Tegra30 and Tegra114. This enables USB Host on the Cardhu's dock connector port and on the single built-in A-ports on Dalmore and Beaver. Diff from v1: - Use internal pullups on the VBUS regulator GPIOs on Beaver. Mikko Per

[PATCH v2 2/2] ARM: dts: USB for Tegra114 Dalmore

2013-08-01 Thread Tuomas Tynkkynen
From: Mikko Perttunen Device tree entries for the three EHCI controllers on Tegra114. Enables the the third controller (USB host) on Dalmore. Signed-off-by: Mikko Perttunen --- arch/arm/boot/dts/tegra114-dalmore.dts | 9 + arch/arm/boot/dts/tegra114.dtsi| 62 ++

Re: Audio I/O parameters

2013-08-01 Thread Alan Stern
On Wed, 31 Jul 2013, James Stone wrote: > > It seems likely that the error is caused by an SMI taking too much > > time. At least, we seem to have ruled out everything else. Besides, > > this change has to be made eventually in any case -- underruns can > > occur at any time, in principle, and t

Re: [PATCH] USB: ohci-at91: add usb_clk for transition to common clk framework

2013-08-01 Thread Alan Stern
On Thu, 1 Aug 2013, Boris BREZILLON wrote: > The AT91 PMC (Power Management Controller) provides an USB clock used by > USB Full Speed host (ohci) and USB Full Speed device (udc). > The usb drivers (ohci and udc) must configure this clock to 48Mhz. > This configuration was formely done in mach-at9

Re: question: do we have any UML like design diagram for usb core and driver model?

2013-08-01 Thread Alan Stern
On Thu, 1 Aug 2013, Oliver Neukum wrote: > On Thu, 2013-08-01 at 17:13 +0800, Chen Wang wrote: > > hello, > > I'm reading code of usb core and driver model/sysfs. I believe they are > > designed with OOP. > > Yes, much of the code is OO. However, we usually > don't overwrite methods. > > > So, d

Re: Ejected Nook (usb mass storage) prevents suspend

2013-08-01 Thread Oliver Neukum
On Wed, 2013-07-31 at 11:13 -0400, Alan Stern wrote: > More importantly, if we already know that the medium is not present or > has been changed since it was last used, then there's no reason to call > sd_sync_cache() at all. Like this? Regards Oliver >From 8c90d860652

[PATCH 5/7] usb: phy: omap: get rid of omap_get_control_dev()

2013-08-01 Thread Roger Quadros
This function was preventing us from supporting multiple instances. Get rid of it. Since we support DT boots only, users can get the control device phandle from the DT node. Signed-off-by: Roger Quadros --- drivers/usb/phy/phy-omap-control.c | 31 ++- include/linu

[PATCH 0/7] phy: omap-usb: Support multiple instances and new types

2013-08-01 Thread Roger Quadros
Hi, This patchset does the following: * Restructure and add support for new PHY types. We now support the follwing four types TYPE1 - if it has otghs_control mailbox register (e.g. on OMAP4) TYPE2 - if it has Power down bit in control_dev_conf register. e.g. USB2 PHY TYPE3 - if it has DPLL an

[PATCH v2] usb/gadget: cdc2: fix conversion to new interface of f_ecm

2013-08-01 Thread Andrzej Pietrasiewicz
This fixes commit a38a275030086d95306555e544fc7c0e65ccd00e (usb: gadget: cdc2: convert to new interface of f_ecm) The invocation of usb_get_function_instance() is in cdc_bind() and should not be repeated in cdc_do_config(). Signed-off-by: Andrzej Pietrasiewicz Signed-off-by: Kyungmin Park ---

[PATCH 2/7] usb: phy: omap-usb2: Don't use omap_get_control_dev()

2013-08-01 Thread Roger Quadros
omap_get_control_dev() is being deprecated as it doesn't support multiple instances. As control device is present only from OMAP4 onwards which supports DT only, we use phandles to get the reference to the control device. As we don't support non-DT boot, we just bail out on probe if device node is

[PATCH 1/7] usb: phy: omap: Add new PHY types and remove omap_control_usb3_phy_power()

2013-08-01 Thread Roger Quadros
TYPE2 meaning has changed. It is now a USB2 phy with Power down bit in control_dev_conf register. Introduce TYPE3 and TYPE4 PHY. TYPE3 is USB3 phy with DPLL and individual TX/RX power control. TYPE4 is USB2 phy with power aux register. Update DT binding information to reflect these changes. Also

[PATCH 4/7] usb: musb: omap2430: Don't use omap_get_control_dev()

2013-08-01 Thread Roger Quadros
omap_get_control_dev() is being deprecated as it doesn't support multiple instances. As control device is present only from OMAP4 onwards which supports DT only, we use phandles to get the reference to the control device. Signed-off-by: Roger Quadros --- drivers/usb/musb/omap2430.c | 22 ++

[PATCH 7/7] ARM: dts: omap5: update omap-control-usb node

2013-08-01 Thread Roger Quadros
Split USB2 PHY and USB3 PHY into separate omap-control-usb nodes. Update ti,mode property. CC: Benoit Cousson Signed-off-by: Roger Quadros --- arch/arm/boot/dts/omap5.dtsi | 18 -- 1 files changed, 12 insertions(+), 6 deletions(-) diff --git a/arch/arm/boot/dts/omap5.dtsi b/a

[PATCH 6/7] ARM: dts: omap4: update omap-control-usb nodes

2013-08-01 Thread Roger Quadros
Split otghs_ctrl and USB2 PHY power down into separate omap-control-usb nodes. Update ti,mode property. CC: Benoit Cousson Signed-off-by: Roger Quadros --- arch/arm/boot/dts/omap4.dtsi | 17 - 1 files changed, 12 insertions(+), 5 deletions(-) diff --git a/arch/arm/boot/dts/om

[PATCH 3/7] usb: phy: omap-usb3: Don't use omap_get_control_dev()

2013-08-01 Thread Roger Quadros
omap_get_control_dev() is being deprecated as it doesn't support multiple instances. As control device is present only from OMAP4 onwards which supports DT only, we use phandles to get the reference to the control device. As we don't support non-DT boot, we just bail out on probe if device node is

Re: [PATCH net-next] ax88179_178a: avoid copy of tx tcp packets

2013-08-01 Thread Eric Dumazet
On Thu, 2013-08-01 at 06:49 -0700, Eric Dumazet wrote: > From: Eric Dumazet > > ax88179_tx_fixup() has quite complex code trying to push 8 bytes > of control data (len/mss), but fails to do it properly for TCP packets, > incurring an extra copy and point of memory allocation failure. I forgot to

[PATCH net-next] ax88179_178a: avoid copy of tx tcp packets

2013-08-01 Thread Eric Dumazet
From: Eric Dumazet ax88179_tx_fixup() has quite complex code trying to push 8 bytes of control data (len/mss), but fails to do it properly for TCP packets, incurring an extra copy and point of memory allocation failure. Lets use the simple and approved way. dev->needed_headroom being 8, all fra

Re: question: do we have any UML like design diagram for usb core and driver model?

2013-08-01 Thread Greg KH
On Thu, Aug 01, 2013 at 11:51:07AM +0200, Oliver Neukum wrote: > On Thu, 2013-08-01 at 17:13 +0800, Chen Wang wrote: > > hello, > > I'm reading code of usb core and driver model/sysfs. I believe they are > > designed with OOP. > > Yes, much of the code is OO. However, we usually > don't overwrite

Re: [PATCH 4/4] USBNET: ax88179_178a: enable tso if host supports sg dma

2013-08-01 Thread Eric Dumazet
On Thu, 2013-08-01 at 16:10 +0800, Ming Lei wrote: > On Thu, Aug 1, 2013 at 1:04 PM, Eric Dumazet wrote: > > On Thu, 2013-08-01 at 12:41 +0800, Ming Lei wrote: > > > >> From my trace result, lots of linear SKBs are cloned or header-cloned, so > >> it needs skb copy too. > >> > >> Is it normal in x

Re: [PATCH 0/6] USB tree changes for Tegra30 and Tegra114 USB Host support

2013-08-01 Thread Tuomas Tynkkynen
On 08/01/2013 02:22 AM, Stephen Warren wrote: > On 07/31/2013 11:41 AM, Tuomas Tynkkynen wrote: >> Hi all, >> >> Here are the patches for the USB tree to enable USB Host support on Tegra30 >> and >> Tegra114. These are based on my and Mikko's cleanup patches that just got >> merged to Felipe's tre

Re: [PATCH] usb/gadget: cdc2: convert to new interface of f_ecm

2013-08-01 Thread Sergei Shtylyov
Hello. Your subject don't seem to match the patch itself. On 01-08-2013 14:40, Andrzej Pietrasiewicz wrote: This fixes commit a38a275030086d95306555e544fc7c0e65ccd00e. Please also specify that commit's summary line in parens. The invocation of usb_get_function_instance() is in cdc_bi

Re: [PATCH 2/2] ARM: dts: USB for Tegra114 Dalmore

2013-08-01 Thread Sergei Shtylyov
Hello. On 01-08-2013 3:29, Stephen Warren wrote: Don't they cause numerous resource conflicts while device nodes being instantiated as the platform devices? No; the driver knows that the HW is screwy and there's lots of register-range sharing going on, so it simply maps the registers, r

Haswell C2, xHCI and S3

2013-08-01 Thread Andre Heider
Hi list, blunt question, because I'm about to assemble a new Haswell box and I wonder if waiting for C2 boards makes sense: Does Linux care about the apparent C1 stepping xHCI bug [1]? Are workarounds required for the kernel? If so, does C2 get rid of them? [1] http://www.guru3d.com/news_story/i

Re: [PATCH 5/5] usb: musb: dsps: use proper child nodes

2013-08-01 Thread Sebastian Andrzej Siewior
On 08/01/2013 12:52 PM, Sebastian Andrzej Siewior wrote: > On 08/01/2013 07:24 AM, George Cherian wrote: >>> b/arch/arm/boot/dts/am33xx.dtsi >>> index 38b446b..0f756ca 100644 >>> --- a/arch/arm/boot/dts/am33xx.dtsi >>> +++ b/arch/arm/boot/dts/am33xx.dtsi >>> @@ -333,21 +337,85 @@ >>>

Re: [PATCH 3/5] usb: phy: Add AM335x PHY driver

2013-08-01 Thread Sebastian Andrzej Siewior
On 08/01/2013 07:36 AM, George Cherian wrote: please keep the file here file snipping >> +static const struct of_device_id omap_control_usb_id_table[] = { >> +{ .compatible = "ti,am335x-ctrl-module", .data = &ctrl_am335x }, >> +{} >> +}; >> +MODULE_DEVICE_TABLE(of, omap_control_usb_id_tab

Re: [PATCH 5/5] usb: musb: dsps: use proper child nodes

2013-08-01 Thread Sebastian Andrzej Siewior
On 08/01/2013 07:24 AM, George Cherian wrote: >> b/arch/arm/boot/dts/am33xx.dtsi >> index 38b446b..0f756ca 100644 >> --- a/arch/arm/boot/dts/am33xx.dtsi >> +++ b/arch/arm/boot/dts/am33xx.dtsi >> @@ -333,21 +337,85 @@ >> status = "disabled"; >> }; >> -usb@4740 {

Re: [PATCH] usb/gadget: cdc2: convert to new interface of f_ecm

2013-08-01 Thread Felipe Balbi
Hi, On Thu, Aug 01, 2013 at 12:40:47PM +0200, Andrzej Pietrasiewicz wrote: > This fixes commit a38a275030086d95306555e544fc7c0e65ccd00e. > The invocation of usb_get_function_instance() is in cdc_bind() > and should not be repeated in cdc_do_config(). > > > Signed-off-by: Andrzej Pietrasiewicz >

Re: Patch ' usb: gadget: cdc2: convert to new interface of f_ecm' applied to my tree

2013-08-01 Thread Felipe Balbi
Hi On Thu, Aug 01, 2013 at 12:31:55PM +0200, Andrzej Pietrasiewicz wrote: > On Wednesday, June 12, 2013 5:17 PM Felipe Balbi wrote: > > Hi, > > > > This is a note to let you know that the patch: > > > > usb: gadget: cdc2: convert to new interface of f_ecm > > > > has been applied to my

[PATCH] usb/gadget: cdc2: convert to new interface of f_ecm

2013-08-01 Thread Andrzej Pietrasiewicz
This fixes commit a38a275030086d95306555e544fc7c0e65ccd00e. The invocation of usb_get_function_instance() is in cdc_bind() and should not be repeated in cdc_do_config(). Signed-off-by: Andrzej Pietrasiewicz Signed-off-by: Kyungmin Park --- drivers/usb/gadget/cdc2.c | 19 +--

  1   2   >