On 08/14/2013 08:24 AM, Sarah Sharp wrote:
On Fri, Aug 09, 2013 at 05:14:48PM -0400, Alan Stern wrote:
On Fri, 9 Aug 2013, Greg KH wrote:
On Thu, Aug 08, 2013 at 10:07:19PM +0200, Martin MOKREJŠ wrote:
Hi,
I get plenty of these in /sys/kernel/debug/kmemleak:
unreferenced object
This driver supports devices using the NCM protocol as an encapsulation layer
for other protocols, like the E3131 Huawei 3G modem. This drivers approach was
heavily inspired by the qmi_wwan approach code model.
Suggested-by: Bjorn Mork bj...@mork.no
Signed-off-by: Enrico Mioso
These patches are all related to the new huawei_cdc_ncm driver, supporting
devices that use the NCM protocol as a transport layer for other protocols.
this is the case of the Huawei E3131 3G modem.
In this version - I actually added the driver file! :) I don't know how I ended
up forgetting
Some drivers implementing NCM-like protocols, may re-use those functions, as is
the case in the huawei_cdc_ncm driver.
Export them via EXPORT_SYMBOL_GPL, in accordance with how other functions have
been exported.
Signed-off-by: Enrico Mioso mrkiko...@gmail.com
---
drivers/net/usb/cdc_ncm.c |
Le Thu, 22 Aug 2013 21:39:17 +0100,
Alan Stern st...@rowland.harvard.edu a écrit :
This patch divides ehci-hcd's interrupt handler into a top half and a
bottom half, using a tasklet to execute the latter.
The conversion is very straightforward. The only subtle point is that
we have to
You have won 500,000.00 Contact :wutransfer...@xtra.co.nz
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
The call to put_dev() releases dev. Hopefully, we don't need to set
the state to STATE_DEV_DISABLED anyway so I have removed those lines.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
---
Static checker stuff. I haven't tested this, but I'm pretty sure it's
correct.
diff --git
This patch adds a trace event to the class 'xhci_log_msg', called
'xhci_dbg_missed_periodic_tx', that traces the debug statements which
signal that the xHC is unable to service an isochronous endpoint within
its service interval either because the endpoint's ring is full and can
not receive
This patch refactors the code in TRB_RESET_DEV switch case in
handle_cmd_completion() into a fuction named xhci_handle_cmd_reset_dev().
Here, in the original code, the slot id is retrieved by the command TRB.
Since this slot id matches the one in Slot ID field of the command completion
event,
This patch renames the function handlers of a triggered Command Completion
Event that correspond to each command type into 'xhci_handle_cmd_type'.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
---
drivers/usb/host/xhci-ring.c | 18 --
1 file changed, 8 insertions(+), 10
This patch refactors the code in TRB_EVAL_CONTEXT switch case in
handle_cmd_completion() into a fuction named xhci_handle_cmd_eval_ctx().
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
---
drivers/usb/host/xhci-ring.c | 19 ++-
1 file changed, 14 insertions(+), 5
This patch refactors the code in TRB_DISABLE_SLOT switch case in
handle_cmd_completion() into a fuction named xhci_handle_cmd_disable_slot().
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
---
drivers/usb/host/xhci-ring.c | 21 ++---
1 file changed, 14 insertions(+), 7
This patch adds a new variable 'cmd_comp_code' to hold the command completion
status code aiming to reduce code duplication and to improve code readability.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
---
drivers/usb/host/xhci-ring.c | 20
1 file changed, 8
This patch refactors the code in TRB_CONFIG_EP switch case, in
handle_cmd_completion(), into a fuction named xhci_handle_cmd_config_ep().
There were added two additional variables, 'add_flags' and 'drop_flags',
to reduce line length below 80 chars and improve code readability.
Signed-off-by:
This patch refactors the code in TRB_ADDR_DEV switch case in
handle_cmd_completion() into a fuction named xhci_handle_cmd_addr_dev().
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
---
drivers/usb/host/xhci-ring.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff
This patch replaces 'xhci-cmd_ring-dequeue' with 'trb', the address of
the command TRB, since it is available to reduce line length.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
---
drivers/usb/host/xhci-ring.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git
Since the Slot ID field in the command completion event matches the Slot ID
field in the associated command TRB for the Stop Endpoint, Set Dequeue Pointer
and Reset Endpoint commands, this patch adds in the handlers of their
completion events a 'slot_id' argument and removes the slot id
This patch adds a new variable 'cmd_type' to hold the command type so that
switch cases can be simplified by removing TRB_TYPE() macro.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
---
drivers/usb/host/xhci-ring.c | 27 ++-
1 file changed, 14 insertions(+), 13
ffs_data_put() can sometimes free ffs so I have moved the call down
a line below the dereference.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
---
Static checker stuff. I can't actually compile this file.
diff --git a/drivers/usb/gadget/f_fs.c b/drivers/usb/gadget/f_fs.c
index
This patch adds a new variable 'cmd_trb' to hold the address of the
command TRB, that is associated with the command completion event,
and to replace repetitions of xhci-cmd_ring-dequeue into the code.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
---
drivers/usb/host/xhci-ring.c | 15
This patch removes the variable 'ep_ring' that is assigned in
TRB_CONFIG_EP switch case but never used.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
---
drivers/usb/host/xhci-ring.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/usb/host/xhci-ring.c
This patch refactors the code in TRB_ENABLE_SLOT switch case in
handle_cmd_completion() into a fuction named xhci_handle_cmd_enable_slot().
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
---
drivers/usb/host/xhci-ring.c | 17 -
1 file changed, 12 insertions(+), 5
This patch adds the label 'update_ring' for the common code path:
inc_deq(xhci, xhci-cmd_ring);
return;
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
---
drivers/usb/host/xhci-ring.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/host/xhci-ring.c
This patch removes the adjective argument from xhci_giveback_urb_in_irq(),
since it is not used in the function anymore.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
---
Differences from version 2:
The original patchset was splitted into multiple 'single change'
patches to help patch
On Thu, Aug 22, 2013 at 05:38:51PM +0100, Rupesh Gujare wrote:
+/*--
* Context: softirq-serialized
*/
Don't resend the patch, but these comments are not in kernel style.
It's explained in
The udc-core will call gadget's driver-disconnect, so we should avoid
calling gadget's disconnect again at ci_udc_stop in case the gadget's
unbind free some structs which is still used at gadget's disconnect.
Tested-by: Marek Vasut ma...@denx.de
Signed-off-by: Peter Chen peter.c...@freescale.com
When we rmmod gadget, the ci-driver needs to be cleared.
Otherwise, when we plug in usb cable again, the driver will
consider gadget is there, and go to enumeration procedure,
but in fact, it was removed.
ci_hdrc ci_hdrc.0: Connected to host
Unable to handle kernel paging request at virtual
Hi Alex,
Below are un-queued chipidea patches, some of them were reviewd.
Peter Chen (5):
usb: host: delete chipidea dependency
usb: chipidea: udc: Consolidate the calling of ci-driver-disconnect
usb: chipidea: udc: fix the oops when plugs in usb cable after rmmod
gadget
usb:
Now, chipidea host has already depended on USB_EHCI_HCD
Acked-by: Alan Stern st...@rowland.harvard.edu
Signed-off-by: Peter Chen peter.c...@freescale.com
---
drivers/usb/host/Kconfig |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/host/Kconfig
It needs to free ci-hw_bank.regmap explicitly since it is not managed
resource.
Signed-off-by: Peter Chen peter.c...@freescale.com
---
drivers/usb/chipidea/core.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c
Like vbus, the dr_mode and phy_mode are also got from glue layer's
platform data or device node.
Signed-off-by: Peter Chen peter.c...@freescale.com
---
drivers/usb/chipidea/core.c | 19 +--
1 files changed, 9 insertions(+), 10 deletions(-)
diff --git
On Wed, Aug 07, 2013 at 05:18:13AM +0800, Peter Chen wrote:
In order to increase test coverage, we can change the interval between
two remote wakeups every time, and the interval can be any user defined
value. This change will no affect current behavior if the user does not
use two introduced
Hi Alan,
Thank you to your comments.
On Fri, Aug 23, 2013 at 12:51:44AM +0800, Alan Stern wrote:
On Thu, 22 Aug 2013, Huang Rui wrote:
Hi Sarah, Alan,
The following patches are required to resolve remote wake issues with
certain devices.
Issue description:
If the remote wake
On Fri, Aug 23, 2013 at 01:00:29AM +0800, Alan Stern wrote:
On Thu, 22 Aug 2013, Huang Rui wrote:
The following patch is required to resolve remote wake issues with
certain devices.
Issue description:
If the remote wake is issued from the device in a specific timing
condition while
Hi,
I just wanna followup this issue a bit more.
We have now tested on several hardware platform, and it is only on one platform
it fails. The platform it fails on is Atom Intel e6xx CPU with EG20T PCH
platform controller. We do not observe it on the Intel i7 3517UE CPU with Intel
6/7 series
On 23/08/13 10:05, Dan Carpenter wrote:
On Thu, Aug 22, 2013 at 05:38:51PM +0100, Rupesh Gujare wrote:
+/*--
* Context: softirq-serialized
*/
Don't resend the patch, but these comments are not in kernel style.
On Fri, Aug 23, 2013 at 12:52 PM, Andreas Lillebø Holm
andr...@sqhead.com wrote:
Hi,
I just wanna followup this issue a bit more.
We have now tested on several hardware platform, and it is only on one
platform it fails. The platform it fails on is Atom Intel e6xx CPU with EG20T
PCH
On Fri, 23 Aug 2013, Benjamin Tissoires wrote:
IIRC, Jiri fixed some paging requests with the two following patches:
http://git.kernel.org/cgit/linux/kernel/git/jikos/hid.git/commit/?h=for-nextid=27ce405039bfe6d3f4143415c638f56a3df77dca
All three reported oopses happened on page boundary exactly, so this
pretty much looks like my implement() fix is the one.
Andreas, could you please apply
http://git.kernel.org/cgit/linux/kernel/git/jikos/hid.git/commit/?h=for-nextid=27ce405039bfe6d3f4143415c638f56a3df77dca
and
Hello.
On 23-08-2013 12:15, Xenia Ragiadakou wrote:
This patch adds the label 'update_ring' for the common code path:
inc_deq(xhci, xhci-cmd_ring);
return;
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
---
drivers/usb/host/xhci-ring.c | 8
1 file changed, 4
On 08/23/2013 04:19 PM, Sergei Shtylyov wrote:
Hello.
On 23-08-2013 12:15, Xenia Ragiadakou wrote:
This patch adds the label 'update_ring' for the common code path:
inc_deq(xhci, xhci-cmd_ring);
return;
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
---
On Fri, 23 Aug 2013, Xenia Ragiadakou wrote:
Martin is right; the BOS descriptors are leaked in
usb_reset_and_verify_device(). We need to store the old descriptor,
compare it with the new one following the reset, and delete one of them
afterward. I haven't had time to fix this.
I'll
On Fri, 23 Aug 2013, Matthieu CASTET wrote:
Le Thu, 22 Aug 2013 21:39:17 +0100,
Alan Stern st...@rowland.harvard.edu a �crit :
This patch divides ehci-hcd's interrupt handler into a top half and a
bottom half, using a tasklet to execute the latter.
The conversion is very
On Wed, 21 Aug 2013, Sarah Sharp wrote:
Background
--
The USB 2.0 specification, section 7.1.7.7, says that upon device remote
wakeup signaling, the first active hub (which is often the roothub) must
rebroadcast the resume signaling for at least 20 ms (TDRSMDN). After
that's
On Fri, 23 Aug 2013, Huang Rui wrote:
What's special about LS devices? Or mice? Shouldn't the resume signal
be sent within 100 us for every device?
Yes, only mice would trigger this issue.
Reproduce steps:
1. Enable remote wakeup for usb mouse.
2. Execute S3.
3. Click mouse
Hi Sarah,
On Thu, Aug 22, 2013 at 04:02:54PM -0700, Sarah Sharp wrote:
Hi Huang,
Thanks for notifying us of this issue and submitting a patch to attempt
to fix it.
Thank you to your reply. Any comments are warm for me. :)
I am the replacement of Andiry Xu, will work on usb driver for AMD
schedule_work() returns true if succeeded false on failure,
error check was doing exactly reverse.
Also removes extra variable.
Signed-off-by: Rupesh Gujare rupesh.guj...@atmel.com
---
drivers/staging/ozwpan/ozpd.c |6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git
As we are initialising structure, we do not require
memset().
Signed-off-by: Rupesh Gujare rupesh.guj...@atmel.com
---
drivers/staging/ozwpan/ozpd.c |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/ozwpan/ozpd.c b/drivers/staging/ozwpan/ozpd.c
index 06004c8..5d24af3 100644
On Fri, 23 Aug 2013, Ming Lei wrote:
On Fri, Aug 23, 2013 at 4:36 AM, Alan Stern st...@rowland.harvard.edu wrote:
On Thu, 22 Aug 2013, Ming Lei wrote:
This seems to be the most important factor. When you think about it,
though, does it really minimize the changes? Consider all the
On Fri, 23 Aug 2013, Ming Lei wrote:
On Fri, Aug 23, 2013 at 4:39 AM, Alan Stern st...@rowland.harvard.edu wrote:
This patch divides ehci-hcd's interrupt handler into a top half and a
bottom half, using a tasklet to execute the latter.
The conversion is very straightforward. The only
On Fri, Aug 23, 2013 at 10:53:38PM +0800, Alan Stern wrote:
On Fri, 23 Aug 2013, Huang Rui wrote:
What's special about LS devices? Or mice? Shouldn't the resume signal
be sent within 100 us for every device?
Yes, only mice would trigger this issue.
Reproduce steps:
1.
On Mon, Aug 12, 2013 at 4:32 PM, Bjorn Helgaas bhelg...@google.com wrote:
On Mon, Aug 12, 2013 at 3:32 PM, Yinghai Lu ying...@kernel.org wrote:
On Mon, Aug 12, 2013 at 2:14 PM, Bjorn Helgaas bhelg...@google.com wrote:
On Thu, Aug 8, 2013 at 7:57 AM, Rafael J. Wysocki r...@sisk.pl wrote:
On
On Sat, 24 Aug 2013, Huang Rui wrote:
On Fri, Aug 23, 2013 at 10:53:38PM +0800, Alan Stern wrote:
On Fri, 23 Aug 2013, Huang Rui wrote:
What's special about LS devices? Or mice? Shouldn't the resume signal
be sent within 100 us for every device?
Yes, only mice would
On 2013-01-26 19:48, Alan Stern wrote:
Please explain.
I can't. I don't know what's going on with your systems. But nobody
else seems to be experiencing this problem.
Well, I replaced the motherboard by one of the same type and same BIOS
version.
And the problem is still here.
kernel:[
Check for valid config number before completing set interface.
Signed-off-by: Rupesh Gujare rupesh.guj...@atmel.com
---
drivers/staging/ozwpan/ozhcd.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ozwpan/ozhcd.c b/drivers/staging/ozwpan/ozhcd.c
index
Make sure that we return negative value if oz_build_frame()
returns NULL.
Signed-off-by: Rupesh Gujare rupesh.guj...@atmel.com
---
drivers/staging/ozwpan/ozpd.c |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/ozwpan/ozpd.c
We have icreased interrupt end point buffer size to 512 bytes,
Change variable data type to accomodate it.
Signed-off-by: Rupesh Gujare rupesh.guj...@atmel.com
---
drivers/staging/ozwpan/ozhcd.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
Max. TX frame size supported is changed to 760 bytes.
Signed-off-by: Rupesh Gujare rupesh.guj...@atmel.com
---
drivers/staging/ozwpan/ozproto.h |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ozwpan/ozproto.h b/drivers/staging/ozwpan/ozproto.h
index
Increase interrupt end point buffer size convert hard coded
value to macro for better readability.
Signed-off-by: Rupesh Gujare rupesh.guj...@atmel.com
---
drivers/staging/ozwpan/ozhcd.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/ozwpan/ozhcd.c
On Wed, Aug 21, 2013 at 04:10:12PM +0800, Ming Lei wrote:
This patch introduces ehci_disable_event(), which is applied on
IAA_WATCHDOG and START_UNLINK_INTR timeouts if the two corresponding
events(IAA and intr URB submission) happened, so that we may avoid
unnecessary CPU wakeup by canceling
On Fri, Aug 23, 2013 at 05:43:51PM +, Graham Williams wrote:
The gadget strings table should be null terminated.
usb_gadget_get_string() loops through the table
expecting a null at the end of the list.
Signed-off-by: Graham Williamsgwi...@broadcom.com
Minor nit, you need a space after
The gadget strings table should be null terminated.
usb_gadget_get_string() loops through the table
expecting a null at the end of the list.
Signed-off-by: Graham Williams gwi...@broadcom.com
---
drivers/usb/gadget/f_acm.c | 1 +
1 file changed, 1 insertion(+)
diff --git
On Fri, Aug 23, 2013 at 05:51:12PM +, Graham Williams wrote:
The gadget strings table should be null terminated.
usb_gadget_get_string() loops through the table
expecting a null at the end of the list.
Signed-off-by: Graham Williams gwi...@broadcom.com
Nice, that works.
---
Anything to do with Sarah Sharp's (from Intel) comment
(https://plus.google.com/u/0/116960357493251979546/posts/RZpndv4BCCD)
and this patch (http://marc.info/?l=linux-usbm=137714769606183w=2)
suggested to be tested? I'll test it in the next couple of days just
in case. I'm asking so we don't work
On Fri, 23 Aug 2013, Udo van den Heuvel wrote:
On 2013-01-26 19:48, Alan Stern wrote:
Please explain.
I can't. I don't know what's going on with your systems. But nobody
else seems to be experiencing this problem.
Well, I replaced the motherboard by one of the same type and same
From: Greg KH gre...@linuxfoundation.org
Instead of having to audit all sysfs attributes, to ensure we get them
right, use the default macros the driver core provides us (read-only,
read-write) to make the code simpler, and to prevent any mistakes from
ever happening.
Signed-off-by: Greg
From: Greg Kroah-Hartman gre...@linuxfoundation.org
In auditing the usbtmc sysfs files, a bunch of them were being created
as read only, yet they have logic to handle writing to. So fix them
up by setting the permissions properly.
Signed-off-by: Greg Kroah-Hartman gre...@linuxfoundation.org
--
From: Greg Kroah-Hartman gre...@linuxfoundation.org
Clean up the DEVICE_ATTR usage in the USB serial drivers, making them
more obvious as to the permissions that the sysfs files should be.
Note: ftdi_sio.c still has a DEVICE_ATTR() used, that will have to wait
until after 3.12-rc1 comes out when
I couldn't get the whitespace formatting correctly from Windows Office (work
email) so I attached the patch file. I ran it on it applies correctly.
0001-usb-acm-gadget-Null-termintate-strings-table.patch
Description: 0001-usb-acm-gadget-Null-termintate-strings-table.patch
From: Greg Kroah-Hartman gre...@linuxfoundation.org
Convert all USB gadget sysfs attributes to use the _RO or _RW variants,
to make them easier to audit and ensure that the permissions are
correct.
Note, two are left using the DEVICE_ATTR() macro, as there is no
DEVICE_ATTR_WO() in Linus's tree,
On Fri, Aug 23, 2013 at 11:19:55PM +, Graham Williams wrote:
I couldn't get the whitespace formatting correctly from Windows Office (work
email) so I attached the patch file. I ran it on it applies correctly.
I can't take attachments, and especially not base64 ones :(
Take a look at the
Hello.
On 08/24/2013 03:09 AM, Greg Kroah-Hartman wrote:
From: Greg Kroah-Hartman gre...@linuxfoundation.org
In auditing the usbtmc sysfs files, a bunch of them were being created
as read only, yet they have logic to handle writing to. So fix them
up by setting the permissions properly.
On Sat, Aug 24, 2013 at 04:10:17AM +0400, Sergei Shtylyov wrote:
Hello.
On 08/24/2013 03:09 AM, Greg Kroah-Hartman wrote:
From: Greg Kroah-Hartman gre...@linuxfoundation.org
In auditing the usbtmc sysfs files, a bunch of them were being created
as read only, yet they have logic to
On Sat, Aug 24, 2013 at 12:06 AM, Alan Stern st...@rowland.harvard.edu wrote:
On Fri, 23 Aug 2013, Ming Lei wrote:
On Fri, Aug 23, 2013 at 4:39 AM, Alan Stern st...@rowland.harvard.edu
wrote:
This patch divides ehci-hcd's interrupt handler into a top half and a
bottom half, using a
On Fri, Aug 23, 2013 at 11:40 PM, Alan Stern st...@rowland.harvard.edu wrote:
On Fri, 23 Aug 2013, Ming Lei wrote:
On Fri, Aug 23, 2013 at 4:36 AM, Alan Stern st...@rowland.harvard.edu
wrote:
On Thu, 22 Aug 2013, Ming Lei wrote:
This seems to be the most important factor. When you
75 matches
Mail list logo
