Re: [PATCH v15 00/13] Add tested id switch and vbus connect detect support for Chipidea

2013-08-27 Thread Hector Palacios
Dear Peter, On 08/27/2013 04:51 AM, Peter Chen wrote: On Mon, Aug 26, 2013 at 06:24:48PM +0200, Hector Palacios wrote: Dear Peter, On 08/12/2013 03:22 AM, Peter Chen wrote: This patchset adds tested otg id switch function and vbus connect and disconnect detection for chipidea driver. And fix

Re: [alsa-devel] Buffer size for ALSA USB PCM audio

2013-08-27 Thread Clemens Ladisch
Alan Stern wrote: >> All the difficulty arises from the fact that we don't know beforehand >> how many URBs will constitute an ALSA period since for playback >> endpoints, the URB sizes can vary. [...] >> the number of URBs per period is fixed, and the number of packets in >> each URB is adjusted

Re: [alsa-devel] Buffer size for ALSA USB PCM audio

2013-08-27 Thread Pavel Hofman
On 27.8.2013 09:19, Clemens Ladisch wrote: > > The driver cannot control how many samples actually end up in a capture > packet,... Does this reasoning apply to asynchronous playback too? I understand the driver has some control, but has to satisfy the endpoint feedback requests. Sorry if this is

Re: [PATCH v15 00/13] Add tested id switch and vbus connect detect support for Chipidea

2013-08-27 Thread Alexander Shishkin
Hector Palacios writes: > Dear Peter, > > On 08/27/2013 04:51 AM, Peter Chen wrote: >> On Mon, Aug 26, 2013 at 06:24:48PM +0200, Hector Palacios wrote: >>> Dear Peter, >>> >>> On 08/12/2013 03:22 AM, Peter Chen wrote: This patchset adds tested otg id switch function and vbus connect and

[PATCH 2/4] usb: r8a66597-hcd: use platform_{get,set}_drvdata()

2013-08-27 Thread Libo Chen
Use the wrapper functions for getting and setting the driver data using platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev, so we can directly pass a struct platform_device. Signed-off-by: Libo Chen --- drivers/usb/host/r8a66597-hcd.c |4 ++-- 1 files changed, 2 insert

Re: [alsa-devel] Buffer size for ALSA USB PCM audio

2013-08-27 Thread Clemens Ladisch
Pavel Hofman wrote: > On 27.8.2013 09:19, Clemens Ladisch wrote: >> The driver cannot control how many samples actually end up in a capture >> packet,... > > Does this reasoning apply to asynchronous playback too? No. > I understand the driver has some control, but has to satisfy the endpoint > f

[PATCH 3/4] usb: phy-tegra-usb: use platform_{get,set}_drvdata()

2013-08-27 Thread Libo Chen
Use the wrapper functions for getting and setting the driver data using platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev, so we can directly pass a struct platform_device. Signed-off-by: Libo Chen --- drivers/usb/phy/phy-tegra-usb.c |2 +- 1 files changed, 1 insertio

Re: [PATCH v15 00/13] Add tested id switch and vbus connect detect support for Chipidea

2013-08-27 Thread Hector Palacios
On 08/27/2013 10:09 AM, Alexander Shishkin wrote: Hector Palacios writes: Dear Peter, On 08/27/2013 04:51 AM, Peter Chen wrote: On Mon, Aug 26, 2013 at 06:24:48PM +0200, Hector Palacios wrote: Dear Peter, On 08/12/2013 03:22 AM, Peter Chen wrote: This patchset adds tested otg id switch fu

[PATCH 0/4] usb: use platform_{get,set}_drvdata()

2013-08-27 Thread Libo Chen
Use the wrapper functions for getting and setting the driver data using platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev, so we can directly pass a struct platform_device. Libo Chen (4): usb: fotg210-udc: use platform_{get,set}_drvdata() usb: r8a66597-hcd: use platform

[PATCH 4/4] usb: renesas_usbhs: use platform_{get,set}_drvdata()

2013-08-27 Thread Libo Chen
Use the wrapper functions for getting and setting the driver data using platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev, so we can directly pass a struct platform_device. Signed-off-by: Libo Chen --- drivers/usb/renesas_usbhs/common.c |2 +- 1 files changed, 1 inser

[PATCH 1/4] usb: fotg210-udc: use platform_{get,set}_drvdata()

2013-08-27 Thread Libo Chen
Use the wrapper functions for getting and setting the driver data using platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev, so we can directly pass a struct platform_device. Signed-off-by: Libo Chen --- drivers/usb/gadget/fotg210-udc.c |4 ++-- 1 files changed, 2 inser

[PATCH v2 4/5] usb: chipidea: Fix memleak for ci->hw_bank.regmap when driver removal

2013-08-27 Thread Peter Chen
It needs to free ci->hw_bank.regmap explicitly since it is not managed resource. Signed-off-by: Peter Chen --- drivers/usb/chipidea/core.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c index 9462640..23763dc 100

[PATCH v2 2/5] usb: chipidea: udc: Consolidate the calling of ci->driver->disconnect

2013-08-27 Thread Peter Chen
The udc-core will call gadget's driver->disconnect, so we should avoid calling gadget's disconnect again at ci_udc_stop in case the gadget's unbind free some structs which is still used at gadget's disconnect. Tested-by: Marek Vasut Signed-off-by: Peter Chen --- drivers/usb/chipidea/udc.c | 1

[PATCH v2 0/5] Chipidea Misc patchset

2013-08-27 Thread Peter Chen
Changed for v2: - Fixed the build error for patch 5/5 Below are un-queued chipidea patches, some of them were reviewed. Peter Chen (5): usb: host: delete chipidea dependency usb: chipidea: udc: Consolidate the calling of ci->driver->disconnect usb: chipidea: udc: fix the oops when plugs in

[PATCH v2 5/5] usb: chipidea: move more platform related things to ci_get_platdata

2013-08-27 Thread Peter Chen
Like vbus, the dr_mode and phy_mode are also got from glue layer's platform data or device node. Signed-off-by: Peter Chen --- drivers/usb/chipidea/core.c | 19 +-- 1 files changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipide

[PATCH v2 3/5] usb: chipidea: udc: fix the oops when plugs in usb cable after rmmod gadget

2013-08-27 Thread Peter Chen
When we rmmod gadget, the ci->driver needs to be cleared. Otherwise, when we plug in usb cable again, the driver will consider gadget is there, and go to enumeration procedure, but in fact, it was removed. ci_hdrc ci_hdrc.0: Connected to host Unable to handle kernel paging request at virtual addre

[PATCH v2 1/5] usb: host: delete chipidea dependency

2013-08-27 Thread Peter Chen
Now, chipidea host has already depended on USB_EHCI_HCD Acked-by: Alan Stern Signed-off-by: Peter Chen --- drivers/usb/host/Kconfig |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig index 344d5e2..61466c5 100644 --- a

RE: [PATCH 0/2] fs: supply inode uid/gid setting interface

2013-08-27 Thread David Laight
> Subject: Re: [PATCH 0/2] fs: supply inode uid/gid setting interface > > On 2013/8/23 12:10, Greg KH wrote: > > On Fri, Aug 23, 2013 at 10:48:36AM +0800, Rui Xiang wrote: > >> This patchset implements an accessor functions to set uid/gid > >> in inode struct. Just finish code clean up. > > > > Wh

Re: [PATCH v15 00/13] Add tested id switch and vbus connect detect support for Chipidea

2013-08-27 Thread Hector Palacios
On 08/27/2013 10:12 AM, Hector Palacios wrote: On 08/27/2013 10:09 AM, Alexander Shishkin wrote: Hector Palacios writes: Dear Peter, On 08/27/2013 04:51 AM, Peter Chen wrote: On Mon, Aug 26, 2013 at 06:24:48PM +0200, Hector Palacios wrote: Dear Peter, On 08/12/2013 03:22 AM, Peter Chen wr

Re: staging:DWC2 USB driver issues

2013-08-27 Thread Matthijs Kooijman
Hi Dinh, > Any chance anyone has a similar experience with this DWC2 driver, any > help will greatly appreciated. Of course, I will go back and verify the > initialization between the DWC2 and the old driver to see if I can spot > anything. At first glance, the symptoms (getting transaction errors

Re: [PATCH v1] USB: EHCI: disable IAA_WATCHDOG and START_UNLINK_INTR if they needn't to be handled

2013-08-27 Thread Ming Lei
On Tue, Aug 27, 2013 at 4:05 AM, Alan Stern wrote: > On Mon, 26 Aug 2013, Ming Lei wrote: > >> > The problem is that once an interrupt QH has been unlinked, relinking >> > it might not make it visible to the hardware until the next frame >> > starts. Therefore interrupt endpoints with an interval

Re: staging:DWC2 USB driver issues

2013-08-27 Thread Pavel Machek
On Tue 2013-08-27 12:22:59, Matthijs Kooijman wrote: > Hi Dinh, > > > Any chance anyone has a similar experience with this DWC2 driver, any > > help will greatly appreciated. Of course, I will go back and verify the > > initialization between the DWC2 and the old driver to see if I can spot > > an

Re: 3.4.4: disabling irq

2013-08-27 Thread Udo van den Heuvel
Hello Alan, On 2013-08-23 21:33, Alan Stern wrote: >> Well, I replaced the motherboard by one of the same type and same BIOS >> version. >> And the problem is still here. >> >>> kernel:[ 3013.199945] Disabling IRQ #18 >> >> So what can we conclude? >> Kernel bug? >> Hardware bug? >> Something else

Re: staging:DWC2 USB driver issues

2013-08-27 Thread Pavel Machek
Hi! > I was wondering if anyone has come across the problem I am experiencing > with the staging DWC2 driver. The problem is that the driver is failing > to detect a device when connected. > > I know that HW works because I have an older version of the driver for > this IP and it seems to work O

Re: [RFC 2/3] EHCI: convert the IRQ handler to a tasklet

2013-08-27 Thread Alan Stern
On Tue, 27 Aug 2013, Ming Lei wrote: > > Yes. A new spinlock would be needed to synchronize the top half and > > the bottom half. The same spinlock would also be used to avoid > > scheduling the tasklet when it is already running, like in your > > implementation. > > Then every HCD need to copy

Re: [PATCH v1] USB: EHCI: disable IAA_WATCHDOG and START_UNLINK_INTR if they needn't to be handled

2013-08-27 Thread Alan Stern
On Tue, 27 Aug 2013, Ming Lei wrote: > > I don't understand your argument. The uhci-hcd _does_ support > > interrupt URBs being submitted from tasklets, workqueues, kernel > > threads, or whatever. The guarantee is that the interrupt URB will be > > scheduled right away if the endpoint queue has

[PATCH 2/4] staging: ozwpan: Reset PORT_ENABLE bit.

2013-08-27 Thread Rupesh Gujare
Reset PORT_ENABLE bit of port status on loosing PD. Signed-off-by: Rupesh Gujare --- drivers/staging/ozwpan/ozhcd.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ozwpan/ozhcd.c b/drivers/staging/ozwpan/ozhcd.c index b0398c5..39f5066 100644 --- a/drivers/s

[PATCH 3/4] staging: ozwpan: Add debounce time before unregistering.

2013-08-27 Thread Rupesh Gujare
Fixes following error caused during unloading driver. [ 1127.542888] usb 5-1: USB disconnect, device number 2 [ 1127.542909] ozwpan ozwpan: remove, state 1 [ 1127.542933] usb usb5: USB disconnect, device number 1 [ 1127.618634] hub 5-0:1.0: hub_port_status failed (err = -19) [ 1127.618647] hub_por

[PATCH 4/4] staging: ozwpan: Return error, if PD is not connected.

2013-08-27 Thread Rupesh Gujare
Return error if we receive write(), while PD is not connected. Signed-off-by: Rupesh Gujare --- drivers/staging/ozwpan/ozcdev.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/ozwpan/ozcdev.c b/drivers/staging/ozwpan/ozcdev.c index 03b41ee..22cb2ae 100644 --- a/drivers/s

[PATCH 1/4] staging: ozwpan: Increase ISOC IN buffer depth

2013-08-27 Thread Rupesh Gujare
Increase ISOC IN buffer depth to 100 units. Signed-off-by: Rupesh Gujare --- drivers/staging/ozwpan/ozhcd.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ozwpan/ozhcd.c b/drivers/staging/ozwpan/ozhcd.c index 3548860..b0398c5 100644 --- a/drivers/staging/o

Re: [alsa-devel] Buffer size for ALSA USB PCM audio

2013-08-27 Thread Alan Stern
On Tue, 27 Aug 2013, James Stone wrote: > This does not help at all with running jackd at lower latencies. > > With this patch, I get xruns at 128 frames/period or less with jackd > (accompanied by iso underrun messages), whereas with vanilla 3.10.9 > (which now has both yours and Clemen's patche

Re: [alsa-devel] Buffer size for ALSA USB PCM audio

2013-08-27 Thread Alan Stern
On Tue, 27 Aug 2013, Clemens Ladisch wrote: > There is no reasoning about capture endpoints. > > The driver cannot control how many samples actually end up in a capture > packet, so it is possible that URBs end up being one USB frame longer > than a period, in which case the ALSA period interrupt

Re: [PATCH] clk: samsung: pll: Use new registration method for PLL6552 and PLL6553

2013-08-27 Thread Kukjin Kim
On 08/27/13 10:14, Mike Turquette wrote: Quoting Tomasz Figa (2013-08-20 17:33:21) This patch modifies PLL6552 and PLL6553 clock drivers to use recently added common Samsung PLL registration method. Signed-off-by: Tomasz Figa Sigh. This change won't apply on top of clk-next-s3c64xx since it r

Re: [Bug] [Sony VAIO SVT15117CXS] USB 2.0 ports not working with any USB device

2013-08-27 Thread Alan Stern
On Mon, 26 Aug 2013, Kevin Archer wrote: > I think the link in my first email was wrong > here is the correct link > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1210858 > > I did run 2.6.33 and 2.6.39 in which the 2 usb ports did appear to > work, but the Xserver did not work correctly s

Re: [PATCH 4/4] staging: ozwpan: Return error, if PD is not connected.

2013-08-27 Thread Sergei Shtylyov
Hello. On 08/27/2013 07:53 PM, Rupesh Gujare wrote: Return error if we receive write(), while PD is not connected. Signed-off-by: Rupesh Gujare --- drivers/staging/ozwpan/ozcdev.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/ozwpan/ozcdev.c b/drivers/staging

Re: 3.4.4: disabling irq

2013-08-27 Thread Alan Stern
On Tue, 27 Aug 2013, Udo van den Heuvel wrote: > Hello Alan, > > On 2013-08-23 21:33, Alan Stern wrote: > >> Well, I replaced the motherboard by one of the same type and same BIOS > >> version. > >> And the problem is still here. > >> > >>> kernel:[ 3013.199945] Disabling IRQ #18 > >> > >> So wha

Re: Bug report: 045e:0721 Microsoft LifeCam NX-3000 not detected

2013-08-27 Thread Alan Stern
On Tue, 27 Aug 2013, Jürgen Liebmann wrote: > Alan, sorry your mail was redirect in the recycle folder of my email account > and I read this at first today. > Please can you help me, how I can get this both kernels without doing a new > bisect? > The results of bisect I'd already delete. I'm unf

Re: failure to resume from suspend cause by 84ebc102

2013-08-27 Thread Alan Stern
On Tue, 27 Aug 2013, Adam Borowski wrote: > > What happens if go back to a kernel without that commit and enable > > CONFIG_USB_SUSPEND? The behavior should be identical -- basically the > > commit is supposed to have the effect of always assuming that > > CONFIG_USB_SUSPEND has the same value as

[PATCH 2/3] xhci: fix port BESL LPM capability checking

2013-08-27 Thread Sarah Sharp
From: Mathias Nyman Wrong capability bit was checked for best effort service latency. bit 20 indicate port is BESL LPM capable (BLC), bit 19 is hardware LPM capable (HLC) This patch should be backported to kernels as old as 3.11, that contain the commit a558ccdcc71c7770c5e80c926a31cfe8a3892a09 "

[Pull Request] xhci: Bug fixes for 3.12.

2013-08-27 Thread Sarah Sharp
The following changes since commit 154547c4fe0fbe92185e69a6cdc2b0502b361995: USB: serial: clean up attribute permissions (2013-08-25 15:12:03 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/sarah/xhci.git tags/for-usb-next-2013-08-27 for you to

[PATCH 1/3] usb: xhci: Disable runtime PM suspend for quirky controllers

2013-08-27 Thread Sarah Sharp
From: Shawn Nematbakhsh If a USB controller with XHCI_RESET_ON_RESUME goes to runtime suspend, a reset will be performed upon runtime resume. Any previously suspended devices attached to the controller will be re-enumerated at this time. This will cause problems, for example, if an open system ca

[PATCH 3/3] xhci:prevent "callbacks suppressed" when debug is not enabled

2013-08-27 Thread Sarah Sharp
From: Dmitry Kasatkin When debug is not enabled and dev_dbg() will expand to nothing, log might be flooded with "callbacks suppressed". If it was not done on purpose, better to use dev_dbg_ratelimited() instead. Signed-off-by: Dmitry Kasatkin Signed-off-by: Sarah Sharp --- drivers/usb/host/xh

Re: [PATCH] USB: gadget: audit sysfs attribute permissions

2013-08-27 Thread Felipe Balbi
On Fri, Aug 23, 2013 at 04:34:43PM -0700, Greg Kroah-Hartman wrote: > From: Greg Kroah-Hartman > > Convert all USB gadget sysfs attributes to use the _RO or _RW variants, > to make them easier to audit and ensure that the permissions are > correct. > > Note, two are left using the DEVICE_ATTR()

Re: [PATCH] usb: phy: samsung-usb2: Toggle HSIC GPIO from device tree

2013-08-27 Thread Felipe Balbi
On Tue, Aug 13, 2013 at 02:11:27PM +0530, Tushar Behera wrote: > On 12 July 2013 12:27, Felipe Balbi wrote: > > Hi, > > > > On Wed, Jul 10, 2013 at 10:42:27AM -0700, Julius Werner wrote: > >> Hi Felipe, > >> > >> This is intended to pull down a reset signal line, not to switch power > >> to the de

Re: [RFC 2/2] usb: dwc3: Add Qualcomm DWC3 glue layer driver

2013-08-27 Thread Felipe Balbi
On Wed, Aug 14, 2013 at 12:28:17PM +0300, Ivan T. Ivanov wrote: > > Hi, > > On Mon, 2013-08-12 at 13:24 -0500, Felipe Balbi wrote: > > On Fri, Aug 09, 2013 at 07:09:18PM +0300, Ivan T. Ivanov wrote: > > > Hi, > > > > > > On Fri, 2013-08-09 at 16:23 +0300, Felipe Balbi wrote: > > > > Hi, > > >

Re: [PATCH] usb: dwc3: core: clarify usb-phy array binding

2013-08-27 Thread Felipe Balbi
Hi, On Tue, Aug 13, 2013 at 02:34:10PM +0100, Mark Rutland wrote: > On Mon, Aug 12, 2013 at 07:05:53PM +0100, Felipe Balbi wrote: > > On Fri, Aug 09, 2013 at 01:42:15PM -0500, Kumar Gala wrote: > > > > > > On Aug 9, 2013, at 11:28 AM, Mark Rutland wrote: > > > > > > > On Fri, Aug 09, 2013 at 04:

Re: [PATCH] usb: gadget/composite : Avoid crash with bad gadget drivers

2013-08-27 Thread Felipe Balbi
On Thu, Aug 15, 2013 at 01:40:01AM +0300, Philippe De Swert wrote: > Hi, > > On 12/08/13 21:08, Felipe Balbi wrote: > >On Fri, Aug 09, 2013 at 09:23:08PM +0300, Philippe De Swert wrote: > >>Some bad gadget drivers do not check the return status of usb_add_config. > > > >fix the gadget driver > >

Re: [PATCH] usb: phy: nop: Prepare clocks as well as enabling them

2013-08-27 Thread Felipe Balbi
On Fri, Aug 09, 2013 at 03:57:27PM +0100, Mark Brown wrote: > On Fri, Aug 09, 2013 at 05:38:57PM +0300, Felipe Balbi wrote: > > On Thu, Aug 08, 2013 at 12:35:04PM +0100, Mark Brown wrote: > > > > Systems with the common clock API need clk_prepare() as well as the enable > > > step. > > > clk_prep

Re: [PATCH] usb: musb: dsps: depend on of_irq

2013-08-27 Thread Felipe Balbi
Hi, On Tue, Aug 13, 2013 at 05:43:00PM +0200, Sebastian Andrzej Siewior wrote: > On 08/13/2013 05:36 PM, Felipe Balbi wrote: > > Hi, > > Hi, > > > I sent this patch yesterday. > > And how did you know about zhis yesterday? The bot reached me today. by trying to build it ? -- balbi signatur

Re: [PATCH 1/4] staging: ozwpan: Increase ISOC IN buffer depth

2013-08-27 Thread Dan Carpenter
On Tue, Aug 27, 2013 at 04:53:40PM +0100, Rupesh Gujare wrote: > Increase ISOC IN buffer depth to 100 units. > This change log is not useful. What are the user visible effects of this bug? regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the bod

Re: [PATCH 0/3] usb: dwc3: PHY should be selected when glue is enabled

2013-08-27 Thread Felipe Balbi
Hi, On Fri, Aug 16, 2013 at 03:21:07PM +0800, Huang Rui wrote: > Hi Felipe, > > USB transceivers should be selected when platform glues are enabled. > Because it need initialize usb phy platform device for binding related > phy driver when gules are probing. > > Patch 1 and patch 2 add NOP USB t

Re: [PATCH v11 0/8] PHY framework

2013-08-27 Thread Felipe Balbi
Hi, On Mon, Aug 26, 2013 at 01:44:49PM +0530, Kishon Vijay Abraham I wrote: > On Wednesday 21 August 2013 11:16 AM, Kishon Vijay Abraham I wrote: > > Added a generic PHY framework that provides a set of APIs for the PHY > > drivers > > to create/destroy a PHY and APIs for the PHY users to obtain

Re: [PATCH 4/4] usb: chipidea: USB_CHIPIDEA should depend on HAS_DMA

2013-08-27 Thread Felipe Balbi
On Mon, Aug 19, 2013 at 09:24:01AM +0800, Peter Chen wrote: > On Sun, Aug 18, 2013 at 10:20:44PM +0200, Geert Uytterhoeven wrote: > > If NO_DMA=y: > > > > drivers/built-in.o: In function `dma_set_coherent_mask': > > include/linux/dma-mapping.h:93: undefined reference to `dma_supported' > > > > Si

Re: [PATCH] davinci: fix resources passed to MUSB driver for DM6467

2013-08-27 Thread Sergei Shtylyov
Hello. On 08/12/2013 12:20 AM, Sergei Shtylyov wrote: After commit 09fc7d22b024692b2fe8a943b246de1af307132b (usb: musb: fix incorrect usage of resource pointer), CPPI DMA driver on DaVinci DM6467 can't detect its dedicated IRQ and so the MUSB IRQ is erroneously used instead. This is because o

Re: [PATCH 4/4] usb: chipidea: USB_CHIPIDEA should depend on HAS_DMA

2013-08-27 Thread Geert Uytterhoeven
On Tue, Aug 27, 2013 at 9:16 PM, Felipe Balbi wrote: > On Mon, Aug 19, 2013 at 09:24:01AM +0800, Peter Chen wrote: >> On Sun, Aug 18, 2013 at 10:20:44PM +0200, Geert Uytterhoeven wrote: >> > If NO_DMA=y: >> > >> > drivers/built-in.o: In function `dma_set_coherent_mask': >> > include/linux/dma-mapp

Re: [PATCH v4 2/3] usb: phy: Add Qualcomm SS-USB and HS-USB drivers for DWC3 core

2013-08-27 Thread Felipe Balbi
Hi, On Thu, Aug 22, 2013 at 09:24:49PM +, Paul Zimmerman wrote: > > From: Ivan T. Ivanov [mailto:iiva...@mm-sol.com] > > Sent: Tuesday, August 20, 2013 8:26 AM > > > > On Tue, 2013-08-20 at 10:01 -0500, Kumar Gala wrote: > > > On Aug 20, 2013, at 9:54 AM, Ivan T. Ivanov wrote: > > > > > > > >

Re: [PATCH] USB: gadget: audit sysfs attribute permissions

2013-08-27 Thread Greg Kroah-Hartman
On Tue, Aug 27, 2013 at 01:28:41PM -0500, Felipe Balbi wrote: > On Fri, Aug 23, 2013 at 04:34:43PM -0700, Greg Kroah-Hartman wrote: > > From: Greg Kroah-Hartman > > > > Convert all USB gadget sysfs attributes to use the _RO or _RW variants, > > to make them easier to audit and ensure that the per

Re: [Pull Request] xhci: Bug fixes for 3.12.

2013-08-27 Thread Greg Kroah-Hartman
On Tue, Aug 27, 2013 at 11:26:55AM -0700, Sarah Sharp wrote: > The following changes since commit 154547c4fe0fbe92185e69a6cdc2b0502b361995: > > USB: serial: clean up attribute permissions (2013-08-25 15:12:03 -0700) > > are available in the git repository at: > > git://git.kernel.org/pub/scm

Re: [PATCH] davinci: fix resources passed to MUSB driver for DM6467

2013-08-27 Thread Felipe Balbi
On Tue, Aug 27, 2013 at 11:23:43PM +0400, Sergei Shtylyov wrote: > Hello. > > On 08/12/2013 12:20 AM, Sergei Shtylyov wrote: > > >After commit 09fc7d22b024692b2fe8a943b246de1af307132b (usb: musb: fix > >incorrect > >usage of resource pointer), CPPI DMA driver on DaVinci DM6467 can't detect > >

Re: [alsa-devel] Buffer size for ALSA USB PCM audio

2013-08-27 Thread Alan Stern
On Tue, 27 Aug 2013, Clemens Ladisch wrote: > Alan Stern wrote: > > On Tue, 27 Aug 2013, Clemens Ladisch wrote: > >> The current algorithm uses very short capture URBs to ensure that _some_ > >> URB is completed as soon as possible after a period ends. > >> [...] > >> I'd suggest to keep the old c

Re: [alsa-devel] Buffer size for ALSA USB PCM audio

2013-08-27 Thread Clemens Ladisch
Alan Stern wrote: > On Tue, 27 Aug 2013, Clemens Ladisch wrote: >> The current algorithm uses very short capture URBs to ensure that _some_ >> URB is completed as soon as possible after a period ends. >> [...] >> I'd suggest to keep the old calculation for capture URBs. It would >> make sense to u

Re: [PATCH] usb: acm gadget: Null termintate strings table

2013-08-27 Thread Felipe Balbi
Hi, On Thu, Aug 22, 2013 at 07:10:04PM +, Graham Williams wrote: > The gadget strings table should be null terminated. > usb_gadget_get_string() loops through the table > expecting a null at the end of the list. > > Signed-off-by: Graham complains about being a malformed patch. -- balbi

Re: [patch] usb: musb: unlock on error in cppi41_dma_callback()

2013-08-27 Thread Felipe Balbi
On Wed, Aug 21, 2013 at 11:38:21AM +0300, Dan Carpenter wrote: > We need to unlock and enable IRQs before returning on error. > > Signed-off-by: Dan Carpenter doesn't apply -- balbi signature.asc Description: Digital signature

[GIT PULL] USB patches for v3.12 merge window (part 2)

2013-08-27 Thread Felipe Balbi
Hi Greg, As promissed, here's a set of important fixes for the first v3.12-rc release. If you want me to change anything, just let me know. The following changes since commit 154547c4fe0fbe92185e69a6cdc2b0502b361995: USB: serial: clean up attribute permissions (2013-08-25 15:12:03 -0700) are

Re: [PATCH 1/3 v5] usb: phy-samsung-usb: Simplify PMU register handling

2013-08-27 Thread Julius Werner
*Ping!* Are there still unanswered concerns left with this patch? I hope my prior mails could clear up why I think that the PMU register description in the device tree for a specific PHY is represents the hardware more accurately after my patch, and my analysis of the Exynos4 situation currently n

Re: [PATCH] davinci: fix resources passed to MUSB driver for DM6467

2013-08-27 Thread Sergei Shtylyov
On 08/28/2013 12:06 AM, Felipe Balbi wrote: After commit 09fc7d22b024692b2fe8a943b246de1af307132b (usb: musb: fix incorrect usage of resource pointer), CPPI DMA driver on DaVinci DM6467 can't detect its dedicated IRQ and so the MUSB IRQ is erroneously used instead. This is because only 2 resou

Re: [GIT PULL] USB patches for v3.12 merge window (part 2)

2013-08-27 Thread Greg KH
On Tue, Aug 27, 2013 at 03:16:05PM -0500, Felipe Balbi wrote: > Hi Greg, > > As promissed, here's a set of important fixes for > the first v3.12-rc release. If you want me to change > anything, just let me know. > > The following changes since commit 154547c4fe0fbe92185e69a6cdc2b0502b361995: > >

Re: staging:DWC2 USB driver issues

2013-08-27 Thread Dinh Nguyen
On Tue, 2013-08-27 at 14:13 +0200, ZY - pavel wrote: > On Tue 2013-08-27 12:22:59, Matthijs Kooijman wrote: > > Hi Dinh, > > > > > Any chance anyone has a similar experience with this DWC2 driver, any > > > help will greatly appreciated. Of course, I will go back and verify the > > > initializatio

Re: [PATCH 3/4] usb: phy-tegra-usb: use platform_{get,set}_drvdata()

2013-08-27 Thread Stephen Warren
On 08/27/2013 02:10 AM, Libo Chen wrote: > Use the wrapper functions for getting and setting the driver data using > platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev, > so we can directly pass a struct platform_device. Acked-by: Stephen Warren -- To unsubscribe from this l

Re: [RFC v2] usb: Fix xHCI host issues on remote wakeup.

2013-08-27 Thread Greg KH
On Mon, Aug 26, 2013 at 06:59:22PM -0700, Sarah Sharp wrote: > When a device signals remote wakeup on a roothub, and the suspend change > bit is set, the host controller driver must not give control back to the > USB core until the port goes back into the active state. > > EHCI accomplishes this b

[PATCH 0/2] Various fixes for dummy_hcd driver

2013-08-27 Thread Philippe De Swert
These two patches fix some minor issues in the dummy_hcd driver. Both errors were detected with the help of coverity analysis. Philippe De Swert (2): usb:gadget:dummy_hcd : Avoid infinite loop usb:gadget:dummy_hcd : Detect port and link state correctly to avoid unreachable code drivers/

[PATCH 1/2] usb:gadget:dummy_hcd : Avoid infinite loop

2013-08-27 Thread Philippe De Swert
When an error occurs adding a platform device there is a risk of an infinite loop. If more than one platform device was added i will remain >= than 0. The intention seems to clean up all the different already added platform devices before the failure occurs, so fixed the code to actually do so.

[PATCH 2/2] usb:gadget:dummy_hcd : Detect port and link state correctly to avoid unreachable code

2013-08-27 Thread Philippe De Swert
Since USB_SS_PORT_LS_U0 is 0x the & operation with the port state would always be 0. Thus the if would never be true. The code tries to check if the port is enabled and link is active (U0 state). This means the port_status should be 0x0001, so the right check is an | with USB_SS_PORT_LS_U0. F

RE: staging:DWC2 USB driver issues

2013-08-27 Thread Paul Zimmerman
> From: Dinh Nguyen [mailto:dingu...@altera.com] > Sent: Tuesday, August 27, 2013 2:09 PM > > On Tue, 2013-08-27 at 14:13 +0200, ZY - pavel wrote: > > On Tue 2013-08-27 12:22:59, Matthijs Kooijman wrote: > > > > > > What hardware are you working with? > > > > Very probably Altera Socfpga Cyclone V

Re: Memory synchronization vs. interrupt handlers

2013-08-27 Thread Paul E. McKenney
On Mon, Aug 26, 2013 at 11:49:15AM -0400, Alan Stern wrote: > David and Paul: > > Here's a question that doesn't seem to be answered in > Documentation/memory-barriers.txt. Are memory accesses within an > interrupt handler synchronized with respect to interrupts? > > In more detail, suppose we

[PATCH v2 0/3] usb: implement AMD remote wakeup quirk

2013-08-27 Thread Huang Rui
Hi Sarah, Alan, The following patches are required to resolve remote wake issues with certain devices. Issue description: If the remote wake is issued from the device in a specific timing condition while the system is entering sleep state then it may cause system to auto wake on subsequent sleep

[PATCH v2 1/3] usb: add is_usb_mouse routine and remote wakeup quirk

2013-08-27 Thread Huang Rui
This patch add a routine to judge if the usb device is a mouse or not. The is_usb_mouse only has one input parameter of usb_device. The return value is bool type, and true means this device is mouse and vice-versa. It also add a remote wakeup quirk for some special AMD platforms. This quirk filter

[PATCH v2 3/3] usb: ohci: add AMD remote wakeup quirk into ohci driver

2013-08-27 Thread Huang Rui
The following patch is required to resolve remote wake issues with certain devices. Issue description: If the remote wake is issued from the device in a specific timing condition while the system is entering sleep state then it may cause system to auto wake on subsequent sleep cycle. Root cause:

[PATCH v2 2/3] usb: xhci: implement AMD remote wakeup quirk

2013-08-27 Thread Huang Rui
The following patch is required to resolve remote wake issues with certain devices. Issue description: If the remote wake is issued from the device in a specific timing condition while the system is entering sleep state then it may cause system to auto wake on subsequent sleep cycle. Root cause:

Re: [PATCH v2 1/3] usb: add is_usb_mouse routine and remote wakeup quirk

2013-08-27 Thread Greg Kroah-Hartman
On Wed, Aug 28, 2013 at 11:13:12AM +0800, Huang Rui wrote: > This patch add a routine to judge if the usb device is a mouse or not. > The is_usb_mouse only has one input parameter of usb_device. The > return value is bool type, and true means this device is mouse and > vice-versa. No, sorry, this

Re: [PATCH] usb: phy: samsung-usb2: Toggle HSIC GPIO from device tree

2013-08-27 Thread Tushar Behera
On 28 August 2013 00:14, Felipe Balbi wrote: > On Tue, Aug 13, 2013 at 02:11:27PM +0530, Tushar Behera wrote: >> On 12 July 2013 12:27, Felipe Balbi wrote: >> > Hi, >> > >> > On Wed, Jul 10, 2013 at 10:42:27AM -0700, Julius Werner wrote: >> >> Hi Felipe, >> >> >> >> This is intended to pull down

Re: [PATCH v1] USB: EHCI: disable IAA_WATCHDOG and START_UNLINK_INTR if they needn't to be handled

2013-08-27 Thread Ming Lei
On Tue, Aug 27, 2013 at 10:55 PM, Alan Stern wrote: > On Tue, 27 Aug 2013, Ming Lei wrote: > >> > I don't understand your argument. The uhci-hcd _does_ support >> > interrupt URBs being submitted from tasklets, workqueues, kernel >> > threads, or whatever. The guarantee is that the interrupt URB

Re: [PATCH v1] USB: EHCI: disable IAA_WATCHDOG and START_UNLINK_INTR if they needn't to be handled

2013-08-27 Thread Ming Lei
On Wed, 28 Aug 2013 12:02:03 +0800 Ming Lei wrote: > Actually the problem only happened when underrun without > URB_ISO_ASAP. > > I have another fix which uses rebase trick and is simper(less change), could > you comment on the attachment patch? Sorry, please ignore last attachment patch, and

Re: [PATCH 3/4] usb: phy-tegra-usb: use platform_{get,set}_drvdata()

2013-08-27 Thread Greg KH
On Tue, Aug 27, 2013 at 04:10:27PM +0800, Libo Chen wrote: > > Use the wrapper functions for getting and setting the driver data using > platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev, > so we can directly pass a struct platform_device. > > Signed-off-by: Libo Chen > --

Re: [PATCH 2/4] usb: r8a66597-hcd: use platform_{get,set}_drvdata()

2013-08-27 Thread Greg KH
On Tue, Aug 27, 2013 at 04:10:22PM +0800, Libo Chen wrote: > > Use the wrapper functions for getting and setting the driver data using > platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev, > so we can directly pass a struct platform_device. > > Signed-off-by: Libo Chen > --

Re: [PATCH] USB: OHCI: Allow runtime PM without system sleep

2013-08-27 Thread Greg KH
On Mon, Aug 26, 2013 at 03:01:40PM -0400, Alan Stern wrote: > Since ohci-hcd supports runtime PM, the .pm field in its pci_driver > structure should be protected by CONFIG_PM rather than > CONFIG_PM_SLEEP. > > Without this change, OHCI controllers won't do runtime suspend if > system suspend or hi

[PATCH] drivers/usb/gadget/g_ffs.c: add missing header "u_ether.h"

2013-08-27 Thread Sergei Trofimovich
In some .config modes [1] macro 'USB_ETHERNET_MODULE_PARAMETERS' gets used without declaration: drivers/usb/gadget/g_ffs.c:79: warning: data definition has no type or storage class drivers/usb/gadget/g_ffs.c:79: warning: type defaults to 'int' in declaration of 'USB_ETHERNET_MODULE_PARAM

Re: [PATCH 2/4] usb: r8a66597-hcd: use platform_{get,set}_drvdata()

2013-08-27 Thread Libo Chen
On 2013/8/28 12:36, Greg KH wrote: > On Tue, Aug 27, 2013 at 04:10:22PM +0800, Libo Chen wrote: >> >> Use the wrapper functions for getting and setting the driver data using >> platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev, >> so we can directly pass a struct platform_dev

Re: [PATCH] usb: phy: nop: Prepare clocks as well as enabling them

2013-08-27 Thread Roger Quadros
Hi Mark, On 08/09/2013 05:57 PM, Mark Brown wrote: > On Fri, Aug 09, 2013 at 05:38:57PM +0300, Felipe Balbi wrote: >> On Thu, Aug 08, 2013 at 12:35:04PM +0100, Mark Brown wrote: > >>> Systems with the common clock API need clk_prepare() as well as the enable >>> step. > >> clk_prepare() is done

Re: [PATCH] drivers/usb/gadget/g_ffs.c: add missing header "u_ether.h"

2013-08-27 Thread Sergei Trofimovich
On Wed, 28 Aug 2013 08:57:28 +0300 Sergei Trofimovich wrote: > In some .config modes [1] macro 'USB_ETHERNET_MODULE_PARAMETERS' > gets used without declaration: > > drivers/usb/gadget/g_ffs.c:79: warning: data definition has no type or > storage class > drivers/usb/gadget/g_ffs.c:79: wa

Re: [alsa-devel] Buffer size for ALSA USB PCM audio

2013-08-27 Thread Clemens Ladisch
Alan Stern wrote: > On Tue, 27 Aug 2013, Clemens Ladisch wrote: >> Alan Stern wrote: >>> On Tue, 27 Aug 2013, Clemens Ladisch wrote: The current algorithm uses very short capture URBs to ensure that _some_ URB is completed as soon as possible after a period ends. [...] I'd sugge