Re: [PATCH v2 2/2] lsusb: Reports devices that support BESL on USB2.0

2013-09-04 Thread Greg KH
On Wed, Sep 04, 2013 at 04:22:09PM -0700, Sarah Sharp wrote: > Ping, Greg, are you going to take these? They look good to me, and I > can verify that the first patch works fine. Ah, verification is always nice to have, as I can't do it myself :) I'll apply it soon, and a much larger lsusb change

Re: [PATCH v2 2/2] lsusb: Reports devices that support BESL on USB2.0

2013-09-04 Thread Sarah Sharp
Ping, Greg, are you going to take these? They look good to me, and I can verify that the first patch works fine. Sarah Sharp On Wed, Aug 07, 2013 at 04:45:51PM -0700, Alexandra Yates wrote: > This patch adds USB2-LPM-Errata for USB2.0 Binary Object Store > Descriptor that support Best Effort Lat

Re: [PATCH 0/3] Adjust isochronous scheduling in ehci-hcd

2013-09-04 Thread Greg KH
On Tue, Sep 03, 2013 at 02:26:33PM -0400, Alan Stern wrote: > On Tue, 3 Sep 2013, Greg KH wrote: > > > On Tue, Sep 03, 2013 at 01:58:23PM -0400, Alan Stern wrote: > > > Greg: > > > > > > This series of three patches modifies the isochronous scheduling > > > routine in ehci-hcd, adding changes tha

Re: Bug 60810 - Kernel oops with controller XHCI while wait usb packet

2013-09-04 Thread Giovanni
> > Full Headers Printable View > > > This was very helpful. > > > Looks like when an address command times out, the > xHCI > > > command ring is > > > first aborted and then stopped. An event with stop > bit set > > > on a empty > > > command ring will point to the next "future" > command

Re: [PATCH 1/3] USB: use percpu counter to count submitted URBs per device

2013-09-04 Thread Greg Kroah-Hartman
On Wed, Sep 04, 2013 at 09:44:47PM +0200, Oliver Neukum wrote: > On Mon, 2013-08-19 at 10:23 -0700, Greg Kroah-Hartman wrote: > > > Please, use perf, and other things, to find out where real problems are > > Actually, first thing about the design. > > > in the USB stack. I'm sure there are loca

Re: [PATCH 1/3] USB: use percpu counter to count submitted URBs per device

2013-09-04 Thread Oliver Neukum
On Mon, 2013-08-19 at 10:23 -0700, Greg Kroah-Hartman wrote: > Please, use perf, and other things, to find out where real problems are Actually, first thing about the design. > in the USB stack. I'm sure there are locations that we can improve on, > but until you get some real numbers, it's goi

Re: [usb-storage] Re: dealing with enclosures that don't handle READ_CAPACITY10

2013-09-04 Thread Oliver Neukum
On Mon, 2013-08-19 at 09:50 +0200, Hannes Reinecke wrote: > On 08/12/2013 03:17 PM, Oliver Neukum wrote: > > Hi, > > > > I got a bug report about an enclosure that mishandles READ_CAPACITY10. > > I don't want to introduce yet another quirk. So what about basing this > > on USB version? > > > Hmm.

Re: [PATCH v3] usbcore: check usb device's state before sending a Set SEL control transfer

2013-09-04 Thread Martin MOKREJŠ
Hi Xenia, thank you. I tested this patch on 3.11 kernel and the messages don't appear anymore upon LPM-capable device disconnect (tested with ASMedia AS2105 devices). Not much to show here, there is just no error/warning related to LPM while handling these devices. Probably better test is with

Re: Bug 60810 - Kernel oops with controller XHCI while wait usb packet

2013-09-04 Thread Giovanni
> Full Headers Printable View > > > Hi Mathias, > > > > > > this is the log https://bugzilla.kernel.org/attachment.cgi?id=107415 > > with your patch. > > > > > > Thank you > > > Giovanni > > > > > > > Hi Giovanni > > > > This was very helpful. > > Looks like when an address command times out, the x

Re: Bug 60810 - Kernel oops with controller XHCI while wait usb packet

2013-09-04 Thread Giovanni
> > Hi Mathias, > > > > this is the log https://bugzilla.kernel.org/attachment.cgi?id=107415 > with your patch. > > > > Thank you > > Giovanni > > > > Hi Giovanni > > This was very helpful. > Looks like when an address command times out, the xHCI > command ring is > first aborted and then stoppe

Introducing libgadget 0.0.1

2013-09-04 Thread Matt Porter
With the move to configfs for creation of arbitrary USB composite gadgets, I found myself wanting a simple C library to configure and parse gadgets in a system. It has no other dependencies other than libc itself. It can be found at: git://git.linaro.org/people/mporter/libgadget.git Doxy

Re: Bug 60810 - Kernel oops with controller XHCI while wait usb packet

2013-09-04 Thread Giovanni
> On 08/29/2013 07:46 AM, Giovanni wrote: > > https://bugzilla.kernel.org/show_bug.cgi?id=60810 > > > > Bug ID: 60810 > > Summary: Kernel oops with controller XHCI while wait usb packet > > > > Hi > > I'm looking into the NULL pointer issue after timed out address devic

Re: Bug 60810 - Kernel oops with controller XHCI while wait usb packet

2013-09-04 Thread Mathias Nyman
On 09/04/2013 05:13 PM, Giovanni wrote: On 08/29/2013 07:46 AM, Giovanni wrote: https://bugzilla.kernel.org/show_bug.cgi?id=60810 Bug ID: 60810 Summary: Kernel oops with controller XHCI while wait usb packet Hi I'm looking into the NULL pointer issue after timed

[PATCH v3] usbcore: check usb device's state before sending a Set SEL control transfer

2013-09-04 Thread Xenia Ragiadakou
Set SEL control urbs cannot be sent to a device in unconfigured state. This patch adds a check in usb_req_set_sel() to ensure the usb device's state is USB_STATE_CONFIGURED. Signed-off-by: Xenia Ragiadakou Reported-by: Martin MOKREJS Suggested-by: Sarah Sharp --- Differences from v2: -push th

Re: Bug 60810 - Kernel oops with controller XHCI while wait usb packet

2013-09-04 Thread Giovanni
> > New log with both patches applied and USB_DEBUG > enabled > > https://bugzilla.kernel.org/attachment.cgi?id=107400 > > > > log size is limited I tried also with dmesg -s 4194304 > but with low success. > > I hope there is enough informations. > > > > Hi Giovanni, > > Sorry, I am b

[PATCH 1/2][usbutils] lsusb: port to hwdb

2013-09-04 Thread Tom Gundersen
Most of the information in usb.ids is now contained in udev's hwdb. Read the information from the hwdb instead of usb.ids. This would allow distributions to no longer ship (most of) usb.ids by default, but rather keep all the usb device information in the hwdb. This patch introduces a dependency

Re: [PATCHv2 1/2][usbutils] lsusb: port to hwdb

2013-09-04 Thread Tom Gundersen
On Fri, Aug 2, 2013 at 5:21 AM, Greg KH wrote: > On Wed, Jul 24, 2013 at 12:37:30PM +0200, Tom Gundersen wrote: >> Most of the information in usb.ids is now contained in udev's hwdb. Read the >> information from the hwdb instead of usb.ids. >> >> This would allow distributions to no longer ship (m

Re: Bug 60810 - Kernel oops with controller XHCI while wait usb packet

2013-09-04 Thread Huang Rui
On Wed, Sep 04, 2013 at 12:22:06AM +0800, Giovanni wrote: > > > On Tue, Sep 03, 2013 at 02:14:14AM +0800, Giovanni > > wrote: > > > > > On Sat, Aug 31, 2013 at 12:11:49AM > > > > > +0800, Giovanni wrote: > > > > > > > > > > > > > > > > I drafted a patch, please have a test and > > enable > > > >

Re: Bug 60810 - Kernel oops with controller XHCI while wait usb packet

2013-09-04 Thread Huang Rui
On Wed, Sep 04, 2013 at 01:22:28AM +0800, Sarah Sharp wrote: > On Tue, Sep 03, 2013 at 10:34:56AM +0800, Huang Rui wrote: > > Please apply this patch based my last patch, and have a test again. > > > > 8<-- cut here > > > > diff --git a/drivers

Re: [PATCH v11 0/8] PHY framework

2013-09-04 Thread Kishon Vijay Abraham I
On Tuesday 03 September 2013 09:20 PM, Greg KH wrote: > On Tue, Sep 03, 2013 at 08:55:23PM +0530, Kishon Vijay Abraham I wrote: >> Hi Greg, >> >> On Wednesday 28 August 2013 12:50 AM, Felipe Balbi wrote: >>> Hi, >>> >>> On Mon, Aug 26, 2013 at 01:44:49PM +0530, Kishon Vijay Abraham I wrote: On

[PATCH RESEND net-next] net: usbnet: update addr_assign_type if appropriate

2013-09-04 Thread Bjørn Mork
This module generates a common default address on init, using eth_random_addr. Set addr_assign_type to let userspace know the address is random unless it was overridden by the minidriver. Signed-off-by: Bjørn Mork Acked-by: Oliver Neukum --- Sorry this patch missed the "addr_assign_type series"

Re: [PATCH 4/5] uas: add dead request list

2013-09-04 Thread Gerd Hoffmann
On Di, 2013-09-03 at 10:39 -0700, Sarah Sharp wrote: > Don't you need to send an ABORT TASK message to the device to cancel the > outstanding request for that stream ID? I don't see that in this code. > I see lots of URB cancellation code, but nothing to remove the request > from the device-side q