On Thu, Oct 03 2013, Andrzej Pietrasiewicz andrze...@samsung.com wrote:
When configfs is in place, gadgets will have to be able to free
fsg buffers. Add a helper function.
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
On Sat, Oct 5, 2013 at 4:34 AM, Alan Stern st...@rowland.harvard.edu wrote:
On Fri, 4 Oct 2013, Markus Rechberger wrote:
I was only testing reading the data so I didn't see any caching
effects since I don't have a device or driver which I can send a lot
data out.
As far as I understand
On Thu, Oct 03 2013, Andrzej Pietrasiewicz wrote:
When configfs is in place, the luns will not be represented in sysfs,
so there will be no struct device associated with a lun.
In order to maintain compatibility and allow configfs adoption
sysfs is made optional in this patch.
As a
On Thu, Oct 03 2013, Andrzej Pietrasiewicz wrote:
fsg_common_init is a lengthy function. Factor a portion of it out.
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
Acked-by: Michal Nazarewicz min...@mina86.com
---
On Thu, Oct 03 2013, Andrzej Pietrasiewicz wrote:
fsg_common_init is a lengthy function. Factor a portion of it out.
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
Acked-by: Michal Nazarewicz min...@mina86.com
---
On Thu, Oct 03 2013, Andrzej Pietrasiewicz wrote:
fsg_common_init is a lengthy function. Factor portions of it out.
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
Acked-by: Michal Nazarewicz min...@mina86.com
---
On Thu, Oct 03 2013, Andrzej Pietrasiewicz wrote:
fsg_common_init is a lengthy function. Factor portions of it out.
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/usb/gadget/f_mass_storage.c | 16
On Thu, Oct 03 2013, Andrzej Pietrasiewicz wrote:
fsg_common_init is a lengthy function. Factor a portion of it out.
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
Acked-by: Michal Nazarewicz min...@mina86.com
---
On Thu, Oct 03 2013, Andrzej Pietrasiewicz wrote:
fsg_common_init is a lengthy function. Factor portions of it out.
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
Acked-by: Michal Nazarewicz min...@mina86.com
---
On Thu, Oct 03 2013, Andrzej Pietrasiewicz wrote:
fsg_common_init is a lengthy function. Factor a portion of it out.
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
Acked-by: Michal Nazarewicz min...@mina86.com.
---
On Thu, Oct 03 2013, Andrzej Pietrasiewicz wrote:
fsg_common_init is a lengthy function. Factor a portion of it out.
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
Acked-by: Michal Nazarewicz min...@mina86.com
---
On Sat, 5 Oct 2013, Arokux X wrote:
Hi all,
first of all thank you all for your help. I now have some news to
report. Using your hint about timing I've inserted a bunch of udelays
around the read/write functions that get called from _rtl92c_write_fw
and got rid of the detected XactErr len
On Fri, 4 Oct 2013, Deng-Cheng Zhu wrote:
From: Deng-Cheng Zhu dengcheng@imgtec.com
The logic len = (x) in OK(x) is dead. Clean it up.
Reviewed-by: James Hogan james.ho...@imgtec.com
Signed-off-by: Deng-Cheng Zhu dengcheng@imgtec.com
Getting rid of the OK macro is a good idea.
On Fri, 4 Oct 2013, Deng-Cheng Zhu wrote:
From: Deng-Cheng Zhu dengcheng@imgtec.com
Now that UHCI IO registers have been defined in uhci-hcd.h, use them.
Reviewed-by: James Hogan james.ho...@imgtec.com
Signed-off-by: Deng-Cheng Zhu dengcheng@imgtec.com
---
On Sat, 5 Oct 2013, Ming Lei wrote:
The buffer should be cached. The userspace program will have to make
sure that it doesn't try to access the buffer while DMA is in progress.
As long as that restriction is obeyed, the USB core will take care of
mapping the buffer for DMA (which flushes
On Sat, Oct 5, 2013 at 11:10 PM, Alan Stern st...@rowland.harvard.edu wrote:
On Sat, 5 Oct 2013, Ming Lei wrote:
The buffer should be cached. The userspace program will have to make
sure that it doesn't try to access the buffer while DMA is in progress.
As long as that restriction is
instead of type
Signed-off-by: Matthias Beyer m...@beyermatthias.de
---
drivers/usb/core/hcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
index d6a8d23..9036794 100644
--- a/drivers/usb/core/hcd.c
+++
Signed-off-by: Matthias Beyer m...@beyermatthias.de
---
drivers/usb/core/hcd.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
index 0f3e5a0..3a2667c 100644
--- a/drivers/usb/core/hcd.c
+++ b/drivers/usb/core/hcd.c
@@
Hi!
I did some cleanup in
drivers/usb/core/hcd.c
of ERROR messages from scripts/checkpatch.pl --file. Not all ERRORs are fixed,
there are some remaining with assignment in if statement.
It's based on 7dee8df, which is Linus current master. I compiled it without
errors. Checkpatch script
Put else keyword on same line as closing brace from if statement, added
{ } braces as the styleguide says.
Signed-off-by: Matthias Beyer m...@beyermatthias.de
---
drivers/usb/core/hcd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/core/hcd.c
including
- spaces to tabs
- removing spaces before array indexing (foo [] to foo[])
- adding spaces around unary operator (foo? 1 : 0 to foo ? 1 : 0)
- removed trailing whitespace
Signed-off-by: Matthias Beyer m...@beyermatthias.de
---
drivers/usb/core/hcd.c | 56
On 10/05/2013 10:01 AM, Alan Stern wrote:
On Sat, 5 Oct 2013, Arokux X wrote:
Hi all,
first of all thank you all for your help. I now have some news to
report. Using your hint about timing I've inserted a bunch of udelays
around the read/write functions that get called from _rtl92c_write_fw
The following changes since commit 15c03dd4859ab16f9212238f29dd315654aa94f6:
Linux 3.12-rc3 (2013-09-29 15:02:38 -0700)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/
tags/usb-3.12-rc4
for you to fetch changes up to
On Sat, 2013-10-05 at 18:02 +0200, Matthias Beyer wrote:
- removing spaces before array indexing (foo [] to foo[])
[]
diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
[]
@@ -93,7 +93,7 @@ EXPORT_SYMBOL_GPL (usb_bus_list);
/* used when allocating bus numbers */
#define USB_MAXBUS
On Sat, 2013-10-05 at 11:04 -0700, Joe Perches wrote:
On Sat, 2013-10-05 at 18:02 +0200, Matthias Beyer wrote:
- removing spaces before array indexing (foo [] to foo[])
[]
diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
[]
@@ -93,7 +93,7 @@ EXPORT_SYMBOL_GPL (usb_bus_list);
On Sat, 5 Oct 2013, Larry Finger wrote:
I do however have something fishy to report, but this is probably an
off-topic for linux-usb mailing list so I'll just mention it here
briefly for completeness. Fist, I've compared the speed of the
rtl8192cu vs 8192cu in 3.4 kernel. The latter one
On 10/05/2013 02:52 PM, Alan Stern wrote:
On Sat, 5 Oct 2013, Larry Finger wrote:
I do however have something fishy to report, but this is probably an
off-topic for linux-usb mailing list so I'll just mention it here
briefly for completeness. Fist, I've compared the speed of the
rtl8192cu vs
The DECLARE_BITMAP macro should be used for declaring this bitmap.
This commit converts the busmap from a struct to a simple (static)
bitmap, using the DECLARE_BITMAP macro from linux/types.h.
Please review, as I'm new to kernel development, I don't know if this
has any hidden side effects!
old_rdtodo and size are short type. They are type promoted to int
and the condition is never true.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/usb/serial/cyberjack.c b/drivers/usb/serial/cyberjack.c
index 7814262..6e1b69d 100644
---
29 matches
Mail list logo
