Re: [PATCH RFC 1/4] phy: Add new Exynos5 USB 3.0 PHY driver

2013-12-05 Thread Vivek Gautam
Hi Kishon, On Wed, Dec 4, 2013 at 7:58 PM, Kishon Vijay Abraham I kis...@ti.com wrote: Hi Vivek, On Wednesday 20 November 2013 09:14 PM, Kishon Vijay Abraham I wrote: Hi, On Wednesday 20 November 2013 03:02 PM, Vivek Gautam wrote: On Wed, Nov 20, 2013 at 2:34 PM, Kishon Vijay Abraham I

Re: [PATCH v2 2/4] dt: exynos5250: Enable support for generic USB 3.0 phy

2013-12-05 Thread Vivek Gautam
Hi, On Wed, Dec 4, 2013 at 6:20 PM, Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com wrote: Hi, Does the old phy-samsung-usb3 driver currently work on Exynos5250? If yes, then this patch should be merged with patch #1 to preserve bisectability. Yes, the old phy-samsung-usb3 driver works

Re: [PATCH 1/2] usb: chipidea: fix mistake in device tree binding of nspire-usb to use vendor name 'lsi' instead of SoC name 'zevio'

2013-12-05 Thread Peter Chen
On Thu, Dec 05, 2013 at 04:44:13PM +1100, Daniel Tang wrote: Hi, On 05/12/2013, at 12:44 AM, Peter Chen peter.c...@freescale.com wrote: lsi is vendor name, what are zevio and nspire? Usually, the compatible string should be vendor_name,soc_name-module_name Because this port uses

[PATCH v3] usb: ohci-at91: fix irq and iomem resource retrieval

2013-12-05 Thread Boris BREZILLON
When using dt resources retrieval (interrupts and reg properties) there is no predefined order for these resources in the platform dev resources table. Retrieve resources using the platform_get_resource function instead of direct resource table entries to avoid resource type mismatch.

Re: [PATCH v3] usb: ohci-at91: fix irq and iomem resource retrieval

2013-12-05 Thread Tomasz Figa
Hi Boris, On Thursday 05 of December 2013 10:50:13 Boris BREZILLON wrote: When using dt resources retrieval (interrupts and reg properties) there is no predefined order for these resources in the platform dev resources table. Retrieve resources using the platform_get_resource function

[PATCH v3 1/3] usb: ohci-at91: replace request_mem_region + ioremap by devm_request_and_ioremap

2013-12-05 Thread Boris BREZILLON
Replace the request_mem_region + ioremap calls by the devm_request_and_ioremap call which does the same things but with device managed resources. Signed-off-by: Boris BREZILLON b.brezil...@overkiz.com Acked-by: Nicolas Ferre nicolas.fe...@atmel.com Signed-off-by: Alan Stern

[PATCH v3 2/3] usb: ohci-at91: use dev variable instead of pdev-dev

2013-12-05 Thread Boris BREZILLON
Make use of the dev variable instead of referencing the dev field of the pdev struct. Signed-off-by: Boris BREZILLON b.brezil...@overkiz.com Acked-by: Nicolas Ferre nicolas.fe...@atmel.com Signed-off-by: Alan Stern st...@rowland.harvard.edu --- drivers/usb/host/ohci-at91.c | 18

[PATCH v3 3/3] usb: ohci-at91: use device managed clk retrieval

2013-12-05 Thread Boris BREZILLON
Replace clk_get calls by devm_clk_get calls. Signed-off-by: Boris BREZILLON b.brezil...@overkiz.com Acked-by: Nicolas Ferre nicolas.fe...@atmel.com Signed-off-by: Alan Stern st...@rowland.harvard.edu --- drivers/usb/host/ohci-at91.c | 30 +++--- 1 file changed, 7

RE: [PATCH 4/7] usb: chipidea: add freescale imx28 special write register method

2013-12-05 Thread David Laight
From: Peter Chen According to Freescale imx28 Errata, ENGR119653 USB: ARM to USB register error issue, All USB register write operations must use the ARM SWP instruction. So, we implement special hw_write and hw_test_and_clear for imx28. Discussion for it at below:

Re: [PATCH v4 12/15] usb: phy: msm: Add support for secondary PHY control

2013-12-05 Thread Mark Rutland
On Mon, Nov 18, 2013 at 12:57:42PM +, Ivan T. Ivanov wrote: Hi Mark, On Fri, 2013-11-15 at 16:42 +, Mark Rutland wrote: On Tue, Nov 12, 2013 at 02:51:47PM +, Ivan T. Ivanov wrote: From: Ivan T. Ivanov iiva...@mm-sol.com Allow support to use 2nd HSPHY with USB2 Core.

[PATCH 1/2] usb: Use dev_is_pci() to check whether it is pci device

2013-12-05 Thread Yijing Wang
Use PCI standard marco dev_is_pci() instead of directly compare pci_bus_type to check whether it is pci device. Signed-off-by: Yijing Wang wangyij...@huawei.com --- drivers/usb/host/ehci-dbg.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/usb/host/ehci-dbg.c

[PATCH 2/2] uwb: Use dev_is_pci() to check whether it is pci device

2013-12-05 Thread Yijing Wang
Use PCI standard marco dev_is_pci() instead of directly compare pci_bus_type to check whether it is pci device. Signed-off-by: Yijing Wang wangyij...@huawei.com --- drivers/uwb/umc-bus.c |2 +- include/linux/uwb/umc.h |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 1/2] usb: chipidea: move malloced regmap directly into struct hw_bank

2013-12-05 Thread Marc Kleine-Budde
Without this patch a seperate chunk of memory is allocated for the regmap array. As the regmap is always used it makes no sense to allocate a seperate memory block for it, this patch moves the regmap array directly into the struct hw_bank. Signed-off-by: Marc Kleine-Budde m...@pengutronix.de ---

[PATCH 2/2] usb: chipidea: mark register map as const and convert to u8

2013-12-05 Thread Marc Kleine-Budde
This patch makes the controller register map ci_regs_nolpm and ci_regs_lpm as const. Further, as all offset fit into a single byte, the type is changed from uintptr_t to u8. Signed-off-by: Marc Kleine-Budde m...@pengutronix.de --- drivers/usb/chipidea/core.c | 80

Re: xHCI quirk increases module load time

2013-12-05 Thread Takashi Iwai
At Tue, 3 Dec 2013 16:17:15 -0800, Sarah Sharp wrote: On Tue, Dec 03, 2013 at 01:13:15PM -0800, Greg KH wrote: On Tue, Dec 03, 2013 at 01:08:08PM -0800, Sarah Sharp wrote: Yeah, it doesn't make much sense to me either. But I can reproduce the behavior on my Lenovo x230 if I add the PCI

[PATCH v4 0/9] phy: Add new Exynos USB 2.0 PHY driver

2013-12-05 Thread Kamil Debski
Hi, This is the fourth version of the patchset adding the new Exynos USB 2.0 PHY driver. The driver uses the Generic PHY Framework. A month has passed since the last version. I have addressed numerous comments that appeared on the mailing list in this patch. I would like to specially thank

[PATCH v4 4/9] usb: ehci-s5p: Change to use phy provided by the generic phy framework

2013-12-05 Thread Kamil Debski
Change the phy provider used from the old usb phy specific to a new one using the generic phy framework. Signed-off-by: Kamil Debski k.deb...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- Documentation/devicetree/bindings/usb/usb-ehci.txt | 35

[PATCH 1/9] phy: core: Change the way of_phy_get is called

2013-12-05 Thread Kamil Debski
Previously the of_phy_get function took a struct device * and was declared static. It was impossible to call it from another driver and thus it was impossible to get phy defined for a given node. Signed-off-by: Kamil Debski k.deb...@samsung.com Signed-off-by: Kyungmin Park

[PATCH 2/9] phy: core: Add devm_of_phy_get to phy-core

2013-12-05 Thread Kamil Debski
Adding devm_of_phy_get will allow to get phys by supplying the device_node instead of by name. Signed-off-by: Kamil Debski k.deb...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/phy/phy-core.c | 31 +++ include/linux/phy/phy.h |

RE: [PATCH 4/7] usb: chipidea: add freescale imx28 special write register method

2013-12-05 Thread Peter Chen
Personally I think you should include the text of the errata in one of the files. Yes, some may be interested in detail, not only the solution, will do it next time. I'm not suggesting you change the guts of the patch, but... Having read the errata it isn't 100% clear to me that

Re: [PATCH 4/7] usb: chipidea: add freescale imx28 special write register method

2013-12-05 Thread Marc Kleine-Budde
On 12/05/2013 01:16 PM, Peter Chen wrote: Personally I think you should include the text of the errata in one of the files. Yes, some may be interested in detail, not only the solution, will do it next time. I'm not suggesting you change the guts of the patch, but... Having read the

RE: [PATCH 4/7] usb: chipidea: add freescale imx28 special write register method

2013-12-05 Thread Peter Chen
On 12/05/2013 01:16 PM, Peter Chen wrote: Personally I think you should include the text of the errata in one of the files. Yes, some may be interested in detail, not only the solution, will do it next time. I'm not suggesting you change the guts of the patch, but... Having

RE: [PATCH 4/7] usb: chipidea: add freescale imx28 special write register method

2013-12-05 Thread David Laight
We can't guarantee there is no other access on the AHB without disable interrupt, would you think below operation will be more efficient than swp, or any better solutions? I don't know whether it would be more or less efficient, it rather depends on the finer points of the architecture. It

Re: [PATCH v4 0/9] phy: Add new Exynos USB 2.0 PHY driver

2013-12-05 Thread Kishon Vijay Abraham I
Hi, On Thursday 05 December 2013 05:59 PM, Kamil Debski wrote: Hi, This is the fourth version of the patchset adding the new Exynos USB 2.0 PHY driver. The driver uses the Generic PHY Framework. A month has passed since the last version. I have addressed numerous comments that appeared

Re: [PATCH 1/2] usb: Use dev_is_pci() to check whether it is pci device

2013-12-05 Thread Alan Stern
On Thu, 5 Dec 2013, Yijing Wang wrote: Use PCI standard marco dev_is_pci() instead of directly compare pci_bus_type to check whether it is pci device. Signed-off-by: Yijing Wang wangyij...@huawei.com --- drivers/usb/host/ehci-dbg.c |2 +- 1 files changed, 1 insertions(+), 1

xhci patches

2013-12-05 Thread David Laight
I sent a few patches to the xhci driver at the beginning of November. One of them has been pushed to 3.13 and 3.12. If it possible to find out if the others are queued somewhere or whether I should resubmit them? David -- To unsubscribe from this list: send the line unsubscribe

RE: [PATCH] usb: hub: Use correct reset for wedged USB3 devices that are NOTATTACHED

2013-12-05 Thread Cortes, Alexis
Hi Sarah, Sorry for my delayed response, I was on vacation. Although I wasn't able to verify this on an actual system that is susceptible to the compliance mode issue, after reviewing the USB spec, I don't think it is possible that a port can enter compliance mode while a connected device is

Re: xhci patches

2013-12-05 Thread Sarah Sharp
On Thu, Dec 05, 2013 at 03:50:59PM -, David Laight wrote: I sent a few patches to the xhci driver at the beginning of November. One of them has been pushed to 3.13 and 3.12. If it possible to find out if the others are queued somewhere or whether I should resubmit them? I'm dealing with

[PATCH] usb: fix leak of descriptor buffer on hub_enable_device failure

2013-12-05 Thread Dan Williams
Smatch says: drivers/usb/core/hub.c:4324 hub_port_init() warn: possible memory leak of 'buf' Fixes: 1e6ed41e7e29 (usb: xhci: change enumeration scheme to 'new scheme' by default) Reported-by: Dan Carpenter dan.carpen...@oracle.com Signed-off-by: Dan Williams dan.j.willi...@intel.com ---

Re: [PATCH v4 4/9] usb: ehci-s5p: Change to use phy provided by the generic phy framework

2013-12-05 Thread Alan Stern
On Thu, 5 Dec 2013, Kamil Debski wrote: Change the phy provider used from the old usb phy specific to a new one using the generic phy framework. Signed-off-by: Kamil Debski k.deb...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- a/drivers/usb/host/ehci-exynos.c

Re: [PATCH v3 1/3] usb: ohci-at91: replace request_mem_region + ioremap by devm_request_and_ioremap

2013-12-05 Thread Sergei Shtylyov
Hello. On 12/05/2013 12:54 PM, Boris BREZILLON wrote: Replace the request_mem_region + ioremap calls by the devm_request_and_ioremap call which does the same things but with device managed resources. Signed-off-by: Boris BREZILLON b.brezil...@overkiz.com Acked-by: Nicolas Ferre

Re: [PATCH] usb: fix leak of descriptor buffer on hub_enable_device failure

2013-12-05 Thread Sarah Sharp
Hi Dan, Can you send me an updated patch for commit 1e6ed41e7e29 that includes this fix? I haven't queued this to Greg yet, and I would like to avoid introducing bugs on bisect. Thanks, Sarah Sharp On Thu, Dec 05, 2013 at 10:00:00AM -0800, Dan Williams wrote: Smatch says:

Re: [PATCH] usb: fix leak of descriptor buffer on hub_enable_device failure

2013-12-05 Thread Dan Williams
On Thu, Dec 5, 2013 at 1:53 PM, Sarah Sharp sarah.a.sh...@linux.intel.com wrote: Hi Dan, Can you send me an updated patch for commit 1e6ed41e7e29 that includes this fix? I haven't queued this to Greg yet, and I would like to avoid introducing bugs on bisect. Sure thing, was not sure if

[PATCH v3] usb: xhci: change enumeration scheme to 'new scheme' by default

2013-12-05 Thread Dan Williams
Change the default enumeration scheme for xhci attached non-SuperSpeed devices from: Reset SetAddress [xhci address-device BSR = 0] GetDescriptor(8) GetDescriptor(18) ...to: Reset [xhci address-device BSR = 1] GetDescriptor(64) Reset SetAddress [xhci address-device

RE: [PATCH 1/2] usb: chipidea: fix mistake in device tree binding of nspire-usb to use vendor name 'lsi' instead of SoC name 'zevio'

2013-12-05 Thread Peter Chen
Hi, On 05/12/2013, at 7:49 PM, Peter Chen peter.c...@freescale.com wrote: On Thu, Dec 05, 2013 at 04:44:13PM +1100, Daniel Tang wrote: Hi, On 05/12/2013, at 12:44 AM, Peter Chen peter.c...@freescale.com wrote: lsi is vendor name, what are zevio and nspire? Usually, the

[PATCH v2] usb: core: Make sure usb_set_configuration(-1) cannot fail

2013-12-05 Thread Julius Werner
usb_deauthorize_device() tries to unset the configuration of a USB device and then unconditionally blows away the configuration descriptors with usb_destroy_configuration(). This is bad if the usb_set_configuration() call failed before the configuration could be correctly unset, since pointers

[PATCH] Usb: atm: usbatm: fixed a pointer variable format issue

2013-12-05 Thread learc83
Fixed a pointer variable format issue. Signed-off-by: Seth Archer Brown lear...@gmail.com --- drivers/usb/atm/usbatm.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/usb/atm/usbatm.c b/drivers/usb/atm/usbatm.c index 25a7bfc..dada014 100644 ---

Re: [PATCH 1/9] phy: core: Change the way of_phy_get is called

2013-12-05 Thread Kishon Vijay Abraham I
Hi, On Thursday 05 December 2013 05:59 PM, Kamil Debski wrote: Previously the of_phy_get function took a struct device * and was declared static. It was impossible to call it from another driver and thus it was impossible to get phy defined It was never intended to be called from other

Re: [GIT PULL] xhci: Regression fix for 3.13.

2013-12-05 Thread Mark Lord
On 13-12-02 04:42 PM, Greg Kroah-Hartman wrote: On Mon, Dec 02, 2013 at 12:49:08PM -0800, Sarah Sharp wrote: The following changes since commit c24cb6c8b501ebdf1aacec7960110a9741a45ced: Merge tag 'fixes-for-v3.13-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb into

Re: [PATCH 0/2] usb: chipidea: streamline regmap handling

2013-12-05 Thread Peter Chen
On Thu, Dec 05, 2013 at 12:32:55PM +0100, Marc Kleine-Budde wrote: Hello Peter, these patches are for your ci-for-usb-next branch. The repmap handling is streamlined and the kernel shrinks by 706 bytes on i.MX28: add/remove: 0/0 grow/shrink: 0/30 up/down: 0/-706 (-706) function

Re: [PATCH 1/2] usb: chipidea: move malloced regmap directly into struct hw_bank

2013-12-05 Thread Peter Chen
On Thu, Dec 05, 2013 at 12:32:56PM +0100, Marc Kleine-Budde wrote: Without this patch a seperate chunk of memory is allocated for the regmap array. As the regmap is always used it makes no sense to allocate a seperate memory block for it, this patch moves the regmap array directly into the

Re: [PATCH 2/2] usb: chipidea: mark register map as const and convert to u8

2013-12-05 Thread Peter Chen
On Thu, Dec 05, 2013 at 12:32:57PM +0100, Marc Kleine-Budde wrote: This patch makes the controller register map ci_regs_nolpm and ci_regs_lpm as const. Further, as all offset fit into a single byte, the type is changed from uintptr_t to u8. Signed-off-by: Marc Kleine-Budde

Re: [PATCH] usb: chipidea: fix device tree binding for zevio/nspire usb driver

2013-12-05 Thread Peter Chen
On Thu, Dec 05, 2013 at 05:37:01PM +1100, dt.ta...@gmail.com wrote: From: Daniel Tang dt.ta...@gmail.com The device tree binding chosen for the nspire-usb driver was inappropriate and should be renamed to lsi,zevio-usb. References to nspire have been replaced with zevio (the SoC name)

Re: [PATCH] usb: chipidea: host: Only disable the vbus regulator if it is not NULL

2013-12-05 Thread Peter Chen
On Fri, Nov 08, 2013 at 01:09:47AM -0200, Fabio Estevam wrote: From: Fabio Estevam fabio.este...@freescale.com Commit 40ed51a4b (usb: chipidea: host: add vbus regulator control) introduced a smatch complaint because regulator_disable() is called without checking whether ci-platdata-reg_vbus

Re: [PATCH 1/1] usb: chipidea: fix nobody cared IRQ when booting with host role

2013-12-05 Thread Peter Chen
On Sat, Nov 30, 2013 at 02:38:29PM +0100, Marc Kleine-Budde wrote: On 11/22/2013 09:14 AM, Peter Chen wrote: If we connect Male-A-To-Male-A cable between otg-host and host pc, the ci-vbus_active is set wrongly, and cause the controller run at peripheral mode when we load gadget module

Re: [PATCH v6 0/3] usb: ehci+chipidea: fix imx28 ENGR119653 USB: ARM to USB register error issue

2013-12-05 Thread Peter Chen
On Sat, Nov 30, 2013 at 02:34:36PM +0100, Marc Kleine-Budde wrote: On 11/26/2013 01:11 PM, Peter Chen wrote: Changes for v6: - Add volatile for arm swp instruction, since we need io access to fix this problem - Add kernel style comment for imx28_write_fix Peter Chen (3): usb:

Re: [PATCH 2/3 v5] Fix Internal error: : 808 [#1] ARM related to STS flag

2013-12-05 Thread Peter Chen
On Wed, Dec 04, 2013 at 09:56:18AM +0800, Chris Ruehl wrote: Fix Internal error: : 808 [#1] ARM related to STS flag * init the sts flag to 0 (missed) * fix write the real bit not sts value * Set PORTCS_STS and DEVLC_STS only if sts = 1 (prefered solution by Mr. Peter Chen, Maintainer of

RE: [PATCH 3/3 v5] usb: chipidea: put hw_phymode_configure before ci_usb_phy_init

2013-12-05 Thread Peter Chen
usb: chipidea: put hw_phymode_configure before ci_usb_phy_init hw_phymode_configure configures the PORTSC registers and allow the following phy_inits to operate on the right parameters. This fix a problem where the UPLI (ISP1504) could not be detected, because the Viewport was not