Re: [PATCH v3 2/2] usb: phy: Add keystone usb phy driver

2013-12-09 Thread Felipe Balbi
Hi again, On Mon, Dec 09, 2013 at 05:17:04PM -0500, WingMan Kwok wrote: +static int keystone_usbphy_init(struct usb_phy *phy) +{ + struct keystone_usbphy *k_phy = dev_get_drvdata(phy-dev); + u32 val; + + val = keystone_usbphy_readl(k_phy-phy_ctrl, USB_PHY_CTL_CLOCK); +

Re: [PATCH] USB: storage: fix compile warning

2013-12-09 Thread Greg Kroah-Hartman
On Tue, Dec 10, 2013 at 12:37:24PM +0800, Ming Lei wrote: This patch should fix the below compile warning: drivers/usb/storage/protocol.c: In function 'usb_stor_access_xfer_buf': drivers/usb/storage/protocol.c:155:22: warning: comparison of distinct pointer types lacks a cast [enabled by

Re: [PATCH] usb: fix build error when USB=m USB_OTG=y

2013-12-09 Thread Greg KH
On Mon, Dec 09, 2013 at 03:41:41PM -0600, Felipe Balbi wrote: when any driver using usb_bus_start_enum() is enabled in a build with CONFIG_USB=m, we will have a build error because of usb_bus_start_enum() will be compiled into a module (usbcore) and the driver (phy-fsm-usb.c or

Re: [PATCH] USB: storage: fix compile warning

2013-12-09 Thread Ming Lei
On Tue, Dec 10, 2013 at 1:05 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Tue, Dec 10, 2013 at 12:37:24PM +0800, Ming Lei wrote: This patch should fix the below compile warning: drivers/usb/storage/protocol.c: In function 'usb_stor_access_xfer_buf':

Re: [PATCH] usb-storage: scsiglue: Changing the command result

2013-12-09 Thread Vishal Annapurve
Hi Greg, Does this look fine? I will send over other patches once you confirm. Patch set 1: - [PATCH 1/3] usb: storage: Proper cmd result assignment This change replaces DID_ABORT with DID_TIMEOUT as a command result whenever US_FLIDX_TIMED_OUT bit is set. This change is made to bring

Re: [PATCH] USB: core: Add warm reset while reset-resuming SuperSpeed HUBs

2013-12-09 Thread Vikas Sajjan
Hi Sarah, On Mon, Dec 9, 2013 at 11:54 PM, Sarah Sharp sarah.a.sh...@linux.intel.com wrote: On Mon, Dec 09, 2013 at 10:24:52AM -0500, Alan Stern wrote: On Mon, 9 Dec 2013, Vikas Sajjan wrote: Does warm reset while activating SuperSpeed HUBs if the hub activate type is HUB_RESET_RESUME.

Re: [PATCH] USB: core: Add warm reset while reset-resuming SuperSpeed HUBs

2013-12-09 Thread Vikas Sajjan
Hi Alan, On Mon, Dec 9, 2013 at 8:54 PM, Alan Stern st...@rowland.harvard.edu wrote: On Mon, 9 Dec 2013, Vikas Sajjan wrote: Does warm reset while activating SuperSpeed HUBs if the hub activate type is HUB_RESET_RESUME. When we do Suspend-to-RAM with (any one of the 16, 32, 64 Jetflash)

Re: [PATCH] USB: storage: fix compile warning

2013-12-09 Thread Greg Kroah-Hartman
On Tue, Dec 10, 2013 at 01:18:48PM +0800, Ming Lei wrote: On Tue, Dec 10, 2013 at 1:05 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Tue, Dec 10, 2013 at 12:37:24PM +0800, Ming Lei wrote: This patch should fix the below compile warning: drivers/usb/storage/protocol.c: In

Re: [PATCH] usb-storage: scsiglue: Changing the command result

2013-12-09 Thread Greg KH
On Tue, Dec 10, 2013 at 10:53:59AM +0530, Vishal Annapurve wrote: Hi Greg, Does this look fine? I will send over other patches once you confirm. I'm not going to confirm a broken format... Please go read the file I pointed you at as to how to properly do this. greg k-h -- To unsubscribe

Re: [PATCH] gadget: make USB_CONFIGFS_MASS_STORAGE depend on BLOCK

2013-12-09 Thread Andrzej Pietrasiewicz
W dniu 09.12.2013 20:18, Randy Dunlap pisze: From: Randy Dunlap rdun...@infradead.org Make USB_CONFIGFS_MASS_STORAGE depend on BLOCK just like the other gadget MASS_STORAGE options do. This fixes the following build errors that occur when BLOCK is not enabled: Already submitted

Re: [PATCH] net: sk == 0xffffffff fix - not for commit

2013-12-09 Thread Andrzej Pietrasiewicz
W dniu 09.12.2013 16:31, Eric Dumazet pisze: On Mon, 2013-12-09 at 12:47 +0100, Andrzej Pietrasiewicz wrote: NOT FOR COMMITTING TO MAINLINE. With g_ether loaded the sk occasionally becomes 0x. It happens usually after transferring few hundreds of kilobytes to few tens of megabytes. If

[PATCH v1] USB: storage: fix compile warning

2013-12-09 Thread Ming Lei
This patch should fix the below compile warning: drivers/usb/storage/protocol.c: In function 'usb_stor_access_xfer_buf': drivers/usb/storage/protocol.c:155:22: warning: comparison of distinct pointer types lacks a cast [enabled by default] Reported-by: kbuild test robot fengguang...@intel.com

<    1   2