[PATCH 1/1] usb: phy-generic: add the implementation of .set_suspend

2013-12-26 Thread Peter Chen
Add clock enable/disable at .set_suspend if the PHY has suspend requirement, it can be benefit of power saving for phy and the whole system (parent clock may also be disabled). Signed-off-by: Peter Chen --- drivers/usb/phy/phy-generic.c | 10 ++ 1 files changed, 10 insertions(+), 0 del

RE: [PATCH] usb/core: fix NULL pointer dereference in recursively_mark_NOTATTACHED

2013-12-26 Thread Du, ChangbinX
> > On Tue, 24 Dec 2013, Alan Stern wrote: > > I think this will fix it. Take a close look and do some careful testing. > > > > Alan Stern > > > > Index: usb-3.13/drivers/usb/core/hub.c > > > == > > --- usb-3.13.orig/drivers/usb/core/hub.c >

Re: [PATCH v5 4/9] usb: ehci-s5p: Change to use phy provided by the generic phy framework

2013-12-26 Thread Vivek Gautam
Hi Kamil, On Fri, Dec 20, 2013 at 6:54 PM, Kamil Debski wrote: > Change the phy provider used from the old one using the USB phy > framework to a new one using the Generic phy framework. > > Signed-off-by: Kamil Debski > Signed-off-by: Kyungmin Park Commit title: s/ehci-s5p/ehci-exynos > ---

Re: [PATCH v2 9/9] dts: Add usb2phy to Exynos 5250

2013-12-26 Thread Vivek Gautam
Hi Kamil, On Fri, Dec 20, 2013 at 6:54 PM, Kamil Debski wrote: > Add support to PHY of USB2 of the Exynos 5250 SoC. > > Signed-off-by: Kamil Debski > --- > arch/arm/boot/dts/exynos5250.dtsi | 33 --- > drivers/phy/phy-exynos5250-usb2.c | 64 > ++

[PATCH 2/2] usb: musb: Rework USB and USB_GADGET dependency

2013-12-26 Thread Ezequiel Garcia
This USB controller can work in as host-only, gadget-only or dual-role modes. Rework the dependency on the USB and USB_GADGET configs in order to allow building the driver when !USB or !USG_GADGET. Signed-off-by: Ezequiel Garcia --- This is just a resend of a recently sent, standalone patch. dr

[PATCH 0/2] musb: Rework USB and USB_GADGET config

2013-12-26 Thread Ezequiel Garcia
I'm resending this configuration rework to include one more patch in the series, prior to the config change. The first patch removes the usb_disable() usage, allowing the build the module for gadget-only mode usage. Without the first patch, the build breaks when building for !USB && USB_GADGET. Ho

[PATCH 1/2] usb: musb: Remove usb_disable() check in module_init()

2013-12-26 Thread Ezequiel Garcia
Removing the check to usb_disable() before registering the platform driver allows to build this driver when !USB && USB_GADGET, to be used in gadget-only mode. Also, use module_platform_driver() to register the platform driver. Signed-off-by: Ezequiel Garcia --- drivers/usb/musb/musb_core.c | 1

Re: [PATCH 2/2] usb: musb: Rework USB and USB_GADGET dependency

2013-12-26 Thread Sergei Shtylyov
Hello. On 26-12-2013 16:24, Ezequiel Garcia wrote: This USB controller can work in as host-only, gadget-only or dual-role modes. Rework the dependency on the USB and USB_GADGET configs in order to allow building the driver when !USB or !USG_GADGET. Signed-off-by: Ezequiel Garcia [...] di

Re: [PATCH 1/1] usb: phy-generic: add the implementation of .set_suspend

2013-12-26 Thread Felipe Balbi
On Thu, Dec 26, 2013 at 03:36:03PM +0800, Peter Chen wrote: > Add clock enable/disable at .set_suspend if the PHY has > suspend requirement, it can be benefit of power saving for > phy and the whole system (parent clock may also be disabled). > > Signed-off-by: Peter Chen > --- > drivers/usb/phy

Re: [PATCH v8 11/12] usb: phy-mxs: Add system suspend/resume API

2013-12-26 Thread Felipe Balbi
Hi, On Tue, Dec 24, 2013 at 11:58:55AM +0800, Peter Chen wrote: > @@ -398,6 +433,29 @@ static int mxs_phy_remove(struct platform_device *pdev) > return 0; > } > > +static int mxs_phy_system_suspend(struct device *dev) > +{ > + struct mxs_phy *mxs_phy = dev_get_drvdata(dev); > + > +

[ANNOUNCE] Tree closed for v3.14

2013-12-26 Thread Felipe Balbi
Hi all, my tree is now closed for v3.14 merge window. I'm testing a few last patches then I'll merge everything on top of my 'next' branch and will send a pull request to Greg by the end of the week. I believe all major sparse errors have already been fixed. We have a total of 105 non-merge comm

RE: [PATCH] usb/core: fix NULL pointer dereference in recursively_mark_NOTATTACHED

2013-12-26 Thread Alan Stern
On Thu, 26 Dec 2013, Du, ChangbinX wrote: > I can reproduce issue by adding a delay just after usb_set_intfdata(intf, > NULL) > (echo -1 > bConfigurationValue to trigger hub_dissconnect())without your > patch. > > After patch applied, cannot reproduce and didn't found any other issue. Patch >

[GIT PULL] usb patches for v3.14 merge window

2013-12-26 Thread Felipe Balbi
Hi Greg, Here's my overly extensive pull request for v3.14 merge window. Lots of work has happened for next merge window. All patches have been tested with all ARM defconfigs, i386_defconfig, kvm_guest.config, x86_64_defconfig, plus quite a few randconfigs. All latest 0-DAY reports have been fix

[PATCH v2] usb: musb: Rework USB and USB_GADGET dependency

2013-12-26 Thread Ezequiel Garcia
This USB controller can work in as host-only, gadget-only or dual-role modes. Rework the dependency on the USB and USB_GADGET configs in order to allow building the driver when !USB or !USG_GADGET. Signed-off-by: Ezequiel Garcia --- Changes from v1: Remove unneeded parenthesis drivers/usb/Kconf

Re: [PATCH v4 00/15] usb: phy: msm: Fixes, cleanups and DT support

2013-12-26 Thread Stephen Boyd
On 12/20, David Brown wrote: > On Thu, Dec 19, 2013 at 05:26:13PM -0600, Felipe Balbi wrote: > > >it's getting quite late for me. I still want to leave my stuff soaking > >in linux-next for a while. I'll try my best, though, if you ack it ASAP > > Thanks. Patch 1 already has my Ack in it, and I'

Re: [PATCH 1/1] usb: phy-generic: add the implementation of .set_suspend

2013-12-26 Thread Peter Chen
On Thu, Dec 26, 2013 at 09:58:01AM -0600, Felipe Balbi wrote: > On Thu, Dec 26, 2013 at 03:36:03PM +0800, Peter Chen wrote: > > Add clock enable/disable at .set_suspend if the PHY has > > suspend requirement, it can be benefit of power saving for > > phy and the whole system (parent clock may also

Re: [PATCH v8 11/12] usb: phy-mxs: Add system suspend/resume API

2013-12-26 Thread Peter Chen
On Thu, Dec 26, 2013 at 10:25:20AM -0600, Felipe Balbi wrote: > Hi, > > On Tue, Dec 24, 2013 at 11:58:55AM +0800, Peter Chen wrote: > > @@ -398,6 +433,29 @@ static int mxs_phy_remove(struct platform_device *pdev) > > return 0; > > } > > > > +static int mxs_phy_system_suspend(struct device *

Re: [PATCH 1/1] usb: phy-generic: add the implementation of .set_suspend

2013-12-26 Thread Felipe Balbi
Hi, On Fri, Dec 27, 2013 at 09:40:24AM +0800, Peter Chen wrote: > On Thu, Dec 26, 2013 at 09:58:01AM -0600, Felipe Balbi wrote: > > On Thu, Dec 26, 2013 at 03:36:03PM +0800, Peter Chen wrote: > > > Add clock enable/disable at .set_suspend if the PHY has > > > suspend requirement, it can be benefit

[PATCH net-next 0/6] Support new chip

2013-12-26 Thread Hayes Wang
Adjust the code to make it easy to add the settings for the new chip. Then, add the relative parameters of the RTL8153. Hayes Wang (6): r8152: move rtl8152_unload and ocp_reg_write r8152: modify the method of accessing PHY r8152: change some definitions r8152: add rtl_ops r8152: split rt

[PATCH net-next 1/6] r8152: move rtl8152_unload and ocp_reg_write

2013-12-26 Thread Hayes Wang
Change the locations of rtl8152_unload() and ocp_reg_write(). Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 58 - 1 file changed, 29 insertions(+), 29 deletions(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index 5107

[PATCH net-next 6/6] r8152: support RTL8153

2013-12-26 Thread Hayes Wang
Support new chip RTL8153 which is the USB 3.0 giga ethernet adapter. Signed-off-by: Hayes Wang --- drivers/net/usb/cdc_ether.c | 10 + drivers/net/usb/r8152.c | 615 +++- drivers/net/usb/r815x.c | 2 +- 3 files changed, 621 insertions(+), 6 dele

[PATCH net-next 4/6] r8152: add rtl_ops

2013-12-26 Thread Hayes Wang
The different chips may have different settings. This makes it easy to let different chips have the same flow with differnt settings. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 56 ++--- 1 file changed, 49 insertions(+), 7 deletions(-) di

[PATCH net-next 5/6] r8152: split rtl8152_enable

2013-12-26 Thread Hayes Wang
Split the contents of rtl8152_enable() into rtl_set_eee_plus() and rtl_enable(). Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index 040ef73..537

[PATCH net-next 3/6] r8152: change some definitions

2013-12-26 Thread Hayes Wang
Replace RX_BUF_THR with RX_THR_HIGH. Replace RWSUME_INDICATE with RESUME_INDICATE. Add CRC_SIZE, TX_ALIGN, and RX_ALIGN. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 27 --- 1 file changed, 16 insertions(+), 11 deletions(-) diff --git a/drivers/net/usb/r8152.c

[PATCH net-next 2/6] r8152: modify the method of accessing PHY

2013-12-26 Thread Hayes Wang
The old method to access PHY is through mdio channel. Replace it with the OCP channel. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 52 + 1 file changed, 18 insertions(+), 34 deletions(-) diff --git a/drivers/net/usb/r8152.c b/drivers/n

Re: [PATCH 1/1] usb: phy-generic: add the implementation of .set_suspend

2013-12-26 Thread Peter Chen
On Thu, Dec 26, 2013 at 08:25:29PM -0600, Felipe Balbi wrote: > Hi, > > On Fri, Dec 27, 2013 at 09:40:24AM +0800, Peter Chen wrote: > > On Thu, Dec 26, 2013 at 09:58:01AM -0600, Felipe Balbi wrote: > > > On Thu, Dec 26, 2013 at 03:36:03PM +0800, Peter Chen wrote: > > > > Add clock enable/disable a

[PATCH v9 03/12] usb: phy-mxs: Add auto clock and power setting

2013-12-26 Thread Peter Chen
The auto setting is used to open related power and clocks automatically after receiving wakeup signal. With this feature, the PHY's clock and power can be recovered correctly from low power mode, it is guaranteed by IC logic. Signed-off-by: Peter Chen --- drivers/usb/phy/phy-mxs-usb.c | 20 ++

[PATCH v9 00/12] Add power management support for mxs phy

2013-12-26 Thread Peter Chen
Hi Felipe & Shawn, The serial adds power management support for MXS PHY, it includes: - Add one PHY API .set_wakeup, and related API implementation at mxs phy driver - misc changes and bug fixes for mxs phy to support low power mode and wakeup. It is based on the lastest Greg's usb-next, 3.13-rc

[PATCH v9 02/12] usb: phy-mxs: Add platform judgement code

2013-12-26 Thread Peter Chen
The mxs-phy has several bugs and features at different versions, the driver code can get it through of_device_id.data. Signed-off-by: Peter Chen --- drivers/usb/phy/phy-mxs-usb.c | 58 ++-- 1 files changed, 49 insertions(+), 9 deletions(-) diff --git a/driv

[PATCH v9 05/12] usb: phy-mxs: Add anatop regmap

2013-12-26 Thread Peter Chen
It is needed by imx6 SoC series, but not for imx23 and imx28. Signed-off-by: Peter Chen --- drivers/usb/phy/phy-mxs-usb.c | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/drivers/usb/phy/phy-mxs-usb.c b/drivers/usb/phy/phy-mxs-usb.c index 0c6f3bc..12671c5 1

[PATCH v9 12/12] usb: phy-mxs: Add sync time after controller clear phcd

2013-12-26 Thread Peter Chen
After clear portsc.phcd, PHY needs 200us stable time for switch 32K clock to AHB clock. Signed-off-by: Peter Chen --- drivers/usb/phy/phy-mxs-usb.c | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/drivers/usb/phy/phy-mxs-usb.c b/drivers/usb/phy/phy-mxs-usb.c in

[PATCH v9 01/12] usb: doc: phy-mxs: Add more compatible strings

2013-12-26 Thread Peter Chen
Add "fsl,imx6q-usbphy" for imx6dq and imx6dl, add "fsl,imx6sl-usbphy" for imx6sl. Signed-off-by: Peter Chen --- Documentation/devicetree/bindings/usb/mxs-phy.txt |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/Documentation/devicetree/bindings/usb/mxs-phy.txt b/Docume

[PATCH v9 04/12] usb: doc: phy-mxs: update binding for adding anatop phandle

2013-12-26 Thread Peter Chen
Add anatop phandle which is used to access anatop registers to control PHY's power and other USB operations. Signed-off-by: Peter Chen --- Documentation/devicetree/bindings/usb/mxs-phy.txt |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/Documentation/devicetree/bindings

[PATCH v9 11/12] usb: phy-mxs: Add system suspend/resume API

2013-12-26 Thread Peter Chen
We need this to keep PHY's power on or off during the system suspend mode. If we need to enable USB wakeup, then we must keep PHY's power being on during the system suspend mode. Otherwise, we need to keep PHY's power being off to save power. Signed-off-by: Peter Chen --- drivers/usb/phy/phy-mxs

[PATCH v9 06/12] usb: phy-mxs: change description of usb device speed

2013-12-26 Thread Peter Chen
Change "high speed" to "HS" Change "non-high speed" to "FS/LS" Implementation of notify_suspend and notify_resume will be different according to mxs_phy_data->flags. Signed-off-by: Peter Chen --- drivers/usb/phy/phy-mxs-usb.c |8 1 files changed, 4 insertions(+), 4 deletions(-) di

[PATCH v9 10/12] usb: phy-mxs: Add implementation of set_wakeup

2013-12-26 Thread Peter Chen
When we need the PHY can be waken up by external signals, we can call this API. Besides, we call mxs_phy_disconnect_line at this API to close the connection between USB PHY and controller, after that, the line state from controller is SE0. Once the PHY is out of power, without calling mxs_phy_disco

[PATCH v9 09/12] usb: phy: Add set_wakeup API

2013-12-26 Thread Peter Chen
This API is used to set wakeup enable at PHY registers, in that case, the PHY can be waken up from suspend due to external events, like vbus change, dp/dm change and id change. Signed-off-by: Peter Chen --- include/linux/usb/phy.h | 16 1 files changed, 16 insertions(+), 0 del

[PATCH v9 08/12] usb: phy-mxs: add controller id

2013-12-26 Thread Peter Chen
It is used to access un-regulator registers according to different controllers. Signed-off-by: Peter Chen --- drivers/usb/phy/phy-mxs-usb.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/drivers/usb/phy/phy-mxs-usb.c b/drivers/usb/phy/phy-mxs-usb.c index bf22970..c

[PATCH v9 07/12] usb: phy-mxs: Enable IC fixes for related SoCs

2013-12-26 Thread Peter Chen
Two PHY bugs are fixed by IC logic, but these bits are not enabled by default, so we enable them at driver. The two bugs are: MXS_PHY_ABNORMAL_IN_SUSPEND and MXS_PHY_SENDING_SOF_TOO_FAST which are described at code. Signed-off-by: Peter Chen --- drivers/usb/phy/phy-mxs-usb.c | 23 +

Re: [PATCH 0/7] Chipidea Fix for 3.13-rc2

2013-12-26 Thread Peter Chen
On Thu, Dec 05, 2013 at 03:20:48PM +0800, Peter Chen wrote: > Hi Greg, > > This patchset includes chipidea fixes for 3.13-rc2, the mainly > fixes include add correct imx28 write register method, fixing > un-initialized variable, etc. > > Chris Ruehl (2): > usb: chipidea: Fix Internal error: : 8