Re: [PATCH] phy-rcar-usb-gen2: add device tree support

2014-01-28 Thread Simon Horman
On Mon, Jan 27, 2014 at 07:06:26PM +, Ben Dooks wrote: > On 27/01/14 18:23, Sergei Shtylyov wrote: > >Hello. > > > >On 01/26/2014 08:05 PM, Ben Dooks wrote: > > [snip] > > >> > >>+static struct of_device_id rcar_gen2_usb_phy_ofmatch[] = { > >>+{ .compatible = "renesas,usb-phy-r8a7790", },

Re: Help testing for USB ethernet/xHCI regression

2014-01-28 Thread renevant
just to add I have a vantec 2 bay usb 3.0 disk dock that has appeared to always work fine connected to the asmedia 1042 with version 3.13 and with 3.14 (with the writeq reversion and transciever fix) On Wednesday 29 January 2014 16:21:00 you wrote: > Hello, > > I am someone who has been struggl

Re: Help testing for USB ethernet/xHCI regression

2014-01-28 Thread renevant
Hello, I am someone who has been struggling to get an ax88179 net adapter working reliably. I have an integrated Asmedia 1042 xhci controller that is reportedly version 0.96 on an ASUS M5A99FX PRO R2.0, BIOS 2201 motherboard based on the AMD 990FX chipset. The big issue I am currently facing

Re: Help testing for USB ethernet/xHCI regression

2014-01-28 Thread Mark Lord
On 14-01-28 11:30 PM, Mark Lord wrote: > On 14-01-28 03:30 PM, Sarah Sharp wrote: > .. >> Can you please pull this branch, which contains a 3.13 kernel with >> David's patch reverted, and test whether your USB ethernet device works >> or fails? > > Fails. dmesg log attached. > All I do is somethi

Re: Help testing for USB ethernet/xHCI regression

2014-01-28 Thread Mark Lord
On 14-01-28 03:30 PM, Sarah Sharp wrote: .. > Can you please pull this branch, which contains a 3.13 kernel with > David's patch reverted, and test whether your USB ethernet device works > or fails? Fails. dmesg log attached. All I do is something akin to this: mount /server/ /x mount --bi

Re: [PATCH] xhci: Limit TD fragments to 1.0 xHCI hosts only.

2014-01-28 Thread walt
On 01/27/2014 03:49 PM, Sarah Sharp wrote: > Walt reports that the PCI add-in card for his 0.96 ASMedia host dies in > a particular machine. This symptom goes away when commit > 35773dac5f862cb1c82ea151eba3e2f6de51ec3e "usb: xhci: Link TRB must not > occur within a USB payload burst" is reverted.

Re: [PATCH v3] usb: core: Fix potential memory leak adding dyn USBdevice IDs

2014-01-28 Thread Wolfram Sang
On Tue, Jan 28, 2014 at 10:22:27PM +0100, Christian Engelmayer wrote: > Fix a memory leak in the usb_store_new_id() error paths. When bailing out > due to sanity checks, the function left the already allocated usb_dynid > struct in place. This regression was introduced by the following commits: >

[PATCH v3] usb: core: Fix potential memory leak adding dyn USBdevice IDs

2014-01-28 Thread Christian Engelmayer
Fix a memory leak in the usb_store_new_id() error paths. When bailing out due to sanity checks, the function left the already allocated usb_dynid struct in place. This regression was introduced by the following commits: c63fe8f6 (usb: core: add sanity checks when using bInterfaceClass with new_id)

Help testing for USB ethernet/xHCI regression

2014-01-28 Thread Sarah Sharp
Hi Mark, You reported that you had an issue with a USB ethernet device on 3.12, and that updating to 3.13-rc4 (which included commit 587194873820 "xhci: convert TRB_CYCLE to le32 before using it to set Link TRB's cycle bit") fixed the issue for you. Later you said applying that patch on top of 3.

[PATCH 1/1] usbip/userspace/libsrc/names.c: memory leak

2014-01-28 Thread xypron . glpk
From: Heinrich Schuchardt revised patch p is freed if NULL. p is leaked if second calloc fails. Signed-off-by: Heinrich Schuchardt --- drivers/staging/usbip/userspace/libsrc/names.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/usbip/userspace/

Re: [PATCH] tools: usb: aio example applications

2014-01-28 Thread Peter Stuge
Nice to have a complete kernel+userspace example. Thanks! Robert Baldyga wrote: > +++ b/tools/usb/aio_multibuff/host_app/test.c > @@ -0,0 +1,122 @@ > +#include Please don't do this. Please always #include and call some combination of: pkg-config --cflags libusb-1.0 pkg-config --libs libusb-1

Re: [PATCH 1/1] usb: chipidea: udc: refine ep operation at isr_tr_complete_handler

2014-01-28 Thread Michael Grzeschik
On Mon, Jan 27, 2014 at 08:58:15AM +0800, Peter Chen wrote: > - delete the warning message at interrupt handler, and adds judgement at > ep_enable, if non-ep0 requests ctrl transfer, it will indicate an error. > - delete hw_test_and_clear_setup_status which is a broken code > - Tested with g_mass_s

Re: [PATCH] tools: usb: aio example applications

2014-01-28 Thread Michal Nazarewicz
On Tue, Jan 28 2014, David Laight wrote: > I was thinking of the bits that are K&R C. > Like: > int foo() { For that I think the code should stick to Linux style guide (even though in this particular instance, I do not agree with it). -- Best regards, _

Re: [PATCH v2 1/1] USB: EHCI: wait more than 3ms until the device enters full-speed idle

2014-01-28 Thread Alan Stern
On Tue, 28 Jan 2014, Peter Chen wrote: > > It sounds like this is a bug in your EHCI hardware. The > > wake-on-disconnect logic should never take effect until after the port > > goes into full-speed idle. > > Where EHCI spec said that? I can't find it at 2.3.9 and 4.3. It doesn't say that. Not

Re: [PATCH 1/2] usb: dwc3: core: continue probing if usb phy library returns -ENODEV/-ENXIO

2014-01-28 Thread Felipe Balbi
Hi, On Tue, Jan 28, 2014 at 05:32:30PM +0200, Heikki Krogerus wrote: > On Mon, Jan 27, 2014 at 10:05:20AM -0600, Felipe Balbi wrote: > > > Why would you need to know if the PHY drivers are needed or not > > > explicitly in your controller driver? > > > > because, one way or another, they all do n

Re: [PATCH 1/2] usb: dwc3: core: continue probing if usb phy library returns -ENODEV/-ENXIO

2014-01-28 Thread Heikki Krogerus
Hi, On Mon, Jan 27, 2014 at 10:05:20AM -0600, Felipe Balbi wrote: > > Why would you need to know if the PHY drivers are needed or not > > explicitly in your controller driver? > > because, one way or another, they all do need it. Except for quirky ones > like AM437x where a USB3 IP was hardwired

[PATCH] usb: chipidea: udc: add maximum-speed = full-speed option

2014-01-28 Thread Michael Grzeschik
This patch makes it possible to set the chipidea udc into full-speed only mode. It is set by the oftree property "maximum-speed = full-speed". Signed-off-by: Michael Grzeschik Signed-off-by: Marc Kleine-Budde --- Documentation/devicetree/bindings/usb/ci-hdrc-imx.txt | 2 ++ drivers/usb/chipide

Re: [PATCH] HID: usbhid: quirk for CY-TM75 75 inch Touch Overlay

2014-01-28 Thread Jiri Kosina
On Mon, 27 Jan 2014, Benjamin Tissoires wrote: > > There is timeout error during initialization: > > kernel: [ 11.733104] hid-multitouch 0003:1870:0110.0001: > > usb_submit_urb(ctrl) failed: -1 > > kernel: [ 11.734093] hid-multitouch 0003:1870:0110.0001: timeout > > initializing reports > >

Re: [PATCH] HID: usbhid: quirk for CY-TM75 75 inch Touch Overlay

2014-01-28 Thread Jiri Kosina
On Mon, 27 Jan 2014, Yufeng Shen wrote: > There is timeout error during initialization: > kernel: [ 11.733104] hid-multitouch 0003:1870:0110.0001: > usb_submit_urb(ctrl) failed: -1 > kernel: [ 11.734093] hid-multitouch 0003:1870:0110.0001: timeout > initializing reports > > Adding quirk HID

RE: [PATCH] tools: usb: aio example applications

2014-01-28 Thread David Laight
From: Michal Nazarewicz > On Tue, Jan 28 2014, David Laight wrote: > > From: Robert Baldyga > >> This patch adds two example applications showing usage of Asynchronous I/O > >> API > >> of FunctionFS. First one (aio_simple) is simple example of bidirectional > >> data > >> transfer. Second one (

[PATCH v3] usb: phy: move some error messages to debug

2014-01-28 Thread Josh Boyer
the PHY layer is supposed to be optional, considering some PHY have no control bus for SW to poke around. After commit 1ae5799 (usb: hcd: Initialize USB phy if needed) any HCD which didn't provide a PHY driver would emit annoying error messages. In this patch we're decreasing those messages to de

Re: [PATCH] tools: usb: aio example applications

2014-01-28 Thread Michal Nazarewicz
On Tue, Jan 28 2014, Robert Baldyga wrote: > diff --git a/tools/usb/aio_multibuff/device_app/aio_multibuff.c > b/tools/usb/aio_multibuff/device_app/aio_multibuff.c > new file mode 100644 > index 000..df1db84 > --- /dev/null > +++ b/tools/usb/aio_multibuff/device_app/aio_multibuff.c > +#define

Re: [PATCH] tools: usb: aio example applications

2014-01-28 Thread Michal Nazarewicz
On Tue, Jan 28 2014, David Laight wrote: > From: Robert Baldyga >> This patch adds two example applications showing usage of Asynchronous I/O >> API >> of FunctionFS. First one (aio_simple) is simple example of bidirectional data >> transfer. Second one (aio_multibuff) shows multi-buffer data tra

RE: [PATCH] tools: usb: aio example applications

2014-01-28 Thread David Laight
From: Robert Baldyga > This patch adds two example applications showing usage of Asynchronous I/O API > of FunctionFS. First one (aio_simple) is simple example of bidirectional data > transfer. Second one (aio_multibuff) shows multi-buffer data transfer, which > may to be used in high performance a

[PATCH] tools: usb: aio example applications

2014-01-28 Thread Robert Baldyga
This patch adds two example applications showing usage of Asynchronous I/O API of FunctionFS. First one (aio_simple) is simple example of bidirectional data transfer. Second one (aio_multibuff) shows multi-buffer data transfer, which may to be used in high performance applications. Both examples c

Re: [PATCH] USB2NET : SR9800 : One chip USB2.0 USB2NET SR9800 Device Driver Support

2014-01-28 Thread Joe Perches
On Tue, 2014-01-28 at 16:36 +0800, liujunliang_...@163.com wrote: > From: Liu Junliang trivial comments... > diff --git a/drivers/net/usb/sr9800.c b/drivers/net/usb/sr9800.c [] > +static int sr_rx_fixup(struct usbnet *dev, struct sk_buff *skb) > +{ [] > + if (size != ((~header >> 1

[PATCH] USB2NET : SR9800 : One chip USB2.0 USB2NET SR9800 Device Driver Support

2014-01-28 Thread liujunliang_ljl
From: Liu Junliang Signed-off-by: Liu Junliang --- drivers/net/usb/Kconfig | 16 + drivers/net/usb/Makefile |1 + drivers/net/usb/sr9800.c | 874 ++ drivers/net/usb/sr9800.h | 202 +++ 4 files changed, 1093 insertions(+) create mode

[PATCH v4 2/5] usb: gadget: functionfs: replace FFS_SETUP_STATUS with an inline function

2014-01-28 Thread Robert Baldyga
From: Michal Nazarewicz The FFS_SETUP_STATUS macro could be trivialy replaced with an static inline function but more importantly its name was tad confusing. The name suggested it was a simple accessor macro but it actually did change the state of the ffs_data structure perfomring a FFS_SETUP_CAN

[PATCH v4 0/5] usb: gadget: f_fs: add asynchronous I/O support

2014-01-28 Thread Robert Baldyga
Hello, This is fourth version of patches containing improvements for FunctionFS which allows to use it with asynchronous I/O interface. It also adds poll function for ep0, to make it usable without creating additional thread, needed by blocking I/O. >From last version I have fixed few nit's, and

[PATCH v4 1/5] usb: gadget: functionfs: fix typo in the enum variable

2014-01-28 Thread Robert Baldyga
From: Michal Nazarewicz Since “cancelled” is spelled with two “l”s, rename FFS_SETUP_CANCELED to FFS_SETUP_CANCELLED. Signed-off-by: Michal Nazarewicz Signed-off-by: Robert Baldyga --- drivers/usb/gadget/f_fs.c | 16 drivers/usb/gadget/u_fs.h | 12 ++-- 2 files ch

[PATCH v4 5/5] usb: gadget: f_fs: add aio support

2014-01-28 Thread Robert Baldyga
This patch adds asynchronous I/O support for FunctionFS endpoint files. It adds ffs_epfile_aio_write() and ffs_epfile_aio_read() functions responsible for preparing AIO operations. It also modifies ffs_epfile_io() function, adding aio handling code. Instead of extending list of parameters of this

[PATCH v4 3/5] usb: gadget: f_fs: fix setup request handling

2014-01-28 Thread Robert Baldyga
This patch fixes __ffs_ep0_queue_wait() function, which now returns number of bytes transferred in USB request or error code in case of failure. This is needed by ffs_ep0_read() function, when read data is copied to userspace. It also cleans up code by removing usused variable ep0req_status. Sign

[PATCH v4 4/5] usb: gadget: f_fs: add poll for endpoint 0

2014-01-28 Thread Robert Baldyga
This patch adds poll function for file representing ep0. Ability of read from or write to ep0 file is related with actual state of ffs: - When desctiptors or strings are not written yet, POLLOUT flag is set. - If there is any event to read, POLLIN flag is set. - If setup request was read, POLLIN a