Re: [PATCH V4 1/5] phy: Add new Exynos5 USB 3.0 PHY driver

2014-04-14 Thread Vivek Gautam
Hi Tomasz, On Thu, Apr 10, 2014 at 5:09 PM, Vivek Gautam wrote: > On Wed, Apr 9, 2014 at 7:03 PM, Tomasz Figa wrote: >> On 09.04.2014 13:49, Vivek Gautam wrote: >>> >>> Hi, >>> >>> >>> On Wed, Apr 9, 2014 at 4:36 PM, Tomasz Figa wrote: Hi Vivek, Please see my comments inlin

[PATCH] usb: phy: return an error in usb_get_phy() if try_module_get() fails

2014-04-14 Thread Mathias Krause
In case we found a matching USB PHY in usb_get_phy() but the call to try_module_get() fails, we shouldn't return a (probably soon dangling) pointer but an ERR_PTR instead. Signed-off-by: Mathias Krause --- drivers/usb/phy/phy.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/us

Re: [PATCH V4 1/5] phy: Add new Exynos5 USB 3.0 PHY driver

2014-04-14 Thread Vivek Gautam
Hi, On Mon, Apr 14, 2014 at 8:07 PM, Sylwester Nawrocki wrote: > On 08/04/14 16:36, Vivek Gautam wrote: >> diff --git a/Documentation/devicetree/bindings/phy/samsung-phy.txt >> b/Documentation/devicetree/bindings/phy/samsung-phy.txt >> index 28f9edb..6d99ba9 100644 >> --- a/Documentation/device

Re: [PATCH V4 1/5] phy: Add new Exynos5 USB 3.0 PHY driver

2014-04-14 Thread Vivek Gautam
Hi Sylwester, On Mon, Apr 14, 2014 at 7:51 PM, Sylwester Nawrocki wrote: > On 14/04/14 15:49, Vivek Gautam wrote: >> True, we don't have a scope of instantiating this driver using old >> platform device and >> old legacy board files. >> So we don't need this check then, right ? > > I think it ca

Re: [PATCH] USB: EHCI: tegra: set txfill_tuning

2014-04-14 Thread Alexandre Courbot
On Tue, Apr 15, 2014 at 6:21 AM, Stephen Warren wrote: > From: Stephen Warren > > To avoid memory fetch underflows with larger USB transfers, Tegra SoCs > need txfill_tuning's txfifothresh register field set to a non-default > value. Add a custom reset override in order to set this up. > > These

linux-usb@vger.kernel.org

2014-04-14 Thread Lars Melin
On 2014-04-14 23:26, Dan Williams wrote: Some of these devices look like Android hotspots or phones, given the "adb" blacklists in the patch, is that correct? But are any of them Qualcomm Gobi-based WWAN cards? Do you have Windows .INF files for any of these devices that we could look at to de

Re: [PATCH v10 00/11] Add USB OTG HNP and SRP support on Chipidea usb driver

2014-04-14 Thread Li Jun
On Mon, Apr 14, 2014 at 08:45:13PM +0800, Peter Chen wrote: > On Mon, Apr 14, 2014 at 10:22:32AM +0800, Li Jun wrote: > > On Mon, Apr 14, 2014 at 09:37:50AM +0800, Li Jun wrote: > > > From: Li Jun > > > > > > This patchset adds USB OTG HNP and SRP support on chipidea usb driver, > > > existing OT

Re:[PATCH v6 2/3] usb: dwc2/s3c-hsotg: move s3c-hsotg into dwc2 directory

2014-04-14 Thread Jingoo Han
On Tuesday, April 15, 2014 6:33 AM, Felipe Balbi wrote: > On Mon, Apr 14, 2014 at 02:13:34PM -0700, Paul Zimmerman wrote: > > From: Dinh Nguyen > > > > Moves the s3c-hsotg driver into the dwc2 directory and uses the > > dwc2 defines in hw.h. Renames s3c-hsotg.c to gadget.c. > > > > NOTE: You can b

Re: [PATCH v6 2/3] usb: dwc2/s3c-hsotg: move s3c-hsotg into dwc2 directory

2014-04-14 Thread Felipe Balbi
On Mon, Apr 14, 2014 at 09:42:24PM +, Paul Zimmerman wrote: > > From: Felipe Balbi [mailto:ba...@ti.com] > > Sent: Monday, April 14, 2014 2:33 PM > > > > On Mon, Apr 14, 2014 at 02:13:34PM -0700, Paul Zimmerman wrote: > > > From: Dinh Nguyen > > > > > > Moves the s3c-hsotg driver into the dwc

Re: Missing USB XHCI and EHCI reset for kexec

2014-04-14 Thread Thadeu Lima de Souza Cascardo
On Mon, Apr 14, 2014 at 05:44:58PM +0200, stef...@seibold.net wrote: > > Zitat von Benjamin Herrenschmidt : > > >On Sun, 2014-04-13 at 21:22 +0200, Stefani Seibold wrote: > >>When executing a kexec kernel on a PowerPC board the new started kernel > >>will not find already enumerated USB devices d

RE: [PATCH v6 2/3] usb: dwc2/s3c-hsotg: move s3c-hsotg into dwc2 directory

2014-04-14 Thread Paul Zimmerman
> From: Felipe Balbi [mailto:ba...@ti.com] > Sent: Monday, April 14, 2014 2:33 PM > > On Mon, Apr 14, 2014 at 02:13:34PM -0700, Paul Zimmerman wrote: > > From: Dinh Nguyen > > > > Moves the s3c-hsotg driver into the dwc2 directory and uses the > > dwc2 defines in hw.h. Renames s3c-hsotg.c to gadg

Re: [PATCH v6 2/3] usb: dwc2/s3c-hsotg: move s3c-hsotg into dwc2 directory

2014-04-14 Thread Felipe Balbi
On Mon, Apr 14, 2014 at 02:13:34PM -0700, Paul Zimmerman wrote: > From: Dinh Nguyen > > Moves the s3c-hsotg driver into the dwc2 directory and uses the > dwc2 defines in hw.h. Renames s3c-hsotg.c to gadget.c. > > NOTE: You can build both host and peripheral as a dynamically > linked module, but

[RESEND PATCHv5] usb: dwc2: Add function to calculate correct FIFO sizes

2014-04-14 Thread dinguyen
From: Dinh Nguyen The dwc2 IP on the SOCFPGA cannot use the default HW configured FIFO sizes. The total FIFO depth as read from GHWCFG3 reports 0x1f80 or 8064 32-bit words. But the GRXFSIZ, GNPTXFSIZ, and HPTXFSIZ register defaults to 0x2000 or 8192 32-bit words. So the driver cannot just use the

[PATCH] USB: EHCI: tegra: set txfill_tuning

2014-04-14 Thread Stephen Warren
From: Stephen Warren To avoid memory fetch underflows with larger USB transfers, Tegra SoCs need txfill_tuning's txfifothresh register field set to a non-default value. Add a custom reset override in order to set this up. These values are recommended practice for all Tegra chips. However, I've o

[PATCH v6 2/3] usb: dwc2/s3c-hsotg: move s3c-hsotg into dwc2 directory

2014-04-14 Thread Paul Zimmerman
From: Dinh Nguyen Moves the s3c-hsotg driver into the dwc2 directory and uses the dwc2 defines in hw.h. Renames s3c-hsotg.c to gadget.c. NOTE: You can build both host and peripheral as a dynamically linked module, but be aware that if you insmod dwc2_gadget, then rmmod it, then insmod dwc2 and d

[PATCH v6 0/3] usb: dwc2/s3c-hsotg: move s3c-hsotg driver into dwc2

2014-04-14 Thread Paul Zimmerman
Whoops, forgot to CC the linux-usb list. Sorry for sending this twice. From: Dinh Nguyen This is a shortened version of the patch to combine the dwc2/s3c-hsotg into a single dual-role driver. The series will only move the s3c-hsotg driver into the dwc2 folder, use the defines in the dwc2 hw.h, a

[PATCH v6 3/3] usb: dwc2: move s3c-hsotg data structures

2014-04-14 Thread Paul Zimmerman
From: Dinh Nguyen This patch moves the data structures that are in the s3c-hsotg source into core.h. This is a necessary step towards unifying the s3c-hsotg and dwc2 into a single DRD. Signed-off-by: Dinh Nguyen [ jh,rb,fb - For gadget part only: ] Tested-by: Jingoo Han Tested-by: Robert Baldy

[PATCH v6 1/3] usb: dwc2: add defines to support s3c-hsotg driver

2014-04-14 Thread Paul Zimmerman
From: Dinh Nguyen In preparation of combining the dwc2/s3c-hsotg driver in a single DRD driver, the defines in dwc2/hw.h needs to get updated so that the s3c-hsotg driver can use them. Signed-off-by: Dinh Nguyen [ jh,rb - For gadget part only: ] Tested-by: Jingoo Han Tested-by: Robert Baldyga

Re: problem with resume after s2ram

2014-04-14 Thread Alan Stern
On Thu, 10 Apr 2014, Alan Stern wrote: > On Thu, 10 Apr 2014, Peter Münster wrote: > > > On Tue, Apr 01 2014, Alan Stern wrote: > > > > >> Should I do another git-bisect? > > > > > > Yes, that would be a good idea. > > > > Hi Alan, > > > > Here is the result: > > > > e583d9db9960cf40e0bc8afee

[RESEND PATCH v2] documentation: docbook: document process of writing an musb glue layer

2014-04-14 Thread Apelete Seketeli
Document the process of writing an musb glue layer by taking the Ingenic JZ4740 glue layer as an example, as it seems more simple than most glue layers due to the basic feature set of the JZ4740 USB device controller. Signed-off-by: Apelete Seketeli --- Documentation/DocBook/Makefile

Re: [PATCH] usb/serial/ch341: Add parity support

2014-04-14 Thread Kijam López
Apply this patch because I have a device that uses even parity. It is a tax machine, it worked perfect in that case. I want to thank you again, though I did in my thread, I write only to support you and implement this PATCH soon. > Based on wireshark packet traces from a windows machine. > > ch34

[RESEND PATCH v2] Add documentation on writing an musb glue layer

2014-04-14 Thread Apelete Seketeli
Hello, Following a few patches already in tree that add support for the USB device controller of the Ingenic JZ4740 MIPS SoC, I documented the process of writing an MUSB glue layer. The JZ4740 MUSB controller offers a basic feature set, which makes the glue layer implementation more simple than mo

[PATCH] USB: cdc-acm: fix broken runtime suspend

2014-04-14 Thread Johan Hovold
The current ACM runtime-suspend implementation is broken in several ways: Firstly, it buffers only the first write request being made while suspended -- any further writes are silently dropped. Secondly, writes being dropped also leak write urbs, which are never reclaimed (until the device is unb

[PATCH] usb/serial/ch341: Add parity support

2014-04-14 Thread Karl Palsson
Based on wireshark packet traces from a windows machine. ch340 and ch341 both seem to support all parity modes, but only the ch341 appears to support variable data bits and variable stop bits, so those are left unimplemented, as before. Tested on a generic usb-rs485 dongle with the chip label scr

patch: usb/serial/ch341: v2: Add parity support

2014-04-14 Thread Karl Palsson
Changes since v1: * Use the C_CMSPAR macros from 3.14 as requested by Johan Hovold v1 was here: http://comments.gmane.org/gmane.linux.usb.general/105940 Sincerely, Karl Palsson -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kern

Re: [RFC 0/2] Support for Super Speed Link Layer Test

2014-04-14 Thread Alan Stern
On Mon, 14 Apr 2014, Pratyush Anand wrote: > Hi Alan, > > On Fri, Apr 11, 2014 at 06:56:37PM +0800, Pratyush ANAND wrote: > > Lecroy's USB Compliance suites provide option to test Link Layer Tests > > for Super Speed device as well as host. > > > > As of now there is no standard way to test embe

Re: Missing USB XHCI and EHCI reset for kexec

2014-04-14 Thread Alan Stern
On Mon, 14 Apr 2014, Stefani Seibold wrote: > > > An other PowerPC device which is nearly eactly the same HW but without > > > this USB HUB works perfectly. > > > > Maybe you should replace that hub with a different brand. > > > > Thats not possible, because the Hub is soldered on the board.

[PATCH] USB: fix crash during hotplug of PCI USB controller card

2014-04-14 Thread Alan Stern
The code in hcd-pci.c that matches up EHCI controllers with their companion UHCI or OHCI controllers assumes that the private drvdata fields don't get set too early. However, it turns out that this field gets set by usb_create_hcd(), before hcd-pci expects it, and this can result in a crash when t

RE: [RFC 1/4] dwc3: dts: Binding information for an optional property lpm_capable

2014-04-14 Thread Paul Zimmerman
> From: linux-usb-ow...@vger.kernel.org > [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Pratyush Anand > Sent: Monday, April 14, 2014 1:48 AM > > On Mon, Apr 14, 2014 at 09:42:25AM +0530, Pratyush Anand wrote: > > Hi Paul, > > > > On Sat, Apr 12, 2014 at 02:25:27AM +0800, Paul Zimmerman w

linux-usb@vger.kernel.org

2014-04-14 Thread Christoph Lameter
n Mon, 14 Apr 2014, Grygorii Strashko wrote: > Hi All, > > I'm observing a huge number of warnings produced during the boot of my > Keystone 2 board > when USB is enabled. > > [2.496460] BUG: using __this_cpu_read() in preemptible [] code: > khubd/202 > [2.504030] caller is __mod

Re: EHCI hotplug kernel crash in kernel 3.14 and 3.13

2014-04-14 Thread Stefani Seibold
Hi Alan, the patch fix the issue. I tested it on a notebook with a cardbus controller and on desktop machine with a thunderbolt interface. Both are working. Thunderbolt will sometimes crash but i think this is a issue with dynamic added pci bridges, which cause a lot of trouble and headache to m

Re: Driver CH341 USB Adapter Serial Port not Works in Linux

2014-04-14 Thread Kijam López
Yes! Thank you so much, do not know how many days I had trying to make it work :D. That patch worked perfectly me, now if I works perfect. I look forward to mourn :'(. I do not understand why not even include that patch in the Kernel. 2014-04-14 5:43 GMT-04:30 Karl Palsson : > > > On Sun, Apr 1

linux-usb@vger.kernel.org

2014-04-14 Thread Dan Williams
On Mon, 2014-04-14 at 00:22 +0800, treeui@gmail.com wrote: > From: "shu.suo" > > Signed-off-by: shu.suo > --- > linux-3.14/drivers/usb/serial/option.c | 47 > +++--- > 1 file changed, 43 insertions(+), 4 deletions(-) Some of these devices look like Android hots

linux-usb@vger.kernel.org

2014-04-14 Thread Grygorii Strashko
Hi All, I'm observing a huge number of warnings produced during the boot of my Keystone 2 board when USB is enabled. [2.496460] BUG: using __this_cpu_read() in preemptible [] code: khubd/202 [2.504030] caller is __mod_zone_page_state+0x20/0xc8 [2.509094] CPU: 1 PID: 202 Comm

Re: Missing USB XHCI and EHCI reset for kexec

2014-04-14 Thread Stefani Seibold
Am Montag, den 14.04.2014, 12:27 -0400 schrieb Alan Stern: > On Mon, 14 Apr 2014 stef...@seibold.net wrote: > > > Zitat von Alan Stern : > > > > > > >> <6>[ 167.936921] usb 2-2.1: new full-speed USB device number 3 > > >> using ohci-pci > > >> <6>[ 168.067890] usb 2-2.1: New USB device found

Re: Missing USB XHCI and EHCI reset for kexec

2014-04-14 Thread Alan Stern
On Mon, 14 Apr 2014 stef...@seibold.net wrote: > Zitat von Alan Stern : > > > >> <6>[ 167.936921] usb 2-2.1: new full-speed USB device number 3 > >> using ohci-pci > >> <6>[ 168.067890] usb 2-2.1: New USB device found, idVendor=076b, > >> idProduct=a021 > >> <6>[ 168.074871] usb 2-2.1: New

Re: [PATCH 0/2] USB: ohci-jz4740: Miscellaneous fixes

2014-04-14 Thread Alan Stern
On Mon, 14 Apr 2014, Laurent Pinchart wrote: > Hello, > > I've noticed two issues with teh ohci-jz4740 driver while reading the source > code. Here are two patches to fix them. Both are untested as I don't have > access to the hardware. I don't have that hardware either. > Laurent Pinchart (2):

Re: stk1160 / ehci-pci 0000:00:0a.0: DMA-API: device driver maps memory fromstack [addr=ffff88003d0b56bf]

2014-04-14 Thread Ezequiel Garcia
On Apr 14, Ezequiel Garcia wrote: > On Apr 13, Sander Eikelenboom wrote: > > > > I'm hitting this warning on boot with a syntek usb video grabber, it's not > > clear > > to me if it's a driver issue of the stk1160 or a generic ehci issue. > > > > Can't reproduce the same warning easily here. C

Re: Missing USB XHCI and EHCI reset for kexec

2014-04-14 Thread stefani
Zitat von Benjamin Herrenschmidt : On Sun, 2014-04-13 at 21:22 +0200, Stefani Seibold wrote: When executing a kexec kernel on a PowerPC board the new started kernel will not find already enumerated USB devices due a missing reset on the USB bus. As a work around a echo 1 >/sys/bus/pci/driver

Re: Missing USB XHCI and EHCI reset for kexec

2014-04-14 Thread stefani
Zitat von Alan Stern : <6>[ 167.936921] usb 2-2.1: new full-speed USB device number 3 using ohci-pci <6>[ 168.067890] usb 2-2.1: New USB device found, idVendor=076b, idProduct=a021 <6>[ 168.074871] usb 2-2.1: New USB device strings: Mfr=1, Product=2, SerialNumber=0 <6>[ 168.082226] usb 2

Re: [RFC 3/4] xhci: A default implementation for Ux timeout calculation and tier policy check

2014-04-14 Thread Mathias Nyman
Hi On 04/11/2014 01:20 PM, Pratyush Anand wrote: As best case, a host controller should support U0 to U1 switching for the devices connected below any tier of hub level supported by usb specification. Therefore xhci_check_default_tier_policy always returns success. A host should be able to issu

Re: USB: serial: option: add support for Novatel E371 PCIe card

2014-04-14 Thread Johan Hovold
On Mon, Apr 14, 2014 at 05:01:25PM +0200, Alexej Starschenko wrote: > Adds product ID for the Novatel E371 PCI Express Mini Card. > > $ lsusb > Bus 001 Device 024: ID 1410:9011 Novatel Wireless > > $ usb-devices > T: Bus=01 Lev=01 Prnt=01 Port=03 Cnt=01 Dev#= 24 Spd=480 MxCh= 0 > D: Ver= 2.00 C

Re: EHCI hotplug kernel crash in kernel 3.14 and 3.13

2014-04-14 Thread Alan Stern
On Sun, 13 Apr 2014, Stefani Seibold wrote: > A hot plug of an USB 2.0 EHCI controller cardbus card will result in a > kernel crash. This is the kernel log of a vanilla 3.14 x86_64 kernel. I > will attach my kernel config. > [ 70.419755] ehci-pci :04:00.2: EHCI Host Controller > [ 70.4198

USB: serial: option: add support for Novatel E371 PCIe card

2014-04-14 Thread Alexej Starschenko
Adds product ID for the Novatel E371 PCI Express Mini Card. $ lsusb Bus 001 Device 024: ID 1410:9011 Novatel Wireless $ usb-devices T: Bus=01 Lev=01 Prnt=01 Port=03 Cnt=01 Dev#= 24 Spd=480 MxCh= 0 D: Ver= 2.00 Cls=ef(misc ) Sub=02 Prot=01 MxPS=64 #Cfgs= 1 P: Vendor=1410 ProdID=9011 Rev=00.03

Re: [PATCH] USB: cp210x: Add 8281 (Nanotec Plug & Drive)

2014-04-14 Thread Johan Hovold
On Sun, Apr 13, 2014 at 11:57:16PM +0200, Tristan Bruns wrote: > Signed-off-by: Tristan Bruns Signed-off-by: Johan Hovold Thanks for the patch. Johan > --- > drivers/usb/serial/cp210x.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial

Re: Missing USB XHCI and EHCI reset for kexec

2014-04-14 Thread Alan Stern
On Mon, 14 Apr 2014 stef...@seibold.net wrote: > > From Alan Stern : > > > On Sun, 13 Apr 2014, Stefani Seibold wrote: > > > >> When executing a kexec kernel on a PowerPC board the new started kernel > >> will not find already enumerated USB devices due a missing reset on the > >> USB bus. > >

Re: [PATCH/RFC 0/3] Allow OHCI drivers to override hub control operations

2014-04-14 Thread Alan Stern
On Mon, 14 Apr 2014, Laurent Pinchart wrote: > Hello, > > The PXA27x OHCI implementation doesn't perform automatic control of port power > supplies for all ports. While the PPS and LSDA bits of the HcRhPortStatus > register are implemented, only a subset of ports have an external power enable > p

Re: [PATCH V4 1/5] phy: Add new Exynos5 USB 3.0 PHY driver

2014-04-14 Thread Sylwester Nawrocki
On 08/04/14 16:36, Vivek Gautam wrote: > diff --git a/Documentation/devicetree/bindings/phy/samsung-phy.txt > b/Documentation/devicetree/bindings/phy/samsung-phy.txt > index 28f9edb..6d99ba9 100644 > --- a/Documentation/devicetree/bindings/phy/samsung-phy.txt > +++ b/Documentation/devicetree/bindi

Re: [PATCH V4 1/5] phy: Add new Exynos5 USB 3.0 PHY driver

2014-04-14 Thread Sylwester Nawrocki
On 14/04/14 15:49, Vivek Gautam wrote: > True, we don't have a scope of instantiating this driver using old > platform device and > old legacy board files. > So we don't need this check then, right ? I think it can be dropped. At least IMHO there is no point to increase size of the module with an

Re: [RFC 1/2] n_tty: fix dropped output characters

2014-04-14 Thread One Thousand Gnomes
On Mon, 14 Apr 2014 15:05:49 +0200 Oliver Neukum wrote: > On Mon, 2014-04-14 at 13:53 +0100, One Thousand Gnomes wrote: > > On Fri, 11 Apr 2014 11:41:24 +0200 > > Johan Hovold wrote: > > > > > Fix characters being dropped by n_tty_write() due to a failure to > > > check the return value of tty_

Re: [PATCH V4 1/5] phy: Add new Exynos5 USB 3.0 PHY driver

2014-04-14 Thread Vivek Gautam
Hi, On Mon, Apr 14, 2014 at 7:14 PM, Tomasz Figa wrote: > On 14.04.2014 15:05, Kishon Vijay Abraham I wrote: >> >> >> >> On Monday 14 April 2014 05:35 PM, Vivek Gautam wrote: >>> >>> Hi Kishon, >>> >>> >>> On Mon, Apr 14, 2014 at 5:24 PM, Kishon Vijay Abraham I >>> wrote: Hi, >>>

Re: Missing USB XHCI and EHCI reset for kexec

2014-04-14 Thread stefani
From Alan Stern : On Sun, 13 Apr 2014, Stefani Seibold wrote: When executing a kexec kernel on a PowerPC board the new started kernel will not find already enumerated USB devices due a missing reset on the USB bus. How do you know the problem is caused by a missing reset? A "echo 1 >/sys

Re: [PATCH v10 00/11] Add USB OTG HNP and SRP support on Chipidea usb driver

2014-04-14 Thread Peter Chen
On Mon, Apr 14, 2014 at 10:22:32AM +0800, Li Jun wrote: > On Mon, Apr 14, 2014 at 09:37:50AM +0800, Li Jun wrote: > > From: Li Jun > > > > This patchset adds USB OTG HNP and SRP support on chipidea usb driver, > > existing OTG port role swtich function by ID pin status kept unchanged, > > based o

Re: [PATCH V4 1/5] phy: Add new Exynos5 USB 3.0 PHY driver

2014-04-14 Thread Tomasz Figa
On 14.04.2014 15:40, Vivek Gautam wrote: On Mon, Apr 14, 2014 at 6:56 PM, Kishon Vijay Abraham I wrote: On Monday 14 April 2014 06:50 PM, Vivek Gautam wrote: On Mon, Apr 14, 2014 at 6:29 PM, Kishon Vijay Abraham I wrote: On Monday 14 April 2014 06:12 PM, Vivek Gautam wrote: Hi, On Mon

Re: [PATCH V4 1/5] phy: Add new Exynos5 USB 3.0 PHY driver

2014-04-14 Thread Vivek Gautam
On Mon, Apr 14, 2014 at 7:10 PM, Vivek Gautam wrote: Just correcting mail-ids for Mark and Dong with the latest ones (earlier ones got bounced back) > On Mon, Apr 14, 2014 at 6:56 PM, Kishon Vijay Abraham I wrote: >> >> >> On Monday 14 April 2014 06:50 PM, Vivek Gautam wrote: >>> On Mon, Apr 14

Re: [PATCH V4 1/5] phy: Add new Exynos5 USB 3.0 PHY driver

2014-04-14 Thread Tomasz Figa
On 14.04.2014 15:05, Kishon Vijay Abraham I wrote: On Monday 14 April 2014 05:35 PM, Vivek Gautam wrote: Hi Kishon, On Mon, Apr 14, 2014 at 5:24 PM, Kishon Vijay Abraham I wrote: Hi, On Wednesday 09 April 2014 04:36 PM, Tomasz Figa wrote: Hi Vivek, Please see my comments inline. On 08.

Re: [PATCH V4 1/5] phy: Add new Exynos5 USB 3.0 PHY driver

2014-04-14 Thread Vivek Gautam
On Mon, Apr 14, 2014 at 6:56 PM, Kishon Vijay Abraham I wrote: > > > On Monday 14 April 2014 06:50 PM, Vivek Gautam wrote: >> On Mon, Apr 14, 2014 at 6:29 PM, Kishon Vijay Abraham I >> wrote: >>> >>> >>> On Monday 14 April 2014 06:12 PM, Vivek Gautam wrote: Hi, On Mon, Apr 14

Re: [RFC 1/2] n_tty: fix dropped output characters

2014-04-14 Thread Johan Hovold
On Mon, Apr 14, 2014 at 01:53:33PM +0100, One Thousand Gnomes wrote: > On Fri, 11 Apr 2014 11:41:24 +0200 > Johan Hovold wrote: > > > Fix characters being dropped by n_tty_write() due to a failure to > > check the return value of tty_put_char() in do_output_char(). > > > > Characters are current

Re: [PATCH V4 1/5] phy: Add new Exynos5 USB 3.0 PHY driver

2014-04-14 Thread Kishon Vijay Abraham I
On Monday 14 April 2014 06:50 PM, Vivek Gautam wrote: > On Mon, Apr 14, 2014 at 6:29 PM, Kishon Vijay Abraham I wrote: >> >> >> On Monday 14 April 2014 06:12 PM, Vivek Gautam wrote: >>> Hi, >>> >>> >>> On Mon, Apr 14, 2014 at 5:57 PM, Kishon Vijay Abraham I >>> wrote: Hi, On Tue

Re: [PATCH V4 1/5] phy: Add new Exynos5 USB 3.0 PHY driver

2014-04-14 Thread Vivek Gautam
On Mon, Apr 14, 2014 at 6:29 PM, Kishon Vijay Abraham I wrote: > > > On Monday 14 April 2014 06:12 PM, Vivek Gautam wrote: >> Hi, >> >> >> On Mon, Apr 14, 2014 at 5:57 PM, Kishon Vijay Abraham I >> wrote: >>> Hi, >>> >>> On Tuesday 08 April 2014 08:06 PM, Vivek Gautam wrote: Add a new drive

Re: [RFC 1/2] n_tty: fix dropped output characters

2014-04-14 Thread Oliver Neukum
On Mon, 2014-04-14 at 13:53 +0100, One Thousand Gnomes wrote: > On Fri, 11 Apr 2014 11:41:24 +0200 > Johan Hovold wrote: > > > Fix characters being dropped by n_tty_write() due to a failure to > > check the return value of tty_put_char() in do_output_char(). > > > > Characters are currently bein

Re: [PATCH V4 1/5] phy: Add new Exynos5 USB 3.0 PHY driver

2014-04-14 Thread Kishon Vijay Abraham I
On Monday 14 April 2014 05:35 PM, Vivek Gautam wrote: > Hi Kishon, > > > On Mon, Apr 14, 2014 at 5:24 PM, Kishon Vijay Abraham I wrote: >> Hi, >> >> On Wednesday 09 April 2014 04:36 PM, Tomasz Figa wrote: >>> Hi Vivek, >>> >>> Please see my comments inline. >>> >>> On 08.04.2014 16:36, Vivek G

Re: [PATCH V4 1/5] phy: Add new Exynos5 USB 3.0 PHY driver

2014-04-14 Thread Kishon Vijay Abraham I
On Monday 14 April 2014 06:12 PM, Vivek Gautam wrote: > Hi, > > > On Mon, Apr 14, 2014 at 5:57 PM, Kishon Vijay Abraham I wrote: >> Hi, >> >> On Tuesday 08 April 2014 08:06 PM, Vivek Gautam wrote: >>> Add a new driver for the USB 3.0 PHY on Exynos5 series of SoCs. >>> The new driver uses the g

Re: [RFC 1/2] n_tty: fix dropped output characters

2014-04-14 Thread One Thousand Gnomes
On Fri, 11 Apr 2014 11:41:24 +0200 Johan Hovold wrote: > Fix characters being dropped by n_tty_write() due to a failure to > check the return value of tty_put_char() in do_output_char(). > > Characters are currently being dropped by write if a tty driver claims > to have write room available, bu

Re: [PATCH V4 1/5] phy: Add new Exynos5 USB 3.0 PHY driver

2014-04-14 Thread Vivek Gautam
Hi, On Mon, Apr 14, 2014 at 5:57 PM, Kishon Vijay Abraham I wrote: > Hi, > > On Tuesday 08 April 2014 08:06 PM, Vivek Gautam wrote: >> Add a new driver for the USB 3.0 PHY on Exynos5 series of SoCs. >> The new driver uses the generic PHY framework and will interact >> with DWC3 controller presen

Re: [PATCH V4 1/5] phy: Add new Exynos5 USB 3.0 PHY driver

2014-04-14 Thread Kishon Vijay Abraham I
Hi, On Tuesday 08 April 2014 08:06 PM, Vivek Gautam wrote: > Add a new driver for the USB 3.0 PHY on Exynos5 series of SoCs. > The new driver uses the generic PHY framework and will interact > with DWC3 controller present on Exynos5 series of SoCs. > Thereby, removing old phy-samsung-usb3 driver a

[PATCH/RFC 2/3] USB: ohci-pxa27x: Add support for external vbus regulators

2014-04-14 Thread Laurent Pinchart
Override the hub control operation to enable and disable external regulators for the ports vbus power supply in response to clear/set USB_PORT_FEAT_POWER requests. Signed-off-by: Laurent Pinchart --- drivers/usb/host/ohci-pxa27x.c | 67 ++ 1 file changed,

[PATCH/RFC 3/3] ARM: pxa: zeus: Replace OHCI init/exit functions with a regulator

2014-04-14 Thread Laurent Pinchart
Signed-off-by: Laurent Pinchart --- arch/arm/mach-pxa/zeus.c | 89 ++-- 1 file changed, 48 insertions(+), 41 deletions(-) diff --git a/arch/arm/mach-pxa/zeus.c b/arch/arm/mach-pxa/zeus.c index b19d1c3..205f9bf 100644 --- a/arch/arm/mach-pxa/zeus.c +++

[PATCH/RFC 1/3] USB: OHCI: Export the ohci_hub_control function

2014-04-14 Thread Laurent Pinchart
Platform drivers sometimes need to perform specific handling of hub control requests. Make this possible by exporting the ohci_hub_control() function which can then be called from a custom hub control handler in the default case. Signed-off-by: Laurent Pinchart --- drivers/usb/host/ohci-hub.c

[PATCH/RFC 0/3] Allow OHCI drivers to override hub control operations

2014-04-14 Thread Laurent Pinchart
Hello, The PXA27x OHCI implementation doesn't perform automatic control of port power supplies for all ports. While the PPS and LSDA bits of the HcRhPortStatus register are implemented, only a subset of ports have an external power enable pin controlled by the port status register. Other ports nee

Re: stk1160 / ehci-pci 0000:00:0a.0: DMA-API: device driver maps memory fromstack [addr=ffff88003d0b56bf]

2014-04-14 Thread Ezequiel Garcia
On Apr 13, Sander Eikelenboom wrote: > > I'm hitting this warning on boot with a syntek usb video grabber, it's not > clear > to me if it's a driver issue of the stk1160 or a generic ehci issue. > Can't reproduce the same warning easily here. Could you test the following patch? diff --git a/

Re: [PATCH V4 1/5] phy: Add new Exynos5 USB 3.0 PHY driver

2014-04-14 Thread Vivek Gautam
Hi Kishon, On Mon, Apr 14, 2014 at 5:24 PM, Kishon Vijay Abraham I wrote: > Hi, > > On Wednesday 09 April 2014 04:36 PM, Tomasz Figa wrote: >> Hi Vivek, >> >> Please see my comments inline. >> >> On 08.04.2014 16:36, Vivek Gautam wrote: >>> Add a new driver for the USB 3.0 PHY on Exynos5 series

Re: usb_class_driver multiple /dev entries

2014-04-14 Thread Старцев Евгений
14.04.2014, 15:02, "Greg KH" : >  On Mon, Apr 14, 2014 at 01:26:54PM +0400, Старцев Евгений wrote: >>   Hello! >> >>   I am developing usb device driver. >  For what type of USB device? >>   I used usb_register_dev for it and usb_class_driver, related to it. >>   But i need for this device multipl

[PATCH v2 02/13] Documentation: update charger-manager devicetree bindings

2014-04-14 Thread Robert Baldyga
This patch changes charger-manager bindings to be compatible with new extcon bindings. Signed-off-by: Robert Baldyga --- .../bindings/power_supply/charger-manager.txt | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/Documentation/devicetree/bindings/power_su

[PATCH v2 00/13] extcon: major rework

2014-04-14 Thread Robert Baldyga
This patchset adds many improvements to extcon class driver and extcon provider drivers. It changes extcon API to faster and safer by replaceing function taking extcon and cable names with functions working with structures representing this objects. It adds more advanced devicetree support which a

[PATCH v2 01/13] Documentation: add extcon devicetree bindings

2014-04-14 Thread Robert Baldyga
This patch adds extcon devicetree bindings. Documentation describes in general client and provider bindings, and contains detailed desctiprion of bindings for each extcon provider. Signed-off-by: Robert Baldyga --- .../devicetree/bindings/extcon/extcon-adc-jack.txt | 60 +++ ..

Re: [PATCH V4 1/5] phy: Add new Exynos5 USB 3.0 PHY driver

2014-04-14 Thread Kishon Vijay Abraham I
Hi, On Wednesday 09 April 2014 04:36 PM, Tomasz Figa wrote: > Hi Vivek, > > Please see my comments inline. > > On 08.04.2014 16:36, Vivek Gautam wrote: >> Add a new driver for the USB 3.0 PHY on Exynos5 series of SoCs. >> The new driver uses the generic PHY framework and will interact >> with DW

[PATCH v2 03/13] extcon: extcon-class: remove extcon_set_cable_state() function

2014-04-14 Thread Robert Baldyga
This patch removes extcon_set_cable_state() and replace all calls of this function witch extcon_set_cable_state_(), which is faster version. This is first step of changing extcon API to faster and safer. Signed-off-by: Robert Baldyga --- drivers/extcon/extcon-class.c| 17 drivers/

[PATCH v2 04/13] extcon: extcon-class: match extcon device by devicetree node

2014-04-14 Thread Robert Baldyga
This patch modifies extcon_get_edev_by_phandle() function, to match extcon device by devicetree node. This modification needed to add field 'node' in extcon_dev structure, and fill it in probe function of each extcon provider driver. This patch adds function of_extcon_get_extcon_dev(), returning e

[PATCH v2 05/13] extcon: extcon-class: improve extcon client API

2014-04-14 Thread Robert Baldyga
This patch improves extcon client API to get rid of ugly functions operating on name strings. It gives independency from naming convention in extcon provider drivers. Names given at provider registration are now used only for sysfs, debugs, and to support platforms using legacy devicetree bindings.

[PATCH v2 06/13] extcon: extcon-class: remove unused functions

2014-04-14 Thread Robert Baldyga
This patch removes two functions, extcon_find_cable_index() and extcon_get_edev_by_phandle(). They are not longer needed, since extcon client API has changed to be oriented on extcon_cable instead of extcon_dev. Signed-off-by: Robert Baldyga --- drivers/extcon/extcon-class.c | 67 -

[PATCH v2 07/13] extcon: extcon-class: improve get_cable_state_()/set_cable_state_() functions

2014-04-14 Thread Robert Baldyga
Added check if pointer to edev is not NULL, and updated documentation of index parameter. Function extcon_find_cable_index() has been deleted and cannot be used to retrieve cable number. Signed-off-by: Robert Baldyga --- drivers/extcon/extcon-class.c |9 ++--- 1 file changed, 6 insertion

[PATCH v2 12/13] extcon: extcon-max8997: check if pdata exists

2014-04-14 Thread Robert Baldyga
This patch adds check if pdata is NULL, to avoid NULL pointer dereference when platform data is not available. After this changes, in described situation driver will be configured with default values. Signed-off-by: Robert Baldyga --- drivers/extcon/extcon-max8997.c |2 +- 1 file changed, 1

[PATCH v2 09/13] extcon: extcon-class: move example to Documentation

2014-04-14 Thread Robert Baldyga
This patch removes cable array example form extcon code, to avoid littering driver namespace. Now it's located in extcon documentation. Signed-off-by: Robert Baldyga --- Documentation/extcon/extcon.txt | 112 +++ drivers/extcon/extcon-class.c | 32 ---

[PATCH v2 11/13] extcon: extcon-adc-jack: add devicetree support

2014-04-14 Thread Robert Baldyga
This patch modifies extcon-adc-jack driver to use initialization data from devicetree, when platform data is not available. It allows to define cable list with ADC value ranges for each of them in devicetree bindings. Signed-off-by: Robert Baldyga --- drivers/extcon/extcon-adc-jack.c | 81

[PATCH v2 13/13] extcon: extcon-max77693: check if pdata exists

2014-04-14 Thread Robert Baldyga
This patch adds check if pdata is NULL, to avoid NULL pointer dereference when platform data is not available. After this changes, in described situation driver will be configured with default values. Signed-off-by: Robert Baldyga --- drivers/extcon/extcon-max77693.c |2 +- 1 file changed, 1

[PATCH v2 10/13] extcon: extcon-gpio: add devicetree support

2014-04-14 Thread Robert Baldyga
This patch modifies extcon-gpio driver to use initialization data from devicetree if platform data is not available. It allows to set controller and cable names, and another parameters from devicetree bindings. Signed-off-by: Robert Baldyga --- drivers/extcon/extcon-gpio.c | 70 +

[PATCH v2 08/13] extcon: extcon-class: simplify extcon_updata_state() function

2014-04-14 Thread Robert Baldyga
This patch simplifies extcon_updata_state() function. There is greatly simplified kobject_uevent preparation. Also meaning of variable passed to raw_notifier_call_chain() (and in effect to _call_per_cable()) has changed. Now positions on ones in variable 'val' in _call_per_cable() indicates numbers

Re: usb_class_driver multiple /dev entries

2014-04-14 Thread Greg KH
On Mon, Apr 14, 2014 at 01:26:54PM +0400, Старцев Евгений wrote: > Hello! > > I am developing usb device driver. For what type of USB device? > I used usb_register_dev for it and usb_class_driver, related to it. > But i need for this device multiple entries in /dev with different > fops, related

Re: Driver CH341 USB Adapter Serial Port not Works in Linux

2014-04-14 Thread Karl Palsson
On Sun, Apr 13, 2014 at 08:51:56PM -0430, Kijam López wrote: > The following code works for me correctly in Windows, but Linux does > not work. I am using the same PC, both operating systems are installed > native. I do not use virtual machine. I need to work on Linux. I have > tried in different

[PATCH 1/2] USB: ohci-jz4740: Fix uninitialized variable warning

2014-04-14 Thread Laurent Pinchart
The ret variable is not initialized in all code paths of the ohci_jz4740_hub_control function. Fix it. Signed-off-by: Laurent Pinchart --- drivers/usb/host/ohci-jz4740.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/ohci-jz4740.c b/drivers/usb/host/ohci-jz4

[PATCH 2/2] USB: ohci-jz4740: FEAT_POWER is a port feature, not a hub feature

2014-04-14 Thread Laurent Pinchart
Power control of hub ports target the CLEAR_FEATURE and SET_FEATURE requests to ports, not to the hub. Fix the hub control function to detect the request correctly. Signed-off-by: Laurent Pinchart --- drivers/usb/host/ohci-jz4740.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH 0/2] USB: ohci-jz4740: Miscellaneous fixes

2014-04-14 Thread Laurent Pinchart
Hello, I've noticed two issues with teh ohci-jz4740 driver while reading the source code. Here are two patches to fix them. Both are untested as I don't have access to the hardware. Laurent Pinchart (2): USB: ohci-jz4740: Fix uninitialized variable warning USB: ohci-jz4740: FEAT_POWER is a po

Re: Missing USB XHCI and EHCI reset for kexec

2014-04-14 Thread Benjamin Herrenschmidt
On Sun, 2014-04-13 at 21:22 +0200, Stefani Seibold wrote: > When executing a kexec kernel on a PowerPC board the new started kernel > will not find already enumerated USB devices due a missing reset on the > USB bus. > > As a work around a > > echo 1 >/sys/bus/pci/drivers/[ex]hci-pci/BUS-ADDRESS-

usb_class_driver multiple /dev entries

2014-04-14 Thread Старцев Евгений
Hello! I am developing usb device driver. I used usb_register_dev for it and usb_class_driver, related to it. But i need for this device multiple entries in /dev with different fops, related to different EP, how can i do that? Result of usb_register_dev is 1 entry, as far as i know. I have try

Re: stk1160 / ehci-pci 0000:00:0a.0: DMA-API: device driver maps memory fromstack [addr=ffff88003d0b56bf]

2014-04-14 Thread Ezequiel Garcia
On Apr 13, Alan Stern wrote: > On Sun, 13 Apr 2014, Sander Eikelenboom wrote: > > > Hi, > > > > I'm hitting this warning on boot with a syntek usb video grabber, it's not > > clear > > to me if it's a driver issue of the stk1160 or a generic ehci issue. > > It is a bug in the stk1160 driver. >

Re: [RFC 1/4] dwc3: dts: Binding information for an optional property lpm_capable

2014-04-14 Thread Pratyush Anand
On Mon, Apr 14, 2014 at 09:42:25AM +0530, Pratyush Anand wrote: > Hi Paul, > > On Sat, Apr 12, 2014 at 02:25:27AM +0800, Paul Zimmerman wrote: > > > From: Pratyush Anand [mailto:pratyush.an...@gmail.com] > > > Sent: Friday, April 11, 2014 11:06 AM > > > > > > On Fri, Apr 11, 2014 at 11:24 PM, Fel

Re: [PATCH] phy: exynos5-usbdrd: Add facility to toggle vbus gpio on/off

2014-04-14 Thread Vivek Gautam
Hi Felipe, On Sat, Apr 12, 2014 at 9:07 AM, Felipe Balbi wrote: > On Wed, Apr 09, 2014 at 05:24:45PM +0530, Vivek Gautam wrote: >> Adding support to enable/disable VBUS hooked to a gpio >> to enable vbus supply on the port. >> >> Signed-off-by: Vivek Gautam >> --- >> >> Based on 'phy-exynos5-us

usb_class_driver multiple /dev entries

2014-04-14 Thread Старцев Евгений
Hello! I am developing usb device driver. I used usb_register_dev for it and usb_class_driver, related to it. But i need for this device multiple entries in /dev, related to different EP, how can i do that? Result of usb_register_dev is 1 entry, as far as i know. I have try usb_register_dev fo

Re: [PATCH 1/1] ARM: dts: omap5: Add clocks to USB3 PHY node

2014-04-14 Thread Roger Quadros
Hi Tony, On 04/01/2014 05:13 PM, Felipe Balbi wrote: > On Tue, Apr 01, 2014 at 01:37:27PM +0300, Roger Quadros wrote: >> The USB3 PHY driver (ti-pipe3) was updated so that the relevant >> clock phandles are expected in the DT node. >> Provide the necessary clocks. >> >> Reported-by: Kishon Vijay A

  1   2   >