RE: [PATCH 2/3] libusbg: Fix buffer overrun issue. CID#56128

2014-05-11 Thread Krzysztof Opasiak
Hi, > -Original Message- > From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb- > ow...@vger.kernel.org] On Behalf Of philippedesw...@gmail.com > Sent: Friday, May 09, 2014 2:51 PM > To: philippedesw...@gmail.com; linux-usb@vger.kernel.org; > mpor...@linaro.org > Cc: Philippe De Swert

RE: [PATCH 1/3] libusbg: Fix readlink/buffer overrun issue. CID#56130, CID#56129

2014-05-11 Thread Krzysztof Opasiak
Hi, > -Original Message- > From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb- > ow...@vger.kernel.org] On Behalf Of philippedesw...@gmail.com > Sent: Friday, May 09, 2014 2:51 PM > To: philippedesw...@gmail.com; linux-usb@vger.kernel.org; > mpor...@linaro.org > Cc: Philippe De Swert

[PATCH] USB: Add LVS Test device driver

2014-05-11 Thread Pratyush Anand
OTG3 and EH Compliance Plan 1.0 talks about Super Speed OTG Verification system (SS-OVS) which consists of an excersizer and analyzer. USB Compliance Suite from Lecroy can act as such SS-OVS for Link Layer Validation (LVS). Some modifications are needed for an embedded Linux USB host to pass all

Re: i.MX6 USB OTG support is broken on linux-next

2014-05-11 Thread Sascha Hauer
On Sat, May 10, 2014 at 09:57:39PM +0800, Li Jun wrote: > On Sat, May 10, 2014 at 09:18:36PM +0800, Shawn Guo wrote: > > + Robin and David, > > > > diff --git a/drivers/usb/core/Kconfig b/drivers/usb/core/Kconfig > > index cb8e991..9081757 100644 > > --- a/drivers/usb/core/Kconfig > > +++ b/driver

Re: [RFC/PATCH] usb: musb: Prevent musb_am335x from being removed

2014-05-11 Thread George Cherian
On 5/8/2014 10:57 PM, Ezequiel Garcia wrote: At probe time, the musb_am335x driver registers its childs by calling of_platform_populate(), which registers all childs in the devicetree hierarchy recursively. On the other side, the driver's remove() function uses of_device_unregister() to remove e

RE: i.MX6 USB OTG support is broken on linux-next

2014-05-11 Thread Peter Chen
> > > > So when the board is OTG & EH (CONFIG_USB_OTG is set), it should have > > TPL according to spec. In fact, even the CONFIG_USB_OTG_WHITELIST is > > not set, the non-TPL devices have not worked well, eg, it will not be > > enumerated again after it has disconnected from host 10 seconds late

[PATCHv5 09/20] Documentation: dt-bindings: update xhci-platform DT binding

2014-05-11 Thread Thomas Petazzoni
From: Gregory CLEMENT This commit extends the compatible string list of the xhci-platform binding with the new "armada-375-xhci" and "armada-380-xhci" compatible strings. It is used to describe the XHCI controller which is available in the Armada 375 and 38x SoCs. It also indicates that an optio

[PATCHv5 04/20] usb: ehci-orion: add optional PHY support

2014-05-11 Thread Thomas Petazzoni
From: Gregory CLEMENT This commit extends the ehci-orion so that it can optionally be passed a reference to a PHY through the Device Tree. It will be useful for the Armada 375 SoCs. If no PHY is provided then the behavior of the driver is unchanged. [Thomas: use devm_phy_optional_get() so that w

[PATCHv5 07/20] usb: host: xhci-plat: add clock support

2014-05-11 Thread Thomas Petazzoni
From: Gregory CLEMENT Some platforms (such as the Armada 38x ones) can gate the clock of their USB controller. This patch adds the support for one clock in xhci-plat, by enabling it during probe and disabling it on remove. To achieve this, it adds a 'struct clk *' member in xhci_hcd. While only

[PATCHv5 19/20] ARM: mvebu: add Device Tree description of the xHCI controller on Armada 375

2014-05-11 Thread Thomas Petazzoni
From: Gregory CLEMENT The Marvell Armada 375 SoCs contain a xHCI controller. This commit adds the Device Tree description of this interfaces at the SoC level, and also enables the USB3 port on the Armada 375 DB platform. Signed-off-by: Gregory CLEMENT Signed-off-by: Thomas Petazzoni --- arch/

[PATCHv5 01/20] usb: ehci-orion: use platform_get_irq() for DT probing

2014-05-11 Thread Thomas Petazzoni
Commit 77dae54ab385033e488d8b07045bc7f8d931740f ('ARM: Kirkwood: ehci-orion: Add device tree binding') added the Device Tree binding for the ehci-orion driver. To achieve that with the irq, it used the irq_of_parse_and_map() function when probed in DT-mode, and platform_get_irq() when probed in non

[PATCHv5 08/20] usb: host: xhci-plat: add support for the Armada 375/38x XHCI controllers

2014-05-11 Thread Thomas Petazzoni
From: Gregory CLEMENT The Armada 375 and 38x SoCs come with an XHCI controller that requires some specific initialization related to the MBus windows configuration. This patch adds the support for this special configuration as an XHCI quirk executed during probe. Two new compatible strings are a

[PATCHv5 16/20] ARM: mvebu: add Device Tree description of xHCI controllers on Armada 38x

2014-05-11 Thread Thomas Petazzoni
From: Gregory CLEMENT The Marvell Armada 38x SoCs contains two xHCI controllers. This commit adds the Device Tree description of those interfaces at the SoC level, and also enables the two USB3 ports on the Armada 385 DB platform and one USB3 port on the Armada 385 RD platform. Signed-off-by: Gr

[PATCHv5 20/20] ARM: mvebu: add Device Tree description of the EHCI controller on Armada 375

2014-05-11 Thread Thomas Petazzoni
From: Gregory CLEMENT The Marvell Armada 375 SoCs contains one EHCI controller. This commit adds the Device Tree description of this interfaces at the SoC level, and also enables the USB2 port on the Armada 375 DB platform. Signed-off-by: Gregory CLEMENT Signed-off-by: Thomas Petazzoni --- ar

[PATCHv5 11/20] Documentation: dt-bindings: document the Armada 375 USB cluster binding

2014-05-11 Thread Thomas Petazzoni
From: Gregory CLEMENT Armada 375 comes with an USB2 host and device controller and an USB3 controller. The USB cluster control register allows to manage common features of both USB controllers. This commit adds the Device Tree binding documentation for this piece of hardware. Signed-off-by: Greg

[PATCHv5 06/20] usb: host: xhci-plat: sort the headers in alphabetic order

2014-05-11 Thread Thomas Petazzoni
From: Gregory CLEMENT Sorting the headers in alphabetic order will help to reduce the conflict when adding new headers later. Signed-off-by: Gregory CLEMENT Acked-by: Felipe Balbi Signed-off-by: Thomas Petazzoni --- drivers/usb/host/xhci-plat.c | 6 +++--- 1 file changed, 3 insertions(+), 3

[PATCHv5 15/20] ARM: configs: enable XHCI mvebu support in multi_v7_defconfig

2014-05-11 Thread Thomas Petazzoni
From: Gregory CLEMENT The Marvell Armada 38x platform needs the xhci_mvebu driver enabled for the xHCI USB hosts, so this commit enables the corresponding Kconfig option in multi_v7_defconfig. Signed-off-by: Gregory CLEMENT Signed-off-by: Thomas Petazzoni Cc: a...@kernel.org Cc: Kevin Hilman

[PATCHv5 18/20] ARM: mvebu: add Device Tree description of USB cluster controller on Armada 375

2014-05-11 Thread Thomas Petazzoni
From: Gregory CLEMENT On Armada 375, the USB cluster allows to control the cluster composed of the USB2 and USB3 host controllers. Signed-off-by: Gregory CLEMENT Signed-off-by: Thomas Petazzoni --- arch/arm/boot/dts/armada-375.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arc

[PATCHv5 13/20] ARM: mvebu: add USB3 support for Armada 375

2014-05-11 Thread Thomas Petazzoni
From: Gregory CLEMENT This patch add the selection of the config symbol to build the USB3 support for Armada 375. Signed-off-by: Gregory CLEMENT Signed-off-by: Thomas Petazzoni --- arch/arm/mach-mvebu/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-mvebu/Kconfig b/ar

[PATCHv5 14/20] ARM: configs: enable XHCI mvebu support in mvebu_v7_defconfig

2014-05-11 Thread Thomas Petazzoni
From: Gregory CLEMENT The Marvell Armada 38x platform needs the xhci_mvebu driver enabled for the xHCI USB hosts, so this commit enables the corresponding Kconfig option in mvebu_v7_defconfig. Signed-off-by: Gregory CLEMENT Signed-off-by: Thomas Petazzoni --- arch/arm/configs/mvebu_v7_defconf

[PATCHv5 05/20] Documentation: dt-bindings: update ehci-orion binding documentation

2014-05-11 Thread Thomas Petazzoni
This commit updates the Device Tree binding documentation of ehci-orion to take into account the fact that we can now optionally pass a clock and a PHY reference. Signed-off-by: Thomas Petazzoni --- Documentation/devicetree/bindings/usb/ehci-orion.txt | 5 + 1 file changed, 5 insertions(+)

[PATCHv5 00/20] USB support for Armada 38x and Armada 375

2014-05-11 Thread Thomas Petazzoni
Hello, This patch set adds the USB support for the Armada 38x and Armada 375 SOCs. These SoCs use an xHCI but still need specific initialization, mainly to setup the MBus memory windows. They also have another USB controller for EHCI, identical to the one used on other mvebu SOCs. This series is

[PATCHv5 10/20] phy: add support for USB cluster on the Armada 375 SoC

2014-05-11 Thread Thomas Petazzoni
From: Gregory CLEMENT The Armada 375 SoC comes with an USB2 host and device controller and an USB3 controller. The USB cluster control register allows to manage common features of both USB controllers. This commit adds a driver integrated in the generic PHY framework to control this USB cluster

[PATCHv5 17/20] ARM: mvebu: add Device Tree description of the EHCI controller on Armada 38x

2014-05-11 Thread Thomas Petazzoni
From: Gregory CLEMENT The Marvell Armada 38x SoCs contains one EHCI controller. This commit adds the Device Tree description of this interface at the SoC level, and also enables the USB2 port on the Armada 385 DB platform. Signed-off-by: Gregory CLEMENT Signed-off-by: Thomas Petazzoni --- arc

[PATCHv5 12/20] ARM: mvebu: add USB3 support for Armada 38x

2014-05-11 Thread Thomas Petazzoni
From: Gregory CLEMENT This patch adds the selection of the config symbol needed to build the USB3 support for Armada 38x into mvebu_v7_defconfig. Signed-off-by: Gregory CLEMENT Signed-off-by: Thomas Petazzoni --- arch/arm/mach-mvebu/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/

[PATCHv5 02/20] usb: ehci-orion: rename error goto labels in ehci_orion_drv_probe()

2014-05-11 Thread Thomas Petazzoni
In preparation to the introduction of additional initialization steps in ehci_orion_drv_probe(), we rename the error goto labels from err1, err2 and err3 names to some more meaningful names. Signed-off-by: Thomas Petazzoni Acked-by: Alan Stern --- drivers/usb/host/ehci-orion.c | 18 +---

[PATCHv5 03/20] usb: ehci-orion: fix clock reference leaking

2014-05-11 Thread Thomas Petazzoni
From: Gregory CLEMENT In order to disable the clock in the ->remove() function, a call to devm_clk_get() is being made, which further increases the reference count of the clock. In order to clean this up, a private structure holding a pointer to the clock is added using the override mechanism pr

Re: [PATCHv4 08/20] usb: host: xhci-plat: add support for the Armada 375/38x XHCI controllers

2014-05-11 Thread Thomas Petazzoni
Dear Shimoda, Yoshihiro, On Thu, 8 May 2014 11:44:48 +0900, Shimoda, Yoshihiro wrote: > > +#ifndef __LINUX_XHCI_MVEBU_H > > +#define __LINUX_XHCI_MVEBU_H > > +#if IS_ENABLED(CONFIG_USB_XHCI_MVEBU) > > +int xhci_mvebu_mbus_init_quirk(struct platform_device *pdev); > > +#else > > +static inline int

Re: Slow boot due to USB errors

2014-05-11 Thread poma
On 11.05.2014 19:17, Hans Petter Selasky wrote: > Hi, > >> Hi, >> >> echo "hw.usb.no_boot_wait=0" >> /boot/loader.conf >> >> --HPS >> > > Maybe not directly related to this list, but in FreeBSD we have a > tunable to not wait for synchronous device probing at boot. > > --HPS > If there's some

Re: Slow boot due to USB errors

2014-05-11 Thread Hans Petter Selasky
On 05/11/14 19:07, Alan Stern wrote: On Sun, 11 May 2014, drago01 wrote: I know that 1-4 is the touchscreen (its an ultrabook with a touchscreen) ... the touchscreen itself works just fine though. So if it takes more time / attempts to enumerate it and it works eventually anyway why do we block

Re: Slow boot due to USB errors

2014-05-11 Thread Hans Petter Selasky
Hi, Hi, echo "hw.usb.no_boot_wait=0" >> /boot/loader.conf --HPS Maybe not directly related to this list, but in FreeBSD we have a tunable to not wait for synchronous device probing at boot. --HPS -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a me

Re: Slow boot due to USB errors

2014-05-11 Thread Alan Stern
On Sun, 11 May 2014, drago01 wrote: > >>> I know that 1-4 is the touchscreen (its an ultrabook with a > >>> touchscreen) ... the touchscreen itself works just fine though. > >>> So if it takes more time / attempts to enumerate it and it works > >>> eventually anyway why do we block boot on it? > >

Re: Slow boot due to USB errors

2014-05-11 Thread drago01
On Sun, May 11, 2014 at 6:08 PM, poma wrote: > On 11.05.2014 08:37, Hans de Goede wrote: >> Hi, >> >> On 05/10/2014 08:00 PM, drago01 wrote: >>> On Sat, May 10, 2014 at 7:49 PM, Hans de Goede wrote: Hi, On 05/10/2014 05:13 PM, drago01 wrote: > Hi, > > Startup finished i

Re: [PATCH v2 0/6] usb: host: Cleanup for ioremap'ing hcd memory

2014-05-11 Thread Vivek Gautam
Hi, On Sat, May 10, 2014 at 7:55 PM, Alexander Shiyan wrote: > Sat, 10 May 2014 17:30:04 +0530 от Vivek Gautam : >> Based on 'usb-next' branch of Greg's usb tree. >> >> devm_ioremap_resource() API is advantageous over devm_ioremap() >> and should therefore be preferred to request any ioremap'ed

Re: [PATCH 5/6] usb: host: ehci-tegra: Use devm_ioremap_resource instead of devm_ioremap

2014-05-11 Thread Vivek Gautam
Hi, On Sun, May 11, 2014 at 1:13 AM, Sergei Shtylyov wrote: > Hello. > > > On 05/10/2014 01:57 PM, Vivek Gautam wrote: > >> Using devm_ioremap_resource() API should actually be preferred over >> devm_ioremap(), since the former request the mem region first and then >> gives back the ioremap'ed m

[PATCH 1/1] Add support for GPIOs for SMSC LAN95xx chips.

2014-05-11 Thread Evgeny Boger
There might be 11 GPIOs in total. Last three GPIOs (offsets 8-11, 0-based) are shared with FDX, LNKA, SPD LEDs respectively. The LEDs are driven by chip by default at startup time. Once the corresponding GPIO is requested, the chip LED drive logic is disabled. Based on commented out code presuma

Re: [PATCH] [resend] net: get rid of SET_ETHTOOL_OPS

2014-05-11 Thread Wilfried Klaebe
Am Sun, May 11, 2014 at 01:13:47PM +0530 schrieb Anish Khurana: > SET_ETHTOOL_OPS is equivalent to : > #define SET_ETHTOOL_OPS(netdev,ops) \ > ( (netdev)->ethtool_ops = (ops) ) > > how it makes difference removing this code and replacing with the > code mentioned ? It doesn't change anything

Re: [PATCH net-next 11/11] net: cdc_ncm: remove redundant "disconnected" flag

2014-05-11 Thread Enrico Mioso (@atlantide)
Acked-By: Enrico Mioso On Sat, 10 May 2014, Bj?rn Mork wrote: ==Date: Sat, 10 May 2014 17:41:49 +0200 ==From: Bj?rn Mork ==To: net...@vger.kernel.org ==Cc: linux-usb@vger.kernel.org, Alexey Orishko , ==Oliver Neukum , Enrico Mioso , ==David Laight , Bj?rn Mork ==Subject: [PATCH net-nex

[PATCH net-next v2 1/4] net: cdc_mbim: optionally use VLAN ID 4094 for IP session 0

2014-05-11 Thread Bjørn Mork
The cdc_mbim driver maps 802.1q VLANs to MBIM IP and DSS sessions. MBIM IP session 0 is handled as an exception and is mapped to untagged frames. This patch adds optional support for remapping MBIM IP session 0 to 802.1q VLAN ID 4094 instead. The default behaviour is not changed. The new behaviour

[PATCH net-next v2 4/4] net: cdc_ncm/cdc_mbim: rework probing of NCM/MBIM functions

2014-05-11 Thread Bjørn Mork
The NCM class match in the cdc_mbim driver is confusing and cause unexpected behaviour. The USB core guarantees that a USB interface is in altsetting 0 when probing starts. This means that devices implementing a NCM 1.0 backwards compatible MBIM function (a "NCM/MBIM function") always hit the NCM e

[PATCH net-next v2 3/4] net: cdc_mbim: add driver documentation

2014-05-11 Thread Bjørn Mork
An initial attempt on describing some of the odd APIs provided by this driver. Cc: Greg Suarez Signed-off-by: Bjørn Mork --- Documentation/networking/cdc_mbim.txt | 339 ++ 1 file changed, 339 insertions(+) create mode 100644 Documentation/networking/cdc_mbim.tx

[PATCH net-next v2 2/4] net: cdc_mbim: reject IP packets on DSS VLANs

2014-05-11 Thread Bjørn Mork
DSS VLANs are pseudo network interfaces representing arbitrary data streams, and specifically not IP. Preventing spurious IP packets can sometimes be a hassle. The kernel will for example send an IPv6 Router Solicit when the interface is brought up unless the user has been careful enough to disable

[PATCH net-next v2 0/4] cdc_mbim: cleanups and new features

2014-05-11 Thread Bjørn Mork
This series depends on commit 6b5eeb7f874b ("net: cdc_mbim: handle unaccelerated VLAN tagged frames"), which is currently in "net" but not yet in "net-next". Patch 4 might have a minor context collision with the "cdc_ncm: add buffer tuning and stats using ethtool" series I just posted for review.

Re: [PATCH net-next 1/4] net: cdc_mbim: optionally use VLAN ID 4094 for IP session 0

2014-05-11 Thread Bjørn Mork
Bjørn Mork writes: > @@ -164,12 +211,24 @@ static struct sk_buff *cdc_mbim_tx_fixup(struct usbnet > *dev, struct sk_buff *skb > skb_pull(skb, ETH_HLEN); > } > > + /* Is IP session <0> tagged too? */ > + if (!tci && info->flags & FLAG_