Re: [PATCH RFC 5/7] usb: gadget: configfs: changes for gadget bus introducing

2014-06-11 Thread Peter Chen
On Tue, Jun 10, 2014 at 02:00:13PM +0200, Andrzej Pietrasiewicz wrote: > Hi Peter, > Hi Andrzej, First, many thanks for commenting and testing it. The reason why I changed gadget-configfs: - The gadget-configfs will register itself (as usb_gadget_driver) when specific udc attaches to it, with g

Re: [PATCH v3] leds: USB: HID: Add support for MSI GT683R led panels

2014-06-11 Thread Jiri Kosina
On Wed, 11 Jun 2014, Janne Kanniainen wrote: > This driver adds support for USB controlled led panels that exists in MSI > GT683R laptop > > Changes in v2: > - sorted headers to alphabetic order > - using devm_kzalloc > - using BIT(n) > - using usb_control_msg instead of

Re: Hardware bug in Intel USB-2 hub?

2014-06-11 Thread Oliver Neukum
On Mon, 2014-06-09 at 11:11 -0400, Alan Stern wrote: > On Mon, 9 Jun 2014, Toralf Förster wrote: > > > On 06/19/2013 09:03 PM, Alan Stern wrote: > > > Sarah: > > > correctly and one didn't. Regardless, it was surprising to see > > > Toralf's report that an Intel hub doesn't work right. I don't h

[PATCH 6/7] fsl/otg: Add host-gadget drv sync delay

2014-06-11 Thread Ramneek Mehresh
Resolve synchronization issue between host and gadget drivers upon role-reversal Signed-off-by: Ramneek Mehresh Reviewed-by: Li Yang-R58472 Reviewed-by: Fleming Andrew-AFLEMING Tested-by: Fleming Andrew-AFLEMING --- drivers/usb/phy/phy-fsl-usb.c | 11 ++- 1 file changed, 10 insertions

[PATCH 3/7] fsl/otg: Modify otg_event to start host drv

2014-06-11 Thread Ramneek Mehresh
Add mechanism to start host driver from inside fsl_otg_even upon each id change interrupt Signed-off-by: Ramneek Mehresh Reviewed-by: Fleming Andrew-AFLEMING Tested-by: Fleming Andrew-AFLEMING --- drivers/usb/phy/phy-fsl-usb.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/usb

[PATCH 1/7] fsl/otg: Add controller version based ULPI and UTMI phy

2014-06-11 Thread Ramneek Mehresh
Add controller version based ULPI and UTMI phy initialization for otg driver Signed-off-by: Shengzhou Liu Signed-off-by: Ramneek Mehresh Reviewed-by: Fleming Andrew-AFLEMING Tested-by: Fleming Andrew-AFLEMING --- drivers/usb/phy/phy-fsl-usb.c | 20 drivers/usb/phy/phy-fsl

[PATCH 2/7] fsl/otg: Add support to add/remove usb host driver

2014-06-11 Thread Ramneek Mehresh
Add workqueue to add/remove host driver (outside interrupt context) upon each id change Signed-off-by: Li Yang Signed-off-by: Ramneek Mehresh Reviewed-by: Fleming Andrew-AFLEMING Tested-by: Fleming Andrew-AFLEMING --- drivers/usb/host/ehci-fsl.c | 97 +++-

[PATCH 4/7] fsl/otg: Combine host/gadget start/resume for ID change

2014-06-11 Thread Ramneek Mehresh
Make call to fsl_otg_event for each id change even Signed-off-by: Ramneek Mehresh Reviewed-by: Fleming Andrew-AFLEMING Tested-by: Fleming Andrew-AFLEMING --- drivers/usb/phy/phy-fsl-usb.c | 15 +++ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/drivers/usb/phy/phy-f

[PATCH 5/7] fsl/otg: Remove host drv upon otg bring-up

2014-06-11 Thread Ramneek Mehresh
Change have_hcd variable to remove/suspend host driver on completion of otg initilization for otg auto detect Signed-off-by: Ramneek Mehresh Reviewed-by: Li Yang-R58472 Reviewed-by: Fleming Andrew-AFLEMING Tested-by: Fleming Andrew-AFLEMING --- drivers/usb/host/ehci-fsl.c | 6 ++ 1 file c

Re: [PATCH v3] leds: USB: HID: Add support for MSI GT683R led panels

2014-06-11 Thread Johan Hovold
On Wed, Jun 11, 2014 at 12:21:39AM +0300, Janne Kanniainen wrote: > This driver adds support for USB controlled led panels that exists in MSI > GT683R laptop Can you break this line by 72 columns or so as well? > Changes in v2: > - sorted headers to alphabetic order > - using devm_kz

Re: [PATCH v3] leds: USB: HID: Add support for MSI GT683R led panels

2014-06-11 Thread Johan Hovold
On Wed, Jun 11, 2014 at 01:25:49PM +0200, Jiri Kosina wrote: > On Wed, 11 Jun 2014, Janne Kanniainen wrote: > > > This driver adds support for USB controlled led panels that exists in MSI > > GT683R laptop > > > > Changes in v2: > > - sorted headers to alphabetic order > > - using devm_k

Re: Hardware bug in Intel USB-2 hub?

2014-06-11 Thread Alan Stern
On Wed, 11 Jun 2014, Oliver Neukum wrote: > On Mon, 2014-06-09 at 11:11 -0400, Alan Stern wrote: > > On Mon, 9 Jun 2014, Toralf Förster wrote: > > > > > On 06/19/2013 09:03 PM, Alan Stern wrote: > > > > Sarah: > > > > correctly and one didn't. Regardless, it was surprising to see > > > > Toralf'

[PATCH v2 0/4] libusbg: Add support for functionfs

2014-06-11 Thread Krzysztof Opasiak
Dear Matt, Configuration of function fs based functions using config fs has been merged to linux kernel quite long ago. To keep libusbg up to date I have prepared patches that add support for functionfs function type. When working with ffs I noticed that it would be a good feature to provide devi

[PATCH v2 1/4] libusbg: Fix potential memory leak in usbg_init()

2014-06-11 Thread Krzysztof Opasiak
Memory allocated with asprintf() for variable path could be not free() in some cases. Fix this issue by doing some small refactoring. Signed-off-by: Krzysztof Opasiak --- src/usbg.c | 35 --- 1 file changed, 24 insertions(+), 11 deletions(-) diff --git a/src/us

[PATCH v2 2/4] libusbg: Add support for functionFS.

2014-06-11 Thread Krzysztof Opasiak
Recent kernel versions supports creation of functionFS based functions using configFS, so this library also should support this. Signed-off-by: Krzysztof Opasiak --- include/usbg/usbg.h | 14 ++ src/usbg.c | 22 +- 2 files changed, 35 insertions(+), 1

[PATCH v2 3/4] libusbg: Update show gadget example support ffs functions.

2014-06-11 Thread Krzysztof Opasiak
Signed-off-by: Krzysztof Opasiak --- examples/show-gadgets.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/examples/show-gadgets.c b/examples/show-gadgets.c index 1ae3860..672eac3 100644 --- a/examples/show-gadgets.c +++ b/examples/show-gadgets.c @@ -108,6 +108,9 @@ void show_function

[PATCH v2 4/4] libusbg: Add example to show how to create ffs functions.

2014-06-11 Thread Krzysztof Opasiak
Add example which demonstartes two ways of creating ffs based usb functions. How to set-up gadget using this example: 1) Run gadget-ffs 2) Mount both instances: $ mount my_dev_name -t functionfs /path/to/mount/dir1 $ mount my_awesome_dev_name -t functionfs /path/to/mount/dir2 3) Run ffs daemon

Re: [PATCH 1/1] xhci: clear root port wake on bits if controller isn't wake-up capable

2014-06-11 Thread Greg Kroah-Hartman
On Wed, Jun 11, 2014 at 06:25:20AM +0800, Lu Baolu wrote: > When the xHCI PCI host is suspended, if do_wakeup is false in > xhci_pci_suspend, > xhci_bus_suspend needs to clear all root port wake on bits. Otherwise some > Intel > platform may get a spurious wakeup, even if PCI PME# is disabled. >

Re: [PATCH v2] usb: host: uhci-grlib.c : use devm_ functions

2014-06-11 Thread Alan Stern
On Tue, 10 Jun 2014, Himangi Saraogi wrote: > The various devm_ functions allocate memory that is released when a > driver detaches. This patch uses devm_ioremap_resource for data > that is allocated in the probe function of a platform device and > is only freed in the remove function. The corresp

Re: [PATCH v3] leds: USB: HID: Add support for MSI GT683R led panels

2014-06-11 Thread Johan Hovold
On Wed, Jun 11, 2014 at 04:05:42PM +0200, Johan Hovold wrote: > On Wed, Jun 11, 2014 at 12:21:39AM +0300, Janne Kanniainen wrote: > > +static const char gt683r_led_select_leds[GT683R_BUFFER_SIZE] = { 0x01, > > 0x02, 0x30, 0x00, > > +0x00

Re: [PATCH v2 1/2] usb: ehci-exynos: Make provision for vdd regulators

2014-06-11 Thread Alan Stern
On Fri, 6 Jun 2014, Vivek Gautam wrote: > Facilitate getting required 3.3V and 1.0V VDD supply for > EHCI controller on Exynos. > > With patches for regulators' nodes merged in 3.15: > c8c253f ARM: dts: Add regulator entries to smdk5420 > 275dcd2 ARM: dts: add max77686 pmic node for smdk5250, >

Re: Dell Precision M3800] DisplayLink USB Graphics adapter not working

2014-06-11 Thread Greg KH
On Wed, Jun 11, 2014 at 08:49:34AM +0200, Bernhard Cygan wrote: > [1.] > Dell Precision M3800] DisplayLink USB Graphics adapter not working What is the vendor/product id of this device? You can get that with a simple `lsusb` output. The newer Displaylink device does not work on Linux as we do n

Re: [PATCH v3] leds: USB: HID: Add support for MSI GT683R led panels

2014-06-11 Thread Johan Hovold
On Wed, Jun 11, 2014 at 04:05:42PM +0200, Johan Hovold wrote: > On Wed, Jun 11, 2014 at 12:21:39AM +0300, Janne Kanniainen wrote: > > +static int gt683r_led_snd_msg(struct gt683r_led *led, char *msg) > > +{ > > + int ret; > > + > > + ret = hid_hw_raw_request(led->hdev, 0x01, msg, GT683R_BUFFER_

[PATCH v3] usb: host: uhci-grlib.c : use devm_ functions

2014-06-11 Thread Himangi Saraogi
The various devm_ functions allocate memory that is released when a driver detaches. This patch uses devm_ioremap_resource for data that is allocated in the probe function of a platform device and is only freed in the remove function. The corresponding free functions are removed and two labels are

Re: [PATCH v3] usb: host: uhci-grlib.c : use devm_ functions

2014-06-11 Thread Alan Stern
On Thu, 12 Jun 2014, Himangi Saraogi wrote: > The various devm_ functions allocate memory that is released when a > driver detaches. This patch uses devm_ioremap_resource for data > that is allocated in the probe function of a platform device and > is only freed in the remove function. The corresp

Re: [PATCH] usb: usb5303: make use of uninitialized err variable

2014-06-11 Thread Geert Uytterhoeven
On Mon, Jun 2, 2014 at 7:45 PM, Emil Goode wrote: > The variable err is not initialized here, this patch uses it > to store an eventual error value from devm_clk_get(). > > Signed-off-by: Emil Goode Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytter

Re: Disable bus's drivers_autoprobe before rootfs has mounted

2014-06-11 Thread Greg KH
On Wed, Jun 11, 2014 at 11:23:23AM +0800, Peter Chen wrote: > On Tue, Jun 10, 2014 at 09:10:00PM -0700, Greg KH wrote: > > On Wed, Jun 11, 2014 at 10:14:40AM +0800, Peter Chen wrote: > > > Hi Greg, > > > > > > Currently, we can't disable auto probe function during booting > > > if both device and

[PATCH v2] uhci-platform: use devm_ioremap resource

2014-06-11 Thread Himangi Saraogi
This patch replaces the memory allocation using request_mem_region and the ioremap by a single call to managed interface devm_ioremap_reource. The corresponding calls to release_mem_region and iounmap in the probe and release functions are now unnecessary and are removed. Also a label is done away

Re: Disable bus's drivers_autoprobe before rootfs has mounted

2014-06-11 Thread Alan Stern
On Wed, 11 Jun 2014, Greg KH wrote: > We can't break existing systems, so I don't understand the issue here. > Just don't configure your kernel for a system you don't have / want, > right? > > > > > From what I read code, we can't implement above feature, but I may > > > > be wrong, if you have s

Re: [PATCH v2] uhci-platform: use devm_ioremap resource

2014-06-11 Thread Alan Stern
On Thu, 12 Jun 2014, Himangi Saraogi wrote: > This patch replaces the memory allocation using request_mem_region and > the ioremap by a single call to managed interface devm_ioremap_reource. > The corresponding calls to release_mem_region and iounmap in the probe > and release functions are now un

Re: Disable bus's drivers_autoprobe before rootfs has mounted

2014-06-11 Thread Felipe Balbi
On Wed, Jun 11, 2014 at 11:29:57AM +0800, Peter Chen wrote: > On Tue, Jun 10, 2014 at 11:35:07PM -0500, Felipe Balbi wrote: > > Hi, > > > > On Tue, Jun 10, 2014 at 09:10:00PM -0700, Greg KH wrote: > > > > Let's take USB peripheral as an example, there is a device for > > > > udc, and a device driv

Re: [PATCH v2] uhci-platform: use devm_ioremap resource

2014-06-11 Thread Julia Lawall
> > v2: pass correct arguments to devm_ioremap_resource > > Not compile tested due to incompatible architecture. > > uhci-platform is compatible with all architectures. But you have to > add it to the .config file by hand. What should one do exactly? I added CONFIG_USB_UHCI_PLATFORM=y to the e

Re: [PATCH v2] uhci-platform: use devm_ioremap resource

2014-06-11 Thread Alan Stern
On Wed, 11 Jun 2014, Julia Lawall wrote: > > > v2: pass correct arguments to devm_ioremap_resource > > > Not compile tested due to incompatible architecture. > > > > uhci-platform is compatible with all architectures. But you have to > > add it to the .config file by hand. > > What should one do

Re: [PATCH v2] uhci-platform: use devm_ioremap resource

2014-06-11 Thread Julia Lawall
On Wed, 11 Jun 2014, Alan Stern wrote: > On Wed, 11 Jun 2014, Julia Lawall wrote: > > > > > v2: pass correct arguments to devm_ioremap_resource > > > > Not compile tested due to incompatible architecture. > > > > > > uhci-platform is compatible with all architectures. But you have to > > > add it

Re: [patch net-next 3/5] ipv6: consider net.ipv6.conf.all sysctls when making decisions

2014-06-11 Thread David Miller
From: Milos Vyletel Date: Tue, 10 Jun 2014 13:49:35 -0400 > On Tue, Jun 10, 2014 at 1:13 PM, Stephen Hemminger > wrote: >> On Tue, 10 Jun 2014 12:19:11 -0400 >> Milos Vyletel wrote: >> >>> As it is right now net.ipv6.conf.all.* are mostly ignored and instead >>> we're only making decisions base

[PATCH v4] leds: USB: HID: Add support for MSI GT683R led panels

2014-06-11 Thread Janne Kanniainen
This driver adds support for USB controlled led panels that exists in MSI GT683R laptop Signed-off-by: Janne Kanniainen --- Changes in v2: - sorted headers to alphabetic order - using devm_kzalloc - using BIT(n) - using usb_control_msg instead of usb_submit_urb

Re: [PATCH 1/1] xhci: clear root port wake on bits if controller isn't wake-up capable

2014-06-11 Thread baolu
On 06/11/2014 11:26 PM, Greg Kroah-Hartman wrote: On Wed, Jun 11, 2014 at 06:25:20AM +0800, Lu Baolu wrote: When the xHCI PCI host is suspended, if do_wakeup is false in xhci_pci_suspend, xhci_bus_suspend needs to clear all root port wake on bits. Otherwise some Intel platform may get a spuriou

Proposal.

2014-06-11 Thread Gogna
I have a proposal for you. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 1/2] usb: ehci-exynos: Make provision for vdd regulators

2014-06-11 Thread Jingoo Han
On Thursday, June 12, 2014 12:39 AM, Alan Stern wrote: > On Fri, 6 Jun 2014, Vivek Gautam wrote: > > > Facilitate getting required 3.3V and 1.0V VDD supply for > > EHCI controller on Exynos. > > > > With patches for regulators' nodes merged in 3.15: > > c8c253f ARM: dts: Add regulator entries to s

Re: [PATCH v3] usb: host: uhci-grlib.c : use devm_ functions

2014-06-11 Thread Andreas Larsson
On 2014-06-11 20:38, Himangi Saraogi wrote: The various devm_ functions allocate memory that is released when a driver detaches. This patch uses devm_ioremap_resource for data that is allocated in the probe function of a platform device and is only freed in the remove function. The corresponding