[PATCH] usb: dwc3: gadget: remove unnecessary 'start_new' variable

2014-07-03 Thread Jingoo Han
Remove 'start_new' variable from dwc3_endpoint_transfer_complete(), since this variable has not been used. Signed-off-by: Jingoo Han --- drivers/usb/dwc3/gadget.c |7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c i

Re: [PATCH 1/1] usb: gadget: f_uac2: Fix pcm sample size selection

2014-07-03 Thread Takashi Iwai
At Thu, 3 Jul 2014 20:15:28 +0200, Sebastian Reimers wrote: > > The pcm playback and capture sample size format was fixed > SNDRV_PCM_FMTBIT_S16_LE. > > This patch respects also 16, 24 and 32 bit p_ssize and c_ssize values. > > Signed-off-by: Sebastian Reimers In general, this driver should c

RE: Chipidea gadget unplug/disconnect event

2014-07-03 Thread Peter Chen
> > > > > > > Yes, it has already implemented at ci_usc_vbus_session. > > > > > I see the code path in ci_udc_vbus_session of udc.c to trigger such > > > an event, but unfortunately it was never possible to run into that > code. > > > > > > The function ci_otg_work in otg.c is prepared to do that

[PATCH v2 0/4] Tegra USB probe order issue fix

2014-07-03 Thread Tuomas Tynkkynen
Hi all, Here's a second version of the probe order issue series. This time I've added the USB1 resets to the PHYs, thus replacing the really ugly parts with something slightly better. Old device trees will still probe successfully, but instead of this bugfix they'll get a dev_warn(). The reset co

[PATCH v2 3/4] USB: EHCI: tegra: Fix probe order issue leading to broken USB

2014-07-03 Thread Tuomas Tynkkynen
The Tegra USB complex has a particularly annoying misdesign: some of the UTMI pad configuration registers are global for all the 3 USB controllers on the chip, but those registers are located in the first controller's register space and will be cleared when the reset to the first controller is asse

[PATCH v2 4/4] USB: PHY: tegra: Call tegra_usb_phy_close only on device removal

2014-07-03 Thread Tuomas Tynkkynen
tegra_usb_phy_close() is supposed to undo the effects of tegra_usb_phy_init(). It is also currently added as the USB PHY shutdown callback, which is wrong, since tegra_usb_phy_init() is only called during probing wheras the shutdown callback can get called multiple times. This then leads to warning

[PATCH v2 2/4] ARM: tegra: Add resets & has-utmi-pad-registers flag to all USB PHYs

2014-07-03 Thread Tuomas Tynkkynen
Add new properties to all of the Tegra PHYs that are now required according to the binding. In order to stay compatible with old device trees, the USB drivers will still function without these reset properties but with the old, potentially buggy behaviour. Signed-off-by: Tuomas Tynkkynen --- v2

[PATCH v2 1/4] USB: tegra: Add resets & has-utmi-pad-registers flag to the PHY binding

2014-07-03 Thread Tuomas Tynkkynen
When Tegra was converted to use the standard reset bindings, the PHY was forgotten, probably because all the resetting of the USB blocks were done in the EHCI driver. What also went unnoticed is that resetting the 1st on-chip USB module also wipes some of the UTMI pad configuration registers that a

[GIT PULL] USB driver fixes for 3.16-rc4

2014-07-03 Thread Greg KH
The following changes since commit a497c3ba1d97fc69c1e78e7b96435ba8c2cb42ee: Linux 3.16-rc2 (2014-06-21 19:02:54 -1000) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/ tags/usb-3.16-rc4 for you to fetch changes up to e4adcff09ca39ecbcc4

Re: [PATCH 2/4] usb: host: xhci-plat: Add support to get PHYs

2014-07-03 Thread Sergei Shtylyov
Hello. On 06/25/2014 12:44 PM, Vivek Gautam wrote: diff --git a/drivers/usb/host/xhci.h b/drivers/usb/host/xhci.h index 9ffecd5..453d89e 100644 --- a/drivers/usb/host/xhci.h +++ b/drivers/usb/host/xhci.h @@ -1582,6 +1582,9 @@ struct xhci_hcd { u32 port_status_u0;

Re: [PATCH 0/2] USB: make HCD specific allocations non-atomically

2014-07-03 Thread Alan Stern
On Thu, 3 Jul 2014, Vladimir Zapolskiy wrote: > This change makes two more one-time per HCD allocations to be done > from non-atomic DMA pool, the main purpose of the change is to save > some bits of space in coherent atomic DMA pool, which is 256KB by > default on ARM platform. > > Vladimir Zapo

[PATCH 2/2] USB: UHCI: don't allocate frame list atomically

2014-07-03 Thread Vladimir Zapolskiy
uhci_start() is executed one time during usb_add_hcd() call and by default UHCI frame list is allocated from atomic DMA pool. Do non-atomic allocation of uhci->frame and free some space in coherent atomic DMA pool. Cc: Alan Stern Cc: Greg Kroah-Hartman Signed-off-by: Vladimir Zapolskiy --- dr

[PATCH 1/2] USB: OHCI: don't allocate HCCA atomically

2014-07-03 Thread Vladimir Zapolskiy
OHCI HCCA memory region is allocated from atomic DMA pool one time during usb_add_hcd() and deallocated by usb_remove_hcd(). Do non-atomic allocation of OHCI HCCA and free some space in coherent atomic DMA pool. Cc: Alan Stern Cc: Greg Kroah-Hartman Signed-off-by: Vladimir Zapolskiy --- drive

[PATCH 0/2] USB: make HCD specific allocations non-atomically

2014-07-03 Thread Vladimir Zapolskiy
This change makes two more one-time per HCD allocations to be done from non-atomic DMA pool, the main purpose of the change is to save some bits of space in coherent atomic DMA pool, which is 256KB by default on ARM platform. Vladimir Zapolskiy (2): USB: OHCI: don't allocate HCCA atomically US

Re: [PATCH] USB: EHCI: don't allocate hardware periodic table atomically by default

2014-07-03 Thread Vladimir Zapolskiy
On 03.07.2014 19:38, Alan Stern wrote: On Thu, 3 Jul 2014, Vladimir Zapolskiy wrote: ehci_mem_init() is executed one time during ehci_init() and by default all memory allocations but ehci->periodic are done not atomically, GFP_KERNEL is passed as flags parameter. Do similar allocation for ehci

Re: [PATCH 2/2 v6] HID: gt683r: move mode attribute to led-class devices

2014-07-03 Thread Janne Kanniainen
2014-07-03 21:17 GMT+03:00 Bryan Wu : > On Thu, Jul 3, 2014 at 10:40 AM, Johan Hovold wrote: >> On Thu, Jul 03, 2014 at 08:17:09PM +0300, Janne Kanniainen wrote: >>> Move led_mode attribute from HID device to led-class devices and rename >>> it msi_mode. This will also fix race condition by using

Re: [PATCH 2/2 v6] HID: gt683r: move mode attribute to led-class devices

2014-07-03 Thread Bryan Wu
On Thu, Jul 3, 2014 at 10:40 AM, Johan Hovold wrote: > On Thu, Jul 03, 2014 at 08:17:09PM +0300, Janne Kanniainen wrote: >> Move led_mode attribute from HID device to led-class devices and rename >> it msi_mode. This will also fix race condition by using > > There's a typo here (s/msi_mode/mode) b

[PATCH 1/1] usb: gadget: f_uac2: Fix pcm sample size selection

2014-07-03 Thread Sebastian Reimers
The pcm playback and capture sample size format was fixed SNDRV_PCM_FMTBIT_S16_LE. This patch respects also 16, 24 and 32 bit p_ssize and c_ssize values. Signed-off-by: Sebastian Reimers --- drivers/usb/gadget/f_uac2.c | 24 ++-- 1 file changed, 22 insertions(+), 2 deletions

Re: [PATCH 1/2 v6] HID: gt683r: fix race condition

2014-07-03 Thread Bryan Wu
On Thu, Jul 3, 2014 at 10:34 AM, Johan Hovold wrote: > On Thu, Jul 03, 2014 at 08:17:08PM +0300, Janne Kanniainen wrote: >> This will fix race condition noticed by Oliver Neukum. Sysfs files are >> created before mutex and work are initialized. >> >> Signed-off-by: Janne Kanniainen > > Reviewed-b

Re: Chipidea gadget unplug/disconnect event

2014-07-03 Thread Michael Grzeschik
Hi Fabio, On Thu, Jul 03, 2014 at 02:04:07PM -0300, Fabio Estevam wrote: > Hi Michael, > > On Thu, Jul 3, 2014 at 1:06 PM, Michael Grzeschik wrote: > > > I validated this with two different imx25 boards and realized, > > that we have this external vbus divider errata for that SoC. > > > > Errat

Re: [PATCH 2/2 v6] HID: gt683r: move mode attribute to led-class devices

2014-07-03 Thread Johan Hovold
On Thu, Jul 03, 2014 at 08:17:09PM +0300, Janne Kanniainen wrote: > Move led_mode attribute from HID device to led-class devices and rename > it msi_mode. This will also fix race condition by using There's a typo here (s/msi_mode/mode) but perhaps Bryan can just fix that up before applying? > att

Re: [PATCH 1/2 v6] HID: gt683r: fix race condition

2014-07-03 Thread Johan Hovold
On Thu, Jul 03, 2014 at 08:17:08PM +0300, Janne Kanniainen wrote: > This will fix race condition noticed by Oliver Neukum. Sysfs files are > created before mutex and work are initialized. > > Signed-off-by: Janne Kanniainen Reviewed-by: Johan Hovold > --- > drivers/hid/hid-gt683r.c | 6 +++---

[PATCH 2/2 v6] HID: gt683r: move mode attribute to led-class devices

2014-07-03 Thread Janne Kanniainen
Move led_mode attribute from HID device to led-class devices and rename it msi_mode. This will also fix race condition by using attribute-groups. Signed-off-by: Janne Kanniainen --- Changes in v3: - Style fixes - Rename sysfs-class-hid-driver-gt683r to sysfs-class-leds-driver-gt6

[PATCH 1/2 v6] HID: gt683r: fix race condition

2014-07-03 Thread Janne Kanniainen
This will fix race condition noticed by Oliver Neukum. Sysfs files are created before mutex and work are initialized. Signed-off-by: Janne Kanniainen --- drivers/hid/hid-gt683r.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/hid/hid-gt683r.c b/drivers/hid/hid-

Re: Chipidea gadget unplug/disconnect event

2014-07-03 Thread Fabio Estevam
Hi Michael, On Thu, Jul 3, 2014 at 1:06 PM, Michael Grzeschik wrote: > I validated this with two different imx25 boards and realized, > that we have this external vbus divider errata for that SoC. > > Errata: ENGcm09152 > > Its likely that the issue is related to this problem as the vbus was > n

Re: Possible bug in xhci-ring.c

2014-07-03 Thread Maciej Puzio
Julius, I finally managed to generate some sensible (I hope) logs. The kernel is 3.2.60-rc3 with modifications as you requested. http://pastebin.com/6as4beZ3 This is an excerpt from syslog, showing messages logged immediately after a USB3 device (Areca ARC-5040) was plugged in. The OS was booted w

Re: [PATCH 5/6] phy: omap-usb2: Balance pm_runtime_enable() on probe failure

2014-07-03 Thread Roger Quadros
On 07/03/2014 04:31 PM, Kishon Vijay Abraham I wrote: > Hi Roger, > > On Wednesday 02 July 2014 05:33 PM, Roger Quadros wrote: >> If probe fails then we need to call pm_runtime_disable() to balance >> out the previous pm_runtime_enable() call. Else it will cause >> unbalanced pm_runtime_enable() c

Re: [PATCH] USB: EHCI: don't allocate hardware periodic table atomically by default

2014-07-03 Thread Alan Stern
On Thu, 3 Jul 2014, Vladimir Zapolskiy wrote: > ehci_mem_init() is executed one time during ehci_init() and by default > all memory allocations but ehci->periodic are done not atomically, > GFP_KERNEL is passed as flags parameter. > > Do similar allocation for ehci->periodic and free some space i

Re: Chipidea gadget unplug/disconnect event

2014-07-03 Thread Michael Grzeschik
On Thu, Jul 03, 2014 at 01:19:21AM +, Peter Chen wrote: > > > > > Is it possible to get the chipidea to generate an event on udc unplugging? > > > > Yes, it has already implemented at ci_usc_vbus_session. > > > I see the code path in ci_udc_vbus_session of udc.c to trigger such an > > eve

[PATCH] USB: EHCI: don't allocate hardware periodic table atomically by default

2014-07-03 Thread Vladimir Zapolskiy
ehci_mem_init() is executed one time during ehci_init() and by default all memory allocations but ehci->periodic are done not atomically, GFP_KERNEL is passed as flags parameter. Do similar allocation for ehci->periodic and free some space in coherent atomic DMA pool by default. Cc: Alan Stern C

Re: [PATCH 0/6] usb: gadget: Delete __init marker for probe

2014-07-03 Thread Felipe Balbi
On Tue, Jul 01, 2014 at 04:50:21AM +, Peter Chen wrote: > > > On Sun, May 18, 2014 at 03:19:01PM +0800, Peter Chen wrote: > > > The probe function may be probed deferal and called after .init > > > section has freed. > > > > > > Peter Chen (6): > > > usb: gadget: atmel_usba_udc: delete __in

Re: USB keyboard on T100TA dock blocks system entering S3 when remote wakeup is enabled

2014-07-03 Thread Alan Stern
On Thu, 3 Jul 2014, Lu, Baolu wrote: > Hi, > > I am using an ASUS T100TA with dock attached. I installed Ubuntu Linux > on eMMC and customized the kernel. > > I started from "echo mem > /sys/power/state". Kernel starts its > processes to put the system into suspend mode. Before kernel executes

Re: [PATCH][RFC] USB: zerocopy support for usbfs

2014-07-03 Thread Alan Stern
On Thu, 3 Jul 2014, Stefan Klug wrote: > >> Questions/Notes: > >> - I'm quite unhappy with the added member async::is_user_mem. Is there a > >> better place > >> where I could store this information? > > No, async is the right place. Why are you unhappy about it? > A whole byte for this flag

Re: [PATCH 5/6] phy: omap-usb2: Balance pm_runtime_enable() on probe failure

2014-07-03 Thread Kishon Vijay Abraham I
Hi Roger, On Wednesday 02 July 2014 05:33 PM, Roger Quadros wrote: > If probe fails then we need to call pm_runtime_disable() to balance > out the previous pm_runtime_enable() call. Else it will cause > unbalanced pm_runtime_enable() call in the succeding probe call. > > This anomaly was observed

Re: Problem with Mobile Broadband on ubuntu

2014-07-03 Thread Oliver Neukum
On Thu, 2014-07-03 at 18:19 +0530, arun wrote: > Hello, > I am on Ubuntu 12.04, and am trying to install a USB dongle with a > 3-g simcard. I have D-link 156 dongle. > > I do the following 2: > - dpkg -i .deb > - usb_modeswitch ... > > after this, i am not able to locate the driver in Net

Problem with Mobile Broadband on ubuntu

2014-07-03 Thread arun
Hello, I am on Ubuntu 12.04, and am trying to install a USB dongle with a 3-g simcard. I have D-link 156 dongle. I do the following 2: - dpkg -i .deb - usb_modeswitch ... after this, i am not able to locate the driver in Network Manager. If i do dmesg, it says: usbserial_generic 1-1.3:1.

Re: usbfs could not found

2014-07-03 Thread Peter Stuge
Hi Niyazi, Niyazi Sırt wrote: > I had kernel-3.4.52, libusb-0.1.12 and usbutils-0.71 > on my centos and lsusb command was working properly. > After I upgraded kernel-3.14.9 and also upgraded > libusb-static-1.0.9, libusb-1.0.9, libusb-devel-1.0.9 > and usbutils-006 rpm packages, lsusb command stop

usbfs could not found

2014-07-03 Thread Niyazi Sırt
Hi, I had kernel-3.4.52, libusb-0.1.12 and usbutils-0.71 on my centos and lsusb command was working properly. After I upgraded kernel-3.14.9 and also upgraded libusb-static-1.0.9, libusb-1.0.9, libusb-devel-1.0.9 and usbutils-006 rpm packages, lsusb command stopped working and I started getting a

Re: [PATCH v3 5/7] ARM: DRA7: hwmod: Add SYSCONFIG for usb_otg_ss

2014-07-03 Thread Sekhar Nori
On Wednesday 02 July 2014 04:56 PM, Roger Quadros wrote: > Sekhar, > > On 06/18/2014 02:19 PM, Rajendra Nayak wrote: >> On Wednesday 18 June 2014 04:40 PM, Roger Quadros wrote: >>> + Nishant and Rajendra for review. >>> >>> On 05/05/2014 12:54 PM, Roger Quadros wrote: Add the sysconfig class

USB keyboard on T100TA dock blocks system entering S3 when remote wakeup is enabled

2014-07-03 Thread Lu, Baolu
Hi, I am using an ASUS T100TA with dock attached. I installed Ubuntu Linux on eMMC and customized the kernel. I started from "echo mem > /sys/power/state". Kernel starts its processes to put the system into suspend mode. Before kernel executes to xhci_bus_suspend(), xHC USB 2 root hub port (

[PATCH v2 3/6] phy: core: Support regulator supply for PHY power

2014-07-03 Thread Roger Quadros
From: Roger Quadros Some PHYs can be powered by an external power regulator. e.g. USB_HS PHY on DRA7 SoC. Make the PHY core support a power regulator. Signed-off-by: Roger Quadros --- drivers/phy/phy-core.c | 27 +++ include/linux/phy/phy.h | 2 ++ 2 files changed, 29

[PATCH v2 1/6] ARM: dts: dra7-evm: Make VDDA_1V8_PHY supply always on

2014-07-03 Thread Roger Quadros
From: Roger Quadros After clarification from the hardware team it was found that this 1.8V PHY supply can't be switched OFF when SoC is Active. Since the PHY IPs don't contain isolation logic built in the design to allow the power rail to be switched off, there is a very high risk of IP reliabil

Re:Re:Re: Re: Re:Re: move ZTE CDMA device pid from zte_ev.c back to option.c and modify a parameter in zte_ev.ko

2014-07-03 Thread 刘磊
Dear johan&Williams As we discuss about the question of zte_ev.c, are you sure how to modify. Looking forward to your reply. thanks. lei.liu At 2014-06-25 04:35:28, "刘磊" wrote: > > >At 2014-06-24 09:46:01, "Johan Hovold" wrote: >>On Tue, Jun 24, 2014 at 08:43:36PM +0800, 刘磊 wrote: >>> A

RE: [PATCH][RFC] USB: zerocopy support for usbfs

2014-07-03 Thread David Laight
From: Stefan Klug ... > Is there any way to check if the host controller supports arbitrary > alignment? > If I read the xhci spec correctly arbitrary alignment is explicitly > permitted. Not entirely. The xhci spec has a few limits on the alignment of transfer buffer. They seem to be designed to

Re: [PATCH 2/2 v5] HID: leds: move led_mode attribute to led-class devices in MSI GT683R driver

2014-07-03 Thread Johan Hovold
On Wed, Jul 02, 2014 at 08:37:59PM +0300, Janne Kanniainen wrote: > Move led_mode attribute from HID device to led-class devices. This will also > fix race condition by using attribute-groups. > > Signed-off-by: Janne Kanniainen Looks good now. Thanks! Perhaps you can resend both patches as a

Re: [PATCH][RFC] USB: zerocopy support for usbfs

2014-07-03 Thread Stefan Klug
On 02.07.2014 21:38, Alan Stern wrote: On Wed, 2 Jul 2014, Oliver Neukum wrote: Stefan Klug Software Developer Basler AG An der Strusbek 60-62 22926 Ahrensburg Germany Tel. +49 4102 463 582 Fax +49 4102 463 46 582 stefan.k...@baslerweb.com www.baslerweb.com Vorstand: Dr.-Ing. Dietmar Le

Re: [PATCH 3/6] phy: core: Support regulator supply for PHY power

2014-07-03 Thread Roger Quadros
On 07/02/2014 03:32 PM, Sergei Shtylyov wrote: > Hello. > > On 07/02/2014 04:03 PM, Roger Quadros wrote: > >> Some PHYs can be powered by an external power regulator. >> e.g. USB_HS PHY on DRA7 SoC. Make the PHY core support a >> power regulator. > >> Signed-off-by: Roger Quadros >> --- >> dr

Re: [PATCH][RFC] USB: zerocopy support for usbfs

2014-07-03 Thread Stefan Klug
On 02.07.2014 20:24, Alan Stern wrote: Overall this implementation seems quite straightforward. However, it appears that your email client has mangled the whitespace in the patch. The patch contains many style violations; you should run it through checkpatch.pl. It also has one or two mistake

Re: [PATCH][RFC] USB: zerocopy support for usbfs

2014-07-03 Thread Stefan Klug
On 02.07.2014 19:55, Greg KH wrote: Very nice. Thanks. Minor non-technical issues here, your patch is corrupted (linewrapped and tabs converted to spaces) and can't be applied at all. Can you fix your email client and try again? Look at Documentation/email_clients.txt for hints on how to do