[PATCH v7] usb:serial:pl2303: add GPIOs interface on PL2303

2014-08-08 Thread Wang YanQing
PL2303 USB Serial devices always has GPIOs, this patch add generic gpio support interfaces for pl2303 USB Serial devices in pl2303_type_data and pl2303_serial_private, then use them to add GPIOs support for one type of them, PL2303HXA. Known issue: If gpios are in use(export to userspace through s

Re: [PATCH 0/3] usbip: move usbip out of staging

2014-08-08 Thread Valentina Manea
On Thu, Aug 7, 2014 at 1:16 PM, Greg KH wrote: > > The top of the MAINTAINERS should have this information, look in the S: > Status section about what type of category you are in. > > Basically I'd like you to be the one to handle patches that are sent in > for the code, just by reviewing them, yo

Re: [oss-security] BadUSB discussion

2014-08-08 Thread Alan Stern
On Sat, 9 Aug 2014, Yves-Alexis Perez wrote: > On ven., 2014-08-08 at 18:26 -0400, Alan Stern wrote: > > I'm not sure what you mean. You can toggle these values at any time, > > but toggling them may not accomplish anything useful. What do you > > want > > to accomplish? > > The point would b

Re: [oss-security] BadUSB discussion

2014-08-08 Thread Yves-Alexis Perez
On ven., 2014-08-08 at 18:26 -0400, Alan Stern wrote: > I'm not sure what you mean. You can toggle these values at any time, > but toggling them may not accomplish anything useful. What do you > want > to accomplish? The point would be to prevent new usb device to be plugged while a system is

Re: [oss-security] BadUSB discussion

2014-08-08 Thread Alan Stern
On Sat, 9 Aug 2014, Yves-Alexis Perez wrote: > On ven., 2014-08-08 at 18:17 -0400, Alan Stern wrote: > > The authorized_default module parameter affects USB buses when they > > are > > discovered and registered; after that it has no effect. Therefore to > > accomplish what you want, you need to p

Re: [oss-security] BadUSB discussion

2014-08-08 Thread Yves-Alexis Perez
On ven., 2014-08-08 at 18:17 -0400, Alan Stern wrote: > The authorized_default module parameter affects USB buses when they > are > discovered and registered; after that it has no effect. Therefore to > accomplish what you want, you need to put > "usbcore.authorized_default=0" in the kernel's boot

Re: [oss-security] BadUSB discussion

2014-08-08 Thread Alan Stern
On Fri, 8 Aug 2014, Yves-Alexis Perez wrote: > On ven., 2014-08-08 at 14:36 -0700, Greg KH wrote: > > On Fri, Aug 08, 2014 at 11:27:06PM +0200, Yves-Alexis Perez wrote: > > > On ven., 2014-08-08 at 14:20 -0700, Greg KH wrote: > > > > > Actually, since it's a module parameter, it doesn't seem possi

Re: [oss-security] BadUSB discussion

2014-08-08 Thread Yves-Alexis Perez
On ven., 2014-08-08 at 14:36 -0700, Greg KH wrote: > On Fri, Aug 08, 2014 at 11:27:06PM +0200, Yves-Alexis Perez wrote: > > On ven., 2014-08-08 at 14:20 -0700, Greg KH wrote: > > > > Actually, since it's a module parameter, it doesn't seem possible to > > > > toggle it without reloading the module

[PATCHv3 08/12] usb: dwc2: gadget: Do not fail probe if there isn't a clock node

2014-08-08 Thread dinguyen
From: Dinh Nguyen Since the dwc2 hcd driver is currently not looking for a clock node during init, we should not completely fail if there isn't a clock provided. Add a check for a valid clock before calling clock functions. Signed-off-by: Dinh Nguyen --- drivers/usb/dwc2/gadget.c | 36

[PATCHv3 09/12] usb: dwc2: initialize the spin_lock for both host and gadget

2014-08-08 Thread dinguyen
From: Dinh Nguyen Move spin_lock_init to common location for both host and gadget. Signed-off-by: Dinh Nguyen --- drivers/usb/dwc2/hcd.c | 1 - drivers/usb/dwc2/platform.c | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c i

[PATCHv3 03/12] usb: dwc2: Update the gadget driver to use common dwc2_hsotg structure

2014-08-08 Thread dinguyen
From: Dinh Nguyen Adds the gadget data structure and appropriate data structure pointers to the common dwc2_hsotg data structure. To keep the driver data dereference code looking clean, the gadget variable declares are only available for peripheral and dual-role mode. This is needed so that the d

[PATCHv3 07/12] usb: dwc2: Add call_gadget functions for perpheral mode interrupts

2014-08-08 Thread dinguyen
From: Dinh Nguyen Update the dwc2 wakeup and suspend interrupt functions to use call_gadget when the IP is in peripheral mode. Signed-off-by: Dinh Nguyen --- drivers/usb/dwc2/core_intr.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/dwc2/core_intr.c b/drivers/usb/dwc2/core_

[PATCHv3 01/12] usb: dwc2: Update Kconfig to support dual-role

2014-08-08 Thread dinguyen
From: Dinh Nguyen Update DWC2 kconfig and makefile to support dual-role mode. The platform file will always get compiled for the case where the controller is directly connected to the CPU. So for loadable modules, only dwc2.ko is needed. Signed-off-by: Dinh Nguyen --- v3: Add USB_GADGET=y and U

[PATCHv3 00/12] usb: dwc2: Add support for dual role

2014-08-08 Thread dinguyen
From: Dinh Nguyen Hello, This is version 3 of the patch series that combines the dwc2 gadget and host driver into a single dual role driver. Here are the main differences from V2: - less code change: v3: 9 files changed, 340 insertions(+), 335 deletions(-) v2: 9 files changed, 3

[PATCHv3 06/12] usb: dwc2: Update common interrupt handler to call gadget interrupt handler

2014-08-08 Thread dinguyen
From: Dinh Nguyen Make dwc2_handle_common_intr call the gadget interrupt function when operating in peripheral mode. Remove the spinlock functions in s3c_hsotg_irq as dwc2_handle_common_intr() already has the spinlocks. Remove duplicate interrupt conditions that was in gadget, as those are handl

[PATCHv3 04/12] usb: dwc2: Add the appropriate init calls in platform code

2014-08-08 Thread dinguyen
From: Dinh Nguyen Add the proper init calls for either host, gadget or both in platform.c Signed-off-by: Dinh Nguyen --- drivers/usb/dwc2/core.h | 13 + drivers/usb/dwc2/gadget.c | 2 +- drivers/usb/dwc2/platform.c | 28 3 files changed, 38 inser

[PATCHv3 10/12] usb: dwc2: Add suspend/resume for gadget

2014-08-08 Thread dinguyen
From: Dinh Nguyen Move suspend/resume code to common platform code. Signed-off-by: Dinh Nguyen --- drivers/usb/dwc2/core.h | 6 ++ drivers/usb/dwc2/gadget.c | 4 ++-- drivers/usb/dwc2/platform.c | 23 +++ 3 files changed, 31 insertions(+), 2 deletions(-) diff -

[PATCHv3 02/12] usb: dwc2: move "samsung,s3c6400-hsotg" into common platform

2014-08-08 Thread dinguyen
From: Dinh Nguyen Move the "samsung,s3c6400-hsotg" binding as the probe function in the gadget driver will get removed when the dual-role driver is implemented. Signed-off-by: Dinh Nguyen --- drivers/usb/dwc2/gadget.c | 1 - drivers/usb/dwc2/platform.c | 1 + 2 files changed, 1 insertion(+),

[PATCHv3 05/12] usb: dwc2: Initialize the USB core for peripheral mode

2014-08-08 Thread dinguyen
From: Dinh Nguyen Initialize the USB driver to peripheral mode when a B-Device connector is attached. Signed-off-by: Dinh Nguyen --- drivers/usb/dwc2/hcd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c index 4d918ed..07a7bcd 100644 --- a/dr

[PATCHv3 12/12] usb: dwc2: pci: Update pci portion of the dwc2 driver

2014-08-08 Thread dinguyen
From: Dinh Nguyen Initialize the spinlock here as the original spinlock in the host driver has been removed. Signed-off-by: Dinh Nguyen --- drivers/usb/dwc2/pci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/dwc2/pci.c b/drivers/usb/dwc2/pci.c index c291fca..faacac9 100644 -

[PATCHv3 11/12] usb: dwc2: check that the host work queue is valid

2014-08-08 Thread dinguyen
From: Dinh Nguyen The Host workqueue will not get initialized if the driver is configured for peripheral mode only. Thus we need to check for wq_otg before calling queue_work(). Signed-off-by: Dinh Nguyen --- drivers/usb/dwc2/core_intr.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletio

Re: Resend Re: [PATCH v6] usb:serial:pl2303: add GPIOs interface on PL2303

2014-08-08 Thread Wang YanQing
On Fri, Aug 08, 2014 at 09:54:42AM +0200, Johan Hovold wrote: > On Fri, Aug 08, 2014 at 03:10:34AM +0800, Wang YanQing wrote: > > On Tue, Aug 05, 2014 at 03:54:08PM +0200, Johan Hovold wrote: > > > > > I noticed that setting direction to output and setting the gpio high > > > > > has > > > > > no

Re: [PATCH v5 2/4] usb: dwc2: add compatible data for rockchip soc

2014-08-08 Thread Doug Anderson
Kever On Thu, Aug 7, 2014 at 8:55 PM, Kever Yang wrote: > This patch add compatible data for dwc2 controller found on > rk3066, rk3188 and rk3288 processors from rockchip. > > Signed-off-by: Kever Yang > Acked-by: Paul Zimmerman > --- > > Changes in v5: > - max_transfer_size change to 65535 to

[PATCH v2 0/3] usb: gadget/uvc: simple fixes and ENUM_FMT

2014-08-08 Thread Michael Grzeschik
This series fixes a possible lock in the uvc-gadget. It also adds ENUM_FMT to the v4l2 ioctl list. This way it will be possible to use gstreamer with it. At last we increase isoc requests in flight. Cheers, Michael Michael Grzeschik (3): usb: gadget/uvc: fix possible lockup in uvc gadget usb:

[PATCH v2 3/3] usb: gadget/uvc: bump isoc requests from 4 to 16

2014-08-08 Thread Michael Grzeschik
While sending bigger images it is better to use more isochronous requests in flight. This patch bumps the default from 4 to 16. Signed-off-by: Michael Grzeschik --- drivers/usb/gadget/uvc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/uvc.h b/drivers/usb

[PATCH v2 2/3] usb: gadget/uvc: also handle v4l2 ioctl ENUM_FMT

2014-08-08 Thread Michael Grzeschik
This patch adds ENUM_FMT as possible ioctl to the uvc v4l2 device. That makes userspace applications with a generic IOCTL calling convention make also use of it. Signed-off-by: Michael Grzeschik --- v1 -> v2: - changed first switch case to simple if - added separate function - added descriptio

[PATCH v2 1/3] usb: gadget/uvc: fix possible lockup in uvc gadget

2014-08-08 Thread Michael Grzeschik
If the pending buffers in the queue could not be pushed to the udc endpoint we have to cancel the uvc_queue. Otherwise the gadget will get stuck on this error. This patch calls uvc_queue_cancel if usb_ep_queue failed. Signed-off-by: Michael Grzeschik --- v1 -> v2: - moved uvc_queue_cancel outsid

Re: [PATCHv2 07/13] usb: dwc2: Update common interrupt handler to call gadget interrupt handler

2014-08-08 Thread Dinh Nguyen
On Wed, Jul 30, 2014 at 1:38 PM, Paul Zimmerman wrote: >> From: linux-usb-ow...@vger.kernel.org >> [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of dingu...@altera.com >> Sent: Wednesday, July 30, 2014 8:21 AM >> >> Make dwc2_handle_common_intr call the gadget interrupt function when >> ope

CONFIDENTIAL

2014-08-08 Thread Google Incorporation®
Dear Google User, Attached to this e-mail is your official Google User Reward Promotion notification for being an active user of Google Services. Best Regards, Larry Page Chairman Google UK. ©2014 Google Incorporation® -- To unsubscribe from this list: send the line "unsubscribe linux-usb" i

Re: [PATCH v4] usb: gadget: at91_udc: move prepare clk into process context

2014-08-08 Thread Alexandre Belloni
On 08/08/2014 at 11:42:42 +0200, Ronald Wahl wrote : > Commit 7628083227b6bc4a7e33d7c381d7a4e558424b6b (usb: gadget: at91_udc: > prepare clk before calling enable) added clock preparation in interrupt > context. This is not allowed as it might sleep. Also setting the clock > rate is unsafe to call

Re: Backslash repeat bug

2014-08-08 Thread Fredrik Hallenberg
Thanks, I will try that list. On Fri, Aug 8, 2014 at 3:29 PM, Greg KH wrote: > On Fri, Aug 08, 2014 at 11:15:00AM +0200, Fredrik Hallenberg wrote: >> Hi, >> >> On my Corsair K70 keyboard, when pressing some key and then the backslash >> key (KEY_BACKSLASH) in rapid succession the backslash charac

Re: Backslash repeat bug

2014-08-08 Thread Greg KH
On Fri, Aug 08, 2014 at 11:15:00AM +0200, Fredrik Hallenberg wrote: > Hi, > > On my Corsair K70 keyboard, when pressing some key and then the backslash > key (KEY_BACKSLASH) in rapid succession the backslash character will be > repeated three times. > > This bug is discussed on the Corsair forums

Re: Re: Re: Re: driver option create ttyUSB

2014-08-08 Thread Greg KH
A: http://en.wikipedia.org/wiki/Top_post Q: Were do I find info about this thing called top-posting? A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I inclu

[RFC PATCH] Revert "usb: chipidea: udc: .pullup is valid only when vbus is there"

2014-08-08 Thread Michael Grzeschik
This reverts commit 4a64783b66bbeed06a1f10ab56a1dd401dd5bfba. --- Hello Peter, I have seen this call is still returning EOPNOTSUPP which is also returned by usb_gadget_connect and usb_gadget_disconnect if the pullup function is not available. Should it not handle that case somehow special? Is i

Re: 3.15.8 USB issue with uvc cam

2014-08-08 Thread Udo van den Heuvel
On 2014-08-08 13:24, Udo van den Heuvel wrote: > unexpected command > completion code 0x11 Is bug https://bugzilla.kernel.org/show_bug.cgi?id=70531 relevant here? Kind regards, Udo -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.k

Re: 3.15.8 USB issue with uvc cam

2014-08-08 Thread Udo van den Heuvel
Hello, The Logitech C615 works OK if moved away from a USB3 port into a non-USB3 port. So it appears a USB3 issue. Is 'xhci_hcd :02:00.0: ERROR: unexpected command completion code 0x11' a possible root cause? My board has: # lspci 00:00.0 Host bridge: Advanced Micro Devices, Inc. [AMD] Famil

[PATCH v4] usb: gadget: at91_udc: move prepare clk into process context

2014-08-08 Thread Ronald Wahl
Commit 7628083227b6bc4a7e33d7c381d7a4e558424b6b (usb: gadget: at91_udc: prepare clk before calling enable) added clock preparation in interrupt context. This is not allowed as it might sleep. Also setting the clock rate is unsafe to call from there for the same reason. Move clock preparation and se

Backslash repeat bug

2014-08-08 Thread Fredrik Hallenberg
Hi, On my Corsair K70 keyboard, when pressing some key and then the backslash key (KEY_BACKSLASH) in rapid succession the backslash character will be repeated three times. This bug is discussed on the Corsair forums, and it seems the exact same thing also happens with Gigabyte Osmium and QPAD MK8

Re: [PATCH v2] USB: Register VIA Telecom CDS7 chipset with Option USB serial driver

2014-08-08 Thread Johan Hovold
On Wed, Aug 06, 2014 at 08:46:44AM -0700, Brennan Ashton wrote: > This VIA Telecom baseband processor is used is used by by u-blox in both the > FW2770 and FW2760 products and may be used in others as well. > > This patch has been tested on both of these modem versions. > > Signed-off-by: Brennan

Re: Resend Re: [PATCH v6] usb:serial:pl2303: add GPIOs interface on PL2303

2014-08-08 Thread Johan Hovold
On Fri, Aug 08, 2014 at 03:10:34AM +0800, Wang YanQing wrote: > On Tue, Aug 05, 2014 at 03:54:08PM +0200, Johan Hovold wrote: > > > > I noticed that setting direction to output and setting the gpio high has > > > > no effect on the read-back value (i.e. I still read back 0) for my > > > > pl2303hx

[PATCH 2/2] usb: phy: samsung: Add a _3P5DB suffix for PHYPARAM1_PCS_TXDEEMPH

2014-08-08 Thread Jingoo Han
According to the datasheet, PHYPARAM1_PCS_TXDEEMPH_3P5DB is a correct name. Thus, a _3P5DB suffix for the PHYPARAM1_PCS_TXDEEMPH register bit field definition is added. In addition, PHYPARAM1_PCS_TXDEEMPH_3P5DB(_x) is added in order to keep the same style, as other register bit field definitions a

[PATCH 1/2] usb: phy: samsung: Fix wrong bit mask for PHYPARAM1_PCS_TXDEEMPH

2014-08-08 Thread Jingoo Han
According to the datasheet, PHYPARAM1_PCS_TXDEEMPH is set as 6 bits [5:0]. Thus, the bit mask should be set as 0x3f, instead of 0x1f. Signed-off-by: Jingoo Han --- These patches have a dependency on the patch ([PATCH] usb: phy: samsung: Remove unnecessary lines of register bit definitions). [1]