Re: usb sound cannot get frequency from enpoind

2014-09-12 Thread vichy
hi all: I get the same message on kernel 3.16.0 and attach the device information as well. (from the description, the ep 0x82 did have different sample rate configuration, but why uac cannot get it?) appreciate your help, Interface Descriptor: bLength 9

Re: usb sound cannot get frequency from enpoind

2014-09-12 Thread Clemens Ladisch
vichy wrote: ALSA sound/usb/clock.c:237 2:3:1: cannot get freq at ep 0x82 ALSA sound/usb/mixer.c:929 5:2: cannot get min/max values for control 2 (id 5) ALSA sound/usb/mixer.c:929 5:2: cannot get min/max values for control 2 (id 5) (from the description, the ep 0x82 did have different

Re: usb sound cannot get frequency from enpoind

2014-09-12 Thread vichy
hi Clements: 2014-09-12 14:41 GMT+08:00 Clemens Ladisch clem...@ladisch.de: vichy wrote: ALSA sound/usb/clock.c:237 2:3:1: cannot get freq at ep 0x82 ALSA sound/usb/mixer.c:929 5:2: cannot get min/max values for control 2 (id 5) ALSA sound/usb/mixer.c:929 5:2: cannot get min/max values for

Re: [PATCH v4 9/9] usb: chipidea: add support to the generic PHY framework in ChipIdea

2014-09-12 Thread Antoine Tenart
Peter, On Fri, Sep 12, 2014 at 01:10:33AM +, Peter Chen wrote: On Thu, Sep 11, 2014 at 08:54:47AM +0800, Peter Chen wrote: On Wed, Sep 03, 2014 at 09:40:40AM +0200, Antoine Tenart wrote: @@ -595,23 +639,27 @@ static int ci_hdrc_probe(struct platform_device *pdev)

[PATCH 0/9] libusbg: Add usbg_udc structure

2014-09-12 Thread Krzysztof Opasiak
Dear Matt, This series adds usbg_udc structure and fixes some typos introduced in previous patches. Before this series UDC didn't have its own structure. Gadget enable took const char * as parameter. Such approach is inconsisten with rest of API. This series introduce structure usbg_udc as

[PATCH 1/9] libusbg: doc: Fix typos in doxygen documentation

2014-09-12 Thread Krzysztof Opasiak
Signed-off-by: Krzysztof Opasiak k.opas...@samsung.com --- include/usbg/usbg.h | 40 +++- 1 file changed, 19 insertions(+), 21 deletions(-) diff --git a/include/usbg/usbg.h b/include/usbg/usbg.h index a934a7b..fe0e019 100644 --- a/include/usbg/usbg.h +++

[PATCH 7/9] libusbg: Refresh gadget UDC while each usbg_get_gadget_udc()

2014-09-12 Thread Krzysztof Opasiak
Kernel may decide to detach our gadget in some cases. A good example is when FFS daemon received a SIGSEGV and all descriptors has been closed. To avoid returning false informations to user we have to refresh UDC attribute before returning cached pointer to usbg_udc. Signed-off-by: Krzysztof

[PATCH 6/9] libusbg: Rework API to use usbg_udc structure

2014-09-12 Thread Krzysztof Opasiak
Using string as udc identifier provides a lot of troubles. To be more consistent with rest of API rework it to start using usbg_udc structure instead of using char *. Signed-off-by: Krzysztof Opasiak k.opas...@samsung.com --- examples/gadget-vid-pid-remove.c | 12 ++--- examples/show-gadgets.c

[PATCH 8/9] libusbg: Allow to get gadget enabled on given UDC

2014-09-12 Thread Krzysztof Opasiak
Add usbg_get_udc_gadget() which allows user to learn which gadget is attached to selected UDC. Signed-off-by: Krzysztof Opasiak k.opas...@samsung.com --- include/usbg/usbg.h |7 +++ src/usbg.c | 30 ++ 2 files changed, 37 insertions(+) diff --git

[PATCH 5/9] libusbg: Replace usbg_get_udcs() with loop

2014-09-12 Thread Krzysztof Opasiak
Library allows to iterate over each gadget using loop. To be consistent with this convention add similar loop for UDCs. Signed-off-by: Krzysztof Opasiak k.opas...@samsung.com --- include/usbg/usbg.h | 31 --- src/usbg.c | 49

[PATCH 3/9] libusbg: Simplify getting names form library structures

2014-09-12 Thread Krzysztof Opasiak
Signed-off-by: Krzysztof Opasiak k.opas...@samsung.com --- examples/show-gadgets.c | 41 +-- include/usbg/usbg.h | 70 --- src/usbg.c | 35 3 files changed, 117 insertions(+), 29

[PATCH 4/9] libusbg: Add udc structure

2014-09-12 Thread Krzysztof Opasiak
Add structure to store informations about available udcs instead of using their names as a string. Signed-off-by: Krzysztof Opasiak k.opas...@samsung.com --- include/usbg/usbg.h | 14 src/usbg.c | 94 +++ 2 files changed, 108

[PATCH 2/9] libusbg: Always add '\0' at end of string

2014-09-12 Thread Krzysztof Opasiak
strncpy() may not append trailing '\0' so let's append it always at end of string to avoid getting into troubles. Signed-off-by: Krzysztof Opasiak k.opas...@samsung.com --- src/usbg.c | 30 -- 1 file changed, 20 insertions(+), 10 deletions(-) diff --git

Re: [PATCH v4 9/9] usb: chipidea: add support to the generic PHY framework in ChipIdea

2014-09-12 Thread Peter Chen
On Fri, Sep 12, 2014 at 10:21:25AM +0200, Antoine Tenart wrote: Peter, On Fri, Sep 12, 2014 at 01:10:33AM +, Peter Chen wrote: On Thu, Sep 11, 2014 at 08:54:47AM +0800, Peter Chen wrote: On Wed, Sep 03, 2014 at 09:40:40AM +0200, Antoine Tenart wrote: @@ -595,23 +639,27 @@

[PATCH 9/9] libusbg: Add example how to use usbg_udc structure

2014-09-12 Thread Krzysztof Opasiak
This example shows how to learn what udcs are available in system and also how to find out what gadgets are enabled on them. Signed-off-by: Krzysztof Opasiak k.opas...@samsung.com --- examples/Makefile.am |3 ++- examples/show-udcs.c | 61 ++

RE: [PATCH 2/9] libusbg: Always add '\0' at end of string

2014-09-12 Thread David Laight
From: Krzysztof Opasiak strncpy() may not append trailing '\0' so let's append it always at end of string to avoid getting into troubles. Silently truncating strings just gives other errors. You really need to verify that it doesn't matter. ... diff --git a/src/usbg.c b/src/usbg.c index

Re: [PATCH v4 9/9] usb: chipidea: add support to the generic PHY framework in ChipIdea

2014-09-12 Thread Antoine Tenart
On Fri, Sep 12, 2014 at 05:27:13PM +0800, Peter Chen wrote: On Fri, Sep 12, 2014 at 10:21:25AM +0200, Antoine Tenart wrote: Peter, On Fri, Sep 12, 2014 at 01:10:33AM +, Peter Chen wrote: On Thu, Sep 11, 2014 at 08:54:47AM +0800, Peter Chen wrote: On Wed, Sep 03, 2014 at

Re: [PATCH v4 9/9] usb: chipidea: add support to the generic PHY framework in ChipIdea

2014-09-12 Thread Peter Chen
On Fri, Sep 12, 2014 at 11:35:50AM +0200, Antoine Tenart wrote: On Fri, Sep 12, 2014 at 05:27:13PM +0800, Peter Chen wrote: On Fri, Sep 12, 2014 at 10:21:25AM +0200, Antoine Tenart wrote: Peter, On Fri, Sep 12, 2014 at 01:10:33AM +, Peter Chen wrote: On Thu, Sep 11, 2014 at

Re: [PATCH v4 9/9] usb: chipidea: add support to the generic PHY framework in ChipIdea

2014-09-12 Thread Antoine Tenart
On Fri, Sep 12, 2014 at 06:28:29PM +0800, Peter Chen wrote: On Fri, Sep 12, 2014 at 11:35:50AM +0200, Antoine Tenart wrote: On Fri, Sep 12, 2014 at 05:27:13PM +0800, Peter Chen wrote: On Fri, Sep 12, 2014 at 10:21:25AM +0200, Antoine Tenart wrote: Peter, On Fri, Sep 12, 2014 at

Re: [PATCHv4 04/12] usb: dwc2: Add the appropriate init calls in platform code

2014-09-12 Thread Robert Baldyga
Hi Dinh, On 08/26/2014 06:19 PM, dingu...@opensource.altera.com wrote: From: Dinh Nguyen dingu...@opensource.altera.com Add the proper init calls for either host, gadget or both in platform.c Signed-off-by: Dinh Nguyen dingu...@opensource.altera.com Acked-by: Paul Zimmerman

[PATCH] usb: hub: wrong order of putting interfaces when processing hub events

2014-09-12 Thread Petr Mladek
usb_autopm_put_interface() must be called only when usb_autopm_get_interface() succeeded before. There was wrong ordering of the goto targets. The funny thing is that the names of the goto targets and the related comments were correct. Signed-off-by: Petr Mladek pmla...@suse.cz ---

[PATCH 0/4] usb: hub: convert khubd into workqueue

2014-09-12 Thread Petr Mladek
The workqueue API is well defined, it allows to schedule the work as needed, and usually allows to avoid an extra thread at all. This patchset converts khubd into the workqueue. It saves one thread, lock, and list. IMHO, the new code is a bit cleaner. It looks huge but the main change is in the

[PATCH 1/4] usb: hub: convert khubd into workqueue

2014-09-12 Thread Petr Mladek
There is no need to have separate kthread for handling USB hub events. It is more elegant to use the workqueue framework. The workqueue is allocated as unbound, cpu intensive, and freezable. There does not seem to be any big advantage to run it on the same CPU. The handler is taking a lock and

[PATCH 2/4] usb: hub: remove obsolete while cycle in hub_event()

2014-09-12 Thread Petr Mladek
The USB hub events are proceed by workqueue instead of kthread now. The result is that hub_event() function processes only one event. The while cycle was not removed earlier to show the real changes when switching to the workqueue. This patch also consolidates the goto targets and rename them

[PATCH 4/4] usb: hub: rename khubd to hub_wq in documentation and comments

2014-09-12 Thread Petr Mladek
USB hub has started to use a workqueue instead of kthread. Let's update the documentation and comments here and there. This patch mostly just replaces khubd with hub_wq. There are only few exceptions where the whole sentence was updated. These more complicated changes can be found in the

[PATCH 3/4] usb: hub: rename *kick_khubd to *kick_hub_wq

2014-09-12 Thread Petr Mladek
USB hub started to use a workqueue instead of kthread. Let's make it clear from the function names. Signed-off-by: Petr Mladek pmla...@suse.cz --- drivers/usb/core/hcd.c | 4 ++-- drivers/usb/core/hub.c | 16 drivers/usb/core/usb.h | 2 +- 3 files changed, 11 insertions(+), 11

Re: [PATCHv4 06/12] usb: dwc2: Update common interrupt handler to call gadget interrupt handler

2014-09-12 Thread Robert Baldyga
Hi, On 08/26/2014 06:19 PM, dingu...@opensource.altera.com wrote: From: Dinh Nguyen dingu...@opensource.altera.com Make dwc2_handle_common_intr call the gadget interrupt function when operating in peripheral mode. Remove the spinlock functions in s3c_hsotg_irq as dwc2_handle_common_intr()

Re: [PATCHv4 09/12] usb: dwc2: initialize the spin_lock for both host and gadget

2014-09-12 Thread Robert Baldyga
Hi, On 08/26/2014 06:20 PM, dingu...@opensource.altera.com wrote: From: Dinh Nguyen dingu...@opensource.altera.com Move spin_lock_init to common location for both host and gadget. Signed-off-by: Dinh Nguyen dingu...@opensource.altera.com --- v4: move spin_lock_init up to make sure sure

Re: xhci

2014-09-12 Thread Mathias Nyman
Hi On 09/11/2014 05:18 PM, Jay Larson wrote: Mathias, I was not able to locate an official method of inquiring about issues with xhci, so I'm writing directly to you. If this is not the appropriate method please accept my apologies and kindly direct me to the proper place. Me,

Re: [PATCH 3/6] arm: omap3: twl: use the new lookup method with usb phy

2014-09-12 Thread Heikki Krogerus
On Thu, Sep 11, 2014 at 08:56:15PM +0530, Kishon Vijay Abraham I wrote: +static struct phy_lookup twl4030_usb_lookup = { + .phy_name = phy-twl4030_usb.0, + .dev_id = musb-hdrc.0, + .con_id = usb, }; Can use PHY_LOOKUP no? I'll fix this. Thanks, --

Re: [PATCH v4 7/9] usb: rename transceiver and phy to usb_phy in ChipIdea

2014-09-12 Thread Antoine Tenart
Peter, On Thu, Sep 11, 2014 at 08:28:59AM +0800, Peter Chen wrote: On Wed, Sep 03, 2014 at 09:40:38AM +0200, Antoine Tenart wrote: Again, rebase my next-tree, and modify the msm part. git://github.com/hzpeterchen/linux-usb.git ci-for-usb-next ? I can do that. But that would be easier if you

Re: [PATCH 2/6] phy: improved lookup method

2014-09-12 Thread Heikki Krogerus
On Thu, Sep 11, 2014 at 09:03:06PM +0530, Kishon Vijay Abraham I wrote: +static struct phy *phy_find(struct device *dev, const char *con_id) +{ + const char *dev_id = dev ? dev_name(dev) : NULL; + int match, best_found = 0, best_possible = 0; + struct phy *phy = ERR_PTR(-ENODEV);

Re: [PATCH] usb: hub: wrong order of putting interfaces when processing hub events

2014-09-12 Thread Alan Stern
On Fri, 12 Sep 2014, Petr Mladek wrote: usb_autopm_put_interface() must be called only when usb_autopm_get_interface() succeeded before. There was wrong ordering of the goto targets. No, you are wrong. The code is correct as it stands. The funny thing is that the names of the goto targets

Re: [PATCH 6/6] usb: dwc3: host: convey the PHYs to xhci

2014-09-12 Thread Kishon Vijay Abraham I
Hi, On Friday 12 September 2014 07:19 PM, Heikki Krogerus wrote: On Thu, Sep 11, 2014 at 08:31:19PM +0530, Kishon Vijay Abraham I wrote: @@ -60,22 +59,33 @@ int dwc3_host_init(struct dwc3 *dwc) goto err1; } + phy_create_lookup(dwc-usb2_generic_phy, usb2-phy, +

Re: [PATCH 1/4] usb: hub: convert khubd into workqueue

2014-09-12 Thread Alan Stern
On Fri, 12 Sep 2014, Petr Mladek wrote: There is no need to have separate kthread for handling USB hub events. It is more elegant to use the workqueue framework. The workqueue is allocated as unbound, cpu intensive, and freezable. There does not seem to be any big advantage to run it on the

Re: [PATCH] usb: hub: wrong order of putting interfaces when processing hub events

2014-09-12 Thread Petr Mladek
On Fri 2014-09-12 10:06:03, Alan Stern wrote: On Fri, 12 Sep 2014, Petr Mladek wrote: usb_autopm_put_interface() must be called only when usb_autopm_get_interface() succeeded before. There was wrong ordering of the goto targets. No, you are wrong. The code is correct as it stands.

Re: [PATCH 2/4] usb: hub: remove obsolete while cycle in hub_event()

2014-09-12 Thread Alan Stern
On Fri, 12 Sep 2014, Petr Mladek wrote: The USB hub events are proceed by workqueue instead of kthread now. The result is that hub_event() function processes only one event. The while cycle was not removed earlier to show the real changes when switching to the workqueue. This patch also

Re: xhci

2014-09-12 Thread Jay Larson
I appreciate the info Mathias. I will work on getting a 3.16 kernel in testing on one of our systems and report back. Jay Larson Sr. Unix Administrator Katalyst Data Management Phone: 281-529-3200 Cell: 832-712-7251 KELMAN is now KATALYST! Please visit www.katalystdm.com! On 09/12/2014 08:26

Re: [PATCH 2/6] phy: improved lookup method

2014-09-12 Thread Kishon Vijay Abraham I
Hi, On Friday 12 September 2014 07:37 PM, Heikki Krogerus wrote: On Thu, Sep 11, 2014 at 09:03:06PM +0530, Kishon Vijay Abraham I wrote: +static struct phy *phy_find(struct device *dev, const char *con_id) +{ + const char *dev_id = dev ? dev_name(dev) : NULL; + int match, best_found = 0,

Re: [PATCH 1/4] usb: hub: convert khubd into workqueue

2014-09-12 Thread Petr Mladek
On Fri 2014-09-12 10:16:21, Alan Stern wrote: On Fri, 12 Sep 2014, Petr Mladek wrote: There is no need to have separate kthread for handling USB hub events. It is more elegant to use the workqueue framework. The workqueue is allocated as unbound, cpu intensive, and freezable. There

Re: Hitting unused qh not empty BUG in qh_destroy

2014-09-12 Thread Alan Stern
On Thu, 11 Sep 2014, Joe Lawrence wrote: Hi Alan, I've got another USB bug to report that manifests during automated device removal testing on RHEL7. This one hits the BUG() inside qh_destroy: How reliably can you trigger this bug? 67 static void qh_destroy(struct ehci_hcd *ehci,

Re: [PATCH 1/4] usb: hub: convert khubd into workqueue

2014-09-12 Thread Alan Stern
On Fri, 12 Sep 2014, Petr Mladek wrote: I don't think you can eliminate the lock quite so easily. This patch introduces some nasty races. @@ -577,18 +571,20 @@ static int hub_port_status(struct usb_hub *hub, int port1, static void kick_khubd(struct usb_hub *hub) {

Re: [PATCHv4 01/12] usb: dwc2: Update Kconfig to support dual-role

2014-09-12 Thread Bartlomiej Zolnierkiewicz
[ added linux-kernel ML to cc: ] Hi, On Tuesday, August 26, 2014 11:19:52 AM dingu...@opensource.altera.com wrote: From: Dinh Nguyen dingu...@opensource.altera.com Update DWC2 kconfig and makefile to support dual-role mode. The platform file will always get compiled for the case where the

Re: [PATCHv4 02/12] usb: dwc2: move samsung,s3c6400-hsotg into common platform

2014-09-12 Thread Bartlomiej Zolnierkiewicz
[ added linux-kernel ML to cc: ] Hi, On Tuesday, August 26, 2014 11:19:53 AM dingu...@opensource.altera.com wrote: From: Dinh Nguyen dingu...@opensource.altera.com Move the samsung,s3c6400-hsotg binding as the probe function in the gadget driver will get removed when the dual-role driver

Re: [PATCHv4 03/12] usb: dwc2: Update the gadget driver to use common dwc2_hsotg structure

2014-09-12 Thread Bartlomiej Zolnierkiewicz
[ added linux-kernel ML to cc: ] Hi, On Tuesday, August 26, 2014 11:19:54 AM dingu...@opensource.altera.com wrote: From: Dinh Nguyen dingu...@opensource.altera.com Adds the gadget data structure and appropriate data structure pointers to the common dwc2_hsotg data structure. To keep the

Re: [PATCHv4 04/12] usb: dwc2: Add the appropriate init calls in platform code

2014-09-12 Thread Bartlomiej Zolnierkiewicz
[ added linux-kernel ML to cc: ] Hi, On Tuesday, August 26, 2014 11:19:55 AM dingu...@opensource.altera.com wrote: From: Dinh Nguyen dingu...@opensource.altera.com Add the proper init calls for either host, gadget or both in platform.c Signed-off-by: Dinh Nguyen

Re: [PATCHv4 08/12] usb: dwc2: gadget: Do not fail probe if there isn't a clock node

2014-09-12 Thread Bartlomiej Zolnierkiewicz
[ added linux-kernel ML to cc: ] Hi, On Tuesday, August 26, 2014 11:19:59 AM dingu...@opensource.altera.com wrote: From: Dinh Nguyen dingu...@opensource.altera.com Since the dwc2 hcd driver is currently not looking for a clock node during init, we should not completely fail if there isn't

Re: [PATCHv4 09/12] usb: dwc2: initialize the spin_lock for both host and gadget

2014-09-12 Thread Bartlomiej Zolnierkiewicz
[ added linux-kernel ML to cc: ] Hi, On Tuesday, August 26, 2014 11:20:00 AM dingu...@opensource.altera.com wrote: From: Dinh Nguyen dingu...@opensource.altera.com Move spin_lock_init to common location for both host and gadget. This should be done at the same time that gadget/host probing

Re: [PATCHv4 11/12] usb: dwc2: check that the host work queue is valid

2014-09-12 Thread Bartlomiej Zolnierkiewicz
[ added linux-kernel ML to cc: ] Hi, On Tuesday, August 26, 2014 11:20:02 AM dingu...@opensource.altera.com wrote: From: Dinh Nguyen dingu...@opensource.altera.com The Host workqueue will not get initialized if the driver is configured for peripheral mode only. Thus we need to check for

Re: [PATCH v3 0/9] Tegra xHCI support

2014-09-12 Thread Andrew Bresticker
On Tue, Sep 9, 2014 at 1:21 AM, Tomeu Vizoso to...@tomeuvizoso.net wrote: On 8 September 2014 18:22, Andrew Bresticker abres...@chromium.org wrote: On Mon, Sep 8, 2014 at 8:34 AM, Tomeu Vizoso to...@tomeuvizoso.net wrote: On 2 September 2014 23:34, Andrew Bresticker abres...@chromium.org wrote:

Re: [PATCHv4 10/12] usb: dwc2: Add suspend/resume for gadget

2014-09-12 Thread Bartlomiej Zolnierkiewicz
[ added linux-kernel ML to cc: ] Hi, On Tuesday, August 26, 2014 11:20:01 AM dingu...@opensource.altera.com wrote: From: Dinh Nguyen dingu...@opensource.altera.com Move suspend/resume code to common platform code. This should be done at the same time that gadget/host probing is merged to

Re: [PATCHv4 00/12] usb: dwc2: Add support for dual role

2014-09-12 Thread Bartlomiej Zolnierkiewicz
[ added linux-kernel ML to cc: ] Hi, On Tuesday, August 26, 2014 11:19:51 AM dingu...@opensource.altera.com wrote: From: Dinh Nguyen dingu...@opensource.altera.com Hello, This is version 4 of the patch series that combines the dwc2 gadget and host driver into a single dual role driver.

Re: Hitting unused qh not empty BUG in qh_destroy

2014-09-12 Thread Joe Lawrence
On Fri, 12 Sep 2014 11:31:46 -0400 Alan Stern st...@rowland.harvard.edu wrote: On Thu, 11 Sep 2014, Joe Lawrence wrote: Hi Alan, I've got another USB bug to report that manifests during automated device removal testing on RHEL7. This one hits the BUG() inside qh_destroy: How

[PATCH v8 2/3] usb: dwc3: Add Qualcomm DWC3 glue layer driver

2014-09-12 Thread Andy Gross
From: Ivan T. Ivanov iiva...@mm-sol.com DWC3 glue layer is hardware layer around Synopsys DesignWare USB3 core. Its purpose is to supply Synopsys IP with required clocks, voltages and interface it with the rest of the SoC. Signed-off-by: Ivan T. Ivanov iiva...@mm-sol.com Signed-off-by: Andy

[PATCH v8 3/3] phy: Add Qualcomm DWC3 HS/SS PHY driver

2014-09-12 Thread Andy Gross
This patch adds a new driver for the Qualcomm USB 3.0 PHY that exists on some Qualcomm platforms. This driver uses the generic PHY framework and will interact with the DWC3 controller. Signed-off-by: Andy Gross agr...@codeaurora.org --- drivers/phy/Kconfig | 11 + drivers/phy/Makefile

[PATCH v8 0/3] DWC3 USB support for Qualcomm platform

2014-09-12 Thread Andy Gross
These patches add basic support for USB3.0 controllers found on MSM platforms. USB3.0 core is based on Synopsys DesignWare SuperSpeed IP. This work was started by Ivan Ivanov and went through a number of iterations. I picked these patches up and did a little rework to get them working. Changes

[PATCH v8 1/3] usb: dwc3: qcom: Add device tree binding

2014-09-12 Thread Andy Gross
From: Ivan T. Ivanov iiva...@mm-sol.com QCOM USB3.0 core wrapper consist of USB3.0 IP from Synopsys (SNPS) and HS, SS PHY's control and configuration registers. It could operate in device mode (SS, HS, FS) and host mode (SS, HS, FS, LS). Signed-off-by: Ivan T. Ivanov iiva...@mm-sol.com

Re: [PATCH v8 2/3] usb: dwc3: Add Qualcomm DWC3 glue layer driver

2014-09-12 Thread Felipe Balbi
Hi, On Fri, Sep 12, 2014 at 12:29:45PM -0500, Andy Gross wrote: From: Ivan T. Ivanov iiva...@mm-sol.com DWC3 glue layer is hardware layer around Synopsys DesignWare USB3 core. Its purpose is to supply Synopsys IP with required clocks, voltages and interface it with the rest of the SoC.

Re: [PATCH v8 3/3] phy: Add Qualcomm DWC3 HS/SS PHY driver

2014-09-12 Thread Josh Cartwright
Hey Andy- Mostly cosmetic things below: On Fri, Sep 12, 2014 at 12:29:46PM -0500, Andy Gross wrote: This patch adds a new driver for the Qualcomm USB 3.0 PHY that exists on some Qualcomm platforms. This driver uses the generic PHY framework and will interact with the DWC3 controller.

Re: [PATCH 1/4] usb: hub: convert khubd into workqueue

2014-09-12 Thread Tejun Heo
On Fri, Sep 12, 2014 at 02:21:05PM +0200, Petr Mladek wrote: There is no need to have separate kthread for handling USB hub events. It is more elegant to use the workqueue framework. The workqueue is allocated as unbound, cpu intensive, and freezable. I'd just go with WQ_FREEZABLE. As a

[GIT PULL] USB driver fixes for 3.17-rc5

2014-09-12 Thread Greg KH
The following changes since commit 69e273c0b0a3c337a521d083374c918dc52c666f: Linux 3.17-rc3 (2014-08-31 18:23:04 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/ tags/usb-3.17-rc5 for you to fetch changes up to

Re: Hitting unused qh not empty BUG in qh_destroy

2014-09-12 Thread Alan Stern
On Fri, 12 Sep 2014, Joe Lawrence wrote: On Fri, 12 Sep 2014 11:31:46 -0400 Alan Stern st...@rowland.harvard.edu wrote: On Thu, 11 Sep 2014, Joe Lawrence wrote: Hi Alan, I've got another USB bug to report that manifests during automated device removal testing on RHEL7. This

Re: [PATCH v8 3/3] phy: Add Qualcomm DWC3 HS/SS PHY driver

2014-09-12 Thread Andy Gross
On Fri, Sep 12, 2014 at 12:50:23PM -0500, Josh Cartwright wrote: Hey Andy- Mostly cosmetic things below: On Fri, Sep 12, 2014 at 12:29:46PM -0500, Andy Gross wrote: This patch adds a new driver for the Qualcomm USB 3.0 PHY that exists on some Qualcomm platforms. This driver uses the

Re: [PATCH v8 3/3] phy: Add Qualcomm DWC3 HS/SS PHY driver

2014-09-12 Thread Stephen Boyd
Yay nitpicks! On 09/12/14 10:29, Andy Gross wrote: + +struct qcom_dwc3_usb_phy { + void __iomem*base; + struct device *dev; + struct phy *phy; Align with other members? + +static int wait_for_latch(void __iomem *addr) +{ + u32 retry = 10; Why not

Re: [PATCHv4 00/12] usb: dwc2: Add support for dual role

2014-09-12 Thread Dinh Nguyen
On 09/12/2014 11:44 AM, Bartlomiej Zolnierkiewicz wrote: [ added linux-kernel ML to cc: ] Hi, On Tuesday, August 26, 2014 11:19:51 AM dingu...@opensource.altera.com wrote: From: Dinh Nguyen dingu...@opensource.altera.com Hello, This is version 4 of the patch series that combines the

[Patch v9 3/3] phy: Add Qualcomm DWC3 HS/SS PHY driver

2014-09-12 Thread Andy Gross
This patch adds a new driver for the Qualcomm USB 3.0 PHY that exists on some Qualcomm platforms. This driver uses the generic PHY framework and will interact with the DWC3 controller. Signed-off-by: Andy Gross agr...@codeaurora.org --- drivers/phy/Kconfig | 11 + drivers/phy/Makefile

[Patch v9 2/3] usb: dwc3: Add Qualcomm DWC3 glue layer driver

2014-09-12 Thread Andy Gross
From: Ivan T. Ivanov iiva...@mm-sol.com DWC3 glue layer is hardware layer around Synopsys DesignWare USB3 core. Its purpose is to supply Synopsys IP with required clocks, voltages and interface it with the rest of the SoC. Signed-off-by: Ivan T. Ivanov iiva...@mm-sol.com Signed-off-by: Andy

[Patch v9 1/3] usb: dwc3: qcom: Add device tree binding

2014-09-12 Thread Andy Gross
From: Ivan T. Ivanov iiva...@mm-sol.com QCOM USB3.0 core wrapper consist of USB3.0 IP from Synopsys (SNPS) and HS, SS PHY's control and configuration registers. It could operate in device mode (SS, HS, FS) and host mode (SS, HS, FS, LS). Signed-off-by: Ivan T. Ivanov iiva...@mm-sol.com

[Patch v9 0/3] DWC3 USB support for Qualcomm platform

2014-09-12 Thread Andy Gross
These patches add basic support for USB3.0 controllers found on MSM platforms. USB3.0 core is based on Synopsys DesignWare SuperSpeed IP. This work was started by Ivan Ivanov and went through a number of iterations. I picked these patches up and did a little rework to get them working. Changes

Re: [REGRESSION 3.17] scsi (uas) disks no longer using tagged command queuing

2014-09-12 Thread Hans de Goede
Hi, On 09/11/2014 06:13 PM, Christoph Hellwig wrote: On Thu, Sep 11, 2014 at 12:01:13PM +0200, Hans de Goede wrote: So we're initializing the tag map, but scsi_activate_tcq doesn't pick it up. I can't really come up with a good explanation for it, but there even without that there is an

Re: [Patch v9 2/3] usb: dwc3: Add Qualcomm DWC3 glue layer driver

2014-09-12 Thread Felipe Balbi
On Sat, Sep 13, 2014 at 01:44:25AM +0530, Pramod Gurav wrote: Andy, Couple of minor comments. On Sat, Sep 13, 2014 at 12:58 AM, Andy Gross agr...@codeaurora.org wrote: From: Ivan T. Ivanov iiva...@mm-sol.com DWC3 glue layer is hardware layer around Synopsys DesignWare USB3 core. Its

Re: [Patch v9 2/3] usb: dwc3: Add Qualcomm DWC3 glue layer driver

2014-09-12 Thread Felipe Balbi
Hi, On Sat, Sep 13, 2014 at 01:55:50AM +0530, Pramod Gurav wrote: + qdwc = devm_kzalloc(pdev-dev, sizeof(*qdwc), GFP_KERNEL); + if (!qdwc) + return -ENOMEM; + + platform_set_drvdata(pdev, qdwc); + + qdwc-dev = pdev-dev; + +

Re: [Patch v9 2/3] usb: dwc3: Add Qualcomm DWC3 glue layer driver

2014-09-12 Thread Pramod Gurav
Hi Felipe, On 13-09-2014 01:50 AM, Felipe Balbi wrote: On Sat, Sep 13, 2014 at 01:44:25AM +0530, Pramod Gurav wrote: Andy, Couple of minor comments. On Sat, Sep 13, 2014 at 12:58 AM, Andy Gross agr...@codeaurora.org wrote: From: Ivan T. Ivanov iiva...@mm-sol.com DWC3 glue layer is

Re: [Patch v9 2/3] usb: dwc3: Add Qualcomm DWC3 glue layer driver

2014-09-12 Thread Pramod Gurav
On 13-09-2014 01:59 AM, Felipe Balbi wrote: Hi, On Sat, Sep 13, 2014 at 01:55:50AM +0530, Pramod Gurav wrote: + qdwc = devm_kzalloc(pdev-dev, sizeof(*qdwc), GFP_KERNEL); + if (!qdwc) + return -ENOMEM; + + platform_set_drvdata(pdev, qdwc); + +

usb3503: some minor patches

2014-09-12 Thread Tobias Jakobi
Hello, here are some minor patches for the usb3503. No functional changes here. With best wishes, Tobias -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 2/3] usb3503: fix typos in devicetree binding documentation

2014-09-12 Thread Tobias Jakobi
'availe' to 'available' 'desribed' to 'described' Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de --- Documentation/devicetree/bindings/usb/usb3503.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/usb/usb3503.txt

[PATCH 1/3] usb3503: correct error message in probe ('connect' to 'interrupt')

2014-09-12 Thread Tobias Jakobi
intn is obviously the interrupt pin. Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de --- drivers/usb/misc/usb3503.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/misc/usb3503.c b/drivers/usb/misc/usb3503.c index 47cb143..0819a2e 100644 ---

[PATCH 3/3] usb3503: clarify what the registers 'PDS' and 'CFG1' really do

2014-09-12 Thread Tobias Jakobi
The current comment sounds like you have to disable some of the ports to be able to use self-powered mode. This is misleading, so change the wording to reflect this. Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de --- drivers/usb/misc/usb3503.c | 4 ++-- 1 file changed, 2

[PATCH] scsi: fix regression that accidentally disabled block-based tcq

2014-09-12 Thread Christoph Hellwig
Please try the fix below, looks like the commit broke TCQ for all drivers using block-level tagging. --- From 865a19b760d2786fe37d3b5c151a4ecea4c0e95e Mon Sep 17 00:00:00 2001 From: Christoph Hellwig h...@lst.de Date: Fri, 12 Sep 2014 16:00:19 -0700 Subject: scsi: fix regression that

RE: [PATCH v4 9/9] usb: chipidea: add support to the generic PHY framework in ChipIdea

2014-09-12 Thread Peter Chen
On Fri, Sep 12, 2014 at 06:28:29PM +0800, Peter Chen wrote: On Fri, Sep 12, 2014 at 11:35:50AM +0200, Antoine Tenart wrote: On Fri, Sep 12, 2014 at 05:27:13PM +0800, Peter Chen wrote: On Fri, Sep 12, 2014 at 10:21:25AM +0200, Antoine Tenart wrote: Peter, On Fri, Sep 12,