Re: Poor performance with USB 1.1 drive connected to USB 3.0 port

2014-09-24 Thread Mark Knibbs
On Wed, 24 Sep 2014 11:37:11 -0400 (EDT) Alan Stern st...@rowland.harvard.edu wrote: On Wed, 24 Sep 2014, Mark Knibbs wrote: I did some benchmarks to check the maximum transfer rate of a USB-to-SCSI converter. The converter is USB 1.1, so limited to the 12Mbps full speed rate. The

Re: [PATCH v6 1/2] usb: gadget: pxa27x_udc: prepare device-tree support

2014-09-24 Thread Felipe Balbi
Hi, On Wed, Sep 24, 2014 at 10:14:53PM +0200, Robert Jarzmik wrote: Felipe Balbi ba...@ti.com writes: On Wed, Sep 24, 2014 at 09:41:12PM +0200, Robert Jarzmik wrote: For this preparation, a preliminary cleanup is done : - convert the probing of pxa27x_udc to gpio_desc. The

Re: [PATCH v6 1/2] usb: gadget: pxa27x_udc: prepare device-tree support

2014-09-24 Thread Robert Jarzmik
Felipe Balbi ba...@ti.com writes: Hi, On Wed, Sep 24, 2014 at 10:14:53PM +0200, Robert Jarzmik wrote: if you reply like this again I'll start ignoring your patches. Settle down, I'm trying to help you get your patches merged. With that said: patch 1 should *ONLY* convert gpio_* to

[PATCH v6 1/4] usb: gadget: Introduce usb_gadget_giveback_request()

2014-09-24 Thread Michal Sojka
All USB peripheral controller drivers call completion routines directly. This patch adds usb_gadget_giveback_request() which will be used instead of direct invocation in the next patch. The goal here is to have a place where common functionality can be added. Signed-off-by: Michal Sojka

[PATCH v6 3/4] usb: Rename usb-common.c

2014-09-24 Thread Michal Sojka
In the next commit, we will want the usb-common module to be composed of two object files. Since Kbuild cannot append another object to an existing one, we need to rename usb-common.c to something else (common.c) and create usb-common.o by linking the wanted objects together. Currently,

[PATCH v6 0/4] LED triggers for USB host and device

2014-09-24 Thread Michal Sojka
This adds LED triggers for USB host and device. First two patches refactor UDC drivers as requested by Felipe Balbi, the next renames a file and the last is the actual implementation of the LED triggers. Changes from v5: - Refactoring of USB gadget completion split into two patches (Filipe

[PATCH v6 4/4] usb: Add LED triggers for USB activity

2014-09-24 Thread Michal Sojka
With this patch, USB activity can be signaled by blinking a LED. There are two triggers, one for activity on USB host and one for USB gadget. Both triggers should work with all host/device controllers. Tested only with musb. Performace: I measured performance overheads on ARM Cortex-A8 (TI

[PATCH v6 2/4] usb: gadget: Refactor request completion

2014-09-24 Thread Michal Sojka
Use the recently introduced usb_gadget_giveback_request() in favor of direct invocation of the completion routine. All places in drivers/usb/ matching [-.]complete( were replaced with a call to usb_gadget_giveback_request(). This was compile-tested with all ARM drivers enabled and runtime-tested

Re: [PATCH v6 1/2] usb: gadget: pxa27x_udc: prepare device-tree support

2014-09-24 Thread Felipe Balbi
Hi, On Wed, Sep 24, 2014 at 10:44:23PM +0200, Robert Jarzmik wrote: On Wed, Sep 24, 2014 at 10:14:53PM +0200, Robert Jarzmik wrote: if you reply like this again I'll start ignoring your patches. Settle down, I'm trying to help you get your patches merged. With that said: patch 1

Re: [PATCH v6 4/4] usb: Add LED triggers for USB activity

2014-09-24 Thread Felipe Balbi
Hi, On Wed, Sep 24, 2014 at 10:43:21PM +0200, Michal Sojka wrote: With this patch, USB activity can be signaled by blinking a LED. There are two triggers, one for activity on USB host and one for USB gadget. Both triggers should work with all host/device controllers. Tested only with musb.

Re: [PATCH v6 0/4] LED triggers for USB host and device

2014-09-24 Thread Felipe Balbi
On Wed, Sep 24, 2014 at 10:43:17PM +0200, Michal Sojka wrote: This adds LED triggers for USB host and device. First two patches refactor UDC drivers as requested by Felipe Balbi, the next renames a file and the last is the actual implementation of the LED triggers. Changes from v5: -

Re: [PATCH v6 1/4] usb: gadget: Introduce usb_gadget_giveback_request()

2014-09-24 Thread Felipe Balbi
On Wed, Sep 24, 2014 at 10:43:18PM +0200, Michal Sojka wrote: All USB peripheral controller drivers call completion routines directly. This patch adds usb_gadget_giveback_request() which will be used instead of direct invocation in the next patch. The goal here is to have a place where common

[PATCH v6 partial v2 3/3] usb: gadget: pxa27x_udc: add devicetree support

2014-09-24 Thread Robert Jarzmik
Add support for device-tree device discovery. If devicetree is not provided, fallback to legacy platform data discovery. Signed-off-by: Robert Jarzmik robert.jarz...@free.fr Cc: devicet...@vger.kernel.org --- Since V1: change OF id mrvl,pxa27x_udc - marvell,pxa27x-udc This is a

[PATCH v6 partial v2 1/3] usb: gadget: pxa27x_udc: prepare device-tree support

2014-09-24 Thread Robert Jarzmik
For this preparation, a preliminary cleanup is done : - convert the probing of pxa27x_udc to gpio_desc. The conversion is partial because : - the platform data still provides a gpio number, not a gpio desc - the invert attribute is lost, hence a loss in the translation The

[PATCH v6 partial v2 2/3] usb: gadget: pxa27x_udc: transfer mach_info into pxa_udc

2014-09-24 Thread Robert Jarzmik
Convert the mach info, and store the udc_command in the pxa_udc control structure. It is to be noticed that the udc_is_connected() in mach info is not transfered. This was not used, as mioa701 machine doesn't need it, balloon3 doesn't really use it, and most importantly the current driver never

Re: [PATCH v6 0/4] LED triggers for USB host and device

2014-09-24 Thread Greg Kroah-Hartman
On Wed, Sep 24, 2014 at 03:59:36PM -0500, Felipe Balbi wrote: On Wed, Sep 24, 2014 at 10:43:17PM +0200, Michal Sojka wrote: This adds LED triggers for USB host and device. First two patches refactor UDC drivers as requested by Felipe Balbi, the next renames a file and the last is the actual

Re: [PATCH v6 0/4] LED triggers for USB host and device

2014-09-24 Thread Felipe Balbi
On Wed, Sep 24, 2014 at 11:41:55PM +0200, Greg Kroah-Hartman wrote: On Wed, Sep 24, 2014 at 03:59:36PM -0500, Felipe Balbi wrote: On Wed, Sep 24, 2014 at 10:43:17PM +0200, Michal Sojka wrote: This adds LED triggers for USB host and device. First two patches refactor UDC drivers as

Re: [PATCH v6 2/4] usb: gadget: Refactor request completion

2014-09-24 Thread Felipe Balbi
On Wed, Sep 24, 2014 at 10:43:19PM +0200, Michal Sojka wrote: Use the recently introduced usb_gadget_giveback_request() in favor of direct invocation of the completion routine. All places in drivers/usb/ matching [-.]complete( were replaced with a call to usb_gadget_giveback_request(). This

Re: [PATCH v6 3/4] usb: Rename usb-common.c

2014-09-24 Thread Felipe Balbi
On Wed, Sep 24, 2014 at 10:43:20PM +0200, Michal Sojka wrote: In the next commit, we will want the usb-common module to be composed of two object files. Since Kbuild cannot append another object to an existing one, we need to rename usb-common.c to something else (common.c) and create

Re: [PATCH v6 0/4] LED triggers for USB host and device

2014-09-24 Thread Felipe Balbi
On Wed, Sep 24, 2014 at 05:18:30PM -0500, Felipe Balbi wrote: On Wed, Sep 24, 2014 at 11:41:55PM +0200, Greg Kroah-Hartman wrote: On Wed, Sep 24, 2014 at 03:59:36PM -0500, Felipe Balbi wrote: On Wed, Sep 24, 2014 at 10:43:17PM +0200, Michal Sojka wrote: This adds LED triggers for USB

Re: [PATCH v6 07/12] usb: chipidea: add a usb2 driver for ci13xxx

2014-09-24 Thread Sören Brinkmann
On Tue, 2014-09-23 at 12:28PM +0200, Antoine Tenart wrote: Add a USB2 ChipIdea driver for ci13xxx, with optional PHY, clock and DMA mask, to support USB2 ChipIdea controllers that don't need specific functions. Tested on the Marvell Berlin SoCs USB controllers. Signed-off-by: Antoine

Re: [PATCH v6 07/12] usb: chipidea: add a usb2 driver for ci13xxx

2014-09-24 Thread Peter Chen
On Wed, Sep 24, 2014 at 02:23:38PM +0200, Arnd Bergmann wrote: On Wednesday 24 September 2014 19:29:05 Peter Chen wrote: So, it is IP CORE LIB (you suggest) vs IP CORE Platform Driver (dwc3, musb, chipidea) you are talking about, right? Except for creating another platform driver as well

Re: [PATCH v6 07/12] usb: chipidea: add a usb2 driver for ci13xxx

2014-09-24 Thread Peter Chen
On Tue, Sep 23, 2014 at 12:28:03PM +0200, Antoine Tenart wrote: Add a USB2 ChipIdea driver for ci13xxx, with optional PHY, clock and DMA mask, to support USB2 ChipIdea controllers that don't need specific functions. Tested on the Marvell Berlin SoCs USB controllers. Signed-off-by: Antoine

RE: g_mass_storage bug ?

2014-09-24 Thread Paul Zimmerman
From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Felipe Balbi Sent: Wednesday, September 24, 2014 12:18 PM On Wed, Sep 24, 2014 at 01:08:15PM -0500, Felipe Balbi wrote: On Wed, Sep 24, 2014 at 01:53:31PM -0400, Alan Stern wrote: On Wed, 24 Sep

Re: g_mass_storage bug ?

2014-09-24 Thread Felipe Balbi
Hi, On Thu, Sep 25, 2014 at 01:37:05AM +, Paul Zimmerman wrote: Then, after the host cleared the halt, the gadget apparently sent the data that _should_ have been sent previously. The host was expecting to receive the CSW at this point, so there was an overflow error. That's

Re: g_mass_storage bug ?

2014-09-24 Thread Felipe Balbi
Hi again, On Wed, Sep 24, 2014 at 09:40:37PM -0500, Felipe Balbi wrote: On Thu, Sep 25, 2014 at 01:37:05AM +, Paul Zimmerman wrote: Then, after the host cleared the halt, the gadget apparently sent the data that _should_ have been sent previously. The host was expecting to

Re: [PATCH v5 1/2] usb: host: ehci-exynos: Remove unnecessary usb-phy support

2014-09-24 Thread Vivek Gautam
Hi Greg, On Mon, Sep 22, 2014 at 11:15 AM, Vivek Gautam gautam.vi...@samsung.com wrote: Now that we have completely moved from older USB-PHY drivers to newer GENERIC-PHY drivers for PHYs available with USB controllers on Exynos series of SoCs, we can remove the support for the same in our

RE: [PATCH 2/3] i2c: add support for Cypress CYUSBS234 USB-I2C adapter

2014-09-24 Thread Muthu Mani
-Original Message- From: Johan Hovold [mailto:jhov...@gmail.com] On Behalf Of Johan Hovold Sent: Monday, September 22, 2014 5:00 PM To: Muthu Mani Cc: Samuel Ortiz; Lee Jones; Wolfram Sang; linux-...@vger.kernel.org; Linus Walleij; Alexandre Courbot; linux-g...@vger.kernel.org;

RE: [PATCH 3/3] gpio: add support for Cypress CYUSBS234 USB-GPIO adapter

2014-09-24 Thread Muthu Mani
-Original Message- From: Johan Hovold [mailto:jhov...@gmail.com] On Behalf Of Johan Hovold Sent: Monday, September 22, 2014 5:14 PM To: Muthu Mani Cc: Samuel Ortiz; Lee Jones; Wolfram Sang; linux-...@vger.kernel.org; Linus Walleij; Alexandre Courbot; linux-g...@vger.kernel.org;

[PATCH v2 3/3] gpio: add support for Cypress CYUSBS234 USB-GPIO adapter

2014-09-24 Thread Muthu Mani
Adds support for USB-GPIO interface of Cypress Semiconductor CYUSBS234 USB-Serial Bridge controller. The GPIO get/set can be done through vendor command on control endpoint. Details about the device can be found at: http://www.cypress.com/?rID=84126 Signed-off-by: Muthu Mani m...@cypress.com

[PATCH v2 2/3] i2c: add support for Cypress CYUSBS234 USB-I2C adapter

2014-09-24 Thread Muthu Mani
Adds support for USB-I2C interface of Cypress Semiconductor CYUSBS234 USB-Serial Bridge controller. The read/write operation is setup using vendor command through control endpoint and actual data transfer happens through bulk in/out endpoints. Details about the device can be found at:

<    1   2