RE: [PATCH 1/3] mfd: add support for Cypress CYUSBS234 USB Serial Bridge controller

2014-09-25 Thread Muthu Mani
-Original Message- From: Johan Hovold [mailto:jhov...@gmail.com] On Behalf Of Johan Hovold Sent: Monday, September 22, 2014 4:29 PM To: Muthu Mani Cc: Samuel Ortiz; Lee Jones; Wolfram Sang; linux-...@vger.kernel.org; Linus Walleij; Alexandre Courbot; linux-g...@vger.kernel.org;

[PATCH v2 1/3] mfd: add support for Cypress CYUSBS234 USB Serial Bridge controller

2014-09-25 Thread Muthu Mani
Adds support for USB-I2C/GPIO interfaces of Cypress Semiconductor CYUSBS234 USB-Serial Bridge controller. Details about the device can be found at: http://www.cypress.com/?rID=84126 Signed-off-by: Muthu Mani m...@cypress.com Signed-off-by: Rajaram Regupathy r...@cypress.com ---

Re: [PATCH 2/6] phy: improved lookup method

2014-09-25 Thread Heikki Krogerus
Assume you have 2 phys in your system.. static struct phy_lookup usb_lookup = { .phy_name = phy-usb.0, .dev_id = usb.0, .con_id = usb, }; static struct phy_lookup sata_lookup = { .phy_name = sata-usb.1, .dev_id =

Re: [PATCH v6 07/12] usb: chipidea: add a usb2 driver for ci13xxx

2014-09-25 Thread Arnd Bergmann
On Thursday 25 September 2014 09:16:48 Peter Chen wrote: + } + + if (dev-of_node) { + ret = ci_hdrc_usb2_dt_probe(dev, ci_pdata); + if (ret) + goto clk_err; + } else { + ret = dma_set_mask_and_coherent(pdev-dev,

[RFC PATCH 3/4] usb: dwc3: add quirk to be compatible for AMD NL

2014-09-25 Thread Huang Rui
This patch add a quirk to be compatible for AMD NL SoC Some specific behaviors on NL: - configure USB3 PIPE registers - enable GCTL disscramble - enable U2EXIT_LFPS - enable hibernation at the global level - set LPM errata dissabled Signed-off-by: Huang Rui ray.hu...@amd.com ---

[RFC PATCH 0/4] usb: dwc3: add support for AMD NL SoC

2014-09-25 Thread Huang Rui
Hi, The series of patches add AMD NL SoC support for DesignWare USB3 OTG IP with PCI bus glue layer. And add a role switch feature with debugfs in order that create an entry to alternative roles between host and device. Because of the limitation for PCI-based temporary platform currently, it's

[RFC PATCH 2/4] usb: dwc3: add some register macros for future use

2014-09-25 Thread Huang Rui
This patch adds some undefined register macros on DWC3 spec 2.80a, these macros will be used on AMD NL specific configuration. Signed-off-by: Huang Rui ray.hu...@amd.com --- drivers/usb/dwc3/core.h | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/usb/dwc3/core.h

[RFC PATCH 4/4] usb: dwc3: introduce dual role switch function with debugfs

2014-09-25 Thread Huang Rui
This patch implemented a feature to dynamic switch to host or device role under debugfs for some physical limitation that unable to leverage connector A/B cables (ID pin) to change roles. The default role should be set as OTG mode. Then use below commands: [1] switch to host: echo host

[RFC PATCH 1/4] usb: dwc3: add AMD NL support

2014-09-25 Thread Huang Rui
Add PCI device ID of AMD NL. Signed-off-by: Huang Rui ray.hu...@amd.com --- drivers/usb/dwc3/dwc3-pci.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/dwc3/dwc3-pci.c b/drivers/usb/dwc3/dwc3-pci.c index 436fb08..cebbd01 100644 --- a/drivers/usb/dwc3/dwc3-pci.c +++

[PATCHv2 3/3] usb: dwc3: add ACPI support

2014-09-25 Thread Heikki Krogerus
Adding ACPI ID used on newer Intel SoCs. Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com --- drivers/usb/dwc3/core.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index d08cac5..88e29f5 100644 ---

Re: [PATCH 00/27] add pm_runtime_last_busy_and_autosuspend() helper

2014-09-25 Thread Vinod Koul
On Wed, Sep 24, 2014 at 10:28:07PM +0200, Rafael J. Wysocki wrote: OK, I guess this is as good as it gets. What tree would you like it go through? Since rest of the patches are dependent upon 1st patch which should go thru your tree, we should merge this thru your tree Thanks -- ~Vinod

Re: [PATCH v6 partial 0/2] pxa27x_udc port to device-tree and gpio_desc

2014-09-25 Thread Linus Walleij
On Wed, Sep 24, 2014 at 9:41 PM, Robert Jarzmik robert.jarz...@free.fr wrote: I have not found in the gpiolib anything for a driver to set that active_low value, only for machine code. The legacy behaviour was that that information was handed over to the driver. That's correct, active low is

Re: USB3 WD drive failure on ASUS M5A 78L-M USB3

2014-09-25 Thread Lu, Baolu
Can you try with the latest kernel? On 9/24/2014 6:13 AM, Len Berman wrote: I'm running debian 7. Linux foobar 3.2.0-4-amd64 #1 SMP Debian 3.2.60-1+deb7u3 x86_64 GNU/Linux. I have a Passport drive which fails on the USB3 connector. It works fine on USB2. It also works fine as USB3 on my

Re: [PATCH v6 partial 0/2] pxa27x_udc port to device-tree and gpio_desc

2014-09-25 Thread Linus Walleij
On Thu, Sep 25, 2014 at 10:26 AM, Linus Walleij linus.wall...@linaro.org wrote: On Wed, Sep 24, 2014 at 9:41 PM, Robert Jarzmik robert.jarz...@free.fr wrote: I have not found in the gpiolib anything for a driver to set that active_low value, only for machine code. The legacy behaviour was

Re: [PATCH v6 partial v2 1/3] usb: gadget: pxa27x_udc: prepare device-tree support

2014-09-25 Thread Linus Walleij
On Wed, Sep 24, 2014 at 11:05 PM, Robert Jarzmik robert.jarz...@free.fr wrote: For this preparation, a preliminary cleanup is done : - convert the probing of pxa27x_udc to gpio_desc. The conversion is partial because : - the platform data still provides a gpio number, not a gpio

Re: [PATCH v6 2/2] usb: gadget: pxa27x_udc: add devicetree support

2014-09-25 Thread Linus Walleij
On Wed, Sep 24, 2014 at 9:41 PM, Robert Jarzmik robert.jarz...@free.fr wrote: Add support for device-tree device discovery. If devicetree is not provided, fallback to legacy platform data discovery. Signed-off-by: Robert Jarzmik robert.jarz...@free.fr Cc: devicet...@vger.kernel.org (...) @@

Re: [PATCH v6 partial v2 1/3] usb: gadget: pxa27x_udc: prepare device-tree support

2014-09-25 Thread robert . jarzmik
- Mail original - De: Linus Walleij linus.wall...@linaro.org @@ -2415,7 +2411,13 @@ static int pxa_udc_probe(struct platform_device *pdev) { struct resource *regs; struct pxa_udc *udc = memory; - int retval = 0, gpio; + struct pxa2xx_udc_mach_info *mach =

Re: [GIT PULL] USB-serial fixes for v3.17-final

2014-09-25 Thread Greg Kroah-Hartman
On Wed, Sep 24, 2014 at 10:29:22AM +0200, Johan Hovold wrote: Hi Greg, Here are two more device ids for v3.17-final. As these are just new device ids, I've pulled these into my -next tree for 3.18-rc1 and they will get backported to 3.17-stable. thanks, greg k-h -- To unsubscribe from this

Re: [PATCH v5 1/4] mfd: add support for Diolan DLN-2 devices

2014-09-25 Thread Octavian Purdila
On Wed, Sep 24, 2014 at 6:22 PM, Octavian Purdila octavian.purd...@intel.com wrote: On Wed, Sep 24, 2014 at 6:07 PM, Johan Hovold jo...@kernel.org wrote: On Wed, Sep 24, 2014 at 05:54:15PM +0300, Octavian Purdila wrote: On Wed, Sep 24, 2014 at 4:54 PM, Johan Hovold jo...@kernel.org wrote: On

Re: [PATCH v5 1/4] mfd: add support for Diolan DLN-2 devices

2014-09-25 Thread Johan Hovold
On Thu, Sep 25, 2014 at 01:25:24PM +0300, Octavian Purdila wrote: Johan, I think we don't really need the spinlock, the disconnect flag and an atomic counter should work. Do you see any issues with that? No, you need to test and increment atomically so the lock is needed. Consider what could

Re: [PATCH v6 0/4] LED triggers for USB host and device

2014-09-25 Thread Greg Kroah-Hartman
On Wed, Sep 24, 2014 at 06:15:50PM -0500, Felipe Balbi wrote: On Wed, Sep 24, 2014 at 05:18:30PM -0500, Felipe Balbi wrote: On Wed, Sep 24, 2014 at 11:41:55PM +0200, Greg Kroah-Hartman wrote: On Wed, Sep 24, 2014 at 03:59:36PM -0500, Felipe Balbi wrote: On Wed, Sep 24, 2014 at 10:43:17PM

Re: [PATCH v5 1/4] mfd: add support for Diolan DLN-2 devices

2014-09-25 Thread Octavian Purdila
On Thu, Sep 25, 2014 at 1:30 PM, Johan Hovold jo...@kernel.org wrote: On Thu, Sep 25, 2014 at 01:25:24PM +0300, Octavian Purdila wrote: Johan, I think we don't really need the spinlock, the disconnect flag and an atomic counter should work. Do you see any issues with that? No, you need to

Re: [PATCH v5 1/4] mfd: add support for Diolan DLN-2 devices

2014-09-25 Thread Johan Hovold
On Thu, Sep 25, 2014 at 01:41:16PM +0300, Octavian Purdila wrote: On Thu, Sep 25, 2014 at 1:30 PM, Johan Hovold jo...@kernel.org wrote: On Thu, Sep 25, 2014 at 01:25:24PM +0300, Octavian Purdila wrote: Johan, I think we don't really need the spinlock, the disconnect flag and an atomic

XHCI host dies with LPM + webcam gadget

2014-09-25 Thread Amit Virdi
Hello Mathias, I'm trying to connect a webcam gadget on USB3.0 interface with xHCI host when LPM is enabled. My xHCI host is TI's TUSB7340EVM. xHCI host stops responding as soon as the webcam gadget module is inserted on the device side (The device is also running linux) Host machine kernel

Re: [PATCH] USB: Remove .owner field for driver

2014-09-25 Thread Ivan T. Ivanov
On Wed, 2014-09-24 at 16:48 +0530, Kiran Padwal wrote: There is no need to init .owner field. Based on the patch from Peter Griffin peter.grif...@linaro.org mmc: remove .owner field for drivers using module_platform_driver This patch removes the superflous .owner field for drivers which

Re: [PATCH 1/6] usb: dwc2/gadget: move phy bus legth initialization

2014-09-25 Thread Marek Szyprowski
Hi Greg and Paul, On 2014-09-09 10:44, Robert Baldyga wrote: From: Kamil Debski k.deb...@samsung.com This patch moves the part of code that initializes the PHY bus width. This results in simpler code and removes the need to check whether the Generic PHY Framework is used. I've noticed that

[PATCH net-next 3/3] r8152: support ethtool eee

2014-09-25 Thread Hayes Wang
Support get_eee() and set_eee() of ethtool_ops. Signed-off-by: Hayes Wang hayesw...@realtek.com --- drivers/net/usb/r8152.c | 128 1 file changed, 128 insertions(+) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index

[PATCH net-next 2/3] r8152: add functions to set EEE

2014-09-25 Thread Hayes Wang
Add functions to enable EEE and set EEE advertisement. Signed-off-by: Hayes Wang hayesw...@realtek.com --- drivers/net/usb/r8152.c | 101 1 file changed, 76 insertions(+), 25 deletions(-) diff --git a/drivers/net/usb/r8152.c

[PATCH net-next 1/3] r8152: change the EEE definition

2014-09-25 Thread Hayes Wang
Replace the EEE definitions with the ones which is declared in mdio.h. Chage some definitions to make them readable. Signed-off-by: Hayes Wang hayesw...@realtek.com --- drivers/net/usb/r8152.c | 35 ++- 1 file changed, 14 insertions(+), 21 deletions(-) diff

[PATCH net-next 0/3] r8152: support setting eee by ethtool

2014-09-25 Thread Hayes Wang
Modify some definitions about EEE, and add the support of setting the EEE through ethtool. Hayes Wang (3): r8152: change the EEE definition r8152: add functions to set EEE r8152: support ethtool eee drivers/net/usb/r8152.c | 246 1 file

Re: [PATCH v6 partial v2 1/3] usb: gadget: pxa27x_udc: prepare device-tree support

2014-09-25 Thread Linus Walleij
On Thu, Sep 25, 2014 at 11:47 AM, robert.jarz...@free.fr wrote: De: Linus Walleij linus.wall...@linaro.org @@ -2415,7 +2411,13 @@ static int pxa_udc_probe(struct platform_device *pdev) { struct resource *regs; struct pxa_udc *udc = memory; - int retval = 0, gpio; +

Re: [PATCH v6 partial v2 1/3] usb: gadget: pxa27x_udc: prepare device-tree support

2014-09-25 Thread Linus Walleij
On Thu, Sep 25, 2014 at 11:47 AM, robert.jarz...@free.fr wrote: } else { udv-gpiod = devm_gpiod_get(pdev-dev, ...); } Here you can also use the flags. Yeah, but my problem is in the if statement, not in the else. The else is for the DT/ACPI cases, in which there is no problem. Damned

Re: [PATCH v6 partial v2 1/3] usb: gadget: pxa27x_udc: prepare device-tree support

2014-09-25 Thread robert . jarzmik
- Mail original - De: Linus Walleij linus.wall...@linaro.org À: Robert Jarzmik robert.jarz...@free.fr Cc: Felipe Balbi ba...@ti.com, linux-usb@vger.kernel.org Envoyé: Jeudi 25 Septembre 2014 15:10:16 Objet: Re: [PATCH v6 partial v2 1/3] usb: gadget: pxa27x_udc: prepare device-tree support

Re: [PATCH v6 0/4] LED triggers for USB host and device

2014-09-25 Thread Felipe Balbi
Hi, On Thu, Sep 25, 2014 at 12:36:23PM +0200, Greg Kroah-Hartman wrote: On Wed, Sep 24, 2014 at 06:15:50PM -0500, Felipe Balbi wrote: On Wed, Sep 24, 2014 at 05:18:30PM -0500, Felipe Balbi wrote: On Wed, Sep 24, 2014 at 11:41:55PM +0200, Greg Kroah-Hartman wrote: On Wed, Sep 24, 2014 at

[PATCH] usb: core: log higher level message on malformed LANGID descriptor

2014-09-25 Thread Scot Doyle
Commit 0cce2eda19923e5e5ccc8b042dec5af87b3ffad0 USB: fix LANGID=0 regression defaults to a langid of 0x0409 if it's not properly implemented by the device. Explain with a higher level error message what this means. Signed-off-by: Scot Doyle lkm...@scotdoyle.com ---

Re: [PATCH v6 partial v2 1/3] usb: gadget: pxa27x_udc: prepare device-tree support

2014-09-25 Thread Linus Walleij
On Thu, Sep 25, 2014 at 3:44 PM, robert.jarz...@free.fr wrote: Could you also review patch 1/3 while at it ;) ? This is patch 1/3... I guess you mean the others. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to

Re: [PATCH v6 07/12] usb: chipidea: add a usb2 driver for ci13xxx

2014-09-25 Thread Felipe Balbi
Hi, On Wed, Sep 24, 2014 at 09:44:19AM +0200, Arnd Bergmann wrote: It is a good suggestion for adding DT support for core driver, Since we did not do it at the first, it is a little embarrass at current situation. - For the new chipidea glue drivers, it is ok we can have a child node

Re: [PATCH v6 07/12] usb: chipidea: add a usb2 driver for ci13xxx

2014-09-25 Thread Felipe Balbi
On Wed, Sep 24, 2014 at 02:23:38PM +0200, Arnd Bergmann wrote: On Wednesday 24 September 2014 19:29:05 Peter Chen wrote: So, it is IP CORE LIB (you suggest) vs IP CORE Platform Driver (dwc3, musb, chipidea) you are talking about, right? Except for creating another platform driver as well

Re: [PATCH] usb: core: log higher level message on malformed LANGID descriptor

2014-09-25 Thread Joe Perches
On Thu, 2014-09-25 at 13:56 +, Scot Doyle wrote: Commit 0cce2eda19923e5e5ccc8b042dec5af87b3ffad0 USB: fix LANGID=0 regression trivia: diff --git a/drivers/usb/core/message.c b/drivers/usb/core/message.c [] @@ -770,9 +770,7 @@ static int usb_get_langid(struct usb_device *dev,

[PATCH v3 3/3] mfd: viperboard: remove unused platform_device

2014-09-25 Thread Octavian Purdila
Signed-off-by: Octavian Purdila octavian.purd...@intel.com --- drivers/mfd/viperboard.c | 1 - include/linux/mfd/viperboard.h | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/mfd/viperboard.c b/drivers/mfd/viperboard.c index 57fac1d..1e7c316 100644 --- a/drivers/mfd/viperboard.c

[PATCH v3 2/3] mfd: viperboard: switch to devm_ allocation

2014-09-25 Thread Octavian Purdila
Switch to using devm_ allocation to simplify the error path. Also remove a redundant OOM error message. Signed-off-by: Octavian Purdila octavian.purd...@intel.com --- drivers/mfd/viperboard.c | 18 +- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git

[PATCH v3 0/3] mfd: viperboard: fix cache line sharing and cleanups

2014-09-25 Thread Octavian Purdila
Changes since v2: * switch to using devm_ allocation * remove unused platform_device Changes since v1: * split cache sharing fix and cleanups into separate patches Octavian Purdila (3): mfd: viperboard: allocate I/O buffer separately mfd: viperboard: switch to devm_ allocation mfd:

[PATCH v3 1/3] mfd: viperboard: allocate I/O buffer separately

2014-09-25 Thread Octavian Purdila
Currently the I/O buffer is allocated part of the device status structure, potentially sharing the same cache line with other members in this structure. Allocate the buffer separately, to avoid the I/O operations corrupting the device status structure due to cache line sharing. Compiled tested

Re: [RFC PATCH 3/4] usb: dwc3: add quirk to be compatible for AMD NL

2014-09-25 Thread Felipe Balbi
Hi, On Thu, Sep 25, 2014 at 03:21:46PM +0800, Huang Rui wrote: diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index b0f4d52..6138c5d 100644 --- a/drivers/usb/dwc3/core.c +++ b/drivers/usb/dwc3/core.c @@ -115,6 +115,25 @@ static int dwc3_core_soft_reset(struct dwc3 *dwc) }

Re: [RFC PATCH 4/4] usb: dwc3: introduce dual role switch function with debugfs

2014-09-25 Thread Felipe Balbi
Hi, On Thu, Sep 25, 2014 at 03:21:47PM +0800, Huang Rui wrote: This patch implemented a feature to dynamic switch to host or device role under debugfs for some physical limitation that unable to leverage connector A/B cables (ID pin) to change roles. The default role should be set as OTG

Re: [RFC PATCH 1/4] usb: dwc3: add AMD NL support

2014-09-25 Thread Felipe Balbi
On Thu, Sep 25, 2014 at 03:21:44PM +0800, Huang Rui wrote: Add PCI device ID of AMD NL. Signed-off-by: Huang Rui ray.hu...@amd.com --- drivers/usb/dwc3/dwc3-pci.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/dwc3/dwc3-pci.c b/drivers/usb/dwc3/dwc3-pci.c index

Re: [PATCH v6 0/4] LED triggers for USB host and device

2014-09-25 Thread Greg Kroah-Hartman
On Thu, Sep 25, 2014 at 08:56:32AM -0500, Felipe Balbi wrote: Hi, On Thu, Sep 25, 2014 at 12:36:23PM +0200, Greg Kroah-Hartman wrote: On Wed, Sep 24, 2014 at 06:15:50PM -0500, Felipe Balbi wrote: On Wed, Sep 24, 2014 at 05:18:30PM -0500, Felipe Balbi wrote: On Wed, Sep 24, 2014 at

Re: [PATCH v3 2/3] mfd: viperboard: switch to devm_ allocation

2014-09-25 Thread Johan Hovold
On Thu, Sep 25, 2014 at 05:43:16PM +0300, Octavian Purdila wrote: Switch to using devm_ allocation to simplify the error path. Also remove a redundant OOM error message. Signed-off-by: Octavian Purdila octavian.purd...@intel.com --- drivers/mfd/viperboard.c | 18 +- 1 file

Re: [PATCH v6 3/4] usb: Rename usb-common.c

2014-09-25 Thread Greg Kroah-Hartman
On Wed, Sep 24, 2014 at 10:43:20PM +0200, Michal Sojka wrote: In the next commit, we will want the usb-common module to be composed of two object files. Since Kbuild cannot append another object to an existing one, we need to rename usb-common.c to something else (common.c) and create

Re: MUSB: extra cppi irq?

2014-09-25 Thread Felipe Balbi
Hi Bin, On Wed, Sep 24, 2014 at 01:55:14PM -0500, Bin Liu wrote: Hi Felipe and all, The musb driver musb_host_tx() has the following: 1244 /* with CPPI, DMA sometimes triggers extra irqs */ 1245 if (!urb) { 1246 dev_dbg(musb-controller, extra TX%d ready,

Re: [PATCH v3 3/3] mfd: viperboard: remove unused platform_device

2014-09-25 Thread Johan Hovold
On Thu, Sep 25, 2014 at 05:43:17PM +0300, Octavian Purdila wrote: Where's the commit message body? Signed-off-by: Octavian Purdila octavian.purd...@intel.com --- drivers/mfd/viperboard.c | 1 - include/linux/mfd/viperboard.h | 1 - 2 files changed, 2 deletions(-) diff --git

Re: Poor performance with USB 1.1 drive connected to USB 3.0 port

2014-09-25 Thread Alan Stern
On Wed, 24 Sep 2014, Mark Knibbs wrote: On Wed, 24 Sep 2014 11:37:11 -0400 (EDT) Alan Stern st...@rowland.harvard.edu wrote: On Wed, 24 Sep 2014, Mark Knibbs wrote: I did some benchmarks to check the maximum transfer rate of a USB-to-SCSI converter. The converter is USB 1.1, so

[PATCH v2] usb: core: log higher level message on malformed LANGID descriptor

2014-09-25 Thread Scot Doyle
Commit 0cce2eda19923e5e5ccc8b042dec5af87b3ffad0 USB: fix LANGID=0 regression defaults to a langid of 0x0409 if it's not properly implemented by the device. Explain with a higher level error message what this means. Signed-off-by: Scot Doyle lkm...@scotdoyle.com ---

Re: [PATCH v3 3/3] mfd: viperboard: remove unused platform_device

2014-09-25 Thread Octavian Purdila
On Thu, Sep 25, 2014 at 6:07 PM, Johan Hovold jo...@kernel.org wrote: On Thu, Sep 25, 2014 at 05:43:17PM +0300, Octavian Purdila wrote: Where's the commit message body? Signed-off-by: Octavian Purdila octavian.purd...@intel.com --- drivers/mfd/viperboard.c | 1 -

Re: [PATCH v3 3/3] mfd: viperboard: remove unused platform_device

2014-09-25 Thread Johan Hovold
On Thu, Sep 25, 2014 at 06:29:48PM +0300, Octavian Purdila wrote: On Thu, Sep 25, 2014 at 6:07 PM, Johan Hovold jo...@kernel.org wrote: Still feels like the kind of clean up that should have a Tested-by. Unfortunately I do not have access to hardware to test. On second thought,

[PATCH v4 2/3] mfd: viperboard: switch to devm_ allocation

2014-09-25 Thread Octavian Purdila
Switch to using devm_ allocation to simplify the error path. Also remove a redundant OOM error message. Signed-off-by: Octavian Purdila octavian.purd...@intel.com --- drivers/mfd/viperboard.c | 23 +++ 1 file changed, 7 insertions(+), 16 deletions(-) diff --git

[PATCH v4 1/3] mfd: viperboard: allocate I/O buffer separately

2014-09-25 Thread Octavian Purdila
Currently the I/O buffer is allocated part of the device status structure, potentially sharing the same cache line with other members in this structure. Allocate the buffer separately, to avoid the I/O operations corrupting the device status structure due to cache line sharing. Compiled tested

[PATCH v4 3/3] mfd: viperboard: remove unused platform_device

2014-09-25 Thread Octavian Purdila
Remove pdev field from struct vpbrd as it is not used in the MFD driver or in any of the sub-drivers. Signed-off-by: Octavian Purdila octavian.purd...@intel.com --- drivers/mfd/viperboard.c | 1 - include/linux/mfd/viperboard.h | 1 - 2 files changed, 2 deletions(-) diff --git

[PATCH v4 0/3] mfd: viperboard: fix cache line sharing and cleanups

2014-09-25 Thread Octavian Purdila
Changes since v3: * undo a whitespace change * one more error path cleanup * add commit body to the last patch Changes since v2: * switch to using devm_ allocation * remove unused platform_device Changes since v1: * split cache sharing fix and cleanups into separate patches

project wide: git config entry for [diff] renames=true

2014-09-25 Thread Joe Perches
On Thu, 2014-09-25 at 17:03 +0200, Greg Kroah-Hartman wrote: In the future, please generate a git move diff, which makes it easier to review, and prove that nothing really changed. It also helps if the file is a bit different from what you diffed against, which in my case, was true. Maybe

Re: [PATCH v4 1/3] mfd: viperboard: allocate I/O buffer separately

2014-09-25 Thread Johan Hovold
On Thu, Sep 25, 2014 at 06:41:35PM +0300, Octavian Purdila wrote: Currently the I/O buffer is allocated part of the device status structure, potentially sharing the same cache line with other members in this structure. Allocate the buffer separately, to avoid the I/O operations corrupting

Re: [PATCH v4 2/3] mfd: viperboard: switch to devm_ allocation

2014-09-25 Thread Johan Hovold
On Thu, Sep 25, 2014 at 06:41:36PM +0300, Octavian Purdila wrote: Switch to using devm_ allocation to simplify the error path. Also remove a redundant OOM error message. Signed-off-by: Octavian Purdila octavian.purd...@intel.com Reviewed-by: Johan Hovold jo...@kernel.org ---

Re: [PATCH v4 3/3] mfd: viperboard: remove unused platform_device

2014-09-25 Thread Johan Hovold
On Thu, Sep 25, 2014 at 06:41:37PM +0300, Octavian Purdila wrote: Remove pdev field from struct vpbrd as it is not used in the MFD driver or in any of the sub-drivers. Signed-off-by: Octavian Purdila octavian.purd...@intel.com Reviewed-by: Johan Hovold jo...@kernel.org ---

[PATCH v6 4/4] gpio: add support for the Diolan DLN-2 USB GPIO driver

2014-09-25 Thread Octavian Purdila
From: Daniel Baluta daniel.bal...@intel.com This patch adds GPIO and IRQ support for the Diolan DLN-2 GPIO module. Information about the USB protocol interface can be found in the Programmer's Reference Manual [1], see section 2.9 for the GPIO module commands and responses. [1]

[PATCH v6 3/4] gpiolib: add irq_not_threaded flag to gpio_chip

2014-09-25 Thread Octavian Purdila
Some GPIO chips (e.g. the DLN2 USB adapter) have blocking get/set operation but do not need a threaded irq handler. Signed-off-by: Octavian Purdila octavian.purd...@intel.com --- drivers/gpio/gpiolib.c | 2 +- include/linux/gpio/driver.h | 3 +++ 2 files changed, 4 insertions(+), 1

[PATCH v6 1/4] mfd: add support for Diolan DLN-2 devices

2014-09-25 Thread Octavian Purdila
This patch implements the USB part of the Diolan USB-I2C/SPI/GPIO Master Adapter DLN-2. Details about the device can be found here: https://www.diolan.com/i2c/i2c_interface.html. Information about the USB protocol can be found in the Programmer's Reference Manual [1], see section 1.7. Because

[PATCH v6 2/4] i2c: add support for Diolan DLN-2 USB-I2C adapter

2014-09-25 Thread Octavian Purdila
From: Laurentiu Palcu laurentiu.pa...@intel.com This patch adds support for the Diolan DLN-2 I2C master module. Due to hardware limitations it does not support SMBUS quick commands. Information about the USB protocol interface can be found in the Programmer's Reference Manual [1], see section

[PATCH v6 0/4] mfd: add support for Diolan DLN-2

2014-09-25 Thread Octavian Purdila
This patch series adds support for Diolan USB-I2C/GPIO Master Adapter DLN-2. Details about device can be found here: https://www.diolan.com/i2c/i2c_interface.html. Changes since v5: * MFD: use enum for handles, fix a couple of miss spells, rename a few fields for clarity, rework the

RE: g_mass_storage bug ?

2014-09-25 Thread Paul Zimmerman
From: Felipe Balbi [mailto:ba...@ti.com] Sent: Wednesday, September 24, 2014 7:41 PM On Thu, Sep 25, 2014 at 01:37:05AM +, Paul Zimmerman wrote: Then, after the host cleared the halt, the gadget apparently sent the data that _should_ have been sent previously. The host was

RE: g_mass_storage bug ?

2014-09-25 Thread Paul Zimmerman
From: Felipe Balbi [mailto:ba...@ti.com] On Wed, Sep 24, 2014 at 09:40:37PM -0500, Felipe Balbi wrote: On Thu, Sep 25, 2014 at 01:37:05AM +, Paul Zimmerman wrote: Then, after the host cleared the halt, the gadget apparently sent the data that _should_ have been sent

Re: project wide: git config entry for [diff] renames=true

2014-09-25 Thread Jeff King
On Thu, Sep 25, 2014 at 08:48:31AM -0700, Joe Perches wrote: On Thu, 2014-09-25 at 17:03 +0200, Greg Kroah-Hartman wrote: In the future, please generate a git move diff, which makes it easier to review, and prove that nothing really changed. It also helps if the file is a bit different

Re: [PATCH v6 partial v2 1/3] usb: gadget: pxa27x_udc: prepare device-tree support

2014-09-25 Thread Robert Jarzmik
Linus Walleij linus.wall...@linaro.org writes: On Thu, Sep 25, 2014 at 3:44 PM, robert.jarz...@free.fr wrote: Could you also review patch 1/3 while at it ;) ? This is patch 1/3... I guess you mean the others. Ah yeah, I meant patch 3/3, slipped on the keyboard. A full review is always

RE: g_mass_storage bug ?

2014-09-25 Thread Alan Stern
On Thu, 25 Sep 2014, Paul Zimmerman wrote: That's why I don't understand how this can happen for IN. AFAIK, a STALL is only sent in response to something the host sent in the CBW. At that point, there shouldn't be any IN transfers active. The gadget may send a partial response to the CBW.

Re: project wide: git config entry for [diff] renames=true

2014-09-25 Thread Joe Perches
On Thu, 2014-09-25 at 14:00 -0400, Jeff King wrote: On Thu, Sep 25, 2014 at 08:48:31AM -0700, Joe Perches wrote: On Thu, 2014-09-25 at 17:03 +0200, Greg Kroah-Hartman wrote: In the future, please generate a git move diff, which makes it easier to review, and prove that nothing really

Re: project wide: git config entry for [diff] renames=true

2014-09-25 Thread Junio C Hamano
Joe Perches j...@perches.com writes: On Thu, 2014-09-25 at 14:00 -0400, Jeff King wrote: ... diff.renames is probably safe, but any config-sharing mechanism would have to deal with either whitelisting, or providing some mechanism for the puller to review changes before blindly following

Re: project wide: git config entry for [diff] renames=true

2014-09-25 Thread Junio C Hamano
Jeff King p...@peff.net writes: There is no such mechanism within git. We've resisted adding one because of the danger of something like: [diff] external = rm -rf / diff.renames is probably safe, but any config-sharing mechanism would have to deal with either whitelisting, or

RE: g_mass_storage bug ?

2014-09-25 Thread Paul Zimmerman
From: Alan Stern [mailto:st...@rowland.harvard.edu] Sent: Thursday, September 25, 2014 11:08 AM On Thu, 25 Sep 2014, Paul Zimmerman wrote: That's why I don't understand how this can happen for IN. AFAIK, a STALL is only sent in response to something the host sent in the CBW. At that

Re: [PATCH 00/27] add pm_runtime_last_busy_and_autosuspend() helper

2014-09-25 Thread Rafael J. Wysocki
On Thursday, September 25, 2014 04:27:58 PM Wolfram Sang wrote: --Bn2rw/3z4jIqBvZU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 25, 2014 at 09:22:01AM -0500, Felipe Balbi wrote: On Thu, Sep 25, 2014 at

RE: g_mass_storage bug ?

2014-09-25 Thread Paul Zimmerman
From: Paul Zimmerman From: Felipe Balbi [mailto:ba...@ti.com] On Wed, Sep 24, 2014 at 09:40:37PM -0500, Felipe Balbi wrote: On Thu, Sep 25, 2014 at 01:37:05AM +, Paul Zimmerman wrote: Then, after the host cleared the halt, the gadget apparently sent the data

Re: [PATCH v6 07/12] usb: chipidea: add a usb2 driver for ci13xxx

2014-09-25 Thread Antoine Tenart
Arnd, On Thu, Sep 25, 2014 at 09:12:07PM +0200, Arnd Bergmann wrote: On Tuesday 23 September 2014, Antoine Tenart wrote: +static int ci_hdrc_usb2_dt_probe(struct device *dev, +struct ci_hdrc_platform_data *ci_pdata) +{ + ci_pdata-phy =

Re: g_mass_storage bug ?

2014-09-25 Thread Felipe Balbi
On Thu, Sep 25, 2014 at 05:54:10PM +, Paul Zimmerman wrote: From: Felipe Balbi [mailto:ba...@ti.com] On Wed, Sep 24, 2014 at 09:40:37PM -0500, Felipe Balbi wrote: On Thu, Sep 25, 2014 at 01:37:05AM +, Paul Zimmerman wrote: Then, after the host cleared the halt, the gadget

Re: g_mass_storage bug ?

2014-09-25 Thread Felipe Balbi
On Thu, Sep 25, 2014 at 07:43:35PM +, Paul Zimmerman wrote: From: Paul Zimmerman From: Felipe Balbi [mailto:ba...@ti.com] On Wed, Sep 24, 2014 at 09:40:37PM -0500, Felipe Balbi wrote: On Thu, Sep 25, 2014 at 01:37:05AM +, Paul Zimmerman wrote: Then, after the host

Re: g_mass_storage bug ?

2014-09-25 Thread Felipe Balbi
Hi, On Thu, Sep 25, 2014 at 05:50:59PM +, Paul Zimmerman wrote: From: Felipe Balbi [mailto:ba...@ti.com] Sent: Wednesday, September 24, 2014 7:41 PM On Thu, Sep 25, 2014 at 01:37:05AM +, Paul Zimmerman wrote: Then, after the host cleared the halt, the gadget apparently sent

Re: g_mass_storage bug ?

2014-09-25 Thread Felipe Balbi
Hi, On Thu, Sep 25, 2014 at 07:08:12PM +, Paul Zimmerman wrote: From: Alan Stern [mailto:st...@rowland.harvard.edu] Sent: Thursday, September 25, 2014 11:08 AM On Thu, 25 Sep 2014, Paul Zimmerman wrote: That's why I don't understand how this can happen for IN. AFAIK, a STALL

Re: [PATCH v6 partial v2 2/3] usb: gadget: pxa27x_udc: transfer mach_info into pxa_udc

2014-09-25 Thread Felipe Balbi
On Wed, Sep 24, 2014 at 11:06:00PM +0200, Robert Jarzmik wrote: Convert the mach info, and store the udc_command in the pxa_udc control structure. It is to be noticed that the udc_is_connected() in mach info is not transfered. This was not used, as mioa701 machine doesn't need it, balloon3

RE: g_mass_storage bug ?

2014-09-25 Thread Paul Zimmerman
From: Felipe Balbi [mailto:ba...@ti.com] On Thu, Sep 25, 2014 at 07:08:12PM +, Paul Zimmerman wrote: From: Alan Stern [mailto:st...@rowland.harvard.edu] Sent: Thursday, September 25, 2014 11:08 AM On Thu, 25 Sep 2014, Paul Zimmerman wrote: That's why I don't understand

RE: g_mass_storage bug ?

2014-09-25 Thread Paul Zimmerman
From the 2.70a databook, section 8.2.2: Sorry, it's databook section 8.2.3, not 8.2.2. -- Paul From: Paul Zimmerman Sent: Thursday, September 25, 2014 2:58 PM From: Felipe Balbi [mailto:ba...@ti.com] On Thu, Sep 25, 2014 at 07:08:12PM +, Paul Zimmerman wrote: From: Alan

Re: g_mass_storage bug ?

2014-09-25 Thread Felipe Balbi
Hi, On Thu, Sep 25, 2014 at 09:57:59PM +, Paul Zimmerman wrote: From: Felipe Balbi [mailto:ba...@ti.com] On Thu, Sep 25, 2014 at 07:08:12PM +, Paul Zimmerman wrote: From: Alan Stern [mailto:st...@rowland.harvard.edu] Sent: Thursday, September 25, 2014 11:08 AM On

Re: [PATCH v6 07/12] usb: chipidea: add a usb2 driver for ci13xxx

2014-09-25 Thread Peter Chen
On Thu, Sep 25, 2014 at 09:15:53AM -0500, Felipe Balbi wrote: On Wed, Sep 24, 2014 at 02:23:38PM +0200, Arnd Bergmann wrote: On Wednesday 24 September 2014 19:29:05 Peter Chen wrote: So, it is IP CORE LIB (you suggest) vs IP CORE Platform Driver (dwc3, musb, chipidea) you are talking

Re: [PATCH v6 07/12] usb: chipidea: add a usb2 driver for ci13xxx

2014-09-25 Thread Peter Chen
On Thu, Sep 25, 2014 at 09:11:35AM +0200, Arnd Bergmann wrote: On Thursday 25 September 2014 09:16:48 Peter Chen wrote: + } + + if (dev-of_node) { + ret = ci_hdrc_usb2_dt_probe(dev, ci_pdata); + if (ret) + goto clk_err; +

Re: [PATCH v6 07/12] usb: chipidea: add a usb2 driver for ci13xxx

2014-09-25 Thread Felipe Balbi
HI, On Fri, Sep 26, 2014 at 07:39:34AM +0800, Peter Chen wrote: On Thu, Sep 25, 2014 at 09:15:53AM -0500, Felipe Balbi wrote: On Wed, Sep 24, 2014 at 02:23:38PM +0200, Arnd Bergmann wrote: On Wednesday 24 September 2014 19:29:05 Peter Chen wrote: So, it is IP CORE LIB (you suggest)

Re: [PATCH v6 07/12] usb: chipidea: add a usb2 driver for ci13xxx

2014-09-25 Thread Felipe Balbi
Hi again, On Thu, Sep 25, 2014 at 07:37:50PM -0500, Felipe Balbi wrote: On Fri, Sep 26, 2014 at 07:39:34AM +0800, Peter Chen wrote: On Thu, Sep 25, 2014 at 09:15:53AM -0500, Felipe Balbi wrote: On Wed, Sep 24, 2014 at 02:23:38PM +0200, Arnd Bergmann wrote: On Wednesday 24 September 2014

Re: [RFC PATCH 1/4] usb: dwc3: add AMD NL support

2014-09-25 Thread Huang Rui
Hi Felipe, On Thu, Sep 25, 2014 at 09:53:55AM -0500, Felipe Balbi wrote: On Thu, Sep 25, 2014 at 03:21:44PM +0800, Huang Rui wrote: Add PCI device ID of AMD NL. Signed-off-by: Huang Rui ray.hu...@amd.com --- drivers/usb/dwc3/dwc3-pci.c | 2 ++ 1 file changed, 2 insertions(+)

Re: [RFC PATCH 1/4] usb: dwc3: add AMD NL support

2014-09-25 Thread Felipe Balbi
Hi, On Fri, Sep 26, 2014 at 12:53:21PM +0800, Huang Rui wrote: On Thu, Sep 25, 2014 at 09:53:55AM -0500, Felipe Balbi wrote: On Thu, Sep 25, 2014 at 03:21:44PM +0800, Huang Rui wrote: Add PCI device ID of AMD NL. Signed-off-by: Huang Rui ray.hu...@amd.com ---