[PATCH] usb: ehci/ohci-exynos: Fix of_node_put() for child when getting PHYs

2014-10-06 Thread Vivek Gautam
On enabling CONFIG_OF_SELFTEST which enables CONFIG_OF_DYNAMIC, we found out that while getting PHYs for the controller we were doing an extra of_node_put on the child node in our routines - exynos_e/ohci_get_phy(). This child is however already put by of_get_next_available_child() which does a

RE: [PATCH] drivers: usb :fsl: Add support for USB controller version-2.5

2014-10-06 Thread nikhil.bad...@freescale.com
-Original Message- From: Greg KH [mailto:g...@kroah.com] Sent: Monday, September 29, 2014 11:56 AM To: Badola Nikhil-B46172 Cc: linux-usb@vger.kernel.org Subject: Re: [PATCH] drivers: usb :fsl: Add support for USB controller version- 2.5 On Mon, Sep 29, 2014 at 03:46:02AM

Re: Question about calculate trbs in xhci

2014-10-06 Thread vichy
hi Mathias: As I understood it, it is ok to cross page boundaries as long as the buffer is physically contiguous. As our dma case should be. xhci specification section 3.2.8 says that: Note that no constraints are placed on the TRB Length fields in a Scatter/Gather list. Classically all

[PATCH 0/4] Remove optional dependencies on PLAT_S5P

2014-10-06 Thread Paul Bolle
Commit d78c16ccde96 (ARM: SAMSUNG: Remove remaining legacy code) removed the Kconfig symbol PLAT_S5P. The seven dependencies on that symbol have evaluated to false since next-20140716 (for linux-next) and v3.17-rc1 (for mainline). Probably no one noticed because these are all optional

[PATCH 4/4] usb: host: Remove optional dependencies on PLAT_S5P

2014-10-06 Thread Paul Bolle
Commit d78c16ccde96 (ARM: SAMSUNG: Remove remaining legacy code) removed the Kconfig symbol PLAT_S5P. Remove two optional dependencies on that symbol from this Kconfig file too. Signed-off-by: Paul Bolle pebo...@tiscali.nl --- drivers/usb/host/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2

RE: Question about calculate trbs in xhci

2014-10-06 Thread David Laight
From: Paul Zimmerman ... The xhi hardware doesn't have that constraint, but has the different constraints: 1) A buffer must not cross a 64k address boundary. 2) A LINK TRB (at the end of the ring) must only occur at a USB message boundary (actually it is a slightly tighter

RE: Question about calculate trbs in xhci

2014-10-06 Thread David Laight
From: vichy hi Mathias: As I understood it, it is ok to cross page boundaries as long as the buffer is physically contiguous. As our dma case should be. xhci specification section 3.2.8 says that: Note that no constraints are placed on the TRB Length fields in a Scatter/Gather

Re: [PATCH] [next-20141003] USB: host: st: fix typo 'CONFIG_USB_EHCI_HCD_ST'

2014-10-06 Thread Peter Griffin
On Fri, 03 Oct 2014, Paul Bolle wrote: Signed-off-by: Paul Bolle pebo...@tiscali.nl Fixes: 905e300e1043 (USB: host: st: fix ehci/ohci driver selection) Acked-by: Peter Griffin peter.grif...@linaro.org -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a

Re: [PATCH 2/2] arm: shmobile: lager: enable HS-USB

2014-10-06 Thread Sergei Shtylyov
Hello. On 10/6/2014 4:59 AM, Yoshihiro Shimoda wrote: Signed-off-by: Yoshihiro Shimoda yoshihiro.shimoda...@renesas.com --- arch/arm/boot/dts/r8a7790-lager.dts |5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm/boot/dts/r8a7790-lager.dts

[PATCH] usb: gadget: f_fs: add zombie mode

2014-10-06 Thread Robert Baldyga
Since we can compose gadgets from many functions, there is the problem related to gadget breakage while FunctionFS daemon being closed. In some cases it's strongly desired to keep gadget alive for a while, despite FunctionFS files are closed, to allow another functions to complete some presumably

btusb_intr_complete returns -EPIPE

2014-10-06 Thread Naveen Kumar Parna
Hi, I am using “3.1.0-7.fc16.x86_64” kernel and testing eight USB Bluetooth dongles using btusb.ko module. Once I power-on the system and loading the btusb.ko driver immediately results the below mentioned errors: [ 1389.410907] hci3 urb 88012954dd80 status -32 count 0 [ 1389.411367]

Re: [PATCH v6 1/4] mfd: add support for Diolan DLN-2 devices

2014-10-06 Thread Octavian Purdila
On Fri, Oct 3, 2014 at 8:12 PM, Johan Hovold jo...@kernel.org wrote: On Thu, Sep 25, 2014 at 07:07:31PM +0300, Octavian Purdila wrote: This patch implements the USB part of the Diolan USB-I2C/SPI/GPIO Master Adapter DLN-2. Details about the device can be found here: snip + +

btusb_intr_complete returns -EPIPE

2014-10-06 Thread Naveen Kumar Parna
Hi, I am using “3.1.0-7.fc16.x86_64” kernel and testing eight USB Bluetooth dongles using btusb.ko module. Once I power-on the system and loading the btusb.ko driver immediately results the below mentioned errors: [ 1389.410907] hci3 urb 88012954dd80 status -32 count 0 [ 1389.411367]

Re: btusb_intr_complete returns -EPIPE

2014-10-06 Thread Oliver Neukum
On Mon, 2014-10-06 at 17:05 +0530, Naveen Kumar Parna wrote: These errors will repeat until sending a proper HCI command on the USB bus. Again after some time duration same error will repeats. The error -32(-EPIPE) says , Endpoint stalled. For non-control endpoints, reset this status with

Re: Question about calculate trbs in xhci

2014-10-06 Thread Mathias Nyman
On 10/06/2014 11:37 AM, vichy wrote: hi Mathias: As I understood it, it is ok to cross page boundaries as long as the buffer is physically contiguous. As our dma case should be. xhci specification section 3.2.8 says that: Note that no constraints are placed on the TRB Length fields in a

Re: [PATCH] usb: gadget: f_fs: add zombie mode

2014-10-06 Thread Michal Nazarewicz
On Mon, Oct 06 2014, Robert Baldyga r.bald...@samsung.com wrote: Since we can compose gadgets from many functions, there is the problem related to gadget breakage while FunctionFS daemon being closed. In some cases it's strongly desired to keep gadget alive for a while, despite FunctionFS

Re: [PATCH] usb: gadget: f_fs: add zombie mode

2014-10-06 Thread Robert Baldyga
On 10/06/2014 02:36 PM, Michal Nazarewicz wrote: On Mon, Oct 06 2014, Robert Baldyga r.bald...@samsung.com wrote: Since we can compose gadgets from many functions, there is the problem related to gadget breakage while FunctionFS daemon being closed. In some cases it's strongly desired to keep

[PATCH v3 1/3] mfd: add support for Cypress CYUSBS234 USB Serial Bridge controller

2014-10-06 Thread Muthu Mani
Adds support for USB-I2C/GPIO interfaces of Cypress Semiconductor CYUSBS234 USB-Serial Bridge controller. Details about the device can be found at: http://www.cypress.com/?rID=84126 Signed-off-by: Muthu Mani m...@cypress.com Signed-off-by: Rajaram Regupathy r...@cypress.com ---

[PATCH v3 2/3] i2c: add support for Cypress CYUSBS234 USB-I2C adapter

2014-10-06 Thread Muthu Mani
Adds support for USB-I2C interface of Cypress Semiconductor CYUSBS234 USB-Serial Bridge controller. The read/write operation is setup using vendor command through control endpoint and actual data transfer happens through bulk in/out endpoints. Details about the device can be found at:

[PATCH v3 3/3] gpio: add support for Cypress CYUSBS234 USB-GPIO adapter

2014-10-06 Thread Muthu Mani
Adds support for USB-GPIO interface of Cypress Semiconductor CYUSBS234 USB-Serial Bridge controller. The GPIO get/set can be done through vendor command on control endpoint for the configured gpios. Details about the device can be found at: http://www.cypress.com/?rID=84126 Signed-off-by: Muthu

Re: btusb_intr_complete returns -EPIPE

2014-10-06 Thread Oliver Neukum
On Mon, 2014-10-06 at 18:18 +0530, Naveen Kumar Parna wrote: Hi, I just collected the usbmon log(1.mon.out) and attached it. It stalls for INT in transfers. Corresponding kernel log is here: Oct 6 18:00:48 naveen-OptiPlex-745 kernel: [ 7528.718473] hci3 urb 88012954dd80 status -32

Re: btusb_intr_complete returns -EPIPE

2014-10-06 Thread Naveen Kumar Parna
Thank you very much. I will try that patch. Thanks, Naveen On Mon, Oct 6, 2014 at 6:25 PM, Oliver Neukum oneu...@suse.de wrote: On Mon, 2014-10-06 at 18:18 +0530, Naveen Kumar Parna wrote: Hi, I just collected the usbmon log(1.mon.out) and attached it. It stalls for INT in transfers.

Re: [PATCH 1/2] USB: EHCI: add portpower callback and override

2014-10-06 Thread Michael Grzeschik
On Fri, Sep 26, 2014 at 10:42:35AM -0400, Alan Stern wrote: On Fri, 26 Sep 2014, Michael Grzeschik wrote: The current EHCI implementation is prepared to toggle the PORT_POWER bit to enable or disable a USB-Port. In some cases this port power can not be toggled by the PORT_POWER bit but

Re: btusb_intr_complete returns -EPIPE

2014-10-06 Thread Oliver Neukum
On Mon, 2014-10-06 at 18:33 +0530, Naveen Kumar Parna wrote: Thank you very much. I will try that patch. Then please try. Regards Oliver From f9f74591abed07ee71c46d443dd10176d05096c5 Mon Sep 17 00:00:00 2001 From: Oliver Neukum oneu...@suse.de Date: Mon, 6 Oct 2014

Re: [PATCH] USB: quirks: enable device-qualifier quirk for another Elan touchscreen

2014-10-06 Thread Adel Gadllah
Hi, This extends the patch set from Johan which introduced the quirk and applied it to the usb device 0x04f3, 0x0089. I have similar symptoms on my device during boot up (long delay, -71 errors). I didn't expirence any disconnects though so the second quirk (always poll) does not appear to be

Re: [PATCH v3 1/3] mfd: add support for Cypress CYUSBS234 USB Serial Bridge controller

2014-10-06 Thread Johan Hovold
On Mon, Oct 06, 2014 at 06:22:29PM +0530, Muthu Mani wrote: Adds support for USB-I2C/GPIO interfaces of Cypress Semiconductor CYUSBS234 USB-Serial Bridge controller. Details about the device can be found at: http://www.cypress.com/?rID=84126 Signed-off-by: Muthu Mani m...@cypress.com

Re: [PATCH 1/2] USB: EHCI: add portpower callback and override

2014-10-06 Thread Michael Grzeschik
On Sun, Sep 28, 2014 at 10:30:53AM +0800, Peter Chen wrote: On Fri, Sep 26, 2014 at 10:42:35AM -0400, Alan Stern wrote: On Fri, 26 Sep 2014, Michael Grzeschik wrote: The current EHCI implementation is prepared to toggle the PORT_POWER bit to enable or disable a USB-Port. In some

[PATCH] HID: usbhid: enable always-poll quirk for Elan Touchscreen 009b

2014-10-06 Thread Adel Gadllah
This is based on Johan's patches that add the quirk. It need is needed for this device as well. Adel Gadllah (1): HID: usbhid: enable always-poll quirk for Elan Touchscreen 009b drivers/hid/hid-ids.h | 1 + drivers/hid/usbhid/hid-quirks.c | 1 + 2 files changed, 2 insertions(+) --

[PATCH] HID: usbhid: enable always-poll quirk for Elan Touchscreen 009b

2014-10-06 Thread Adel Gadllah
This device needs the quirk as well. Signed-off-by: Adel Gadllah adel.gadl...@gmail.com --- drivers/hid/hid-ids.h | 1 + drivers/hid/usbhid/hid-quirks.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h index 79b966d..2c3c4d3 100644 ---

Re: [PATCH] usb: gadget: f_fs: add zombie mode

2014-10-06 Thread Michal Nazarewicz
On 10/06/2014 02:36 PM, Michal Nazarewicz wrote: However, all the ep# files will still exist on the filesystem. This may be a bit confusing and error-prone, no? On Mon, Oct 06 2014, Robert Baldyga r.bald...@samsung.com wrote: Shouldn't be error-prone, because opening them will fail with

Re: [PATCH 1/2] USB: EHCI: add portpower callback and override

2014-10-06 Thread Alan Stern
On Mon, 6 Oct 2014, Michael Grzeschik wrote: The implementation leaves something to be desired. Instead of keeping the current port-power code in ehci-hcd inline, as it is, you should define a default callback routine to do the work. Then the override can replace the default callback.

[PATCH v3 3/3] gpio: add support for Cypress CYUSBS234 USB-GPIO adapter

2014-10-06 Thread Muthu Mani
Adds support for USB-GPIO interface of Cypress Semiconductor CYUSBS234 USB-Serial Bridge controller. The GPIO get/set can be done through vendor command on control endpoint for the configured gpios. Details about the device can be found at: http://www.cypress.com/?rID=84126 Signed-off-by: Muthu

Re: btusb_intr_complete returns -EPIPE

2014-10-06 Thread Oliver Neukum
On Mon, 2014-10-06 at 20:08 +0530, Naveen Kumar Parna wrote: Thanks for the patch. I tried and It crashed after the first occurrence of EPIPE. Crash log is attached. Could you post a full lsusb -v? Regards Oliver -- To unsubscribe from this list: send the line

[PATCH v3 1/3] mfd: add support for Cypress CYUSBS234 USB Serial Bridge controller

2014-10-06 Thread Muthu Mani
Adds support for USB-I2C/GPIO interfaces of Cypress Semiconductor CYUSBS234 USB-Serial Bridge controller. Details about the device can be found at: http://www.cypress.com/?rID=84126 Signed-off-by: Muthu Mani m...@cypress.com Signed-off-by: Rajaram Regupathy r...@cypress.com --- Changes since v2:

[PATCH v3 2/3] i2c: add support for Cypress CYUSBS234 USB-I2C adapter

2014-10-06 Thread Muthu Mani
Adds support for USB-I2C interface of Cypress Semiconductor CYUSBS234 USB-Serial Bridge controller. The read/write operation is setup using vendor command through control endpoint and actual data transfer happens through bulk in/out endpoints. Details about the device can be found at:

[PATCH] usb: Remove references to non-existent PLAT_S5P symbol

2014-10-06 Thread Sylwester Nawrocki
The PLAT_S5P Kconfig symbol was removed in commit d78c16ccde96 (ARM: SAMSUNG: Remove remaining legacy code). There are still some references left, fix that by replacing them with ARCH_S5PV210. Reported-by: Paul Bolle pebo...@tiscali.nl Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com ---

[PATCH 01/17] usb: isp1760: Retrieve pdev memory resource from hcd at remove time

2014-10-06 Thread Laurent Pinchart
The platform driver remove function needs to release the memory resource requested at probe time. Instead of retrieving the resource from the platform device, retrieve it from the usb_hcd. This mimics the behaviour of the PCI and OF glues, and will make it easier to share code between all three

[PATCH 03/17] usb: isp1760: Manage device driver data in common code

2014-10-06 Thread Laurent Pinchart
Don't duplicate *_set_drvdata calls in glue code. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/usb/host/isp1760-hcd.c | 2 ++ drivers/usb/host/isp1760-if.c | 4 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/usb/host/isp1760-hcd.c

[PATCH 08/17] usb: isp1760: Pass resource pointer to isp1760_register

2014-10-06 Thread Laurent Pinchart
The function takes quite a few arguments, passing the resource pointer instead of the start address and length simplifies it a bit. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/usb/host/isp1760-hcd.c | 11 +-- drivers/usb/host/isp1760-hcd.h | 5 ++---

[PATCH 11/17] usb: isp1760: Reorganize header files

2014-10-06 Thread Laurent Pinchart
The isp1760-rhcd.h header contains PTD constants and structures only useful for the HCD implementation. It also contains register definitions that will be needed by common code when implementing support for the ISP1761 device controller, but doesn't contain the isp1760_hcd structure definition

[PATCH 00/17] Add UDC support to the isp1760 driver

2014-10-06 Thread Laurent Pinchart
Hello, This patch set adds UDC support to the isp1760 driver, to be used with the ISP1761 dual-role USB controller. The first 16 patches rework the isp1760 driver to prepare it for UDC support. In particular it removes the direct HCD dependencies from the glue code (01/17 to 04/17), creates core

[PATCH 12/17] usb: isp1760: Move core code to isp1760-core.c

2014-10-06 Thread Laurent Pinchart
Move core device initialization to a central location in order to share it with the device mode implementation. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/usb/host/Makefile | 2 +- drivers/usb/host/isp1760-core.c | 90

[PATCH 02/17] usb: isp1760: Move removal cleanup code to isp1760-hcd.c

2014-10-06 Thread Laurent Pinchart
The removal cleanup code is duplicated between the different bus glues. Move it to a central location. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/usb/host/isp1760-hcd.c | 15 drivers/usb/host/isp1760-hcd.h | 2 ++ drivers/usb/host/isp1760-if.c | 80

[PATCH 06/17] usb: isp1760: Prefix init_kmem_once and deinit_kmem_cache with isp1760_

2014-10-06 Thread Laurent Pinchart
The two functions are specific to the driver but have very generic names, subject to collisions. Rename them. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/usb/host/isp1760-hcd.c | 4 ++-- drivers/usb/host/isp1760-hcd.h | 4 ++-- drivers/usb/host/isp1760-if.c | 6

[PATCH 13/17] usb: isp1760: Move GPIO request to common code

2014-10-06 Thread Laurent Pinchart
The code isn't specific to a glue layer, move it to a common location. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/usb/host/isp1760-core.c | 15 +++ drivers/usb/host/isp1760-if.c | 20 +++- 2 files changed, 18 insertions(+), 17

[PATCH 05/17] usb: isp1760: Fix indentation in probe error path

2014-10-06 Thread Laurent Pinchart
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/usb/host/isp1760-hcd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/host/isp1760-hcd.c b/drivers/usb/host/isp1760-hcd.c index c153097..b93f71d 100644 ---

[PATCH 07/17] usb: isp1760: Remove busname argument to isp1760_register

2014-10-06 Thread Laurent Pinchart
The argument is unused, remove it. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/usb/host/isp1760-hcd.c | 2 +- drivers/usb/host/isp1760-hcd.h | 2 +- drivers/usb/host/isp1760-if.c | 14 +- 3 files changed, 7 insertions(+), 11 deletions(-) diff

[PATCH 04/17] usb: isp1760: Don't expose hcd to glue code from isp1760_register

2014-10-06 Thread Laurent Pinchart
The glue code probe functions don't need to access the hcd structure anymore. Modify isp1760_register to return an integer error code instead of the hcd pointer. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/usb/host/isp1760-hcd.c | 19 ++-

[PATCH 16/17] usb: isp1760: Implement driver shutdown operations

2014-10-06 Thread Laurent Pinchart
Reset the HCD and, if applicable, the UDC when shutting down the hardware to avoid spurious interrupts. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/usb/host/isp1760-core.c | 7 +++ drivers/usb/host/isp1760-core.h | 1 + drivers/usb/host/isp1760-hcd.c | 4

[PATCH 17/17] usb: isp1760: Add device controller support

2014-10-06 Thread Laurent Pinchart
The ISP1761 is a dual-mode host and device controller backward compatible on the host side with the ISP1760. Add support for the device controller. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/usb/gadget/udc/Kconfig |7 + drivers/usb/host/Makefile |

[PATCH 15/17] usb: isp1760: Initialize the bus interface in core code

2014-10-06 Thread Laurent Pinchart
Although the corresponding register is part of the HCD register space, processor bus initialization is not specific to the HCD. To prepare for device controller support, move bus interface initialization to core code. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com ---

[PATCH 09/17] usb: isp1760: Decouple usb_hdc and isp1760_priv

2014-10-06 Thread Laurent Pinchart
Allocate the driver private data structure manually instead of using the usb_hcd private space. This will allow skipping hcd registration for the isp1761 when used in device mode only. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/usb/host/isp1760-hcd.c | 31

[PATCH 14/17] usb: isp1760: Set IRQF_SHARED flag in core code

2014-10-06 Thread Laurent Pinchart
The IRQF_SHARED flag needs to be set regardless of the bus type. Don't require glue code to set it manually. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/usb/host/isp1760-core.c | 4 ++-- drivers/usb/host/isp1760-if.c | 10 -- 2 files changed, 6

[PATCH 10/17] usb: isp1760: Prefix driver data structures with isp1760_

2014-10-06 Thread Laurent Pinchart
The slotinfo and memory_chunk structures are specific to the driver and defined in a header file. Prefix them with isp1760_ to avoid namespace clashes. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/usb/host/isp1760-hcd.c | 15 ---

Re: [PATCH 01/17] usb: isp1760: Retrieve pdev memory resource from hcd at remove time

2014-10-06 Thread Felipe Balbi
On Mon, Oct 06, 2014 at 06:54:49PM +0300, Laurent Pinchart wrote: The platform driver remove function needs to release the memory resource requested at probe time. Instead of retrieving the resource from the platform device, retrieve it from the usb_hcd. This mimics the behaviour of the PCI

Re: [PATCH 03/17] usb: isp1760: Manage device driver data in common code

2014-10-06 Thread Felipe Balbi
On Mon, Oct 06, 2014 at 06:54:51PM +0300, Laurent Pinchart wrote: Don't duplicate *_set_drvdata calls in glue code. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Reviewed-by: Felipe Balbi ba...@ti.com --- drivers/usb/host/isp1760-hcd.c | 2 ++

Re: [PATCH 02/17] usb: isp1760: Move removal cleanup code to isp1760-hcd.c

2014-10-06 Thread Felipe Balbi
On Mon, Oct 06, 2014 at 06:54:50PM +0300, Laurent Pinchart wrote: The removal cleanup code is duplicated between the different bus glues. Move it to a central location. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/usb/host/isp1760-hcd.c | 15

Re: [PATCH 04/17] usb: isp1760: Don't expose hcd to glue code from isp1760_register

2014-10-06 Thread Felipe Balbi
On Mon, Oct 06, 2014 at 06:54:52PM +0300, Laurent Pinchart wrote: The glue code probe functions don't need to access the hcd structure anymore. Modify isp1760_register to return an integer error code instead of the hcd pointer. Signed-off-by: Laurent Pinchart

Re: [PATCH 05/17] usb: isp1760: Fix indentation in probe error path

2014-10-06 Thread Felipe Balbi
On Mon, Oct 06, 2014 at 06:54:53PM +0300, Laurent Pinchart wrote: Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Reviewed-by: Felipe Balbi ba...@ti.com --- drivers/usb/host/isp1760-hcd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [PATCH 08/17] usb: isp1760: Pass resource pointer to isp1760_register

2014-10-06 Thread Felipe Balbi
On Mon, Oct 06, 2014 at 06:54:56PM +0300, Laurent Pinchart wrote: The function takes quite a few arguments, passing the resource pointer instead of the start address and length simplifies it a bit. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Reviewed-by: Felipe Balbi

Re: [PATCH 07/17] usb: isp1760: Remove busname argument to isp1760_register

2014-10-06 Thread Felipe Balbi
On Mon, Oct 06, 2014 at 06:54:55PM +0300, Laurent Pinchart wrote: The argument is unused, remove it. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Reviewed-by: Felipe Balbi ba...@ti.com --- drivers/usb/host/isp1760-hcd.c | 2 +- drivers/usb/host/isp1760-hcd.h | 2 +-

Re: [PATCH 11/17] usb: isp1760: Reorganize header files

2014-10-06 Thread Felipe Balbi
On Mon, Oct 06, 2014 at 06:54:59PM +0300, Laurent Pinchart wrote: The isp1760-rhcd.h header contains PTD constants and structures only useful for the HCD implementation. It also contains register definitions that will be needed by common code when implementing support for the ISP1761 device

Re: [PATCH 10/17] usb: isp1760: Prefix driver data structures with isp1760_

2014-10-06 Thread Felipe Balbi
On Mon, Oct 06, 2014 at 06:54:58PM +0300, Laurent Pinchart wrote: The slotinfo and memory_chunk structures are specific to the driver and defined in a header file. Prefix them with isp1760_ to avoid namespace clashes. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com

Re: [PATCH 09/17] usb: isp1760: Decouple usb_hdc and isp1760_priv

2014-10-06 Thread Felipe Balbi
On Mon, Oct 06, 2014 at 06:54:57PM +0300, Laurent Pinchart wrote: Allocate the driver private data structure manually instead of using the usb_hcd private space. This will allow skipping hcd registration for the isp1761 when used in device mode only. Signed-off-by: Laurent Pinchart

Re: [PATCH 13/17] usb: isp1760: Move GPIO request to common code

2014-10-06 Thread Felipe Balbi
On Mon, Oct 06, 2014 at 06:55:01PM +0300, Laurent Pinchart wrote: The code isn't specific to a glue layer, move it to a common location. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Reviewed-by: Felipe Balbi ba...@ti.com --- drivers/usb/host/isp1760-core.c | 15

Re: [PATCH 12/17] usb: isp1760: Move core code to isp1760-core.c

2014-10-06 Thread Felipe Balbi
On Mon, Oct 06, 2014 at 06:55:00PM +0300, Laurent Pinchart wrote: Move core device initialization to a central location in order to share it with the device mode implementation. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/usb/host/Makefile | 2 +-

Re: [PATCH 14/17] usb: isp1760: Set IRQF_SHARED flag in core code

2014-10-06 Thread Felipe Balbi
On Mon, Oct 06, 2014 at 06:55:02PM +0300, Laurent Pinchart wrote: The IRQF_SHARED flag needs to be set regardless of the bus type. Don't require glue code to set it manually. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Reviewed-by: Felipe Balbi ba...@ti.com ---

Re: [PATCH 15/17] usb: isp1760: Initialize the bus interface in core code

2014-10-06 Thread Felipe Balbi
On Mon, Oct 06, 2014 at 06:55:03PM +0300, Laurent Pinchart wrote: Although the corresponding register is part of the HCD register space, processor bus initialization is not specific to the HCD. To prepare for device controller support, move bus interface initialization to core code.

Re: [PATCH 16/17] usb: isp1760: Implement driver shutdown operations

2014-10-06 Thread Felipe Balbi
On Mon, Oct 06, 2014 at 06:55:04PM +0300, Laurent Pinchart wrote: Reset the HCD and, if applicable, the UDC when shutting down the hardware to avoid spurious interrupts. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com I'm confused as to why would you get spurious IRQs when

Re: [PATCH 12/17] usb: isp1760: Move core code to isp1760-core.c

2014-10-06 Thread Laurent Pinchart
Hi Felipe, Thank you for the quick review. On Monday 06 October 2014 11:06:27 Felipe Balbi wrote: On Mon, Oct 06, 2014 at 06:55:00PM +0300, Laurent Pinchart wrote: Move core device initialization to a central location in order to share it with the device mode implementation.

Re: [PATCH 17/17] usb: isp1760: Add device controller support

2014-10-06 Thread Felipe Balbi
Hi, On Mon, Oct 06, 2014 at 06:55:05PM +0300, Laurent Pinchart wrote: The ISP1761 is a dual-mode host and device controller backward compatible on the host side with the ISP1760. Add support for the device controller. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com

Re: [PATCH 12/17] usb: isp1760: Move core code to isp1760-core.c

2014-10-06 Thread Felipe Balbi
hi, On Mon, Oct 06, 2014 at 07:15:42PM +0300, Laurent Pinchart wrote: +int isp1760_register(struct resource *mem, int irq, unsigned long irqflags, +int rst_gpio, struct device *dev, unsigned int devflags) +{ + struct isp1760_device *isp; + int ret; +

Re: [PATCH 12/17] usb: isp1760: Move core code to isp1760-core.c

2014-10-06 Thread Laurent Pinchart
Hi Felipe, On Monday 06 October 2014 11:53:52 Felipe Balbi wrote: On Mon, Oct 06, 2014 at 07:15:42PM +0300, Laurent Pinchart wrote: +int isp1760_register(struct resource *mem, int irq, unsigned long irqflags, + int rst_gpio, struct device *dev, unsigned int

Re: [PATCH 12/17] usb: isp1760: Move core code to isp1760-core.c

2014-10-06 Thread Felipe Balbi
On Mon, Oct 06, 2014 at 08:00:56PM +0300, Laurent Pinchart wrote: Hi Felipe, On Monday 06 October 2014 11:53:52 Felipe Balbi wrote: On Mon, Oct 06, 2014 at 07:15:42PM +0300, Laurent Pinchart wrote: +int isp1760_register(struct resource *mem, int irq, unsigned long irqflags, +

xhci_hcd can't detect new devices after enabling runtime PM and disabling S3 wake (bug #85701)

2014-10-06 Thread Dmitry Nezhevenko
[ resending from bugzilla as requested ]+ On Lenovo t440p machine I've xhci_hcd port that doesn't work after enabling runtime PM: 1. Just after boot, rmmod xhci_hcd and modprobe it again: [ 120.595176] xhci_hcd :00:14.0: enabling bus mastering [ 120.595188] xhci_hcd :00:14.0: xHCI

Re: xhci_hcd can't detect new devices after enabling runtime PM and disabling S3 wake (bug #85701)

2014-10-06 Thread Alan Stern
On Mon, 6 Oct 2014, Dmitry Nezhevenko wrote: [ resending from bugzilla as requested ]+ On Lenovo t440p machine I've xhci_hcd port that doesn't work after enabling runtime PM: 1. Just after boot, rmmod xhci_hcd and modprobe it again: ... 2. apply power_settings: % for F in

Re: xhci_hcd can't detect new devices after enabling runtime PM and disabling S3 wake (bug #85701)

2014-10-06 Thread Dmitry Nezhevenko
On Mon, Oct 06, 2014 at 02:49:29PM -0400, Alan Stern wrote: % echo XHCI | sudo tee /proc/acpi/wakeup % cat /proc/acpi/wakeup| grep XHCI XHCI S3*disabled pci::00:14.0 The right way to disable wakeup is to write disabled to the device's power/wakeup attribute in sysfs. Don't

usb_stor_Bulk_max_lun() and scsi_host max_lun field mismatch

2014-10-06 Thread Mark Knibbs
Hi, This is about USB mass storage devices. The max_lun field in the scsi_host/us_data structure is the maximum possible LUN value *plus 1*. It's initially set to 8 by scsi_host_alloc() which is called by usb_stor_probe1(). usb_stor_scan_dwork() in drivers/usb/storage/usb.c contains this:

Re: usb_stor_Bulk_max_lun() and scsi_host max_lun field mismatch

2014-10-06 Thread Alan Stern
On Mon, 6 Oct 2014, Mark Knibbs wrote: Hi, This is about USB mass storage devices. The max_lun field in the scsi_host/us_data structure is the maximum possible LUN value *plus 1*. You are confusing two different fields. The max_lun field in scsi_host is different from the max_lun field

Re: xhci_hcd can't detect new devices after enabling runtime PM and disabling S3 wake (bug #85701)

2014-10-06 Thread Alan Stern
On Mon, 6 Oct 2014, Dmitry Nezhevenko wrote: --- device plugged --- [ 2116.861499] xhci_hcd :00:14.0: power state changed by ACPI to D0 [ 2116.962998] xhci_hcd :00:14.0: PME# disabled [ 2116.963015] xhci_hcd :00:14.0: enabling bus mastering [ 2116.963094] xhci_hcd :00:14.0:

Re: xhci_hcd can't detect new devices after enabling runtime PM and disabling S3 wake (bug #85701)

2014-10-06 Thread Dmitry Nezhevenko
On Mon, Oct 06, 2014 at 03:28:33PM -0400, Alan Stern wrote: On Mon, 6 Oct 2014, Dmitry Nezhevenko wrote: --- device plugged --- [ 2116.861499] xhci_hcd :00:14.0: power state changed by ACPI to D0 [ 2116.962998] xhci_hcd :00:14.0: PME# disabled [ 2116.963015] xhci_hcd

Re: [PATCH] phy: omap-usb2: Enable runtime PM of omap-usb2 phy properly

2014-10-06 Thread Rabin Vincent
On Fri, Sep 26, 2014 at 02:17:47PM +0100, Oussama Ghorbel wrote: You may find merge conflict since v3.17-rc5. If necessary I can send a re-based version of this patch on v3.17-rc5 for seamless integration. Looks like pandaboard USB is still broken on v3.17 due to this bug. Please do send an

Re: [PATCH 0/2] Add portpower callback to ehci-hub

2014-10-06 Thread Laurent Pinchart
Hi Michal, Thank you for the patch. On Friday 26 September 2014 16:21:18 Michael Grzeschik wrote: This series adds an portpower callback that can be triggered additionaly to the PORT_POWER ehci bit. With that we are able to toggle an external registered regulator i.e. fixed GPIO. The first

Re: [PATCH 2/2] arm: shmobile: lager: enable HS-USB

2014-10-06 Thread Sergei Shtylyov
Hello. On 10/02/2014 12:04 PM, Yoshihiro Shimoda wrote: Signed-off-by: Yoshihiro Shimoda yoshihiro.shimoda...@renesas.com --- arch/arm/boot/dts/r8a7790-lager.dts |5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm/boot/dts/r8a7790-lager.dts

Re: [PATCH net-next v2] r8152: nway reset after setting eee

2014-10-06 Thread David Miller
From: Hayes Wang hayesw...@realtek.com Date: Mon, 6 Oct 2014 10:36:04 +0800 Restart autonegotiation is necessary after setting EEE. Signed-off-by: Hayes Wang hayesw...@realtek.com Applied, thanks. -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message

Re: [PATCH 0/2] Add portpower callback to ehci-hub

2014-10-06 Thread Michael Grzeschik
Hi Laurent, On Mon, Oct 06, 2014 at 10:50:36PM +0300, Laurent Pinchart wrote: Thank you for the patch. On Friday 26 September 2014 16:21:18 Michael Grzeschik wrote: This series adds an portpower callback that can be triggered additionaly to the PORT_POWER ehci bit. With that we are able

Re: [PATCH 2/2] arm: shmobile: lager: enable HS-USB

2014-10-06 Thread Yoshihiro Shimoda
Hello. (2014/10/07 6:38), Sergei Shtylyov wrote: Hello. On 10/02/2014 12:04 PM, Yoshihiro Shimoda wrote: Signed-off-by: Yoshihiro Shimoda yoshihiro.shimoda...@renesas.com --- arch/arm/boot/dts/r8a7790-lager.dts |5 + 1 file changed, 5 insertions(+) diff --git

Re: [PATCH] usb: Remove references to non-existent PLAT_S5P symbol

2014-10-06 Thread Jingoo Han
On Tuesday, October 07, 2014 12:47 AM, Sylwester Nawrocki wrote: The PLAT_S5P Kconfig symbol was removed in commit d78c16ccde96 (ARM: SAMSUNG: Remove remaining legacy code). There are still some references left, fix that by replacing them with ARCH_S5PV210. Reported-by: Paul Bolle

Re: [PATCH] usb: gadget: f_fs: add zombie mode

2014-10-06 Thread Felipe Balbi
Hi, On Mon, Oct 06, 2014 at 01:25:14PM +0200, Robert Baldyga wrote: Since we can compose gadgets from many functions, there is the problem related to gadget breakage while FunctionFS daemon being closed. In some cases it's strongly desired to keep gadget alive for a while, despite FunctionFS

Re: [PATCH 2/2] arm: shmobile: lager: enable HS-USB

2014-10-06 Thread Yoshihiro Shimoda
Hello. (2014/10/06 9:59), Yoshihiro Shimoda wrote: Hello. (2014/10/04 4:50), Sergei Shtylyov wrote: On 10/02/2014 12:04 PM, Yoshihiro Shimoda wrote: Signed-off-by: Yoshihiro Shimoda yoshihiro.shimoda...@renesas.com --- arch/arm/boot/dts/r8a7790-lager.dts |5 + 1 file changed,

[PATCH v2 0/3] usb: renesas_usbhs: add support for generic PHY

2014-10-06 Thread Yoshihiro Shimoda
This patch series adds support for the generic PHY. This series is based on the origin/testing/next branch in Felipe's git. (commit id : cf72c46944766b69e7bc5c10ac69f2b01287b7a9) Changes from v1: - Separate patch 1 to rename and clean up. Yoshihiro Shimoda (3): usb: renesas_usbhs: rename phy

[PATCH v2 2/3] usb: renesas_usbhs: clean up rcar2.c to support a generic PHY

2014-10-06 Thread Yoshihiro Shimoda
To support both usb PHY and generic PHY, this patch cleans up rcar2.c. Signed-off-by: Yoshihiro Shimoda yoshihiro.shimoda...@renesas.com --- drivers/usb/renesas_usbhs/rcar2.c | 48 - 1 file changed, 26 insertions(+), 22 deletions(-) diff --git

[PATCH v2 3/3] usb: renesas_usbhs: add support for generic PHY

2014-10-06 Thread Yoshihiro Shimoda
This patch adds support for the generic PHY. The generic PHY will be used in multiplatform environment. Signed-off-by: Yoshihiro Shimoda yoshihiro.shimoda...@renesas.com --- drivers/usb/renesas_usbhs/common.h |1 + drivers/usb/renesas_usbhs/rcar2.c | 29 + 2

[PATCH v2 1/3] usb: renesas_usbhs: rename phy to usb_phy in usbhs_priv

2014-10-06 Thread Yoshihiro Shimoda
To support a generic phy driver in this driver later, this patch renames struct usb_phy *phy to struct usb_phy *usb_phy. Signed-off-by: Yoshihiro Shimoda yoshihiro.shimoda...@renesas.com --- drivers/usb/renesas_usbhs/common.h |2 +- drivers/usb/renesas_usbhs/rcar2.c | 26

[PATCH net-next] r8152: use mutex for hw settings

2014-10-06 Thread Hayes Wang
Use mutex to avoid that the serial hw settings would be interrupted by other settings. Although there is no problem now, it makes the driver more safe. Signed-off-by: Hayes Wang hayesw...@realtek.com --- drivers/net/usb/r8152.c | 69 +++-- 1 file