Re: Query regarding root hub reset

2014-12-22 Thread Deepak Das
On 22 December 2014 at 22:13, Alan Stern wrote: > On Mon, 22 Dec 2014, Deepak Das wrote: > >> Can somebody please help me to find the test-case/use-case of >> following snippet of code in drivers/usb/core/hub.c:hub_port_connect() >> :- >> >> /* maybe switch power back on (e.g. root

Re: [PATCH] usb: gadget: udc-core: call udc_stop() before gadget unbind

2014-12-22 Thread Robert Baldyga
Hi Felipe, On 12/22/2014 05:34 PM, Felipe Balbi wrote: > On Mon, Dec 15, 2014 at 11:05:22AM +0100, Robert Baldyga wrote: >> On 12/15/2014 06:13 AM, Peter Chen wrote: >>> On Fri, Dec 12, 2014 at 02:17:28PM +0100, Robert Baldyga wrote: As usb function drivers assumes that all usb request will b

Re: [PATCH v2] OHCI: add a quirk for ULi M5237 blocking on reset

2014-12-22 Thread Nikita Yushchenko
23.12.2014 08:36, Arseny Solokha пишет: >> On Sat, 6 Dec 2014, Arseny Solokha wrote: >> >>> From: Arseny Solokha >>> >>> Commit 8dccddbc2368 ("OHCI: final fix for NVIDIA problems (I hope)") >>> introduced into 3.1.9 broke boot on e.g. Freescale P2020DS development >>> board. The code path that was

RE: [DISCUSSION] USB device remote wakeup is not working for S3 case

2014-12-22 Thread Du, Changbin
> You have to make sure that wakeup is also enabled for the host > controller the device is attached to. For some host controllers, it > may also be necessary to enable wakeup for the root hub. > Yes, the root-hub is not wakeup enabled by default, actually hub devices are not enabled. It works af

Re: [PATCH v2] OHCI: add a quirk for ULi M5237 blocking on reset

2014-12-22 Thread Arseny Solokha
> On Sat, 6 Dec 2014, Arseny Solokha wrote: > >> From: Arseny Solokha >> >> Commit 8dccddbc2368 ("OHCI: final fix for NVIDIA problems (I hope)") >> introduced into 3.1.9 broke boot on e.g. Freescale P2020DS development >> board. The code path that was previously specific to NVIDIA controllers >>

[PATCH 2/4] usb: chipidea: usbmisc_imx: add .set_wakeup interface

2014-12-22 Thread Peter Chen
This API is used to enable/disable usb wakeup, only imx6 series are added, since I don't have other imx hardware on hand. Other imx users can add their API according to reference manual after testing. Signed-off-by: Peter Chen --- drivers/usb/chipidea/ci_hdrc_imx.h | 1 + drivers/usb/chipidea/u

[PATCH 3/4] usb: chipidea: imx: add runtime power management support

2014-12-22 Thread Peter Chen
Add runtime pm support for imx, only imx6 series are supported and tested. Signed-off-by: Peter Chen --- drivers/usb/chipidea/ci_hdrc_imx.c | 106 ++--- 1 file changed, 100 insertions(+), 6 deletions(-) diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c b/drivers/u

[PATCH 4/4] usb: chipidea: clear otg interrupt status for otg capable controller

2014-12-22 Thread Peter Chen
We need to do it for all otg capable controller, not only peripheral featured otg capable controller, otherwise, the host-only role, but otg capable controller may be responded by otg interrupt. Signed-off-by: Peter Chen --- drivers/usb/chipidea/core.c | 9 + 1 file changed, 5 insertions

[PATCH 1/4] usb: chipidea: add runtime power management support

2014-12-22 Thread Peter Chen
Add runtime power management support. Signed-off-by: Peter Chen --- drivers/usb/chipidea/ci.h| 6 +++ drivers/usb/chipidea/core.c | 93 +--- drivers/usb/chipidea/otg.c | 2 + include/linux/usb/chipidea.h | 1 + 4 files changed, 96 insertions(+),

[PATCH 0/4] usb: chipidea: add runtime power management support

2014-12-22 Thread Peter Chen
Hi All, The first three patches in this set is adding runtime power management support for chipidea, since runtime pm will take the PHY enter low power mode and gate the controller clock, if there is no related wakeup logic, the usb will can't be used any more, and wakeup logic is different per ve

Re: [PATCH 0/3] usb: chipidea: add one errata for revision 2.40a

2014-12-22 Thread Sanchayan Maity
On 12/23/2014 05:39 AM, Peter Chen wrote: > On Mon, Dec 22, 2014 at 06:39:42PM +0530, Sanchayan Maity wrote: >> On 12/22/2014 06:48 AM, Peter Chen wrote: >>> On Fri, Dec 19, 2014 at 03:25:26PM +0530, Sanchayan Maity wrote: The first two patches add identification register API's. These can

RE: Query regarding root hub reset

2014-12-22 Thread Peter Chen
> The Linux USB stack supports turning off port power only under a very limited > set of conditions. For example, if the port is hard-wired or not connected > at all, > and if remote wakeup is not required. > Alan, any reasons/limitations we do not support it (by libusb)? Peter -- To unsubs

Re: [RFC/PATCH] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)

2014-12-22 Thread Peter Chen
On Mon, Dec 22, 2014 at 02:43:37PM -0800, David Cohen wrote: > Some platforms have an USB OTG port fully (or partially) controlled by > GPIOs: > > (1) USB ID is connected directly to GPIO > > Optionally: > (2) VBUS is enabled by a GPIO (when ID is grounded) > (3) Platform has 2 USB controllers co

Re: USB Creative Soundcard non-functioning on 3.13 kernel and above

2014-12-22 Thread robtongue
On Monday 22 December 2014 16:55:12 you wrote: > On Sun, 21 Dec 2014 robton...@gmail.com wrote: > > On Friday 19 December 2014 17:22:42 you wrote: > > > > You'll have to collect a bunch of additional information. I'd like to > > > > see the entry in /sys/kernel/debug/usb/devices that describes the

Re: Strange behaviour...

2014-12-22 Thread Peter Chen
On Mon, Dec 22, 2014 at 11:05:09AM +0100, gianluca wrote: > On 12/22/2014 10:59 AM, gianluca wrote: > >On 12/22/2014 10:49 AM, Peter Chen wrote: > >it waits for 0x400 (timeout value counter) read access, then exit > >with a timeout. It looks like the HW_USBPHY_CTRL for USBPHY1 > >(0x800

Re: [PATCH 0/3] usb: chipidea: add one errata for revision 2.40a

2014-12-22 Thread Peter Chen
On Mon, Dec 22, 2014 at 06:39:42PM +0530, Sanchayan Maity wrote: > On 12/22/2014 06:48 AM, Peter Chen wrote: > > On Fri, Dec 19, 2014 at 03:25:26PM +0530, Sanchayan Maity wrote: > >> The first two patches add identification register API's. These can > >> be used to get controller's revision. > >>

Re: [xhci_hcd] USB3 device unplug breaks system suspend

2014-12-22 Thread Tobias Jakobi
Alan Stern wrote: > I don't follow your reasoning. The Logitech mouse is also driven by > xhci-hcd, and so is the Azurewave webcam. Ah OK, I was under the impression that ehci_hcd was handling these, since it shows up as used driver in the lspci output. Anyway, I did some more tests. 1) I remov

[RFC/PATCH] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)

2014-12-22 Thread David Cohen
Some platforms have an USB OTG port fully (or partially) controlled by GPIOs: (1) USB ID is connected directly to GPIO Optionally: (2) VBUS is enabled by a GPIO (when ID is grounded) (3) Platform has 2 USB controllers connected to same port: one for device and one for host role. D+/- are swit

Re: [PATCH 2/2] USB: ehci-platform: Support ehci reset after resume quirk

2014-12-22 Thread Doug Anderson
Hi, On Mon, Dec 22, 2014 at 1:04 PM, Alan Stern wrote: > On Mon, 22 Dec 2014, Doug Anderson wrote: > >> Alan, >> >> On Mon, Dec 22, 2014 at 8:06 AM, Alan Stern >> wrote: >> > On Mon, 22 Dec 2014, Wu Liang feng wrote: >> > >> >> The EHCI controller doesn't properly detect the case when >> > >> >

Re: USB Creative Soundcard non-functioning on 3.13 kernel and above

2014-12-22 Thread Alan Stern
On Sun, 21 Dec 2014 robton...@gmail.com wrote: > On Friday 19 December 2014 17:22:42 you wrote: > > > You'll have to collect a bunch of additional information. I'd like to > > > see the entry in /sys/kernel/debug/usb/devices that describes the > sound > > > card, and the contents of the files un

Re: Query regarding root hub reset

2014-12-22 Thread Alan Stern
On Mon, 22 Dec 2014, Deepak Das wrote: > Can somebody please help me to find the test-case/use-case of > following snippet of code in drivers/usb/core/hub.c:hub_port_connect() > :- > > /* maybe switch power back on (e.g. root hub was reset) */ > if (hub_is_port_pow

Re: [PATCH 2/2] USB: ehci-platform: Support ehci reset after resume quirk

2014-12-22 Thread Alan Stern
On Mon, 22 Dec 2014, Doug Anderson wrote: > Alan, > > On Mon, Dec 22, 2014 at 8:06 AM, Alan Stern wrote: > > On Mon, 22 Dec 2014, Wu Liang feng wrote: > > > >> The EHCI controller doesn't properly detect the case when > > > > "The" EHCI controller? I don't know what EHCI controller you're > > t

Re: "# CONFIG_USB_SUPPORT is not set" but "CONFIG_USB_OHCI_LITTLE_ENDIAN=y" int he same kernel .config file

2014-12-22 Thread Alan Stern
On Mon, 22 Dec 2014, Toralf Förster wrote: > I'm wondering why it is set to "y" : > > $> zgrep USB /proc/config.gz > # CONFIG_USB_SWITCH_FSA9480 is not set > # Host-side USB support is needed for USB Network Adapter support > CONFIG_USB_OHCI_LITTLE_ENDIAN=y > # CONFIG_USB_SUPPORT is not set > # C

Re: "# CONFIG_USB_SUPPORT is not set" but "CONFIG_USB_OHCI_LITTLE_ENDIAN=y" int he same kernel .config file

2014-12-22 Thread Randy Dunlap
On 12/22/14 09:31, Toralf Förster wrote: > On 12/22/2014 06:16 PM, Greg KH wrote: >> If you delete it, does it come back with a 'make oldconfig'? > > it comes back, even on a vanilla kernel (KVM guest): > > n22kvm-clone linux # uname -a > Linux n22kvm-clone 3.19.0-rc1 #1 SMP Sun Dec 21 18:03:48 C

Re: [PATCH 2/2] USB: ehci-platform: Support ehci reset after resume quirk

2014-12-22 Thread Julius Werner
>> The EHCI controller doesn't properly detect the case when > > "The" EHCI controller? I don't know what EHCI controller you're > talking about, but my controllers don't have any trouble detecting > device removal during suspend. This is similar to other SoC-based controllers that loose state in

Re: Kernel 3.17.x Attaching Keyspan 4-Port Serial to USB Adapter Causes Kernel Panic

2014-12-22 Thread Johan Hovold
[+CC: linux-usb ] On Sat, Dec 20, 2014 at 04:08:20PM -0800, Richard wrote: > On a new Gentoo based system with Kernel.org Kernels 3.17.4 to 3.17.7 > when I physically plug the Keyspan 4-Port Serial to USB adapter into a > usb port my system freezes with a "unable to handle kernel NULL pointer > de

RE: [PATCH v1 03/29] usb: dwc2: gadget: process setup packet on transfer complete

2014-12-22 Thread Kaukab, Yousaf
Hi > -Original Message- > From: Mian Yousaf Kaukab [mailto:yousaf.kau...@gmail.com] > Sent: Sunday, December 21, 2014 5:15 PM > To: linux-usb@vger.kernel.org; ba...@ti.com > Cc: Herrero, Gregory; pa...@synopsys.com; > sergei.shtyl...@cogentembedded.com; Kaukab, Yousaf > Subject: [PATCH v1

Re: "# CONFIG_USB_SUPPORT is not set" but "CONFIG_USB_OHCI_LITTLE_ENDIAN=y" int he same kernel .config file

2014-12-22 Thread Toralf Förster
On 12/22/2014 06:16 PM, Greg KH wrote: > If you delete it, does it come back with a 'make oldconfig'? it comes back, even on a vanilla kernel (KVM guest): n22kvm-clone linux # uname -a Linux n22kvm-clone 3.19.0-rc1 #1 SMP Sun Dec 21 18:03:48 CET 2014 i686 Intel Xeon E312xx (Sandy Bridge) Genuine

Re: "# CONFIG_USB_SUPPORT is not set" but "CONFIG_USB_OHCI_LITTLE_ENDIAN=y" int he same kernel .config file

2014-12-22 Thread Greg KH
On Mon, Dec 22, 2014 at 06:12:43PM +0100, Toralf Förster wrote: > On 12/22/2014 06:04 PM, Greg KH wrote: > > On Mon, Dec 22, 2014 at 05:53:32PM +0100, Toralf Förster wrote: > >> I'm wondering why it is set to "y" : > >> > >> $> zgrep USB /proc/config.gz > >> # CONFIG_USB_SWITCH_FSA9480 is not set >

Query regarding root hub reset

2014-12-22 Thread Deepak Das
Can somebody please help me to find the test-case/use-case of following snippet of code in drivers/usb/core/hub.c:hub_port_connect() :- /* maybe switch power back on (e.g. root hub was reset) */ if (hub_is_port_power_switchable(hub) &

Re: "# CONFIG_USB_SUPPORT is not set" but "CONFIG_USB_OHCI_LITTLE_ENDIAN=y" int he same kernel .config file

2014-12-22 Thread Toralf Förster
On 12/22/2014 06:04 PM, Greg KH wrote: > On Mon, Dec 22, 2014 at 05:53:32PM +0100, Toralf Förster wrote: >> I'm wondering why it is set to "y" : >> >> $> zgrep USB /proc/config.gz >> # CONFIG_USB_SWITCH_FSA9480 is not set >> # Host-side USB support is needed for USB Network Adapter support >> CONFI

Re: [PATCH 1/2] dt-bindings: usb-ehci: Add an optional property "needs-reset-on-resume"

2014-12-22 Thread Doug Anderson
Wu Liang feng, On Mon, Dec 22, 2014 at 2:36 AM, Wu Liang feng wrote: > Add device-tree bindings for EHCI so we can use "needs-reset-on-resume" > property to force EHCI reset after resume if necessary. This is necessary > on platforms like rk3288 that need a reset after resume to detect if a > dev

Re: [PATCH 2/2] USB: ehci-platform: Support ehci reset after resume quirk

2014-12-22 Thread Doug Anderson
Alan, On Mon, Dec 22, 2014 at 8:06 AM, Alan Stern wrote: > On Mon, 22 Dec 2014, Wu Liang feng wrote: > >> The EHCI controller doesn't properly detect the case when > > "The" EHCI controller? I don't know what EHCI controller you're > talking about, but my controllers don't have any trouble detec

Re: "# CONFIG_USB_SUPPORT is not set" but "CONFIG_USB_OHCI_LITTLE_ENDIAN=y" int he same kernel .config file

2014-12-22 Thread Greg KH
On Mon, Dec 22, 2014 at 05:53:32PM +0100, Toralf Förster wrote: > I'm wondering why it is set to "y" : > > $> zgrep USB /proc/config.gz > # CONFIG_USB_SWITCH_FSA9480 is not set > # Host-side USB support is needed for USB Network Adapter support > CONFIG_USB_OHCI_LITTLE_ENDIAN=y > # CONFIG_USB_SUPP

"# CONFIG_USB_SUPPORT is not set" but "CONFIG_USB_OHCI_LITTLE_ENDIAN=y" int he same kernel .config file

2014-12-22 Thread Toralf Förster
I'm wondering why it is set to "y" : $> zgrep USB /proc/config.gz # CONFIG_USB_SWITCH_FSA9480 is not set # Host-side USB support is needed for USB Network Adapter support CONFIG_USB_OHCI_LITTLE_ENDIAN=y # CONFIG_USB_SUPPORT is not set # CONFIG_BCM_KONA_USB2_PHY is not set -- Toralf pgp key: 7B1A

Re: [RESEND PATCH] usb: gadget: at91_udc: move prepare clk into process context

2014-12-22 Thread Felipe Balbi
Hi, On Fri, Dec 19, 2014 at 02:18:31PM +, Luis Henriques wrote: > On Fri, Dec 19, 2014 at 03:08:15PM +0100, Nicolas Ferre wrote: > > Le 19/12/2014 15:02, Ronald Wahl a écrit : > > > On 19.12.2014 14:51, Luis Henriques wrote: > > >> Hi Felipe, > > >> > > >> On Thu, Nov 20, 2014 at 01:50:49PM -0

Re: [PATCH 1/2] USB: gadget: udc: atmel: change setting for DMA

2014-12-22 Thread Felipe Balbi
On Thu, Dec 18, 2014 at 06:20:39PM +0100, Nicolas Ferre wrote: > Le 17/12/2014 10:18, Bo Shen a écrit : > > According to the datasheet, when transfer using DMA, the control > > setting for IN packet only need END_BUF_EN, END_BUF_IE, CH_EN, > > while for OUT packet, need more two bits END_TR_EN and

Re: [PATCH] usb: gadget: udc-core: call udc_stop() before gadget unbind

2014-12-22 Thread Felipe Balbi
On Mon, Dec 15, 2014 at 11:05:22AM +0100, Robert Baldyga wrote: > On 12/15/2014 06:13 AM, Peter Chen wrote: > > On Fri, Dec 12, 2014 at 02:17:28PM +0100, Robert Baldyga wrote: > >> As usb function drivers assumes that all usb request will be completed > >> before function unbind call, we should sup

Re: [PATCH] usb: gadget: udc-core: call udc_stop() before gadget unbind

2014-12-22 Thread Felipe Balbi
On Fri, Dec 12, 2014 at 02:17:28PM +0100, Robert Baldyga wrote: > As usb function drivers assumes that all usb request will be completed > before function unbind call, we should supply such behavior. In some > cases ep_disable() won't kill all request effectively, because some > IN requests can be

Re: query on DWC3

2014-12-22 Thread Felipe Balbi
Hi again, On Mon, Dec 22, 2014 at 10:11:23AM -0600, Felipe Balbi wrote: > (please don't top-post) > > On Sun, Dec 14, 2014 at 08:39:18AM +0530, sundeep subbaraya wrote: > > Hi Paul, > > > > As per my understanding, for BULK OUT we do queue a request with 512 > > bytes length since we do not > >

Re: query on DWC3

2014-12-22 Thread Felipe Balbi
Hi, (please don't top-post) On Sun, Dec 14, 2014 at 08:39:18AM +0530, sundeep subbaraya wrote: > Hi Paul, > > As per my understanding, for BULK OUT we do queue a request with 512 > bytes length since we do not sometimes we _do_ know the size. In case of Mass Storage, we _know_ that the first bu

Re: [PATCH 2/4] usb: dwc3: gadget: Stop TRB preparation after limit is reached

2014-12-22 Thread Felipe Balbi
On Fri, Dec 19, 2014 at 12:40:16PM +0530, Amit Virdi wrote: > When SG is used, there are two loops iterating to prepare TRBs: > - Outer loop over the request_list > - Inner loop over the SG list > > The driver must stop preparing TRBs when the max TRBs have been prepared. The > code was missing

Re: [PATCH 2/2] USB: ehci-platform: Support ehci reset after resume quirk

2014-12-22 Thread Alan Stern
On Mon, 22 Dec 2014, Wu Liang feng wrote: > The EHCI controller doesn't properly detect the case when "The" EHCI controller? I don't know what EHCI controller you're talking about, but my controllers don't have any trouble detecting device removal during suspend. > a device is removed during

Re: [PATCH 1/4] usb: dwc3: gadget: Fix TRB preparation during SG

2014-12-22 Thread Felipe Balbi
On Fri, Dec 19, 2014 at 12:40:15PM +0530, Amit Virdi wrote: > When scatter gather is used, multiple TRBs are prepared from one DWC3 request. > Hence, we must set the 'last' flag when the SG is last as well as the TRB is > last. The current implementation uses list_is_last to check if the > dwc3_re

Re: [PATCH 2/3] usb: dwc3: add Fujitsu Specific Glue layer

2014-12-22 Thread Felipe Balbi
Hi, On Tue, Dec 16, 2014 at 10:10:27AM +0800, Sneeker Yeh wrote: > This patch adds support for Synopsis DesignWare USB3 IP Core found > on Fujitsu Socs. > > Signed-off-by: Sneeker Yeh > --- > .../devicetree/bindings/usb/fujitsu-dwc3.txt | 25 +++ > drivers/usb/dwc3/Kconfig

Re: [PATCH 3/3] usb: dwc3: add a quirk for device disconnection issue in Synopsis dwc3 core

2014-12-22 Thread Felipe Balbi
On Tue, Dec 16, 2014 at 10:10:28AM +0800, Sneeker Yeh wrote: > Synopsis DesignWare USB3 IP Core integrated with a config-free > phy needs special handling during device disconnection to avoid > the host controller dying. > > This quirk makes sure PORT_CSC is cleared after the disable slot > comman

Re: [PATCH 00/11] Exynos7: Adding USB 3.0 support

2014-12-22 Thread Sylwester Nawrocki
Hi Vivek, On 25/11/14 12:48, Vivek Gautam wrote: > On Sat, Nov 22, 2014 at 8:42 PM, Kukjin Kim wrote: >> > On 11/22/14 17:40, Kishon Vijay Abraham I wrote: >>> >> On Friday 21 November 2014 08:41 PM, Felipe Balbi wrote: ... >>> I took dwc3 driver patches. >>> >> >>> >> I took the phy patches

usb: dwc2: problems with IN requests completion in linux-next

2014-12-22 Thread Robert Baldyga
Hi, I have recently noticed problem with DWC2 driver in latest linux-next. I use it in gadget only mode at Samsung platform (Odroid U3) but I believe the bug can be reproduced at another platforms. While running FFS example (tools/usb/ffs-aio-example/simple/) the communication breaks after few se

Re: [PATCH 0/3] usb: chipidea: add one errata for revision 2.40a

2014-12-22 Thread Sanchayan Maity
On 12/22/2014 06:48 AM, Peter Chen wrote: > On Fri, Dec 19, 2014 at 03:25:26PM +0530, Sanchayan Maity wrote: >> The first two patches add identification register API's. These can >> be used to get controller's revision. >> >> The third patch implements an errata for revision 2.40a. Not sure >> whi

RE: [PATCH net] r8152: drop the tx packet with invalid length

2014-12-22 Thread Hayes Wang
> -Original Message- > From: Hayes Wang > Sent: Monday, December 22, 2014 10:23 AM > To: 'Eric Dumazet' > Cc: Tom Herbert; David Miller; net...@vger.kernel.org; > nic_swsd; linux-ker...@vger.kernel.org; linux-usb@vger.kernel.org > Subject: RE: [PATCH net] r8152: drop the tx packet with in

[PATCH 1/2] dt-bindings: usb-ehci: Add an optional property "needs-reset-on-resume"

2014-12-22 Thread Wu Liang feng
Add device-tree bindings for EHCI so we can use "needs-reset-on-resume" property to force EHCI reset after resume if necessary. This is necessary on platforms like rk3288 that need a reset after resume to detect if a device has been disconnected during suspend time. Signed-off-by: Wu Liang feng -

[PATCH 0/2] Support EHCI reset after resume quirk

2014-12-22 Thread Wu Liang feng
This series adds support for EHCI controller to do reset after resume if necessory. Wu Liang feng (2): dt-bindings: usb-ehci: Add an optional property "needs-reset-on-resume" USB: ehci-platform: Support ehci reset after resume quirk tested on rk3288 chromebook board Documentation/devic

[PATCH 2/2] USB: ehci-platform: Support ehci reset after resume quirk

2014-12-22 Thread Wu Liang feng
The EHCI controller doesn't properly detect the case when a device is removed during suspend. Specifically,when we resume from suspend the EHCI controller maintaining the USB state (FLAG_CF is 1 Current Connect Status is 1) but a USB device (like a USB camera on rk3288) may have been disconnected a

Re: Strange behaviour...

2014-12-22 Thread gianluca
On 12/22/2014 10:59 AM, gianluca wrote: On 12/22/2014 10:49 AM, Peter Chen wrote: it waits for 0x400 (timeout value counter) read access, then exit with a timeout. It looks like the HW_USBPHY_CTRL for USBPHY1 (0x8007E030) has the following value: 0x8002 (so no CLKGATE high...) It means the

Re: Strange behaviour...

2014-12-22 Thread gianluca
On 12/22/2014 10:49 AM, Peter Chen wrote: it waits for 0x400 (timeout value counter) read access, then exit with a timeout. It looks like the HW_USBPHY_CTRL for USBPHY1 (0x8007E030) has the following value: 0x8002 (so no CLKGATE high...) It means the PHY works abnormal, would you please che

RE: Strange behaviour...

2014-12-22 Thread Peter Chen
> > > >> Hello Fabio and Peter, > >> > >> I am suffering some strange behaviour in initializing the smtp reset > >> block of the USB1 (host) in iMX28 running kernel 3.12.1 (vanilla) on > >> my custom board based on iMX28EVK. > >> > >> With bootlets I DO NOT TOUCH any register to the USB PHY and f

[PATCH] USB: gadget: udc: atmel: fix possible oops when unloading module

2014-12-22 Thread Songjun Wu
When unloading the module, the urb request will be dequeued and the completion routine will be excuted. If no urb packet, the urb request will not be added to the endpoint queue and the completion routine pointer in urb request is NULL. Accessing to the NULL function pointer will cause the oops iss

Re: [PATCH] usb: gadget: udc: s3c2410_udc.c: Remove some unused functions

2014-12-22 Thread Vasily Khoruzhick
On Sun, Dec 21, 2014 at 1:30 AM, Rickard Strandqvist wrote: > Removes some functions that are not used anywhere: > s3c2410_udc_clear_ep_state() s3c2410_udc_set_ep0_sse_out() > > This was partially found by using a static code analysis program called > cppcheck. Looks OK to me. > Signed-off-by:

Re: Strange behaviour...

2014-12-22 Thread gianluca
On 12/22/2014 02:13 AM, Peter Chen wrote: On Fri, Dec 19, 2014 at 12:35:49PM +0100, gianluca wrote: CC linux-usb ML Hello Fabio and Peter, I am suffering some strange behaviour in initializing the smtp reset block of the USB1 (host) in iMX28 running kernel 3.12.1 (vanilla) on my custom board