Re: [PATCH 11/11] usb: core: fix a race with usb_queue_reset_device()

2015-01-21 Thread Alan Stern
On Wed, 21 Jan 2015, Olivier Sobrie wrote: I tested your patch. It also fixes the problem I observed. You can drop mine. For your info: My test consists in powering down a usb hso modem while one of its serial port is opened. It leads to two URB failures, each urb callback queues a

hid: Adding rdesc quirks

2015-01-21 Thread Simon Wörner
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, I'm working on a fix for my synaptics keyboard and got some questions. The keyboard is reporting a wrong Logical / Usage Maximum (0xFF, 0xFF) and i patched the rdesc as seen in other quirks. But I don't know what would be a correct (or

Re: [PATCHv3 1/2] usb: ehci-platform: add support for multiple phys per controller

2015-01-21 Thread Arun Ramamurthy
Thanks Alan. I did run check patch and I had no errors or warnings. I explained my changes in v3 in the cover patch, did that not come through or is it convention to do it in the individual patch? Is the ack for the ohci patch as well? Thanks Arun Ramamurthy On 15-01-21 07:03 AM, Alan

Re: [PATCH v2 0/4] toshiba_acpi: Add support for USB Sleep functions

2015-01-21 Thread Darren Hart
On Wed, Jan 21, 2015 at 11:21:06AM -0700, Azael Avalos wrote: Hi there, Sorry for the late reply. 2015-01-20 4:15 GMT-07:00 Oliver Neukum oneu...@suse.de: On Sun, 2015-01-18 at 18:30 -0700, Azael Avalos wrote: The following patches add support to several USB Sleep functions found on

Re: [PATCHv5 4/4] USB: gadget: atmel_usba_udc: Add suspend/resume with wakeup support

2015-01-21 Thread Boris Brezillon
Hi Sylvain, On Wed, 21 Jan 2015 20:31:14 +0100 Sylvain Rochet sylvain.roc...@finsecur.com wrote: This patch add suspend/resume with wakeup support for Atmel USBA. On suspend: We stay continuously clocked if Vbus signal is not available. If Vbus signal is available we set the Vbus signal as

Re: [PATCH v2 0/4] toshiba_acpi: Add support for USB Sleep functions

2015-01-21 Thread Azael Avalos
Hi there, Sorry for the late reply. 2015-01-20 4:15 GMT-07:00 Oliver Neukum oneu...@suse.de: On Sun, 2015-01-18 at 18:30 -0700, Azael Avalos wrote: The following patches add support to several USB Sleep functions found on newer Toshiba laptops, allowing to use the USB ports while the laptop

Re: [RFC PATCH] usb: dwc2: Use platform endianness when accessing registers

2015-01-21 Thread John Crispin
Hi, small nitpick On 21/01/2015 19:27, Antti Seppälä wrote: This patch switches calls to readl/writel to their __raw_readl/__raw_writel equivalents which preserve platform endianness. This patch is necessary to access dwc2 registers correctly on big endian systems such as mips. Then dwc2

[PATCHv5 1/4] USB: gadget: atmel_usba_udc: Fixed vbus_prev initial state

2015-01-21 Thread Sylvain Rochet
If vbus gpio is high at init, we should set vbus_prev to true accordingly to the current vbus state. Without that, we skip the first vbus interrupt because the saved vbus state is not consistent. Signed-off-by: Sylvain Rochet sylvain.roc...@finsecur.com Acked-by: Nicolas Ferre

[PATCHv5 2/4] USB: gadget: atmel_usba_udc: Request an auto disabled Vbus signal IRQ instead of an auto enabled IRQ request followed by IRQ disable

2015-01-21 Thread Sylvain Rochet
Vbus IRQ handler needs a started UDC driver to work because it uses udc-driver, which is set by the UDC start handler. The previous way chosen was to return from interrupt if udc-driver is NULL using a spinlock around the check. We now request an auto disabled (IRQ_NOAUTOEN) Vbus signal IRQ

[PATCHv5 4/4] USB: gadget: atmel_usba_udc: Add suspend/resume with wakeup support

2015-01-21 Thread Sylvain Rochet
This patch add suspend/resume with wakeup support for Atmel USBA. On suspend: We stay continuously clocked if Vbus signal is not available. If Vbus signal is available we set the Vbus signal as a wake up source then we stop the USBA itself and all clocks used by USBA. On resume: We recover

Re: Control message failures kill entire XHCI stack

2015-01-21 Thread Devin Heitmueller
I've been following this as it somewhat resembles the problems I'm experiencing, which I've just formally reported in Hauppauge USB-Live2 recording fails on USB3 port. Yeah, it happens with the cx231xx as well, although the sequencing of events leading to the failure is a bit different (I

[PATCHv5 3/4] USB: gadget: atmel_usba_udc: Start clocks on rising edge of the Vbus signal, stop clocks on falling edge of the Vbus signal

2015-01-21 Thread Sylvain Rochet
If USB PLL is not necessary for other USB drivers (e.g. OHCI and EHCI) we will reduce power consumption by switching off the USB PLL if no USB Host is currently connected to this USB Device. We are using Vbus GPIO signal to detect Host presence. If Vbus signal is not available then the device

[PATCHv5 0/4] USB: gadget: atmel_usba_udc: Driver improvements

2015-01-21 Thread Sylvain Rochet
Start clocks on rising edge of the Vbus signal, stop clocks on falling edge of the Vbus signal. Add suspend/resume with wakeup support. Changes since v4: * Now using IRQ_NOAUTOEN flag to remove the unused check for udc-driver is not NULL in the Vbus IRQ. * Reworked the start/stop of

Re: MUSB dual-role on AM335x behaving weirdly

2015-01-21 Thread Bin Liu
Hi, On Wed, Jan 21, 2015 at 10:06 AM, Maxime Ripard maxime.rip...@free-electrons.com wrote: Hi Felipe, I'm currently working on a custom AM335x-based board, that has a OTG connector wired to one of the musb controlers, and Linux 3.17 This OTG connector seems to behave in a weird way when it

[PATCHv2] usb: core: hub: modify hub reset logic in hub driver

2015-01-21 Thread deepakdas . linux
From: Deepak Das deepakdas.li...@gmail.com Currently if port power is turned off by user on hub port using USBDEVFS then port power is turned back ON by hub driver. This commit modifies hub reset logic in hub_port_connect() to prevent hub driver from turning back the port power ON if port is not

[RFC PATCH] usb: dwc2: Use platform endianness when accessing registers

2015-01-21 Thread Antti Seppälä
This patch switches calls to readl/writel to their __raw_readl/__raw_writel equivalents which preserve platform endianness. This patch is necessary to access dwc2 registers correctly on big endian systems such as mips. Then dwc2 can be used to replace ifx-hcd driver for lantiq platform found e.g.

[PATCH] USB: don't cancel queued resets when unbinding drivers

2015-01-21 Thread Alan Stern
The USB stack provides a mechanism for drivers to request an asynchronous device reset (usb_queue_reset_device()). The mechanism uses a work item (reset_ws) embedded in the usb_interface structure used by the driver, and the reset is carried out by a work queue routine. The asynchronous reset

Re: Control message failures kill entire XHCI stack

2015-01-21 Thread Alistair Grant
Hi Matthias, On Tue, Jan 20, 2015 at 10:22 AM, Mathias Nyman mathias.ny...@linux.intel.com wrote: On 19.01.2015 22:02, Devin Heitmueller wrote: Hi Mathias, Thanks for getting back to me. There are a couple of xhci bugs triggered by dvb devices:

MUSB dual-role on AM335x behaving weirdly

2015-01-21 Thread Maxime Ripard
Hi Felipe, I'm currently working on a custom AM335x-based board, that has a OTG connector wired to one of the musb controlers, and Linux 3.17 This OTG connector seems to behave in a weird way when it comes to switching from one role to another: - The host mode works with

Re: [PATCH] usb: core: hub: modify hub reset logic in hub driver

2015-01-21 Thread Deepak Das
On 21 January 2015 at 15:58, Alan Stern st...@rowland.harvard.edu wrote: On Wed, 21 Jan 2015 deepakdas.li...@gmail.com wrote: From: Deepak Das deepakdas.li...@gmail.com Currently if port power is turned off by user on hub port using USBDEVFS then port power is turned back ON by hub driver.

Re: [PATCH 2/2] usb: musb: try a race-free wakeup

2015-01-21 Thread Bin Liu
Hi Sebastian, On Mon, Oct 27, 2014 at 1:06 PM, Sebastian Andrzej Siewior bige...@linutronix.de wrote: Attaching a keyboard, using it as a wakeup via |for f in $(find /sys/devices/ocp.3/4740.usb -name wakeup) |do | echo enabled $f |done going into standby | echo standby

Re: [PATCHv2 001/002] usbhid: Fix initialisation for the Microsoft Sidewinder Force Feedback Pro 2 joystick

2015-01-21 Thread Jim Keir
Hi, Thanks for the feedback. I've included a replacement patch here for the first issue, and will send a separate message with a patch for the third issue. I've removed the second as per Alan's request. This diff is against the latest version of the hid branch rather than the 3.13 branch I

Re: Boot regression on Versatile Express TC2 after commit b2b49ccbdd

2015-01-21 Thread Alan Stern
On Wed, 21 Jan 2015, Rafael J. Wysocki wrote: Well, assuming that the HCD driver doesn't support wakeup signaling, it would be good to have a way to indicate the lack of support for autosuspend to the USB core so as to avoid the user-visible breakage. Do we have any means for that?

Re: [PATCHv3 1/2] usb: ehci-platform: add support for multiple phys per controller

2015-01-21 Thread Alan Stern
On Wed, 21 Jan 2015, Arun Ramamurthy wrote: Thanks Alan. I did run check patch and I had no errors or warnings. I explained my changes in v3 in the cover patch, did that not come through or is it convention to do it in the individual patch? Oh, sorry, I missed it. Must have deleted that

Re: [PATCHv5 0/4] USB: gadget: atmel_usba_udc: Driver improvements

2015-01-21 Thread Boris Brezillon
Hi Sylvain, On Wed, 21 Jan 2015 20:31:10 +0100 Sylvain Rochet sylvain.roc...@finsecur.com wrote: Start clocks on rising edge of the Vbus signal, stop clocks on falling edge of the Vbus signal. Add suspend/resume with wakeup support. Apart from the minor comment I made on patch 4, you can

Re: Boot regression on Versatile Express TC2 after commit b2b49ccbdd

2015-01-21 Thread Alan Stern
On Wed, 21 Jan 2015, Rafael J. Wysocki wrote: If nothing happens, there are two possibilities: The hub doesn't support wakeup signalling, or the isp1760-hcd driver doesn't support it. To tell the truth, it wouldn't be surprising if the second turns out to be the case.

[PATCH] USB: cp210x: add ID for RUGGEDCOM USB Serial Console

2015-01-21 Thread Lennart Sorensen
Added the USB serial console device ID for Siemens Ruggedcom devices which have a USB port for their serial console. Signed-off-by: Len Sorensen lsore...@csclub.uwaterloo.ca --- drivers/usb/serial/cp210x.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/serial/cp210x.c

Re: Boot regression on Versatile Express TC2 after commit b2b49ccbdd

2015-01-21 Thread Rafael J. Wysocki
On Wednesday, January 21, 2015 04:36:35 PM Alan Stern wrote: On Wed, 21 Jan 2015, Rafael J. Wysocki wrote: If nothing happens, there are two possibilities: The hub doesn't support wakeup signalling, or the isp1760-hcd driver doesn't support it. To tell the truth, it wouldn't

Re: Boot regression on Versatile Express TC2 after commit b2b49ccbdd

2015-01-21 Thread Rafael J. Wysocki
On Wednesday, January 21, 2015 05:05:36 PM Alan Stern wrote: On Wed, 21 Jan 2015, Rafael J. Wysocki wrote: Well, assuming that the HCD driver doesn't support wakeup signaling, it would be good to have a way to indicate the lack of support for autosuspend to the USB core so as to avoid

Re: [PATCH 00/13] usb: second series of updates for dwc2 driver

2015-01-21 Thread Dinh Nguyen
On 01/21/2015 02:54 AM, Kaukab, Yousaf wrote: Hi John, -Original Message- From: Kaukab, Yousaf Sent: Thursday, January 15, 2015 6:09 PM To: linux-usb@vger.kernel.org; ba...@ti.com Cc: john.y...@synopsys.com; Herrero, Gregory; pa...@synopsys.com; r.bald...@samsung.com;

Re: [PATCH 2/9] power/reset: brcmstb: Use the DT compatible string to indicate bit positions

2015-01-21 Thread Sebastian Reichel
Hi, On Tue, Nov 25, 2014 at 04:49:47PM -0800, Kevin Cernekee wrote: Some of the older chips used different bits to arm and trigger the reset. Add the infrastructure needed to specify this through the compatible string. Thanks, applied. -- Sebastian signature.asc Description: Digital

Re: [PATCH 1/9] power/reset: brcmstb: Make the driver buildable on MIPS

2015-01-21 Thread Sebastian Reichel
Hi, On Tue, Nov 25, 2014 at 04:49:46PM -0800, Kevin Cernekee wrote: Now that the driver doesn't use any ARM-specific headers, it is safe to build on MIPS or with COMPILE_TEST. Thanks, applied. -- Sebastian signature.asc Description: Digital signature

Re: [PATCH 3/4] mfd: dln2: add support for ACPI

2015-01-21 Thread Rafael J. Wysocki
On Tuesday, December 16, 2014 06:12:32 PM Octavian Purdila wrote: This patch adds support to load a custom ACPI table that describes devices connected via the DLN2 USB to I2C/SPI/GPIO bridge. The ACPI table can be loaded either externally (from QEMU or with CONFIG_ACPI_CUSTOM_DSDT) or it can

Re: [PATCH 3/9] power/reset: brcmstb: Add support for old 65nm chips

2015-01-21 Thread Sebastian Reichel
Hi, On Tue, Nov 25, 2014 at 04:49:48PM -0800, Kevin Cernekee wrote: The register bit fields are a little different, so add an entry and a compatible string to accommodate them. Thanks, applied. -- Sebastian signature.asc Description: Digital signature

RE: [PATCH v1 00/13] usb: second series of updates for dwc2 driver

2015-01-21 Thread John Youn
From: Mian Yousaf Kaukab [mailto:yousaf.kau...@intel.com] Sent: Wednesday, January 21, 2015 6:37 AM Hi, This patchset consists of some bug fixes, feature enhancements and cosmetic changes for the dwc2 driver. All the patches are verified on dwc2 v3.0a with dedicated fifos. Main focus

RE: [PATCH v1 00/13] usb: second series of updates for dwc2 driver

2015-01-21 Thread John Youn
From: Mian Yousaf Kaukab [mailto:yousaf.kau...@intel.com] Sent: Wednesday, January 21, 2015 6:37 AM Hi, This patchset consists of some bug fixes, feature enhancements and cosmetic changes for the dwc2 driver. All the patches are verified on dwc2 v3.0a with dedicated fifos. Main focus of

Re: [PATCH v2 3/4] usb: serial: implement function for F81232

2015-01-21 Thread Peter Hung
Hello, I'll do it later depend on this series patchs to be accpeted or rejected. Thanks for your advice One Thousand Gnomes 於 2015/1/21 下午 10:41 寫道: + if (cflag PARENB) { + if (cflag PARODD) + new_lcr |= UART_LCR_PARITY; /* odd */ +

Re: [PATCH 0/2] usb: renesas_usbhs: add support for requesting DT DMA

2015-01-21 Thread Kuninori Morimoto
Hi shimoda-san This patch series is based on Felipe's usb.git / testing/next branch. (commit id = 05cf6e00b8ff2b80c8b2d1e69f07cdd6c830efe0) Yoshihiro Shimoda (2): usb: renesas_usbhs: add usbhsf_dma_init_pdev() function usb: renesas_usbhs: add support for requesting DT DMA

Bad DMA for ehci_qtd after suspend/resume cycle on Exynos7 (64-bit)

2015-01-21 Thread Vivek Gautam
Hi all, While working on our test board with Exynos7 SoC, we see that across suspend/resume (Suspend to RAM) the EHCI can't resume the devices connected to HSIC phy properly. We have been using 3.16 kernel for our development, but on the ehci-exynos driver side there isn't any delta that we

Re: [PATCH v7 2/5] phy: add a driver for the Rockchip SoC internal USB2.0 PHY

2015-01-21 Thread Kishon Vijay Abraham I
Hi, On Wednesday 21 January 2015 03:36 PM, Yunzhi Li wrote: Hi Kishon : Hi, On Friday 12 December 2014 08:37 PM, Yunzhi Li wrote: This patch to add a generic PHY driver for ROCKCHIP usb PHYs, currently this driver can support RK3288. The RK3288 SoC have three independent USB PHY IPs which

[PATCH v2 2/4] usb: serial: fix callback wrong process for F81232

2015-01-21 Thread Peter Hung
Our int callback will return IIR, not LSR, and bulk-in callback will return [LSR+Data][LSR+Data], so need to rewrite it Signed-off-by: Peter Hung hpeter+linux_ker...@gmail.com --- drivers/usb/serial/f81232.c | 82 + 1 file changed, 39 insertions(+), 43

[PATCH v2 4/4] usb: serial: remove unused function for F81232

2015-01-21 Thread Peter Hung
remove unused function set_line_control Signed-off-by: Peter Hung hpeter+linux_ker...@gmail.com --- drivers/usb/serial/f81232.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/usb/serial/f81232.c b/drivers/usb/serial/f81232.c index 9a54f56..11a236b 100644 ---

Re: [PATCH v7 2/5] phy: add a driver for the Rockchip SoC internal USB2.0 PHY

2015-01-21 Thread Yunzhi Li
Hi Kishon : Hi, On Wednesday 21 January 2015 03:36 PM, Yunzhi Li wrote: Hi Kishon : Hi, On Friday 12 December 2014 08:37 PM, Yunzhi Li wrote: This patch to add a generic PHY driver for ROCKCHIP usb PHYs, currently this driver can support RK3288. The RK3288 SoC have three independent USB

Re: [PATCH] mmc: vub300: remove unreachable return value handling

2015-01-21 Thread Ulf Hansson
On 18 January 2015 at 02:51, Nicholas Mc Guire der.h...@hofr.at wrote: Signed-off-by: Nicholas Mc Guire der.h...@hofr.at Thanks! Applied for next. Kind regards Uffe --- The return value of wait_for_completion_timeout is unsigned long, as it is used here for wait_for_completion_timeout only

Re: [PATCH v7 2/5] phy: add a driver for the Rockchip SoC internal USB2.0 PHY

2015-01-21 Thread Yunzhi Li
Hi Kishon : Hi, On Friday 12 December 2014 08:37 PM, Yunzhi Li wrote: This patch to add a generic PHY driver for ROCKCHIP usb PHYs, currently this driver can support RK3288. The RK3288 SoC have three independent USB PHY IPs which are all configured through a set of registers located in the GRF

[PATCH v2 3/4] usb: serial: implement function for F81232

2015-01-21 Thread Peter Hung
This patch implement the following function: set_termios, tiocmset, tiocmget, dtr_rts Signed-off-by: Peter Hung hpeter+linux_ker...@gmail.com --- drivers/usb/serial/f81232.c | 103 1 file changed, 84 insertions(+), 19 deletions(-) mode change 100644

[PATCH v2 1/4] usb: serial: add register map for F81232

2015-01-21 Thread Peter Hung
Add register map for F81232. and add some function to operating this device. etc. f81232_get_register()/f81232_set_register() to work with USB control point. and worker f81232_int_work_wq() to read MSR when IIR acquired. Signed-off-by: Peter Hung hpeter+linux_ker...@gmail.com ---

Re: [PATCH 3/3] phy: ulpi: add driver for TI TUSB1210

2015-01-21 Thread Heikki Krogerus
Hi, On Wed, Jan 21, 2015 at 11:17:49AM +0200, Heikki Krogerus wrote: On Tue, Jan 20, 2015 at 09:45:39AM -0600, Felipe Balbi wrote: diff --git a/drivers/phy/ulpi/tusb1210.c b/drivers/phy/ulpi/tusb1210.c new file mode 100644 index 000..ac77f98 --- /dev/null +++

Re: [PATCH v2 4/4] usb: serial: remove unused function for F81232

2015-01-21 Thread Sergei Shtylyov
Hello. On 1/21/2015 1:30 PM, Peter Hung wrote: remove unused function set_line_control The source says set_control_lines(). Signed-off-by: Peter Hung hpeter+linux_ker...@gmail.com --- drivers/usb/serial/f81232.c | 7 --- 1 file changed, 7 deletions(-) diff --git

[PATCH] usb: core: hub: modify hub reset logic in hub driver

2015-01-21 Thread deepakdas . linux
From: Deepak Das deepakdas.li...@gmail.com Currently if port power is turned off by user on hub port using USBDEVFS then port power is turned back ON by hub driver. This commit modifies hub reset logic in hub_port_connect() to prevent hub driver from turning back the port power ON if port is not

Re: [PATCH v2 3/5] usb: dwc3: Add quirk for Synopsis device disconnection errata

2015-01-21 Thread Sneeker Yeh
Hi Felipe: Thanks for reviewing these, 2015-01-19 22:50 GMT+08:00 Felipe Balbi ba...@ti.com: Hi, On Mon, Jan 19, 2015 at 03:56:47PM +0800, Sneeker Yeh wrote: Synopsis Designware USB3 IP earlier than v3.00a which is configured in silicon with DWC_USB3_SUSPEND_ON_DISCONNECT_EN=1, would need

[PATCH] usb: gadget: zero: fix format string warnings

2015-01-21 Thread Asaf Vertz
Fixed the following warnings (reported by cppcheck): [drivers/usb/gadget/function/f_sourcesink.c:1217]: (warning) %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [drivers/usb/gadget/function/f_sourcesink.c:1261]: (warning) %d in format string (no. 1) requires

Re: [PATCHv4 2/3] USB: gadget: atmel_usba_udc: Enable Vbus signal IRQ in UDC start instead of UDC probe

2015-01-21 Thread Boris Brezillon
Hi Sylvain, On Tue, 20 Jan 2015 22:23:29 +0100 Sylvain Rochet sylvain.roc...@finsecur.com wrote: Vbus IRQ handler needs a started UDC driver to work because it uses udc-driver, which is set by the UDC start handler. The previous way chosen was to return from interrupt if udc-driver is NULL

Re: [PATCH v7 2/5] phy: add a driver for the Rockchip SoC internal USB2.0 PHY

2015-01-21 Thread Kishon Vijay Abraham I
Hi, On Friday 12 December 2014 08:37 PM, Yunzhi Li wrote: This patch to add a generic PHY driver for ROCKCHIP usb PHYs, currently this driver can support RK3288. The RK3288 SoC have three independent USB PHY IPs which are all configured through a set of registers located in the GRF (general

RE: [PATCH 00/13] usb: second series of updates for dwc2 driver

2015-01-21 Thread Kaukab, Yousaf
Hi John, -Original Message- From: Kaukab, Yousaf Sent: Thursday, January 15, 2015 6:09 PM To: linux-usb@vger.kernel.org; ba...@ti.com Cc: john.y...@synopsys.com; Herrero, Gregory; pa...@synopsys.com; r.bald...@samsung.com; dingu...@opensource.altera.com; Kaukab, Yousaf Subject:

Re: [PATCH v2 0/3] ARM: mvebu: Enable XHCI on the Armada 385 AP

2015-01-21 Thread Maxime Ripard
On Tue, Jan 20, 2015 at 09:43:07PM +0100, Andrew Lunn wrote: On Tue, Jan 20, 2015 at 09:30:28PM +0100, Maxime Ripard wrote: Hi Andrew, On Mon, Jan 19, 2015 at 10:35:07PM +0100, Andrew Lunn wrote: On Mon, Jan 19, 2015 at 02:01:11PM +0100, Maxime Ripard wrote: Hi all, This

Re: [PATCH v2 4/5] xhci: Platform: Set Synopsis device disconnection quirk based on platform data

2015-01-21 Thread Sneeker Yeh
hi, 2015-01-19 22:51 GMT+08:00 Felipe Balbi ba...@ti.com: On Mon, Jan 19, 2015 at 03:56:48PM +0800, Sneeker Yeh wrote: If an xhci platform has Synopsis device disconnection errata then enable XHCI_DISCONNECT_QUIRK quirk flag. Signed-off-by: Sneeker Yeh sneeker@tw.fujitsu.com ---

Re: [PATCH 2/3] usb: dwc3: add ULPI interface support

2015-01-21 Thread Heikki Krogerus
On Tue, Jan 20, 2015 at 09:23:37AM -0600, Felipe Balbi wrote: Hi, On Tue, Jan 20, 2015 at 11:18:21AM +0200, Heikki Krogerus wrote: Registers ULPI interface with the ULPI bus if HSPHY type is ULPI. Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com Cc: Felipe Balbi

Re: [PATCH 3/3] phy: ulpi: add driver for TI TUSB1210

2015-01-21 Thread Heikki Krogerus
On Tue, Jan 20, 2015 at 09:45:39AM -0600, Felipe Balbi wrote: Hi, On Tue, Jan 20, 2015 at 11:18:22AM +0200, Heikki Krogerus wrote: TUSB1210 ULPI PHY has vendor specific register for eye diagram tuning. On some platforms the system firmware has set optimized value to it. In order to not

Re: [PATCH v2 2/5] usb: dwc3: add revision number DWC3_REVISION_300A

2015-01-21 Thread Sneeker Yeh
hi, 2015-01-20 4:00 GMT+08:00 Felipe Balbi ba...@ti.com: On Mon, Jan 19, 2015 at 07:45:31PM +, John Youn wrote: -Original Message- From: Felipe Balbi [mailto:ba...@ti.com] Sent: Monday, January 19, 2015 6:47 AM looking at Synopsys Solvnet for this IP, it shows that current

Re: [PATCHv4 2/3] USB: gadget: atmel_usba_udc: Enable Vbus signal IRQ in UDC start instead of UDC probe

2015-01-21 Thread Sylvain Rochet
Hi Boris, On Wed, Jan 21, 2015 at 10:20:16AM +0100, Boris Brezillon wrote: udc-vbus_prev = 0; - if (gpio_is_valid(udc-vbus_pin)) - enable_irq(gpio_to_irq(udc-vbus_pin)); + if (gpio_is_valid(udc-vbus_pin)) { + ret = request_irq(gpio_to_irq(udc-vbus_pin),

[RFC]cdc-wdm: bug in ceasing IO

2015-01-21 Thread Oliver Neukum
From c37d436b8832e817ab437baa3324f6c08c846af9 Mon Sep 17 00:00:00 2001 From: Oliver Neukum oneu...@suse.de Date: Fri, 16 Jan 2015 15:13:28 +0100 Subject: [PATCH] cdc-wdm: bug in ceasing IO The work submits the URB and the URB queues the work. To reliably kill this cycle a flag needs to be set and

[RFC]cdc-wdm: fix deadlock in scheduled work

2015-01-21 Thread Oliver Neukum
From 5cfcd26b872719089dd714b5b1047d4d6e985889 Mon Sep 17 00:00:00 2001 From: Oliver Neukum oneu...@suse.de Date: Tue, 20 Jan 2015 15:28:53 +0100 Subject: [PATCH] cdc-wdm: fix deadlock in scheduled work The scheduled work can deadlock in the error handling case. kmalloc with GFP_KERNEL in the

[RFC]cdc-wdm: race between work queue and pre_reset

2015-01-21 Thread Oliver Neukum
From 7cccf82cf2c34f8e5b3a60100a1e35108c52bfba Mon Sep 17 00:00:00 2001 From: Oliver Neukum oneu...@suse.de Date: Fri, 16 Jan 2015 14:58:23 +0100 Subject: [PATCH] cdc-wdm: race between work queue and pre_reset pre_reset() must cease IO so the work needs to check the flag. Signed-off-by: Oliver

question on stable fix f161ead70fa6a62e432dff6e9dab8e3cfbeabea6

2015-01-21 Thread Oliver Neukum
Hi Mathias, regarding commit f161ead70fa6a62e432dff6e9dab8e3cfbeabea6 Author: Mathias Nyman mathias.ny...@linux.intel.com Date: Fri Jan 9 17:18:28 2015 +0200 xhci: Check if slot is already in default state before moving it there you are marking this for stable only on 3.14+ I don't see

Re: [PATCHv2 001/002] usbhid: Fix initialisation for the Microsoft Sidewinder Force Feedback Pro 2 joystick

2015-01-21 Thread Benjamin Tissoires
HI Jim, On Wed, Jan 21, 2015 at 9:29 AM, Jim Keir jimk...@oracledbadirect.com wrote: Hi, Thanks for the feedback. I've included a replacement patch here for the first issue, and will send a separate message with a patch for the third issue. I've removed the second as per Alan's request. This

Re: [PATCH] usb: core: hub: modify hub reset logic in hub driver

2015-01-21 Thread Alan Stern
On Wed, 21 Jan 2015 deepakdas.li...@gmail.com wrote: From: Deepak Das deepakdas.li...@gmail.com Currently if port power is turned off by user on hub port using USBDEVFS then port power is turned back ON by hub driver. This commit modifies hub reset logic in hub_port_connect() to prevent

Re: [PATCHv3 1/2] usb: ehci-platform: add support for multiple phys per controller

2015-01-21 Thread Alan Stern
On Mon, 19 Jan 2015 arun.ramamur...@broadcom.com wrote: From: Arun Ramamurthy arunr...@broadcom.com Added support for cases where one controller is connected to multiple phys. Signed-off-by: Arun Ramamurthy arunr...@broadcom.com Reviewed-by: Ray Jui r...@broadcom.com Reviewed-by: Scott

[PATCH v1 03/13] usb: dwc2: gadget: fix clear halt feature handling

2015-01-21 Thread Mian Yousaf Kaukab
From: Gregory Herrero gregory.herr...@intel.com When clearing HALT on an endpoint, req-complete of in progress requests must be called with locks off. New request should only be started if there is not already a pending request on the endpoint. Signed-off-by: Gregory Herrero

[PATCH v1 08/13] usb: dwc2: gadget: add reset flag in init function

2015-01-21 Thread Mian Yousaf Kaukab
From: Gregory Herrero gregory.herr...@intel.com Add a flag to request physical reset of the controller when s3c_hsotg_core_init_disconnected is called. During the usb reset, controller must not be fully reconfigured and resetted. Else this leads to shorter chirp-k duration during enumeration.

[PATCH v1 07/13] usb: dwc2: gadget: add unaligned buffers support

2015-01-21 Thread Mian Yousaf Kaukab
When using DMA, dwc2 requires buffers to be 4 bytes aligned. Use bounce buffers if they are not. Signed-off-by: Mian Yousaf Kaukab yousaf.kau...@intel.com --- drivers/usb/dwc2/core.h | 2 ++ drivers/usb/dwc2/gadget.c | 62 ++- 2 files changed, 63

[PATCH v1 04/13] usb: dwc2: gadget: add TEST_MODE feature support

2015-01-21 Thread Mian Yousaf Kaukab
From: Gregory Herrero gregory.herr...@intel.com Handle SET_FEATURE TEST_MODE request sent by the host. Slightly rework FEATURE request handling to allow parsing other request types than Endpoint. Also add a debugfs to change test mode value from user space. Signed-off-by: Gregory Herrero

[PATCH v1 10/13] usb: dwc2: gadget: fix debug message for zlp

2015-01-21 Thread Mian Yousaf Kaukab
Print debug message according to zlp direction. Always saying Sending is misleading. Signed-off-by: Mian Yousaf Kaukab yousaf.kau...@intel.com --- drivers/usb/dwc2/gadget.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/usb/dwc2/gadget.c

[PATCH v1 13/13] usb: dwc2: gadget: initialize controller in pullup callback

2015-01-21 Thread Mian Yousaf Kaukab
From: Gregory Herrero gregory.herr...@intel.com USB reset interrupt is no more used to reset the controller. Thus, reset the controller in pullup callback as described by Synopsys programming guide. Otherwise enumeration sometimes fails when usb configuration is switched without physical

[PATCH v1 09/13] usb: dwc2: gadget: don't modify pullup status during reset

2015-01-21 Thread Mian Yousaf Kaukab
From: Gregory Herrero gregory.herr...@intel.com Pullup doesn't need to be enabled during usb reset since it is already enabled. This leads to shorter chirp-k duration if done during usb reset. Signed-off-by: Gregory Herrero gregory.herr...@intel.com --- drivers/usb/dwc2/gadget.c | 1 - 1 file

[PATCH v1 11/13] usb: dwc2: gadget: fix phy interface configuration

2015-01-21 Thread Mian Yousaf Kaukab
hsotg-phyif is set in dwc2_gadget_init according to phy interface width. Use it for configuration instead of hardcoded value. Moreover, set USB turnaround time according to phy width. Signed-off-by: Mian Yousaf Kaukab yousaf.kau...@intel.com --- drivers/usb/dwc2/gadget.c | 10 +++--- 1 file

[PATCH v1 05/13] usb: dwc2: gadget: fix a typo in comment

2015-01-21 Thread Mian Yousaf Kaukab
From: Gregory Herrero gregory.herr...@intel.com s3c_hsotg_process_req_feature comments was not correct Signed-off-by: Gregory Herrero gregory.herr...@intel.com --- drivers/usb/dwc2/gadget.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/dwc2/gadget.c

[PATCH v1 01/13] usb: dwc2: host: register hcd handle to the phy

2015-01-21 Thread Mian Yousaf Kaukab
From: Gregory Herrero gregory.herr...@intel.com If phy driver is present, register hcd handle to it and let it take care of calling usb_add_hcd. Otherwise, add hcd here. Moreover, save irq number so that it can be used to call usb_add_hcd. Signed-off-by: Gregory Herrero

[PATCH v1 00/13] usb: second series of updates for dwc2 driver

2015-01-21 Thread Mian Yousaf Kaukab
Hi, This patchset consists of some bug fixes, feature enhancements and cosmetic changes for the dwc2 driver. All the patches are verified on dwc2 v3.0a with dedicated fifos. Main focus of testing was with dma enabled. Although basic testing without dma was also done. This is based on testing/next

[PATCH v1 06/13] usb: dwc2: gadget: remove hardcoded if (0) and if (1) checks

2015-01-21 Thread Mian Yousaf Kaukab
Remove dead code as well. Signed-off-by: Mian Yousaf Kaukab yousaf.kau...@intel.com --- drivers/usb/dwc2/gadget.c | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c index aa5c0ba..fc9462a 100644 ---

[PATCH v1 02/13] usb: dwc2: host: resume root hub on remote wakeup

2015-01-21 Thread Mian Yousaf Kaukab
From: Gregory Herrero gregory.herr...@intel.com When a remote wakeup happens during bus_suspend, hcd needs to resume its root hub. Signed-off-by: Gregory Herrero gregory.herr...@intel.com --- drivers/usb/dwc2/hcd.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

[PATCH v1 12/13] usb: dwc2: gadget: replace constants with defines

2015-01-21 Thread Mian Yousaf Kaukab
Defines are more readable and searchable than constants. Signed-off-by: Mian Yousaf Kaukab yousaf.kau...@intel.com --- drivers/usb/dwc2/gadget.c | 24 drivers/usb/dwc2/hw.h | 1 + 2 files changed, 13 insertions(+), 12 deletions(-) diff --git

Re: [PATCH v2 3/4] usb: serial: implement function for F81232

2015-01-21 Thread One Thousand Gnomes
+ if (cflag PARENB) { + if (cflag PARODD) + new_lcr |= UART_LCR_PARITY; /* odd */ + else + new_lcr |= SERIAL_EVEN_PARITY; /* even */ + } If you don't support mark/space also clear CMSPAR in the passed termios -

Re: [PATCH 04/13] usb: dwc2: gadget: add TEST_MODE feature support

2015-01-21 Thread Robert Baldyga
Hi, I got following error: drivers/usb/dwc2/gadget.c: In function ‘testmode_write’: drivers/usb/dwc2/gadget.c:3409:2: error: implicit declaration of function ‘copy_from_user’ [-Werror=implicit-function-declaration] You should add: +#include linux/uaccess.h Best regards, Robert Baldyga On

Re: [PATCH 11/11] usb: core: fix a race with usb_queue_reset_device()

2015-01-21 Thread Olivier Sobrie
Hello Alan, On Tue, Jan 20, 2015 at 10:26:30AM -0500, Alan Stern wrote: On Tue, 20 Jan 2015, Olivier Sobrie wrote: When usb_queue_reset() is called it schedules a work in view of resetting the usb interface. When the reset work is running, it can be scheduled again (e.g. by the usb