Re: [PATCH 2/2] usb: musb: try a race-free wakeup

2015-02-03 Thread Sebastian Andrzej Siewior
On 02/02/2015 11:44 PM, Bin Liu wrote: > Sebastian, Hi Bin, > I think I found the cause. Plugging a device behind a hub, this is > related to runtime PM, so the finish_resume_work() should also be > added in musb_runtime_resume(), also musb_host_resume_root_hub() > should not be moved as did in y

Re: Kernel Ooops upon USB disconnect of a Western Digital My Passport 1TB drive

2015-02-03 Thread Athlion
On Mon, Feb 2, 2015 at 7:27 PM, Alan Stern wrote: > Had you made any changes to the runtime suspend settings? > blk_post_runtime_resume wouldn't be called unless the drive had gone > into runtime suspend. And even then, it's not likely to be called > after you unplug the USB cable. > > Alan Ster

RE: [PATCH RESEND] usb: dwc2: Fix a bug in reading the endpoint directions from reg.

2015-02-03 Thread Kaukab, Yousaf
Hi Roshan, > -Original Message- > From: Roshan Pius [mailto:rp...@chromium.org] > Sent: Monday, February 2, 2015 11:56 PM > To: linux-usb@vger.kernel.org > Cc: benc...@chromium.org; Kaukab, Yousaf; Roshan Pius > Subject: [PATCH RESEND] usb: dwc2: Fix a bug in reading the endpoint > directi

Re: [PATCH v5 3/3] usb: udc: add usb_udc_activation_handler

2015-02-03 Thread Alexander Shishkin
Peter Chen writes: > Currently, connect gadget is unconditional after binding, > but some function drivers may want to connect gadget on the fly. > With this API, the function driver can disconnect gadget during > the initialization, and connect gadget when it wants. > > During this API, the deac

Re: [PATCH v5 0/3] usb: udc: Unify dp control

2015-02-03 Thread Alexander Shishkin
Peter Chen writes: > On Thu, Jan 29, 2015 at 12:27:23PM +0800, Peter Chen wrote: >> Hi Felipe, >> > > Hi Felipe, I see you tree is closed, but below three patches are > not in your tree, will you queue them now or at next rc? I have > some other patches based on them, so I would like to know you

[PATCH_V4 0/3] usb: ohci: jz4740: Add DT support and a fix

2015-02-03 Thread Zubair Lutfullah Kakakhel
Hi, Here are a few simple patches for the jz4740. First adds a simple DT binding. Seconds adds DT support. Third is a minor fix in clock enabling. Patches are based on 3.19-rc7. Quite disjoint and stay within jz4740 so should apply easily on other trees. If you would like to have them rebased

[PATCH_V4 2/3] usb: ohci: jz4740: add DT support

2015-02-03 Thread Zubair Lutfullah Kakakhel
From: Paul Burton This is a simple matter of providing a match table, the probe code needs no modification. Signed-off-by: Paul Burton Signed-off-by: Zubair Lutfullah Kakakhel Acked-by: Alan Stern --- drivers/usb/host/ohci-jz4740.c | 9 + 1 file changed, 9 insertions(+) diff --git a

[PATCH_V4 1/3] dt: usb: jz4740: Add DT binding document for OHCI

2015-02-03 Thread Zubair Lutfullah Kakakhel
From: Paul Burton Add the binding documentation for the JZ4740 OHCI controller. Signed-off-by: Paul Burton Signed-off-by: Zubair Lutfullah Kakakhel --- The jz4740 is platform only at the moment. But DT support is being added See http://patchwork.linux-mips.org/bundle/paulburton/ci20-v3.20/

[PATCH_V4 3/3] usb: ohci: jz4740: prepare the clock before enabling it

2015-02-03 Thread Zubair Lutfullah Kakakhel
From: Paul Burton The clock must have been prepared before enabling it. Signed-off-by: Paul Burton Signed-off-by: Zubair Lutfullah Kakakhel Acked-by: Alan Stern -- V2 changes. Add disable_unprepare as well --- drivers/usb/host/ohci-jz4740.c | 6 +++--- 1 file changed, 3 insertions(+), 3 del

Re: [PATCH_V4 1/3] dt: usb: jz4740: Add DT binding document for OHCI

2015-02-03 Thread Lars-Peter Clausen
On 02/03/2015 11:17 AM, Zubair Lutfullah Kakakhel wrote: [...] V4 Changes Removed clock binding because of pending work in clock tree. Will add binding later. Rather than introduce a bad binding now and change later. But this patch is introducing a bad binding. The part needs the clock to work

Re: [PATCH_V4 1/3] dt: usb: jz4740: Add DT binding document for OHCI

2015-02-03 Thread Zubair Lutfullah Kakakhel
On 03/02/15 10:32, Lars-Peter Clausen wrote: > On 02/03/2015 11:17 AM, Zubair Lutfullah Kakakhel wrote: > [...] >> V4 Changes >> Removed clock binding because of pending work in clock tree. Will add >> binding later. Rather than introduce a bad binding now and change later. > > But this patch is

Re: [PATCH 8/8] phy: add driver for TI TUSB1210 ULPI PHY

2015-02-03 Thread Heikki Krogerus
Hi David, Felipe, > > > > why would you have dwc3 mess around with the PHY's gpios ? Doesn't look > > > > very good. > > > > > > ..but unfortunately we can't use the bus without it :(. We depend on > > > being able to read the vendor and product id's in the bus driver. > > > > Doesn't the ugly p

Re: [PATCH_V4 1/3] dt: usb: jz4740: Add DT binding document for OHCI

2015-02-03 Thread Sergei Shtylyov
Hello. On 2/3/2015 1:17 PM, Zubair Lutfullah Kakakhel wrote: From: Paul Burton Add the binding documentation for the JZ4740 OHCI controller. Signed-off-by: Paul Burton Signed-off-by: Zubair Lutfullah Kakakhel [...] diff --git a/Documentation/devicetree/bindings/usb/ingenic,jz4740-o

RE: [PATCH v1] ehci-pci: disable for Intel MID platforms

2015-02-03 Thread Alan Stern
On Tue, 3 Feb 2015, Peter Chen wrote: > > > How i386 platform chooses > > > which driver is suitable for device? The ehci_pci_init may overwrite > > > what ci_hdrc_host_init does if it runs later? > > > > There's nothing special about the i386 platform. _All_ platforms that > > support > > PC

Re: [PATCH_V4 1/3] dt: usb: jz4740: Add DT binding document for OHCI

2015-02-03 Thread Lars-Peter Clausen
On 02/03/2015 11:53 AM, Zubair Lutfullah Kakakhel wrote: On 03/02/15 10:32, Lars-Peter Clausen wrote: On 02/03/2015 11:17 AM, Zubair Lutfullah Kakakhel wrote: [...] V4 Changes Removed clock binding because of pending work in clock tree. Will add binding later. Rather than introduce a bad bindi

Re: net2280 driver and gadgetfs?

2015-02-03 Thread Alan Stern
On Tue, 3 Feb 2015, Mario Schuknecht wrote: > I used gadgetfs with PLX3380 controler. I had the problem that was > reported here: > > http://thread.gmane.org/gmane.linux.usb.general/116872/focus=117488 > > Perphaps this is also your problem. The commit that caused the error > is probably this: >

Re: [PATCH 1/3] usb: gadget: function: phonet: balance usb_ep_disable calls

2015-02-03 Thread Pali Rohár
On Tuesday 03 February 2015 00:15:19 Felipe Balbi wrote: > f_phonet's ->set_alt() method will call usb_ep_disable() > potentially on an endpoint which is already disabled. That's > something the gadget/function driver must guarantee that it's > always balanced. > > In order to balance the calls, j

Re: [PATCH 1/3] usb: gadget: function: phonet: balance usb_ep_disable calls

2015-02-03 Thread Felipe Balbi
Hi, On Tue, Feb 03, 2015 at 04:31:51PM +0100, Pali Rohár wrote: > On Tuesday 03 February 2015 00:15:19 Felipe Balbi wrote: > > f_phonet's ->set_alt() method will call usb_ep_disable() > > potentially on an endpoint which is already disabled. That's > > something the gadget/function driver must gua

Re: Kernel Ooops upon USB disconnect of a Western Digital My Passport 1TB drive

2015-02-03 Thread Alan Stern
On Tue, 3 Feb 2015, Athlion wrote: > On Mon, Feb 2, 2015 at 7:27 PM, Alan Stern wrote: > > > Had you made any changes to the runtime suspend settings? > > blk_post_runtime_resume wouldn't be called unless the drive had gone > > into runtime suspend. And even then, it's not likely to be called >

[PATCH v4] ehci-pci: disable for Intel MID platforms (update)

2015-02-03 Thread Andy Shevchenko
This is a follow up to the previously submitted commit cefa9a31a5f0 (ehci-pci: disable for Intel MID platforms). It includes the following changes: - table and function are renamed to reflect this is not only about ChipIdea - ChipIdea PCI driver (ci_hdrc_pci.c) gets the comment about the table in

Re: [PATCH 1/3] usb: gadget: function: phonet: balance usb_ep_disable calls

2015-02-03 Thread Pali Rohár
On Tuesday 03 February 2015 16:43:45 Felipe Balbi wrote: > Hi, > > On Tue, Feb 03, 2015 at 04:31:51PM +0100, Pali Rohár wrote: > > On Tuesday 03 February 2015 00:15:19 Felipe Balbi wrote: > > > f_phonet's ->set_alt() method will call usb_ep_disable() > > > potentially on an endpoint which is alrea

[PATCH] usb: musb: fix device hotplug behind hub

2015-02-03 Thread Bin Liu
The commit 889ad3b "usb: musb: try a race-free wakeup" breaks device hotplug enumeraitonn when the device is connected behind a hub while usb autosuspend is enabled. Adding finish_resume_work into runtime resume callback fixes the issue. Also resume root hub is required to resume the bus from run

OOPS: musb_am335x: __device_attach

2015-02-03 Thread Matwey V. Kornilov
Hi, I am facing the following issue, when running 3.19-rc6 on my beaglebone black: [9.638571] Unable to handle kernel paging request at virtual address 69646b89 [9.646309] pgd = db6dc000 [9.649168] [69646b89] *pgd= [9.652929] Internal error: Oops: 5 [#1] SMP ARM [9.65

Re: intensive IO on usb-storage device causing system lock

2015-02-03 Thread Alan Stern
On Tue, 3 Feb 2015, Enrico Mioso wrote: > Hi guys. > I finally was able to obtain some informations about what was going on - > infos I retained useful. > I am re-sending these, since it seems my previous message didn't get to the > list - but might be I am wrong and didn't find it. > This time

Re: [PATCH RESEND] usb: dwc2: Fix a bug in reading the endpoint directions from reg.

2015-02-03 Thread John Youn
On 02/02/2015 02:55 PM, Roshan Pius wrote: > According to the DWC2 datasheet, the HWCFG1 register stores > the configured endpoint directions for endpoints 0-15 in bit positions > 0-31. > == > Endpoint Direction (EpDir) > This 32-bit field uses two bits per endpoint to dete

Re: [PATCH 1/3] usb: gadget: function: phonet: balance usb_ep_disable calls

2015-02-03 Thread Felipe Balbi
On Tue, Feb 03, 2015 at 05:17:28PM +0100, Pali Rohár wrote: > On Tuesday 03 February 2015 16:43:45 Felipe Balbi wrote: > > Hi, > > > > On Tue, Feb 03, 2015 at 04:31:51PM +0100, Pali Rohár wrote: > > > On Tuesday 03 February 2015 00:15:19 Felipe Balbi wrote: > > > > f_phonet's ->set_alt() method wi

Re: [PATCH 1/3] usb: gadget: function: phonet: balance usb_ep_disable calls

2015-02-03 Thread Pali Rohár
On Tuesday 03 February 2015 20:18:59 Felipe Balbi wrote: > On Tue, Feb 03, 2015 at 05:17:28PM +0100, Pali Rohár wrote: > > On Tuesday 03 February 2015 16:43:45 Felipe Balbi wrote: > > > Hi, > > > > > > On Tue, Feb 03, 2015 at 04:31:51PM +0100, Pali Rohár wrote: > > > > On Tuesday 03 February 2015

Re: [PATCH 1/3] usb: gadget: function: phonet: balance usb_ep_disable calls

2015-02-03 Thread Felipe Balbi
On Tue, Feb 03, 2015 at 08:27:52PM +0100, Pali Rohár wrote: > On Tuesday 03 February 2015 20:18:59 Felipe Balbi wrote: > > On Tue, Feb 03, 2015 at 05:17:28PM +0100, Pali Rohár wrote: > > > On Tuesday 03 February 2015 16:43:45 Felipe Balbi wrote: > > > > Hi, > > > > > > > > On Tue, Feb 03, 2015 at

Re: [PATCH 1/3] usb: gadget: function: phonet: balance usb_ep_disable calls

2015-02-03 Thread Felipe Balbi
On Tue, Feb 03, 2015 at 01:35:25PM -0600, Felipe Balbi wrote: > On Tue, Feb 03, 2015 at 08:27:52PM +0100, Pali Rohár wrote: > > On Tuesday 03 February 2015 20:18:59 Felipe Balbi wrote: > > > On Tue, Feb 03, 2015 at 05:17:28PM +0100, Pali Rohár wrote: > > > > On Tuesday 03 February 2015 16:43:45 Fel

Re: [PATCH 1/3] usb: gadget: function: phonet: balance usb_ep_disable calls

2015-02-03 Thread Pali Rohár
On Tuesday 03 February 2015 20:35:25 Felipe Balbi wrote: > On Tue, Feb 03, 2015 at 08:27:52PM +0100, Pali Rohár wrote: > > On Tuesday 03 February 2015 20:18:59 Felipe Balbi wrote: > > > On Tue, Feb 03, 2015 at 05:17:28PM +0100, Pali Rohár wrote: > > > > On Tuesday 03 February 2015 16:43:45 Felipe B

Re: [PATCH 1/3] usb: gadget: function: phonet: balance usb_ep_disable calls

2015-02-03 Thread Felipe Balbi
Hi, On Tue, Feb 03, 2015 at 08:57:11PM +0100, Pali Rohár wrote: > > > > > > > > f_phonet's ->set_alt() method will call > > > > > > > > usb_ep_disable() potentially on an endpoint which > > > > > > > > is already disabled. That's something the > > > > > > > > gadget/function driver must guarantee

Re: [PATCH 1/3] usb: gadget: function: phonet: balance usb_ep_disable calls

2015-02-03 Thread Pali Rohár
On Tuesday 03 February 2015 20:51:34 Felipe Balbi wrote: > On Tue, Feb 03, 2015 at 01:35:25PM -0600, Felipe Balbi wrote: > > On Tue, Feb 03, 2015 at 08:27:52PM +0100, Pali Rohár wrote: > > > On Tuesday 03 February 2015 20:18:59 Felipe Balbi wrote: > > > > On Tue, Feb 03, 2015 at 05:17:28PM +0100, P

Re: [PATCH v4] ehci-pci: disable for Intel MID platforms (update)

2015-02-03 Thread Sergei Shtylyov
Hello. On 02/03/2015 07:08 PM, Andy Shevchenko wrote: This is a follow up to the previously submitted commit cefa9a31a5f0 (ehci-pci: disable for Intel MID platforms). It includes the following changes: - table and function are renamed to reflect this is not only about ChipIdea - ChipIdea PCI

[PATCH v2] usb: phy: phy-generic: No need to call gpiod_direction_output() twice

2015-02-03 Thread Fabio Estevam
From: Fabio Estevam Commit 9eb0797722895f4309b4 ("usb: phy: generic: fix the gpios to be optional") calls gpiod_direction_output() in the probe function, so there is no need to call it again, as we can simply call gpiod_set_value() directly. Also, in usb_gen_phy_shutdown() we can simply put the

Re: [PATCH] usb: phy: phy-generic: No need to call gpiod_direction_output() twice

2015-02-03 Thread Fabio Estevam
Hi Felipe, On Sun, Feb 1, 2015 at 3:37 PM, Felipe Balbi wrote: > I like this, very much. Two comments though. We requested the gpio with > _optional(), and NULL is a valid gpio_desc, this if (nop->gpiod_reset) > is unnecessary. And also, since we don't have anymore the assert But if the reset-g

Re: [PATCH] usb: phy: phy-generic: No need to call gpiod_direction_output() twice

2015-02-03 Thread Felipe Balbi
On Tue, Feb 03, 2015 at 06:21:24PM -0200, Fabio Estevam wrote: > Hi Felipe, > > On Sun, Feb 1, 2015 at 3:37 PM, Felipe Balbi wrote: > > > I like this, very much. Two comments though. We requested the gpio with > > _optional(), and NULL is a valid gpio_desc, this if (nop->gpiod_reset) > > is unne

Re: [PATCH] usb: phy: phy-generic: No need to call gpiod_direction_output() twice

2015-02-03 Thread Fabio Estevam
On Tue, Feb 3, 2015 at 6:52 PM, Felipe Balbi wrote: > it doesn't make a difference though, right ? > gpiod_direction_output(NULL, 1) won't do anything. Yes, I will send a v3 without the NULL check. gpiod_set_value returns immediately if desc is NULL: void gpiod_set_value(struct gpio_desc *desc

[PATCH v3] usb: phy: phy-generic: No need to call gpiod_direction_output() twice

2015-02-03 Thread Fabio Estevam
From: Fabio Estevam Commit 9eb0797722895f4309b4 ("usb: phy: generic: fix the gpios to be optional") calls gpiod_direction_output() in the probe function, so there is no need to call it again, as we can simply call gpiod_set_value() directly. Also, in usb_gen_phy_shutdown() we can simply put the

Re: [PATCH v4] ehci-pci: disable for Intel MID platforms (update)

2015-02-03 Thread Greg Kroah-Hartman
On Tue, Feb 03, 2015 at 11:15:34PM +0300, Sergei Shtylyov wrote: > Hello. > > On 02/03/2015 07:08 PM, Andy Shevchenko wrote: > > >This is a follow up to the previously submitted commit cefa9a31a5f0 > >(ehci-pci: > >disable for Intel MID platforms). > > >It includes the following changes: > >- t

Re: NETDEV WATCHDOG: internal(r8152): transmit queue 0 timed out

2015-02-03 Thread poma
On 17.01.2015 09:56, poma wrote: > On 17.01.2015 00:57, sean darcy wrote: >> On 01/16/2015 07:09 AM, poma wrote: >>> On 16.01.2015 10:37, Hayes Wang wrote: poma [mailto:pomidorabelis...@gmail.com] > Sent: Friday, January 16, 2015 4:25 PM [...] >> This looks like a USB problem. I

Re: [PATCH v4] ehci-pci: disable for Intel MID platforms (update)

2015-02-03 Thread Peter Chen
On Tue, Feb 03, 2015 at 06:08:39PM +0200, Andy Shevchenko wrote: > This is a follow up to the previously submitted commit cefa9a31a5f0 (ehci-pci: > disable for Intel MID platforms). > > It includes the following changes: > - table and function are renamed to reflect this is not only about ChipIdea

Re: [PATCH v5 3/3] usb: udc: add usb_udc_activation_handler

2015-02-03 Thread Peter Chen
On Tue, Feb 03, 2015 at 12:04:08PM +0200, Alexander Shishkin wrote: > Peter Chen writes: > > > Currently, connect gadget is unconditional after binding, > > but some function drivers may want to connect gadget on the fly. > > With this API, the function driver can disconnect gadget during > > the

RE: [PATCH v5 0/3] usb: udc: Unify dp control

2015-02-03 Thread Peter Chen
> > > On Thu, Jan 29, 2015 at 12:27:23PM +0800, Peter Chen wrote: > >> Hi Felipe, > >> > > > > Hi Felipe, I see you tree is closed, but below three patches are not > > in your tree, will you queue them now or at next rc? I have some other > > patches based on them, so I would like to know your i

Re: intensive IO on usb-storage device causing system lock

2015-02-03 Thread Enrico Mioso
Hello to everybody reading this list, Hello alan. First of all - thank you for your help, attention and time in helping me troubleshoot this problem. I am 99% certain the device generating the problem is Bus 001 Device 010: ID 1e68:0022 TrekStor GmbH & Co. KG I don't think the problem is on the

[PATCH 1/2] usb: chipidea: add a flag for turn on vbus early for host

2015-02-03 Thread Peter Chen
From: Li Jun Some usb PHYs need power supply from vbus to make it work, eg mxs-phy, if there is no vbus, USB PHY will not in correct state when the controller starts to work, for host, this requires vbus should be turned on before setting port power(PP) of ehci, to work with this kind of USB PHY

[PATCH 2/2] usb: chipidea: host: turn on vbus before add hcd if early vbus on is required

2015-02-03 Thread Peter Chen
From: Li Jun If CI_HDRC_TURN_VBUS_EARLY_ON is set, turn on vbus before adding hcd, so it will not set reg_vbus of ehci_ci_priv, then vbus will not be handled by ehci core. Signed-off-by: Li Jun Signed-off-by: Peter Chen --- drivers/usb/chipidea/host.c | 27 ++- 1 file