Re: [PATCH 2/5] usb: xhci: plat: Create both HCDs before adding them

2015-04-20 Thread Roger Quadros
On 20/04/15 15:35, Mathias Nyman wrote: > Hi > > On 02.04.2015 15:23, Roger Quadros wrote: >> As xhci_hcd is now allocated by usb_create_hcd(), we don't >> need to add the primary HCD before creating the shared HCD. >> >> Creating the shared HCD before adding the primary HCD is particularly >> use

RE: [RFC][PATCH v2 00/13] USB: OTG/DRD Core functionality

2015-04-20 Thread Peter Chen
> > On 20/04/15 06:05, Peter Chen wrote: > > On Tue, Apr 14, 2015 at 01:41:47PM +0300, Roger Quadros wrote: > >> This is an attempt to centralize OTG/Dual-role functionality in the kernel. > >> As of now I've got Dual-role functionality working pretty reliably on > >> dra7-evm. xhci side of thin

Re: [PATCHv2 1/3] phy: core: Add devm_of_phy_get_by_index to phy-core

2015-04-20 Thread Kishon Vijay Abraham I
Hi, On Tuesday 21 April 2015 01:49 AM, Arun Ramamurthy wrote: On 15-04-15 02:59 AM, Kishon Vijay Abraham I wrote: Hi, On Tuesday 14 April 2015 03:40 AM, Arun Ramamurthy wrote: Some generic drivers, such as ehci, may use multiple phys and for such drivers referencing phy(s) by name(s) does n

Re: [PATCHv2 2/3] usb: ehci-platform: Use devm_of_phy_get_by_index

2015-04-20 Thread Kishon Vijay Abraham I
Arnd, On Wednesday 15 April 2015 03:17 AM, Arnd Bergmann wrote: On Tuesday 14 April 2015 11:05:35 Arun Ramamurthy wrote: [1] -> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/kbuild/kconfig-language.txt#n111 Kishon,removing select GENERIC_PHY also breaks t

Re: [PATCH v4 1/5] usb: introduce OTG 2.0 related kernel feature and API.

2015-04-20 Thread Li Jun
On Mon, Apr 20, 2015 at 01:47:33PM +0800, Macpaul Lin wrote: > Hi Peter, > > 2015-04-20 13:30 GMT+08:00 Peter Chen : > > On Thu, Apr 16, 2015 at 02:56:59PM +0800, Macpaul Lin wrote: > >> Introduce kernel feature CONFIG_USB_OTG20 and related > >> gadget_is_otg20() API for supporting OTG20 compliant

Re: [PATCH 1/1] drivers/usb/chipidea/debuc.c: avoid out of bound read

2015-04-20 Thread Peter Chen
On Fri, Apr 17, 2015 at 08:04:13AM +0200, Heinrich Schuchardt wrote: > A string written by the user may not be zero terminated. > > sscanf may read memory beyond the buffer if no zero byte > is found. > > Signed-off-by: Heinrich Schuchardt > --- > drivers/usb/chipidea/debug.c | 6 +- > 1 fi

Polling a usbfs file descriptor.

2015-04-20 Thread Dave Mielke
It seems (from inspecting libusb) that poll()ing a usbfs file descriptor for output can be used to determine when a urb can be reaped. A user has sent me a patch to our code that does this, and it actually does seem to work. So far, I haven't found any documentation on this. Is it okay for us t

Re: default value of power/wakeup

2015-04-20 Thread Tom Yan
On 21 April 2015 at 03:44, Alan Stern wrote: > The generic driver includes code for enabling wakeup by default, Is there a part of code which can shows this? It seems to me that the usbhid module is loaded for all USB HID devices, so I doubt a bit: [tom@localhost ~]$ journalctl -b -1 | grep hid

Re: xhci irq event bogus return value ffffff94

2015-04-20 Thread Sergei Shtylyov
Hello. On 04/20/2015 11:04 PM, Joe Lawrence wrote: So -ESHUTDOWN = -108 (0xff94) provoked bad_action_ret into reporting a bogus return value and stack trace above. As far as I know, -Eanything is never a valid return code for an IRQ handler. Shouldn't this always return either IRQ_NONE

Re: xhci irq event bogus return value ffffff94

2015-04-20 Thread Alan Stern
On Mon, 20 Apr 2015, Joe Lawrence wrote: > On Mon, Apr 20, 2015 at 01:35:40PM -0400, Alan Stern wrote: > > On Mon, 20 Apr 2015, Joe Lawrence wrote: > > > > > So -ESHUTDOWN = -108 (0xff94) provoked bad_action_ret into reporting > > > a bogus return value and stack trace above. > > > > As far

Re: [PATCHv2 1/3] phy: core: Add devm_of_phy_get_by_index to phy-core

2015-04-20 Thread Arun Ramamurthy
On 15-04-15 02:59 AM, Kishon Vijay Abraham I wrote: Hi, On Tuesday 14 April 2015 03:40 AM, Arun Ramamurthy wrote: Some generic drivers, such as ehci, may use multiple phys and for such drivers referencing phy(s) by name(s) does not make sense. Instead of inventing new naming schemes and using

[PATCH v2] Documentation usb serial: fixed how to provide vendor and product id

2015-04-20 Thread Marek Belisko
From: "H. Nikolaus Schaller" While trying to test a Cinterion GSM/GPS/3G module I had reconfigured the USB interface by mistake and therefore needed to run a different USB driver than CDC-ACM. It turned out that I need the "usbserial" driver. This file is an official description how to use it:

Re: xhci irq event bogus return value ffffff94

2015-04-20 Thread Joe Lawrence
On Mon, Apr 20, 2015 at 01:35:40PM -0400, Alan Stern wrote: > On Mon, 20 Apr 2015, Joe Lawrence wrote: > > > So -ESHUTDOWN = -108 (0xff94) provoked bad_action_ret into reporting > > a bogus return value and stack trace above. > > As far as I know, -Eanything is never a valid return code for a

Re: default value of power/wakeup

2015-04-20 Thread Alan Stern
On Tue, 21 Apr 2015, Tom Yan wrote: > Yes of course: Okay, the two devices appear to be the same as far as remote wakeup is concerned. The difference lies in the drivers. From your original report: > logitech-djreceiver 0003:046D:C52B.0003: hiddev0,hidraw0: USB HID > v1.11 Device [Logitech USB

Re: default value of power/wakeup

2015-04-20 Thread Tom Yan
Yes of course: Bus 003 Device 002: ID 046d:c52b Logitech, Inc. Unifying Receiver Device Descriptor: bLength18 bDescriptorType 1 bcdUSB 2.00 bDeviceClass0 bDeviceSubClass 0 bDeviceProtocol 0 bMaxPacketSize0 8

Re: default value of power/wakeup

2015-04-20 Thread Alan Stern
On Tue, 21 Apr 2015, Tom Yan wrote: > Thank you very much for your reply. > > So I tried to see if there's any difference between the two devices. I > can see that the one didn't get enabled by default has an extra > interface with 0 for the two attributes. But does that matter? Because > if it d

Re: default value of power/wakeup

2015-04-20 Thread Tom Yan
Thank you very much for your reply. So I tried to see if there's any difference between the two devices. I can see that the one didn't get enabled by default has an extra interface with 0 for the two attributes. But does that matter? Because if it does, shouldn't the mouse interface prevents the o

Re: default value of power/wakeup

2015-04-20 Thread Alan Stern
On Tue, 21 Apr 2015, Tom Yan wrote: > I have the following two USB wireless mouse/keyboard receivers: > > logitech-djreceiver 0003:046D:C52B.0003: hiddev0,hidraw0: USB HID > v1.11 Device [Logitech USB Receiver] on usb-:00:14.0-13/input2 > hid-generic 0003:046D:C52E.0005: input,hidraw2: USB HI

RE: [PATCH 2/9][v2]usb:fsl:otg: Add support to add/remove usb host driver

2015-04-20 Thread Alan Stern
On Mon, 20 Apr 2015, Ramneek Mehresh wrote: > > > This is the wrong way to connect platform-private data with the > > > ehci_hcd structure. The right way is to use an ehci_driver_overrides > > > structure, like in ehci-omap.c and quite a few other EHCI platform > > > drivers. > > > > > > Hi Alan

Re: [PATCH] usb: ehci-msm: Don't ioremap configuration space exclusively

2015-04-20 Thread Alan Stern
On Mon, 20 Apr 2015, Ivan T. Ivanov wrote: > > On Mon, 2015-04-20 at 10:14 -0400, Alan Stern wrote: > > On Mon, 20 Apr 2015, Ivan T. Ivanov wrote: > > > > > Hi Alan, > > > > > > Perhaps I have to resend this patch with updated commit > > > message? Are they any other obstacles? > > > > Instead

Re: xhci irq event bogus return value ffffff94

2015-04-20 Thread Alan Stern
On Mon, 20 Apr 2015, Joe Lawrence wrote: > Hi all, > > I noticed a xhci warning on Stratus fault-tolerant box running automated > surprise device removal tests over the weekend: > > irq event 95: bogus return value ff94 > CPU: 0 PID: 31710 Comm: kworker/u97:2 Tainted: PF O-

default value of power/wakeup

2015-04-20 Thread Tom Yan
I have the following two USB wireless mouse/keyboard receivers: logitech-djreceiver 0003:046D:C52B.0003: hiddev0,hidraw0: USB HID v1.11 Device [Logitech USB Receiver] on usb-:00:14.0-13/input2 hid-generic 0003:046D:C52E.0005: input,hidraw2: USB HID v1.11 Keyboard [Logitech USB Receiver] on usb

RE: [PATCH 2/9][v2]usb:fsl:otg: Add support to add/remove usb host driver

2015-04-20 Thread Ramneek Mehresh
> -Original Message- > From: Mehresh Ramneek-B31383 > Sent: Monday, April 20, 2015 10:05 PM > To: 'Alan Stern' > Cc: linux-ker...@vger.kernel.org; linux-usb@vger.kernel.org; ba...@ti.com; > gre...@linuxfoundation.org > Subject: RE: [PATCH 2/9][v2]usb:fsl:otg: Add support to add/remove usb

RE: [PATCH 2/9][v2]usb:fsl:otg: Add support to add/remove usb host driver

2015-04-20 Thread Ramneek Mehresh
> -Original Message- > From: Alan Stern [mailto:st...@rowland.harvard.edu] > Sent: Tuesday, April 07, 2015 9:23 PM > To: Mehresh Ramneek-B31383 > Cc: linux-ker...@vger.kernel.org; linux-usb@vger.kernel.org; ba...@ti.com; > gre...@linuxfoundation.org > Subject: Re: [PATCH 2/9][v2]usb:fsl:o

Re: [PATCH] usb: ehci-msm: Don't ioremap configuration space exclusively

2015-04-20 Thread Ivan T. Ivanov
On Mon, 2015-04-20 at 10:14 -0400, Alan Stern wrote: > On Mon, 20 Apr 2015, Ivan T. Ivanov wrote: > > > Hi Alan, > > > > Perhaps I have to resend this patch with updated commit > > message? Are they any other obstacles? > > Instead of submitting this new patch, would it be okay to revert commit

xhci irq event bogus return value ffffff94

2015-04-20 Thread Joe Lawrence
Hi all, I noticed a xhci warning on Stratus fault-tolerant box running automated surprise device removal tests over the weekend: irq event 95: bogus return value ff94 CPU: 0 PID: 31710 Comm: kworker/u97:2 Tainted: PF O-- 3.10.0-229.el7.x86_64 #1 Hardware name: Stratus

Re: Mouse works with eHCI, fails with xHCI - can't set config #1, error -110

2015-04-20 Thread Alistair Grant
On Tue, Apr 14, 2015 at 10:52:21AM -0400, Alan Stern wrote: > On Tue, 14 Apr 2015, Alistair Grant wrote: > > > Hi Mathias and Alan, > > > > As Mathias requested, I've included the usbmon output with the patch > > applied. > > > > It didn't make any difference to the end result, the mouse still f

Re: [PATCH v2] cdc-acm: prevent infinite loop when parsing CDC headers.

2015-04-20 Thread Greg Kroah-Hartman
On Mon, Apr 20, 2015 at 01:54:56PM +0200, Quentin Casasnovas wrote: > On Tue, Apr 14, 2015 at 11:25:43AM +0200, Quentin Casasnovas wrote: > > Phil and I found out a problem with commit: > > > > 7e860a6e7aa6 ("cdc-acm: add sanity checks") > > > > Any comment on v2? I can't do anything with any

Re: [PATCH] usb: ehci-msm: Don't ioremap configuration space exclusively

2015-04-20 Thread Alan Stern
On Mon, 20 Apr 2015, Ivan T. Ivanov wrote: > Hi Alan, > > Perhaps I have to resend this patch with updated commit > message? Are they any other obstacles? Instead of submitting this new patch, would it be okay to revert commit 70843f623b58? That would be simpler. Also, I'd like to get an Ac

Re: [PATCH v4 0/8] add HNP polling support for usb otg fsm

2015-04-20 Thread Li Jun
On Thu, Mar 26, 2015 at 05:38:11PM +0800, Peter Chen wrote: > On Wed, Mar 25, 2015 at 07:25:24PM +0800, Li Jun wrote: > > On Wed, Mar 25, 2015 at 02:43:43PM +0800, Chen Peter-B29397 wrote: > > > > > > > On Wed, Mar 25, 2015 at 02:03:51PM +0800, Peter Chen wrote: > > > > > > > > > > Hi Jun, > > >

Re: [RFC][PATCH v2 06/13] usb: hcd: Add hcd add/remove functions for OTG use

2015-04-20 Thread Alan Stern
On Mon, 20 Apr 2015, Roger Quadros wrote: > > I don't understand this. Why do you want to defer the add/remove if > > the device is OTG? Don't host controller drivers expect these things > > to execute synchronously? > > Sorry for the wrong information. We actually defer only the add as the >

Re: Error: DMA: Out of SW-IOMMU space [was: External USB drives become unresponsive after few hours.]

2015-04-20 Thread Konrad Rzeszutek Wilk
On Sun, Apr 19, 2015 at 05:43:18PM +0200, Dorian Gray wrote: > I think the case is closed. > Now that I know it's not USB, but wireless driver, I looked through > the new k3.19.5's changelog and saw this: > > > commit b943e69d33fac1e5f6db57868e061096b0aae67a > Author: Larry Finger > Date: Sat

Re: [PATCH 2/5] usb: xhci: plat: Create both HCDs before adding them

2015-04-20 Thread Mathias Nyman
Hi On 02.04.2015 15:23, Roger Quadros wrote: > As xhci_hcd is now allocated by usb_create_hcd(), we don't > need to add the primary HCD before creating the shared HCD. > > Creating the shared HCD before adding the primary HCD is particularly > useful for the OTG use case so that we know at the OT

Re: [PATCH v2] cdc-acm: prevent infinite loop when parsing CDC headers.

2015-04-20 Thread Quentin Casasnovas
On Tue, Apr 14, 2015 at 11:25:43AM +0200, Quentin Casasnovas wrote: > Phil and I found out a problem with commit: > > 7e860a6e7aa6 ("cdc-acm: add sanity checks") > Any comment on v2? Thanks, Quentin -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a messa

Re: [PATCH] usb: ehci-msm: Don't ioremap configuration space exclusively

2015-04-20 Thread Ivan T. Ivanov
On Thu, 2015-04-16 at 10:42 +0300, Ivan T. Ivanov wrote: > Hi, > > On Wed, 2015-04-15 at 21:28 +0530, Vivek Gautam wrote: > > On Thu, Apr 9, 2015 at 8:19 PM, Alan Stern > > wrote: > > > On Thu, 9 Apr 2015, Ivan T. Ivanov wrote: > > > > > > > This allow same IO space to be shared between HCD an

Re: [RFC][PATCH v2 00/13] USB: OTG/DRD Core functionality

2015-04-20 Thread Roger Quadros
Hi Peter, On 20/04/15 06:05, Peter Chen wrote: > On Tue, Apr 14, 2015 at 01:41:47PM +0300, Roger Quadros wrote: >> This is an attempt to centralize OTG/Dual-role functionality in the kernel. >> As of now I've got Dual-role functionality working pretty reliably on >> dra7-evm. xhci side of things f

Re: [PATCH v4 1/5] usb: introduce OTG 2.0 related kernel feature and API.

2015-04-20 Thread Roger Quadros
Hi, On 16/04/15 09:56, Macpaul Lin wrote: > Introduce kernel feature CONFIG_USB_OTG20 and related > gadget_is_otg20() API for supporting OTG20 compliant > drivers. > This patch also updated usb_otg_descritpor. > > Signed-off-by: Macpaul Lin > --- > changes for v2: > - Add USB_OTG_ADP definitio

Re: [RFC][PATCH v2 06/13] usb: hcd: Add hcd add/remove functions for OTG use

2015-04-20 Thread Roger Quadros
On 17/04/15 17:03, Alan Stern wrote: > On Fri, 17 Apr 2015, Roger Quadros wrote: > >> On 17/04/15 05:18, Peter Chen wrote: >>> On Tue, Apr 14, 2015 at 01:41:53PM +0300, Roger Quadros wrote: The existing usb_add/remove_hcd() functionality remains unchanged for non-OTG devices. For OTG >>>