Re: [PATCH] usb: gadget: composite: enable BESL support

2015-04-28 Thread Felipe Balbi
On Wed, Apr 29, 2015 at 03:04:51AM +, Du, Changbin wrote: > > > From: Felipe Balbi > > > Date: Tue, 30 Sep 2014 16:08:03 -0500 > > > Subject: [PATCH] usb: gadget: composite: enable BESL support > > > > missing upstream commit. > > > > > According to USB 2.0 ECN Errata for Link Power Manageme

Re: [PATCH v2] usb: gadget: composite: enable BESL support

2015-04-28 Thread Felipe Balbi
Hi, On Wed, Apr 29, 2015 at 03:40:28AM +, Du, Changbin wrote: > From a6615937bcd9234e6d6bb817c3701fce44d0a84d Mon Sep 17 00:00:00 2001 > From: Felipe Balbi > Date: Tue, 30 Sep 2014 16:08:03 -0500 > Subject: [PATCH] usb: gadget: composite: enable BESL support > > According to USB 2.0 ECN Erra

[PATCH v2] usb: gadget: composite: enable BESL support

2015-04-28 Thread Du, Changbin
>From a6615937bcd9234e6d6bb817c3701fce44d0a84d Mon Sep 17 00:00:00 2001 From: Felipe Balbi Date: Tue, 30 Sep 2014 16:08:03 -0500 Subject: [PATCH] usb: gadget: composite: enable BESL support According to USB 2.0 ECN Errata for Link Power Management (USB2-LPM-Errata-final.pdf), BESL must be enabled

RE: [PATCH] usb: gadget: composite: enable BESL support

2015-04-28 Thread Du, Changbin
> > From: Felipe Balbi > > Date: Tue, 30 Sep 2014 16:08:03 -0500 > > Subject: [PATCH] usb: gadget: composite: enable BESL support > > missing upstream commit. > > > According to USB 2.0 ECN Errata for Link Power Management > > (USB2-LPM-Errata-final.pdf), BESL must be enabled if LPM is enabled.

Re: [PATCH v4 14/22] usb: dwc2: host: register handle to the phy

2015-04-28 Thread Felipe Balbi
Hi, On Tue, Apr 28, 2015 at 09:09:40PM +, Kaukab, Yousaf wrote: > > -Original Message- > > From: Felipe Balbi [mailto:ba...@ti.com] > > Sent: Tuesday, April 28, 2015 10:49 PM > > To: Kaukab, Yousaf > > Cc: ba...@ti.com; linux-usb@vger.kernel.org; john.y...@synopsys.com; > > Herrero, Gr

Re: [PATCH] usb: gadget: xilinx: fix devm_ioremap_resource() check

2015-04-28 Thread Felipe Balbi
On Wed, Apr 29, 2015 at 02:59:14AM +0300, Vladimir Zapolskiy wrote: > On 30.03.2015 05:38, Sören Brinkmann wrote: > > On Sun, 2015-03-29 at 05:43AM +0300, Vladimir Zapolskiy wrote: > >> devm_ioremap_resource() returns IOMEM_ERR_PTR() and it never > >> returns NULL, fix the check to prevent access t

Re: [PATCH] usb: gadget: xilinx: fix devm_ioremap_resource() check

2015-04-28 Thread Vladimir Zapolskiy
On 30.03.2015 05:38, Sören Brinkmann wrote: > On Sun, 2015-03-29 at 05:43AM +0300, Vladimir Zapolskiy wrote: >> devm_ioremap_resource() returns IOMEM_ERR_PTR() and it never >> returns NULL, fix the check to prevent access to invalid >> virtual address. >> >> Signed-off-by: Vladimir Zapolskiy > Rev

Re: [PATCH] usb: dwc2: gadget: cleanup useless code

2015-04-28 Thread John Youn
On 4/28/2015 3:50 PM, John Youn wrote: > On 4/26/2015 12:36 AM, Yunzhi Li wrote: >> dwc2 gadget driver s3c_hsotg_of_probe() run twice in >> dwc2_gadget_init() and the first one is useless, so remove it. >> >> Signed-off-by: Yunzhi Li >> --- >> drivers/usb/dwc2/gadget.c | 2 -- >> 1 file changed,

Re: [PATCH] usb: dwc2: gadget: cleanup useless code

2015-04-28 Thread John Youn
On 4/26/2015 12:36 AM, Yunzhi Li wrote: > dwc2 gadget driver s3c_hsotg_of_probe() run twice in > dwc2_gadget_init() and the first one is useless, so remove it. > > Signed-off-by: Yunzhi Li > --- > drivers/usb/dwc2/gadget.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/usb/dw

Re: [PATCH] usb: core: add usb3 lpm sysfs

2015-04-28 Thread Greg KH
On Wed, Apr 29, 2015 at 12:51:27AM +0800, Zhuang Jin Can wrote: > Hi Greg KH, > > On Tue, Apr 28, 2015 at 12:42:24PM +0200, Greg KH wrote: > > On Sun, Apr 19, 2015 at 11:46:12AM +0800, Zhuang Jin Can wrote: > > > Some usb3 devices may not support usb3 lpm well. > > > The patch adds a sysfs to enab

RE: [PATCH v4 14/22] usb: dwc2: host: register handle to the phy

2015-04-28 Thread Kaukab, Yousaf
> -Original Message- > From: Felipe Balbi [mailto:ba...@ti.com] > Sent: Tuesday, April 28, 2015 10:49 PM > To: Kaukab, Yousaf > Cc: ba...@ti.com; linux-usb@vger.kernel.org; john.y...@synopsys.com; > Herrero, Gregory; r.bald...@samsung.com; > dingu...@opensource.altera.com; zhangfei@lina

Re: [PATCH v4 14/22] usb: dwc2: host: register handle to the phy

2015-04-28 Thread Felipe Balbi
On Tue, Apr 28, 2015 at 08:47:08PM +, Kaukab, Yousaf wrote: > > -Original Message- > > From: Felipe Balbi [mailto:ba...@ti.com] > > Sent: Monday, April 27, 2015 10:43 PM > > To: Kaukab, Yousaf > > Cc: linux-usb@vger.kernel.org; ba...@ti.com; john.y...@synopsys.com; > > Herrero, Gregory;

RE: [PATCH v4 14/22] usb: dwc2: host: register handle to the phy

2015-04-28 Thread Kaukab, Yousaf
> -Original Message- > From: Felipe Balbi [mailto:ba...@ti.com] > Sent: Monday, April 27, 2015 10:43 PM > To: Kaukab, Yousaf > Cc: linux-usb@vger.kernel.org; ba...@ti.com; john.y...@synopsys.com; > Herrero, Gregory; r.bald...@samsung.com; > dingu...@opensource.altera.com; zhangfei@linar

Computer Reboots Instead of Shutting Down

2015-04-28 Thread Brian Monroe
I filed a bug with kernel.org: https://bugzilla.kernel.org/show_bug.cgi?id=97391 and Greg Kroah-Hartman requested that I email this list to advise you of the issue as well. There's also a bug that's been filed with Fedora https://bugzilla.redhat.com/show_bug.cgi?id=1168557 for this issue, and ther

Re: [PATCH 3/3] Usb: core: buffer: fixed the checkpatch warning

2015-04-28 Thread Greg KH
On Tue, Apr 28, 2015 at 05:17:11PM +0530, Nizam Haider wrote: > Fixed two warnings sizeof name and Blank line after declaration > > Signed-off-by: Nizam Haider > --- > drivers/usb/core/buffer.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Where are patches 1/3 and 2/3? Please rese

[PATCH v2] usb: gadget: ether: Fix MAC address parsing

2015-04-28 Thread Stefan Agner
MAC addresses can be written without leading zeros. A popular example is libc's ether_ntoa_r function which creates such MAC addresses. Example: 00:14:3d:0f:ff:fe can be written as 0:14:3d:f:ff:fe The function get_ether_addr potentially also parsed past the end of the user provided string. Use th

Re: [PATCH] usb: gadget: ether: Fix MAC address parsing

2015-04-28 Thread Felipe Balbi
On Tue, Apr 28, 2015 at 07:28:21PM +0200, Stefan Agner wrote: > On 2015-04-28 18:31, Felipe Balbi wrote: > > On Tue, Apr 28, 2015 at 06:15:51PM +0200, Krzysztof Opasiak wrote: > >> On 04/28/2015 05:59 PM, Stefan Agner wrote: > >> >On 2015-04-28 17:00, Krzysztof Opasiak wrote: > >> >>Hi Stefan, > >>

[PATCH 1/1 v2] drivers/usb/chipidea/debuc.c: avoid out of bound read

2015-04-28 Thread Heinrich Schuchardt
A string written by the user may not be zero terminated. sscanf may read memory beyond the buffer if no zero byte is found. For testing build with CONFIG_USB_CHIPIDEA=y, CONFIG_USB_CHIPIDEA_DEBUG=y. Version 2: Use '\0' for char constant. Signed-off-by: Heinrich Schuchardt --- drivers/usb/ch

Re: [PATCH] usb: gadget: ether: Fix MAC address parsing

2015-04-28 Thread Stefan Agner
On 2015-04-28 18:31, Felipe Balbi wrote: > On Tue, Apr 28, 2015 at 06:15:51PM +0200, Krzysztof Opasiak wrote: >> On 04/28/2015 05:59 PM, Stefan Agner wrote: >> >On 2015-04-28 17:00, Krzysztof Opasiak wrote: >> >>Hi Stefan, >> >> >> >>On 04/28/2015 01:51 PM, Stefan Agner wrote: >> >>>MAC addresses c

Re: [PATCHv3 06/11] usb: dwc3: soft reset to it's own function

2015-04-28 Thread Felipe Balbi
On Tue, Apr 28, 2015 at 04:24:41PM +0300, Heikki Krogerus wrote: > So it can be called from other places later. > > Signed-off-by: Heikki Krogerus > Acked-by: David Cohen > --- > drivers/usb/dwc3/core.c | 46 ++ > 1 file changed, 30 insertions(+), 16

Re: [PATCHv3 00/12] usb: ulpi bus

2015-04-28 Thread Felipe Balbi
Hi, On Tue, Apr 28, 2015 at 04:24:35PM +0300, Heikki Krogerus wrote: > Hi, > > I took the liberty of adding David's ACK to everything except 9/12, including > to > the 1/12 (removing the module handling has no functional affect). > > Changes since v2: > - remove module handling from the bus dri

[PATCH 3/3] Usb: core: buffer: fixed the checkpatch warning

2015-04-28 Thread Nizam Haider
Fixed two warnings sizeof name and Blank line after declaration Signed-off-by: Nizam Haider --- drivers/usb/core/buffer.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/core/buffer.c b/drivers/usb/core/buffer.c index 684ef70..04125b6 100644 --- a/drivers/usb/co

Re: [PATCHv3 08/11] usb: dwc3: add hsphy_interface property

2015-04-28 Thread Felipe Balbi
On Tue, Apr 28, 2015 at 04:24:43PM +0300, Heikki Krogerus wrote: > Platforms that have configured DWC_USB3_HSPHY_INTERFACE with > value 3, i.e. UTMI+ and ULPI, need to inform the driver of > the actual HSPHY interface type with the property. "utmi" if > the interface is UTMI+ or "ulpi" if the inter

Re: [PATCH] usb: phy: Remove the phy-rcar-gen2-usb driver

2015-04-28 Thread Felipe Balbi
On Tue, Apr 28, 2015 at 06:55:37PM +0200, Geert Uytterhoeven wrote: > Hi Felipe, > > On Tue, Apr 28, 2015 at 6:50 PM, Felipe Balbi wrote: > > On Tue, Apr 28, 2015 at 02:04:07PM +0200, Geert Uytterhoeven wrote: > >> The phy-rcar-gen2-usb driver, which supports legacy platform data only, > >> is no

Re: [PATCH v4 8/8] Documentation: usb: chipidea: Update test procedure for HNP polling

2015-04-28 Thread Felipe Balbi
On Thu, Mar 19, 2015 at 11:11:25AM +0800, Li Jun wrote: > From: Li Jun > > Update HNP test procedure as HNP polling is supported. > > Signed-off-by: Li Jun > --- > Documentation/usb/chipidea.txt | 11 ++- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/Documentati

Re: [PATCH] usb: phy: Remove the phy-rcar-gen2-usb driver

2015-04-28 Thread Geert Uytterhoeven
Hi Felipe, On Tue, Apr 28, 2015 at 6:50 PM, Felipe Balbi wrote: > On Tue, Apr 28, 2015 at 02:04:07PM +0200, Geert Uytterhoeven wrote: >> The phy-rcar-gen2-usb driver, which supports legacy platform data only, >> is no longer used since commit a483dcbfa21f919c ("ARM: shmobile: lager: >> Remove leg

Re: [PATCH v3 1/4] fs: configfs: Add unlocked version of configfs_depend_item()

2015-04-28 Thread Felipe Balbi
Hi, On Thu, Apr 09, 2015 at 06:18:07PM +0200, Krzysztof Opasiak wrote: > Sometimes it might be desirable to prohibit removing a directory > in configfs. One example is USB gadget (mass_storage function): > when gadget is already bound, if lun directory is removed, > the gadget must be thrown away,

Re: [PATCH] usb: core: add usb3 lpm sysfs

2015-04-28 Thread Zhuang Jin Can
Hi Greg KH, On Tue, Apr 28, 2015 at 12:42:24PM +0200, Greg KH wrote: > On Sun, Apr 19, 2015 at 11:46:12AM +0800, Zhuang Jin Can wrote: > > Some usb3 devices may not support usb3 lpm well. > > The patch adds a sysfs to enable/disable u1 or u2 of the port.The > > settings apply to both before and af

Re: [PATCH] usb: phy: Remove the phy-rcar-gen2-usb driver

2015-04-28 Thread Felipe Balbi
On Tue, Apr 28, 2015 at 02:04:07PM +0200, Geert Uytterhoeven wrote: > The phy-rcar-gen2-usb driver, which supports legacy platform data only, > is no longer used since commit a483dcbfa21f919c ("ARM: shmobile: lager: > Remove legacy board support"). > > This driver was superseded by the DT-only phy

Re: [PATCH V7 2/9] mailbox: Make struct mbox_controller's ops field const

2015-04-28 Thread Suman Anna
Hi Andrew, On 04/27/2015 05:37 PM, Andrew Bresticker wrote: > The mailbox controller's channel ops ought to be read-only. We ought to change this on all the existing controllers as well. regards Suman > > Signed-off-by: Andrew Bresticker > Cc: Jassi Brar > --- > No changes from v5/v6. > New

Re: [PATCH V7 3/9] mailbox: Fix up error handling in mbox_request_channel()

2015-04-28 Thread Suman Anna
On 04/27/2015 05:37 PM, Andrew Bresticker wrote: > From: Benson Leung > > mbox_request_channel() currently returns EBUSY in the event the controller > is not present or if of_xlate() fails, but in neither case is EBUSY really > appropriate. Return EPROBE_DEFER if the controller is not yet presen

Re: [PATCH 1/2] usb: gadget: add usb_gadget_activate/deactivate functions

2015-04-28 Thread Felipe Balbi
On Tue, Apr 07, 2015 at 10:31:52AM +0200, Robert Baldyga wrote: > These functions allows to deactivate gadget to make it not visible to > host and make it active again when gadget driver is finally ready. > > They are needed to fix usb_function_activate() and usb_function_deactivate() > functions

Re: [RFC 5/6] usb: gadget: atmel_usba: use atmel_io.h to provide on-chip IO

2015-04-28 Thread Felipe Balbi
On Tue, Apr 28, 2015 at 05:34:09PM +0100, Ben Dooks wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > On 28/04/15 17:30, Felipe Balbi wrote: > > Hi, > > > > On Tue, Apr 28, 2015 at 04:40:14PM +0100, Ben Dooks wrote: > > /* Register access macros */ -#ifdef CONFIG_AVR32 -#define

Re: [RFC 5/6] usb: gadget: atmel_usba: use atmel_io.h to provide on-chip IO

2015-04-28 Thread Ben Dooks
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 28/04/15 17:30, Felipe Balbi wrote: > Hi, > > On Tue, Apr 28, 2015 at 04:40:14PM +0100, Ben Dooks wrote: > /* Register access macros */ -#ifdef CONFIG_AVR32 -#define > usba_io_readl __raw_readl -#define usba_io_writel > __raw_wri

Re: [RFC 5/6] usb: gadget: atmel_usba: use atmel_io.h to provide on-chip IO

2015-04-28 Thread Felipe Balbi
Hi, On Tue, Apr 28, 2015 at 04:40:14PM +0100, Ben Dooks wrote: > >>> /* Register access macros */ -#ifdef CONFIG_AVR32 -#define > >>> usba_io_readl __raw_readl -#define usba_io_writel __raw_writel > >>> -#define usba_io_writew __raw_writew -#else -#define > >>> usba_io_readl readl_r

Re: [PATCH] usb: gadget: ether: Fix MAC address parsing

2015-04-28 Thread Felipe Balbi
On Tue, Apr 28, 2015 at 06:15:51PM +0200, Krzysztof Opasiak wrote: > > > On 04/28/2015 05:59 PM, Stefan Agner wrote: > >On 2015-04-28 17:00, Krzysztof Opasiak wrote: > >>Hi Stefan, > >> > >>On 04/28/2015 01:51 PM, Stefan Agner wrote: > >>>MAC addresses can be written without leading zeros. A popu

Re: [PATCH v2] phy: fix Kconfig dependencies

2015-04-28 Thread Felipe Balbi
On Tue, Apr 28, 2015 at 09:20:22AM -0700, Tony Lindgren wrote: > * Felipe Balbi [150428 09:16]: > > DM816x PHY uses usb_phy_* methods and because > > of that, it must select USB_PHY, however, because > > the drivers in question (DM816x, TWL4030 and > > OMAP_USB2) sit outside of drivers/usb/ direct

Re: [RFC 5/6] usb: gadget: atmel_usba: use atmel_io.h to provide on-chip IO

2015-04-28 Thread Nicolas Ferre
Le 28/04/2015 17:40, Ben Dooks a écrit : > /* Register access macros */ -#ifdef CONFIG_AVR32 -#define usba_io_readl __raw_readl -#define usba_io_writel __raw_writel -#define usba_io_writew__raw_writew -#else -#define usba_io_readl readl_relaxed -#define

Re: [PATCH v2] phy: fix Kconfig dependencies

2015-04-28 Thread Tony Lindgren
* Felipe Balbi [150428 09:16]: > DM816x PHY uses usb_phy_* methods and because > of that, it must select USB_PHY, however, because > the drivers in question (DM816x, TWL4030 and > OMAP_USB2) sit outside of drivers/usb/ directory, > meaning they can be built even if USB_SUPPORT=n. > > This patches

Re: [PATCH] usb: gadget: ether: Fix MAC address parsing

2015-04-28 Thread Krzysztof Opasiak
On 04/28/2015 05:59 PM, Stefan Agner wrote: On 2015-04-28 17:00, Krzysztof Opasiak wrote: Hi Stefan, On 04/28/2015 01:51 PM, Stefan Agner wrote: MAC addresses can be written without leading zeros. A popular example is libc's ether_ntoa_r function which creates such MAC addresses. Example: 0

[PATCH v2] phy: fix Kconfig dependencies

2015-04-28 Thread Felipe Balbi
DM816x PHY uses usb_phy_* methods and because of that, it must select USB_PHY, however, because the drivers in question (DM816x, TWL4030 and OMAP_USB2) sit outside of drivers/usb/ directory, meaning they can be built even if USB_SUPPORT=n. This patches fixes the dependencies by adding USB_SUPPORT

Re: [PATCH] phy: fix Kconfig dependencies

2015-04-28 Thread Felipe Balbi
On Tue, Apr 28, 2015 at 11:09:30AM -0500, Felipe Balbi wrote: > DM816x PHY uses usb_phy_* methods and because > of that, it must select USB_PHY, however, because > the drivers in question (DM816x and OMAP_USB2) sit > outside of drivers/usb/ directory, they can compile > even if USB_SUPPORT=n. > >

Re: [BUG] xhci_hcd: intermittent bug with VL812 hub: Bad Slot ID 2 Could not allocate xHCI USB device data structures

2015-04-28 Thread Johan Hovold
On Mon, Apr 27, 2015 at 02:17:45PM +0300, Mathias Nyman wrote: > On 27.04.2015 12:30, Johan Hovold wrote: > > On Sat, Apr 25, 2015 at 10:39:23PM +0100, Chris Bainbridge wrote: > >> Kernel: v4.0-10710-g27cf3a1 > >> > >> Hardware: > >> > >> IvyBridge Macbook (Panther Point PCH), 2 external USB3 ports

[PATCH] phy: fix Kconfig dependencies

2015-04-28 Thread Felipe Balbi
DM816x PHY uses usb_phy_* methods and because of that, it must select USB_PHY, however, because the drivers in question (DM816x and OMAP_USB2) sit outside of drivers/usb/ directory, they can compile even if USB_SUPPORT=n. This patches fixes the dependencies by adding USB_SUPPORT as a dependency an

Re: [PATCH] usb: gadget: ether: Fix MAC address parsing

2015-04-28 Thread Stefan Agner
On 2015-04-28 17:00, Krzysztof Opasiak wrote: > Hi Stefan, > > On 04/28/2015 01:51 PM, Stefan Agner wrote: >> MAC addresses can be written without leading zeros. A popular >> example is libc's ether_ntoa_r function which creates such >> MAC addresses. >> >> Example: >> 00:14:3d:0f:ff:fe can be wri

Re: [PATCH] usb: gadget: composite: enable BESL support

2015-04-28 Thread Felipe Balbi
On Tue, Apr 28, 2015 at 07:56:13AM +, Du, Changbin wrote: > From a6615937bcd9234e6d6bb817c3701fce44d0a84d Mon Sep 17 00:00:00 2001 > From: Felipe Balbi > Date: Tue, 30 Sep 2014 16:08:03 -0500 > Subject: [PATCH] usb: gadget: composite: enable BESL support missing upstream commit. > According

Re: [RFC 5/6] usb: gadget: atmel_usba: use atmel_io.h to provide on-chip IO

2015-04-28 Thread Ben Dooks
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 >>> >>> /* Register access macros */ -#ifdef CONFIG_AVR32 -#define >>> usba_io_readl __raw_readl -#define usba_io_writel __raw_writel >>> -#define usba_io_writew __raw_writew -#else -#define >>> usba_io_readl readl_relaxed -#de

Re: [PATCH v3 00/11] usbip: features to USB over WebSocket

2015-04-28 Thread Krzysztof Opasiak
Hi, On 04/28/2015 11:35 AM, fx IWATA NOBUO wrote: Hello, As far as I understand your design you have kernel stub driver which is sending and receiving data via socket fd received from userspace. Now after this series you are exporting all messages to userspace where daemon is sending them us

Re: [PATCH] usb: gadget: ether: Fix MAC address parsing

2015-04-28 Thread Krzysztof Opasiak
Hi Stefan, On 04/28/2015 01:51 PM, Stefan Agner wrote: MAC addresses can be written without leading zeros. A popular example is libc's ether_ntoa_r function which creates such MAC addresses. Example: 00:14:3d:0f:ff:fe can be written as 0:14:3d:f:ff:fe Additionally, get_ether_addr potentially p

[PATCHv3 01/11] usb: add bus type for USB ULPI

2015-04-28 Thread Heikki Krogerus
UTMI+ Low Pin Interface (ULPI) is a commonly used PHY interface for USB 2.0. The ULPI specification describes a standard set of registers which the vendors can extend for their specific needs. ULPI PHYs provide often functions such as charger detection and ADP sensing and probing. There are two ma

[PATCHv3 00/12] usb: ulpi bus

2015-04-28 Thread Heikki Krogerus
Hi, I took the liberty of adding David's ACK to everything except 9/12, including to the 1/12 (removing the module handling has no functional affect). Changes since v2: - remove module handling from the bus driver as suggested by Paul Bolle. - reordered the gpio requests in BYT quirk as suggested

[PATCHv3 03/11] usb: dwc3: ULPI or UTMI+ select

2015-04-28 Thread Heikki Krogerus
Make selection between ULPI and UTMI+ interfaces possible by providing definition for the bit in Global USB2 PHY Configuration Register that controls it. Signed-off-by: Heikki Krogerus Acked-by: David Cohen --- drivers/usb/dwc3/core.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/

[PATCHv3 04/11] usb: dwc3: store driver data earlier

2015-04-28 Thread Heikki Krogerus
We need to store it before phys are handled, so we can later use it in ULPI interface support code. Signed-off-by: Heikki Krogerus Acked-by: David Cohen --- drivers/usb/dwc3/core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/c

[PATCHv3 05/11] usb: dwc3: cache hwparams earlier

2015-04-28 Thread Heikki Krogerus
So they are available when ULPI interface support is added. Signed-off-by: Heikki Krogerus Acked-by: David Cohen --- drivers/usb/dwc3/core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index c7734ed..104b236 100644 ---

[PATCHv3 06/11] usb: dwc3: soft reset to it's own function

2015-04-28 Thread Heikki Krogerus
So it can be called from other places later. Signed-off-by: Heikki Krogerus Acked-by: David Cohen --- drivers/usb/dwc3/core.c | 46 ++ 1 file changed, 30 insertions(+), 16 deletions(-) diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c in

[PATCHv3 08/11] usb: dwc3: add hsphy_interface property

2015-04-28 Thread Heikki Krogerus
Platforms that have configured DWC_USB3_HSPHY_INTERFACE with value 3, i.e. UTMI+ and ULPI, need to inform the driver of the actual HSPHY interface type with the property. "utmi" if the interface is UTMI+ or "ulpi" if the interface is ULPI. Signed-off-by: Heikki Krogerus Acked-by: David Cohen ---

[PATCHv3 09/11] usb: dwc3: pci: add quirk for Baytrails

2015-04-28 Thread Heikki Krogerus
On some BYT platforms the USB2 PHY needs to be put into operational mode by the controller driver with GPIOs controlling the PHYs reset and cs signals. Signed-off-by: Heikki Krogerus --- drivers/usb/dwc3/dwc3-pci.c | 36 1 file changed, 36 insertions(+) diff

[PATCHv3 11/11] phy: add driver for TI TUSB1210 ULPI PHY

2015-04-28 Thread Heikki Krogerus
TUSB1210 ULPI PHY has vendor specific register for eye diagram tuning. On some platforms the system firmware has set optimized value to it. In order to not loose the optimized value, the driver stores it during probe and restores it every time the PHY is powered back on. Signed-off-by: Heikki Krog

[PATCHv3 07/11] usb: dwc3: setup phys earlier

2015-04-28 Thread Heikki Krogerus
This allows dwc3_phy_setup() to be more useful later. There is nothing preventing the PHY configuration registers from being programmed early. They do not loose their context in soft reset. There are however other PHY related operations that should be executed before the driver request handles to

[PATCHv3 10/11] phy: helpers for USB ULPI PHY registering

2015-04-28 Thread Heikki Krogerus
ULPI PHYs need to be bound to their controllers with a lookup. This adds helpers that the ULPI drivers can use to do both, the registration of the PHY and the lookup, at the same time. Signed-off-by: Heikki Krogerus Acked-by: David Cohen Cc: Kishon Vijay Abraham I --- drivers/phy/ulpi_phy.h |

[PATCHv3 02/11] usb: dwc3: USB2 PHY register access bits

2015-04-28 Thread Heikki Krogerus
Definitions for Global USB2 PHY Vendor Control Register bits. We will need them to access ULPI PHY registers later. Signed-off-by: Heikki Krogerus Acked-by: David Cohen --- drivers/usb/dwc3/core.h | 8 1 file changed, 8 insertions(+) diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/

[PATCH] usb: phy: Remove the phy-rcar-gen2-usb driver

2015-04-28 Thread Geert Uytterhoeven
The phy-rcar-gen2-usb driver, which supports legacy platform data only, is no longer used since commit a483dcbfa21f919c ("ARM: shmobile: lager: Remove legacy board support"). This driver was superseded by the DT-only phy-rcar-gen2 driver, which was introduced in commit 1233f59f745b237d ("phy: Rene

[PATCH] usb: gadget: ether: Fix MAC address parsing

2015-04-28 Thread Stefan Agner
MAC addresses can be written without leading zeros. A popular example is libc's ether_ntoa_r function which creates such MAC addresses. Example: 00:14:3d:0f:ff:fe can be written as 0:14:3d:f:ff:fe Additionally, get_ether_addr potentially parsed past the end of the user provided string. Use the op

Re: [PATCH] usb: phy: rcar-gen2-usb: Fix USBHS_UGSTS_LOCK value

2015-04-28 Thread Geert Uytterhoeven
Hi Shimoda-san, On Tue, Apr 28, 2015 at 12:25 PM, Yoshihiro Shimoda wrote: >> Sent: Tuesday, April 28, 2015 6:55 PM >> On Tue, Apr 28, 2015 at 3:36 AM, Yoshihiro Shimoda >> wrote: >> >> Sent: Tuesday, April 28, 2015 4:45 AM >> >> On Thu, Apr 02, 2015 at 08:22:34PM +0900, Yoshihiro Shimoda wrote:

Re: [PATCH 3/3] Usb: core: buffer: fixed the checkpatch warning

2015-04-28 Thread Greg KH
On Sat, Apr 18, 2015 at 08:22:36PM +0530, Nizam Haider wrote: > Fixed two warnings sizeof name and clank line after declaration "clank"? -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vge

Re: [PATCH] drivers/usb/core: hcd.c: Removed BitTime space warnings

2015-04-28 Thread Greg KH
On Sat, Apr 11, 2015 at 05:51:21PM -0700, Chase Metzger wrote: > Removed BitTime macro space warnings generated by checkpatch.pl. > > Signed-off-by: Chase Metzger > --- > drivers/usb/core/hcd.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) You sent a bunch of patches, yet didn

Re: [PATCH] drivers/usb/core: devio.c: Removed various errors and warnings generated by checkpatch.pl

2015-04-28 Thread Greg KH
On Sat, Apr 11, 2015 at 10:20:38AM -0700, Joe Perches wrote: > On Sat, 2015-04-11 at 00:53 -0700, Chase Metzger wrote: > > Fixed several errors and warnings. > [] > > Lines 1040 and 1591: changed dev_printk(KERN_DEBUG, ...) to dev_dbg(...). > > These changes hav the possibly undesired effect of >

Re: [PATCH] usb: core: add usb3 lpm sysfs

2015-04-28 Thread Greg KH
On Sun, Apr 19, 2015 at 11:46:12AM +0800, Zhuang Jin Can wrote: > Some usb3 devices may not support usb3 lpm well. > The patch adds a sysfs to enable/disable u1 or u2 of the port.The > settings apply to both before and after device enumeration. > Supported values are "0" - u1 and u2 are disabled, "

Re: [PATCH] usb: image: mdc800: fixed various style issues

2015-04-28 Thread Greg KH
On Thu, Apr 23, 2015 at 05:59:01PM -0600, Jason Eastman wrote: > Fixed several style issues with: comments, function perenthesis, > indentation, and conditional braces > > Signed-off-by: Jason Eastman > --- > drivers/usb/image/mdc800.c | 769 > +++- > 1

RE: [PATCH] usb: phy: rcar-gen2-usb: Fix USBHS_UGSTS_LOCK value

2015-04-28 Thread Yoshihiro Shimoda
Hi Geert-san, Thank you for your comment! > Sent: Tuesday, April 28, 2015 6:55 PM > > Hi Shimoda-san, > > On Tue, Apr 28, 2015 at 3:36 AM, Yoshihiro Shimoda > wrote: > >> Sent: Tuesday, April 28, 2015 4:45 AM > >> On Thu, Apr 02, 2015 at 08:22:34PM +0900, Yoshihiro Shimoda wrote: > >> > Accord

Re: [PATCH] usb: phy: rcar-gen2-usb: Fix USBHS_UGSTS_LOCK value

2015-04-28 Thread Geert Uytterhoeven
Hi Shimoda-san, On Tue, Apr 28, 2015 at 3:36 AM, Yoshihiro Shimoda wrote: >> Sent: Tuesday, April 28, 2015 4:45 AM >> On Thu, Apr 02, 2015 at 08:22:34PM +0900, Yoshihiro Shimoda wrote: >> > According to the technical update (No. TN-RCS-B011A/E), the UGSTS LOCK >> > bit location is bit 8, not bits

RE: [PATCH v3 00/11] usbip: features to USB over WebSocket

2015-04-28 Thread fx IWATA NOBUO
Hello, > As far as I understand your design you have kernel stub driver which > is sending and receiving data via socket fd received from userspace. > Now after this series you are exporting all messages to userspace > where daemon is sending them using web sockets. Am I right? Yes. > I don't

Re: [PATCH] usb: gadget: ether: Fix MAC address parsing

2015-04-28 Thread Stefan Agner
Hi Krzysztof, On 2015-04-27 11:42, Krzysztof Opasiak wrote: > MAC address is often written without leading zeros. > > Example: > 00:14:3d:0f:ff:fe can be written as 0:14:3d:f:ff:fe > > Convention of skipping leading zeros is used in libc. > enther_ntoa_r() generates MAC address without leading >

Re: [PATCH 1/1] drivers/usb/chipidea/debuc.c: avoid out of bound read

2015-04-28 Thread Peter Chen
On Mon, Apr 27, 2015 at 08:25:12PM +0200, Heinrich Schuchardt wrote: > On 22.04.2015 03:26, Peter Chen wrote: > > On Tue, Apr 21, 2015 at 09:25:41PM +0200, Heinrich Schuchardt wrote: > >> Hello Peter, > >> > >> thanks for reviewing. > >> > >> On 21.04.2015 03:32, Peter Chen wrote: > >>> On Fri, Apr

[PATCH] usb: gadget: composite: enable BESL support

2015-04-28 Thread Du, Changbin
>From a6615937bcd9234e6d6bb817c3701fce44d0a84d Mon Sep 17 00:00:00 2001 From: Felipe Balbi Date: Tue, 30 Sep 2014 16:08:03 -0500 Subject: [PATCH] usb: gadget: composite: enable BESL support According to USB 2.0 ECN Errata for Link Power Management (USB2-LPM-Errata-final.pdf), BESL must be enabled

Re: [PATCH v2] Revert "usb: host: ehci-msm: Use devm_ioremap_resource instead of devm_ioremap"

2015-04-28 Thread Vivek Gautam
Hi, -- From: "Alan Stern" Sent: Monday, April 27, 2015 8:14 PM To: "Ivan T. Ivanov" Cc: "Greg Kroah-Hartman" ; ; ; ; "Vivek Gautam" Subject: Re: [PATCH v2] Revert "usb: host: ehci-msm: Use devm_ioremap_resource instead of devm_ioremap" On M

Re: [PATCH v3 00/11] usbip: features to USB over WebSocket

2015-04-28 Thread Krzysztof Opasiak
Hello, On 04/27/2015 03:07 AM, Nobuo Iwata wrote: (...snip...) 2) User space transmission USB/IP transfer URBs in kernel space. It's better for performance but difficult to introduce application protocols. Like fuse for file systems, it allows to transfer URBs in user space. When usbip_ux.ko