Re: DWC3 linux driver query

2015-05-29 Thread sundeep subbaraya
Hi, On Fri, May 29, 2015 at 8:35 PM, Felipe Balbi wrote: > On Fri, May 29, 2015 at 07:01:16PM +0530, sundeep subbaraya wrote: >> Hi Felipe, >> >> On Thu, May 28, 2015 at 7:41 PM, Felipe Balbi wrote: >> > Hi, >> > >> > On Thu, May 28, 2015 at 04:53:09PM +0530, sundeep subbaraya wrote: >> >> Hi Fe

Re: [PATCH] usb: gadget: nokia: Add mass storage driver to g_nokia

2015-05-29 Thread Felipe Balbi
On Thu, May 28, 2015 at 11:40:07PM +0200, Pali Rohár wrote: > On Thursday 28 May 2015 18:34:31 Felipe Balbi wrote: > > On Thu, May 28, 2015 at 04:59:18PM +0200, Pali Rohár wrote: > > > On Thursday 28 May 2015 16:51:07 Krzysztof Opasiak wrote: > > > > On 05/28/2015 04:31 PM, Pali Rohár wrote: > > >

[PATCH v3 1/6] dt-bindings: Add Marvell PXA1928 USB and HSIC PHY bindings

2015-05-29 Thread Rob Herring
Add PHY binding for Marvell PXA1928 SOC's USB and HSIC PHYs. Signed-off-by: Rob Herring Cc: Pawel Moll Cc: Mark Rutland Cc: Ian Campbell Cc: Kumar Gala Cc: devicet...@vger.kernel.org --- .../devicetree/bindings/phy/pxa1928-usb-phy.txt| 18 ++ 1 file changed, 18 insert

[PATCH v3 4/6] dt-bindings: Consolidate ChipIdea USB ci13xxx bindings

2015-05-29 Thread Rob Herring
Combine the ChipIdea USB binding into a single document to reduce duplication and fragmentation. This marks use of the old PHY bindings as deprecated. Future compatible bindings should use generic PHY binding. Signed-off-by: Rob Herring Cc: Ivan T. Ivanov Cc: Peter Chen Cc: Daniel Tang Cc: Paw

[PATCH v3 6/6] usb: chipidea: add work-around for Marvell HSIC PHY startup

2015-05-29 Thread Rob Herring
The Marvell 28nm HSIC PHY requires the port to be forced to HS mode after the port power is applied. This is done using the test mode in the PORTSC register. As HSIC is always HS, this work-around should be safe to do with all HSIC PHYs and has been tested on i.MX6S. Signed-off-by: Rob Herring T

[PATCH v3 5/6] usb: chipidea: allow multiple instances to use default ci_default_pdata

2015-05-29 Thread Rob Herring
Currently, ci_default_pdata is common to all instances of the driver and gets modified by the core driver code. This is bad if there are multiple instances of the device with different settings such as the phy type. Fix this by making a copy of the default platform_data. Signed-off-by: Rob Herring

[PATCH v3 2/6] phy: Add Marvell USB 2.0 OTG 28nm PHY

2015-05-29 Thread Rob Herring
Add driver for USB 28nm PHY found in Marvell PXA1928 SOC. Signed-off-by: Rob Herring Cc: Kishon Vijay Abraham I --- drivers/phy/Kconfig | 10 ++ drivers/phy/Makefile| 1 + drivers/phy/phy-pxa-28nm-usb2.c | 355 3 files changed,

[PATCH v3 3/6] phy: add Marvell HSIC 28nm PHY

2015-05-29 Thread Rob Herring
Add PHY driver for the Marvell HSIC 28nm PHY. This PHY is found in PXA1928 SOC. Signed-off-by: Rob Herring Cc: Kishon Vijay Abraham I --- drivers/phy/Kconfig | 10 ++ drivers/phy/Makefile| 1 + drivers/phy/phy-pxa-28nm-hsic.c | 220

[PATCH v3 0/6] Marvell PXA1928 USB support

2015-05-29 Thread Rob Herring
This series adds USB PHYs and EHCI host drivers for the Marvell PXA1928 SOC. The OTG block is based on ChipIdea and works with the "chipidea,usb2" compatible driver as is just by adding the PHY driver. Yay! After more testing it turns out the EHCI host is also based on ChipIdea too. So this vers

[PATCH] usb: dwc3: gadget: don't clear EP_BUSY too early

2015-05-29 Thread Felipe Balbi
In case of non-Isochronous transfers, we don't want to clear DWC3_EP_BUSY flag until XferComplete event. That's because XferInProgress was only enabled so we can recycle TRBs and usb_requests quicker, but there are still other pending requests being transferred. In order to make sure we don't allo

Re: DWC3 linux driver query

2015-05-29 Thread Felipe Balbi
On Fri, May 29, 2015 at 07:01:16PM +0530, sundeep subbaraya wrote: > Hi Felipe, > > On Thu, May 28, 2015 at 7:41 PM, Felipe Balbi wrote: > > Hi, > > > > On Thu, May 28, 2015 at 04:53:09PM +0530, sundeep subbaraya wrote: > >> Hi Felipe and Paul, > > > > btw, Paul has left Synopys :-) > > ahh I se

Re: [PATCHv3 1/4] phy: phy-core: Make GENERIC_PHY an invisible option

2015-05-29 Thread Felipe Balbi
Hi, On Fri, May 29, 2015 at 05:04:38PM +0530, Kishon Vijay Abraham I wrote: > Hi Felipe, > > On Wednesday 27 May 2015 12:09 AM, Felipe Balbi wrote: > >On Tue, May 26, 2015 at 11:37:17AM -0700, Arun Ramamurthy wrote: > >>Hi > >> > >>On 15-05-26 07:19 AM, Felipe Balbi wrote: > >>>HI, > >>> > >>>On

Re: [PATCH 7/9] xhci: remove XHCI_TRUST_TX_LENGTH quirk and handle it as default

2015-05-29 Thread Rodrigo Severo
On Fri, May 29, 2015 at 11:01 AM, Mathias Nyman wrote: > Now including Renesas uPD720201 we got four xhci vendors that return > Success instead of short transfer when there are still unstraferred bytes > left. The driver anyway checks the untransferred bytes and suggest adding > the quirk if neede

Re: [PATCH] drivers:usb:fsl: Fix compilation error for fsl ehci drv

2015-05-29 Thread Alan Stern
On Fri, 29 May 2015, Ramneek Mehresh wrote: > Fix compilation error in fsl ehci drv because ehci_reset() > and ehci_adjust_port_wakeup_flags() were not exported, and > are used when PM is enabled > > Signed-off-by: Ramneek Mehresh Acked-by: Alan Stern -- To unsubscribe from this list: send t

[PATCH 8/9] xhci: Return correct number of tranferred bytes for stalled control endpoints

2015-05-29 Thread Mathias Nyman
Fix the xhci driver from bluntly setting the transferred length to 0 if we get a STALL on anything else than the data stage of a control transfer. Signed-off-by: Mathias Nyman --- drivers/usb/host/xhci-ring.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/xh

[PATCH 3/9] usb: xhci: Allow usb_add/remove_hcd() to be called repeatedly

2015-05-29 Thread Mathias Nyman
From: Roger Quadros Don't set xhci->shared_hcd to NULL in xhci_stop() as we have still not de-allocated it. It was resulting in a NULL pointer de-reference if usb_add/remove_hcd() is called repeatedly. We want repeated add/remove to work for the OTG use case. Signed-off-by: Roger Quadros Signe

[PATCH 6/9] xhci: optimize xhci bus resume time

2015-05-29 Thread Mathias Nyman
We used to write the root port state changes in turn for every port, sleeping 20ms after every port state change. Suspended usb2 ports need two state changes, taking minimun 40ms per port. Now instead poll the Port Link State Change (PLC) bit as the state change to U0 will set this bit. Suspended

[PATCH 5/9] usb: xhci: Fix suspend/resume when used with OTG core

2015-05-29 Thread Mathias Nyman
From: Roger Quadros In the OTG case, the controller might not yet have been added or is removed before the system suspends. Assign xhci->main_hcd during probe to prevent NULL pointer de-reference in xhci_suspend/resume(). Use the hcd->state flag to check if HCD is halted and if that is so do no

[PATCH 9/9] usb: host: xhci: remove incorrect comment about mutex

2015-05-29 Thread Mathias Nyman
From: Chris Bainbridge The comment stating that xhci_setup_device() is protected by the address mutex is not true since commit 6fecd4f2a58c ("USB: separate usb_address0 mutexes for each bus") as xhci handles two buses. Signed-off-by: Chris Bainbridge Signed-off-by: Mathias Nyman --- drivers/u

[PATCH 7/9] xhci: remove XHCI_TRUST_TX_LENGTH quirk and handle it as default

2015-05-29 Thread Mathias Nyman
Now including Renesas uPD720201 we got four xhci vendors that return Success instead of short transfer when there are still unstraferred bytes left. The driver anyway checks the untransferred bytes and suggest adding the quirk if needed, so we can as well make it default behavior and get rid of the

[PATCH 4/9] usb: xhci: fix xhci locking up during hcd remove

2015-05-29 Thread Mathias Nyman
From: Roger Quadros The problem seems to be that if a new device is detected while we have already removed the shared HCD, then many of the xhci operations (e.g. xhci_alloc_dev(), xhci_setup_device()) hang as command never completes. I don't think XHCI can operate without the shared HCD as we'v

[PATCH 0/9] xhci features for usb next

2015-05-29 Thread Mathias Nyman
Hi Greg These xhci patches for usb-next include Roger Quardros series allowing xhci to work nicely with OTG core. Other patches optimize resume time for xhci, and remove a common quirk that we can detect and handle by default. -Mathias Chris Bainbridge (1): usb: host: xhci: remove incorrect co

[PATCH 1/9] usb: xhci: cleanup xhci_hcd allocation

2015-05-29 Thread Mathias Nyman
From: Roger Quadros HCD core allocates memory for HCD private data in usb_create_[shared_]hcd() so make use of that mechanism to allocate the struct xhci_hcd. Introduce struct xhci_driver_overrides to provide the size of HCD private data and hc_driver operation overrides. As of now we only need

[PATCH 2/9] usb: xhci: plat: Create both HCDs before adding them

2015-05-29 Thread Mathias Nyman
From: Roger Quadros As xhci_hcd is now allocated by usb_create_hcd(), we don't need to add the primary HCD before creating the shared HCD. Creating the shared HCD before adding the primary HCD is particularly useful for the OTG use case so that we know at the OTG core if the HCD is in single con

Re: [PATCH] usb: host: xhci-pci: Fix NULL pointer dereference error

2015-05-29 Thread Roger Quadros
Mathias, On 29/05/15 16:19, Mathias Nyman wrote: On 26.05.2015 17:15, Roger Quadros wrote: From: Kishon Vijay Abraham I commit 3b8295d5cbf2 (usb: xhci: Fix suspend/resume when used with OTG core) removes assigning xhci->main_hcd from xhci_gen_setup and adds it in the probe of xhci-plat and xh

Re: DWC3 linux driver query

2015-05-29 Thread sundeep subbaraya
Hi Felipe, On Thu, May 28, 2015 at 7:41 PM, Felipe Balbi wrote: > Hi, > > On Thu, May 28, 2015 at 04:53:09PM +0530, sundeep subbaraya wrote: >> Hi Felipe and Paul, > > btw, Paul has left Synopys :-) ahh I see.. > >> I am seeing an issue while testing iperf for USB ethernet gadget with >> dwc3 co

Re: ehci_bus_suspend system halt

2015-05-29 Thread Michael Trimarchi
Hi On Thu, May 28, 2015 at 01:42:07PM -0400, Alan Stern wrote: > On Thu, 28 May 2015, Michael Trimarchi wrote: > > > Hi Alan > > > > we are working on a samsung exysnos5430 device and we have some problem > > during suspend. The only way to solve it seems this patch. > > We don't really know wha

Re: [PATCH] usb: host: xhci-pci: Fix NULL pointer dereference error

2015-05-29 Thread Mathias Nyman
On 26.05.2015 17:15, Roger Quadros wrote: > From: Kishon Vijay Abraham I > > commit 3b8295d5cbf2 (usb: xhci: Fix suspend/resume when used > with OTG core) removes assigning xhci->main_hcd from xhci_gen_setup > and adds it in the probe of xhci-plat and xhci-pci. > > In the case of xhci-pci, xhci_

Re: [PATCHv3 1/4] phy: phy-core: Make GENERIC_PHY an invisible option

2015-05-29 Thread Sylwester Nawrocki
On 29/05/15 14:37, Kishon Vijay Abraham I wrote: > Tejun, Maxime, Sylwester, Kyungmin > > On Thursday 23 April 2015 04:34 AM, Arun Ramamurthy wrote: >> Most of the phy providers use "select" to enable GENERIC_PHY. Since select >> is only recommended when the config is not visible, GENERIC_PHY is c

Re: [PATCHv3 1/4] phy: phy-core: Make GENERIC_PHY an invisible option

2015-05-29 Thread Tejun Heo
On Fri, May 29, 2015 at 06:07:18PM +0530, Kishon Vijay Abraham I wrote: > Tejun, Maxime, Sylwester, Kyungmin > > On Thursday 23 April 2015 04:34 AM, Arun Ramamurthy wrote: > >Most of the phy providers use "select" to enable GENERIC_PHY. Since select > >is only recommended when the config is not vi

Re: [PATCHv3 1/4] phy: phy-core: Make GENERIC_PHY an invisible option

2015-05-29 Thread Maxime Coquelin
Hi Kishon, Arun, On 05/29/2015 02:37 PM, Kishon Vijay Abraham I wrote: Tejun, Maxime, Sylwester, Kyungmin On Thursday 23 April 2015 04:34 AM, Arun Ramamurthy wrote: Most of the phy providers use "select" to enable GENERIC_PHY. Since select is only recommended when the config is not visible, GE

Re: ehci_bus_suspend system halt

2015-05-29 Thread Michael Trimarchi
Hi On Thu, May 28, 2015 at 01:42:07PM -0400, Alan Stern wrote: > On Thu, 28 May 2015, Michael Trimarchi wrote: > > > Hi Alan > > > > we are working on a samsung exysnos5430 device and we have some problem > > during suspend. The only way to solve it seems this patch. > > We don't really know wha

Re: [PATCHv3 1/4] phy: phy-core: Make GENERIC_PHY an invisible option

2015-05-29 Thread Kishon Vijay Abraham I
Tejun, Maxime, Sylwester, Kyungmin On Thursday 23 April 2015 04:34 AM, Arun Ramamurthy wrote: Most of the phy providers use "select" to enable GENERIC_PHY. Since select is only recommended when the config is not visible, GENERIC_PHY is changed an invisible option. To maintain consistency, all ph

Re: USB3 external HDD not recognized [regression]

2015-05-29 Thread Ralf Jung
Hi again, > Indeed doing "echo 'on' | sudo tee /sys/bus/pci/devices/*/power/control" > fixes the problem: When I subsequently plug in the disk, it is > recognized correctly. I confirmed this with an older kernel (the 3.16 > Debian kernel, to be more precise). That's good to know, now I don't > nee

Re: [PATCHv3 1/4] phy: phy-core: Make GENERIC_PHY an invisible option

2015-05-29 Thread Kishon Vijay Abraham I
Hi Felipe, On Wednesday 27 May 2015 12:09 AM, Felipe Balbi wrote: On Tue, May 26, 2015 at 11:37:17AM -0700, Arun Ramamurthy wrote: Hi On 15-05-26 07:19 AM, Felipe Balbi wrote: HI, On Mon, May 25, 2015 at 02:19:58PM -0700, Arun Ramamurthy wrote: On 15-05-14 05:52 PM, Felipe Balbi wrote: H

Re: [PATCH 1/1] usb: Remove Vernier devices from lsusb and hid_ignore_list

2015-05-29 Thread Jiri Kosina
On Thu, 28 May 2015, Greg KH wrote: > On Thu, May 28, 2015 at 04:58:54PM +0200, Jiri Kosina wrote: > > On Thu, 21 May 2015, Dennis O'Brien wrote: > > > > > From: Dennis O'Brien > > > > > > Removes Vernier Software & Technology devices from the ldusb > > > driver and the hid_ignore_list table of