Re: [PATCH v3 06/11] usb: gadget.h: Add OTG to gadget interface

2015-07-16 Thread Peter Chen
On Wed, Jul 08, 2015 at 01:19:32PM +0300, Roger Quadros wrote: > The OTG core will use struct otg_gadget_ops to > start/stop the gadget controller. > > The main purpose of this interface is to avoid directly > calling usb_gadget_start/stop() from the OTG core as they > wouldn't be defined in the b

Re: [PATCH v3 05/11] usb: hcd.h: Add OTG to HCD interface

2015-07-16 Thread Peter Chen
On Wed, Jul 08, 2015 at 01:19:31PM +0300, Roger Quadros wrote: > The OTG core will use struct otg_hcd_ops to > add/remove the HCD controller. > > The main purpose of this interface is to avoid directly > calling usb_add/remove_hcd() from the OTG core as they > wouldn't be defined in the built-in s

Re: [PATCH v3 04/11] otg-fsm: move usb_bus_start_enum into otg-fsm->ops

2015-07-16 Thread Peter Chen
On Wed, Jul 08, 2015 at 01:19:30PM +0300, Roger Quadros wrote: > This is to prevent missing symbol build error if OTG is > enabled (built-in) and HCD core (CONFIG_USB) is module. > > Signed-off-by: Roger Quadros > --- > drivers/usb/common/usb-otg-fsm.c | 6 -- > drivers/usb/phy/phy-fsl-usb.c

RE: [PATCH 1/1] usb: gadget: composite: fix configuration NULL pointer dereference problem

2015-07-16 Thread Peter Chen
> > On Thu, Jul 16, 2015 at 04:04:28PM +0800, Peter Chen wrote: > > At some unexpected cases, the host may send the non-core control > > request before the configruation has been established, so the > > cdev->config is still NULL, then below NULL pointer dereference issue > > problem will occur.

Re: [PATCH v4 3/3] USB / PM: Allow USB devices to remain runtime-suspended when sleeping

2015-07-16 Thread Rafael J. Wysocki
On Thursday, July 16, 2015 02:09:41 PM Tomeu Vizoso wrote: > On 16 July 2015 at 02:42, Rafael J. Wysocki wrote: > > On Wednesday, July 15, 2015 02:40:08 PM Tomeu Vizoso wrote: > >> Have dev_pm_ops.prepare return 1 for USB devices and ports so that USB > >> devices can remain runtime-suspended when

Re: [PATCH 2/8] cdc-ncm: use common CDC parser

2015-07-16 Thread Oliver Neukum
On Thu, 2015-07-16 at 22:18 +0200, Bjørn Mork wrote: > I'm on vacation without any usable Internet or other code access, so you'll > have to excuse me if I'm missing something. But this seems to leave > union_desc uninitialized, doesn't it? Yes, good catch. I'll make a new version. Tha

[PATCH 3/4] usb: gadget: bdc: Add device-tree binding document for BDC driver

2015-07-16 Thread Al Cooper
Signed-off-by: Al Cooper --- Documentation/devicetree/bindings/usb/bdc-udc.txt | 16 1 file changed, 16 insertions(+) create mode 100644 Documentation/devicetree/bindings/usb/bdc-udc.txt diff --git a/Documentation/devicetree/bindings/usb/bdc-udc.txt b/Documentation/devicetree/

[PATCH 1/4] usb: gadget: udc: bdc: Fix a driver crash on disconnect

2015-07-16 Thread Al Cooper
ep_dequeue() in bdc_ep.c was capturing the hw dequeue pointer incorrectly by reading the wrong register for the upper 32 bits. The header file defining the registers was incorrect. Signed-off-by: Al Cooper --- drivers/usb/gadget/udc/bdc/bdc.h | 16 drivers/usb/gadget/udc/bdc

[PATCH 2/4] usb: gadget: udc: bdc: Add a Device Tree compatible string

2015-07-16 Thread Al Cooper
Allows Device Tree probing Signed-off-by: Al Cooper --- drivers/usb/gadget/udc/bdc/bdc_core.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/usb/gadget/udc/bdc/bdc_core.c b/drivers/usb/gadget/udc/bdc/bdc_core.c index 5c8f4ef..0f963d5 100644 --- a/drivers/usb/gadget/udc/bdc/

[PATCH 4/4] MAINTAINERS: Add entry for BDC UDC driver

2015-07-16 Thread Al Cooper
Signed-off-by: Al Cooper --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 246d9d8..88b443d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2301,6 +2301,12 @@ L: net...@vger.kernel.org S: Supported F: drivers/net/ethernet/broa

Re: [PATCH 2/8] cdc-ncm: use common CDC parser

2015-07-16 Thread Bjørn Mork
I'm on vacation without any usable Internet or other code access, so you'll have to excuse me if I'm missing something. But this seems to leave union_desc uninitialized, doesn't it? Bjørn On July 16, 2015 9:24:34 PM CEST, Oliver Neukum wrote: >Switch to the common parser > >Signed-off-by: Oli

Re: [PATCH] USB: pl2303: Rewrite pl2303_encode_baud_rate_divisor

2015-07-16 Thread Greg KH
On Thu, Jul 16, 2015 at 10:12:55PM +0200, Frank Schäfer wrote: > Simply not true, re-read the ML archieves. For those of us who don't understand, please explain. > In that case I would of course have supported the revert. > We both know the real reason. What is the "real reason" that you feel th

Re: [PATCH] USB: pl2303: Rewrite pl2303_encode_baud_rate_divisor

2015-07-16 Thread Frank Schäfer
Am 14.07.2015 um 22:29 schrieb Greg KH: > On Tue, Jul 14, 2015 at 09:29:29PM +0200, Frank Schäfer wrote: >>> If you want to pick this up and improve the divisor calculations that'd >>> be great. >> Maybe you should just start doing your job as the maintainer and accept >> one of the patches peopl

Re: [PATCH] USB: pl2303: Rewrite pl2303_encode_baud_rate_divisor

2015-07-16 Thread Frank Schäfer
Am 15.07.2015 um 13:16 schrieb Johan Hovold: > > Your changes caused a regression that was discovered mere days before > 3.12 was released. At the time the reason had not been fully determined > so the patches were consequently reverted. Simply not true, re-read the ML archieves. In that case I w

Re: [PATCH v3 00/11] USB: OTG/DRD Core functionality

2015-07-16 Thread Andrew Bresticker
Hi Roger, On Wed, Jul 15, 2015 at 6:26 AM, Roger Quadros wrote: > Hi Andrew, > > On 13/07/15 22:14, Andrew Bresticker wrote: >> Hi Roger, >> >> On Wed, Jul 8, 2015 at 3:19 AM, Roger Quadros wrote: >>> Usage model: >>> --- >>> >>> - The OTG controller device is assumed to be the parent of

Re: [PATCH 1/1] usb: gadget: composite: fix configuration NULL pointer dereference problem

2015-07-16 Thread Li Jun
On Thu, Jul 16, 2015 at 04:04:28PM +0800, Peter Chen wrote: > At some unexpected cases, the host may send the non-core control request > before the configruation has been established, so the cdev->config is still > NULL, then below NULL pointer dereference issue problem will occur. Although > the u

Re: [PATCH v4 3/3] USB / PM: Allow USB devices to remain runtime-suspended when sleeping

2015-07-16 Thread Tomeu Vizoso
On 16 July 2015 at 02:42, Rafael J. Wysocki wrote: > On Wednesday, July 15, 2015 02:40:08 PM Tomeu Vizoso wrote: >> Have dev_pm_ops.prepare return 1 for USB devices and ports so that USB >> devices can remain runtime-suspended when the system goes to a sleep >> state, if their wakeup state is corr

Re: [PATCH] USB: ftdi_sio: add GPIO support

2015-07-16 Thread Linus Walleij
On Sat, Jul 4, 2015 at 12:13 AM, Grant Likely wrote: > On Tue, Jun 2, 2015 at 2:18 PM, Linus Walleij > wrote: >> On Sat, May 30, 2015 at 10:29 PM, Grant Likely >> wrote: >>> On Mon, Jul 7, 2014 at 6:31 PM, Greg Kroah-Hartman >>> wrote: >> > However is the MFD cell approach acceptable?

Re: [PATCH v3 04/11] otg-fsm: move usb_bus_start_enum into otg-fsm->ops

2015-07-16 Thread Roger Quadros
On 16/07/15 03:54, Peter Chen wrote: > On Wed, Jul 15, 2015 at 04:30:27PM +0300, Roger Quadros wrote: >> On 14/07/15 03:34, Peter Chen wrote: >>> On Mon, Jul 13, 2015 at 01:13:54PM +0300, Roger Quadros wrote: Peter, On 13/07/15 04:58, Peter Chen wrote: > On Wed, Jul 08, 2015 at 0

Re: [PATCH 1/1] usb: gadget: composite: fix configuration NULL pointer dereference problem

2015-07-16 Thread Roger Quadros
On 16/07/15 13:31, Roger Quadros wrote: > Peter, > > On 16/07/15 11:04, Peter Chen wrote: >> At some unexpected cases, the host may send the non-core control request >> before the configruation has been established, so the cdev->config is still >> NULL, then below NULL pointer dereference issue pr

Re: [PATCH 1/1] usb: gadget: composite: fix configuration NULL pointer dereference problem

2015-07-16 Thread Roger Quadros
Peter, On 16/07/15 11:04, Peter Chen wrote: > At some unexpected cases, the host may send the non-core control request > before the configruation has been established, so the cdev->config is still > NULL, then below NULL pointer dereference issue problem will occur. Although > the udc driver can h

[PATCH 1/1] usb: gadget: composite: fix configuration NULL pointer dereference problem

2015-07-16 Thread Peter Chen
At some unexpected cases, the host may send the non-core control request before the configruation has been established, so the cdev->config is still NULL, then below NULL pointer dereference issue problem will occur. Although the udc driver can handle non-core control request beforhand, we still ne

RE: [PATCH v4 00/11] usbip: features to USB over WebSocket

2015-07-16 Thread fx IWATA NOBUO
Dear Valentina, I'm preparing 2 sets of patches. 1) cleanups, fixings and workarounds to WebSocket patch set and previous code. - no critical modification included. 2) number of ports extension in vhci side - I think it was talked in 'usbredir' e-mail thread. I wrote these on WebSocket p