Re: [PATCH v4 5/9] usb: dwc3: core: make dual-role work with OTG irq

2015-09-05 Thread Peter Chen
On Wed, Sep 02, 2015 at 09:43:38AM -0500, Felipe Balbi wrote: > Hi, > > > + > > +static irqreturn_t dwc3_otg_irq(int irq, void *_dwc) > > +{ > > + struct dwc3 *dwc = _dwc; > > + irqreturn_t ret = IRQ_NONE; > > + u32 reg; > > + > > + spin_lock(&dwc->lock); > > this seems unnecessary, we're

Re: [PATCH v4 1/9] usb: dwc3: add dual-role support

2015-09-05 Thread Peter Chen
On Wed, Sep 02, 2015 at 05:24:16PM +0300, Roger Quadros wrote: > Register with the USB OTG core. Since we don't support > OTG yet we just work as a dual-role device even > if device tree says "otg". > > + > +static int dwc3_drd_init(struct dwc3 *dwc) > +{ > + int ret, id, vbus; > + struct

Re: [RFC PATCH 1/1] usb: misc: usbtest: add bulk queue test

2015-09-05 Thread Peter Chen
On Wed, Sep 02, 2015 at 10:23:39AM -0400, Alan Stern wrote: > On Wed, 2 Sep 2015, Peter Chen wrote: > > > The bulk queue tests are used to show 'best performance' for bulk > > transfer, we are often asked this question by users. > > > > It's result should be very close to IC simulation, in order

[PATCH] usb: gadget: amd5536udc: fix error handling in udc_pci_probe()

2015-09-05 Thread Alexey Khoroshilov
If a failure happens early in udc_pci_probe(), error handling code just kfree(dev) and returns. The patch adds proper resource deallocations in udc_pci_probe() itself, since udc_pci_remove() is not suitabe to be called so early in initialization process. By the way, iounmap(dev->regs) is replaced