Re: [PATCHv2] usb: dwc2: use devm_phy_optional_get

2015-10-26 Thread Uwe Kleine-König
On Mon, Oct 26, 2015 at 10:28:18AM +0100, Alexander Aring wrote: > This patch changes devm_phy_get to devm_phy_optional_get. Which fixes the > error handling when trying to get the phy. Currently on all errors we > try to look for an old style USB PHY. With this patch we try to look for > an old

Re: [PATCH] HID: usbhid: Add a quirk for Xin-Mo Dual Arcade

2015-10-26 Thread Olivier Scherler
Hi, > On 24 oct. 2015, at 22:11, Jiri Kosina wrote: > > On Sat, 24 Oct 2015, Michele Baldessari wrote: > >> The Xin-Mo Dual Arcade controller (16c0:05e1) needs this quirk in order >> to have the two distinct joysticks working. >> >> Before the change: >> $ jstest

Re: [GIT PULL] On-demand device probing

2015-10-26 Thread Michael Turquette
Quoting Rafael J. Wysocki (2015-10-25 06:54:39) > On Sun, Oct 25, 2015 at 12:06 AM, Mark Brown wrote: > > On Sat, Oct 24, 2015 at 04:17:12PM +0200, Rafael J. Wysocki wrote: > > > >> Well, I'm not quite sure why exactly everyone is so focused on probing > >> here. > > > >

Re: [PATCH] dwc2: wait for usb phy while probing

2015-10-26 Thread Alexander Aring
Hi, On Sun, Oct 25, 2015 at 08:00:11PM +0100, Uwe Kleine-König wrote: > Hello, > > On Sun, Oct 25, 2015 at 08:57:31AM +0100, Alexander Aring wrote: > > This patch adds support to return -EPROBE_DEFER if devm_phy_get reports > > it. If devm_phy_get returns -EPROBE_DEFER it could be that there is

[PATCHv2] usb: dwc2: use devm_phy_optional_get

2015-10-26 Thread Alexander Aring
This patch changes devm_phy_get to devm_phy_optional_get. Which fixes the error handling when trying to get the phy. Currently on all errors we try to look for an old style USB PHY. With this patch we try to look for an old USB PHY when devm_phy_get returns -ENOENT only. Other values like

Re: [PATCH] dwc2: wait for usb phy while probing

2015-10-26 Thread Uwe Kleine-König
Hello Alex, On Mon, Oct 26, 2015 at 10:24:58AM +0100, Alexander Aring wrote: > On Sun, Oct 25, 2015 at 08:00:11PM +0100, Uwe Kleine-König wrote: > > On Sun, Oct 25, 2015 at 08:57:31AM +0100, Alexander Aring wrote: > > > This patch adds support to return -EPROBE_DEFER if devm_phy_get reports > > >

[PATCH v3 6/7] usb: host: xhci-plat: add support for the R-Car M2-N xHCI controller

2015-10-26 Thread Yoshihiro Shimoda
This patch adds support for R-Car M2-N (r8a7793) xHCI controller. This SoC is compatible with R-Car H2 (r8a7790) and R-Car M2-W (r8a7791). Signed-off-by: Yoshihiro Shimoda --- Documentation/devicetree/bindings/usb/usb-xhci.txt | 4 ++--

[PATCH v3 2/7] usb: host: xhci: add a platform-private field

2015-10-26 Thread Yoshihiro Shimoda
This patch adds an xhci->priv field for private use by XHCI platform drivers. Until now none of the platform drivers has used this private space. Signed-off-by: Yoshihiro Shimoda --- drivers/usb/host/xhci.h | 3 +++ 1 file changed, 3 insertions(+) diff --git

[PATCH 0/8] Staging: rdma ipath: fix checkpatch issues

2015-10-26 Thread Swetha
This patchset fixes checkpatch issues, for ipath_common.h and ipath_cq.c Swetha (8): Staging: rdma ipath: Removing multiple blank lines Staging: rdma ipath: __aligned(size) is preferred over __attribute__((aligned(size))) Staging : rdma ipath: spaces preferred around that '<<'

[RESEND PATCH] usb: remove unnecessary CONFIG_PM dependency from USB_OTG

2015-10-26 Thread Nathan Sullivan
The USB gadget support currently depends on power management (CONFIG_PM) being enabled, but does not actually need it enabled. Remove this dependency. Tested on Bay Trail hardware with dwc3 USB. Signed-off-by: Nathan Sullivan --- drivers/usb/core/Kconfig |1 - 1

[PATCH 1/4] Staging: panel: spaces preferred around that '/'

2015-10-26 Thread Swetha
This patch fixes the checkpatch issue: CHECK: spaces preferred around that '/' Signed-off-by: Swetha --- drivers/staging/panel/panel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c

[PATCH 4/4] Staging: panel: Logical continuations should be on the previous line

2015-10-26 Thread Swetha
This patch fixes the checkpatch issue: CHECK: Logical continuations should be on the previous line Signed-off-by: Swetha --- drivers/staging/panel/panel.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/panel/panel.c

Re: [PATCH 3/4] Staging: panel: usleep_range is preferred over udelay

2015-10-26 Thread Sergei Shtylyov
Hello. On 10/26/2015 11:44 PM, Swetha wrote: This patch fixes the issue: CHECK: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt Signed-off-by: Swetha Full (and true) name needed here. --- drivers/staging/panel/panel.c |

[PATCH 0/4] Staging: panel: Fix checkpatch issues

2015-10-26 Thread Swetha
Swetha (4): Staging: panel: spaces preferred around that '/' Staging: panel: Removing multiple blank lines Staging: panel: usleep_range is preferred over udelay Staging: panel: Logical continuations should be on the previous line drivers/staging/panel/panel.c | 49

[PATCH 3/8] Staging : rdma ipath: spaces preferred around that '<<'

2015-10-26 Thread Swetha
This patch fixes the checkpatch issue: CHECK: spaces preferred around that '<<' Signed-off-by: Swetha --- drivers/staging/rdma/ipath/ipath_common.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rdma/ipath/ipath_common.h

[PATCH 1/8] Staging: rdma ipath: Removing multiple blank lines

2015-10-26 Thread Swetha
This patch fixes the checkpatch issue CHECK: Please don't use multiple blank lines Signed-off-by: Swetha --- drivers/staging/rdma/ipath/ipath_common.h | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/rdma/ipath/ipath_common.h

[PATCH 2/8] Staging: rdma ipath: __aligned(size) is preferred over __attribute__((aligned(size)))

2015-10-26 Thread Swetha
This patch fixes the checkpatch issue: WARNING: __aligned(size) is preferred over __attribute__((aligned(size))) Signed-off-by: Swetha --- drivers/staging/rdma/ipath/ipath_common.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH] usb: dwc2: host: Fix ahbcfg for rk3066

2015-10-26 Thread John Youn
On 10/20/2015 4:35 PM, Douglas Anderson wrote: > The comment for ahbcfg for rk3066 parameters (also used for rk3288) > claimed that ahbcfg was INCR16, but it wasn't. Since the bits weren't > shifted properly, the 0x7 ended up being masked and we ended up > programming 0x3 for the HBstLen. Let's

RE: [PATCH v3 1/7] usb: host: xhci: fix hcd private size

2015-10-26 Thread Yoshihiro Shimoda
Hi, > From: Felipe Balbi [mailto:ba...@ti.com] > Sent: Monday, October 26, 2015 11:27 PM > > Hi, > > Yoshihiro Shimoda writes: > > This patch fixes the hcd private size to sutabile size. > >

[PATCH 3/4] Staging: panel: usleep_range is preferred over udelay

2015-10-26 Thread Swetha
This patch fixes the issue: CHECK: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt Signed-off-by: Swetha --- drivers/staging/panel/panel.c | 34 +++--- 1 file changed, 19 insertions(+), 15 deletions(-)

[PATCH 2/4] Staging: panel: Removing multiple blank lines

2015-10-26 Thread Swetha
This patch fixes the checkpatch issue CHECK: Please don't use multiple blank lines Signed-off-by: Swetha --- drivers/staging/panel/panel.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c index

Re: [PATCH v4 4/7] usb: gadget: f_midi: fix leak on failed to enqueue out requests

2015-10-26 Thread Robert Baldyga
On 10/26/2015 05:55 PM, Felipe F. Tonello wrote: > This patch fixes a memory leak that occurs when an endpoint fails to enqueue > the request. If that happens the complete function will never be called, thus > never freeing the request. > > Signed-off-by: Felipe F. Tonello

[PATCH 5/8] Staging: rdma ipath: Fix space before tabs, line over 80 characters

2015-10-26 Thread Swetha
This patch fixes: CHECK: no space before tabs WARNING: line over 80 characters Signed-off-by: Swetha --- drivers/staging/rdma/ipath/ipath_common.h | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git

[PATCH 7/8] Staging: rdma ipath: No space is necessary after a cast

2015-10-26 Thread Swetha
This patch fixes the issue: CHECK: No space is necessary after a cast Signed-off-by: Swetha --- drivers/staging/rdma/ipath/ipath_cq.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/rdma/ipath/ipath_cq.c

[PATCH 8/8] Staging: rdma ipath: braces should be used on all arms

2015-10-26 Thread Swetha
Fix all instances of the following checkpatch.pl check: CHECK: braces {} should be used on all arms of this statement Signed-off-by: Swetha --- drivers/staging/rdma/ipath/ipath_cq.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git

[PATCH 6/8] Staging: rdma ipath: 'explict' misspelled

2015-10-26 Thread Swetha
Fix: CHECK: 'explict' may be misspelled - perhaps 'explicit'? Signed-off-by: Swetha --- drivers/staging/rdma/ipath/ipath_common.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rdma/ipath/ipath_common.h

[PATCH 4/8] Staging : rdma ipath: "foo * bar" should be "foo *bar"

2015-10-26 Thread Swetha
This patch fixes: ERROR: "foo * bar" should be "foo *bar" Signed-off-by: Swetha --- drivers/staging/rdma/ipath/ipath_common.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rdma/ipath/ipath_common.h

Re: [GIT PULL] On-demand device probing

2015-10-26 Thread Rafael J. Wysocki
On Mon, Oct 26, 2015 at 11:51 AM, Michael Turquette wrote: > Quoting Rafael J. Wysocki (2015-10-25 06:54:39) >> On Sun, Oct 25, 2015 at 12:06 AM, Mark Brown wrote: >> > On Sat, Oct 24, 2015 at 04:17:12PM +0200, Rafael J. Wysocki wrote: >> > >> >>

[PATCH v4 1/7] usb: host: xhci: cleanup hcd private size

2015-10-26 Thread Yoshihiro Shimoda
This patch cleanups the hcd private size to suitable size. The previous code has "sizeof(struct xhci_hcd *)" in xhci_hc_driver as hcd_priv_size and sizeof(struct xhci_hcd) in xhci_plat_overrides or xhci_pci_overrides as extra_priv_size. However, the xhci driver uses a "sizeof(struct xhcd_hcd)"

[PATCH v4 0/7] usb: host: xhci-plat: add support for the R-Car M2-N and H3 xHCI controllers

2015-10-26 Thread Yoshihiro Shimoda
This patch set adds support for R-Car M2-N (r8a7793) and H3 (r8a7795) xHCI controllers. To add support these new SoCs, this patch set adds a new member "priv" in struct xhci_hcd. This patch is based on the latest usb.git / usb-next branch. (The commit id =

[PATCH v4 5/7] usb: host: xhci-rcar: Change code for new SoCs

2015-10-26 Thread Yoshihiro Shimoda
This patch changes code to ease the addition of next generation SoCs. Signed-off-by: Yoshihiro Shimoda --- drivers/usb/host/xhci-plat.c | 1 + drivers/usb/host/xhci-rcar.c | 37 +++-- drivers/usb/host/xhci-rcar.h | 2 ++ 3

[PATCH v4 4/7] usb: host: xhci-plat: add firmware_name in xhci_plat_priv

2015-10-26 Thread Yoshihiro Shimoda
This patch adds a member "firmware_name" in struct xhci_plat_priv to simplify the code to match specific firmware name. Signed-off-by: Yoshihiro Shimoda --- drivers/usb/host/xhci-plat.h | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH v4 7/7] usb: host: xhci-plat: add support for the R-Car H3 xHCI controllers

2015-10-26 Thread Yoshihiro Shimoda
The R-Car H3 has two xHCI controllers. This SoC is compatible with R-Car Gen2 SoCs, however this SoC doesn't need some specific registers setting, and need a new firmware. Signed-off-by: Yoshihiro Shimoda --- Documentation/devicetree/bindings/usb/usb-xhci.txt |

[PATCH v4 6/7] usb: host: xhci-plat: add support for the R-Car M2-N xHCI controller

2015-10-26 Thread Yoshihiro Shimoda
This patch adds support for R-Car M2-N (r8a7793) xHCI controller. This SoC is compatible with R-Car H2 (r8a7790) and R-Car M2-W (r8a7791). Signed-off-by: Yoshihiro Shimoda --- Documentation/devicetree/bindings/usb/usb-xhci.txt | 4 ++--

[PATCH v4 3/7] usb: host: xhci-plat: add struct xhci_plat_priv

2015-10-26 Thread Yoshihiro Shimoda
This patch adds struct xhci_plat_priv to simplify the code to match platform specific variables. For now, this patch adds a member "type" in the structure. Signed-off-by: Yoshihiro Shimoda --- drivers/usb/host/xhci-plat.c | 73

[PATCH v4 2/7] usb: host: xhci: add a platform-private field

2015-10-26 Thread Yoshihiro Shimoda
This patch adds an xhci->priv field for private use by XHCI platform drivers. Until now none of the platform drivers has used this private space. Signed-off-by: Yoshihiro Shimoda --- drivers/usb/host/xhci.h | 3 +++ 1 file changed, 3 insertions(+) diff --git

Re: [PATCH v4 1/7] usb: gadget: f_midi: Transmit data only when IN ep is enabled

2015-10-26 Thread Robert Baldyga
Hi Felipe, On 10/26/2015 05:55 PM, Felipe F. Tonello wrote: > This makes sure f_midi doesn't try to enqueue data when the IN endpoint is > disabled, ie, USB cable is disconnected. > > Signed-off-by: Felipe F. Tonello > --- > drivers/usb/gadget/function/f_midi.c | 7

Re: [PATCH v4 1/7] usb: gadget: f_midi: Transmit data only when IN ep is enabled

2015-10-26 Thread Felipe Tonello
Hi Robert, On Mon, Oct 26, 2015 at 10:13 PM, Robert Baldyga wrote: > Hi Felipe, > > On 10/26/2015 05:55 PM, Felipe F. Tonello wrote: >> This makes sure f_midi doesn't try to enqueue data when the IN endpoint is >> disabled, ie, USB cable is disconnected. >> >>

Re: [PATCH v4 4/7] usb: gadget: f_midi: fix leak on failed to enqueue out requests

2015-10-26 Thread Felipe Tonello
Hi Robert, On Mon, Oct 26, 2015 at 10:23 PM, Robert Baldyga wrote: > On 10/26/2015 05:55 PM, Felipe F. Tonello wrote: >> This patch fixes a memory leak that occurs when an endpoint fails to enqueue >> the request. If that happens the complete function will never be

Re: [PATCH 0/4] Patches to fix remote wakeup on rk3288 dwc2 "host" port

2015-10-26 Thread Rob Herring
On Sat, Oct 24, 2015 at 4:22 PM, Doug Anderson wrote: > Rob, > > On Sat, Oct 24, 2015 at 11:10 AM, Rob Herring wrote: >> On 10/23/2015 01:28 PM, Douglas Anderson wrote: >>> The "host1" port (AKA the dwc2 port that isn't the OTG port) on rk3288 >>> has a

Re: [PATCHv2] usb: dwc2: use devm_phy_optional_get

2015-10-26 Thread John Youn
On 10/26/2015 2:29 AM, Alexander Aring wrote: > This patch changes devm_phy_get to devm_phy_optional_get. Which fixes the > error handling when trying to get the phy. Currently on all errors we > try to look for an old style USB PHY. With this patch we try to look for > an old USB PHY when

Re: [PATCH v4 5/7] usb: gadget: f_midi: set altsettings only for MIDIStreaming interface

2015-10-26 Thread Robert Baldyga
On 10/26/2015 05:55 PM, Felipe F. Tonello wrote: > This avoids duplication of USB requests for OUT endpoint and > re-enabling endpoints. > > Signed-off-by: Felipe F. Tonello > --- > drivers/usb/gadget/function/f_midi.c | 4 > 1 file changed, 4 insertions(+) > >

Re: [Outreachy kernel] [PATCH 1/8] Staging: rdma ipath: Removing multiple blank lines

2015-10-26 Thread Ksenija Stanojević
Hi Swetha, On Mon, Oct 26, 2015 at 3:36 PM, Swetha wrote: > This patch fixes the checkpatch issue > > CHECK: Please don't use multiple blank lines > > Signed-off-by: Swetha ^^^ Here you need to write your full

Re: [PATCH v4 5/7] usb: gadget: f_midi: set altsettings only for MIDIStreaming interface

2015-10-26 Thread Felipe Tonello
Hi Robert, On Mon, Oct 26, 2015 at 10:30 PM, Robert Baldyga wrote: > On 10/26/2015 05:55 PM, Felipe F. Tonello wrote: >> This avoids duplication of USB requests for OUT endpoint and >> re-enabling endpoints. >> >> Signed-off-by: Felipe F. Tonello

Re: [PATCH 0/4] Patches to fix remote wakeup on rk3288 dwc2 "host" port

2015-10-26 Thread Doug Anderson
Rob, On Mon, Oct 26, 2015 at 4:05 PM, Rob Herring wrote: >>> A DT reset controller seems like a bit of an overkill here. I think this >>> would be much more simple if we just add a phy reset hook to the phy >>> subsystem. >> >> Adding a reset hook in the PHY subsystem does seem

Re: [PATCHv2] usb: dwc2: use devm_phy_optional_get

2015-10-26 Thread Stephen Warren
On 10/26/2015 03:28 AM, Alexander Aring wrote: > This patch changes devm_phy_get to devm_phy_optional_get. Which fixes the > error handling when trying to get the phy. Currently on all errors we > try to look for an old style USB PHY. With this patch we try to look for > an old USB PHY when

Re: [REPOST PATCH 0/3] dwc2 patches to allow wakeup on Rockchip rk3288

2015-10-26 Thread John Youn
On 10/21/2015 9:23 AM, Doug Anderson wrote: > John, > > On Mon, Jul 6, 2015 at 11:27 AM, Douglas Anderson > wrote: >> This series of patches, together with >> from Chris Zhong and a >> dts change allow us to wake up from a USB

Re: [RESEND PATCH] usb: remove unnecessary CONFIG_PM dependency from USB_OTG

2015-10-26 Thread Peter Chen
On Mon, Oct 26, 2015 at 06:23:25PM -0500, Nathan Sullivan wrote: > The USB gadget support currently depends on power management Why you said gadget? The thing you change is for OTG. > (CONFIG_PM) being enabled, but does not actually need it enabled. > Remove this dependency. > > Tested on Bay

Re: [PATCH 0/4] Patches to fix remote wakeup on rk3288 dwc2 "host" port

2015-10-26 Thread Doug Anderson
Hi, On Mon, Oct 26, 2015 at 4:49 PM, Doug Anderson wrote: > One note: the "full" PHY reset is actually not in the register map of > the PHY. It is amazingly enough in the CRU (clock reset unit). So if > we actually exposed the "full" reset through the PHY framework, the

Re: [GIT PULL] On-demand device probing

2015-10-26 Thread Rafael J. Wysocki
On Tuesday, October 20, 2015 12:04:05 PM Alan Stern wrote: > On Tue, 20 Oct 2015, Mark Brown wrote: > > > On Tue, Oct 20, 2015 at 10:40:03AM -0400, Alan Stern wrote: > > > > > Furthermore, that applies only to devices that use synchronous suspend. > > > Async suspend is becoming common, and

Re: [PATCH] HID: usbhid: Add a quirk for Xin-Mo Dual Arcade

2015-10-26 Thread Michele Baldessari
Hi Olivier, On Mon, Oct 26, 2015 at 12:00:50PM +0100, Olivier Scherler wrote: > > On 24 oct. 2015, at 22:11, Jiri Kosina wrote: > > On Sat, 24 Oct 2015, Michele Baldessari wrote: > > > >> The Xin-Mo Dual Arcade controller (16c0:05e1) needs this quirk in order > >> to have the

Re: [GIT PULL] On-demand device probing

2015-10-26 Thread Tomeu Vizoso
On 26 October 2015 at 11:51, Michael Turquette wrote: > Quoting Rafael J. Wysocki (2015-10-25 06:54:39) >> On Sun, Oct 25, 2015 at 12:06 AM, Mark Brown wrote: >> > On Sat, Oct 24, 2015 at 04:17:12PM +0200, Rafael J. Wysocki wrote: >> > >> >> Well, I'm

Re: [PATCH v3 1/7] usb: host: xhci: fix hcd private size

2015-10-26 Thread Felipe Balbi
Hi, Yoshihiro Shimoda writes: > This patch fixes the hcd private size to sutabile size. suitable > The previous code has "sizeof(struct xhci_hcd *)" in

[PATCH v3 4/4] fs: configfs: Add unlocked version of configfs_depend_item()

2015-10-26 Thread Krzysztof Opasiak
This change is necessary for the SCSI target usb gadget composed with configfs. In this case configfs will be used for two different purposes: to compose a usb gadget and to configure the target part. If an instance of tcm function is created in $CONFIGFS_ROOT/usb_gadget//functions a tpg can be

[PATCH v3 1/4] fs: configfs: Drop unused parameter from configfs_undepend_item()

2015-10-26 Thread Krzysztof Opasiak
subsys parameter is never used by configfs_undepend_item() so there is no point in passing it to this function. Signed-off-by: Krzysztof Opasiak --- drivers/target/target_core_configfs.c |2 +- fs/configfs/dir.c |3 +-- include/linux/configfs.h

[PATCH v3 3/4] fs: configfs: Factor out configfs_find_subsys_dentry()

2015-10-26 Thread Krzysztof Opasiak
configfs_depend_item() is quite complicated and should be split up into smaller functions. This also allow to share this code with other functions. Signed-off-by: Krzysztof Opasiak --- fs/configfs/dir.c | 33 + 1 file changed, 21

Re: [PATCHv2 01/15] fs: configfs: Add unlocked version of configfs_depend_item()

2015-10-26 Thread Krzysztof Opasiak
Hi Christoph, On 10/23/2015 04:51 PM, Andrzej Pietrasiewicz wrote: W dniu 22.10.2015 o 17:22, Christoph Hellwig pisze: Hi Andrzej, please find a way to share code between the two depend function. And also drop the duplicate undepend version and just stop passing the unused subsystem

Re: [PATCH v3 1/4] fs: configfs: Drop unused parameter from configfs_undepend_item()

2015-10-26 Thread kbuild test robot
Hi Krzysztof, [auto build test ERROR on target/master -- if it's inappropriate base, please suggest rules for selecting the more suitable base] url: https://github.com/0day-ci/linux/commits/Krzysztof-Opasiak/fs-configfs-Drop-unused-parameter-from-configfs_undepend_item/20151026-232656

Re: Help needed for EHCI problem: removing an active bulk-in QH

2015-10-26 Thread Alan Stern
Michael: In the absence of any suggestions, we might as well try to verify my idea about what's going wrong. The patch below adds a little more debugging information; please try repeating the last test with this patch in place of the previous one. Alan Stern Index:

Re: [PATCH v3 1/4] fs: configfs: Drop unused parameter from configfs_undepend_item()

2015-10-26 Thread kbuild test robot
Hi Krzysztof, [auto build test WARNING on target/master -- if it's inappropriate base, please suggest rules for selecting the more suitable base] url: https://github.com/0day-ci/linux/commits/Krzysztof-Opasiak/fs-configfs-Drop-unused-parameter-from-configfs_undepend_item/20151026-232656

[PATCH v4 1/4] fs: configfs: Drop unused parameter from configfs_undepend_item()

2015-10-26 Thread Krzysztof Opasiak
subsys parameter is never used by configfs_undepend_item() so there is no point in passing it to this function. Signed-off-by: Krzysztof Opasiak --- Changes since v3: - fix build break in ocfs2 --- drivers/target/target_core_configfs.c |2 +- fs/configfs/dir.c

[PATCH v4 3/4] fs: configfs: Factor out configfs_find_subsys_dentry()

2015-10-26 Thread Krzysztof Opasiak
configfs_depend_item() is quite complicated and should be split up into smaller functions. This also allow to share this code with other functions. Signed-off-by: Krzysztof Opasiak --- fs/configfs/dir.c | 33 + 1 file changed, 21

[PATCH v4 2/4] fs: configfs: Factor out configfs_do_depend_item()

2015-10-26 Thread Krzysztof Opasiak
configfs_depend_item() is quite complicated and should be split up into smaller functions. This also allow to share this code with other functions. Signed-off-by: Krzysztof Opasiak --- fs/configfs/dir.c | 41 ++--- 1 file changed, 26

[PATCH v4 6/7] usb: gadget: gmidi: Cleanup legacy code

2015-10-26 Thread Felipe F. Tonello
Remove unnecessary headers and variables. Signed-off-by: Felipe F. Tonello --- drivers/usb/gadget/legacy/gmidi.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/usb/gadget/legacy/gmidi.c b/drivers/usb/gadget/legacy/gmidi.c index da19c48..055390b

[PATCH v4 5/7] usb: gadget: f_midi: set altsettings only for MIDIStreaming interface

2015-10-26 Thread Felipe F. Tonello
This avoids duplication of USB requests for OUT endpoint and re-enabling endpoints. Signed-off-by: Felipe F. Tonello --- drivers/usb/gadget/function/f_midi.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/usb/gadget/function/f_midi.c

[PATCH v4 7/7] usb: gadget: f_midi: pre-allocate IN requests

2015-10-26 Thread Felipe F. Tonello
This patch introduces pre-allocation of IN endpoint USB requests. This improves on latency (requires no usb request allocation on transmit) and avoid several potential probles on allocating too many usb requests (which involves DMA pool allocation problems). This implementation also handles

[PATCH v4 0/7] USB MIDI Gadget improvements and bug fixes

2015-10-26 Thread Felipe F. Tonello
Patch 7 has changes on how to transmit IN USB requests. It implements a FIFO of pre-allocated usb requests and uses then as needed, instead of allocating then on demand. This is my initial implementation and is open for suggestions and comments. Patches 1-6 is pretty much straight forward.

[PATCH v4 4/4] fs: configfs: Add unlocked version of configfs_depend_item()

2015-10-26 Thread Krzysztof Opasiak
This change is necessary for the SCSI target usb gadget composed with configfs. In this case configfs will be used for two different purposes: to compose a usb gadget and to configure the target part. If an instance of tcm function is created in $CONFIGFS_ROOT/usb_gadget//functions a tpg can be

[PATCH v4 1/7] usb: gadget: f_midi: Transmit data only when IN ep is enabled

2015-10-26 Thread Felipe F. Tonello
This makes sure f_midi doesn't try to enqueue data when the IN endpoint is disabled, ie, USB cable is disconnected. Signed-off-by: Felipe F. Tonello --- drivers/usb/gadget/function/f_midi.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git

[PATCH v4 3/7] usb: gadget: define free_ep_req as universal function

2015-10-26 Thread Felipe F. Tonello
This function is shared between gadget functions, so this avoid unnecessary duplicated code and potentially avoid memory leaks. Signed-off-by: Felipe F. Tonello --- drivers/usb/gadget/function/f_midi.c | 6 -- drivers/usb/gadget/function/f_sourcesink.c | 6

[PATCH v4 2/7] usb: gadget: f_midi: remove duplicated code

2015-10-26 Thread Felipe F. Tonello
This code is duplicated from f_midi_start_ep(midi, f, midi->out_ep). Signed-off-by: Felipe F. Tonello --- drivers/usb/gadget/function/f_midi.c | 20 1 file changed, 20 deletions(-) diff --git a/drivers/usb/gadget/function/f_midi.c

[PATCH v4 4/7] usb: gadget: f_midi: fix leak on failed to enqueue out requests

2015-10-26 Thread Felipe F. Tonello
This patch fixes a memory leak that occurs when an endpoint fails to enqueue the request. If that happens the complete function will never be called, thus never freeing the request. Signed-off-by: Felipe F. Tonello --- drivers/usb/gadget/function/f_midi.c | 1 + 1 file