[PATCH v2 2/3] doc: dt-binding: generic onboard USB HUB

2015-12-13 Thread Peter Chen
Add dt-binding documentation for generic onboard USB HUB. Signed-off-by: Peter Chen --- .../devicetree/bindings/usb/generic-onboard-hub.txt | 20 1 file changed, 20 insertions(+) create mode 100644 Documentation/devicetree/bindings/usb/generic-onboard-hub.txt diff --git

[PATCH v2 3/3] ARM: dts: imx6qdl-udoo.dtsi: fix onboard USB HUB property

2015-12-13 Thread Peter Chen
The current dts describes USB HUB's property at USB controller's entry, it is improper. Fix it by using a generic USB HUB entry. Signed-off-by: Peter Chen --- arch/arm/boot/dts/imx6qdl-udoo.dtsi | 26 +++--- 1 file changed, 7 insertions(+), 19 deletions(-) diff --git a/arch/

[PATCH v2 1/3] usb: misc: generic_onboard_hub: add generic onboard USB HUB driver

2015-12-13 Thread Peter Chen
Current USB HUB driver lacks of platform interfaces to configure external signal on HUB chip, eg, the PHY input clock and gpio reset pin for HUB, these kinds of HUBs are usually soldered at the board, and they are not hot-plug USB devices. With this patch, the user can configure the HUB's pins at

[PATCH v2 0/3] USB: add generic onboard USB HUB driver

2015-12-13 Thread Peter Chen
Changes for v2: - Delete platform data support for this driver - Delete '#define DEBUG' - Add "clock-frequency" entry for clock setting support - Set hub_data->clk as NULL if clk is nonexist, it can simply operation for optional clocks. - Delete gpio polarity entry, the polarity can passed by dts

[PATCH v2] usb: gadget: forbid queuing request to a disabled ep

2015-12-13 Thread changbin . du
From: "Du, Changbin" Queue a request to disabled ep doesn't make sense, and induce caller make mistakes. Here is a example for the android mtp gadget function driver. A mem corruption can happen on below senario. 1) On disconnect, mtp driver disable its EPs, 2) During send_file_work and receive

[PATCH v2] usb: gadget: make usb_ep_enable return -EBUSY if ep has already enabled

2015-12-13 Thread changbin . du
From: "Du, Changbin" When usb_ep_enable on a enabled ep, the configuration of the ep probably has changed. In this scenario, the ep configuration in hw should be reprogrammed by udc driver. Hence, it is better to return an error to inform the caller. Signed-off-by: Du, Changbin --- change from

RE: [PATCH 1/2] usb: dwc2: add ep enabled flag to avoid double enable/disable

2015-12-13 Thread Du, Changbin
Hi, Balbi, Please ignore this patch set. Because we have a fix in gadget API layer. [PATCH] usb: gadget: forbid queuing request to a disabled ep > > Enabling an already enabled ep is illegal, because the ep may has trbs > > running. Reprogram the ep may break running transfer. So udc driver > > mu

RE: [PATCH] usb: gadget: make usb_ep_enable return -EBUSY if ep has already enabled

2015-12-13 Thread Du, Changbin
> > When usb_ep_enable on a enabled ep, the configuration of the ep > probably > > has changed. In this scenario, the ep configuration in hw should be > > reprogrammed by udc driver. Hence, it is better to return an error to > > inform the caller. > > > > Signed-off-by: Du, Changbin > > --- > > i

Re: [PATCH v2] extcon: add Maxim MAX3355 driver

2015-12-13 Thread Rob Herring
On Sat, Dec 12, 2015 at 02:22:06AM +0300, Sergei Shtylyov wrote: > Maxim Integrated MAX3355E chip integrates a charge pump and comparators to > enable a system with an integrated USB OTG dual-role transceiver to function > as an USB OTG dual-role device. In addition to sensing/controlling Vbu

Re: [PATCH v2 2/3] ehci-platform: Add support for controllers with multiple reset lines

2015-12-13 Thread Rob Herring
On Fri, Dec 11, 2015 at 04:41:59PM +0100, Hans de Goede wrote: > From: Reinder de Haan > > At least the EHCI/OHCI found on the Allwinnner H3 SoC needs multiple > reset lines, the controller will not initialize while the reset for > its companion is still asserted, which means we need to de-assert

Re: [PATCH v2 3/3] ohci-platform: Add support for controllers with multiple reset lines

2015-12-13 Thread Rob Herring
On Fri, Dec 11, 2015 at 04:42:00PM +0100, Hans de Goede wrote: > At least the EHCI/OHCI found on the Allwinnner H3 SoC needs multiple > reset lines, the controller will not initialize while the reset for > its companion is still asserted, which means we need to de-assert > 2 resets for the controll

Re: [PATCH v4 2/2] phy-sun4i-usb: Add support for the host usb-phys found on the H3 SoC

2015-12-13 Thread Rob Herring
On Fri, Dec 11, 2015 at 04:32:18PM +0100, Hans de Goede wrote: > From: Reinder de Haan > > Note this commit only adds support for phys 1-3, phy 0, the otg phy, is > not yet (fully) supported after this commit. > > Signed-off-by: Reinder de Haan > Signed-off-by: Hans de Goede Acked-by: Rob Her

[PATCH v2 3/3] USB: serial: cp210x: New register access functions for large registers

2015-12-13 Thread Konstantin Shkolnyy
cp210x_get_config and cp210x_set_config are cumbersome to use. This change switches large register access to use new block functions. The old functions are removed because now they become unused. Signed-off-by: Konstantin Shkolnyy --- drivers/usb/serial/cp210x.c | 137 ---

[PATCH v2 2/3] USB: serial: cp210x: New 8-bit and 32-bit register access functions.

2015-12-13 Thread Konstantin Shkolnyy
cp210x_get_config and cp210x_set_config are cumbersome to use. This change introduces new register access functions for 8 and 32-bit values, instead of the above functions. Signed-off-by: Konstantin Shkolnyy --- drivers/usb/serial/cp210x.c | 92 ++--- 1 fi

[PATCH v2 1/3] USB: serial: cp210x: New 16-bit register access functions.

2015-12-13 Thread Konstantin Shkolnyy
cp210x_get_config and cp210x_set_config are cumbersome to use. This change introduces new register access functions for 16-bit values, instead of the above functions. Signed-off-by: Konstantin Shkolnyy --- drivers/usb/serial/cp210x.c | 155 +++- 1 file cha

Re: USB3 xHCI Error, unable to acces the disk

2015-12-13 Thread Sébastien Deligny
I've sent the logfile on Saturday, but I can't find my message in the archive, move to spam? So here is the logfile simply past as text : [0.00] Initializing cgroup subsys cpuset [0.00] Initializing cgroup subsys cpu [0.00] Initializing cgroup subsys cpuacct [0.00]

[PATCH v3 03/10] usb: host: ehci-sched: remove useless initializations

2015-12-13 Thread Geyslan G. Bem
This patch removes useless initializations. Tested by compilation only. Caught by cppcheck. Signed-off-by: Geyslan G. Bem --- v2: replaces 'assignments' with 'initializations' --- drivers/usb/host/ehci-sched.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb

[PATCH v3 01/10] usb: host: ehci-sched: refactor scan_isoc function

2015-12-13 Thread Geyslan G. Bem
This patch removes an infinite 'for' loop and makes use of the already existing 'restart' tag instead, reducing one leading tab. The comments and code were corrected conforming file coding style. Tested by compilation only. Caught by checkpatch: WARNING: Too many leading tabs - consider code ref

[PATCH v3 05/10] usb: host: ehci-sched: remove prohibited spaces

2015-12-13 Thread Geyslan G. Bem
This patch removes prohibited spaces before open parenthesis and open brackets. It also removes an assignment inside condition and unnecessary braces in single statement block. Tested by compilation only. Caught by checkpatch. Signed-off-by: Geyslan G. Bem --- drivers/usb/host/ehci-sched.c | 2

[PATCH v3 02/10] usb: host: ehci-sched: move constants to right

2015-12-13 Thread Geyslan G. Bem
This patch moves the constants to right. Tested by compilation only. Caught by coccinelle: scripts/coccinelle/misc/compare_const_fl.cocci Signed-off-by: Geyslan G. Bem --- drivers/usb/host/ehci-sched.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/host/eh

[PATCH v3 04/10] usb: host: ehci-sched: add spaces around operators

2015-12-13 Thread Geyslan G. Bem
This patch adds spaces around operators. Tested by compilation only. Caught by checkpatch. Signed-off-by: Geyslan G. Bem --- drivers/usb/host/ehci-sched.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/ehci-sched.c b/drivers/usb/host/ehci-sched.c index 4d4c

[PATCH v3 07/10] usb: host: ehci-sched: use C89-style comments

2015-12-13 Thread Geyslan G. Bem
This patch changes comments conforming coding style. Caught by checkpatch. Signed-off-by: Geyslan G. Bem --- drivers/usb/host/ehci-sched.c | 26 ++ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/drivers/usb/host/ehci-sched.c b/drivers/usb/host/ehci-sched

[PATCH v3 09/10] usb: host: ehci-sched: use sizeof operator with parens

2015-12-13 Thread Geyslan G. Bem
This patch adds parens to sizeof operator uses. Tested by compilation only. Caught by checkpatch. Signed-off-by: Geyslan G. Bem --- drivers/usb/host/ehci-sched.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/usb/host/ehci-sched.c b/drivers/usb/host/ehci-sch

[PATCH v3 08/10] usb: host: ehci-sched: add line after declarations

2015-12-13 Thread Geyslan G. Bem
This patch adds a blank line after declarations. Caught by checkpatch. Signed-off-by: Geyslan G. Bem --- drivers/usb/host/ehci-sched.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/host/ehci-sched.c b/drivers/usb/host/ehci-sched.c index 2705c0b..d62d2fe 100644 --- a/drivers/

[PATCH v3 10/10] usb: host: ehci-sched: remove unnecessary braces

2015-12-13 Thread Geyslan G. Bem
This patch removes unnecessary braces in single statement blocks at the same time as replaces the if statement with a ternary conditional. Tested by compilation only. Caught by checkpatch. Signed-off-by: Geyslan G. Bem --- v2: removes unnecessary parens in ternary conditional. --- drivers/usb

[PATCH v3 00/10] usb: host: ehci-sched: cleanup

2015-12-13 Thread Geyslan G. Bem
Cleanup done with the help of coccinelle, checkpatch and cppcheck tools. Geyslan G. Bem (10): usb: host: ehci-sched: refactor scan_isoc function usb: host: ehci-sched: move constants to right usb: host: ehci-sched: remove useless initializations usb: host: ehci-sched: add spaces around ope

[PATCH v3 06/10] usb: host: ehci-sched: remove useless else branch

2015-12-13 Thread Geyslan G. Bem
This patch removes an useless else branch after a break, reducing one indent block. Tested by compilation only. Caught by checkpatch. Signed-off-by: Geyslan G. Bem --- drivers/usb/host/ehci-sched.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/usb/host/ehci-sc

Re: [PATCH v2 01/10] usb: host: ehci-sched: refactor scan_isoc function

2015-12-13 Thread Geyslan G. Bem
2015-12-13 12:29 GMT-03:00 Alan Stern : > On Sun, 13 Dec 2015, Geyslan G. Bem wrote: > >> This patch removes an infinite 'for' loop and makes use of the already >> existing 'restart' tag instead, reducing one leading tab. >> >> It also puts the easier evaluation (live variable) to be the first in >

Re: [PATCH v2 01/10] usb: host: ehci-sched: refactor scan_isoc function

2015-12-13 Thread Alan Stern
On Sun, 13 Dec 2015, Geyslan G. Bem wrote: > This patch removes an infinite 'for' loop and makes use of the already > existing 'restart' tag instead, reducing one leading tab. > > It also puts the easier evaluation (live variable) to be the first in > two conditionals. > > if (live && frame ==