Re: Fwd: USB gadget driver issue

2016-02-29 Thread Olivier Schonken
Hi Felipe As far as I could see in Systemd, getty PID changes, so the SIGHUP should be received to close getty. The re-opening of the port with getty is when the issues begin. Regards Olivier Schonken On 1 March 2016 at 09:27, Felipe Balbi wrote: > > Hi, > > Robert

Re: Fwd: USB gadget driver issue

2016-02-29 Thread Felipe Balbi
Hi, Robert Baldyga writes: >> Olivier Schonken writes: >>> Hope I'm not raising an issue which actually is my own stupidity. >>> >>> I recently upstreamed my embedded Linux kernel to version 4.4, after which >>> I started experiencing issues

Re: Fwd: USB gadget driver issue

2016-02-29 Thread Olivier Schonken
Hi Robert I may have used very bad language to describe the problem "hang up". A better description would be to say that when connecting to the ttyACM gadget via a terminal, it works at startup, but if the usb device is plugged out, and back in again, comms with it is unresponsive, regardless of

Spurious Mass Storage Device Resets

2016-02-29 Thread Rian Hunter
Hello, I own a JBOD SATA<->USB 3.0 bridge. All information about this device and my kernel version is below. My trouble is that every so often this device will undergo a virtual USB disconnect and then be reconnected. This will cause all drives to disappear and reappear on the system. All

RE: [PATCH v1] usb: dwc3: gadget: sanity check for usb request complete function in ep_enqueue and giveback function.

2016-02-29 Thread Tang, Jianqiang
Hi Balbi, Sorry late response due to some other issues. 1> Yes, I agree this is one gadget driver bug. Current gadget framework do not have any check about this usb_request->complete pointer per my understanding. I think we should add some check in dwc3 OR gadget API like usb_ep_queue()

Re: [PATCH] usb: dwc2: Add support for Lantiq ARX and XRX SoCs

2016-02-29 Thread John Youn
On 2/27/2016 2:32 AM, Antti Seppälä wrote: > Add support for Lantiq ARX and XRX SoC families to the dwc2 driver. > > Signed-off-by: Antti Seppälä > --- > Documentation/devicetree/bindings/usb/dwc2.txt | 2 ++ > drivers/usb/dwc2/platform.c| 34 >

[PATCH] Fix static analysis issues

2016-02-29 Thread John Youn
Hi Felipe, This can be applied to next after 4.5-rc6. Thanks, John John Youn (1): usb: dwc2: Fix issues in dwc2_complete_non_isoc_xfer_ddma() drivers/usb/dwc2/hcd_ddma.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) -- 2.6.3 -- To unsubscribe from this list: send the line

[PATCH] usb: dwc2: Fix issues in dwc2_complete_non_isoc_xfer_ddma()

2016-02-29 Thread John Youn
Fixes a static analysis issue in dwc2_complete_non_isoc_xfer_ddma(). The qtd was being passed to a function after being freed. It was not being used in the function so this doesn't fix any bugs. But it fixes up the warning and makes the code safer by setting qtd to NULL and not using it at all.

Re: OHCI unplug kernel crash in kernel 4.3, 4.4 and 4.5

2016-02-29 Thread Joerg Roedel
Hi Stefani, On Mon, Feb 29, 2016 at 06:43:54PM +0100, Stefani Seibold wrote: > It seems that this patch solve the problem. This is the kernel log with > your patch together with the one from alan. Great, thanks for testing the fix. I queued it as a patch to my iommu/fixes branch and send it

Re: [PATCH] Revert "USB: serial: add Moxa UPORT 11x0 driver"

2016-02-29 Thread Greg KH
On Mon, Feb 29, 2016 at 06:56:02PM +0100, Johan Hovold wrote: > This reverts commit 0b2b093ad405b56a9e6f4f20a25da77ebfa9549c. > > Turns out the MOXA vendor driver was basically just a copy of the > ti_usb_3410_5052 driver. We don't want two drivers for the same chip > even if mxu11x0 had gotten

Re: "reset full-speed USB device number 6 using ehci-pci" with Dell Inspiron 15R 5537

2016-02-29 Thread Daniel Fraga
On Mon, 29 Feb 2016 16:28:40 -0500 (EST) Alan Stern wrote: > Okay, that's what I had guessed. Somehow usbhid->urbin is getting set > to NULL. Maybe the patch below will indicate why. When you post the > log, include everything that mentions the 3-1.6 device --

Re: "reset full-speed USB device number 6 using ehci-pci" with Dell Inspiron 15R 5537

2016-02-29 Thread Alan Stern
On Wed, 24 Feb 2016, Daniel Fraga wrote: > On Wed, 24 Feb 2016 14:24:44 -0500 (EST) > Alan Stern wrote: > > > I intended the patch not to cause any call traces, but it did anyway. > > So let's drop the questionable code and try something that will be > > completely

Re: [PATCH v3 4/4] leds: core: add support for RGB LED's

2016-02-29 Thread Heiner Kallweit
Am 29.02.2016 um 10:57 schrieb Jacek Anaszewski: > On 02/26/2016 11:36 PM, Heiner Kallweit wrote: >> Am 25.02.2016 um 13:40 schrieb Jacek Anaszewski: >>> On 02/23/2016 09:27 PM, Heiner Kallweit wrote: Am 19.02.2016 um 14:59 schrieb Jacek Anaszewski: > Hi Heiner, > > On 02/18/2016

Re: [PATCH 3/3] usb: musb: sunxi: support module autoloading

2016-02-29 Thread Javier Martinez Canillas
Hello Emilio, On Sun, Feb 21, 2016 at 10:26 PM, Emilio López wrote: > From: Emilio López > > MODULE_DEVICE_TABLE() is missing, so the module isn't auto-loading on > sunxi systems using the OTG controller. This commit adds the missing > line so

Re: [PATCH 2/3] dmaengine: sun4i: support module autoloading

2016-02-29 Thread Javier Martinez Canillas
Hello Emilio, On Sun, Feb 21, 2016 at 10:26 PM, Emilio López wrote: > From: Emilio López > > MODULE_DEVICE_TABLE() is missing, so the module isn't auto-loading on > supported systems. This commit adds the missing line so it loads >

Re: [PATCH 1/3] [media] rc: sunxi-cir: support module autoloading

2016-02-29 Thread Javier Martinez Canillas
Hello Emilio, On Sun, Feb 21, 2016 at 10:26 PM, Emilio López wrote: > From: Emilio López > > MODULE_DEVICE_TABLE() is missing, so the module isn't auto-loading on > systems supporting infrared. This commit adds the missing line so it > works

Re: [PATCH 2/5 v7] usb: musb: core: added helper functions for parsing DT

2016-02-29 Thread Bin Liu
Hi, On Mon, Feb 29, 2016 at 10:20:55AM +0100, Petr Kulhavy wrote: > > > On 26.02.2016 15:23, Bin Liu wrote: > >Hi, > > > >On Fri, Feb 26, 2016 at 10:29:12AM +0100, Petr Kulhavy wrote: > >>On 26.02.2016 04:15, Bin Liu wrote: > >>>On Thu, Feb 25, 2016 at 01:04:13PM +0100, Petr Kulhavy wrote: >

Re: [PATCH v2] USB: serial: option: add support for Quectel UC20

2016-02-29 Thread Johan Hovold
On Mon, Feb 29, 2016 at 04:39:57PM +0100, yegorsli...@googlemail.com wrote: > From: Yegor Yefremov > > Blacklist the QMI interface. > > Signed-off-by: Yegor Yefremov > --- > Changes: > v2: blacklist QMI interface Now applied with

Re: [PATCH v2 1/1] usb: serial: option: Adding support for Telit LE922 PID 0x1045

2016-02-29 Thread Johan Hovold
On Mon, Feb 29, 2016 at 03:36:11PM +0100, Daniele Palmas wrote: > This patch adds support for 0x1045 PID of Telit LE922. > > Signed-off-by: Daniele Palmas Now applied, thanks. Johan -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a

Re: use after free of bos pointer in usb_reset_and_verify_device?

2016-02-29 Thread Joe Lawrence
On 02/29/2016 11:41 AM, Greg KH wrote: > On Mon, Feb 29, 2016 at 11:06:55AM -0500, Joe Lawrence wrote: >> Hi Alan, Changbin, Xenia, >> >> I've twice encountered a crash on system reboot in usb_disable_device >> that looks to be a bos descriptor use-after-free. >> >> The machine in question is

[PATCH] Revert "USB: serial: add Moxa UPORT 11x0 driver"

2016-02-29 Thread Johan Hovold
This reverts commit 0b2b093ad405b56a9e6f4f20a25da77ebfa9549c. Turns out the MOXA vendor driver was basically just a copy of the ti_usb_3410_5052 driver. We don't want two drivers for the same chip even if mxu11x0 had gotten some much needed clean up before merge. So let's remove the mxu11x0

Re: OHCI unplug kernel crash in kernel 4.3, 4.4 and 4.5

2016-02-29 Thread Stefani Seibold
Am Montag, den 29.02.2016, 18:07 +0100 schrieb Joerg Roedel: > On Mon, Feb 29, 2016 at 10:36:07AM -0500, Alan Stern wrote: > > > > The lines added by the patch were never executed.  This means that > > dev->archdata.iommu is getting set to NULL some place other than > > unlink_domain_info().  I

Re: OHCI unplug kernel crash in kernel 4.3, 4.4 and 4.5

2016-02-29 Thread Joerg Roedel
On Mon, Feb 29, 2016 at 10:36:07AM -0500, Alan Stern wrote: > The lines added by the patch were never executed. This means that > dev->archdata.iommu is getting set to NULL some place other than > unlink_domain_info(). I have no idea where that would be. > > Joerg, can you suggest any

Re: problems with cp210x

2016-02-29 Thread walter harms
I am aware of it, the system is a prototype and they wanted to stay with something they know. I will ask for am update. re, wh Am 29.02.2016 17:10, schrieb Greg KH: > On Mon, Feb 29, 2016 at 02:47:45PM +0100, walter harms wrote: >> Hello List, >> >> is someone aware of a problem with DTR in

Re: use after free of bos pointer in usb_reset_and_verify_device?

2016-02-29 Thread Greg KH
On Mon, Feb 29, 2016 at 11:06:55AM -0500, Joe Lawrence wrote: > Hi Alan, Changbin, Xenia, > > I've twice encountered a crash on system reboot in usb_disable_device > that looks to be a bos descriptor use-after-free. > > The machine in question is running a 4.5-rc5 kernel Please use 4.5-rc6, a

use after free of bos pointer in usb_reset_and_verify_device?

2016-02-29 Thread Joe Lawrence
Hi Alan, Changbin, Xenia, I've twice encountered a crash on system reboot in usb_disable_device that looks to be a bos descriptor use-after-free. The machine in question is running a 4.5-rc5 kernel with proprietary and out-of-tree Stratus drivers that facilitate device-removal testing -- these

Re: [PATCH 14/14] uas: fix race with TMF performing an abort and regular finish

2016-02-29 Thread Hans de Goede
Hi, On 17-02-16 16:50, Oliver Neukum wrote: A successful TMF means that the URBs for a command must be killed. Also fixes sleeping with a spinlock. Signed-off-by: Oliver Neukum --- drivers/usb/storage/uas.c | 35 --- 1 file changed, 16

Re: problems with cp210x

2016-02-29 Thread Greg KH
On Mon, Feb 29, 2016 at 02:47:45PM +0100, walter harms wrote: > Hello List, > > is someone aware of a problem with DTR in that driver ? > > I use: Linux version 3.4.53-MMI-SW.401_0.1-43 That's a very old and obsolete kernel version. Please ask for support from the vendor that is forcing you to

Re: Fwd: USB gadget driver issue

2016-02-29 Thread Robert Baldyga
Hi Oliver, On 02/29/2016 08:34 AM, Felipe Balbi wrote: > > Hi, > > Olivier Schonken writes: >> Hope I'm not raising an issue which actually is my own stupidity. >> >> I recently upstreamed my embedded Linux kernel to version 4.4, after which >> I started

[PATCH v2] USB: serial: option: add support for Quectel UC20

2016-02-29 Thread yegorslists
From: Yegor Yefremov Blacklist the QMI interface. Signed-off-by: Yegor Yefremov --- Changes: v2: blacklist QMI interface drivers/usb/serial/option.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: OHCI unplug kernel crash in kernel 4.3, 4.4 and 4.5

2016-02-29 Thread Alan Stern
Please use Reply-To-All so that your message gets sent to the mailing list as well as to me. On Mon, 29 Feb 2016, Stefani Seibold wrote: > Hi, > > this is the result with kernel 4.5.0-rc6 without virtual box modules > and nvideo driver. The patch was applied. The Bug still occurs. The lines

Re: [PATCH v1] usb: hcd: out of bounds access in for_each_companion

2016-02-29 Thread Alan Stern
On Mon, 29 Feb 2016, Robert Dobrowolski wrote: > On BXT platform Host Controller and Device Controller figure as > same PCI device but with different device function. HCD should not > pass data to Device Controller. Checking if companion device is > Device Controller and omitting it. > >

Re: [HELP] USB 3.0 PCI Endpoint problem

2016-02-29 Thread Joao Pinto
Hi Felipe, On 2/22/2016 8:39 AM, Felipe Balbi wrote: > > Could this be a bug in your emulation environment ? Have you tested any > other PCIe endpoints ? > We tried with a SATA endpoint and experienced the same problem, so there's some problem that must be solved in our virtualization

[PATCH v2 0/1] usb: serial: option: Adding support for Telit LE922 PID 0x1045

2016-02-29 Thread Daniele Palmas
This patch adds support for PID 0x1045 of Telit LE922. Since the composition is similar to the one with PID 0x1042 the same blacklist is used: the only difference is an additional audio device The usb composition can be set using the AT command AT#USBCFG=5 v2: use USB_DEVICE_INTERFACE_CLASS

[PATCH v2 1/1] usb: serial: option: Adding support for Telit LE922 PID 0x1045

2016-02-29 Thread Daniele Palmas
This patch adds support for 0x1045 PID of Telit LE922. Signed-off-by: Daniele Palmas --- drivers/usb/serial/option.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c index db86e51..15d16f2 100644 ---

Re: [PATCH v7 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-02-29 Thread Mark Brown
On Mon, Jan 04, 2016 at 11:04:26AM +0800, Baolin Wang wrote: > Currently the Linux kernel does not provide any standard integration of this > feature that integrates the USB subsystem with the system power regulation > provided by PMICs meaning that either vendors must add this in their kernels >

problems with cp210x

2016-02-29 Thread walter harms
Hello List, is someone aware of a problem with DTR in that driver ? I use: Linux version 3.4.53-MMI-SW.401_0.1-43 My test was to use TIOCMBIS to set RTS and DTR while RTS is fine DTR is dead. re, wh ps: please mail me directly i am not a list member. -- To unsubscribe from this list: send

Re: [PATCH 1/1] usb: serial: option: Adding support for Telit LE922 PID 0x1045

2016-02-29 Thread Daniele Palmas
Hi Johan, 2016-02-28 16:36 GMT+01:00 Johan Hovold : > On Fri, Feb 26, 2016 at 01:35:27PM +0100, Daniele Palmas wrote: >> This patch adds support for 0x1045 PID of Telit LE922. >> >> Signed-off-by: Daniele Palmas >> --- >> drivers/usb/serial/option.c | 8

[PATCH v2] USB: Add uPD78F0730 USB to Serial Adaptor Driver

2016-02-29 Thread Maksim Salau
The adaptor can be found on development boards for 78k, RL78 and V850 microcontrollers produced by Renesas Electronics Corporation. This is not a full-featured USB to serial converter, however it allows basic communication and simple control which is enough for programming of on-board flash and

Re: [PATCH v5 3/3] USB: serial: cp210x: New access functions for large registers

2016-02-29 Thread Johan Hovold
On Sun, Feb 28, 2016 at 03:51:56PM -0600, Konstantin Shkolnyy wrote: > cp210x_get_config and cp210x_set_config are cumbersome to use. This change > switches large register access to use new block functions. The old > functions are removed because now they become unused. > > Signed-off-by:

[PATCH v1] usb: hcd: out of bounds access in for_each_companion

2016-02-29 Thread Robert Dobrowolski
On BXT platform Host Controller and Device Controller figure as same PCI device but with different device function. HCD should not pass data to Device Controller. Checking if companion device is Device Controller and omitting it. Signed-off-by: Robert Dobrowolski

Re: [PATCH v2] USB: cp210x: Add ID for Parrot NMEA GPS Flight Recorder

2016-02-29 Thread Johan Hovold
On Sun, Feb 28, 2016 at 05:51:23PM +0100, Vittorio Alfieri wrote: > On Sun, Feb 28, 2016 at 05:23:17PM +0100, Johan Hovold wrote: > > On Sun, Feb 28, 2016 at 02:40:24PM +0100, Vittorio Alfieri wrote: > > > The Parrot NMEA GPS Flight Recorder is a USB composite device > > > consisting of hub, flash

Re: [PATCH v2 1/4] USB: mxu11x0: fix memory leak on usb_serial private data

2016-02-29 Thread Johan Hovold
On Sun, Feb 28, 2016 at 05:30:54PM +0100, Mathieu OTHACEHE wrote: > On Sun, Feb 28, 2016 at 01:20:16PM +0100, Johan Hovold wrote: > So, I could post a patch serie : > > 1. Removing mxu11x0 driver > 2. Patching ti_usb_3410_5052 > 3. Cleaning up ti_usb_3410_5052 the same as we cleaned-up mxu11x0

Re: [PATCH 2/5 v7] usb: musb: core: added helper functions for parsing DT

2016-02-29 Thread Petr Kulhavy
On 26.02.2016 15:23, Bin Liu wrote: Hi, On Fri, Feb 26, 2016 at 10:29:12AM +0100, Petr Kulhavy wrote: On 26.02.2016 04:15, Bin Liu wrote: On Thu, Feb 25, 2016 at 01:04:13PM +0100, Petr Kulhavy wrote: Well, so we're still at the same point - there is a fundamental mismatch in the different