Some generic-ehci compatible controllers have more than one reset signal
lines, e.g., Synopsys DWC USB2.0 Host-AHB Controller has two resets bus_reset
and roothub_reset. Two more resets are added in this patch in order for this
kind of controller to use this driver directly.
Signed-off-by: Jianche
On 4/20/2016 2:31 PM, dingu...@opensource.altera.com wrote:
> From: Dinh Nguyen
>
> Allow for platforms that have a reset controller driver in place to bring
> the USB IP out of reset.
>
> Signed-off-by: Dinh Nguyen
> ---
> v6: fix 80 line checkpatch warning in dev_err print
> v5: updated error
Mathias Nyman writes:
> Nice catch, and moving xhci_mem_cleanup() until second hcd (primary) is
> removed is one way to solve it.
Thank you and Roger for your suggestions!
> But I don't think we should even try to handle the interrupt at this stage
> anymore.
> The host is already halted and n
Please remember to use Reply-To-All so that your messages get sent to
the mailing list as well as to me.
On Thu, 21 Apr 2016, Matthew Giassa wrote:
> Hi Alan,
>
> I've tested your latest patch, and here is a subset of the output in
> `dmesg':
...
> [ 44.975704] enable LPM
> [ 44.975707] CP
On some platforms, the clocks might be registered by a platform
driver. When this is the case, the clock platform driver may very well
be probed after xhci-plat, in which case the first probe() invocation
of xhci-plat will receive -EPROBE_DEFER as the return value of
devm_clk_get().
The current co
Hello,
On Fri, 22 Apr 2016 16:44:11 +0300, Heikki Krogerus wrote:
> if (!IS_ERR(clk)) {
> ...
> } else if (PTR_ERR(clk) == -EPROBE_DEFER)
> ret = -EPROBE_DEFER;
> goto put_hcd;
> ...
Thanks for the review! I've just sent a v2 that address
On 21.04.2016 15:43, Heikki Krogerus wrote:
USB Type-C Connector System Software Interface (UCSI) is
specification that defines the registers and data structures
that can be used to control USB Type-C ports on a system.
UCSI is used on several Intel Broxton SoC based platforms.
Things that UCSI c
Hi,
One nitpick..
On Fri, Apr 22, 2016 at 03:16:45PM +0200, Thomas Petazzoni wrote:
> On some platforms, the clocks might be registered by a platform
> driver. When this is the case, the clock platform driver may very well
> be probed after xhci-plat, in which case the first probe() invocation
>
On Fri, Apr 22, 2016 at 4:36 AM, Felipe Balbi
wrote:
>
> Hi,
>
> Yoshihiro Shimoda writes:
>> The firmware of R-Car USB 3.0 host controller will control the reset.
>> So, if the xhci driver doesn't do firmware downloading (e.g. kernel
>> configuration is CONFIG_USB_XHCI_PLATFORM=y and CONFIG_USB_
On Thu, Apr 21, 2016 at 8:57 AM, Felipe Balbi
wrote:
>
> Hi,
>
> Rob Herring writes:
>> On Thu, Apr 21, 2016 at 6:20 AM, Felipe Balbi
>> wrote:
>>>
>>> Hi,
>>>
>>> Heikki Krogerus writes:
@@ -197,7 +196,7 @@ static int xhci_plat_probe(struct platform_device
*pdev)
}
>
On some platforms, the clocks might be registered by a platform
driver. When this is the case, the clock platform driver may very well
be probed after xhci-plat, in which case the first probe() invocation
of xhci-plat will receive -EPROBE_DEFER as the return value of
devm_clk_get().
The current co
Hi Jim,
Jim Lin writes:
> Android N adds os_desc_compat in v2_descriptor by init_functionfs()
> (system/core/adb/usb_linux_client.cpp) to support automatic install
> of MTP driver on Windows for USB device mode.
>
> Current __ffs_data_do_os_desc() of f_fs.c will check reserved1 field
> and retur
On 04/22/2016 12:43 PM, Jim Lin wrote:
> Android N adds os_desc_compat in v2_descriptor by init_functionfs()
> (system/core/adb/usb_linux_client.cpp) to support automatic install
> of MTP driver on Windows for USB device mode.
>
> Current __ffs_data_do_os_desc() of f_fs.c will check reserved1 fiel
Android N adds os_desc_compat in v2_descriptor by init_functionfs()
(system/core/adb/usb_linux_client.cpp) to support automatic install
of MTP driver on Windows for USB device mode.
Current __ffs_data_do_os_desc() of f_fs.c will check reserved1 field
and return -EINVAL.
This results in a second ad
From: Felipe Balbi
We're preparing to remove xhci_plat_type_is() in
favor of a better approach where we define function
pointers ahead of time. This will let us make
assumptions about which platforms we're running on
and which platform-specific functions we should call.
Acked-by: Yoshihiro Shimo
From: Felipe Balbi
xhci_plat_setup() is the rightful place for
xhci_mvebu_mbus_init_quirk(), so let's move it there
in order to make it simpler to get rid of
xhci_plat_type_is() later on.
Acked-by: Yoshihiro Shimoda
Signed-off-by: Felipe Balbi
Signed-off-by: Mathias Nyman
---
drivers/usb/hos
From: Felipe Balbi
Now that the code has been refactored enough,
switching over to using ->plat_start() and
->init_quirk() becomes a very simple patch.
After this patch, there are no further uses for
xhci_plat_type_is() which will be removed in a
follow-up patch.
Acked-by: Yoshihiro Shimoda
Si
From: Alexandr Ivanov
In drivers/usb/host/xhci-ring.c there are two functions
(xhci_queue_bulk_tx and queue_bulk_sg_tx) that are very similar,
so a lot of code duplication.
This patch merges these functions into to one xhci_queue_bulk_tx.
Also counting the needed TRBs is merged and refactored.
S
From: Felipe Balbi
Just like RCAR's init_quirk() we want mvebu's to use
struct usb_hcd * as argument too. This is another
step towards removing xhci_plat_type_is().
Acked-by: Yoshihiro Shimoda
Signed-off-by: Felipe Balbi
Signed-off-by: Mathias Nyman
---
drivers/usb/host/xhci-mvebu.c | 7
From: Felipe Balbi
these two methods will be used to hide
platform-specific details so we can get rid of
xhci_plat_type_is() in a later patch.
Acked-by: Yoshihiro Shimoda
Signed-off-by: Felipe Balbi
Signed-off-by: Mathias Nyman
---
drivers/usb/host/xhci-plat.h | 2 ++
1 file changed, 2 inser
From: Alexandr Ivanov
Move duplicate code from xhci_queue_intr_tx()
and xhci_queue_isoc_tx_prepare() to the check_interval() function.
Signed-off-by: Alexandr Ivanov
Signed-off-by: Mathias Nyman
---
drivers/usb/host/xhci-ring.c | 53 ++--
1 file changed
From: Alexandr Ivanov
Remove duplicate function xhci_urb_to_transfer_ring from xhci.c.
We have same function in xhci-ring.c.
Signed-off-by: Alexandr Ivanov
Signed-off-by: Mathias Nyman
---
drivers/usb/host/xhci-ring.c | 17 +
drivers/usb/host/xhci.c | 41 -
From: Felipe Balbi
Now that there are no more users for
xhci_plat_type_is(), we can safely remove it.
Acked-by: Yoshihiro Shimoda
Signed-off-by: Felipe Balbi
Signed-off-by: Mathias Nyman
---
drivers/usb/host/xhci-plat.c | 3 ---
drivers/usb/host/xhci-plat.h | 18 --
2 files
Hi Greg
These patches for 4.7 are mostly refactoring and cleanups.
Alexandr Ivanov refactored xhci bulk transfer queuing, and Felipe
cleaned up code for xhci platform devices.
Alexandr Ivanov (3):
usb: xhci: merge xhci_queue_bulk_tx and queue_bulk_sg_tx functions
usb: xhci: remove duplicate f
/linux/commits/Felipe-Balbi/usb-xhci-get-rid-of-xhci_plat_type_is/20160422-162823
> base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
> usb-testing
> config: mips-allyesconfig (attached as .config)
> reproduce:
> wget
> https://git.kernel.org/cgit/l
Hi,
Yoshihiro Shimoda writes:
> The firmware of R-Car USB 3.0 host controller will control the reset.
> So, if the xhci driver doesn't do firmware downloading (e.g. kernel
> configuration is CONFIG_USB_XHCI_PLATFORM=y and CONFIG_USB_XHCI_RCAR
> is not set), the reset of USB 3.0 host controller d
The firmware of R-Car USB 3.0 host controller will control the reset.
So, if the xhci driver doesn't do firmware downloading (e.g. kernel
configuration is CONFIG_USB_XHCI_PLATFORM=y and CONFIG_USB_XHCI_RCAR
is not set), the reset of USB 3.0 host controller doesn't work
correctly. Then, the host con
-xhci_plat_type_is/20160422-162823
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
usb-testing
config: mips-allyesconfig (attached as .config)
reproduce:
wget
https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross
-O ~/bin/make.cross
chmod +x
Now that there are no more users for
xhci_plat_type_is(), we can safely remove it.
Acked-by: Yoshihiro Shimoda
Signed-off-by: Felipe Balbi
---
drivers/usb/host/xhci-plat.c | 3 ---
drivers/usb/host/xhci-plat.h | 18 --
2 files changed, 21 deletions(-)
diff --git a/drivers/usb/
Now that the code has been refactored enough,
switching over to using ->plat_start() and
->init_quirk() becomes a very simple patch.
After this patch, there are no further uses for
xhci_plat_type_is() which will be removed in a
follow-up patch.
Acked-by: Yoshihiro Shimoda
Signed-off-by: Felipe B
xhci_plat_setup() is the rightful place for
xhci_mvebu_mbus_init_quirk(), so let's move it there
in order to make it simpler to get rid of
xhci_plat_type_is() later on.
Acked-by: Yoshihiro Shimoda
Signed-off-by: Felipe Balbi
---
drivers/usb/host/xhci-plat.c | 15 +--
1 file changed,
Just like RCAR's init_quirk() we want mvebu's to use
struct usb_hcd * as argument too. This is another
step towards removing xhci_plat_type_is().
Acked-by: Yoshihiro Shimoda
Signed-off-by: Felipe Balbi
---
drivers/usb/host/xhci-mvebu.c | 7 ++-
drivers/usb/host/xhci-mvebu.h | 7 +--
dri
these two methods will be used to hide
platform-specific details so we can get rid of
xhci_plat_type_is() in a later patch.
Acked-by: Yoshihiro Shimoda
Signed-off-by: Felipe Balbi
---
drivers/usb/host/xhci-plat.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/host/xhci-plat.h
We're preparing to remove xhci_plat_type_is() in
favor of a better approach where we define function
pointers ahead of time. This will let us make
assumptions about which platforms we're running on
and which platform-specific functions we should call.
Acked-by: Yoshihiro Shimoda
Signed-off-by: Fe
Hi,
This 6-patch series gets rid of the pointless
xhci_plat_type_is() in favour of a nicer setup where
we initialize function pointers ahead of time using
driver_data. That way we help the code look a little
cleaner and easier to read.
Changes since v2:
- rebased on v4.6-rc4
- fixed another
No more users for it.
Signed-off-by: Heikki Krogerus
---
drivers/usb/dwc3/core.c | 35 --
drivers/usb/dwc3/platform_data.h | 53
2 files changed, 88 deletions(-)
delete mode 100644 drivers/usb/dwc3/platform_data.h
diff -
This should allow the core driver to drop handling of
platform data and expect the platform specific details to
always come from properties.
Signed-off-by: Heikki Krogerus
Cc: Huang Rui
CC: John Youn
---
drivers/usb/dwc3/dwc3-pci.c | 70 +
1 file cha
Changes since v1:
- Slit the refactoring and cleanup into separate patches
Heikki Krogerus (4):
usb: dwc3: pci: make build-in device properties available
usb: dwc3: pci: pass the platform device as a parameter to
dwc3_pci_quirks()
usb: dwc3: pci: use build-in properties instead of platf
Setting the ACPI companion before calling dwc3_pci_quirks.
The ACPI companion will be set unconditionally as the
primary fwnode, overriding any previously set primary
fwnode. This will make sure that any build-in properties
added to the platform device will be added as the secondary
fwnode in cases
For convenience, passing the dwc3 platform device as a
parameter to dwc3_pci_quirks() function.
Signed-off-by: Heikki Krogerus
---
drivers/usb/dwc3/dwc3-pci.c | 13 +
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/drivers/usb/dwc3/dwc3-pci.c b/drivers/usb/dwc3/dwc3-pci
On Wed, Apr 20, 2016 at 11:15:37AM +0300, Felipe Balbi wrote:
>
> Hi Greg,
>
> here's what I hope to be my last pull request to this -rc series.
>
> Patches have been tested (where applicable) with intel platforms I have
> around. They have also been in next for a little while without any
> repo
-xhci_plat_type_is/20160422-154613
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
usb-testing
config: i386-randconfig-x002-201616 (attached as .config)
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All errors (new ones prefixed by
Just like RCAR's init_quirk() we want mvebu's to use
struct usb_hcd * as argument too. This is another
step towards removing xhci_plat_type_is().
Acked-by: Yoshihiro Shimoda
Signed-off-by: Felipe Balbi
---
drivers/usb/host/xhci-mvebu.c | 7 ++-
drivers/usb/host/xhci-mvebu.h | 7 +--
dri
xhci_plat_setup() is the rightful place for
xhci_mvebu_mbus_init_quirk(), so let's move it there
in order to make it simpler to get rid of
xhci_plat_type_is() later on.
Acked-by: Yoshihiro Shimoda
Signed-off-by: Felipe Balbi
---
drivers/usb/host/xhci-plat.c | 15 +--
1 file changed,
Now that the code has been refactored enough,
switching over to using ->plat_start() and
->init_quirk() becomes a very simple patch.
After this patch, there are no further uses for
xhci_plat_type_is() which will be removed in a
follow-up patch.
Acked-by: Yoshihiro Shimoda
Signed-off-by: Felipe B
these two methods will be used to hide
platform-specific details so we can get rid of
xhci_plat_type_is() in a later patch.
Acked-by: Yoshihiro Shimoda
Signed-off-by: Felipe Balbi
---
drivers/usb/host/xhci-plat.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/host/xhci-plat.h
We're preparing to remove xhci_plat_type_is() in
favor of a better approach where we define function
pointers ahead of time. This will let us make
assumptions about which platforms we're running on
and which platform-specific functions we should call.
Acked-by: Yoshihiro Shimoda
Signed-off-by: Fe
Now that there are no more users for
xhci_plat_type_is(), we can safely remove it.
Acked-by: Yoshihiro Shimoda
Signed-off-by: Felipe Balbi
---
drivers/usb/host/xhci-plat.c | 3 ---
drivers/usb/host/xhci-plat.h | 18 --
2 files changed, 21 deletions(-)
diff --git a/drivers/usb/
Hi,
Yoshihiro Shimoda writes:
>> > > And, kernel log is the following:
>> > >
>> > > [1.565605] xhci-hcd ee00.usb: xHCI Host Controller
>> > > [1.570636] xhci-hcd ee00.usb: new USB bus registered, assigned
>> > > bus number 5
>> > > [ 22.270160] xhci-hcd ee00.usb: can't se
49 matches
Mail list logo