Re: [PATCH v2] usb: host: xhci-rcar: Avoid long wait in xhci_reset()

2016-04-24 Thread Geert Uytterhoeven
Hi Shimoda-san, On Mon, Apr 25, 2016 at 4:10 AM, Yoshihiro Shimoda wrote: >> From: Rob Herring >> Sent: Friday, April 22, 2016 10:29 PM >> On Fri, Apr 22, 2016 at 4:36 AM, Felipe Balbi >> wrote: >> > Yoshihiro Shimoda writes: >> >> The firmware of R-Car USB 3.0 host controller will control the

Re: uas: order 7 page allocation failure in init_tag_map()

2016-04-24 Thread Hans de Goede
Hi, On 23-04-16 23:10, Johannes Stezenbach wrote: Hi, I bought a new backup disk which turned out to be UAS capable, but when I plugged it in I got an order 7 page allocation failure. My hunch is that the .can_queue = 65536 in drivers/usb/storage/uas.c is much too large. Maybe 256 would be a p

Re: devicetree: avoid duplicated matching code (was: Re: [PATCH 1/3] xhci: plat: adapt to unified device property interface)

2016-04-24 Thread Felipe Balbi
Hi, Rob Herring writes: > On Thu, Apr 21, 2016 at 8:57 AM, Felipe Balbi > wrote: >> >> Hi, >> >> Rob Herring writes: >>> On Thu, Apr 21, 2016 at 6:20 AM, Felipe Balbi >>> wrote: Hi, Heikki Krogerus writes: > @@ -197,7 +196,7 @@ static int xhci_plat_probe(struct platfo

Re: [PATCHv3] usb: Add driver for UCSI

2016-04-24 Thread Felipe Balbi
Heikki Krogerus writes: > USB Type-C Connector System Software Interface (UCSI) is > specification that defines the registers and data structures > that can be used to control USB Type-C ports on a system. > UCSI is used on several Intel Broxton SoC based platforms. > Things that UCSI can be used

RE: [PATCH v2] usb: host: xhci-rcar: Avoid long wait in xhci_reset()

2016-04-24 Thread Felipe Balbi
Hi, Yoshihiro Shimoda writes: >> > Yoshihiro Shimoda writes: >> >> The firmware of R-Car USB 3.0 host controller will control the reset. >> >> So, if the xhci driver doesn't do firmware downloading (e.g. kernel >> >> configuration is CONFIG_USB_XHCI_PLATFORM=y and CONFIG_USB_XHCI_RCAR >> >> is

Re: [PATCH 5/5] doc: usb: ci-hdrc-usb2: add property usb-charger-detection

2016-04-24 Thread Peter Chen
On Mon, Apr 18, 2016 at 04:17:49PM +0800, Li Jun wrote: > Set this property if your usb module has usb charger detect function > and you want to use it. > > Signed-off-by: Li Jun > --- > Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --

Re: [PATCH 1/5] usb: chipidea: add usb charger detection support

2016-04-24 Thread Peter Chen
On Mon, Apr 18, 2016 at 04:17:45PM +0800, Li Jun wrote: > Some usb module implementations has functionality of detect usb charger > type, it can be used by usb charger framework to report max current drawn > from charger in different situations. > > Signed-off-by: Li Jun > --- > drivers/usb/chip

Re: [PATCH 4/5] usb: chipidea: imx: add usb charger detection for imx7d

2016-04-24 Thread Peter Chen
On Mon, Apr 18, 2016 at 04:17:48PM +0800, Li Jun wrote: > Adds imx7d usb charger detection implementation, which needs pull up > DP line before do secondary detection and pull down DP afterwards. > You can merge patch 3 and patch 4 as one patch. Acked-by: Peter Chen > Signed-off-by: Li Jun >

[PATCH] usb: dwc3: gadget: give better command return code

2016-04-24 Thread Felipe Balbi
From: Konrad Leszczynski if Start Transfer command fails, let's try a little harder to figure out why the command failed and give slightly better return codes. This will be usefulf or isochronous endpoints, at least, which could decide to retry a given request. Signed-off-by: Konrad Leszczynski

Re: [PATCH 2/5] usb: chipidea: imx: add usb charger dectection for imx platforms

2016-04-24 Thread Peter Chen
On Mon, Apr 18, 2016 at 04:17:46PM +0800, Li Jun wrote: > Some imx usb charger dectection need software implement the whole process, > during which, pull up&down DP line via usb core is required. via chipidea core Others are ok. Peter > > Signed-off-by: Li Jun > --- > drivers/usb/chipidea/ci

Re: [PATCH 1/5] usb: chipidea: add usb charger detection support

2016-04-24 Thread Peter Chen
On Mon, Apr 18, 2016 at 04:17:45PM +0800, Li Jun wrote: > Some usb module implementations has functionality of detect usb charger > type, it can be used by usb charger framework to report max current drawn > from charger in different situations. %s/has/have %s/drawn/draw > > Signed-off-by: Li Ju

RE: [PATCH v2] usb: host: xhci-rcar: Avoid long wait in xhci_reset()

2016-04-24 Thread Yoshihiro Shimoda
Hi, > From: Rob Herring > Sent: Friday, April 22, 2016 10:29 PM > > On Fri, Apr 22, 2016 at 4:36 AM, Felipe Balbi > wrote: > > > > Hi, > > > > Yoshihiro Shimoda writes: > >> The firmware of R-Car USB 3.0 host controller will control the reset. > >> So, if the xhci driver doesn't do firmware dow

[PATCH 1/1] usb: core: move root hub's device node assignment after it is added to bus

2016-04-24 Thread Peter Chen
When the root hub device is added to the bus, it tries to get pins information from pinctrl (see pinctrl_bind_pins, at really_probe), if the pin information is described at DT, it will show below error since the root hub's device node is the same with controller's, but controller's pin has already

[PATCH 1/1] usb: core: move root hub's device node assignment after it is added to bus

2016-04-24 Thread Peter Chen
When the root hub device is added to the bus, it tries to get pins information from pinctrl (see pinctrl_bind_pins, at really_probe), if the pin information is described at DT, it will show below error since the root hub's device node is the same with controller's, but controller's pin has already

RE: [PATCH v2] usb: host: xhci-rcar: Avoid long wait in xhci_reset()

2016-04-24 Thread Yoshihiro Shimoda
Hi, > From: Felipe Balbi > Sent: Friday, April 22, 2016 6:37 PM > > Hi, > > Yoshihiro Shimoda writes: > > The firmware of R-Car USB 3.0 host controller will control the reset. > > So, if the xhci driver doesn't do firmware downloading (e.g. kernel > > configuration is CONFIG_USB_XHCI_PLATFORM=y

Re: USB quirks for Creative SB Omni Surround 5.1

2016-04-24 Thread Greg KH
On Sun, Apr 24, 2016 at 09:59:47PM +0300, Nazar Mokrynskyi wrote: > I had a long kernel boot delay after upgrading firmware on Creative > SoundBlaster Omni Surround 5.1 USB sound card to v2 with message > "usb_submit_urb(ctrl) failed: -1". > > I've also managed to fix this issue with patch attache

USB quirks for Creative SB Omni Surround 5.1

2016-04-24 Thread Nazar Mokrynskyi
I had a long kernel boot delay after upgrading firmware on Creative SoundBlaster Omni Surround 5.1 USB sound card to v2 with message "usb_submit_urb(ctrl) failed: -1". I've also managed to fix this issue with patch attached. Checked on 4.6.0-rc4 kernel, now it works fine. Would be nice if so

[PATCH RESEND 4/5] USB: serial: cp210x: Prepared get_termios() for adding error handling

2016-04-24 Thread Konstantin Shkolnyy
Replaced several register write calls with one, to simplify adding error handling. Signed-off-by: Konstantin Shkolnyy --- drivers/usb/serial/cp210x.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c index b23

[PATCH RESEND 3/5] USB: serial: cp210x: Added comments to CRTSCT flag code.

2016-04-24 Thread Konstantin Shkolnyy
Documented "magic numbers" used in the CRTSCT flag code in terms of register bit names from the chip specification. Signed-off-by: Konstantin Shkolnyy --- drivers/usb/serial/cp210x.c | 38 ++ 1 file changed, 34 insertions(+), 4 deletions(-) diff --git a/drive

[PATCH RESEND 2/5] USB: serial: cp210x: Made sure SERIAL_XOFF_CONTINUE flag is clear.

2016-04-24 Thread Konstantin Shkolnyy
The CRTCTS flag code intended to clear the SERIAL_XOFF_CONTINUE flag, but did it inconsistently. This change is non-functional for existing chips because the driver never set the flag and it's clear by default. Signed-off-by: Konstantin Shkolnyy --- drivers/usb/serial/cp210x.c | 2 +- 1 file cha

[PATCH RESEND 5/5] USB: serial: cp210x: Added more error handling to open()

2016-04-24 Thread Konstantin Shkolnyy
Added error handling to register accesses made by open(), so it doesn't succeed if anything goes wrong. Signed-off-by: Konstantin Shkolnyy --- drivers/usb/serial/cp210x.c | 41 - 1 file changed, 28 insertions(+), 13 deletions(-) diff --git a/drivers/usb/s

[PATCH RESEND 1/5] USB: serial: cp210x: Fixed RTS mode setting by the CRTSCTS flag.

2016-04-24 Thread Konstantin Shkolnyy
A bug in the CRTSCT handling caused RTS to alternate between CRTSCTS=0 => "RTS transmits active signal" and CRTSCTS=1 => "RTS receives flow control" instead of CRTSCTS=0 => "RTS is statically active" and CRTSCTS=1 => "RTS receives flow control" Signed-off-by: Konstantin Shkolnyy --- drivers/usb/

Re: [PATCH] usb: serial: ti_usb_3410_5052: add MOXA UPORT 11x0 support

2016-04-24 Thread Johan Hovold
On Wed, Mar 02, 2016 at 10:46:13AM +0100, Mathieu OTHACEHE wrote: > Add support for : > > - UPort 1110 : 1 port RS-232 USB to Serial Hub. > - UPort 1130 : 1 port RS-422/485 USB to Serial Hub. > - UPort 1130I : 1 port RS-422/485 USB to Serial Hub with Isolation. > - UPort 1150 : 1 port RS-232/42

Re: [PATCH v2] USB: Add uPD78F0730 USB to Serial Adaptor Driver

2016-04-24 Thread Johan Hovold
On Mon, Feb 29, 2016 at 04:11:20PM +0300, Maksim Salau wrote: > The adaptor can be found on development boards for 78k, RL78 and V850 > microcontrollers produced by Renesas Electronics Corporation. > > This is not a full-featured USB to serial converter, however it allows > basic communication and

[PATCH] usb: Remove unnecessary space before function pointer arguments.

2016-04-24 Thread Sandhya Bankar
Remove unnecessary space before function pointer arguments. Signed-off-by: Sandhya Bankar --- drivers/usb/atm/ueagle-atm.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/usb/atm/ueagle-atm.c b/drivers/usb/atm/ueagle-atm.c index 0186442..4333dc5 100644 --- a/d

[PATCH] Use "foo *bar" instead of "foo * bar".

2016-04-24 Thread Sandhya Bankar
Use "foo *bar" instead of "foo * bar". Signed-off-by: Sandhya Bankar --- drivers/usb/atm/ueagle-atm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/atm/ueagle-atm.c b/drivers/usb/atm/ueagle-atm.c index a2ae88d..0186442 100644 --- a/drivers/usb/atm/ueagle-atm.c +

Re: [PATCH] option.c: Support for Gemalto's Cinterion PH8 and AHxx products added

2016-04-24 Thread Johan Hovold
On Fri, Apr 08, 2016 at 08:27:16AM +, Schemmel Hans-Christoph wrote: > > -Original Message- > > From: Johan Hovold [mailto:jhov...@gmail.com] On Behalf Of Johan Hovold > > Sent: Donnerstag, 7. April 2016 11:51 > > To: Schemmel Hans-Christoph > > Cc: jo...@kernel.org; gre...@linuxfoundat

Re: [PATCH v2] usb: serial: Adding Straizona Focusers to cp210x driver

2016-04-24 Thread Johan Hovold
On Tue, Apr 19, 2016 at 10:38:27AM +0300, Jasem Mutlaq wrote: > From: Jasem Mutlaq > > Adding VID:PID for Straizona Focusers to cp210x driver. Fixed white space > issue. > > Signed-off-by: Jasem Mutlaq > --- Thanks for the v2. I trimmed the changelog comment (about white space) before applyin

Re: [PATCH] cp210x: Add ID for Link ECU

2016-04-24 Thread Johan Hovold
On Mon, Apr 18, 2016 at 12:13:23PM +, Mike Manning wrote: > The Link ECU is an aftermarket ECU computer for vehicles that provides full > tuning abilities as well as datalogging and displaying capabilities via the > USB to Serial adapter built into the device. > > Signed-off-by: Mike Manning