[PATCH] asix: Fix offset calculation in asix_rx_fixup() causing slow transmissions

2016-05-16 Thread John Stultz
In testing with HiKey, we found that since commit 3f30b158eba5 ("asix: On RX avoid creating bad Ethernet frames"), we're seeing lots of noise during network transfers: [ 239.027993] asix 1-1.1:1.0 eth0: asix_rx_fixup() Data Header synchronisation was lost, remaining 988 [ 239.037310] asix 1-1.1

RE: [PATCH] usb: gadget: f_fs: report error if excess data received

2016-05-16 Thread Du, Changbin
> There appears to be no kfifo support for iov_iter though, so I just went > with a simple buffer. > > I haven’t looked at the patch too carefully so this is an RFC rather > than an actual patch at this point. It does compile at least. > > Regardless, the more I thin about it, the more I’m under

Re: [PATCH] usb: xhci-mtk: fixup mouse wakeup failure during system suspend

2016-05-16 Thread chunfeng yun
On Wed, 2016-05-04 at 14:56 +0300, Felipe Balbi wrote: > Hi, > > chunfeng yun writes: > >> chunfeng yun writes: > >> > On Tue, 2016-05-03 at 12:33 +0300, Felipe Balbi wrote: > >> >> Hi, > >> >> > >> >> chunfeng yun writes: > >> >> >> chunfeng yun writes: > >> >> >> > On Thu, 2016-04-21 at 10:

Re: USB kernel debug

2016-05-16 Thread Brian T. McKee
Hi Greg and Alan, I just booted windows 10 to see if it can handle the setup and it can't. The cameras lock up in similar ways to linux. A few frames display and then they lock up. It looks like some kind of hardware failure. I'm going to take another machine with four USB 3.0 ports on it and se

Re: USB kernel debug

2016-05-16 Thread Brian T. McKee
On 05/16/16 17:56, Greg KH wrote: > I recommend any of the hubs recommended here: > http://thewirecutter.com/reviews/best-usb-hubs/ > > Thanks Greg. I'm using the Sabrent HB-UMP3 which I would hope is related to or derived from the Sabrent they mention in thewirecutter article. -- To un

Re: USB kernel debug

2016-05-16 Thread Greg KH
A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Mon, May 16, 2016 at 04:58:46PM -0700, Brian T. McKee wrote: > Can you make a recommendation? Is there one you trust? I recommend any of the hubs recommended here: http://thewirecutter.com/

Re: [REGRESSION] asix: Lots of asix_rx_fixup() errors and slow transmissions

2016-05-16 Thread John Stultz
On Wed, May 11, 2016 at 3:00 PM, Dean Jenkins wrote: > > Your observations are consistent with missing URBs from the USB host > controller. > > Here is a summary of what I think is happening in your case: > > Good case: > URB #1: 1514 octets of 1514 Ethernet frame (A) > URB #2: 1514 octets of 1514

Re: USB kernel debug

2016-05-16 Thread Brian T. McKee
Can you make a recommendation? Is there one you trust? On 05/16/16 16:19, Greg KH wrote: > On Mon, May 16, 2016 at 03:49:55PM -0700, Brian T. McKee wrote: >> Thanks Greg. It is a powered USB hub. The supplies have 2.5 amps to >> spread across three cameras. One of the hub's ports uses laptop pow

Re: USB kernel debug

2016-05-16 Thread Greg KH
On Mon, May 16, 2016 at 03:49:55PM -0700, Brian T. McKee wrote: > Thanks Greg. It is a powered USB hub. The supplies have 2.5 amps to > spread across three cameras. One of the hub's ports uses laptop power, > but I'm not using that port. > The USB 3.0 spec (according to wikipedia) requires that eac

Re: USB kernel debug

2016-05-16 Thread Brian T. McKee
Here's another crash. I include discovery of the hubs, cameras and even the logitech keyboard and mouse wireless dongle. [ 2158.726264] usb 1-1: new full-speed USB device number 48 using xhci_hcd [ 2158.893384] usb 1-1: New USB device found, idVendor=046d, idProduct=c52b [ 2158.893386] usb 1-1: Ne

Re: USB kernel debug

2016-05-16 Thread Brian T. McKee
Thanks Greg. It is a powered USB hub. The supplies have 2.5 amps to spread across three cameras. One of the hub's ports uses laptop power, but I'm not using that port. The USB 3.0 spec (according to wikipedia) requires that each port be capable of delivering 900 mA, so those power supplies seem a b

Re: USB kernel debug

2016-05-16 Thread Greg KH
On Mon, May 16, 2016 at 02:09:03PM -0700, Brian T. McKee wrote: > I just noticed that timing matters. If I bring the USB devices up one at > a time, with lots of time between power ups, things seem to initialize > better. And there are two ports that won't work much at all and two that > work until

Re: USB kernel debug

2016-05-16 Thread Brian T. McKee
I just noticed that timing matters. If I bring the USB devices up one at a time, with lots of time between power ups, things seem to initialize better. And there are two ports that won't work much at all and two that work until this failure occurs. I was able to reproduce the HCI shut down with ke

Re: USB kernel debug

2016-05-16 Thread Brian T. McKee
Thanks for replying Alan. I really appreciate it. You asked what I was hoping to do. I have a six camera system that crashes regularly forcing a reboot. I'm hoping to get more stability. It's possible that the failure is software and not hardware or kernel, but at any rate I'd like to know what th

Re: [PATCH v2 2/2] musb: sunxi: Set state to A_WAIT_VRISE when enabling Vbus

2016-05-16 Thread Bin Liu
On Sat, May 14, 2016 at 02:45:05PM +0200, Hans de Goede wrote: > When the board is powering attached usb devices via the otg port > sometimes / on some devices it takes slightly too long for the Vbus > detection code in phy-sun4i-usb.c to signal that Vbus is high after > enabling Vbus and the musb

Re: [PATCH v2 1/2] musb: sunxi: Add set_mode platform function

2016-05-16 Thread Bin Liu
On Sat, May 14, 2016 at 02:45:04PM +0200, Hans de Goede wrote: > Move the mode handling to the platform_set_mode callback. > > Signed-off-by: Hans de Goede Signed-off-by: Bin Liu Regards, -Bin. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to

Re: USB kernel debug

2016-05-16 Thread Alan Stern
On Mon, 16 May 2016, Brian T. McKee wrote: > I sent a message to the group yesterday, but I suspect it was too big > for it's own good and didn't make it to the list. It did; I saw it. > I'm attempting to debug a USB problem where multiple UVC camera causes > the USB driver to crash and shut dow

Re: [PATCH] usb: gadget: f_fs: report error if excess data received

2016-05-16 Thread Michal Nazarewicz
On Mon, May 16 2016, Felipe Balbi wrote: > Michal Nazarewicz writes: > >>> Alan Stern writes: The point is that you don't know whether the host sent more data than expected. All you know is that the host sent more data than the user asked the kernel for -- but maybe the user didn'

USB kernel debug

2016-05-16 Thread Brian T. McKee
I sent a message to the group yesterday, but I suspect it was too big for it's own good and didn't make it to the list. I'm attempting to debug a USB problem where multiple UVC camera causes the USB driver to crash and shut down. All *HCI devices stop working. I managed to get a USB serial port u

Re: [PATCH] usb: gadget: f_fs: report error if excess data received

2016-05-16 Thread Michal Nazarewicz
> On 05/16/2016 06:05 PM, Michal Nazarewicz wrote: >> So I’ve been looking at AIO handling in f_fs and either I’m stupid or >> the code is broken. On Mon, May 16 2016, Lars-Peter Clausen wrote: > The code was broken. Fixed in commit 332a5b446b791 ("usb: gadget: > f_fs: Fix EFAULT generation for as

Re: [PATCH] usb: gadget: f_fs: report error if excess data received

2016-05-16 Thread Krzysztof Opasiak
Hi Michal, On 05/16/2016 06:05 PM, Michal Nazarewicz wrote: > So I’ve been looking at AIO handling in f_fs and either I’m stupid or > the code is broken. Here’s part of ffs_user_copy_worker: > > int ret = io_data->req->status ? io_data->req->status : >

Re: [PATCH] usb: gadget: f_fs: report error if excess data received

2016-05-16 Thread Lars-Peter Clausen
On 05/16/2016 06:05 PM, Michal Nazarewicz wrote: > So I’ve been looking at AIO handling in f_fs and either I’m stupid or > the code is broken. The code was broken. Fixed in commit 332a5b446b791 ("usb: gadget: f_fs: Fix EFAULT generation for async read operations:). -- To unsubscribe from this list

Re: [PATCH] usb: gadget: f_fs: report error if excess data received

2016-05-16 Thread Michal Nazarewicz
So I’ve been looking at AIO handling in f_fs and either I’m stupid or the code is broken. Here’s part of ffs_user_copy_worker: int ret = io_data->req->status ? io_data->req->status : io_data->req->actual; if (io_data->read && ret > 0) {

Re: [PATCH 0/4] musb fixes for v4.7-rc1

2016-05-16 Thread Bin Liu
Greg, On Mon, May 16, 2016 at 05:35:44AM -0700, Greg KH wrote: > On Mon, May 09, 2016 at 08:56:21AM -0500, Bin Liu wrote: > > Hi Greg, > > > > Here are fixes for musb, which are ready to get into v4.7-rc1. Please let me > > know if any change is needed. > > I missed these in time, sorry. Please

Re: [PATCH 10/15] usb: musb: Don't set d+ high before enable for 2430 glue layer

2016-05-16 Thread Tony Lindgren
* Bin Liu [160516 08:24]: > Hi, > > On Mon, May 16, 2016 at 07:57:57AM -0700, Tony Lindgren wrote: > > * Bin Liu [160516 07:17]: > > > Hi, > > > > > > On Sat, May 14, 2016 at 04:30:32PM +0300, Sergei Shtylyov wrote: > > > > On 5/14/2016 12:03 AM, Bin Liu wrote: > > > > > > > > >>At least 2430

Re: [PATCH 10/15] usb: musb: Don't set d+ high before enable for 2430 glue layer

2016-05-16 Thread Bin Liu
Hi, On Mon, May 16, 2016 at 07:57:57AM -0700, Tony Lindgren wrote: > * Bin Liu [160516 07:17]: > > Hi, > > > > On Sat, May 14, 2016 at 04:30:32PM +0300, Sergei Shtylyov wrote: > > > On 5/14/2016 12:03 AM, Bin Liu wrote: > > > > > > >>At least 2430 glue layer pulls d+ high on start up even if th

Re: [PATCH 10/15] usb: musb: Don't set d+ high before enable for 2430 glue layer

2016-05-16 Thread Tony Lindgren
* Bin Liu [160514 21:44]: > Hi, > > On Fri, May 13, 2016 at 03:25:17PM -0700, Tony Lindgren wrote: > > * Bin Liu [160513 15:04]: > > > > > > But what would be in musb_default_set_mode()? Currently only am35x, > > > da8xx, dsps, and omap2430 glues implement _set_mode(), but they don't > > > have

Re: [PATCH 0/4] musb fixes for v4.7-rc1

2016-05-16 Thread Greg KH
On Mon, May 09, 2016 at 08:56:21AM -0500, Bin Liu wrote: > Hi Greg, > > Here are fixes for musb, which are ready to get into v4.7-rc1. Please let me > know if any change is needed. I missed these in time, sorry. Please resend after 4.7-rc1 is out. thanks, greg k-h -- To unsubscribe from this l

Re: [PATCH 10/15] usb: musb: Don't set d+ high before enable for 2430 glue layer

2016-05-16 Thread Tony Lindgren
* Bin Liu [160516 07:17]: > Hi, > > On Sat, May 14, 2016 at 04:30:32PM +0300, Sergei Shtylyov wrote: > > On 5/14/2016 12:03 AM, Bin Liu wrote: > > > > >>At least 2430 glue layer pulls d+ high on start up even if there are > > >>no gadgets configured. This is bad at least for anything using a sep

Re: [PATCH 10/15] usb: musb: Don't set d+ high before enable for 2430 glue layer

2016-05-16 Thread Bin Liu
Hi, On Sat, May 14, 2016 at 04:30:32PM +0300, Sergei Shtylyov wrote: > On 5/14/2016 12:03 AM, Bin Liu wrote: > > >>At least 2430 glue layer pulls d+ high on start up even if there are > >>no gadgets configured. This is bad at least for anything using a separate > >>battery charger chip as it can

Re: [PATCH] usb: gadget: f_fs: report error if excess data received

2016-05-16 Thread Felipe Balbi
Michal Nazarewicz writes: >> Alan Stern writes: >>> The point is that you don't know whether the host sent more data than >>> expected. All you know is that the host sent more data than the user >>> asked the kernel for -- but maybe the user didn't ask for all the >>> data that he expected. Ma

Re: [PATCH] usb: gadget: f_fs: report error if excess data received

2016-05-16 Thread Michal Nazarewicz
> Alan Stern writes: >> The point is that you don't know whether the host sent more data than >> expected. All you know is that the host sent more data than the user >> asked the kernel for -- but maybe the user didn't ask for all the >> data that he expected. Maybe the user wanted to retrieve t

RE: [PATCH] usb: gadget: f_fs: report error if excess data received

2016-05-16 Thread Felipe Balbi
Hi, Alan Stern writes: > On Fri, 13 May 2016, Felipe Balbi wrote: > >> We deliver to userspace the part userspace requested, right? So that's >> okay. The USB details WRT e.g. babble or host trying to send more data >> than expected, needs to be handled within the kernel. > > The point is that y

hello linux

2016-05-16 Thread Joe Bryant
Salutations linux http://qualityonions.com/forget.php?return=rzpbyfqyv1rn41c56 Joe -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v8 13/14] usb: gadget: udc: adapt to OTG core

2016-05-16 Thread Roger Quadros
On 16/05/16 12:23, Peter Chen wrote: > On Mon, May 16, 2016 at 11:26:57AM +0300, Roger Quadros wrote: >> Hi, >> >> On 16/05/16 10:02, Peter Chen wrote: >>> On Fri, May 13, 2016 at 01:03:27PM +0300, Roger Quadros wrote: + +static int usb_gadget_connect_control(struct usb_gadget *gadget, bo

Re: [PATCH v5 1/2] USB: serial: cp210x: Adding GPIO support for CP2105

2016-05-16 Thread Martyn Welch
On 12/04/16 09:15, Martyn Welch wrote: On 12/04/16 09:08, Johan Hovold wrote: On Tue, Apr 12, 2016 at 09:01:52AM +0100, Martyn Welch wrote: Johan, Thanks for reviewing the other patch in this series. I haven't seen any feedback regarding this patch, is it still in your queue? It is, and I

Re: [PATCH v8 13/14] usb: gadget: udc: adapt to OTG core

2016-05-16 Thread Peter Chen
On Mon, May 16, 2016 at 11:26:57AM +0300, Roger Quadros wrote: > Hi, > > On 16/05/16 10:02, Peter Chen wrote: > > On Fri, May 13, 2016 at 01:03:27PM +0300, Roger Quadros wrote: > >> + > >> +static int usb_gadget_connect_control(struct usb_gadget *gadget, bool > >> connect) > >> +{ > >> + struct

Re: [PATCH v8 08/14] usb: otg: add OTG/dual-role core

2016-05-16 Thread Roger Quadros
On 13/05/16 13:03, Roger Quadros wrote: > It provides APIs for the following tasks > > - Registering an OTG/dual-role capable controller > - Registering Host and Gadget controllers to OTG core > - Providing inputs to and kicking the OTG state machine > > Provide a dual-role device (DRD) state mac

[PATCH] dwc3: gadget: Implement the suspend entry event handler

2016-05-16 Thread Baolin Wang
It had changed to be suspend event for BIT6 in DEVT register from version 2.30a and above. Thus this patch introduces one suspend event handler to handle the suspend event. Signed-off-by: Baolin Wang --- drivers/usb/dwc3/gadget.c | 26 +- 1 file changed, 25 insertions(+

Re: [PATCH v7 10/14] usb: otg: add hcd companion support

2016-05-16 Thread Roger Quadros
On 16/05/16 11:13, Peter Chen wrote: > On Mon, May 16, 2016 at 11:01:27AM +0300, Roger Quadros wrote: >> On 16/05/16 05:13, Peter Chen wrote: >>> On Thu, May 12, 2016 at 03:13:48PM +0300, Roger Quadros wrote: Hi, On 12/05/16 13:31, Yoshihiro Shimoda wrote: > Hi, > >> From

Re: [PATCH v8 13/14] usb: gadget: udc: adapt to OTG core

2016-05-16 Thread Roger Quadros
Hi, On 16/05/16 10:02, Peter Chen wrote: > On Fri, May 13, 2016 at 01:03:27PM +0300, Roger Quadros wrote: >> + >> +static int usb_gadget_connect_control(struct usb_gadget *gadget, bool >> connect) >> +{ >> +struct usb_udc *udc; >> + >> +mutex_lock(&udc_lock); >> +udc = usb_gadget_to_u

Re: [PATCH v7 10/14] usb: otg: add hcd companion support

2016-05-16 Thread Peter Chen
On Mon, May 16, 2016 at 11:01:27AM +0300, Roger Quadros wrote: > On 16/05/16 05:13, Peter Chen wrote: > > On Thu, May 12, 2016 at 03:13:48PM +0300, Roger Quadros wrote: > >> Hi, > >> > >> On 12/05/16 13:31, Yoshihiro Shimoda wrote: > >>> Hi, > >>> > From: Roger Quadros > Sent: Thursday, M

Re: [PATCH v8 10/14] usb: otg: add hcd companion support

2016-05-16 Thread Roger Quadros
On 13/05/16 21:13, Rob Herring wrote: > On Fri, May 13, 2016 at 5:03 AM, Roger Quadros wrote: >> From: Yoshihiro Shimoda >> >> Since some host controller (e.g. EHCI) needs a companion host controller >> (e.g. OHCI), this patch adds such a configuration to use it in the OTG >> core. >> >> Signed-o

Re: [PATCH v7 10/14] usb: otg: add hcd companion support

2016-05-16 Thread Roger Quadros
On 16/05/16 05:13, Peter Chen wrote: > On Thu, May 12, 2016 at 03:13:48PM +0300, Roger Quadros wrote: >> Hi, >> >> On 12/05/16 13:31, Yoshihiro Shimoda wrote: >>> Hi, >>> From: Roger Quadros Sent: Thursday, May 12, 2016 6:32 PM Hi, On 12/05/16 11:34, Roger Quadros wrot

Re: [PATCH v8 13/14] usb: gadget: udc: adapt to OTG core

2016-05-16 Thread Peter Chen
On Fri, May 13, 2016 at 01:03:27PM +0300, Roger Quadros wrote: > + > +static int usb_gadget_connect_control(struct usb_gadget *gadget, bool > connect) > +{ > + struct usb_udc *udc; > + > + mutex_lock(&udc_lock); > + udc = usb_gadget_to_udc(gadget); > + if (!udc) { > + d