Re: question on trust in chaoskey

2016-05-20 Thread Oliver Neukum
On Fri, 2016-05-20 at 17:13 -0700, Steve Calfee wrote: > A clever attacker would provide a false USB key which is "almost" > random. This would allow them to decrypt messages based on the false > key, with nobody else knowing there was a vulnerability. An almost > random number simplifies

Re: [RFC PATCHv2] usb: USB Type-C Connector Class

2016-05-20 Thread Guenter Roeck
On 05/20/2016 06:37 AM, Oliver Neukum wrote: On Fri, 2016-05-20 at 14:24 +0300, Heikki Krogerus wrote: On Thu, May 19, 2016 at 04:47:17PM +0200, Oliver Neukum wrote: Please explain. How does that express DRP but prefered master? Sorry but I'm not sure what you mean here. If the port is

Re: [OOPS] cppi41_dma_channel_program: Unable to handle kernel NULL pointer dereference

2016-05-20 Thread Bin Liu
Hi, On Fri, May 20, 2016 at 4:20 PM, Matwey V. Kornilov wrote: > 2016-05-21 0:12 GMT+03:00 Bin Liu : >> Hi, >> >> On Sat, May 21, 2016 at 12:05:06AM +0300, Matwey V. Kornilov wrote: >>> By the way, is it ok that function musb_rx_dma_iso_cppi41 uses >>>

Re: [PATCH v8 13/14] usb: gadget: udc: adapt to OTG core

2016-05-20 Thread Peter Chen
On Fri, May 20, 2016 at 10:26:03AM +0300, Roger Quadros wrote: > Peter, > > On 20/05/16 04:39, Peter Chen wrote: > > On Wed, May 18, 2016 at 03:45:11PM +0300, Roger Quadros wrote: > >> On 18/05/16 06:18, Peter Chen wrote: > >>> On Mon, May 16, 2016 at 12:51:53PM +0300, Roger Quadros wrote: >

Re: [PATCH v8 13/14] usb: gadget: udc: adapt to OTG core

2016-05-20 Thread Peter Chen
On Thu, May 19, 2016 at 10:32:44AM +0300, Roger Quadros wrote: > On 18/05/16 17:46, Jun Li wrote: > > > > > > I didn't want to have complex Kconfig so decided to have otg as > built-in only. > What do you want me to change in existing code? and why? > >>> > >>> Remove those

Re: question on trust in chaoskey

2016-05-20 Thread Steve Calfee
Hi Keith, On Thu, May 19, 2016 at 9:23 PM, Keith Packard wrote: > Dave Tian writes: > >> I am personally in favor of a TPM-like solution, since we probably >> couldn’t/shouldn’t disable the firmware update anyway, >> and we really need a hardware

Re: NET2280: Adding PLX usb2380 support (issues encountered)

2016-05-20 Thread Tim Harvey
On Thu, May 12, 2016 at 3:48 PM, Justin DeFields wrote: > On Thu, May 12, 2016 at 6:27 PM, Tim Harvey wrote: >> On Tue, Jan 26, 2016 at 6:40 AM, Justin DeFields >> wrote: >>> I spoke with the Avago/PLX FAE, and they said

Re: [PATCH] net: usb: ch9200: use kmemdup

2016-05-20 Thread David Miller
From: Muhammad Falak R Wani Date: Thu, 19 May 2016 19:26:50 +0530 > Use kmemdup when some other buffer is immediately copied into allocated > region. It replaces call to allocation followed by memcpy, by a single > call to kmemdup. > > Signed-off-by: Muhammad Falak R Wani

[PATCH 1/2] usb: dwc3: Fix DWC3_USB31_REVISION_110A definition

2016-05-20 Thread John Youn
The DWC3_USB31_REVISION_110A macro uses an invalid constant name in its definition. This is currently not used. Signed-off-by: John Youn --- drivers/usb/dwc3/core.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/dwc3/core.h

[PATCH 2/2] usb: dwc3: Use the correct speed macros for DSTS/DCFG

2016-05-20 Thread John Youn
Correct the use of the DWC3_DSTS_XXX_SPEED and DWC3_DCFG_XXX_SPEED macros. The wrong set of macros were being used in a few places. This is only a cosmetic change as the values for both sets are identical. Signed-off-by: John Youn --- drivers/usb/dwc3/gadget.c | 24

[PATCH v2 09/13] usb: dwc2: gadget: Add dwc2_gadget_start_next_request function

2016-05-20 Thread John Youn
From: Vardan Mikayelyan Replaced repeating code with function call. Starts next request from ep queue. If queue is empty and ep is isoc -In case of OUT-EP unmasks OUTTKNEPDIS. OUTTKNEPDIS is masked in it's handler, so we need to unmask it here to be able to do

[PATCH v2 06/13] usb: dwc2: gadget: Add dwc2_gadget_incr_frame_num()

2016-05-20 Thread John Youn
From: Vardan Mikayelyan Increases and checks targeted frame number of current ep if overrun happened, sets flag and masks with DSTS_SOFFN_LIMIT Added following fields to struct dwc2_hsotg_ep -target_frame: Targeted frame num to setup next ISOC transfer -frame_overrun:

[PATCH v2 10/13] usb: dwc2: gadget: Add OUTTKNEPDIS and NAKINTRPT handlers

2016-05-20 Thread John Youn
From: Vardan Mikayelyan NAKINTRPT interrupt is starting point for isoc-in transfer, synchronization done with first in token received from host, core asserts this interrupt when responds with 0 length data to in token, received from host. The first IN token is asynchronous

[PATCH v2 05/13] usb: dwc2: gadget: Fix transfer stop programming for out endpoint

2016-05-20 Thread John Youn
From: Vardan Mikayelyan According DWC-OTG databook, "GOUTNakEff" is read only and can be cleared only by "DCTL.CGOUTNak", but here we do not need to clear it because DWC-OTG programming guide says that before disabling any OUT endpoint, the application must enable Global

[PATCH v2 08/13] usb: dwc2: gadget: Add dwc2_gadget_read_ep_interrupts function

2016-05-20 Thread John Youn
From: Vardan Mikayelyan Reads and returns interrupts for given endpoint, by masking epint_reg with corresponding mask. Tested-by: John Keeping Signed-off-by: Vardan Mikayelyan Signed-off-by: John Youn ---

[PATCH v2 07/13] usb: dwc2: gadget: Corrected interval calculation

2016-05-20 Thread John Youn
From: Vardan Mikayelyan Calculate the interval according to the USB 2.0 specification section 9.6.6. Tested-by: John Keeping Signed-off-by: Vardan Mikayelyan Signed-off-by: John Youn ---

[PATCH v2 13/13] usb: dwc2: gadget: Final fixes for BDMA ISOC

2016-05-20 Thread John Youn
From: Vardan Mikayelyan Done fixes and tested hsotg gadget's BDMA mode. Tested Control, Bulk, Isoc, Inter transfers. Added code for isoc transfers, removed unusable code, done minor fixes. Affected functions and IRQ handlers: - dwc2_hsotg_start_req(), -

[PATCH v2 11/13] usb: dwc2: gadget: Add Incomplete ISO IN/OUT Interrupt handlers

2016-05-20 Thread John Youn
From: Vardan Mikayelyan Incomplete ISO IN interrupt indicates one of the following conditions occurred while transmitting an ISOC transaction. - Corrupted IN Token for ISOC EP. - Packet not complete in FIFO. Incomplete ISO OUT indicates that there is at least one

[PATCH v2 12/13] usb: dwc2: gadget: Add EP disabled interrupt handler

2016-05-20 Thread John Youn
From: Vardan Mikayelyan Reimplemented EP disabled interrupt handler and moved to corresponding function. This interrupt indicates that the endpoint has been disabled per the application's request. For IN endpoints flushes txfifo, in case of BULK clears DCTL_CGNPINNAK, in

[PATCH v2 02/13] usb: dwc2: gadget: Remove unnecessary line

2016-05-20 Thread John Youn
From: Vardan Mikayelyan Removed "ctrl |= DXEPCTL_USBACTEP" from dwc2_hsotg_start_req() function because this step is done in dwc2_hsotg_ep_enable(). Tested-by: John Keeping Signed-off-by: Vardan Mikayelyan Signed-off-by: John Youn

[PATCH v2 04/13] usb: dwc2: gadget: Corrected field names

2016-05-20 Thread John Youn
From: Vardan Mikayelyan No-op change. Changed field names to prevent misunderstanding. Tested-by: John Keeping Signed-off-by: Vardan Mikayelyan Signed-off-by: John Youn --- drivers/usb/dwc2/gadget.c | 6

[PATCH v2 01/13] usb: dwc2: Add missing register field definitions

2016-05-20 Thread John Youn
From: Vardan Mikayelyan Added register field definitions, register names are according DWC-OTG databook. Tested-by: John Keeping Signed-off-by: Vardan Mikayelyan Signed-off-by: John Youn ---

[PATCH v2 03/13] usb: dwc2: gadget: Remove unnecessary code

2016-05-20 Thread John Youn
From: Vardan Mikayelyan This chunk is not needed here. There is no functionality depend on this, so if no-op, I think we do not need to have this interrupt unmasked. Tested-by: John Keeping Signed-off-by: Vardan Mikayelyan

[PATCH v2 00/13] usb: dwc2: Fix up gadget isochronous support

2016-05-20 Thread John Youn
The following patch series fixes up isochronous support for the dwc2 gadget. The existing isochronous support lacked a few features. Most notably it did not properly sync up with the first packet and it didn't handle the Incomplete ISO IN/OUT interrupts. These patches have been sitting in our

Re: [PATCH][v3.13.y-ckt][v3.19-ckt][v4.2.y-ckt]Revert "usb: hub: do not clear BOS field during reset device"

2016-05-20 Thread Kamal Mostafa
On Fri, May 20, 2016 at 11:56:39AM -0400, Joseph Salisbury wrote: > Hello, > > Please consider including commit > e5bdfd50d6f76077bf8441d130c606229e100d40 in the next v3.13.y-ckt, > v3.19-ckt and v4.2.y-ckt releases. Queued up for 3.19- and 4.2- ckt stable. (3.13.y-ckt is no longer

[PATCH] usb: host: ehci-msm: Conditionally call ehci suspend/resume

2016-05-20 Thread Andy Gross
This patch fixes a suspend/resume issue where the driver is blindly calling ehci_suspend/resume functions when the ehci hasn't been setup. This results in a crash during suspend/resume operations. Signed-off-by: Andy Gross --- drivers/usb/host/ehci-msm.c | 14

Re: [OOPS] cppi41_dma_channel_program: Unable to handle kernel NULL pointer dereference

2016-05-20 Thread Matwey V. Kornilov
2016-05-21 0:12 GMT+03:00 Bin Liu : > Hi, > > On Sat, May 21, 2016 at 12:05:06AM +0300, Matwey V. Kornilov wrote: >> By the way, is it ok that function musb_rx_dma_iso_cppi41 uses >> hw_ep->tx_channel? I would suppose that it should use rx_channel >> instead. > > I just got here, and

Re: [OOPS] cppi41_dma_channel_program: Unable to handle kernel NULL pointer dereference

2016-05-20 Thread Bin Liu
Hi, On Sat, May 21, 2016 at 12:05:06AM +0300, Matwey V. Kornilov wrote: > By the way, is it ok that function musb_rx_dma_iso_cppi41 uses > hw_ep->tx_channel? I would suppose that it should use rx_channel > instead. I just got here, and am wondering the same. But the question is why just your

Re: [OOPS] cppi41_dma_channel_program: Unable to handle kernel NULL pointer dereference

2016-05-20 Thread Matwey V. Kornilov
By the way, is it ok that function musb_rx_dma_iso_cppi41 uses hw_ep->tx_channel? I would suppose that it should use rx_channel instead. 2016-05-20 23:58 GMT+03:00 Matwey V. Kornilov : > (gdb) frame 3 > #3 musb_host_rx (musb=0xdb3e0010, epnum=) at >

Re: [OOPS] cppi41_dma_channel_program: Unable to handle kernel NULL pointer dereference

2016-05-20 Thread Matwey V. Kornilov
(gdb) frame 3 #3 musb_host_rx (musb=0xdb3e0010, epnum=) at ../drivers/usb/musb/musb_host.c:1969 1969done = musb_rx_dma_inventra_cppi41(c, hw_ep, qh, urb, xfer_len); (gdb) info locals hw_ep = 0xdb3e0f48 c = epio = qh = 0xd9cb2000 xfer_len = mbase = iso_err =

Re: [OOPS] cppi41_dma_channel_program: Unable to handle kernel NULL pointer dereference

2016-05-20 Thread Matwey V. Kornilov
I used kgdb. Is it ok? channel appeared to be 0x0: (gdb) continue Continuing. [Switching to Thread 315] Breakpoint 1, cppi41_dma_channel_program (channel=0x0, packet_sz=960, mode=0 '\000', dma_addr=2609136576, len=960) at ../drivers/usb/musb/musb_cppi41.c:481 481 { (gdb) bt #0

Re: [PATCH v2 1/2] musb: sunxi: Add set_mode platform function

2016-05-20 Thread Bin Liu
Hi, On Mon, May 16, 2016 at 03:11:34PM -0500, Bin Liu wrote: > On Sat, May 14, 2016 at 02:45:04PM +0200, Hans de Goede wrote: > > Move the mode handling to the platform_set_mode callback. > > > > Signed-off-by: Hans de Goede > > Signed-off-by: Bin Liu I

Re: [PATCH 0/2] musb_host: TX DMA cleanup after Tony's patches to the MUSB host driver

2016-05-20 Thread Bin Liu
Hi, On Wed, May 04, 2016 at 01:49:06AM +0300, Sergei Shtylyov wrote: > Hello. > >Here's 2 patches against the 'next' branch of Felipe's 'usb.git' repo. Tony > Lindgren's patches from the last year didn't seem complete, so trying to clean > up the TX DMA patch... > > [1/2] musb_host: move

[[PATCH v2] 1/2] usb: musb: host: clear rxcsr error bit if set

2016-05-20 Thread Bin Liu
The MUSB Programming Guide states that the driver should clear RXCSR bit2 when the controller sets the bit. Signed-off-by: Bin Liu --- v2: no change. drivers/usb/musb/musb_host.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/musb/musb_host.c

[[PATCH v2] 2/2] usb: musb: host: don't start next rx urb if current one failed

2016-05-20 Thread Bin Liu
urb->status is set when endpoint csr RXSTALL, H_ERROR, DATAERROR or INCOMPRX bit is set. Those bits mean a broken pipe, so don't start next urb when any of these bits is set by checking urb->status. To minimize the risk of regression, only do so for RX, until we have a test case to understand the

Re: [OOPS] cppi41_dma_channel_program: Unable to handle kernel NULL pointer dereference

2016-05-20 Thread Bin Liu
Hi, On Fri, May 20, 2016 at 04:32:06PM +0300, Matwey V. Kornilov wrote: > 2016-05-20 16:19 GMT+03:00 : > > Hello, > > > > I am running 4.6-rc3 on BealgeBone Black and when I try to interract > > with pwc webcam attached to usb port the following kernel panic > > happening. >

[PATCH v2] usb: musb: only restore devctl when session was set in backup

2016-05-20 Thread Bin Liu
If the session bit was not set in the backup of devctl register, restoring devctl would clear the session bit. Therefor, only restore devctl register when the session bit was set in the backup. This solves the device enumeration failure in otg mode exposed by commit 56f487c (PM / Runtime: Update

RE: [PATCH 2/2] usb: musb: Stop bulk endpoint while queue is rotated

2016-05-20 Thread Andrew Goodbody
> From: Sergei Shtylyov [mailto:sergei.shtyl...@cogentembedded.com] > On 05/20/2016 08:06 PM, Andrew Goodbody wrote: > > >>> Ensure that the endpoint is stopped by clearing REQPKT before > >>> clearing DATAERR_NAKTIMEOUT before rotating the queue on the > >>> dedicated bulk endpoint. > >>> This

Re: usb: customized USB Hub device doubt

2016-05-20 Thread Greg KH
On Fri, May 20, 2016 at 09:20:15PM +0530, Muni Sekhar wrote: > Hi, > > > We have a customized USB Hub device which has a inbuilt device attached to it. > > By default Linux kernel’s USB Hub Class driver claims the customized Hub. > > I need to Send Vendor Specific command to my USB Hub to

Re: [PATCH 2/2] usb: musb: Stop bulk endpoint while queue is rotated

2016-05-20 Thread Sergei Shtylyov
On 05/20/2016 08:06 PM, Andrew Goodbody wrote: Ensure that the endpoint is stopped by clearing REQPKT before clearing DATAERR_NAKTIMEOUT before rotating the queue on the dedicated bulk endpoint. This addresses an issue where a race could result in the endpoint receiving data before it was

RE: [PATCH 2/2] usb: musb: Stop bulk endpoint while queue is rotated

2016-05-20 Thread Andrew Goodbody
> From: Sergei Shtylyov [mailto:sergei.shtyl...@cogentembedded.com] > On 05/20/2016 05:51 PM, Andrew Goodbody wrote: > > > Ensure that the endpoint is stopped by clearing REQPKT before clearing > > DATAERR_NAKTIMEOUT before rotating the queue on the dedicated bulk > > endpoint. > > This addresses

Re: [RFC PATCHv2] usb: USB Type-C Connector Class

2016-05-20 Thread Guenter Roeck
On Fri, May 20, 2016 at 01:47:03PM +0300, Heikki Krogerus wrote: > On Thu, May 19, 2016 at 10:53:04AM -0700, Guenter Roeck wrote: > > Hello Heikki, > > > > On Thu, May 19, 2016 at 03:44:54PM +0300, Heikki Krogerus wrote: > > > The purpose of this class is to provide unified interface for user > >

RE: [PATCH 1/2] usb: musb: Ensure rx reinit occurs for shared_fifo endpoints

2016-05-20 Thread Andrew Goodbody
> From: Sergei Shtylyov [mailto:sergei.shtyl...@cogentembedded.com] > > Hello. > > On 05/20/2016 05:51 PM, Andrew Goodbody wrote: > > > shared_fifo endpoints would only get a previous tx state cleared out, > > the rx state was only cleared for non shared_fifo endpoints Change > > this so that

Re: [PATCH 1/1] net: pegasus: remove dead coding

2016-05-20 Thread David Miller
From: Petko Manolov Date: Fri, 20 May 2016 10:33:47 +0300 > On 16-05-19 11:35:42, David Miller wrote: >> From: Heinrich Schuchardt >> Date: Wed, 18 May 2016 02:13:30 +0200 >> >> > (!count || count < 4) is always true. >> > So let's remove the coding

Re: [PATCH] net: pegasus: remove unused variables and labels

2016-05-20 Thread David Miller
From: Arnd Bergmann Date: Fri, 20 May 2016 10:22:30 +0200 > The latest dead-code removal was slightly incomplete and > left a few things behind that we now get compiler warnings > for: > > drivers/net/usb/pegasus.c: In function 'read_bulk_callback': >

Re: [PATCH 2/2] usb: musb: Stop bulk endpoint while queue is rotated

2016-05-20 Thread Sergei Shtylyov
On 05/20/2016 05:51 PM, Andrew Goodbody wrote: Ensure that the endpoint is stopped by clearing REQPKT before clearing DATAERR_NAKTIMEOUT before rotating the queue on the dedicated bulk endpoint. This addresses an issue where a race could result in the endpoint receiving data before it was

Re: [PATCH] usb: echi-hcd: Add ehci_setup check before echi_shutdown

2016-05-20 Thread Andy Gross
On 20 May 2016 at 10:57, Alan Stern wrote: > On Fri, 20 May 2016, Andy Gross wrote: > >> On 20 May 2016 at 09:31, Alan Stern wrote: >> > On Thu, 19 May 2016, Andy Gross wrote: >> > >> >> On 19 May 2016 at 05:12, Srinivas Kandagatla >> >>

[PATCH][v3.13.y-ckt][v3.19-ckt][v4.2.y-ckt]Revert "usb: hub: do not clear BOS field during reset device"

2016-05-20 Thread Joseph Salisbury
Hello, Please consider including commit e5bdfd50d6f76077bf8441d130c606229e100d40 in the next v3.13.y-ckt, v3.19-ckt and v4.2.y-ckt releases. It was included upstream as of v4.5-rc6. This commit has been tested and resolves the following bug: http://pad.lv/1582864. According to the commit

Re: [PATCH] usb: echi-hcd: Add ehci_setup check before echi_shutdown

2016-05-20 Thread Alan Stern
On Fri, 20 May 2016, Andy Gross wrote: > On 20 May 2016 at 09:31, Alan Stern wrote: > > On Thu, 19 May 2016, Andy Gross wrote: > > > >> On 19 May 2016 at 05:12, Srinivas Kandagatla > >> wrote: > >> > >> > >> > >> > +++

Re: [PATCH] usb: echi-hcd: Add ehci_setup check before echi_shutdown

2016-05-20 Thread Andy Gross
On 20 May 2016 at 09:31, Alan Stern wrote: > On Thu, 19 May 2016, Andy Gross wrote: > >> On 19 May 2016 at 05:12, Srinivas Kandagatla >> wrote: >> >> >> >> > +++ b/drivers/usb/host/ehci-hcd.c >> > @@ -368,6 +368,15 @@ static void

Re: [PATCH 1/2] usb: musb: Ensure rx reinit occurs for shared_fifo endpoints

2016-05-20 Thread Sergei Shtylyov
Hello. On 05/20/2016 05:51 PM, Andrew Goodbody wrote: shared_fifo endpoints would only get a previous tx state cleared out, the rx state was only cleared for non shared_fifo endpoints Change this so that the rx state is cleared for all endpoints. This addresses an issue that resulted in rx

[PATCH 0/2] usb: musb: fix dropped packets

2016-05-20 Thread Andrew Goodbody
The musb driver can drop rx packets when heavily loaded. These two patches address two issues that can cause this. Both issues arose when an endpoint was reprogrammed. The first patch is a logic bug that resulted in a shared_fifo in rx mode not having its state cleared out. The second patch fixes

[PATCH 1/2] usb: musb: Ensure rx reinit occurs for shared_fifo endpoints

2016-05-20 Thread Andrew Goodbody
shared_fifo endpoints would only get a previous tx state cleared out, the rx state was only cleared for non shared_fifo endpoints Change this so that the rx state is cleared for all endpoints. This addresses an issue that resulted in rx packets being dropped silently. Signed-off-by: Andrew

[PATCH 2/2] usb: musb: Stop bulk endpoint while queue is rotated

2016-05-20 Thread Andrew Goodbody
Ensure that the endpoint is stopped by clearing REQPKT before clearing DATAERR_NAKTIMEOUT before rotating the queue on the dedicated bulk endpoint. This addresses an issue where a race could result in the endpoint receiving data before it was reprogrammed resulting in a warning about such data

Re: [PATCH] - silence UBSAN complaint in ehci-hcd.

2016-05-20 Thread Alan Stern
On Thu, 19 May 2016, Valdis Kletnieks wrote: > UBSAN throws a complaint: > > [2.418579] UBSAN: Undefined behaviour in > drivers/usb/host/ehci-hub.c:877:47 > [2.418582] index -1 is out of range for type 'u32 [1]' > > though it's only on the hostpc[] part, not on the port_status[] on

Re: [PATCH] - silence UBSAN complaint in ehci-hcd.

2016-05-20 Thread Alan Stern
On Thu, 19 May 2016 valdis.kletni...@vt.edu wrote: > On Thu, 19 May 2016 17:50:31 -0700, Greg Kroah-Hartman said: > > On Thu, May 19, 2016 at 05:19:00PM -0400, Valdis Kletnieks wrote: > > > UBSAN throws a complaint: > > > > > > [2.418579] UBSAN: Undefined behaviour in > > >

Re: [PATCH] usb: echi-hcd: Add ehci_setup check before echi_shutdown

2016-05-20 Thread Alan Stern
On Thu, 19 May 2016, Andy Gross wrote: > On 19 May 2016 at 05:12, Srinivas Kandagatla > wrote: > > > > > +++ b/drivers/usb/host/ehci-hcd.c > > @@ -368,6 +368,15 @@ static void ehci_shutdown(struct usb_hcd *hcd) > > { > > struct ehci_hcd *ehci =

Re: [RFC PATCHv2] usb: USB Type-C Connector Class

2016-05-20 Thread Oliver Neukum
On Thu, 2016-05-19 at 15:44 +0300, Heikki Krogerus wrote: > Like I've told some of you guys, I'm trying to implement a bus for > the Alternate Modes, but I'm still nowhere near finished with that > one, so let's just get the class ready now. The altmode bus should in > any case not affect the

Re: [RFC 4/8] usb: phy: move TCSR driver into new file

2016-05-20 Thread Arnd Bergmann
On Friday 20 May 2016 13:44:14 Mark Brown wrote: > On Fri, May 20, 2016 at 02:24:14PM +0200, Arnd Bergmann wrote: > > On Thursday 19 May 2016 14:08:43 Andy Gross wrote: > > > > I'd rather do something like what we did for the GSBI. It needed to > > > change some phy related bits in the TCSR as

Re: xhci DWC3 flavor problem

2016-05-20 Thread Mathias Nyman
On 19.05.2016 18:42, Joao Pinto wrote: After a few moments the schedule problem happen again: # INFO: task kworker/0:1:349 blocked for more than 120 seconds. Not tainted 4.6.0-rc5 #9 "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message. kworker/0:1 D

Re: [RFC PATCHv2] usb: USB Type-C Connector Class

2016-05-20 Thread Oliver Neukum
On Fri, 2016-05-20 at 14:24 +0300, Heikki Krogerus wrote: > On Thu, May 19, 2016 at 04:47:17PM +0200, Oliver Neukum wrote: > > > > Please explain. How does that express DRP but prefered master? > > Sorry but I'm not sure what you mean here. If the port is capable of > being used as dual role port

Re: [OOPS] cppi41_dma_channel_program: Unable to handle kernel NULL pointer dereference

2016-05-20 Thread Matwey V. Kornilov
2016-05-20 16:19 GMT+03:00 : > Hello, > > I am running 4.6-rc3 on BealgeBone Black and when I try to interract with pwc > webcam attached to usb port the following kernel panic happening. Please note, that the same is happening with 4.6.0 release. > > Please also find used

[OOPS] cppi41_dma_channel_program: Unable to handle kernel NULL pointer dereference

2016-05-20 Thread matwey
Hello, I am running 4.6-rc3 on BealgeBone Black and when I try to interract with pwc webcam attached to usb port the following kernel panic happening. Please also find used kernel config here:

Re: [RFC 4/8] usb: phy: move TCSR driver into new file

2016-05-20 Thread Mark Brown
On Fri, May 20, 2016 at 02:24:14PM +0200, Arnd Bergmann wrote: > On Thursday 19 May 2016 14:08:43 Andy Gross wrote: > > I'd rather do something like what we did for the GSBI. It needed to > > change some phy related bits in the TCSR as well. We defined the TCSR > > as a syscon, with binding

Re: [RFC 4/8] usb: phy: move TCSR driver into new file

2016-05-20 Thread Arnd Bergmann
On Thursday 19 May 2016 14:08:43 Andy Gross wrote: > > + * - Tim > > + */ > > +int qcom_tcsr_phy_sel(u32 val) > > +{ > > + void __iomem *phy_select; > > + int ret; > > + > > + phy_select = ioremap(USB2_PHY_SEL, 4); > > + > > + if (!phy_select) { > > +

Re: USB 3.1 Gen 2 - 4.6 mainline broken

2016-05-20 Thread Mathias Nyman
Hi I'm adding the mailing list to this reply (removed your contact info) USB 3.1 Gen 2 in 4.6 is not broken just because device is not seen as SuperSpeedPlus 10Gbps device. On 20.05.2016 02:04, Everett Wenzel wrote: Hello, I noticed that an FPGA was used to develop most of the USB3.1 Gen2

Re: [RFC PATCHv2] usb: USB Type-C Connector Class

2016-05-20 Thread Heikki Krogerus
On Thu, May 19, 2016 at 04:47:17PM +0200, Oliver Neukum wrote: > On Thu, 2016-05-19 at 15:44 +0300, Heikki Krogerus wrote: > > The purpose of this class is to provide unified interface for user > > space to get the status and basic information about USB Type-C > > Connectors in the system, control

Re: [RFC PATCHv2] usb: USB Type-C Connector Class

2016-05-20 Thread Heikki Krogerus
On Thu, May 19, 2016 at 08:43:27AM -0700, Greg KH wrote: > On Thu, May 19, 2016 at 04:48:46PM +0200, Oliver Neukum wrote: > > On Thu, 2016-05-19 at 15:44 +0300, Heikki Krogerus wrote: > > > + ret = typec_register_altmodes(dev, partner->alt_modes); > > > + if (ret) { > > > +

Re: [RFC PATCHv2] usb: USB Type-C Connector Class

2016-05-20 Thread Heikki Krogerus
On Thu, May 19, 2016 at 10:53:04AM -0700, Guenter Roeck wrote: > Hello Heikki, > > On Thu, May 19, 2016 at 03:44:54PM +0300, Heikki Krogerus wrote: > > The purpose of this class is to provide unified interface for user > > space to get the status and basic information about USB Type-C > >

[PATCH v2 1/1] usb: gadget: f_fs: Fix wrong check on reserved1 of OS_DESC_EXT_COMPAT

2016-05-20 Thread Jim Lin
Current __ffs_data_do_os_desc() of f_fs.c will check reserved1 field of OS_DESC_EXT_COMPAT and return -EINVAL if it's 1. But MS OS 1.0 Descriptors http://msdn.microsoft.com/en-us/library/windows/hardware/gg463179.aspx defines that field to be 1. Signed-off-by: Jim Lin --- v2:

Re: [PATCH] net: pegasus: remove unused variables and labels

2016-05-20 Thread Arnd Bergmann
On Friday 20 May 2016 12:32:23 Petko Manolov wrote: > Guys, come on. This code is not dead. This code is executed every time an > ethernet packet is received. It takes care of various error statistics. More > importantly, it sends the actual (reported by the adapter) packet length to > the

Re: [PATCH v8 08/14] usb: otg: add OTG/dual-role core

2016-05-20 Thread Peter Chen
On Fri, May 20, 2016 at 12:19:07PM +0300, Roger Quadros wrote: > On 20/05/16 11:31, Roger Quadros wrote: > > On 18/05/16 15:59, Roger Quadros wrote: > >> Hi Peter, > >> > >> On 18/05/16 10:45, Peter Chen wrote: > >>> > >>> > >>> On Mon, May 16, 2016 at 5:00 PM, Roger Quadros >>>

[PATCH 1/1] usbip: don't call stub_device_reset() during stub_disconnect()

2016-05-20 Thread Alexander Popov
stub_disconnect() calls stub_device_reset() during usb_unbind_device() when usb device is locked. So usb_lock_device_for_reset() in stub_device_reset() in that case polls for one second and returns -EBUSY anyway. Remove useless flag USBIP_EH_RESET from SDEV_EVENT_REMOVED. Signed-off-by:

Re: [PATCH] net: pegasus: remove unused variables and labels

2016-05-20 Thread Petko Manolov
Guys, come on. This code is not dead. This code is executed every time an ethernet packet is received. It takes care of various error statistics. More importantly, it sends the actual (reported by the adapter) packet length to the network layer along with the packet. This patch removes

[PATCH v9 10/14] usb: otg: add hcd companion support

2016-05-20 Thread Roger Quadros
Since some host controller (e.g. EHCI) needs a companion host controller (e.g. OHCI), this patch adds such a configuration to use it in the OTG core. Signed-off-by: Yoshihiro Shimoda Signed-off-by: Roger Quadros Acked-by: Peter Chen

[PATCH v9 09/14] usb: of: add an API to get OTG device from USB controller node

2016-05-20 Thread Roger Quadros
The OTG controller and the USB controller can be linked via the 'otg-controller' property in the USB controller's device node. of_usb_get_otg() can be used to get the OTG controller device from the USB controller's device node. Signed-off-by: Roger Quadros Acked-by: Peter Chen

Re: [PATCH v8 08/14] usb: otg: add OTG/dual-role core

2016-05-20 Thread Roger Quadros
On 20/05/16 11:31, Roger Quadros wrote: > On 18/05/16 15:59, Roger Quadros wrote: >> Hi Peter, >> >> On 18/05/16 10:45, Peter Chen wrote: >>> >>> >>> On Mon, May 16, 2016 at 5:00 PM, Roger Quadros >> > wrote: >>> >>> On 13/05/16 13:03, Roger Quadros

[PATCH v11 1/4] gadget: Introduce the usb charger framework

2016-05-20 Thread Baolin Wang
This patch introduces the usb charger driver based on usb gadget that makes an enhancement to a power driver. It works well in practice but that requires a system with suitable hardware. The basic conception of the usb charger is that, when one usb charger is added or removed by reporting from

[PATCH v11 2/4] gadget: Support for the usb charger framework

2016-05-20 Thread Baolin Wang
For supporting the usb charger, it adds the usb_charger_init() and usb_charger_exit() functions for usb charger initialization and exit. It will report to the usb charger when the gadget state is changed, then the usb charger can do the power things. Signed-off-by: Baolin Wang

[PATCH v11 3/4] gadget: Integrate with the usb gadget supporting for usb charger

2016-05-20 Thread Baolin Wang
When the usb gadget supporting for usb charger is ready, the usb charger can implement the usb_charger_plug_by_gadget() function and usb_charger_exit() function by getting 'struct usb_charger' from 'struct gadget'. Signed-off-by: Baolin Wang ---

[PATCH v11 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-05-20 Thread Baolin Wang
Currently the Linux kernel does not provide any standard integration of this feature that integrates the USB subsystem with the system power regulation provided by PMICs meaning that either vendors must add this in their kernels or USB gadget devices based on Linux (such as mobile phones) may not

Re: [PATCH v8 08/14] usb: otg: add OTG/dual-role core

2016-05-20 Thread Roger Quadros
On 18/05/16 15:59, Roger Quadros wrote: > Hi Peter, > > On 18/05/16 10:45, Peter Chen wrote: >> >> >> On Mon, May 16, 2016 at 5:00 PM, Roger Quadros > > wrote: >> >> On 13/05/16 13:03, Roger Quadros wrote: >> > It provides APIs for the following

[PATCH] net: pegasus: remove unused variables and labels

2016-05-20 Thread Arnd Bergmann
The latest dead-code removal was slightly incomplete and left a few things behind that we now get compiler warnings for: drivers/net/usb/pegasus.c: In function 'read_bulk_callback': drivers/net/usb/pegasus.c:475:1: error: label 'goon' defined but not used [-Werror=unused-label]

Re: ZTE 403ZT supported ?

2016-05-20 Thread Oliver Neukum
On Mon, 2016-05-16 at 02:43 +, YAMAMOTO Hiroyuki wrote: > Hi USB serial experts, > > I am trying to support ZTE 403ZT modem by linux serial driver. > > Currently, option driver can not be used for the modem, because USB Class > Code of the modem does not match. > Linux driver has 0xff as

Re: ffs-test fails with warning (-19) No such device

2016-05-20 Thread Krzysztof Opasiak
On 05/19/2016 03:43 PM, jan.hu...@k2l.de wrote: > I'm trying to establish a high performance USB connection from device/gadget > to host. On the USB gadget side I'm running on a Atmel ATSAMA5D35-EK. The > Linux Kernel version is 4.1 (4.1.0-linux4sam_5.2-00045-g633e08a) and I'm > using

Re: [PATCH 1/1] net: pegasus: remove dead coding

2016-05-20 Thread Petko Manolov
On 16-05-19 11:35:42, David Miller wrote: > From: Heinrich Schuchardt > Date: Wed, 18 May 2016 02:13:30 +0200 > > > (!count || count < 4) is always true. > > So let's remove the coding which is dead at least since 2005. > > > > Signed-off-by: Heinrich Schuchardt

Re: [PATCH v8 13/14] usb: gadget: udc: adapt to OTG core

2016-05-20 Thread Roger Quadros
Peter, On 20/05/16 04:39, Peter Chen wrote: > On Wed, May 18, 2016 at 03:45:11PM +0300, Roger Quadros wrote: >> On 18/05/16 06:18, Peter Chen wrote: >>> On Mon, May 16, 2016 at 12:51:53PM +0300, Roger Quadros wrote: On 16/05/16 12:23, Peter Chen wrote: > On Mon, May 16, 2016 at

Re: composite gadget with _real_ USB device

2016-05-20 Thread Felipe Balbi
Hi, Shea Ako writes: > I’ve been learning about and playing with configfs and functionfs to > create composite user space USB gadgets. My objective is to create a > composite USB gadget that incorporates a custom functionfs function of > my own creation along with some

Re: [PATCH 2/2] usb: dwc3: gadget: Various fixes to trbs_left calculation

2016-05-20 Thread Felipe Balbi
Hi, John Youn writes: > On 5/19/2016 12:51 AM, Felipe Balbi wrote: >> >> Hi, >> >> John Youn writes: >>> This patch fixes up some issues related to the trb_left calculation. >>> >>> This calculation sometimes included the link trb slot in the