Re: [PATCH v10 2/7] usb: mux: add generic code for dual role port mux

2016-06-05 Thread Peter Chen
On Mon, Jun 06, 2016 at 10:45:34AM +0800, Lu Baolu wrote: > Hi Peter, > > On 06/06/2016 10:05 AM, Peter Chen wrote: > > On Sun, Jun 05, 2016 at 04:46:55PM +0800, Lu Baolu wrote: > >> Hi, > >> > >> On 06/05/2016 04:33 PM, Jun Li wrote: > Port mux is part of dual role switch, but not the whole

[PATCH v2] usb: dwc3: host: Set the dma_ops for xhci device

2016-06-05 Thread Baolin Wang
On ARM64 platform, it will set 'dummy_dma_ops' for device dma_ops if it did not call 'arch_setup_dma_ops' at device creation time, that will cause failure when setting the dma mask for device. Thus this patch set the xhci device dma_ops from the parent device if the xhci device dma_ops is 'dummy_d

Re: [v2, 2/2] phy: rockchip-inno-usb2: add a new driver for Rockchip usb2phy

2016-06-05 Thread Frank Wang
Hi Heiko & Guenter, On 2016/6/4 5:24, Heiko Stübner wrote: Am Freitag, 3. Juni 2016, 12:59:22 schrieb Guenter Roeck: On Thu, Jun 02, 2016 at 02:48:10PM +0800, Frank Wang wrote: The newer SoCs (rk3366, rk3399) take a different usb-phy IP block than rk3288 and before, and most of phy-related reg

Re: [v2, 2/2] phy: rockchip-inno-usb2: add a new driver for Rockchip usb2phy

2016-06-05 Thread Frank Wang
Hi Guenter, On 2016/6/4 3:57, Guenter Roeck wrote: On Thu, Jun 02, 2016 at 02:48:10PM +0800, Frank Wang wrote: The newer SoCs (rk3366, rk3399) take a different usb-phy IP block than rk3288 and before, and most of phy-related registers are also different from the past, so a new phy driver is req

Re: [v2, 1/2] Documentation: bindings: add DT documentation for Rockchip USB2PHY

2016-06-05 Thread Frank Wang
Hi Guenter, On 2016/6/4 3:25, Guenter Roeck wrote: On Thu, Jun 02, 2016 at 02:48:09PM +0800, Frank Wang wrote: Signed-off-by: Frank Wang --- Changes in v2: - Changed vbus_host optional property from gpio to regulator. - Specified vbus_otg-supply optional property. - Specified otg_id and

Re: [PATCH v3 06/12] power: pwrseq: simple: Add support for regulator and generic property

2016-06-05 Thread Peter Chen
On Fri, Jun 03, 2016 at 02:35:08PM +0200, Krzysztof Kozlowski wrote: > On 06/03/2016 04:02 AM, Rob Herring wrote: > > On Wed, Jun 01, 2016 at 10:02:15AM +0200, Krzysztof Kozlowski wrote: > >> Some devices need real hard-reset by cutting the power. During power > >> sequence turn off and on the reg

Re: [PATCH v10 2/7] usb: mux: add generic code for dual role port mux

2016-06-05 Thread Lu Baolu
Hi Peter, On 06/06/2016 09:25 AM, Peter Chen wrote: > On Sun, Jun 05, 2016 at 02:55:56PM +0800, Lu Baolu wrote: >> Hi Peter, >> >> On 06/04/2016 10:28 AM, Peter Chen wrote: >>> On Sat, Jun 04, 2016 at 12:06:06AM +0800, Lu Baolu wrote: > from my point,it is a dual-role switch > driver too,

Re: [PATCH v10 2/7] usb: mux: add generic code for dual role port mux

2016-06-05 Thread Lu Baolu
Hi Peter, On 06/06/2016 10:05 AM, Peter Chen wrote: > On Sun, Jun 05, 2016 at 04:46:55PM +0800, Lu Baolu wrote: >> Hi, >> >> On 06/05/2016 04:33 PM, Jun Li wrote: Port mux is part of dual role switch, but not the whole thing. > Dual role switch includes at least below things: > - ID

Re: [PATCH v10 2/7] usb: mux: add generic code for dual role port mux

2016-06-05 Thread Lu Baolu
Hi Jun, On 06/06/2016 09:08 AM, Jun Li wrote: > >> -Original Message- >> From: Lu Baolu [mailto:baolu...@linux.intel.com] >> Sent: Sunday, June 05, 2016 4:47 PM >> To: Jun Li ; Peter Chen >> Cc: felipe.ba...@linux.intel.com; Mathias Nyman ; >> Greg Kroah-Hartman ; Lee Jones >> ; Heikki Kr

RE: [PATCH 1/2] usb: configfs: allow UDC binding rule configured as binding to *any* UDC

2016-06-05 Thread Du, Changbin
Thanks, Machek, This patch has already been dropped. > On Tue 2016-05-03 11:04:24, changbin...@intel.com wrote: > > From: "Du, Changbin" > > > > On most platforms, there is only one device controller available. > > In this case, we desn't care the UDC's name. So let's ignore the > > name by setti

Re: [PATCH v10 2/7] usb: mux: add generic code for dual role port mux

2016-06-05 Thread Peter Chen
On Sun, Jun 05, 2016 at 04:46:55PM +0800, Lu Baolu wrote: > Hi, > > On 06/05/2016 04:33 PM, Jun Li wrote: > >> Port mux is part of dual role switch, but not the whole thing. > >> > > >> > Dual role switch includes at least below things: > >> > - ID or type-C event detection > >> > - port mux >

Re: [PATCH v10 2/7] usb: mux: add generic code for dual role port mux

2016-06-05 Thread Peter Chen
On Sun, Jun 05, 2016 at 02:55:56PM +0800, Lu Baolu wrote: > Hi Peter, > > On 06/04/2016 10:28 AM, Peter Chen wrote: > > On Sat, Jun 04, 2016 at 12:06:06AM +0800, Lu Baolu wrote: > >>> from my point,it is a dual-role switch > >>> driver too, > >> No, it's not a dual-role switch driver, but a driver

RE: [PATCH v10 2/7] usb: mux: add generic code for dual role port mux

2016-06-05 Thread Jun Li
> -Original Message- > From: Lu Baolu [mailto:baolu...@linux.intel.com] > Sent: Sunday, June 05, 2016 4:47 PM > To: Jun Li ; Peter Chen > Cc: felipe.ba...@linux.intel.com; Mathias Nyman ; > Greg Kroah-Hartman ; Lee Jones > ; Heikki Krogerus ; > Liam Girdwood ; Mark Brown ; > linux-usb@vg

Re: OHCI: NULL or LIST_POISON dereference on ueagle-atm disconnection

2016-06-05 Thread Alan Stern
On Sun, 5 Jun 2016, Michał Pecio wrote: > OK, so I added those printks and I think I know what's going on. > > Apparently, ed_schedule failure triggers 'goto fail' and leaves the ed > in some non-IDLE state so that it never gets added to the list indeed. > > The failing EP 0x88 is 1kB isochronou

Re: clear halt

2016-06-05 Thread Dave Mielke
[quoted lines by Greg KH on 2016/06/05 at 14:23 -0700] >> Using USBFS: If a device doesn't support clear halt (or, perhaps, not >> properly), is there an alternative? For example, is there a way to ask which >> state the device's data toggle is in and then tell the host what state to >> reset

Re: clear halt

2016-06-05 Thread Greg KH
On Sun, Jun 05, 2016 at 05:00:12PM -0400, Dave Mielke wrote: > Using USBFS: If a device doesn't support clear halt (or, perhaps, not > properly), is there an alternative? For example, is there a way to ask which > state the device's data toggle is in and then tell the host what state to > reset

clear halt

2016-06-05 Thread Dave Mielke
Using USBFS: If a device doesn't support clear halt (or, perhaps, not properly), is there an alternative? For example, is there a way to ask which state the device's data toggle is in and then tell the host what state to reset its end to? -- Dave Mielke | 2213 Fox Crescent | The Bibl

Re: OHCI: NULL or LIST_POISON dereference on ueagle-atm disconnection

2016-06-05 Thread Michał Pecio
OK, so I added those printks and I think I know what's going on. Apparently, ed_schedule failure triggers 'goto fail' and leaves the ed in some non-IDLE state so that it never gets added to the list indeed. The failing EP 0x88 is 1kB isochronous, btw, so it all looks plausible. Code (v3.18, newe

Re: [PATCH] usb: usbip: fix null pointer dereference

2016-06-05 Thread Sudip Mukherjee
On Friday 03 June 2016 09:29 AM, Krzysztof Opasiak wrote: On 06/02/2016 03:22 PM, Sudip Mukherjee wrote: We have been dereferencing udc before checking it. Lets use it after it has been checked. To be honest I have mixed feelings about this patch. On one hand it prevents us from dereferenc

Re: OHCI: NULL or LIST_POISON dereference on ueagle-atm disconnection

2016-06-05 Thread Alan Stern
On Sat, 4 Jun 2016, Greg KH wrote: > On Sat, Jun 04, 2016 at 10:05:27AM +0200, Michał Pecio wrote: > > > Hi, I think I have a bug in the OHCI driver. > > > > > > Kernel version: 4.4.11 (some old 3.14 seems fine, didn't try others) > > > > 3.18.34 and 4.7-rc1 are affected too. > > > > The bug se

Re: EHCI fails to schedule large full-speed isochronous transfers

2016-06-05 Thread Alan Stern
yOn Sat, 4 Jun 2016, Greg KH wrote: > On Sat, Jun 04, 2016 at 08:32:43PM +0200, Michał Pecio wrote: > > Hi, > > > > Why high-bandwidth USB 1.1 isochronous devices don't work on 2.0 hosts? You mean, on EHCI hosts -- they do work on other USB-2 host controllers, as far as I know. Basically, the

[PATCH v3 4/4] musb: sunxi: Simplify dr_mode handling

2016-06-05 Thread Hans de Goede
phy-sun4i-usb now has proper dr_mode handling, it always registers an extcon, and sends a notify with the mode (even when in peripheral- / host-only mode) at least once. So we can simply the sunxi musb glue by always registering its extcon notifier and relying on sunxi_musb_work() to enable vbus w

[PATCH v3 3/4] phy-sun4i-usb: Add workaround for missing Vbus det interrupts on A31

2016-06-05 Thread Hans de Goede
The A31 companion pmic (axp221) does not generate vbus change interrupts when the board is driving vbus, so we must poll when using the pmic for vbus-det _and_ we're driving vbus. Signed-off-by: Hans de Goede --- Changes in v2: -No changes Changes in v3: -No changes --- drivers/phy/phy-sun4i-usb

[PATCH v3 1/4] USB: Fix of_usb_get_dr_mode_by_phy with a shared phy block

2016-06-05 Thread Hans de Goede
Some SoCs have a single phy-hw-block with multiple phys, this is modelled by a single phy dts node, so we end up with multiple controller nodes with a phys property pointing to the phy-node of the otg-phy. Only one of these controllers typically is an otg controller, yet we were checking the first

[PATCH v3 2/4] phy-sun4i-usb: Add support for peripheral-only mode

2016-06-05 Thread Hans de Goede
Use the new of_usb_get_dr_mode_by_phy() function to get the dr_mode from the musb controller node instead of assuming that having an id_det gpio means otg mode, and not having one means host mode. Implement peripheral-only mode by adding a sun4i_usb_phy0_get_id_det helper which looks at the dr_mod

Re: [PATCH v2,3/5] dt-bindings: mtu3: add devicetree bindings

2016-06-05 Thread chunfeng yun
On Fri, 2016-06-03 at 15:34 +0200, Matthias Brugger wrote: > > On 31/05/16 07:52, Chunfeng Yun wrote: > > add a DT binding doc for MediaTek USB3 DRD driver > > > > Signed-off-by: Chunfeng Yun > > --- > > Documentation/devicetree/bindings/usb/mtu3.txt | 85 > > > > 1

Re: [PATCH v10 2/7] usb: mux: add generic code for dual role port mux

2016-06-05 Thread Lu Baolu
Hi, On 06/05/2016 04:33 PM, Jun Li wrote: >> Port mux is part of dual role switch, but not the whole thing. >> > >> > Dual role switch includes at least below things: >> > - ID or type-C event detection >> > - port mux >> > - VBUS management >> > - start/stop host/device controllers >> > >>

RE: [PATCH v10 2/7] usb: mux: add generic code for dual role port mux

2016-06-05 Thread Jun Li
Hi > -Original Message- > From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb- > ow...@vger.kernel.org] On Behalf Of Lu Baolu > Sent: Sunday, June 05, 2016 2:56 PM > To: Peter Chen > Cc: felipe.ba...@linux.intel.com; Mathias Nyman ; > Greg Kroah-Hartman ; Lee Jones > ; Heikki Krogerus