Re: [PATCH 1/3] usb: pci: Remove unnecessary pci_set_drvdata().

2016-06-07 Thread Greg KH
On Wed, May 11, 2016 at 06:08:15PM +0530, Sandhya Bankar wrote: > Unnecessary [platform|pci]_set_drvdata() have been removed since the driver > core clears the driver data to NULLafter device release or on probe failure. > There is no need to manually clear the > device driver data to NULL.

Re: [PATCH v5 resend 1/2] ehci-platform: Add support for controllers with multiple reset lines

2016-06-07 Thread Greg Kroah-Hartman
On Thu, Jun 02, 2016 at 05:14:05PM +0200, Hans de Goede wrote: > From: Reinder de Haan > > At least the EHCI/OHCI found on the Allwinnner H3 SoC needs multiple > reset lines, the controller will not initialize while the reset for > its companion is still asserted, which

Re: [PATCH v10 6/7] usb: pci-quirks: add Intel USB drcfg mux device

2016-06-07 Thread Greg Kroah-Hartman
On Thu, Jun 02, 2016 at 09:37:28AM +0800, Lu Baolu wrote: > In some Intel platforms, a single usb port is shared between USB host > and device controllers. The shared port is under control of a switch > which is defined in the Intel vendor defined extended capability for > xHCI. > > This patch

Re: [PATCH v10 1/7] regulator: fixed: add support for ACPI interface

2016-06-07 Thread Greg Kroah-Hartman
On Thu, Jun 02, 2016 at 09:37:23AM +0800, Lu Baolu wrote: > Add support to retrieve fixed voltage configure information through > ACPI interface. This is needed for Intel Bay Trail devices, where a > GPIO is used to control the USB vbus. > > Signed-off-by: Lu Baolu >

[PATCH v3 2/2] ARM: at91/dt: sama5d2: Use new compatible for ohci node

2016-06-07 Thread Wenyou Yang
Use compatible "atmel,sama5d2-ohci" to be capable of suspending ports while sleep to save the power consumption. Signed-off-by: Wenyou Yang --- Changes in v3: None Changes in v2: - Use the new compatible for ohci-node. arch/arm/boot/dts/sama5d2.dtsi | 2 +- 1 file

[PATCH v3 1/2] usb: ohci-at91: Forcibly suspend ports while USB suspend

2016-06-07 Thread Wenyou Yang
In order to the save power consumption, as a workaround, suspend forcibly the USB PORTA/B/C via set the SUSPEND_A/B/C bits of OHCI Interrupt Configuration Register in the SFRs while OHCI USB suspend. This suspend operation must be done before the USB clock is disabled, resume after the USB clock

[PATCH v3 0/2] ARM: ohci-at91: Add support to forcibly suspend ports while sleep

2016-06-07 Thread Wenyou Yang
To save the power consumption, add a new compatible to support forcibly suspend the USB PORTA/B/C via OHCI Interrupt Configuration SFR Register. Changes in v3: - Change the compatible description for more precise. Changes in v2: - Add compatible to support forcibly suspend the ports. - Add

Re: [balbi-usb:testing/next 64/67] phy-generic.c:undefined reference to `usb_gadget_vbus_connect'

2016-06-07 Thread Peter Chen
On Tue, Jun 07, 2016 at 01:22:37PM +0300, Felipe Balbi wrote: > > Hi, > > Peter Chen writes: > >> >> > kbuild test robot writes: > >> >> >> tree: > >> >> >> https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git > >> >> >> testing/next

RE: [PATCH v10 2/7] usb: mux: add generic code for dual role port mux

2016-06-07 Thread Jun Li
Hi, > -Original Message- > From: Felipe Balbi [mailto:felipe.ba...@linux.intel.com] > Sent: Tuesday, June 07, 2016 11:05 PM > To: Roger Quadros ; Lu Baolu ; > Jun Li ; Peter Chen > Cc: Mathias Nyman

Re: [PATCH 0/2] hwrng: chaoskey - Add support for Araneus Alea I USB RNG

2016-06-07 Thread Greg KH
On Wed, Jun 08, 2016 at 08:49:55AM +0800, Herbert Xu wrote: > On Tue, Jun 07, 2016 at 03:03:11PM -0700, Greg KH wrote: > > > > Ok, but usually drivers/usb/misc/ patches go through my tree :) > > Sorry. But I do wonder whether this driver should be moved as > it is just an hwrng device like every

Re: [PATCH 0/2] hwrng: chaoskey - Add support for Araneus Alea I USB RNG

2016-06-07 Thread Herbert Xu
On Tue, Jun 07, 2016 at 03:03:11PM -0700, Greg KH wrote: > > Ok, but usually drivers/usb/misc/ patches go through my tree :) Sorry. But I do wonder whether this driver should be moved as it is just an hwrng device like every other driver under hw_random, except for the fact that it happens to be

[balbi-usb:testing/next 64/67] powercap_sys.c:undefined reference to `usb_gadget_vbus_connect'

2016-06-07 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git testing/next head: fc4d1f3f522648d92d0c046beedbc1469979499a commit: 74e51eb7b5b4f7ab33c099c20def3dce0c699006 [64/67] usb: gadget: move gadget API functions to udc-core config: arm-hisi_defconfig (attached as .config)

[PATCH] usb: xhci: handle uPD720201 and uPD720202 w/o ROM

2016-06-07 Thread Christian Lamparter
This patch adds a firmware check for the uPD720201K8-711-BAC-A and uPD720202K8-711-BAA-A variant. Both of these chips are listed in Renesas' R19UH0078EJ0500 Rev.5.00 "User's Manual: Hardware" as devices which need a firmware in order to work as they do not have support to load the firmware from an

Re: [PATCH 0/2] hwrng: chaoskey - Add support for Araneus Alea I USB RNG

2016-06-07 Thread Greg KH
On Tue, Jun 07, 2016 at 06:53:45PM +0800, Herbert Xu wrote: > On Fri, Jun 03, 2016 at 12:13:06PM +0100, Bob Ham wrote: > > Two patches to add support for the Araneus Alea I USB RNG to the > > chaoskey driver. The first simply includes the Alea I as a device, > > the second fixes an issue with the

Re: [XHCI: Help needed] One hang issue when using XHCI host driver playing Video for Isochronous transfer

2016-06-07 Thread Greg KH
On Tue, Jun 07, 2016 at 06:30:56PM +0800, Tang Jianqiang wrote: > Hi Mathias && Balbi and ALL, >We hit one hang issue when using DWC3 XHCI host mode to play Video > for Isochronous transfer. >Both usb-audio module and XHCI driver output errors. > Our kernel version is 3.18.x. That is

Re: [PATCH] USB: core: fix missing include

2016-06-07 Thread kbuild test robot
Hi, [auto build test ERROR on usb/usb-testing] [also build test ERROR on v4.7-rc2 next-20160607] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Ben-Dooks/USB-core-fix-missing-include-linux-usb

[PATCH v6] r8152: Add support for setting pass through MAC address on RTL8153-AD

2016-06-07 Thread Mario Limonciello
The RTL8153-AD supports a persistent system specific MAC address. This means a device plugged into two different systems with host side support will show different (but persistent) MAC addresses. This information for the system's persistent MAC address is burned in when the system HW is built and

[PATCH] USB: core: fix missing include

2016-06-07 Thread Ben Dooks
The helper function usb_of_get_child_node() is defined in the header but this was not included. Fix the warning about usb_of_get_child_node() not being declared by adding the right include. Fixes: drivers/usb/core/of.c:31:20: warning: symbol 'usb_of_get_child_node' was not declared. Should it

Re: [PATCH v5] r8152: Add support for setting pass through MAC address on RTL8153-AD

2016-06-07 Thread Pali Rohár
Hi! Another problem which I found now: On Tuesday 07 June 2016 10:33:47 Mario Limonciello wrote: > + ret = hex2bin(buf, obj->string.pointer + 9, 6); > + if (!(ret == 0 && is_valid_ether_addr(buf))) { > + netif_warn(tp, probe, tp->netdev, > +"Invalid MAC

Re: [PATCH] USB: OHCI: Don't mark EDs as ED_OPER if scheduling fails

2016-06-07 Thread Alan Stern
On Tue, 7 Jun 2016, Michał Pecio wrote: > > Greg, in principle this should go to -stable. However, it looks like > > this might break some applications that currently sort-of work, even > > though they shouldn't. Therefore we have decided not to mark this > > patch for -stable at present. >

Re: USB broken on Banana Pi in Linux 4.6

2016-06-07 Thread Greg KH
On Tue, Jun 07, 2016 at 07:06:00PM +0200, Marc Haber wrote: > On Fri, Jun 03, 2016 at 08:35:11AM -0700, Greg KH wrote: > > On Fri, Jun 03, 2016 at 08:53:58AM +0200, Marc Haber wrote: > > > On Mon, May 30, 2016 at 01:47:12PM -0700, Greg KH wrote: > > > > On Mon, May 30, 2016 at 09:02:54PM +0200,

Re: [PATCH v3 2/2] phy: rockchip-inno-usb2: add a new driver for Rockchip usb2phy

2016-06-07 Thread Guenter Roeck
On Tue, Jun 07, 2016 at 04:12:29PM +0200, Heiko Stübner wrote: > Hi Guenter, > > Am Dienstag, 7. Juni 2016, 06:19:45 schrieb Guenter Roeck: > > On Tue, Jun 7, 2016 at 2:54 AM, Heiko Stübner wrote: > > > Hi Frank, > > > > > > Am Montag, 6. Juni 2016, 17:20:04 schrieb Frank Wang:

Re: USB broken on Banana Pi in Linux 4.6

2016-06-07 Thread Marc Haber
On Fri, Jun 03, 2016 at 08:35:11AM -0700, Greg KH wrote: > On Fri, Jun 03, 2016 at 08:53:58AM +0200, Marc Haber wrote: > > On Mon, May 30, 2016 at 01:47:12PM -0700, Greg KH wrote: > > > On Mon, May 30, 2016 at 09:02:54PM +0200, Marc Haber wrote: > > > > Hi, > > > > > > > > on my Bananapis, in

Re: [RFC PATCHv2] usb: USB Type-C Connector Class

2016-06-07 Thread Guenter Roeck
On Mon, Jun 06, 2016 at 04:28:08PM +0300, Heikki Krogerus wrote: [ ... ] > > I would prefer lower case letters. I don't know the SIDs there are at > them moment, other then Display Port. Do you know them? > SIDs: 0xff00 - power delivery 0xff01 - displayport 0xff02 - MHL

Re: [PATCH] USB: OHCI: Don't mark EDs as ED_OPER if scheduling fails

2016-06-07 Thread Michał Pecio
> Greg, in principle this should go to -stable. However, it looks like > this might break some applications that currently sort-of work, even > though they shouldn't. Therefore we have decided not to mark this > patch for -stable at present. This means leaving three longterm branches with a

[PATCH v5] r8152: Add support for setting pass through MAC address on RTL8153-AD

2016-06-07 Thread Mario Limonciello
The RTL8153-AD supports a persistent system specific MAC address. This means a device plugged into two different systems with host side support will show different (but persistent) MAC addresses. This information for the system's persistent MAC address is burned in when the system HW is built and

Re: Race condition in usbfs / libusb when using reap-after-disconnect

2016-06-07 Thread Alan Stern
On Tue, 7 Jun 2016, Hans de Goede wrote: > Hi, > > On 06-06-16 19:03, Alan Stern wrote: > > On Mon, 6 Jun 2016, Hans de Goede wrote: > > > >> Hi, > >> > >> On 06-06-16 16:48, Greg Kroah-Hartman wrote: > >>> On Mon, Jun 06, 2016 at 01:44:23PM +0200, Hans de Goede wrote: > Hi All, > >

Re: [PATCH v10 2/7] usb: mux: add generic code for dual role port mux

2016-06-07 Thread Felipe Balbi
Hi, Roger Quadros writes: >> I might be able to find some time to implement a proof of concept which >> would allow your platforms to get dual-role with code we already have, >> but I need DWC3's OTG support which, I'm assuming, you already have :-) >> >> If you wanna try

RE: Re: Re: Re: [PATCH] usb: core: fix a double free in the usb driver

2016-06-07 Thread Alan Stern
On Tue, 7 Jun 2016, Chung-Geol Kim wrote: > = > At *remove USB(3.0) Storage > sequence <1> --> <5> ((Problem Case)) > = > VOLD >

Re: http://www.linux-usb.org/gadget/usb.c exambple problem.

2016-06-07 Thread Alan Stern
On Tue, 7 Jun 2016, Brian Park wrote: > Hi, > I need help with getting http://www.linux-usb.org/gadget/usb.c > working on my Beagle Bone Black based embedded board. I'm using TI > Processor SDK 2.00.02.11 with their linux kernel > linux-4.1.18+gitAUTOINC+bbe8cfc1da-gbbe8cfc. My application is

Re: OHCI: NULL or LIST_POISON dereference on ueagle-atm disconnection

2016-06-07 Thread Alan Stern
On Tue, 7 Jun 2016, Michał Pecio wrote: > > That's clear enough. > > > > ISO IN 1007 bytes -> 793 us > > INT IN 32 bytes -> 35 us > > -- > > 825 us > > > > The additional requirements are: > > > > ISO IN 48 bytes -> 45 us

Re: [PATCH] USB: OHCI: Don't mark EDs as ED_OPER if scheduling fails

2016-06-07 Thread Alan Stern
On Tue, 7 Jun 2016, Michał Pecio wrote: > Since ed_schedule begins with marking the ED as "operational", > the ED may be left in such state even if scheduling actually > fails. > > This allows future submission attempts to smuggle this ED to the > hardware behind the scheduler's back and without

Re: [PATCH v3 2/2] phy: rockchip-inno-usb2: add a new driver for Rockchip usb2phy

2016-06-07 Thread Heiko Stübner
Hi Guenter, Am Dienstag, 7. Juni 2016, 06:19:45 schrieb Guenter Roeck: > On Tue, Jun 7, 2016 at 2:54 AM, Heiko Stübner wrote: > > Hi Frank, > > > > Am Montag, 6. Juni 2016, 17:20:04 schrieb Frank Wang: > >> The newer SoCs (rk3366, rk3399) take a different usb-phy IP block > >>

Re: [PATCH v9 5/5] usb: dwc3: core: cleanup IRQ resources

2016-06-07 Thread Roger Quadros
On 07/06/16 16:09, Felipe Balbi wrote: > > Hi, > > (guys, please make sure to break lines at 80-columns) > > Roger Quadros writes: >> @@ -2853,6 +2852,23 @@ static irqreturn_t dwc3_interrupt(int irq, void >> *_evt) >>int dwc3_gadget_init(struct dwc3 *dwc) >>

Re: [PATCH v10 2/7] usb: mux: add generic code for dual role port mux

2016-06-07 Thread Roger Quadros
On 07/06/16 16:04, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: >>> But you said I must run an unnecessary OTG state machine, even thought it >>> has nothing to do with my system, only because the two sides of my port >>> mux device is a host and peripheral controller.

RE: [PATCH v4] r8152: Add support for setting pass through MAC address on RTL8153-AD

2016-06-07 Thread Hayes Wang
Mario Limonciello [mailto:mario_limoncie...@dell.com] [...] > + ret = hex2bin(buf, obj->string.pointer + 9, 6); > + if (ret < 0 || !is_valid_ether_addr(buf)) { > + netif_warn(tp, probe, tp->netdev, "Invalid MAC\n"); > + goto amacout;

Re: [PATCH v9 5/5] usb: dwc3: core: cleanup IRQ resources

2016-06-07 Thread Felipe Balbi
Hi, (guys, please make sure to break lines at 80-columns) Roger Quadros writes: > @@ -2853,6 +2852,23 @@ static irqreturn_t dwc3_interrupt(int irq, void > *_evt) >int dwc3_gadget_init(struct dwc3 *dwc) >{ >intret; > +

Re: [PATCH v10 2/7] usb: mux: add generic code for dual role port mux

2016-06-07 Thread Felipe Balbi
Hi, Roger Quadros writes: >> But you said I must run an unnecessary OTG state machine, even thought it >> has nothing to do with my system, only because the two sides of my port >> mux device is a host and peripheral controller. > > We have a minimal dual-role state machine that

Re: [PATCH v10 2/7] usb: mux: add generic code for dual role port mux

2016-06-07 Thread Roger Quadros
On 07/06/16 12:53, Lu Baolu wrote: > Hi, > > On 06/07/2016 11:03 AM, Jun Li wrote: >> Hi Roger >> >>> >>> For Mux devices implementing dual-role, the mux device driver _must_ use >>> OTG/dual-role core API so that a common ABI is presented to user space for >>> OTG/dual-role. >> That's the only

Re: Nokia N900: musb is in wrong state after boot

2016-06-07 Thread Pali Rohár
On Sunday 29 May 2016 12:38:24 Pali Rohár wrote: > > From fd67b58e3538c0732750ecad915cde736da099dc Mon Sep 17 00:00:00 2001 > > From: =?UTF-8?q?Pali=20Roh=C3=A1r?= > > Date: Sat, 9 Jan 2016 16:57:59 +0100 > > Subject: [PATCH] musb: debugfs: Add support in testmode for

Re: [PATCH v10 2/7] usb: mux: add generic code for dual role port mux

2016-06-07 Thread Roger Quadros
On 07/06/16 12:27, Lu Baolu wrote: > Hi, > > On 06/07/2016 02:34 PM, Jun Li wrote: On 06/07/2016 11:03 AM, Jun Li wrote: >> Hi Roger >> For Mux devices implementing dual-role, the mux device driver _must_ use OTG/dual-role core API so that a common ABI is

Re: [PATCH v9 5/5] usb: dwc3: core: cleanup IRQ resources

2016-06-07 Thread Roger Quadros
On 07/06/16 14:49, Grygorii Strashko wrote: > On 06/07/2016 12:34 PM, Roger Quadros wrote: >> On 02/06/16 14:52, Grygorii Strashko wrote: >>> On 06/01/2016 10:46 AM, Roger Quadros wrote: Implementations might use different IRQs for host, gadget and OTG so use named interrupt resources

Re: [PATCH v9 5/5] usb: dwc3: core: cleanup IRQ resources

2016-06-07 Thread Grygorii Strashko
On 06/07/2016 12:34 PM, Roger Quadros wrote: > On 02/06/16 14:52, Grygorii Strashko wrote: >> On 06/01/2016 10:46 AM, Roger Quadros wrote: >>> Implementations might use different IRQs for >>> host, gadget and OTG so use named interrupt resources >>> to allow Device tree to specify the 3

RE: [RFC][PATCH] usb: gadget: Allow to build both USB functions and legacy gadgets

2016-06-07 Thread Peter Chen
>-Original Message- >From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb-ow...@vger.kernel.org] >On Behalf Of Krzysztof Opasiak >Sent: Tuesday, June 07, 2016 3:46 PM >To: Peter Chen >Cc: Krzysztof Opasiak ; ba...@kernel.org; Greg Kroah-

Re: [PATCH 0/2] hwrng: chaoskey - Add support for Araneus Alea I USB RNG

2016-06-07 Thread Herbert Xu
On Fri, Jun 03, 2016 at 12:13:06PM +0100, Bob Ham wrote: > Two patches to add support for the Araneus Alea I USB RNG to the > chaoskey driver. The first simply includes the Alea I as a device, > the second fixes an issue with the timeout on the first read. > > Bob Ham (2): > hwrng: chaoskey -

[XHCI: Help needed] One hang issue when using XHCI host driver playing Video for Isochronous transfer

2016-06-07 Thread Tang Jianqiang
Hi Mathias && Balbi and ALL, We hit one hang issue when using DWC3 XHCI host mode to play Video for Isochronous transfer. Both usb-audio module and XHCI driver output errors. Our kernel version is 3.18.x. And already include Mathias's commit: 1> xhci: fix off by one error in TRB

[PATCH] USB: OHCI: Don't mark EDs as ED_OPER if scheduling fails

2016-06-07 Thread Michał Pecio
Since ed_schedule begins with marking the ED as "operational", the ED may be left in such state even if scheduling actually fails. This allows future submission attempts to smuggle this ED to the hardware behind the scheduler's back and without linking it to the ohci->eds_in_use list. The former

[PATCH 1/2] usb: dwc3: pci: add dr-mode for Intel dwc3

2016-06-07 Thread Felipe Balbi
It's know that Intel's SoCs' dwc3 integration is peripheral-only since Intel implements its own portmux for role-swapping. In order to prevent dwc3 from ever registering and XHCI platform_device, let's just set dr-mode to peripheral-only on Intel SoCs. Signed-off-by: Felipe Balbi

[PATCH 2/2] usb: dwc3: core: fixup dr_mode fallback selection

2016-06-07 Thread Felipe Balbi
We shouldn't change a host-only dwc3 to gadget-only if driver is built as gadget-only. Fix that up here. Signed-off-by: Felipe Balbi --- drivers/usb/dwc3/core.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/usb/dwc3/core.c

Re: [balbi-usb:testing/next 64/67] phy-generic.c:undefined reference to `usb_gadget_vbus_connect'

2016-06-07 Thread Felipe Balbi
Hi, Peter Chen writes: >> >> > kbuild test robot writes: >> >> >> tree: https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git >> >> >> testing/next >> >> >> head: 89fe2b5ab11cdf6a67d4492d893e70e330aa7060 >> >> >> commit:

Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

2016-06-07 Thread Joao Pinto
Hi, Just to add my tested-by to the patch sent by Grygorii Strashko on 03/31/2016 (https://lkml.org/lkml/2016/3/31/609). The patch was tested on a v4.6 kernel, running in a Juno r1 development board, being the USB 3.0 Host prototyped in a FPGA. Tested-by: Joao Pinto

Re: [RFC][PATCH] usb: gadget: Allow to build both USB functions and legacy gadgets

2016-06-07 Thread Krzysztof Opasiak
Hi, On Tue, Jun 7, 2016 at 11:06 AM, Peter Chen wrote: > > >>-Original Message- >>From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb-ow...@vger.kernel.org] >>On Behalf Of Krzysztof Opasiak >>Sent: Tuesday, June 07, 2016 3:46 PM >>To: Peter Chen

Re: Race condition in usbfs / libusb when using reap-after-disconnect

2016-06-07 Thread Hans de Goede
Hi, On 06-06-16 19:03, Alan Stern wrote: On Mon, 6 Jun 2016, Hans de Goede wrote: Hi, On 06-06-16 16:48, Greg Kroah-Hartman wrote: On Mon, Jun 06, 2016 at 01:44:23PM +0200, Hans de Goede wrote: Hi All, While looking at libusb today I ended up looking at the reap-after-disconnect code.

Re: [balbi-usb:testing/next 64/67] phy-generic.c:undefined reference to `usb_gadget_vbus_connect'

2016-06-07 Thread Peter Chen
On Tue, Jun 07, 2016 at 12:36:13PM +0300, Felipe Balbi wrote: > > Hi, > > Peter Chen writes: > > On Mon, Jun 06, 2016 at 04:16:17PM +0300, Felipe Balbi wrote: > >> > >> Hi, > >> > >> Felipe Balbi writes: > >> > [ Unknown signature status ]

Re: [PATCH v3 2/2] phy: rockchip-inno-usb2: add a new driver for Rockchip usb2phy

2016-06-07 Thread Heiko Stübner
Hi Frank, Am Montag, 6. Juni 2016, 17:20:04 schrieb Frank Wang: > The newer SoCs (rk3366, rk3399) take a different usb-phy IP block > than rk3288 and before, and most of phy-related registers are also > different from the past, so a new phy driver is required necessarily. > > Signed-off-by:

Re: [PATCH v10 2/7] usb: mux: add generic code for dual role port mux

2016-06-07 Thread Lu Baolu
Hi, On 06/07/2016 11:03 AM, Jun Li wrote: > Hi Roger > >> >> For Mux devices implementing dual-role, the mux device driver _must_ use >> OTG/dual-role core API so that a common ABI is presented to user space for >> OTG/dual-role. > That's the only point we have concern, do dual role switch

Re: [PATCH 23/62] usb: dwc3: implement runtime PM

2016-06-07 Thread Felipe Balbi
Hi, Roger Quadros writes: >> Roger Quadros writes: >>> On 30/05/16 14:35, Felipe Balbi wrote: this patch implements the most basic pm_runtime support for dwc3. Whenever USB cable is dettached, then we will allow core to runtime_suspend.

Re: http://www.linux-usb.org/gadget/usb.c exambple problem.

2016-06-07 Thread Felipe Balbi
Hi, Brian Park writes: > I need help with getting http://www.linux-usb.org/gadget/usb.c working > on my Beagle Bone Black based embedded board. I'm using TI Processor > SDK 2.00.02.11 with their linux kernel > linux-4.1.18+gitAUTOINC+bbe8cfc1da-gbbe8cfc. My application

Re: [balbi-usb:testing/next 64/67] phy-generic.c:undefined reference to `usb_gadget_vbus_connect'

2016-06-07 Thread Felipe Balbi
Hi, Peter Chen writes: > On Mon, Jun 06, 2016 at 04:16:17PM +0300, Felipe Balbi wrote: >> >> Hi, >> >> Felipe Balbi writes: >> > [ Unknown signature status ] >> > >> > Hi, >> > >> > kbuild test robot writes: >> >>

Re: [PATCH v9 5/5] usb: dwc3: core: cleanup IRQ resources

2016-06-07 Thread Roger Quadros
On 02/06/16 14:52, Grygorii Strashko wrote: > On 06/01/2016 10:46 AM, Roger Quadros wrote: >> Implementations might use different IRQs for >> host, gadget and OTG so use named interrupt resources >> to allow Device tree to specify the 3 interrupts. >> >> Following are the interrupt names >> >>

Re: [PATCH v9 5/5] usb: dwc3: core: cleanup IRQ resources

2016-06-07 Thread Roger Quadros
Felipe, On 01/06/16 11:06, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: >> Implementations might use different IRQs for >> host, gadget and OTG so use named interrupt resources >> to allow Device tree to specify the 3 interrupts. >> >> Following are the interrupt names

Re: [PATCH v3 06/12] power: pwrseq: simple: Add support for regulator and generic property

2016-06-07 Thread Krzysztof Kozlowski
On 06/03/2016 04:02 AM, Rob Herring wrote: >> Optional properties: >> - reset-gpios : contains a list of GPIO specifiers. The reset GPIOs are >> asserted >> @@ -16,6 +22,7 @@ Optional properties: >>See ../clocks/clock-bindings.txt for details. >> - clock-names : Must include the following

Re: [PATCH v10 2/7] usb: mux: add generic code for dual role port mux

2016-06-07 Thread Lu Baolu
Hi, On 06/07/2016 02:34 PM, Jun Li wrote: >> > On 06/07/2016 11:03 AM, Jun Li wrote: >>> > > Hi Roger >>> > > > >> > >> For Mux devices implementing dual-role, the mux device driver _must_ > >> use OTG/dual-role core API so that a common ABI is presented to user > >> space for

Re: [STLinux Kernel] [PATCH 0/7] reset: Consumers to explicitly request 'exclusive' or 'shared' lines

2016-06-07 Thread Lee Jones
On Tue, 07 Jun 2016, Lee Jones wrote: > On Tue, 07 Jun 2016, Peter Griffin wrote: > > > Hi, > > > > On Mon, 06 Jun 2016, Lee Jones wrote: > > > > > Phasing out generic reset line requests enables us to make some better > > > decisions on when and how to (de)assert said lines. If an

Re: [PATCH 23/62] usb: dwc3: implement runtime PM

2016-06-07 Thread Roger Quadros
Felipe, On 30/05/16 15:42, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: >> On 30/05/16 14:35, Felipe Balbi wrote: >>> this patch implements the most basic pm_runtime >>> support for dwc3. Whenever USB cable is dettached, >>> then we will allow core to runtime_suspend.

[PATCH v4 1/2] Documentation: bindings: add DT documentation for Rockchip USB2PHY

2016-06-07 Thread Frank Wang
Signed-off-by: Frank Wang --- Changes in v4: - Used 'phy-supply' instead of 'vbus_*-supply'. Changes in v3: - Added 'clocks' and 'clock-names' optional properties. - Specified 'otg-port' and 'host-port' as the sub-node name. Changes in v2: - Changed vbus_host

[PATCH v4 2/2] phy: rockchip-inno-usb2: add a new driver for Rockchip usb2phy

2016-06-07 Thread Frank Wang
The newer SoCs (rk3366, rk3399) take a different usb-phy IP block than rk3288 and before, and most of phy-related registers are also different from the past, so a new phy driver is required necessarily. Signed-off-by: Frank Wang --- Changes in v4: - Removed some

[PATCH v4 0/2] Add a new Rockchip usb2 phy driver

2016-06-07 Thread Frank Wang
The newer SoCs (rk3366, rk3399) of Rock-chip take a different usb-phy IP block than rk3288 and before, and most of phy-related registers are also different from the past, so a new phy driver is required necessarily. These series patches add phy-rockchip-inno-usb2.c and the corresponding

Re: [STLinux Kernel] [PATCH 0/7] reset: Consumers to explicitly request 'exclusive' or 'shared' lines

2016-06-07 Thread Lee Jones
On Tue, 07 Jun 2016, Peter Griffin wrote: > Hi, > > On Mon, 06 Jun 2016, Lee Jones wrote: > > > Phasing out generic reset line requests enables us to make some better > > decisions on when and how to (de)assert said lines. If an 'exclusive' > > line is requested, we know a device *requires* a

Re: [PATCH 8/10] phy: phy-stih407-usb: Inform the reset framework that our reset line may be shared

2016-06-07 Thread Kishon Vijay Abraham I
On Monday 06 June 2016 10:38 PM, Lee Jones wrote: > On the STiH410 B2120 development board the ports on the Generic PHY > share their reset lines with each other. New functionality in the > reset subsystems forces consumers to be explicit when requesting > shared/exclusive reset lines. > >

Re: [PATCH 6/7] phy: miphy28lp: Inform the reset framework that our reset line may be shared

2016-06-07 Thread Kishon Vijay Abraham I
On Monday 06 June 2016 09:26 PM, Lee Jones wrote: > On the STiH410 B2120 development board the MiPHY28lp shares its reset > line with the Synopsys DWC3 SuperSpeed (SS) USB 3.0 Dual-Role-Device > (DRD). New functionality in the reset subsystems forces consumers to > be explicit when requesting

Re: [STLinux Kernel] [PATCH 0/7] reset: Consumers to explicitly request 'exclusive' or 'shared' lines

2016-06-07 Thread Peter Griffin
Hi, On Mon, 06 Jun 2016, Lee Jones wrote: > Phasing out generic reset line requests enables us to make some better > decisions on when and how to (de)assert said lines. If an 'exclusive' > line is requested, we know a device *requires* a reset and that it's > preferable to act upon a request

Re: [STLinux Kernel] [PATCH 9/10] usb: host: ehci-st: Inform the reset framework that our reset line may be shared

2016-06-07 Thread Peter Griffin
On Mon, 06 Jun 2016, Lee Jones wrote: > On the STiH410 B2120 development board the ST EHCI IP shares its reset > line with the OHCI IP. New functionality in the reset subsystems forces > consumers to be explicit when requesting shared/exclusive reset lines. > > Signed-off-by: Lee Jones

Re: [STLinux Kernel] [PATCH 7/7] usb: dwc3: st: Inform the reset framework that our reset line may be shared

2016-06-07 Thread Peter Griffin
Hi Lee, On Mon, 06 Jun 2016, Lee Jones wrote: > On the STiH410 B2120 development board the MiPHY28lp shares its reset > line with the Synopsys DWC3 SuperSpeed (SS) USB 3.0 Dual-Role-Device > (DRD). New functionality in the reset subsystems forces consumers to > be explicit when requesting

Re: [STLinux Kernel] [PATCH 6/7] phy: miphy28lp: Inform the reset framework that our reset line may be shared

2016-06-07 Thread Peter Griffin
On Mon, 06 Jun 2016, Lee Jones wrote: > On the STiH410 B2120 development board the MiPHY28lp shares its reset > line with the Synopsys DWC3 SuperSpeed (SS) USB 3.0 Dual-Role-Device > (DRD). New functionality in the reset subsystems forces consumers to > be explicit when requesting

Re: [STLinux Kernel] [PATCH 8/10] phy: phy-stih407-usb: Inform the reset framework that our reset line may be shared

2016-06-07 Thread Peter Griffin
On Mon, 06 Jun 2016, Lee Jones wrote: > On the STiH410 B2120 development board the ports on the Generic PHY > share their reset lines with each other. New functionality in the > reset subsystems forces consumers to be explicit when requesting > shared/exclusive reset lines. > > Signed-off-by:

Re: [RFC PATCHv2] usb: USB Type-C Connector Class

2016-06-07 Thread Heikki Krogerus
On Mon, Jun 06, 2016 at 03:35:35PM +0200, Oliver Neukum wrote: > On Mon, 2016-06-06 at 16:28 +0300, Heikki Krogerus wrote: > > > I would prefer lower case letters. I don't know the SIDs there are at > > them moment, other then Display Port. Do you know them? > > > > I don't think we can ever

Re: [PATCH v3 1/2] Documentation: bindings: add DT documentation for Rockchip USB2PHY

2016-06-07 Thread Frank Wang
Hi Kishon & Heiko, On 2016/6/7 15:45, Kishon Vijay Abraham I wrote: Hi, On Tuesday 07 June 2016 09:01 AM, Frank Wang wrote: Hi Heiko, On 2016/6/7 10:59, Frank Wang wrote: Hi Heiko & Mark, On 2016/6/6 20:33, Heiko Stübner wrote: Am Montag, 6. Juni 2016, 12:27:54 schrieb Mark Rutland: On

Re: [PATCH v3 1/2] Documentation: bindings: add DT documentation for Rockchip USB2PHY

2016-06-07 Thread Heiko Stübner
Hi Frank, Am Dienstag, 7. Juni 2016, 11:31:59 schrieb Frank Wang: > On 2016/6/7 10:59, Frank Wang wrote: > > On 2016/6/6 20:33, Heiko Stübner wrote: > >> Am Montag, 6. Juni 2016, 12:27:54 schrieb Mark Rutland: > >>> On Mon, Jun 06, 2016 at 05:20:03PM +0800, Frank Wang wrote: > Signed-off-by:

Re: [PATCH v4] r8152: Add support for setting pass through MAC address on RTL8153-AD

2016-06-07 Thread Pali Rohár
Hi! Below are my comments, all about coding style. On Monday 06 June 2016 12:19:29 Mario Limonciello wrote: > The RTL8153-AD supports a persistent system specific MAC address. > This means a device plugged into two different systems with host side > support will show different (but persistent)

Re: [PATCH v3 1/2] Documentation: bindings: add DT documentation for Rockchip USB2PHY

2016-06-07 Thread Kishon Vijay Abraham I
Hi, On Tuesday 07 June 2016 09:01 AM, Frank Wang wrote: > Hi Heiko, > > On 2016/6/7 10:59, Frank Wang wrote: >> Hi Heiko & Mark, >> >> On 2016/6/6 20:33, Heiko Stübner wrote: >>> Am Montag, 6. Juni 2016, 12:27:54 schrieb Mark Rutland: On Mon, Jun 06, 2016 at 05:20:03PM +0800, Frank Wang

Re: [RFC][PATCH] usb: gadget: Allow to build both USB functions and legacy gadgets

2016-06-07 Thread Krzysztof Opasiak
Hi, On Tue, Jun 7, 2016 at 3:27 AM, Peter Chen wrote: > On Mon, Jun 06, 2016 at 09:40:33PM +0200, Krzysztof Opasiak wrote: >> Currently it is possible to build in some subset of usb functions >> *OR* some gadget module. This is limited only by Kconfig not >> any

RE: [PATCH v10 2/7] usb: mux: add generic code for dual role port mux

2016-06-07 Thread Jun Li
Hi Baolu > -Original Message- > From: Lu Baolu [mailto:baolu...@linux.intel.com] > Sent: Tuesday, June 07, 2016 2:27 PM > To: Jun Li ; Roger Quadros ; Peter Chen > > Cc: felipe.ba...@linux.intel.com; Mathias Nyman

Re: [PATCH v10 2/7] usb: mux: add generic code for dual role port mux

2016-06-07 Thread Lu Baolu
Hi Jun, On 06/07/2016 11:03 AM, Jun Li wrote: > Hi Roger > >> >> For Mux devices implementing dual-role, the mux device driver _must_ use >> OTG/dual-role core API so that a common ABI is presented to user space for >> OTG/dual-role. > That's the only point we have concern, do dual role switch

Re: [PATCH v3 00/12] usb/mmc/power: Generic power sequence (and fix USB/LAN when TFTP booting)

2016-06-07 Thread Krzysztof Kozlowski
On 06/06/2016 10:43 PM, Heiko Stübner wrote: > Hi, > > Am Mittwoch, 1. Juni 2016, 10:02:09 schrieb Krzysztof Kozlowski: >> My third approach for a USB power sequence which fixes usb3503+lan >> on Odroid U3 board if it was initialized by bootloader >> (e.g. for TFTP boot). > > I was just tackling