RE: [PATCH] usb: otg-fsm: Cancel HNP polling work when not used

2016-06-27 Thread Jun Li
Hi > -Original Message- > From: Stephen Boyd [mailto:stephen.b...@linaro.org] > Sent: Tuesday, June 28, 2016 9:18 AM > To: Peter Chen ; Felipe Balbi > Cc: linux-arm-ker...@lists.infradead.org; linux-ker...@vger.kernel.org; > linux-usb@vger.kernel.org; Jun Li ; Greg Kroah-Hartman > > Subj

Re: [PATCH 15/21] usb: chipidea: msm: Mux over secondary phy at the right time

2016-06-27 Thread Bjorn Andersson
On Sun 26 Jun 00:28 PDT 2016, Stephen Boyd wrote: > We need to pick the correct phy at runtime based on how the SoC > has been wired onto the board. If the secondary phy is used, take > it out of reset and mux over to it by writing into the TCSR > register. Make sure to do this on reset too, becau

Re: [PATCH 01/21] of: device: Support loading a module with OF based modalias

2016-06-27 Thread Bjorn Andersson
On Sun 26 Jun 00:28 PDT 2016, Stephen Boyd wrote: > In the case of ULPI devices, we want to be able to load the > driver before registering the device so that we don't get stuck > in a loop waiting for the phy module to appear and failing usb > controller probe. Currently we request the ulpi modul

Re: [PATCH v4 5/5] usb: dwc3: rockchip: add devicetree bindings documentation

2016-06-27 Thread William Wu
Dear Heiko, On 06/25/2016 03:50 AM, Heiko Stuebner wrote: Hi William, Am Dienstag, 21. Juni 2016, 17:11:44 schrieb William Wu: On 06/20/2016 10:44 PM, Heiko Stübner wrote: Am Freitag, 17. Juni 2016, 17:18:59 schrieb William Wu: On 06/17/2016 07:15 AM, Heiko Stübner wrote: Am Donnerstag, 2.

Re: [PATCH 00/21] Support qcom's HSIC USB and rewrite USB2 HS phy support

2016-06-27 Thread John Stultz
On Sun, Jun 26, 2016 at 12:28 AM, Stephen Boyd wrote: > The state of USB ChipIdea support on Qualcomm's platforms is not great. > The DT description of these devices requires up to three different nodes > for what amounts to be the same hardware block, when there should really > only be one. Furth

[PATCH net-next v2 5/6] r8152: support RTL8153B

2016-06-27 Thread Hayes Wang
Support new chip RTL8153B. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 560 +--- 1 file changed, 533 insertions(+), 27 deletions(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index 3ccbff0..2fd4944 100644 --- a/drivers/

[PATCH net-next v2 6/6] r8152: add byte_enable for ocp_read_word function

2016-06-27 Thread Hayes Wang
Add byte_enable for ocp_read_word() to replace reading 4 bytes data with reading the desired 2 bytes data. This is used to avoid the issue which is described in commit b4d99def0938 ("r8152: remove sram_read"). The origin method always reads 4 bytes data, and it may have problem when reading the PH

[PATCH net-next v2 4/6] r8152: support the new chip 8050

2016-06-27 Thread Hayes Wang
Support a new chip which has the product ID 0x8050. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index a4f8a01..3ccbff0 100644 --- a/drivers/net/usb/r8152.c +++ b/drivers/net/u

[PATCH net-next v2 0/6] r8152: support new chips

2016-06-27 Thread Hayes Wang
v2: Fix the commit message for patch #6. v1: In order to support new chips, adjust some codes. Then, add the settings for the new chips. Hayes Wang (6): r8152: add aldps_enable for rtl_ops r8152: add u1u2_enable for rtl_ops r8152: add power_cut_en for rtl_ops r8152: support the new chip 8

[PATCH net-next v2 3/6] r8152: add power_cut_en for rtl_ops

2016-06-27 Thread Hayes Wang
Add power_cut_en() for rtl_ops. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index f51d799..a4f8a01 100644 --- a/drivers/net/usb/r8152.c +++ b/drivers/

[PATCH net-next v2 1/6] r8152: add aldps_enable for rtl_ops

2016-06-27 Thread Hayes Wang
Add aldps_enable() for rtl_ops. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index 11178f9..b253003 100644 --- a/drivers/net/usb/r8152.c +++ b/drive

[PATCH net-next v2 2/6] r8152: add u1u2_enable for rtl_ops

2016-06-27 Thread Hayes Wang
Add u1u2_enable() for rtl_ops. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index b253003..f51d799 100644 --- a/drivers/net/usb/r8152.c +++ b/drivers/net/u

Re: [PATCH 1/1] usb: dwc2: add printf attribute to cat_printf()

2016-06-27 Thread John Youn
On 6/26/2016 1:12 AM, Nicolas Iooss wrote: > As cat_printf() uses printf format strings in its parameters, adding > __printf attribute allows the compiler to detect at compile-time some > errors related to format strings (with -Wformat warning flag). > > Signed-off-by: Nicolas Iooss > --- > driv

Re: [PATCH] USB: dwc2-usb: add USB_GADGET dependency

2016-06-27 Thread John Youn
On 6/24/2016 12:28 AM, Arnd Bergmann wrote: > The driver selects NOP_USB_XCEIV, which can only be built-in if > USB_GADGET is either disabled or also built-in, so with USB_DWC2_PCI=y > and USB_GADGET=m, NOP_USB_XCEIV is also built-in and we get this link > error: > > drivers/usb/built-in.o: In fun

[PATCH] usb: otg-fsm: Cancel HNP polling work when not used

2016-06-27 Thread Stephen Boyd
We setup the HNP polling worker, but we never stop it. The OTG state machine can go round and round and keep reinitializing the worker even while it's actively running. That's bad, and debug objects catches it. Fix this by canceling the work when we leave the A_HOST or B_HOST states. [otg_set_stat

Re: [PATCH 1/3] usb: dwc2: Add support for STM32F429/439/469 USB OTG in FS mode with internal PHY

2016-06-27 Thread John Youn
On 6/21/2016 7:26 PM, Bruno Herrera wrote: > Signed-off-by: Bruno Herrera Please add a commit message describing the purpose of your changes, some information about the platform you're adding, and the special handling of the GGPIO. > --- > drivers/usb/dwc2/core.c | 18 ++ >

ASM1153 SATA bridge fails with Crucial MX100 512GB SSD

2016-06-27 Thread Alistair Buxton
I have a USB to SATA bridge which claims to be a ASM1153. It works fine with all the other drives I tried, but not with a Crucial MX100 512GB SSD. I can read approximately the first 1.7GB of the disk with dd and then it stops, always at the same point. Very rarely, when I plug it in, it does not wo

Re: 4.6.x VIA VL805 USB 3.0 controller resets device making it unusable until re-plugged

2016-06-27 Thread Alan Stern
On Mon, 27 Jun 2016, Dmitry K wrote: > Hi, first for the delay in the reply. > > I've assumed the device is being reset because the device itself has a > led indicator that goes ON when plugged in. Few second before the > timeout message in dmesg the led indicator goes OFF. It comes back ON > aft

Re: [PATCH] usbhid: Fix lockdep unannotated irqs-off warning

2016-06-27 Thread Linus Torvalds
On Mon, Jun 27, 2016 at 1:27 PM, Sedat Dilek wrote: > > I just grepped for some "buzzwords" people gave me in this > email-thread and I was looking at (llvm.git HEAD - upcoming v3.9 > release) and found these comments in [1] > > > [1] > https://github.com/llvm-mirror/llvm/blob/master/lib/Target/X

Re: [PATCH] usbhid: Fix lockdep unannotated irqs-off warning

2016-06-27 Thread Sedat Dilek
On Mon, Jun 27, 2016 at 10:14 PM, Linus Torvalds wrote: > On Mon, Jun 27, 2016 at 12:50 PM, Sedat Dilek wrote: >> >> $ objdump -S clang-eflag.o >> >> clang-eflag.o: file format elf64-x86-64 >> >> >> Disassembly of section .text: >> >> : >>0: 55 push

Re: [PATCH] usbhid: Fix lockdep unannotated irqs-off warning

2016-06-27 Thread Linus Torvalds
On Mon, Jun 27, 2016 at 12:50 PM, Sedat Dilek wrote: > > $ objdump -S clang-eflag.o > > clang-eflag.o: file format elf64-x86-64 > > > Disassembly of section .text: > > : >0: 55 push %rbp >1: 48 89 e5mov%rsp,%rbp >4:

Re: [PATCH] usbhid: Fix lockdep unannotated irqs-off warning

2016-06-27 Thread Sedat Dilek
On Mon, Jun 27, 2016 at 9:50 PM, Sedat Dilek wrote: > On Mon, Mar 7, 2016 at 7:30 PM, Linus Torvalds > wrote: >> On Mon, Mar 7, 2016 at 10:07 AM, Alan Stern >> wrote: >>> >>> Of course, there are other ways to save a single flag value (such as >>> setz). It's up to the compiler developers to d

Re: [PATCH] usbhid: Fix lockdep unannotated irqs-off warning

2016-06-27 Thread Sedat Dilek
On Mon, Mar 7, 2016 at 7:30 PM, Linus Torvalds wrote: > On Mon, Mar 7, 2016 at 10:07 AM, Alan Stern wrote: >> >> Of course, there are other ways to save a single flag value (such as >> setz). It's up to the compiler developers to decide what they think is >> best. > > Using 'setcc' to save eflag

RE: [PATCH 04/21] usb: chipidea: Only read/write OTGSC from one place

2016-06-27 Thread Stephen Boyd
Quoting Jun Li (2016-06-27 01:04:39) > > diff --git a/drivers/usb/chipidea/otg.c b/drivers/usb/chipidea/otg.c index > > 03b6743461d1..763a8332b009 100644 > > --- a/drivers/usb/chipidea/otg.c > > +++ b/drivers/usb/chipidea/otg.c > > @@ -104,7 +104,32 @@ void ci_handle_vbus_change(struct ci_hdrc *ci)

Re: [PATCH 02/21] usb: ulpi: Support device discovery via DT

2016-06-27 Thread Heikki Krogerus
Hi, I'm fine with most of the patch, except.. On Sun, Jun 26, 2016 at 12:28:19AM -0700, Stephen Boyd wrote: > @@ -39,7 +42,10 @@ static int ulpi_match(struct device *dev, struct > device_driver *driver) > struct ulpi *ulpi = to_ulpi_dev(dev); > const struct ulpi_device_id *id; > >

[PATCH v2] USB: don't free bandwidth_mutex too early

2016-06-27 Thread Alan Stern
The USB core contains a bug that can show up when a USB-3 host controller is removed. If the primary (USB-2) hcd structure is released before the shared (USB-3) hcd, the core will try to do a double-free of the common bandwidth_mutex. The problem was described in graphical form by Chung-Geol Kim,

Re: [PATCHv3 1/2] usb: USB Type-C connector class

2016-06-27 Thread Guenter Roeck
On 06/27/2016 05:13 AM, Heikki Krogerus wrote: Hi, On Mon, Jun 27, 2016 at 03:51:08PM +0530, Rajaram R wrote: May be I am missing user or usage of the driver.. I see this driver is providing limited information of the Type-C connectors or the port partner Yes, this interface can't provide dir

re: usb: host: Faraday fotg210-hcd driver

2016-06-27 Thread Dan Carpenter
Hello Feng-Hsin Chiang, The patch 7d50195f6c50: "usb: host: Faraday fotg210-hcd driver" from Jul 29, 2013, leads to the following static checker warning: drivers/usb/host/fotg210-hcd.c:3967 iso_stream_init() warn: mask and shift to zero drivers/usb/host/fotg210-hcd.c 3944 stat

Re: [PATCH] usb: ulpi: Automatically set driver::owner with ulpi_driver_register()

2016-06-27 Thread Heikki Krogerus
On Sat, Jun 25, 2016 at 10:38:21PM -0700, Stephen Boyd wrote: > Let's follow other driver registration functions and > automatically set the driver's owner member to THIS_MODULE when > ulpi_driver_register() is called. This allows ulpi driver writers > to forget about this boiler plate detail and a

Re: [PATCH v5 0/7] da8xx USB PHY (was da8xx USB clocks)

2016-06-27 Thread Kishon Vijay Abraham I
On Tuesday 10 May 2016 05:09 AM, David Lechner wrote: > v5 changes: > > Functionally, nothing has really changed. Just some cleanups based on > feedback. > > * Renamed "usbphy" to "usb_phy" or "usb-phy" as appropriate > * License header matches MODULE_LICENSE in new phy driver applied all the

Re: [PATCH v5 3/7] phy: Add set_mode callback

2016-06-27 Thread Kishon Vijay Abraham I
Hi, On Tuesday 10 May 2016 05:09 AM, David Lechner wrote: > The initial use for this is for PHYs that have a mode related to USB OTG. > There are several SoCs (e.g. TI OMAP and DA8xx) that have a mode setting > in the USB PHY to override OTG VBUS and ID signals. > > Of course, the enum can be exp

Re: [PATCH] usb: ohci-at91: make at91_dt_syscon_sfr static

2016-06-27 Thread Alexandre Belloni
On 27/06/2016 at 10:24:59 +0100, Ben Dooks wrote : > On 26/06/16 19:48, Greg Kroah-Hartman wrote: > > On Fri, Jun 17, 2016 at 04:11:55PM +0100, Ben Dooks wrote: > >> Make at91_dt_syscon_sfr() static as it is not used or declared > >> outside the drivers/usb/host/ohci-at91.c file. > >> > >> drivers/

Re: [PATCHv3 1/2] usb: USB Type-C connector class

2016-06-27 Thread Heikki Krogerus
Hi, On Mon, Jun 27, 2016 at 03:51:08PM +0530, Rajaram R wrote: > May be I am missing user or usage of the driver.. I see this driver is > providing limited information of the Type-C connectors or the port > partner Yes, this interface can't provide directly information received from PD commands l

[PATCH 3/3] usb: renesas_usbhs: Use devm_usb_get_phy_by_phandle()

2016-06-27 Thread Yoshihiro Shimoda
This patch uses devm_usb_get_phy_by_phandle() instead of usb_get_phy() for device tree environment. This change is not compabile with the previous code, but it is no problem because nobody calls usb_bind_phy() for this driver now. Signed-off-by: Yoshihiro Shimoda --- Documentation/devicetree/bin

[PATCH 2/3] usb: renesas_usbhs: show error code when probe failed

2016-06-27 Thread Yoshihiro Shimoda
To know why the driver probing failed, this patch shows error code. Signed-off-by: Yoshihiro Shimoda --- drivers/usb/renesas_usbhs/common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/renesas_usbhs/common.c b/drivers/usb/renesas_usbhs/common.c index baeb7d2..

[PATCH 0/3] usb: renesas_usbhs: some modifications

2016-06-27 Thread Yoshihiro Shimoda
This patch set is based on the latest Felipe's testing/next branch (commit id = 1d23d16a88e6c8143b07339435ba061b131ebb8c) and the following fixed patch set: http://thread.gmane.org/gmane.linux.kernel.stable/181504 Yoshihiro Shimoda (3): usb: renesas_usbhs: Fix a condition about a log of "trans

Re: [PATCH net-next 6/6] r8152: add byte_enable for ocp_read_word function

2016-06-27 Thread Sergei Shtylyov
Hello. On 6/27/2016 8:07 AM, Hayes Wang wrote: Add byte_enable for ocp_read_word() to replace reading 4 bytes data with reading the desired 2 bytes data. This is used to avoid the issue which is described in commit:b4d99def. scripts/checkpatch.pl now enforces certain commit citing style,

Re: [PATCH] usb: ohci-at91: make at91_dt_syscon_sfr static

2016-06-27 Thread Ben Dooks
On 26/06/16 19:48, Greg Kroah-Hartman wrote: > On Fri, Jun 17, 2016 at 04:11:55PM +0100, Ben Dooks wrote: >> Make at91_dt_syscon_sfr() static as it is not used or declared >> outside the drivers/usb/host/ohci-at91.c file. >> >> drivers/usb/host/ohci-at91.c:144:15: warning: symbol 'at91_dt_syscon_sf

RE: [PATCH 04/21] usb: chipidea: Only read/write OTGSC from one place

2016-06-27 Thread Jun Li
Hi > -Original Message- > From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb- > ow...@vger.kernel.org] On Behalf Of Stephen Boyd > Sent: Sunday, June 26, 2016 3:28 PM > To: linux-usb@vger.kernel.org > Cc: linux-arm-ker...@lists.infradead.org; linux-ker...@vger.kernel.org; > linux-arm-

[PATCH] usb: gadget: rndis: free response queue during REMOTE_NDIS_RESET_MSG

2016-06-27 Thread Amit Pundir
From: xerox_lin When rndis data transfer is in progress, some Windows7 Host PC is not sending the GET_ENCAPSULATED_RESPONSE command for receiving the response for the previous SEND_ENCAPSULATED_COMMAND processed. The rndis function driver appends each response for the SEND_ENCAPSULATED_COMMAND i

Re: [PATCH 18/21] usb: chipidea: msm: Add reset controller for PHY POR bit

2016-06-27 Thread kbuild test robot
-USB-and-rewrite-USB2-HS-phy-support/20160627-102637 base: https://git.kernel.org/pub/scm/linux/kernel/git/peter.chen/usb ci-for-usb-next config: x86_64-randconfig-s5-06271251 (attached as .config) compiler: gcc-6 (Debian 6.1.1-1) 6.1.1 20160430 reproduce: # save the attached .config to