Re: [PATCH v3 18/22] usb: chipidea: msm: Add reset controller for PHY POR bit

2016-09-01 Thread Peter Chen
On Wed, Aug 31, 2016 at 05:40:32PM -0700, Stephen Boyd wrote: > The MSM chipidea wrapper has two bits that are used to reset the > first or second phy. Add support for these bits via the reset > controller framework, so that phy drivers can reset their > hardware at the right time during

Re: [PATCH v3 10/22] usb: chipidea: Consolidate extcon notifiers

2016-09-01 Thread Peter Chen
On Wed, Aug 31, 2016 at 05:40:24PM -0700, Stephen Boyd wrote: > The two extcon notifiers are almost the same except for the > variable name for the cable structure and the id notifier inverts > the cable->state logic. Make it the same and replace two > functions with one to save some lines. This

Re: [PATCH v3 09/22] usb: chipidea: Add support for ULPI PHY bus

2016-09-01 Thread Peter Chen
On Wed, Aug 31, 2016 at 05:40:23PM -0700, Stephen Boyd wrote: > Some phys for the chipidea controller are controlled via the ULPI > viewport. Add support for the ULPI bus so that these sorts of > phys can be probed and read/written automatically without having > to duplicate the viewport logic in

Re: [PATCH v3 04/22] usb: chipidea: Only read/write OTGSC from one place

2016-09-01 Thread Peter Chen
On Wed, Aug 31, 2016 at 05:40:18PM -0700, Stephen Boyd wrote: > With the id and vbus detection done via extcon we need to make > sure we poll the status of OTGSC properly by considering what the > extcon is saying, and not just what the register is saying. Let's > move this hw_wait_reg() function

Re: [PATCH 1/1] subsystem:usb

2016-09-01 Thread Peter Chen
On Fri, Sep 02, 2016 at 01:20:21AM +0100, James wrote: > This patch fixes a NULL pointer dereference caused by a race codition in the > probe > function of the legousbtower driver. The probe function does not deregister > the > usb interface after an error receiving the devices firmware ID. The

Re: chipidea: udc: kernel panic in isr_setup_status_phase

2016-09-01 Thread Peter Chen
On Tue, Aug 30, 2016 at 07:20:45PM +0200, Clemens Gruber wrote: > On Mon, Aug 29, 2016 at 06:24:03PM +0800, Peter Chen wrote: > > Would you please measure the voltage of vbus within 1s at below two > > conditions: > > > > - Just connect cable > > - Just disconnect cable > > We found out that

Re: [PATCH v6 4/8] usb: core: add power sequence handling for USB devices

2016-09-01 Thread Peter Chen
On Thu, Sep 01, 2016 at 01:32:49PM +0530, Vaibhav Hiremath wrote: > > > On Monday 15 August 2016 02:43 PM, Peter Chen wrote: > >Some hard-wired USB devices need to do power sequence to let the > >device work normally, the typical power sequence like: enable USB > >PHY clock, toggle reset pin,

Re: [PATCH v6 2/8] power: add power sequence library

2016-09-01 Thread Peter Chen
On Thu, Sep 01, 2016 at 01:32:56PM +0530, Vaibhav Hiremath wrote: > >+static void pwrseq_generic_put(struct pwrseq *pwrseq) > >+{ > >+struct pwrseq_generic *pwrseq_gen = to_generic_pwrseq(pwrseq); > >+int clk; > >+ > >+if (pwrseq_gen->gpiod_reset) > >+

Re: [PATCH v5] Axi-usb: Add support for 64-bit addressing.

2016-09-01 Thread Sören Brinkmann
On Thu, 2016-09-01 at 14:22:56 +0530, Nava kishore Manne wrote: > This patch updates the driver to support 64-bit DMA addressing. > > Signed-off-by: Nava kishore Manne > Acked-by: Rob Herring > --- > Changes for v5: > -None. > > Changes for

Re: [PATCH 1/1] subsystem:usb

2016-09-01 Thread Randy Dunlap
On 09/01/16 17:20, James wrote: > This patch fixes a NULL pointer dereference caused by a race codition in the > probe > function of the legousbtower driver. The probe function does not deregister > the > usb interface after an error receiving the devices firmware ID. The device > file >

Re: [PATCH v6 0/8] power: add power sequence library

2016-09-01 Thread Peter Chen
On Wed, Aug 31, 2016 at 10:28:20PM +0530, Vaibhav Hiremath wrote: > > > On Wednesday 31 August 2016 03:22 PM, Peter Chen wrote: > >On Wed, Aug 31, 2016 at 01:46:30PM +0530, Vaibhav Hiremath wrote: > >> > >>On Monday 29 August 2016 04:40 PM, Peter Chen wrote: > >>>On Wed, Aug 24, 2016 at

Re: [PATCH v6 1/8] binding-doc: power: pwrseq-generic: add binding doc for generic power sequence library

2016-09-01 Thread Peter Chen
On Thu, Sep 01, 2016 at 01:33:22PM +0530, Vaibhav Hiremath wrote: > > > On Monday 15 August 2016 02:43 PM, Peter Chen wrote: > >Add binding doc for generic power sequence library. > > > >Signed-off-by: Peter Chen > >Acked-by: Philipp Zabel >

[PATCH] usb: dwc3: Fix dr_mode validation

2016-09-01 Thread John Youn
From: Thinh Nguyen This patch follows the similar fix in dwc2. See commit 5268ed9d2e3b ("usb: dwc2: Fix dr_mode validation") Currently, the dr_mode is only checked against the module configuration. It also needs to be checked against the hardware capablities. The driver

[PATCH 1/1] subsystem:usb

2016-09-01 Thread James
This patch fixes a NULL pointer dereference caused by a race codition in the probe function of the legousbtower driver. The probe function does not deregister the usb interface after an error receiving the devices firmware ID. The device file registered (/dev/usb/legousbtower%d) may be

Re: [PATCH] net: pegasus: Remove deprecated create_singlethread_workqueue

2016-09-01 Thread David Miller
From: Bhaktipriya Shridhar Date: Tue, 30 Aug 2016 22:02:47 +0530 > The workqueue "pegasus_workqueue" queues a single work item per pegasus > instance and hence it doesn't require execution ordering. Hence, > alloc_workqueue has been used to replace the deprecated >

Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

2016-09-01 Thread Leo Li
On Thu, Apr 28, 2016 at 9:27 AM, Felipe Balbi wrote: > > Hi, > > Arnd Bergmann writes: >> On Thursday 28 April 2016 15:16:12 Russell King - ARM Linux wrote: >>> On Thu, Apr 28, 2016 at 09:37:08AM +0300, Felipe Balbi wrote: >>> > >>> > Hi, >>> > >>> > Arnd

Re: [PATCH] HID: usbkbd: return proper error code

2016-09-01 Thread Sudip Mukherjee
On Thursday 01 September 2016 04:51 PM, Jiri Kosina wrote: On Wed, 31 Aug 2016, Sudip Mukherjee wrote: Use proper error code instead of using -1 on failure to allocate memory. We may use the error code later in the caller. But we don't. usb_kbd_probe() returns -ENOMEM in case

Re: [PATCH net-next] r8152: fix the coding style with checkpatch.pl

2016-09-01 Thread David Miller
From: Hayes Wang Date: Thu, 1 Sep 2016 17:01:42 +0800 > check the coding style with checkpatch.pl and fix the warnings and errors. > > Signed-off-by: Hayes Wang Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in

[PATCH 1/2] usb: dwc3: Add ref clock period setting

2016-09-01 Thread John Youn
From: Thinh Nguyen Added ref_clk_per for writing to GUCTL.RefClkPer which sets the period of ref_clk in nano second. Signed-off-by: Thinh Nguyen Signed-off-by: John Youn --- Documentation/devicetree/bindings/usb/dwc3.txt | 2

[PATCH 2/2] usb: dwc3: Added a property to set GFLADJ register

2016-09-01 Thread John Youn
From: Thinh Nguyen Added gfladj variable to control the core behavior with respect to SOF, ITP, and frame timer functionality. Currently there is dwc->fladj that holds a single field in GFLADJ register (GFLADJ.GFLADJ_30MHZ). A new variable gfladj is added to dwc structure

[RFT PATCH v4 1/3] usb: dwc2: gadget: Only initialize device if in device mode

2016-09-01 Thread John Youn
In dwc2_hsotg_udc_start(), don't initialize the controller for device mode unless we are actually in device mode. Tested-by: Heiko Stuebner Signed-off-by: John Youn --- drivers/usb/dwc2/gadget.c | 7 +-- 1 file changed, 5 insertions(+), 2

[RFT PATCH v4 0/3] usb: dwc2: Fix core reset and force mode delays

2016-09-01 Thread John Youn
This series accounts for the delay from the IDDIG debounce filter when switching modes. This delay is a function of the PHY clock speed and can range from 5-50 ms. This delay must be taken into account on core reset and force modes. A full explanation is provided in the patch commit log and code

[RFT PATCH v4 2/3] usb: dwc2: Add delay to core soft reset

2016-09-01 Thread John Youn
Add a delay to the core soft reset function to account for the IDDIG debounce filter. If the current mode is host, either due to the force mode bit being set (which persists after core reset) or the connector id pin, a core soft reset will temporarily reset the mode to device and a delay from the

[RFT PATCH v4 3/3] usb: dwc2: Properly account for the force mode delays

2016-09-01 Thread John Youn
When a force mode bit is set and the IDDIG debounce filter is enabled, there is a delay for the forced mode to take effect. This delay is due to the IDDIG debounce filter and is variable depending on the platform's PHY clock speed. To account for this delay we can poll for the expected mode. On a

Re: [PATCH v3 5/5] net: asix: autoneg will set WRITE_MEDIUM reg

2016-09-01 Thread Eric Dumazet
On Thu, 2016-09-01 at 12:47 -0400, Robert Foss wrote: > I'm not quite sure how the first From line was added, it > should not have been. > Grant Grundler is most definitely the author. > > Would you like me to resubmit in v++ and make sure that it has been > corrected? This is too late,

Re: [PATCH v3 5/5] net: asix: autoneg will set WRITE_MEDIUM reg

2016-09-01 Thread Robert Foss
On 2016-09-01 12:43 PM, Eric Dumazet wrote: On Mon, 2016-08-29 at 09:32 -0400, robert.f...@collabora.com wrote: From: Robert Foss From: Grant Grundler The miii_nway_restart() causes a PHY link change activity and ax88772_link_reset will be

Re: [PATCH v3 5/5] net: asix: autoneg will set WRITE_MEDIUM reg

2016-09-01 Thread Eric Dumazet
On Mon, 2016-08-29 at 09:32 -0400, robert.f...@collabora.com wrote: > From: Robert Foss > > From: Grant Grundler > > The miii_nway_restart() causes a PHY link change activity and > ax88772_link_reset will be called. link_reset will set >

Re: [PATCH 2/2] USB: hub: change the locking in hub_activate

2016-09-01 Thread Vaibhav Hiremath
On Thursday 01 September 2016 07:59 PM, Alan Stern wrote: On Thu, 1 Sep 2016, Viresh Kumar wrote: On 31-08-16, 12:46, Alan Stern wrote: On Wed, 31 Aug 2016, Viresh Kumar wrote: On 05-08-16, 11:51, Alan Stern wrote: +++ usb-4.x/drivers/usb/core/hub.c @@ -1052,7 +1052,7 @@ static void

Re: g_mass_storage not queueing requests

2016-09-01 Thread Felipe Balbi
Hi, (adding linux-usb which I forgot when I sent the original email, sorry) Alan Stern writes: > On Thu, 1 Sep 2016, Felipe Balbi wrote: > >> Hi Alan, Michal, >> >> I think I have emailed the list about this at some point, but I have >> much stronger evidence that

Re: [PATCH V4] leds: trigger: Introduce an USB port trigger

2016-09-01 Thread Alan Stern
On Thu, 1 Sep 2016, Jacek Anaszewski wrote: > On 09/01/2016 07:25 AM, Rafał Miłecki wrote: > > On 31 August 2016 at 21:00, Rafał Miłecki wrote: > >> On 31 August 2016 at 20:23, Alan Stern wrote: > >>> On Tue, 30 Aug 2016, Rafał Miłecki wrote: >

Re: [PATCH 2/2] USB: hub: change the locking in hub_activate

2016-09-01 Thread Alan Stern
On Thu, 1 Sep 2016, Viresh Kumar wrote: > On 31-08-16, 12:46, Alan Stern wrote: > > On Wed, 31 Aug 2016, Viresh Kumar wrote: > > > > > On 05-08-16, 11:51, Alan Stern wrote: > > > > +++ usb-4.x/drivers/usb/core/hub.c > > > > @@ -1052,7 +1052,7 @@ static void hub_activate(struct usb_hub > > > >

Re: [PATCH] USB: core: add missing header dependencies

2016-09-01 Thread Arnd Bergmann
On Thursday, September 1, 2016 9:33:59 PM CEST kbuild test robot wrote: > Hi Baoyou, > > [auto build test ERROR on arm-soc/for-next] > [also build test ERROR on v4.8-rc4] > [cannot apply to usb/usb-testing next-20160825] > [if your patch is applied to the wrong git tree, please drop us a note to

Re: [PATCH] USB: core: add missing header dependencies

2016-09-01 Thread kbuild test robot
ase= (or --base=auto for convenience) to record what (public, well-known) commit your patch series was built on] [Check https://git-scm.com/docs/git-format-patch for more information] url: https://github.com/0day-ci/linux/commits/Baoyou-Xie/USB-core-add-missing-header-dependencies/20160901-194228 b

Re: [PATCHv8 0/2] USB Type-C Connector class

2016-09-01 Thread Guenter Roeck
Heikki, On 09/01/2016 04:49 AM, Heikki Krogerus wrote: The USB Type-C class is meant to provide unified interface to the userspace to present the USB Type-C ports in a system. Thanks for the updated series. I'll be traveling for the next couple of days, so I'll only be able to look into it

Re: [PATCHv8 0/2] USB Type-C Connector class

2016-09-01 Thread Heikki Krogerus
On Thu, Sep 01, 2016 at 05:13:18AM -0700, Guenter Roeck wrote: > Heikki, > > On 09/01/2016 04:49 AM, Heikki Krogerus wrote: > > The USB Type-C class is meant to provide unified interface to the > > userspace to present the USB Type-C ports in a system. > > > Thanks for the updated series. I'll

[PATCHv8 1/2] usb: USB Type-C connector class

2016-09-01 Thread Heikki Krogerus
The purpose of USB Type-C connector class is to provide unified interface for the user space to get the status and basic information about USB Type-C connectors on a system, control over data role swapping, and when the port supports USB Power Delivery, also control over power role swapping and

[PATCHv8 2/2] usb: typec: add driver for Intel Whiskey Cove PMIC USB Type-C PHY

2016-09-01 Thread Heikki Krogerus
This adds driver for the USB Type-C PHY on Intel WhiskeyCove PMIC which is available on some of the Intel Broxton SoC based platforms. Signed-off-by: Heikki Krogerus --- drivers/usb/typec/Kconfig | 14 ++ drivers/usb/typec/Makefile | 1 +

[PATCHv8 0/2] USB Type-C Connector class

2016-09-01 Thread Heikki Krogerus
The USB Type-C class is meant to provide unified interface to the userspace to present the USB Type-C ports in a system. Changes since v7: - Removed "type" attribute from partners - Added supports_usb_power_delivery attribute for partner and cable Changes since v6: - current_vconn_role attr

[PATCH] USB: core: add missing header dependencies

2016-09-01 Thread Baoyou Xie
We get 1 warning when building kernel with W=1: drivers/usb/core/of.c:31:21: warning: no previous prototype for 'usb_of_get_child_node' [-Wmissing-prototypes] In fact, this function is declared in linux/usb/of.h, so this patch add missing header dependencies Signed-off-by: Baoyou Xie

[PATCH] xhci: mark xhci_unmap_td_bounce_buffer() static

2016-09-01 Thread Baoyou Xie
We get 1 warning when building kernel with W=1: drivers/usb/host/xhci-ring.c:608:6: warning: no previous prototype for 'xhci_unmap_td_bounce_buffer' [-Wmissing-prototypes] In fact, this function is only used in the file in which it is declared and don't need a declaration, but can be made

Re: [PATCH] HID: usbkbd: return proper error code

2016-09-01 Thread Jiri Kosina
On Wed, 31 Aug 2016, Sudip Mukherjee wrote: > Use proper error code instead of using -1 on failure to allocate > memory. We may use the error code later in the caller. But we don't. usb_kbd_probe() returns -ENOMEM in case usb_kbd_alloc_mem() fails anyway, so I fail to see the point of the

[PATCH v5] Axi-usb: Add support for 64-bit addressing.

2016-09-01 Thread Nava kishore Manne
This patch updates the driver to support 64-bit DMA addressing. Signed-off-by: Nava kishore Manne Acked-by: Rob Herring --- Changes for v5: -None. Changes for v4: -Used boolen property insted of addrwith property in the DT

[PATCH net-next] r8152: fix the coding style with checkpatch.pl

2016-09-01 Thread Hayes Wang
check the coding style with checkpatch.pl and fix the warnings and errors. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index

Re: [PATCH 2/2] USB: hub: change the locking in hub_activate

2016-09-01 Thread Vaibhav Hiremath
On Thursday 01 September 2016 10:32 AM, Viresh Kumar wrote: On 31-08-16, 12:46, Alan Stern wrote: On Wed, 31 Aug 2016, Viresh Kumar wrote: On 05-08-16, 11:51, Alan Stern wrote: +++ usb-4.x/drivers/usb/core/hub.c @@ -1052,7 +1052,7 @@ static void hub_activate(struct usb_hub /*

Re: [RESEND PATCH 1/4] usb: dbc: early driver for xhci debug capability

2016-09-01 Thread Oliver Neukum
On Thu, 2016-09-01 at 10:21 +0800, Lu Baolu wrote: > Hi Oliver, > > Thanks for review. > > On 08/31/2016 05:53 PM, Oliver Neukum wrote: > > On Mon, 2016-08-29 at 13:26 +0800, Lu Baolu wrote: > >> + /* > >> +* Memory barrier to ensure hardware sees the trbs > >> +* enqueued

Re: [PATCH v6 4/8] usb: core: add power sequence handling for USB devices

2016-09-01 Thread Vaibhav Hiremath
On Monday 15 August 2016 02:43 PM, Peter Chen wrote: Some hard-wired USB devices need to do power sequence to let the device work normally, the typical power sequence like: enable USB PHY clock, toggle reset pin, etc. But current Linux USB driver lacks of such code to do it, it may cause some

Re: [PATCH v6 1/8] binding-doc: power: pwrseq-generic: add binding doc for generic power sequence library

2016-09-01 Thread Vaibhav Hiremath
On Monday 15 August 2016 02:43 PM, Peter Chen wrote: Add binding doc for generic power sequence library. Signed-off-by: Peter Chen Acked-by: Philipp Zabel Acked-by: Rob Herring --- .../bindings/power/pwrseq/pwrseq-generic.txt

Re: [PATCH v6 2/8] power: add power sequence library

2016-09-01 Thread Vaibhav Hiremath
On Monday 15 August 2016 02:43 PM, Peter Chen wrote: We have an well-known problem that the device needs to do some power sequence before it can be recognized by related host, the typical example like hard-wired mmc devices and usb devices. This power sequence is hard to be described at

Re: crash in usb_hc_died+0x16 when unplugging usb-c dock

2016-09-01 Thread Richard van der Hoff
On 30/08/16 21:52, Richard van der Hoff wrote: On 30/08/16 19:48, Alan Stern wrote: On Tue, 30 Aug 2016, Richard van der Hoff wrote: I have a USB-3.1 dock; sometimes I see a kernel panic when I unplug it, which hangs the entire system. It appears that the first unplug is successful; the

Re: [PATCH V4] leds: trigger: Introduce an USB port trigger

2016-09-01 Thread Jacek Anaszewski
On 09/01/2016 07:25 AM, Rafał Miłecki wrote: On 31 August 2016 at 21:00, Rafał Miłecki wrote: On 31 August 2016 at 20:23, Alan Stern wrote: On Tue, 30 Aug 2016, Rafał Miłecki wrote: Not really as it won't cover some pretty common use cases. Many

Re: [PATCH v3 21/22] phy: Add support for Qualcomm's USB HSIC phy

2016-09-01 Thread Vivek Gautam
Hi Stephen, On Thu, Sep 1, 2016 at 6:10 AM, Stephen Boyd wrote: > The HSIC USB controller on qcom SoCs has an integrated all > digital phy controlled via the ULPI viewport. > > Cc: Kishon Vijay Abraham I > Cc: >