Re: cdc_ncm driver padding problem

2016-09-15 Thread Bjørn Mork
> ==From: Marek Brudka .. > ==The bad thing is DHCP. It seems, that cdc_ncm driver somehow consumes DHCP > ==replies. I had to manually setup wwan0 interface as well as routing > ==using the result > ==of Hayes command > == > ==AT^DHCP? > ==^DHCP: > ==EC684764,F8FF,E9684764,E9684764,356002D4,3

Re: [PATCH v5 3/3] usb: dwc2: Properly account for the force mode delays

2016-09-15 Thread John Youn
On 9/14/2016 7:05 AM, Heiko Stübner wrote: > Am Dienstag, 13. September 2016, 12:04:12 schrieb John Youn: >> On 9/13/2016 11:39 AM, Heiko Stübner wrote: >>> Am Dienstag, 13. September 2016, 20:07:25 schrieb Stefan Wahren: Hi Heiko, > Heiko Stuebner hat am 12. September 2016 um 13:05

cdc_ncm driver padding problem (WAS: Question about CDC_NCM_FLAG_NDP_TO_END)

2016-09-15 Thread Enrico Mioso
Hello guys. Some very good people managed to detect there is a problem with some Huawei firmwares and NCM padding. I actually don't think I have the hardware to test btw. On Wed, 14 Sep 2016, Marek Brudka wrote: Sorry Marek - I forwarded this message without asking for your consent. Let me know

Re: mceusb xhci issue?

2016-09-15 Thread Wade Berrier
On Thu Sep 15 15:13, Alan Stern wrote: > On Sat, 10 Sep 2016, Wade Berrier wrote: > > > On Thu Aug 11 16:18, Alan Stern wrote: > > > I never received any replies to this message. Should the patch I > > > suggested be merged? > > > > > > > Hello, > > > > I applied this updated patch to the fedo

Re: [PATCH v2 6/6] ARM64: meson-gxbb-vega-s95: Enable USB Nodes

2016-09-15 Thread Kevin Hilman
Martin Blumenstingl writes: > Enable both gxbb USB controller and add a 5V regulator for the OTG port > VBUS > > Signed-off-by: Martin Blumenstingl > Signed-off-by: Jerome Brunet Applied (after adding a "dts: " to the subject. Kevin -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH v2 4/6] ARM64: meson-gxbb: add USB Nodes

2016-09-15 Thread Kevin Hilman
Martin Blumenstingl writes: > Add the nodes for the dwc2 USB controller and the related USB PHYs. > Currently we force usb0 to host mode because OTG is currently not > working in our PHY driver. > > Signed-off-by: Martin Blumenstingl > Signed-off-by: Jerome Brunet Applied (after adding a "dts:

Re: [PATCH v2 5/6] ARM64: meson-gxbb-p20x: Enable USB Nodes

2016-09-15 Thread Kevin Hilman
Kevin Hilman writes: > Martin Blumenstingl writes: > >> From: Jerome Brunet >> >> Enable both gxbb USB controller and add a 5V regulator for the OTG port >> VBUS >> >> Signed-off-by: Jerome Brunet > > nit: subject should have "ARM64: dts:" prefix. > >> --- >> arch/arm64/boot/dts/amlogic/meson

Re: mceusb xhci issue?

2016-09-15 Thread Alan Stern
Mauro: I just took a look at the mceusb.c source file under drivers/media/rc/. The probe routine checks that ep_in != NULL, but it doesn't check ep_out. This can lead to a NULL-pointer dereference later on, crashing the driver. Such a crash was reported here: http://marc.info/?l=mytht

Re: [PATCH 3/3] usb: gadget: default U1/U2 exit latencies to maximum

2016-09-15 Thread John Youn
On 9/14/2016 11:53 PM, Felipe Balbi wrote: > > Hi, > > John Youn writes: John Youn writes: > On 8/31/2016 2:38 AM, Felipe Balbi wrote: >> If we don't know what are the actual U1/U2 exit >> latencies from the UDC, we're better off using >> maximum latencies as default. This

Re: mceusb xhci issue?

2016-09-15 Thread Alan Stern
On Sat, 10 Sep 2016, Wade Berrier wrote: > On Thu Aug 11 16:18, Alan Stern wrote: > > I never received any replies to this message. Should the patch I > > suggested be merged? > > > > Hello, > > I applied this updated patch to the fedora23 4.7.2 kernel and the mceusb > transceiver works as exp

Re: [PATCH v1 2/3] usb: gadget: NCM: link socket buffers to the device for received packets

2016-09-15 Thread Yauheni Kaliuta
Hi, Harish! > On Thu, 15 Sep 2016 16:22:57 +0200, Harish Jenny K N wrote: > diff --git a/drivers/usb/gadget/function/u_ether.c > b/drivers/usb/gadget/function/u_ether.c ^^^ Is subject a bit misleading, it's more generic, then NCM? -- WBR, Y

Re: [PATCHv3] usb: musb: Fix unbalanced platform_disable

2016-09-15 Thread Tony Lindgren
* Hans de Goede [160915 09:59]: > Hi, > > On 15-09-16 16:43, Tony Lindgren wrote: > > * Hans de Goede [160915 07:00]: > > > Hi, > > > > > > On 14-09-16 20:10, Tony Lindgren wrote: > > > > Commit a83e17d0f73b ("usb: musb: Improve PM runtime and phy handling > > > > for 2430 glue layer") moved PH

Re: [PATCHv3] usb: musb: Fix unbalanced platform_disable

2016-09-15 Thread Hans de Goede
Hi, On 15-09-16 16:43, Tony Lindgren wrote: * Hans de Goede [160915 07:00]: Hi, On 14-09-16 20:10, Tony Lindgren wrote: Commit a83e17d0f73b ("usb: musb: Improve PM runtime and phy handling for 2430 glue layer") moved PHY enable/disable calls to happen from omap2430_musb_enable/disable(). Tha

[PATCH 0/2] Few PM fixes for MUSB for v4.9 merge window

2016-09-15 Thread Tony Lindgren
Hi, I noticed few corner cases we're not handling properly with the musb hardware session bit based PM runtime heading for v4.9. Probably the disconnect after unconfigure PM issue has always been there, but fixing it without the session bit based PM runtime would be a mess. Regards, Tony Tony

[PATCH 2/2] usb: musb: Fix session based PM for first invalid VBUS

2016-09-15 Thread Tony Lindgren
With the session bit based PM runtime working on musb, we've implemented few quirks to attempt to detect the current state of the hardware. One of the quirks is for invalid VBUS as peripheral, but it is not working in all cases. If we start musb on dm3730 as a peripheral with no cable connected, w

[PATCH 1/2] usb: musb: Fix PM runtime for disconnect after unconfigure

2016-09-15 Thread Tony Lindgren
If we unconfigure musb as a USB peripheral with cable connected, and then remove the cable, no interrupts will happen. And musb thinks we're still connected keeping the device active. Now with the session bit based PM runtime working for musb, we can fix this issue by calling musb irq_work. That r

[PATCH 3/4] USB: ch341: add support for parity, frame length, stop bits

2016-09-15 Thread Aidan Thornton
With the new reinitialization method, configuring parity, different frame lengths and different stop bit settings should work as expected on both CH340G and CH341A. Tested on a loopback-connected CH340G with a logic analyzer, and the only differences from Grigori's CH341A-tested code should be name

[PATCH 4/4] USB: ch341: add debug output for chip version

2016-09-15 Thread Aidan Thornton
Will probably be helpful if there are any more compatibility issues. Signed-off-by: Aidan Thornton --- drivers/usb/serial/ch341.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/serial/ch341.c b/drivers/usb/serial/ch341.c index d5f83ff..2afdda1 100644 --- a/drivers/usb/serial/ch3

[PATCH 2/4] USB: ch341: reinitialize chip on reconfiguration

2016-09-15 Thread Aidan Thornton
Changing the LCR register after initialization does not seem to be reliable on all chips (particularly not on CH341A). Restructure initialization and configuration to always reinit the chip on configuration changes instead and pass the LCR register value directly to the initialization command. Cl

[PATCH 1/4] USB: ch341: add register and USB request definitions

2016-09-15 Thread Aidan Thornton
No functional changes, this just gives names to some registers and USB requests based on Grigori Goronzy's work and WinChipTech's Linux driver (which reassuringly agree), then uses them in place of magic numbers. This also renames the misnamed BREAK2 register (actually UART config) Signed-off-by:

[PATCH 0/4] ch341 cleanup and parity etc support

2016-09-15 Thread Aidan Thornton
This is an attempt to clean-up and resubmit some patches by Grigori Goronzy a few months back adding support for parity, frame length, and 2 stop bits to the CH340/1 driver and cleaning up some magic constants. His original patch series also went on to add RTS/CTS hardware flow control and some ot

Re: next-20160915 build: 2 failures 16 warnings (next-20160915)

2016-09-15 Thread Mark Brown
On Thu, Sep 15, 2016 at 12:43:41PM +0100, Build bot for Mark Brown wrote: Today's -next fails to build both arm and arm64 allmodconfigs due to: > arm64-allmodconfig > ERROR: "musb_root_disconnect" [drivers/usb/musb/sunxi.ko] undefined! > arm-allmodconfig > ERROR: "musb_root_disconnec

Re: VL805 USB 3.0 does not see connected devices (only on x86_64) (x86 is ok)

2016-09-15 Thread c400
roger that i`ll test it and write back after weekends 2016-09-15 17:29 GMT+03:00 c400 : >>Obviously you're not reading my email messages. I told you quite >>clearly: >> >>After unloading the xhci-pci and xhci-hcd modules: >> >>sudo modprobe xhci_hcd quirks=0x00800090 >>sud

Re: VL805 USB 3.0 does not see connected devices (only on x86_64) (x86 is ok)

2016-09-15 Thread Alan Stern
On Thu, 15 Sep 2016, c400 wrote: > >Obviously you're not reading my email messages. I told you quite > >clearly: > > > >After unloading the xhci-pci and xhci-hcd modules: > > > >sudo modprobe xhci_hcd quirks=0x00800090 > >sudo modprobe xhci_pci > ==

Re: [PATCH V5] leds: trigger: Introduce a USB port trigger

2016-09-15 Thread Jacek Anaszewski
On 09/15/2016 03:33 PM, Rafał Miłecki wrote: On 15 September 2016 at 14:56, Pavel Machek wrote: On Fri 2016-09-09 13:31:10, Rafał Miłecki wrote: On 9 September 2016 at 13:05, Greg KH wrote: On Fri, Sep 09, 2016 at 05:34:40PM +0800, Peter Chen wrote: On Thu, Sep 08, 2016 at 06:08:24PM +0200,

[PATCH] usb: gadget: udc: atmel: fix endpoint name

2016-09-15 Thread Alexandre Belloni
Since commit c32b5bcfa3c4 ("ARM: dts: at91: Fix USB endpoint nodes"), atmel_usba_udc fails with: [ cut here ] WARNING: CPU: 0 PID: 0 at include/linux/usb/gadget.h:405 ecm_do_notify+0x188/0x1a0 Modules linked in: CPU: 0 PID: 0 Comm: swapper Not tainted 4.7.0+ #15 Hardware na

Re: [PATCHv3] usb: musb: Fix unbalanced platform_disable

2016-09-15 Thread Tony Lindgren
* Hans de Goede [160915 07:00]: > Hi, > > On 14-09-16 20:10, Tony Lindgren wrote: > > Commit a83e17d0f73b ("usb: musb: Improve PM runtime and phy handling > > for 2430 glue layer") moved PHY enable/disable calls to happen from > > omap2430_musb_enable/disable(). That broke enumeration for several

Re: VL805 USB 3.0 does not see connected devices (only on x86_64) (x86 is ok)

2016-09-15 Thread c400
>Obviously you're not reading my email messages. I told you quite >clearly: > >After unloading the xhci-pci and xhci-hcd modules: > >sudo modprobe xhci_hcd quirks=0x00800090 >sudo modprobe xhci_pci === this part of commands from y

[PATCH v1 2/3] usb: gadget: NCM: link socket buffers to the device for received packets

2016-09-15 Thread Harish Jenny K N
From: Torsten Polle Socket buffers should be linked to the (network) device that allocated the buffers. __netdev_alloc_skb performs this task. Signed-off-by: Torsten Polle Signed-off-by: Jim Baxter Signed-off-by: Harish Jenny K N --- drivers/usb/gadget/function/u_ether.c |2 +- 1 file ch

[TESTPATCH] xhci: fix deadlock at host remove by running watchdog correctly

2016-09-15 Thread Mathias Nyman
If a URB is killed while the host is removed we can end up in a situation where the hub thread takes the roothub device lock, and waits for the URB to be given back by xhci-hcd, blocking the host remove code. xhci-hcd tries to stop the endpoint and give back the urb, but can't as the host is remov

[PATCH v1 3/3] usb: gadget: NCM: differentiate consumed packets from dropped packets

2016-09-15 Thread Harish Jenny K N
From: Torsten Polle dev_kfree_skb_any() is used to free packets that are dropped by the network stack. Therefore the function should not be used for packets that have been successfully processed by the network stack. Instead dev_consume_skb_any() has to be used for such consumed packets. This se

[PATCH v1 1/3] usb: gadget: NCM: link socket buffers to the device for tx packets

2016-09-15 Thread Harish Jenny K N
From: Torsten Polle Socket buffers should be linked to the (network) device that allocated the buffers. Signed-off-by: Torsten Polle Signed-off-by: Harish Jenny K N --- drivers/usb/gadget/function/f_ncm.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/gadget/function/f_

[PATCH v1 0/3] Usb gadget ncm code cleanup

2016-09-15 Thread Harish Jenny K N
This patchset consists of some code cleanup in usb gadget ncm code. Note: Testing has only been done on an ARM i.MX6 based platform. Torsten Polle (3): usb: gadget: NCM: link socket buffers to the device for tx packets usb: gadget: NCM: link socket buffers to the device for received packe

Re: xHCI problem? [was Re: Erratic USB device behavior and device loss]

2016-09-15 Thread Alan Stern
On Thu, 15 Sep 2016, Ulf Hansson wrote: > > The situation isn't any better. At the start of the trace, > > the device is in runtime suspend but there are many attempts to > > communicate with it, all of which fail. > > It's really weird. Have this driver ever worked!? :-) Probably not. Or at l

Re: VL805 USB 3.0 does not see connected devices (only on x86_64) (x86 is ok)

2016-09-15 Thread Alan Stern
On Thu, 15 Sep 2016, c400 wrote: > XHCI_NO_64BIT_SUPPORT > can't find such flag in my kernel config. May be you can help me to > find it in menuconfig tree? It's not there. Obviously you're not reading my email messages. I told you quite clearly: After unloading the xhci-pci and xhci-h

Re: [PATCHv3] usb: musb: Fix unbalanced platform_disable

2016-09-15 Thread Hans de Goede
Hi, On 14-09-16 20:10, Tony Lindgren wrote: Commit a83e17d0f73b ("usb: musb: Improve PM runtime and phy handling for 2430 glue layer") moved PHY enable/disable calls to happen from omap2430_musb_enable/disable(). That broke enumeration for several devices as PM runtime in the PHY will never enab

Re: xHCI problem? [was Re: Erratic USB device behavior and device loss]

2016-09-15 Thread Ulf Hansson
On 14 September 2016 at 17:19, Alan Stern wrote: > On Wed, 14 Sep 2016, Ritesh Raj Sarraf wrote: > >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA512 >> >> Hello Ulf and Alan, >> >> On Fri, 2016-09-09 at 19:34 +0530, Ritesh Raj Sarraf wrote: >> > For #2, I'm building the 4.8-rc5 kernel with the

Re: [PATCH V5] leds: trigger: Introduce a USB port trigger

2016-09-15 Thread Rafał Miłecki
On 15 September 2016 at 14:56, Pavel Machek wrote: > On Fri 2016-09-09 13:31:10, Rafał Miłecki wrote: >> On 9 September 2016 at 13:05, Greg KH wrote: >> > On Fri, Sep 09, 2016 at 05:34:40PM +0800, Peter Chen wrote: >> >> On Thu, Sep 08, 2016 at 06:08:24PM +0200, Rafał Miłecki wrote: >> >> > From:

Re: [PATCH V5] leds: trigger: Introduce a USB port trigger

2016-09-15 Thread Pavel Machek
On Fri 2016-09-09 13:31:10, Rafał Miłecki wrote: > On 9 September 2016 at 13:05, Greg KH wrote: > > On Fri, Sep 09, 2016 at 05:34:40PM +0800, Peter Chen wrote: > >> On Thu, Sep 08, 2016 at 06:08:24PM +0200, Rafał Miłecki wrote: > >> > From: Rafał Miłecki > >> > > >> > This commit adds a new trigg

Re: 转发: [PATCH] usb: serial: update CH34x driver in drivers/usb/serial

2016-09-15 Thread Johan Hovold
On Thu, Sep 15, 2016 at 11:19:26AM +0100, Aidan Thornton wrote: > On Thu, Sep 15, 2016 at 6:56 AM, Greg KH wrote: > > On Thu, Sep 15, 2016 at 12:03:48AM +0100, Aidan Thornton wrote: > >> > >> It looks like someone by the name of Grigori Goronzy (CCed) had a patch > >> series > >> or four attempti

Re: [PATCH v16 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-09-15 Thread Pavel Machek
Hi! > > That's not actually 100% clear to me - for what the wm831x is doing it > > probably *does* want the higher limit. This is a system inflow limit > > (as it should be for this), at least the charger will adapt to voltage > > variations though other users in the system are much less likely t

Re: [PATCH 4/7] phy: meson: add USB2 PHY support for Meson8b and GXBB

2016-09-15 Thread Philipp Zabel
Hi Martin, Am Mittwoch, den 14.09.2016, 23:23 +0200 schrieb Martin Blumenstingl: [...] > > We could add a triggered flag or a counter to struct reset_control, and > > have reset_control_reset_once do nothing if it is already set / > > incremented. Since the reset_control goes away with the last co

Re: 转发: [PATCH] usb: serial: update CH34x driver in drivers/usb/serial

2016-09-15 Thread Aidan Thornton
On Thu, Sep 15, 2016 at 6:56 AM, Greg KH wrote: > On Thu, Sep 15, 2016 at 12:03:48AM +0100, Aidan Thornton wrote: >> >> It looks like someone by the name of Grigori Goronzy (CCed) had a patch >> series >> or four attempting to do this that just never went anywhere like all the >> other >> attemp

Re: [PATCH 1/6] staging: lustre: Add space b/w concatenated strings

2016-09-15 Thread Greg Kroah-Hartman
On Thu, Sep 15, 2016 at 01:34:48PM +0530, Rehas Sachdeva wrote: > Fixes checkpatch.pl warning: > CHECK: Concatenated strings should use spaces between elements > > Signed-off-by: Rehas Sachdeva > --- > drivers/staging/lustre/lustre/fid/fid_request.c | 8 > drivers/staging/lustre/lustre/

Re: [GIT PULL] usb: chipidea changes for v4.9-rc1

2016-09-15 Thread Greg KH
On Thu, Sep 15, 2016 at 03:48:50PM +0800, Peter Chen wrote: > The following changes since commit 050bc4e846af24e77af82d0fa5f718e0919d15a4: > > scsi: introduce a quirk for false cache reporting (2016-09-13 08:08:24 > +0200) > > are available in the git repository at: > > git://git.kernel.org

Re: [RFC/PATCH] usb: misc: Add a driver for TC7USB40MU

2016-09-15 Thread Peter Chen
On Wed, Sep 14, 2016 at 01:45:04AM -0700, Stephen Boyd wrote: > Quoting Peter Chen (2016-09-14 01:03:21) > > On Tue, Sep 13, 2016 at 10:58:26PM -0700, Stephen Boyd wrote: > > > Quoting Peter Chen (2016-09-13 20:32:00) > > > > On Tue, Sep 13, 2016 at 06:42:46PM -0700, Stephen Boyd wrote: > > > > > O

Re: [Outreachy kernel] [PATCH 5/6] staging: lustre: Remove unnecessary 'return'

2016-09-15 Thread Julia Lawall
On Thu, 15 Sep 2016, Rehas Sachdeva wrote: > Fixes checkpatch.pl warning: > WARNING: void function return statements are not generally useful. It would be better to say what you did, rather than saying fix. Here you could say: Remove unnecessary void return at the end of a function. Issue dete

[PATCH 6/6] staging: lustre: Fix indentation

2016-09-15 Thread Rehas Sachdeva
Fixes checkpatch.pl warning: Statements should start on a tabstop. Signed-off-by: Rehas Sachdeva --- drivers/staging/lustre/lustre/llite/file.c | 2 +- drivers/staging/lustre/lustre/llite/rw.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/lustre/lustre/

[PATCH 5/6] staging: lustre: Remove unnecessary 'return'

2016-09-15 Thread Rehas Sachdeva
Fixes checkpatch.pl warning: WARNING: void function return statements are not generally useful. Signed-off-by: Rehas Sachdeva --- drivers/staging/lustre/lustre/llite/rw.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/lustre/lustre/llite/rw.c b/drivers/staging/lustre/lustr

[PATCH 4/6] staging: lustre: Change 'seq_printf' to 'seq_puts'

2016-09-15 Thread Rehas Sachdeva
Fixes checkpatch.pl warning: Prefer seq_puts to seq_printf. This can be done as both have same type of first two arguments in their function definition. Signed-off-by: Rehas Sachdeva --- drivers/staging/lustre/lustre/llite/lproc_llite.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 2/6] staging: lustre: Fix block comment style

2016-09-15 Thread Rehas Sachdeva
Fixes checkpatch.pl warning: WARNING: Block comments use a trailing */ on a separate line. Signed-off-by: Rehas Sachdeva --- drivers/staging/lustre/lustre/ldlm/ldlm_request.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/lustre/lustre/ldlm/ldlm_request

[PATCH 1/6] staging: lustre: Add space b/w concatenated strings

2016-09-15 Thread Rehas Sachdeva
Fixes checkpatch.pl warning: CHECK: Concatenated strings should use spaces between elements Signed-off-by: Rehas Sachdeva --- drivers/staging/lustre/lustre/fid/fid_request.c | 8 drivers/staging/lustre/lustre/fid/lproc_fid.c | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) di

[GIT PULL] usb: chipidea changes for v4.9-rc1

2016-09-15 Thread Peter Chen
The following changes since commit 050bc4e846af24e77af82d0fa5f718e0919d15a4: scsi: introduce a quirk for false cache reporting (2016-09-13 08:08:24 +0200) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/peter.chen/usb.git/ tags/usb-ci-v4.9-rc1 for you