Re: [PATCH 0/2] Intel cherrytrail xhci extended cap phy/mux support

2016-12-23 Thread Hans de Goede
HI, On 23-12-16 02:25, Lu Baolu wrote: Hi, On 12/22/2016 09:18 PM, Felipe Balbi wrote: Hi, Hans de Goede writes: Matthias, assuming Felipe is ok with putting this in drivers/misc (minus the phy bindings), are you ok with the xhci blurb which registers the platform-device for the "misc"

Re: [PATCH 2/2] phy: Add new Intel Cherrytrail USB OTG phy driver

2016-12-23 Thread Hans de Goede
Hi, On 23-12-16 02:04, Lu Baolu wrote: Hi, On 12/22/2016 07:47 PM, Hans de Goede wrote: +static int intel_cht_usb_phy_probe(struct platform_device *pdev) +{ + struct intel_cht_usb_phy *phy; + struct device *dev = &pdev->dev; + struct resource *res; + resource_size_t siz

Re: [PATCH 0/2] Intel cherrytrail xhci extended cap phy/mux support

2016-12-23 Thread Hans de Goede
HI, On 22-12-16 17:28, Mathias Nyman wrote: On 22.12.2016 14:45, Hans de Goede wrote: Hi, On 22-12-16 13:11, Felipe Balbi wrote: Hi, Hans de Goede writes: Hi All, Here are 2 patches which can and should be merged separately, but which do belong together, as together they add support for

Re: [PATCH v2 REGRESSION RESEND] usb: ohci-at91: use descriptor-based gpio APIs correctly

2016-12-23 Thread Greg Kroah-Hartman
On Thu, Dec 22, 2016 at 09:38:08PM +0100, Peter Rosin wrote: > On 2016-12-22 18:27, Greg Kroah-Hartman wrote: > > On Thu, Dec 22, 2016 at 08:43:55AM +0100, Peter Rosin wrote: > >> The gpiod_get* function family does not want the -gpio suffix. > >> Use devm_gpiod_get_index_optional instead of devm_g

Re: DWC3 + g_ether: crash when qmult is increased

2016-12-23 Thread Felipe Balbi
Hi, Jean-Jacques Hiblot writes: >>> Jean-Jacques Hiblot writes: Hi Felipe, While trying out the v4.9 kernel on a DRA7x, I stumbled upon this crash. I haven't tried to bisect yet and probably won't be do it before next year. This crash doesn't occur with a 4.4

Re: DWC3 + g_ether: crash when qmult is increased

2016-12-23 Thread Jean-Jacques Hiblot
On 23/12/2016 13:44, Felipe Balbi wrote: Hi, Felipe Balbi writes: Hi, Jean-Jacques Hiblot writes: Hi Felipe, While trying out the v4.9 kernel on a DRA7x, I stumbled upon this crash. I haven't tried to bisect yet and probably won't be do it before next year. This crash doesn't occur with

Re: JMS56x not working reliably with uas driver

2016-12-23 Thread Alan Stern
On Fri, 23 Dec 2016, George Cherian wrote: > >> 2) On disconnect I am seeing the following issue > >> > >>scsi host4: uas_post_reset: alloc streams error -19 after reset > >>sd 4:0:0:0: [sdb] Synchronizing SCSI cache > >> > >> This is more fatal because after these messages the USB port be

Re: [PATCH 2/2] usb: host: xhci: Handle the right timeout command

2016-12-23 Thread Mathias Nyman
On 22.12.2016 03:46, Lu Baolu wrote: Hi, On 12/21/2016 11:18 PM, OGAWA Hirofumi wrote: Mathias Nyman writes: We set CMD_RING_STATE_ABORTED state under locking. I'm not checking what is for taking lock for register though, I guess it should be enough just lock around of read=>write of ->cmd_r

Re: DWC3 + g_ether: crash when qmult is increased

2016-12-23 Thread Felipe Balbi
Hi, Felipe Balbi writes: > Hi, > > Jean-Jacques Hiblot writes: >> Hi Felipe, >> >> While trying out the v4.9 kernel on a DRA7x, I stumbled upon this >> crash. I haven't tried to bisect yet and probably won't be do it >> before next year. >> >> This crash doesn't occur with a 4.4 kernel. I suspe

Re: [PATCH 1/1] usb: xhci: hold lock over xhci_abort_cmd_ring()

2016-12-23 Thread Mathias Nyman
On 23.12.2016 08:46, Lu Baolu wrote: In command timer function, xhci_handle_command_timeout(), xhci->lock is unlocked before call into xhci_abort_cmd_ring(). This might cause race between the timer function and the event handler. The xhci_abort_cmd_ring() function sets the CMD_RING_ABORT bit in

Re: [PATCH 0/1] xhci: Fix race related to abort operation

2016-12-23 Thread Mathias Nyman
On 23.12.2016 08:50, Lu Baolu wrote: Hi Mathias, This is a follow-up patch for below comment "rebase OGAWA Hirofumi's changes on top of that, and send to usb-linus only" in below discussion thread. https://lkml.org/lkml/2016/12/21/186 I rebased the patch and added unlock-before and lock-afte

Re: DWC3 + ECM: performance regression

2016-12-23 Thread Felipe Balbi
Hi, Jean-Jacques Hiblot writes: > Hi Felipe, > > I noticed a performance regression with commit > fd9afd3cbe404998d732be6cc798f749597c5114 "usb: gadget: u_ether: remove > interrupt throttling". > > I read the discussion leading to this commit and I agree that the > interrupt throttling may no

Re: DWC3 + g_ether: crash when qmult is increased

2016-12-23 Thread Felipe Balbi
Hi, Jean-Jacques Hiblot writes: > Hi Felipe, > > While trying out the v4.9 kernel on a DRA7x, I stumbled upon this > crash. I haven't tried to bisect yet and probably won't be do it > before next year. > > This crash doesn't occur with a 4.4 kernel. I suspect it has to do > with the changes in t

DWC3 + ECM: performance regression

2016-12-23 Thread Jean-Jacques Hiblot
Hi Felipe, I noticed a performance regression with commit fd9afd3cbe404998d732be6cc798f749597c5114 "usb: gadget: u_ether: remove interrupt throttling". I read the discussion leading to this commit and I agree that the interrupt throttling may not have been done perfectly and could lead to s

Re: [PATCH 4/4] usb: xhci: warn on command timeout in stopped command ring

2016-12-23 Thread Sergei Shtylyov
Hello! On 12/23/2016 9:52 AM, Lu Baolu wrote: If xhci host fails to response to a command, the command s/response/respond/. watchdog timer will be fired. The callback function will abort and clear current command and restart the command execution. If driver fails to restart command execu