Re: [PATCH v6 23/25] usb: chipidea: Pullup D+ in device mode via phy APIs

2017-01-17 Thread Peter Chen
On Tue, Jan 17, 2017 at 09:58:33AM -0800, Stephen Boyd wrote: > Quoting Peter Chen (2017-01-15 19:45:51) > > > > So, you need to call phy_set_mode when switching between host and device. > > Besides, you also need to toggle VBUSVLDEXT when the external vbus > > is on or off at device mode

Re: [PATCH v2 25/28] usb: dwc2: Add a quirk to allow speed negotiation for Hisilicon Hi6220

2017-01-17 Thread John Youn
On 1/17/2017 10:58 PM, Stefan Wahren wrote: > Hi John, > > is there a public git repo where this series is already applied? > > Stefan > Hi Stefan, Yes, here: https://github.com/synopsys-usb/linux.git I know you're still waiting for the FIFO stuff. We'll send out a first version of that

Re: [PATCH v2 25/28] usb: dwc2: Add a quirk to allow speed negotiation for Hisilicon Hi6220

2017-01-17 Thread Stefan Wahren
Hi John, is there a public git repo where this series is already applied? Stefan -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] usb: core: update comments for send message functions

2017-01-17 Thread Kim Jaejoong
Keep sending several times same patch file is totally my fault. I am really sorry about that. (today I said lots of 'sorry'..) My default gmail's view options is conversation view. And this conversation view option makes me misunderstand my resend path is reply the previous mail with subject

Re: [PATCH v5 0/4] usb: early: add support for early printk through USB3 debug port

2017-01-17 Thread Lu Baolu
Hi Greg, This patch series has been there for 2 months without further comments. Will you consider it for usb-next? Best regards, Lu Baolu On 11/15/2016 02:02 PM, Lu Baolu wrote: > xHCI debug capability (DbC) is an optional but standalone > functionality provided by an xHCI host controller.

[PATCH v2] usb: core: update comments for send message functions

2017-01-17 Thread Jaejoong Kim
The commonly use of bottom halves are tasklet and workqueue. The big difference between tasklet and workqueue is that the tasklet runs in an interrupt context and the workqueue runs in a process context, which means it can sleep if need be. The comment for usb_control/interrupt/bulk_msg()

[PATCH 1/6] usb: mtu3: get resources that cause deferred probe earlier

2017-01-17 Thread Chunfeng Yun
Some resources such as regulator, clock usually cause deferred probe, get them earlier to avoid more ineffective processing. Signed-off-by: Chunfeng Yun --- drivers/usb/mtu3/mtu3_plat.c | 24 1 file changed, 12 insertions(+), 12 deletions(-)

[PATCH 2/6] usb: mtu3: add reference clock

2017-01-17 Thread Chunfeng Yun
usually, the reference clock comes from 26M oscillator directly, but some SoCs are not, add it for compatibility. Signed-off-by: Chunfeng Yun --- drivers/usb/mtu3/mtu3.h |1 + drivers/usb/mtu3/mtu3_plat.c | 21 +++-- 2 files changed, 20

[PATCH 3/6] usb: xhci-mtk: add reference clock

2017-01-17 Thread Chunfeng Yun
usually, the reference clock comes from 26M oscillator directly, but some SoCs are not, add it for compatibility. Signed-off-by: Chunfeng Yun --- drivers/usb/host/xhci-mtk.c | 15 +++ drivers/usb/host/xhci-mtk.h |1 + 2 files changed, 16

[PATCH 5/6] dt-bindings: mt8173-xhci: add reference clock

2017-01-17 Thread Chunfeng Yun
add a reference clock for compatibility Signed-off-by: Chunfeng Yun --- .../devicetree/bindings/usb/mt8173-xhci.txt| 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/Documentation/devicetree/bindings/usb/mt8173-xhci.txt

[PATCH 4/6] arm64: dts: mt8173: add reference clock for usb

2017-01-17 Thread Chunfeng Yun
add 26M reference clock for ssusb and xhci nodes Signed-off-by: Chunfeng Yun --- arch/arm64/boot/dts/mediatek/mt8173.dtsi |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi

[PATCH 6/6] dt-bindings: mt8173-mtu3: add reference clock

2017-01-17 Thread Chunfeng Yun
add a reference clock for compatibility Signed-off-by: Chunfeng Yun --- .../devicetree/bindings/usb/mt8173-mtu3.txt| 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/Documentation/devicetree/bindings/usb/mt8173-mtu3.txt

[RESEND PATCH 6/6] dt-bindings: phy-mt65xx-usb: add support for mt2712 platform

2017-01-17 Thread Chunfeng Yun
add a new compatible string for "mt2712", and a new reference clock for SuperSpeed analog phy; Signed-off-by: Chunfeng Yun --- .../devicetree/bindings/phy/phy-mt65xx-usb.txt | 81 +--- 1 file changed, 70 insertions(+), 11 deletions(-) diff --git

[RESEND PATCH 2/6] phy: phy-mt65xx-usb3: split SuperSpeed port into two ones

2017-01-17 Thread Chunfeng Yun
Currently usb3 port in fact includes two sub-ports, but it is not flexible for some cases, such as following one: usb3 port0 includes u2port0 and u3port0; usb2 port0 includes u2port1; If wants to support only HS, we can use u2port0 or u2port1, when select u2port0, u3port0 is not needed; If

[RESEND PATCH 4/6] arm64: dts: mt8173: add a new reference clock for usb3 analog phy

2017-01-17 Thread Chunfeng Yun
add a new reference clock which comes from 26M oscillator directly for SuperSpeed analog phy. and the old one which comes for PLL is 48M for HighSpeed analog phy. Signed-off-by: Chunfeng Yun --- arch/arm64/boot/dts/mediatek/mt8173.dtsi |4 ++-- 1 file changed, 2

[RESEND PATCH 1/6] phy: phy-mt65xx-usb3: add reference clock of usb3 analog phy

2017-01-17 Thread Chunfeng Yun
usually, the reference clock of usb3 analog phy comes from 26M oscillator directly, but some SoCs are not, add it for compatibility. Signed-off-by: Chunfeng Yun --- drivers/phy/phy-mt65xx-usb3.c | 36 1 file changed, 28

[RESEND PATCH 5/6] arm64: dts: mt8173: split usb SuperSpeed port into two ports

2017-01-17 Thread Chunfeng Yun
split the old SuperSpeed port node into a HighSpeed one and a new SuperSpeed one. Signed-off-by: Chunfeng Yun --- arch/arm64/boot/dts/mediatek/mt8173.dtsi | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git

[RESEND PATCH 3/6] phy: phy-mt65xx-usb3: add support for mt2712 platform

2017-01-17 Thread Chunfeng Yun
There are some variations from mt2701 to mt2712: 1. banks shared by multiple ports are put back into each port, such as SPLLC and U2FREQ; 2. add a new bank MISC for u2port, and CHIP for u3port; 3. bank's offset in each port are also rearranged; Signed-off-by: Chunfeng Yun

[PATCH 3/6] phy: phy-mt65xx-usb3: add support for mt2712 platform

2017-01-17 Thread Chunfeng Yun
There are some variations from mt2701 to mt2712: 1. banks shared by multiple ports are put back into each port, such as SPLLC and U2FREQ; 2. add a new bank MISC for u2port, and CHIP for u3port; 3. bank's offset in each port are also rearranged; Signed-off-by: Chunfeng Yun

[PATCH 2/6] phy: phy-mt65xx-usb3: split SuperSpeed port into two ones

2017-01-17 Thread Chunfeng Yun
Currently usb3 port in fact includes two sub-ports, but it is not flexible for some cases, such as following one: usb3 port0 includes u2port0 and u3port0; usb2 port0 includes u2port1; If wants to support only HS, we can use u2port0 or u2port1, when select u2port0, u3port0 is not needed; If

[PATCH 4/6] arm64: dts: mt8173: add a new reference clock for usb3 analog phy

2017-01-17 Thread Chunfeng Yun
add a new reference clock which comes from 26M oscillator directly for SuperSpeed analog phy. and the old one which comes for PLL is 48M for HighSpeed analog phy. Signed-off-by: Chunfeng Yun --- arch/arm64/boot/dts/mediatek/mt8173.dtsi |4 ++-- 1 file changed, 2

[PATCH 5/6] arm64: dts: mt8173: split usb SuperSpeed port into two ports

2017-01-17 Thread Chunfeng Yun
split the old SuperSpeed port node into a HighSpeed one and a new SuperSpeed one. Signed-off-by: Chunfeng Yun --- arch/arm64/boot/dts/mediatek/mt8173.dtsi | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git

[PATCH 6/6] dt-bindings: phy-mt65xx-usb: add support for mt2712 platform

2017-01-17 Thread Chunfeng Yun
add a new compatible string for "mt2712", and a new reference clock for SuperSpeed analog phy; Signed-off-by: Chunfeng Yun --- .../devicetree/bindings/phy/phy-mt65xx-usb.txt | 81 +--- 1 file changed, 70 insertions(+), 11 deletions(-) diff --git

[PATCH 1/6] phy: phy-mt65xx-usb3: add reference clock of usb3 analog phy

2017-01-17 Thread Chunfeng Yun
usually, the reference clock of usb3 analog phy comes from 26M oscillator directly, but some SoCs are not, add it for compatibility. Signed-off-by: Chunfeng Yun --- drivers/phy/phy-mt65xx-usb3.c | 36 1 file changed, 28

[PATCH v2 22/28] usb: dwc2: Avoid sleeping while holding hsotg->lock

2017-01-17 Thread John Youn
From: John Stultz Basically when plugging in various cables in different orders, I'm occasionally seeing the following BUG splat: [ 86.215403] BUG: scheduling while atomic: kworker/u16:2/53/0x0002 [ 86.219164] usb 1-1: USB disconnect, device number 9 [

[PATCH v2 00/28] usb: dwc2: Rework params, checkpatch, and other changes

2017-01-17 Thread John Youn
Hi Felipe, This is a consolidation, rebase, and resend of several dwc2 patch series that were submitted to linux-usb in the past month or so. These should all be applied to testing/next for 4.11. See the following links for the original list messages:

[PATCH v2 05/28] usb: dwc2: Fix brace usage

2017-01-17 Thread John Youn
* Remove braces for one-line statements * Add missing braces where another arm in if-statement uses braces Signed-off-by: John Youn --- drivers/usb/dwc2/gadget.c | 10 -- drivers/usb/dwc2/platform.c | 12 ++-- 2 files changed, 10 insertions(+), 12

[PATCH v2 02/28] usb: dwc2: Add identifier in prototypes

2017-01-17 Thread John Youn
Fixes checkpatch warning: WARNING: function definition argument 'struct dwc2_hsotg *' should also have an identifier name Signed-off-by: John Youn --- drivers/usb/dwc2/debug.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH v2 19/28] usb: dwc2: Add debugfs file to show params

2017-01-17 Thread John Youn
Show the core params and hardware params. Signed-off-by: John Youn --- drivers/usb/dwc2/debugfs.c | 127 + 1 file changed, 127 insertions(+) diff --git a/drivers/usb/dwc2/debugfs.c b/drivers/usb/dwc2/debugfs.c index

[PATCH v2 24/28] usb: dwc2: Force port resume on switching to device mode

2017-01-17 Thread John Youn
From: Chen Yu We've seen failures when switching between host and gadget mode, which was diagnosed as being caused due to the bus being auto-suspended when we switched. So this patch forces a port resume when switching to device mode if the bus is suspended. Cc: Wei Xu

[PATCH v2 25/28] usb: dwc2: Add a quirk to allow speed negotiation for Hisilicon Hi6220

2017-01-17 Thread John Youn
From: Chen Yu The Hi6220's usb controller is limited in that it does not support "Split Transactions", so it does not support communicating with low-speed and full-speed devices behind a high-speed hub. Thus it requires a quirk so that we can manually drop the usb speed

[PATCH v2 27/28] usb: dwc2: host: use true/false for boolean

2017-01-17 Thread John Youn
From: Nicholas Mc Guire For boolean variables true/false is preferred over 1/0 for readability. [johnyoun: minor rebase] Signed-off-by: Nicholas Mc Guire Signed-off-by: John Youn --- drivers/usb/dwc2/hcd.c | 10 +- 1 file

[PATCH v2 23/28] usb: dwc2: Workaround case where GOTGCTL state is wrong

2017-01-17 Thread John Youn
From: John Stultz When removing a USB-A to USB-otg adapter cable, we get a change status irq, and then in dwc2_conn_id_status_change, we erroniously see the GOTGCTL_CONID_B flag set. This causes us to get stuck in the "while (!dwc2_is_device_mode(hsotg))" loop, spitting

[PATCH v2 20/28] usb: dwc2: Remove debug prints in params.c

2017-01-17 Thread John Youn
Remove debugging prints to show params. Signed-off-by: John Youn --- drivers/usb/dwc2/params.c | 56 --- 1 file changed, 56 deletions(-) diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c index

[PATCH v2 26/28] usb: dwc2: host: use msleep() for long delay

2017-01-17 Thread John Youn
From: Nicholas Mc Guire ulseep_range() uses hrtimers and provides no advantage over msleep() for larger delays. Fix up the 100ms delays here passing the adjusted "min" value to msleep(). This helps reduce the load on the hrtimer subsystem. Link:

[PATCH v2 06/28] usb: dwc2: Fix lines over 80 characters

2017-01-17 Thread John Youn
Fix lines over 80 characters. Signed-off-by: John Youn --- drivers/usb/dwc2/core.h | 13 + drivers/usb/dwc2/gadget.c | 14 +- drivers/usb/dwc2/hcd.c | 4 ++-- drivers/usb/dwc2/hcd_intr.c | 13 +++-- drivers/usb/dwc2/params.c |

[PATCH v2 28/28] usb: dwc2: host: use msleep() for long delays

2017-01-17 Thread John Youn
From: Nicholas Mc Guire ulseep_range() uses hrtimers and provides no advantage over msleep() for larger delays. Fix up the 20+ ms delays here passing the adjusted "min" value to msleep(). This helps reduce the load on the hrtimer subsystem. [johnyoun: minor rebase]

[PATCH v2 21/28] usb: dwc2: Show dr_mode via debugfs

2017-01-17 Thread John Youn
Show the value of dr_mode via a debufs file. Signed-off-by: John Youn --- drivers/usb/dwc2/debugfs.c | 29 + 1 file changed, 29 insertions(+) diff --git a/drivers/usb/dwc2/debugfs.c b/drivers/usb/dwc2/debugfs.c index 57747b0df595..794b959a7c8c

[PATCH v2 18/28] usb: dwc2: Remove unnecessary parameters

2017-01-17 Thread John Youn
Further reduce the set of parameters set by platforms. Many of them are unnecessary as they should be reported by hardware. They should only need to be overridden if there is a problem. Signed-off-by: John Youn --- drivers/usb/dwc2/params.c | 11 --- 1 file

[PATCH v2 14/28] usb: dwc2: Rearrange param structure members

2017-01-17 Thread John Youn
Group the members by global, host, and gadget params. Formatting and organizational change only. Signed-off-by: John Youn --- drivers/usb/dwc2/core.h | 51 ++--- 1 file changed, 23 insertions(+), 28 deletions(-) diff --git

[PATCH v2 13/28] usb: dwc2: Update parameter types

2017-01-17 Thread John Youn
Update the param types to appropriately sized ints and bools. Signed-off-by: John Youn --- drivers/usb/dwc2/core.h | 52 - 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a/drivers/usb/dwc2/core.h

[PATCH v2 04/28] usb: dwc2: Fix logical continuations

2017-01-17 Thread John Youn
Fix the formatting of logical statements to end the line with the logical operator. Signed-off-by: John Youn --- drivers/usb/dwc2/core_intr.c | 5 ++--- drivers/usb/dwc2/hcd_ddma.c | 8 drivers/usb/dwc2/hcd_queue.c | 5 ++--- 3 files changed, 8 insertions(+), 10

[PATCH v2 16/28] usb: dwc2: Remove platform static params

2017-01-17 Thread John Youn
Remove the platform-specific static param structs and set only those params that are necessary for each platform. Signed-off-by: John Youn --- drivers/usb/dwc2/params.c | 262 +++--- 1 file changed, 108 insertions(+), 154

[PATCH v2 15/28] usb: dwc2: Check core parameters

2017-01-17 Thread John Youn
Check that core parameters have valid values and adjust them if they aren't. Signed-off-by: John Youn --- drivers/usb/dwc2/params.c | 185 ++ 1 file changed, 185 insertions(+) diff --git a/drivers/usb/dwc2/params.c

[PATCH v2 17/28] usb: dwc2: Fix usage of bool params

2017-01-17 Thread John Youn
Check these parameters only for true or false. There is no need to check for greater or less than 0. Signed-off-by: John Youn --- drivers/usb/dwc2/core.c | 4 +- drivers/usb/dwc2/core.h | 5 -- drivers/usb/dwc2/core_intr.c | 2 +- drivers/usb/dwc2/gadget.c

[PATCH v2 01/28] usb: dwc2: Cleanup some checkpatch issues

2017-01-17 Thread John Youn
This commmit is the result of running checkpatch --fix. The results were verified for correctness. Some of the fixes result in line over 80 char which we will fix manually later. The following is a summary of what was done by checkpatch: * Remove externs on function prototypes. * Replace

[PATCH v2 03/28] usb: dwc2: Fix comment alignment and format

2017-01-17 Thread John Youn
Fix misaligned and over 80-character comments. Signed-off-by: John Youn --- drivers/usb/dwc2/core.h | 19 ++- drivers/usb/dwc2/gadget.c | 43 +++ drivers/usb/dwc2/hcd.c | 2 +- drivers/usb/dwc2/hcd_intr.c

[PATCH v2 12/28] usb: dwc2: Get device properties

2017-01-17 Thread John Youn
After setting the default core parameter values, read in the device properties and modify core parameter values if needed. Signed-off-by: John Youn --- drivers/usb/dwc2/params.c | 35 +++ 1 file changed, 35 insertions(+) diff --git

[PATCH v2 10/28] usb: dwc2: Remove unused otg_ver parameter

2017-01-17 Thread John Youn
The otg_ver parameter only controls the SRP pulsing method and defaults to the 1.3 behavior. It is unused and can be removed. Signed-off-by: John Youn --- drivers/usb/dwc2/core.c | 5 - drivers/usb/dwc2/core.h | 9 - drivers/usb/dwc2/hcd.c| 3 ---

[PATCH v2 08/28] usb: dwc2: Remove 'return' from void function

2017-01-17 Thread John Youn
The function returns void so a return is unnecessary. Signed-off-by: John Youn --- drivers/usb/dwc2/hcd_queue.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/dwc2/hcd_queue.c b/drivers/usb/dwc2/hcd_queue.c index faf45dfbf652..b1fc9fed6ebe 100644 ---

[PATCH v2 11/28] usb: dwc2: Set core parameters to default values

2017-01-17 Thread John Youn
Initialize the core parameters to their default, auto-detected values. Remove all the previous dwc2_set_param* methods. Most of what this code is doing is handling defaults for "not set" values and other trivial checks. The checking can be simplified and will be done in a later commit. This

[PATCH v2 07/28] usb: dwc2: Fix code indentation after conditionals

2017-01-17 Thread John Youn
The indent should be only one tab. Signed-off-by: John Youn --- drivers/usb/dwc2/gadget.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c index 09fadc26023f..559c01e591dc 100644 ---

[PATCH v2 09/28] usb: dwc2: Fix sizeof in kzalloc

2017-01-17 Thread John Youn
Take the sizeof '*req' instead of 'struct dwc2_hsotg_req'. Signed-off-by: John Youn --- drivers/usb/dwc2/gadget.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c index 559c01e591dc..b457522c20f8

Re: [PATCH] usb: dwc2: fix "iomem 0x00000000" message by setting iomem parameters in usb_hcd

2017-01-17 Thread John Youn
On 1/17/2017 12:13 AM, Felipe Balbi wrote: > > Hi, > > Heiner Kallweit writes: >> Am 16.01.2017 um 15:05 schrieb Felipe Balbi: >>> >>> Hi, >>> >>> Heiner Kallweit writes: Set the iomem parameters in the usb_hcd to fix this misleading message

Re: [PATCH v2] usb: core: update comments for send message functions

2017-01-17 Thread Kim Jaejoong
I just want to send v2 patch with new mail thread with subject [PATCH v2] not reply I don't understand why v2 patch mail is followed previous mail thread. --no-chain-reply-to : fail ( this is wrong option for in this case) --subject-prefix "PATCH v2" : fail.. why? This is what I did for send

[PATCH v2] usb: core: update comments for send message functions

2017-01-17 Thread Jaejoong Kim
The commonly use of bottom halves are tasklet and workqueue. The big difference between tasklet and workqueue is that the tasklet runs in an interrupt context and the workqueue runs in a process context, which means it can sleep if need be. The comment for usb_control/interrupt/bulk_msg()

[PATCH v2] usb: core: update comments for send message functions

2017-01-17 Thread Jaejoong Kim
The commonly use of bottom halves are tasklet and workqueue. The big difference between tasklet and workqueue is that the tasklet runs in an interrupt context and the workqueue runs in a process context, which means it can sleep if need be. The comment for usb_control/interrupt/bulk_msg()

[PATCH v2] usb: core: update comments for send message functions

2017-01-17 Thread Jaejoong Kim
The commonly use of bottom halves are tasklet and workqueue. The big difference between tasklet and workqueue is that the tasklet runs in an interrupt context and the workqueue runs in a process context, which means it can sleep if need be. The comment for usb_control/interrupt/bulk_msg()

Re: [PATCH] usb: core: update comments for send message functions

2017-01-17 Thread Kim Jaejoong
really really sorry for noisy mail. Please ignore this mail. I will resend patch with right subject.. Jaejoong 2017-01-18 10:46 GMT+09:00 Jaejoong Kim : > The commonly use of bottom halves are tasklet and workqueue. The big > difference between tasklet and workqueue is

[PATCH] usb: core: update comments for send message functions

2017-01-17 Thread Jaejoong Kim
The commonly use of bottom halves are tasklet and workqueue. The big difference between tasklet and workqueue is that the tasklet runs in an interrupt context and the workqueue runs in a process context, which means it can sleep if need be. The comment for usb_control/interrupt/bulk_msg()

Re: [PATCH] usb: musb: dsps: make dsps_musb_clear_ep_rxintr() static

2017-01-17 Thread Bin Liu
On Tue, Jan 17, 2017 at 05:23:48PM +0100, Greg KH wrote: > On Tue, Jan 17, 2017 at 09:32:05AM -0600, Bin Liu wrote: > > From: Wei Yongjun > > > > Fixes the following sparse warning: > > > > drivers/usb/musb/musb_dsps.c:270:6: warning: > > symbol

Re: [PATCH] usb: core: update comments for send message functions

2017-01-17 Thread Kim Jaejoong
Hi Alan 2017-01-18 0:57 GMT+09:00 Alan Stern : > On Tue, 17 Jan 2017, Jaejoong Kim wrote: > >> The commonly use of a bottom half are tasklet and workqueue. The big >> difference between tasklet and workqueue is that the tasklet runs in >> an interrupt context and the

Re: [PATCH] usb: dwc3 dwc3_exynos_probe() change goto labels to meaningful names

2017-01-17 Thread Shuah Khan
On 01/16/2017 03:33 AM, Felipe Balbi wrote: > > Hi, > > Shuah Khan writes: >> Change goto labels to meaningful names from a series of errNs. >> >> Signed-off-by: Shuah Khan > > doesn't apply to testing/next, please rebase. > Hi Felipe, This

Re: [PATCHv2] dmaengine: cppi41: Fix oops in cppi41_runtime_resume

2017-01-17 Thread Bin Liu
On Tue, Jan 17, 2017 at 09:39:23AM -0800, Tony Lindgren wrote: > * Bin Liu [170117 08:49]: > > On Tue, Jan 17, 2017 at 08:31:03AM -0800, Tony Lindgren wrote: > > > * Bin Liu [170117 08:22]: > > > > On Tue, Jan 17, 2017 at 08:11:39AM -0800, Tony Lindgren wrote: > > > >

usb: gadget: Kernel panic (NULL pointer dereference) when using fsl_udc2_core on i.MX31 PDK

2017-01-17 Thread Magnus Lilja
Hi I tried the fsl_udc_core gadget driver on the i.MX31 PDK board and got a kernel panic (NULL pointer dereference) when connecting the USB cable. I had the g_serial module loaded as well. The NULL pointer panic comes from gadget/udc/core.c usb_gadget_giveback_request() which calls

Re: [PATCH] usb: dwc2: fix "iomem 0x00000000" message by setting iomem parameters in usb_hcd

2017-01-17 Thread Heiner Kallweit
Am 17.01.2017 um 21:08 schrieb Heiner Kallweit: > Am 17.01.2017 um 09:11 schrieb Felipe Balbi: >> >> Hi, >> >> Heiner Kallweit writes: >>> Am 16.01.2017 um 15:05 schrieb Felipe Balbi: Hi, Heiner Kallweit writes: > Set the iomem

[PATCH] usb: dwc2: remove dead function dwc2_pci_quirks

2017-01-17 Thread Heiner Kallweit
Commit 9962b62f1be9 "Deprecate g-use-dma binding" removed the only property in dwc2_pci_quirks. This function is dead code now. Maybe it was kept intentionally to be prepared for the case that another quirk-related property needs to be added in future. If not it can be removed. Signed-off-by:

Re: [PATCHv2] dmaengine: cppi41: Fix oops in cppi41_runtime_resume

2017-01-17 Thread Tony Lindgren
* Bin Liu [170117 11:47]: > On Tue, Jan 17, 2017 at 09:39:23AM -0800, Tony Lindgren wrote: > > * Bin Liu [170117 08:49]: > > > On Tue, Jan 17, 2017 at 08:31:03AM -0800, Tony Lindgren wrote: > > > > * Bin Liu [170117 08:22]: > > > > > On Tue, Jan 17,

Re: [PATCH 1/4] phy: sun4i-usb: support PHY0 on H3 in MUSB mode

2017-01-17 Thread Maxime Ripard
On Wed, Jan 18, 2017 at 12:57:08AM +0800, Icenowy Zheng wrote: > > > 17.01.2017, 16:06, "Maxime Ripard" : > > On Tue, Jan 17, 2017 at 03:14:46AM +0800, Icenowy Zheng wrote: > >>  The PHY0 on H3 can be wired either to MUSB controller or OHCI/EHCI > >>  

Re: [PATCH 1/4] phy: sun4i-usb: support PHY0 on H3 in MUSB mode

2017-01-17 Thread Chen-Yu Tsai
Hi, On Wed, Jan 18, 2017 at 4:06 AM, Maxime Ripard wrote: > On Wed, Jan 18, 2017 at 12:57:08AM +0800, Icenowy Zheng wrote: >> >> >> 17.01.2017, 16:06, "Maxime Ripard" : >> > On Tue, Jan 17, 2017 at 03:14:46AM +0800, Icenowy

Re: [PATCH] usb: dwc2: fix "iomem 0x00000000" message by setting iomem parameters in usb_hcd

2017-01-17 Thread Heiner Kallweit
Am 17.01.2017 um 09:11 schrieb Felipe Balbi: > > Hi, > > Heiner Kallweit writes: >> Am 16.01.2017 um 15:05 schrieb Felipe Balbi: >>> >>> Hi, >>> >>> Heiner Kallweit writes: Set the iomem parameters in the usb_hcd to fix this misleading

Re: [PATCH] usb: musb: dsps: make dsps_musb_clear_ep_rxintr() static

2017-01-17 Thread Bin Liu
On Tue, Jan 17, 2017 at 07:28:29PM +0100, Greg KH wrote: > On Tue, Jan 17, 2017 at 10:43:28AM -0600, Bin Liu wrote: > > On Tue, Jan 17, 2017 at 05:23:48PM +0100, Greg KH wrote: > > > On Tue, Jan 17, 2017 at 09:32:05AM -0600, Bin Liu wrote: > > > > From: Wei Yongjun > > > >

Re: [PATCH] usb: musb: dsps: make dsps_musb_clear_ep_rxintr() static

2017-01-17 Thread Greg KH
On Tue, Jan 17, 2017 at 10:43:28AM -0600, Bin Liu wrote: > On Tue, Jan 17, 2017 at 05:23:48PM +0100, Greg KH wrote: > > On Tue, Jan 17, 2017 at 09:32:05AM -0600, Bin Liu wrote: > > > From: Wei Yongjun > > > > > > Fixes the following sparse warning: > > > > > >

[PATCHv3] dmaengine: cppi41: Fix oops in cppi41_runtime_resume

2017-01-17 Thread Tony Lindgren
Commit fdea2d09b997 ("dmaengine: cppi41: Add basic PM runtime support") together with recent MUSB changes allowed USB and DMA on BeagleBone to idle when no cable is connected. But looks like few corner case issues still remain. Looks like just by re-plugging USB cable about ten or so times on

Re: [PATCHv2] dmaengine: cppi41: Fix oops in cppi41_runtime_resume

2017-01-17 Thread Tony Lindgren
* Bin Liu [170117 08:49]: > On Tue, Jan 17, 2017 at 08:31:03AM -0800, Tony Lindgren wrote: > > * Bin Liu [170117 08:22]: > > > On Tue, Jan 17, 2017 at 08:11:39AM -0800, Tony Lindgren wrote: > > > > * Bin Liu [170117 05:00]: > > > > > On Mon, Jan 16,

Re: [PATCHv2] dmaengine: cppi41: Fix oops in cppi41_runtime_resume

2017-01-17 Thread Bin Liu
On Tue, Jan 17, 2017 at 08:31:03AM -0800, Tony Lindgren wrote: > * Bin Liu [170117 08:22]: > > On Tue, Jan 17, 2017 at 08:11:39AM -0800, Tony Lindgren wrote: > > > * Bin Liu [170117 05:00]: > > > > On Mon, Jan 16, 2017 at 03:54:29PM -0800, Tony Lindgren wrote: > > > >

Re: [PATCHv2] dmaengine: cppi41: Fix oops in cppi41_runtime_resume

2017-01-17 Thread Tony Lindgren
* Bin Liu [170117 08:22]: > On Tue, Jan 17, 2017 at 08:11:39AM -0800, Tony Lindgren wrote: > > * Bin Liu [170117 05:00]: > > > On Mon, Jan 16, 2017 at 03:54:29PM -0800, Tony Lindgren wrote: > > > > Anyways, for the -rc series oops, we can just leave out the WARN_ON >

Re: [PATCH] usb: musb: dsps: make dsps_musb_clear_ep_rxintr() static

2017-01-17 Thread Greg KH
On Tue, Jan 17, 2017 at 09:32:05AM -0600, Bin Liu wrote: > From: Wei Yongjun > > Fixes the following sparse warning: > > drivers/usb/musb/musb_dsps.c:270:6: warning: > symbol 'dsps_musb_clear_ep_rxintr' was not declared. Should it be static? > > Signed-off-by: Wei

Re: [PATCHv2] dmaengine: cppi41: Fix oops in cppi41_runtime_resume

2017-01-17 Thread Bin Liu
On Tue, Jan 17, 2017 at 08:11:39AM -0800, Tony Lindgren wrote: > * Bin Liu [170117 05:00]: > > On Mon, Jan 16, 2017 at 03:54:29PM -0800, Tony Lindgren wrote: > > > Anyways, for the -rc series oops, we can just leave out the WARN_ON > > > parts for now until

[PATCH v3 0/5] usb: dwc2: Add support for USB OTG on STM32F4x9

2017-01-17 Thread Bruno Herrera
The STM32F4x9 MCU family has two DWC2 USB OTG cores on it. One core is USB OTG FS and other core is USB OTG HS. The USB FS core only works with its internal phy whilst the USF HS core can work in HS with external ulpi phy or in FS/LS speed with the embedded FS PHY. The goal of this patch series

[PATCH v3 1/5] usb: dwc2: Add support for STM32F429/439/469 USB OTG HS/FS in FS mode (internal PHY)

2017-01-17 Thread Bruno Herrera
This patch introduces a new parameter to activate USB OTG HS/FS core embedded phy transceiver. The STM32F4x9 SoC uses the GGPIO register to enable the transceiver. Also add the dwc2_core_params structure for stm32f4 otg fs. Signed-off-by: Bruno Herrera ---

[PATCH v3 2/5] ARM: dts: stm32: Add USB FS support for STM32F429 MCU

2017-01-17 Thread Bruno Herrera
This patch adds the USB pins and nodes for USB FS core. Signed-off-by: Bruno Herrera --- arch/arm/boot/dts/stm32f429.dtsi | 31 +++ 1 file changed, 31 insertions(+) diff --git a/arch/arm/boot/dts/stm32f429.dtsi

[PATCH v3 3/5] ARM: dts: stm32: Enable USB FS on stm32f469-disco

2017-01-17 Thread Bruno Herrera
This patch enables USB FS on stm32f469-disco with 5V VBUS enable. Signed-off-by: Bruno Herrera --- arch/arm/boot/dts/stm32f469-disco.dts | 16 1 file changed, 16 insertions(+) diff --git a/arch/arm/boot/dts/stm32f469-disco.dts

[PATCH v3 4/5] ARM: dts: stm32: Enable USB HS in FS mode (embedded phy) on stm32f429-disco

2017-01-17 Thread Bruno Herrera
This patch enables USB HS working in FS mode on stm32f429-disco with 5V VBUS enable. Signed-off-by: Bruno Herrera --- arch/arm/boot/dts/stm32f429-disco.dts | 16 1 file changed, 16 insertions(+) diff --git a/arch/arm/boot/dts/stm32f429-disco.dts

Re: [PATCHv2] dmaengine: cppi41: Fix oops in cppi41_runtime_resume

2017-01-17 Thread Tony Lindgren
* Bin Liu [170117 05:00]: > On Mon, Jan 16, 2017 at 03:54:29PM -0800, Tony Lindgren wrote: > > Anyways, for the -rc series oops, we can just leave out the WARN_ON > > parts for now until drivers/usb/musb/musb_cppi41.c is fixed too. > > Giving that cppi is a submodule inside the usb

[PATCH v3 5/5] dt-bindings: Document the STM32 USB OTG DWC2 core binding

2017-01-17 Thread Bruno Herrera
This patch adds the documentation for STM32F4x9 USB OTG FS/HS compatible strings. Signed-off-by: Bruno Herrera --- Documentation/devicetree/bindings/usb/dwc2.txt | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/usb/dwc2.txt

Re: [PATCH] usb: dwc3: ep0: Fix the possible missed request for handling delay STATUS phase

2017-01-17 Thread Alan Stern
On Mon, 16 Jan 2017, Felipe Balbi wrote: > > The gadget driver never calls usb_ep_queue in order to receive the next > > SETUP packet; the UDC driver takes care of SETUP handling > > automatically. > > yeah, that's another thing I'd like to change. Currently, we have no > means to either try to

Re: [PATCH] usb: core: update comments for send message functions

2017-01-17 Thread Alan Stern
On Tue, 17 Jan 2017, Jaejoong Kim wrote: > The commonly use of a bottom half are tasklet and workqueue. The big > difference between tasklet and workqueue is that the tasklet runs in > an interrupt context and the workqueue runs in a process context, > which means it can sleep if need be. > >

[PATCH] musb fixes for v4.10-rc5

2017-01-17 Thread Bin Liu
Hi Greg, Here is musb fixes for v4.10-rc5, it is to fix a sparse warning. Please let me know if any change is needed. Regards, -Bin. Wei Yongjun (1): usb: musb: dsps: make dsps_musb_clear_ep_rxintr() static drivers/usb/musb/musb_dsps.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH] usb: musb: dsps: make dsps_musb_clear_ep_rxintr() static

2017-01-17 Thread Bin Liu
From: Wei Yongjun Fixes the following sparse warning: drivers/usb/musb/musb_dsps.c:270:6: warning: symbol 'dsps_musb_clear_ep_rxintr' was not declared. Should it be static? Signed-off-by: Wei Yongjun Signed-off-by: Bin Liu ---

Re: [PATCH v3] USB: Add uPD78F0730 USB to Serial Adaptor Driver

2017-01-17 Thread Johan Hovold
On Tue, Jan 17, 2017 at 04:25:18PM +0300, Maksim Salau wrote: > Hi Johan, > > > I think it's right to keep them as in the current version of the patch > > (i.e. active high) which is accordance with the datasheet, but if > > possible you should verify the levels when using hardware flow control >

Re: functionfs on dwc3, xhci host: endpoint cannot be used in both directions ?

2017-01-17 Thread Vincent Pelletier
On Mon, 16 Jan 2017 14:48:31 +, Vincent Pelletier wrote: > 3) I declared 4 endpoints (2 IN, 2 OUT). And I went one level deeper >down the rabbit hole: now enumeration fails with this message on >host: Aaand... I dug this part of the hole myself. In the library

Re: [PATCH] usb: musb: constify dev_pm_ops structures

2017-01-17 Thread Bin Liu
On Sun, Jan 15, 2017 at 05:30:46PM +0530, Bhumika Goyal wrote: > Declare dev_pm_ops structures as const as they are only stored in the pm > field of a device_driver structure. This field is of type const, so > dev_pm_ops structures having similar properties can be declared const > too. > > Size

Re: [PATCH 2/4] musb: sunxi: add support for the variant in H3/V3s SoC

2017-01-17 Thread Bin Liu
On Fri, Jan 06, 2017 at 02:57:15PM +0100, Maxime Ripard wrote: > On Tue, Jan 03, 2017 at 11:25:32PM +0800, Icenowy Zheng wrote: > > Allwinner H3/V3s features a variant of MUSB controller, which lacks one > > endpoint. > > > > Add support for it. > > > > Signed-off-by: Icenowy Zheng

Re: [PATCHv2] usb: musb: Add support for optional VBUS irq to dsps glue layer

2017-01-17 Thread Bin Liu
On Thu, Jan 12, 2017 at 01:40:46PM -0800, Tony Lindgren wrote: > We can now configure the PMIC interrupt to provide us VBUS > events. In that case we don't need to constantly poll the > status and can make it optional. This is only wired up > for the mini-B interface on beaglebone. > > Note that

[PATCH 2/2] tools: usb: ffs-test: add SS descriptors

2017-01-17 Thread Felipe Balbi
Without SS descriptors, we have no possibility of running on SS controllers such as DWC3. Signed-off-by: Felipe Balbi --- tools/usb/ffs-test.c | 50 +- 1 file changed, 49 insertions(+), 1 deletion(-) diff --git

[PATCH 1/2] tools: usb: ffs-test: switch to _DEFAULT_SOURCE

2017-01-17 Thread Felipe Balbi
_BSD_SOURCE is deprecated and gives a build warning. Let's use _DEFAULT_SOURCE instead. Signed-off-by: Felipe Balbi --- tools/usb/ffs-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/usb/ffs-test.c b/tools/usb/ffs-test.c index

Re: [PATCH v3] USB: Add uPD78F0730 USB to Serial Adaptor Driver

2017-01-17 Thread Maksim Salau
Hi Johan, > I think it's right to keep them as in the current version of the patch > (i.e. active high) which is accordance with the datasheet, but if > possible you should verify the levels when using hardware flow control > to be certain that the polarity is not inverted when enabling hardware

usb: gadger: f_fs: Do not copy past descriptor end.

2017-01-17 Thread Vincent Pelletier
Endpoint descriptors come in 2 sizes, struct usb_endpoint_descriptor being the largest. Use bLength to stop on endpoint descriptor boundary, and not 2 bytes too far. Signed-off-by: Vincent Pelletier --- drivers/usb/gadget/function/f_fs.c | 2 +- 1 file changed, 1

[try2] usb: gadger: f_fs: Do not copy past descriptor end.

2017-01-17 Thread Vincent Pelletier
Changes since try1: - do not involve sizeof(*desc) in copy length. - remove explicit cast to size_t, which was needed to compare bLength to sizeof(). -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info

  1   2   >