Re: [PATCH v11 2/8] power: add power sequence library

2017-01-19 Thread Peter Chen
On Tue, Jan 10, 2017 at 03:02:41PM +0800, Peter Chen wrote: > On Sat, Jan 07, 2017 at 10:54:56AM +0200, Krzysztof Kozlowski wrote: > > On Thu, Jan 05, 2017 at 02:01:53PM +0800, Peter Chen wrote: > > > We have an well-known problem that the device needs to do some power > > > sequence before it can

Re: [PATCH 2/2] usb: gadget: uac2: add req_number as parameter

2017-01-19 Thread Peter Chen
On Tue, Jan 17, 2017 at 05:57:50PM +0800, Peter Chen wrote: > On Tue, Jan 17, 2017 at 11:23:55AM +0200, Felipe Balbi wrote: > > > > Hi, > > > > Peter Chen writes: > > > On Mon, Jan 16, 2017 at 12:40:06PM +0200, Felipe Balbi wrote: > > >> > > >> Hi, > > >> > > >> Peter

Re: [PATCH v6 00/25] Support qcom's HSIC USB and rewrite USB2 HS support

2017-01-19 Thread Peter Chen
On Wed, Dec 28, 2016 at 02:56:46PM -0800, Stephen Boyd wrote: > The state of USB ChipIdea support on Qualcomm's platforms is not great. > The DT description of these devices requires up to three different nodes > for what amounts to be the same hardware block, when there should really > only be

[PATCH net] r8152: fix rtl8152_post_reset function

2017-01-19 Thread Hayes Wang
The rtl8152_post_reset() should sumbit rx urb and interrupt transfer, otherwise the rx wouldn't work and the linking change couldn't be detected. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

RE: [PATCH net] r8152: fix the rx doesn't work

2017-01-19 Thread Hayes Wang
> Subject: [PATCH net] r8152: fix the rx doesn't work > > The rtl8152_post_reset() doesn't submit the rx urb, so the rx wouldn't work. > > Signed-off-by: Hayes Wang Excuse me. Please ignore this patch. I would submit another one. -- To unsubscribe from this list: send

[PATCH net] r8152: fix the rx doesn't work

2017-01-19 Thread Hayes Wang
The rtl8152_post_reset() doesn't submit the rx urb, so the rx wouldn't work. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index f3b48ad..e8f4f88 100644 ---

Re: [PATCH v3 5/5] usb: musb: da8xx: Add a primary support of PM runtime

2017-01-19 Thread Sekhar Nori
On Thursday 19 January 2017 10:12 PM, Sergei Shtylyov wrote: > On 01/19/2017 05:08 PM, Alexandre Bailon wrote: > >> Currently, DA8xx doesn't support PM runtime. >> In addition, the glue driver is managing the clock itself. >> But the CPPI DMA needs to manage this clock too. >> Add support to PM

Re: [PATCH v5 0/4] usb: early: add support for early printk through USB3 debug port

2017-01-19 Thread Lu Baolu
Hi Ingo, On 01/19/2017 05:12 PM, Ingo Molnar wrote: > * Lu Baolu wrote: > >> xHCI debug capability (DbC) is an optional but standalone >> functionality provided by an xHCI host controller. With DbC >> hardware initialized, the system will present a debug device >>

Re: [PATCH v5 4/4] usb: doc: add document for USB3 debug port usage

2017-01-19 Thread Lu Baolu
Hi Ingo, On 01/19/2017 05:41 PM, Ingo Molnar wrote: > * Lu Baolu wrote: > >> Add Documentation/usb/usb3-debug-port.rst. This document includes >> the user guide for USB3 debug port. >> >> Cc: linux-...@vger.kernel.org >> Signed-off-by: Lu Baolu

Re: [PATCH v5 3/4] usb: serial: usb_debug: add support for dbc debug device

2017-01-19 Thread Lu Baolu
Hi Ingo, On 01/19/2017 05:39 PM, Ingo Molnar wrote: > * Lu Baolu wrote: > >> This patch add dbc debug device support in usb_debug driver. > s/add dbc debug device support in usb_debug driver > /adds dbc debug device support to the usb_debug driver > > Please fix the

Re: [PATCH v5 2/4] x86: add support for earlyprintk via USB3 debug port

2017-01-19 Thread Lu Baolu
Hi Ingo, On 01/19/2017 05:38 PM, Ingo Molnar wrote: > * Lu Baolu wrote: > >> index 8a12199..c4031b9 100644 >> --- a/arch/x86/kernel/early_printk.c >> +++ b/arch/x86/kernel/early_printk.c >> @@ -17,6 +17,7 @@ >> #include >> #include >> #include >> +#include >>

Re: [PATCH v5 1/4] usb: dbc: early driver for xhci debug capability

2017-01-19 Thread Lu Baolu
Hi Ingo, I'm very appreciated for your review comments. I've put my replies in lines. On 01/19/2017 05:37 PM, Ingo Molnar wrote: > * Lu Baolu wrote: > >> xHCI debug capability (DbC) is an optional but standalone >> functionality provided by an xHCI host controller.

Re: [PATCH 2/6] usb: mtu3: add reference clock

2017-01-19 Thread Chunfeng Yun
On Thu, 2017-01-19 at 13:22 +0100, Matthias Brugger wrote: > > On 18/01/17 07:08, Chunfeng Yun wrote: > > usually, the reference clock comes from 26M oscillator directly, > > but some SoCs are not, add it for compatibility. > > > > Signed-off-by: Chunfeng Yun > > --- >

Re: [PATCH v3 1/5] usb: dwc2: Add support for STM32F429/439/469 USB OTG HS/FS in FS mode (internal PHY)

2017-01-19 Thread John Youn
On 1/17/2017 8:13 AM, Bruno Herrera wrote: > This patch introduces a new parameter to activate USB OTG HS/FS core embedded > phy transceiver. The STM32F4x9 SoC uses the GGPIO register to enable the > transceiver. > Also add the dwc2_core_params structure for stm32f4 otg fs. > > Signed-off-by:

Re: [RFC v2 4/5] DT bindings documentation for Synopsys UDC platform driver

2017-01-19 Thread Florian Fainelli
On 01/19/2017 02:36 PM, Scott Branden wrote: The driver stands alone from the SoC and does not need compatibility strings per SoC. New SoCs will use the exact same block. >>> >>> Even if you take the exact same block and put it in a different SoC, >>> that's still an integration work

Re: [PATCH] usb: dwc3: add quirk to handle DWC_USB3_NUM == DWC_USB3_NUM_IN_EPS

2017-01-19 Thread John Youn
On 1/19/2017 12:17 PM, Felipe Balbi wrote: > > Hi, > > Bryan O'Donoghue writes: >> - DWC_USB3_NUM indicates the number of Device mode single directional >> endpoints, including OUT and IN endpoint 0. >> >> - DWC_USB3_NUM_IN_EPS indicates the maximum number of

Re: [RFC v2 4/5] DT bindings documentation for Synopsys UDC platform driver

2017-01-19 Thread Scott Branden
On 17-01-19 01:55 PM, Ray Jui wrote: On 1/19/2017 12:17 PM, Florian Fainelli wrote: On 01/19/2017 12:07 PM, Scott Branden wrote: Hi Florian, On 17-01-19 11:40 AM, Florian Fainelli wrote: On 01/19/2017 11:30 AM, Scott Branden wrote: Hi Rob, On 17-01-19 09:36 AM, Rob Herring wrote: On

Re: [RFC v2 4/5] DT bindings documentation for Synopsys UDC platform driver

2017-01-19 Thread Ray Jui
On 1/19/2017 12:17 PM, Florian Fainelli wrote: > On 01/19/2017 12:07 PM, Scott Branden wrote: >> Hi Florian, >> >> On 17-01-19 11:40 AM, Florian Fainelli wrote: >>> On 01/19/2017 11:30 AM, Scott Branden wrote: Hi Rob, On 17-01-19 09:36 AM, Rob Herring wrote: > On Tue, Jan 17,

Re: [PATCH] usb: dwc3: add quirk to handle DWC_USB3_NUM == DWC_USB3_NUM_IN_EPS

2017-01-19 Thread Bryan O'Donoghue
Thanks for the quick feedback Felipe, appreciated, I'll take on-board those changes. --- bod -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC v2 4/5] DT bindings documentation for Synopsys UDC platform driver

2017-01-19 Thread Florian Fainelli
On 01/19/2017 12:07 PM, Scott Branden wrote: > Hi Florian, > > On 17-01-19 11:40 AM, Florian Fainelli wrote: >> On 01/19/2017 11:30 AM, Scott Branden wrote: >>> Hi Rob, >>> >>> On 17-01-19 09:36 AM, Rob Herring wrote: On Tue, Jan 17, 2017 at 01:35:07PM +0530, Raviteja Garimella wrote: >

Re: [PATCH] usb: dwc3: add quirk to handle DWC_USB3_NUM == DWC_USB3_NUM_IN_EPS

2017-01-19 Thread Felipe Balbi
Hi, Bryan O'Donoghue writes: > - DWC_USB3_NUM indicates the number of Device mode single directional > endpoints, including OUT and IN endpoint 0. > > - DWC_USB3_NUM_IN_EPS indicates the maximum number of Device mode IN > endpoints active at any time, including

Re: [RFC v2 4/5] DT bindings documentation for Synopsys UDC platform driver

2017-01-19 Thread Scott Branden
Hi Florian, On 17-01-19 11:40 AM, Florian Fainelli wrote: On 01/19/2017 11:30 AM, Scott Branden wrote: Hi Rob, On 17-01-19 09:36 AM, Rob Herring wrote: On Tue, Jan 17, 2017 at 01:35:07PM +0530, Raviteja Garimella wrote: This patch adds device tree bindings documentation for Synopsys USB

Re: [PATCH RFC 0/7] Clean up PHY MMD accessors

2017-01-19 Thread Russell King - ARM Linux
On Thu, Jan 19, 2017 at 11:42:47AM -0800, Florian Fainelli wrote: > On 01/13/2017 07:20 AM, Russell King - ARM Linux wrote: > > This series cleans up phylib's MMD accessors, so that we have a common > > way of accessing the Clause 45 register set. > > > > The current situation is far from ideal -

Re: [PATCH v3 2/3] dmaengine: cppi41: Add support of DA8xx to CPPI 4.1

2017-01-19 Thread Sergei Shtylyov
On 01/19/2017 02:13 PM, Alexandre Bailon wrote: The DA8xx has a CPPI 4.1 DMA controller. This is add the glue layer required to make it work on DA8xx. Signed-off-by: Alexandre Bailon --- drivers/dma/Kconfig | 6 +++--- drivers/dma/cppi41.c | 24

[PATCH] usb: dwc3: add quirk to handle DWC_USB3_NUM == DWC_USB3_NUM_IN_EPS

2017-01-19 Thread Bryan O'Donoghue
- DWC_USB3_NUM indicates the number of Device mode single directional endpoints, including OUT and IN endpoint 0. - DWC_USB3_NUM_IN_EPS indicates the maximum number of Device mode IN endpoints active at any time, including control endpoint 0. It's possible to configure RTL such that

Re: [RFC v2 4/5] DT bindings documentation for Synopsys UDC platform driver

2017-01-19 Thread Florian Fainelli
On 01/19/2017 11:30 AM, Scott Branden wrote: > Hi Rob, > > On 17-01-19 09:36 AM, Rob Herring wrote: >> On Tue, Jan 17, 2017 at 01:35:07PM +0530, Raviteja Garimella wrote: >>> This patch adds device tree bindings documentation for Synopsys >>> USB device controller platform driver. >> >> Bindings

Re: [PATCH RFC 0/7] Clean up PHY MMD accessors

2017-01-19 Thread Florian Fainelli
On 01/13/2017 07:20 AM, Russell King - ARM Linux wrote: > This series cleans up phylib's MMD accessors, so that we have a common > way of accessing the Clause 45 register set. > > The current situation is far from ideal - we have phy_(read|write)_mmd() > which accesses Clause 45 registers over

Re: [RFC v2 4/5] DT bindings documentation for Synopsys UDC platform driver

2017-01-19 Thread Scott Branden
Hi Rob, On 17-01-19 09:36 AM, Rob Herring wrote: On Tue, Jan 17, 2017 at 01:35:07PM +0530, Raviteja Garimella wrote: This patch adds device tree bindings documentation for Synopsys USB device controller platform driver. Bindings describe h/w, not drivers. Signed-off-by: Raviteja Garimella

Re: [RFC v2 1/5] UDC: Split the driver into amd (pci) and Synopsys core driver

2017-01-19 Thread Florian Fainelli
On 01/19/2017 02:44 AM, Raviteja Garimella wrote: > Hi, > > On Thu, Jan 19, 2017 at 12:15 AM, Florian Fainelli > wrote: >> On 01/17/2017 12:05 AM, Raviteja Garimella wrote: >>> This patch splits the amd5536udc driver into two -- one that does >>> pci device registration

Re: [PATCH v3 5/5] dt-bindings: Document the STM32 USB OTG DWC2 core binding

2017-01-19 Thread Rob Herring
On Tue, Jan 17, 2017 at 02:12:37PM -0200, Bruno Herrera wrote: > This patch adds the documentation for STM32F4x9 USB OTG FS/HS compatible > strings. > > Signed-off-by: Bruno Herrera > --- > Documentation/devicetree/bindings/usb/dwc2.txt | 4 > 1 file changed, 4

Re: [PATCH resend v5 0/4] xhci fixes for usb-linus

2017-01-19 Thread Greg KH
On Thu, Jan 19, 2017 at 02:21:26PM +0200, Mathias Nyman wrote: > Hi Greg > > This series by Arnd Bergmann was originally six patches, but last two of > them were already taken to 4.10. Without the rest of them there will > be a regression in 4.10. Is it really a regression? I thought this had

[PATCH 2/4] usb: gadget: f_hid: fix: Prevent accessing released memory

2017-01-19 Thread Krzysztof Opasiak
When we unlock our spinlock to copy data to user we may get disabled by USB host and free the whole list of completed out requests including the one from which we are copying the data to user memory. To prevent from this let's remove our working element from the list and place it back only if

[PATCH 3/4] usb: gadget: f_hid: Use spinlock instead of mutex

2017-01-19 Thread Krzysztof Opasiak
As IN request has to be allocated in set_alt() and released in disable() we cannot use mutex to protect it as we cannot sleep in those funcitons. Let's replace this mutex with a spinlock. Cc: sta...@vger.kernel.org Signed-off-by: Krzysztof Opasiak ---

[PATCH 4/4] usb: gadget: f_hid: fix: Move IN request allocation to set_alt()

2017-01-19 Thread Krzysztof Opasiak
Since commit ba1582f22231 ("usb: gadget: f_hid: use alloc_ep_req()") we cannot allocate any requests in bind() as we check if we should align request buffer based on endpoint descriptor which is assigned in set_alt(). Allocating request in bind() function causes a NULL pointer dereference. This

[PATCH 1/4] usb: gadget: f_hid: fix: Free out requests

2017-01-19 Thread Krzysztof Opasiak
Requests for out endpoint are allocated in bind() function but never released. This commit ensures that all pending requests are released when we disable out endpoint. Fixes: 99c515005857 ("usb: gadget: hidg: register OUT INT endpoint for SET_REPORT") Cc: sta...@vger.kernel.org Signed-off-by:

Re: [PATCH 2/2] usb: musb: Size 1 dma in transfers won't complete with cpp41

2017-01-19 Thread Bin Liu
On Thu, Jan 19, 2017 at 07:04:57AM -0800, Tony Lindgren wrote: > * Bin Liu [170118 19:42]: > > On Wed, Jan 18, 2017 at 06:29:59PM -0800, Tony Lindgren wrote: > > > At least with the cppi41 dma, size 1 in dma transfers will just wait > > > > In which case do you see the size 1

Re: [PATCH] arm: davinci: Make the usb20 clock available to PM runtime

2017-01-19 Thread Alexandre Bailon
On 01/19/2017 05:49 PM, Grygorii Strashko wrote: > On 01/19/2017 09:08 AM, Alexandre Bailon wrote: >> On 01/19/2017 03:48 PM, Sekhar Nori wrote: >>> On Thursday 19 January 2017 07:39 PM, Alexandre Bailon wrote: Add usb20 to the list of clock supported by PM runtime. Signed-off-by:

Re: [RFC v2 4/5] DT bindings documentation for Synopsys UDC platform driver

2017-01-19 Thread Rob Herring
On Tue, Jan 17, 2017 at 01:35:07PM +0530, Raviteja Garimella wrote: > This patch adds device tree bindings documentation for Synopsys > USB device controller platform driver. Bindings describe h/w, not drivers. > > Signed-off-by: Raviteja Garimella > --- >

Re: [PATCH 2/2] usb: musb: Size 1 dma in transfers won't complete with cpp41

2017-01-19 Thread Bin Liu
On Thu, Jan 19, 2017 at 08:15:45AM -0800, Tony Lindgren wrote: > * Tony Lindgren [170119 07:57]: > > * Bin Liu [170119 07:14]: > > > On Thu, Jan 19, 2017 at 07:04:57AM -0800, Tony Lindgren wrote: > > > > * Bin Liu [170118 19:42]: > > > > > On Wed,

Re: [PATCH] tools: usb usbip - update README USB/IP driver location

2017-01-19 Thread Shuah Khan
On 01/19/2017 07:15 AM, Shuah Khan wrote: > On 01/19/2017 02:35 AM, Greg KH wrote: >> On Fri, Jan 13, 2017 at 04:38:32PM -0700, Shuah Khan wrote: >>> Update USB/IP driver location in README. >>> >>> Signed-off-by: Shuah Khan >>> Reviewed-by: Krzysztof Opasiak

Re: [PATCH 2/2] usb: musb: Size 1 dma in transfers won't complete with cpp41

2017-01-19 Thread Tony Lindgren
* Bin Liu [170119 09:16]: > On Thu, Jan 19, 2017 at 08:15:45AM -0800, Tony Lindgren wrote: > > * Tony Lindgren [170119 07:57]: > > > * Bin Liu [170119 07:14]: > > > > On Thu, Jan 19, 2017 at 07:04:57AM -0800, Tony Lindgren wrote: > > > > > * Bin Liu

[PATCH 2/2] dmaengine: cppi41: Fix oops in cppi41_runtime_resume

2017-01-19 Thread Tony Lindgren
Commit fdea2d09b997 ("dmaengine: cppi41: Add basic PM runtime support") together with recent MUSB changes allowed USB and DMA on BeagleBone to idle when no cable is connected. But looks like few corner case issues still remain. Looks like just by re-plugging USB cable about ten or so times on

Re: [PATCH v3 0/4] dmaengine: cppi41: Make CPPI 4.1 driver more generic

2017-01-19 Thread Tony Lindgren
* Alexandre Bailon [170119 02:38]: > - Make CPPI 4.1 driver compatible with old and new binddings. Thanks for fixing that, that removes a dependency with the dts changes. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of

[PATCHv4 0/2] cppi41 dma fixes for v4.10-rc cycle

2017-01-19 Thread Tony Lindgren
Hi all, I'm using v4 naming here as the earlier patch "dmaengine: cppi41: Add dma support to da8xx" has been separated from the error -115 issue. We've identified so far three musb and cppi41 regressions: 1. Error -71 regression with musb This is not dma related, and fixed with recently

Re: [PATCH v3 4/5] usb: musb: musb_cppi41: Workaround DMA stall issue during teardown

2017-01-19 Thread Tony Lindgren
* Alexandre Bailon [170119 06:09]: > The DMA may hung up if a teardown is initiated while an endpoint is still > active (Advisory 2.3.27 of DA8xx errata). > To workaround this issue, add a delay before to initiate the teardown. > > Signed-off-by: Alexandre Bailon

[PATCH 1/2] dmaengine: cppi41: Fix runtime PM timeouts with USB mass storage

2017-01-19 Thread Tony Lindgren
Commit fdea2d09b997 ("dmaengine: cppi41: Add basic PM runtime support") added runtime PM support for cppi41, but had corner case issues. Some of the issues were fixed with commit 098de42ad670 ("dmaengine: cppi41: Fix unpaired pm runtime when only a USB hub is connected"). That fix however caused a

Re: [PATCH] arm: davinci: Make the usb20 clock available to PM runtime

2017-01-19 Thread Grygorii Strashko
On 01/19/2017 09:08 AM, Alexandre Bailon wrote: > On 01/19/2017 03:48 PM, Sekhar Nori wrote: >> On Thursday 19 January 2017 07:39 PM, Alexandre Bailon wrote: >>> Add usb20 to the list of clock supported by PM runtime. >>> >>> Signed-off-by: Alexandre Bailon >>> --- >>>

Re: [PATCH 2/2] usb: musb: Size 1 dma in transfers won't complete with cpp41

2017-01-19 Thread Tony Lindgren
* Tony Lindgren [170119 07:57]: > * Bin Liu [170119 07:14]: > > On Thu, Jan 19, 2017 at 07:04:57AM -0800, Tony Lindgren wrote: > > > * Bin Liu [170118 19:42]: > > > > On Wed, Jan 18, 2017 at 06:29:59PM -0800, Tony Lindgren wrote: > > > > > At least

Re: [PATCH v3 5/5] usb: musb: da8xx: Add a primary support of PM runtime

2017-01-19 Thread Sergei Shtylyov
On 01/19/2017 05:08 PM, Alexandre Bailon wrote: Currently, DA8xx doesn't support PM runtime. In addition, the glue driver is managing the clock itself. But the CPPI DMA needs to manage this clock too. Add support to PM runtime and use the callback to enable / disable the clock. I think

Re: [PATCH v3 3/5] usb: musb: Add support of CPPI 4.1 DMA controller to DA8xx

2017-01-19 Thread Sergei Shtylyov
On 01/19/2017 05:08 PM, Alexandre Bailon wrote: Currently, only the PIO mode is supported. This add support of CPPI 4.1 to DA8xx. As the In DA8xx the CPPI 4.1 DMA is a part of the USB. Create the CPPI 4.1 device as a child of USB. Signed-off-by: Alexandre Bailon ---

Re: [PATCH v3] USB: Add uPD78F0730 USB to Serial Adaptor Driver

2017-01-19 Thread Maksim Salau
Hi Johan, > And keep the current modem-control-signal polarity. What are the levels > of these signals when coming out of reset (i.e. after having connected > the device, but not opened it yet)? Thanks. RTS is low (0V) after plugging the device in. Regards, Maksim. -- To unsubscribe from this

Re: [PATCH v3 3/5] usb: musb: Add support of CPPI 4.1 DMA controller to DA8xx

2017-01-19 Thread Alexandre Bailon
On 01/19/2017 03:08 PM, Alexandre Bailon wrote: > Currently, only the PIO mode is supported. > This add support of CPPI 4.1 to DA8xx. > As the In DA8xx the CPPI 4.1 DMA is a part of the USB. > Create the CPPI 4.1 device as a child of USB. > > Signed-off-by: Alexandre Bailon

Re: [PATCH 2/2] usb: musb: Size 1 dma in transfers won't complete with cpp41

2017-01-19 Thread Tony Lindgren
* Bin Liu [170119 07:14]: > On Thu, Jan 19, 2017 at 07:04:57AM -0800, Tony Lindgren wrote: > > * Bin Liu [170118 19:42]: > > > On Wed, Jan 18, 2017 at 06:29:59PM -0800, Tony Lindgren wrote: > > > > At least with the cppi41 dma, size 1 in dma transfers will just wait >

Re: [PATCH v11 08/14] usb: otg: add OTG/dual-role core

2017-01-19 Thread vivek . gautam
Hi Roger, On 2017-01-19 17:45, Roger Quadros wrote: Vivek, On 19/01/17 13:56, Vivek Gautam wrote: Hi, On Wed, Jun 22, 2016 at 2:00 PM, Roger Quadros wrote: Luckily hit this thread while checking about DRD role functionality for DWC3. On 22/06/16 11:14, Felipe Balbi

Re: [PATCH] arm: davinci: Make the usb20 clock available to PM runtime

2017-01-19 Thread Alexandre Bailon
On 01/19/2017 03:48 PM, Sekhar Nori wrote: > On Thursday 19 January 2017 07:39 PM, Alexandre Bailon wrote: >> Add usb20 to the list of clock supported by PM runtime. >> >> Signed-off-by: Alexandre Bailon >> --- >> arch/arm/mach-davinci/pm_domain.c | 2 +- >> 1 file changed,

Re: [PATCH 2/2] usb: musb: Size 1 dma in transfers won't complete with cpp41

2017-01-19 Thread Tony Lindgren
* Bin Liu [170118 19:42]: > On Wed, Jan 18, 2017 at 06:29:59PM -0800, Tony Lindgren wrote: > > At least with the cppi41 dma, size 1 in dma transfers will just wait > > In which case do you see the size 1 transfer? using testusb? > > > until the device is disconnected. This causes

Re: [PATCH 1/4] phy: sun4i-usb: support PHY0 on H3 in MUSB mode

2017-01-19 Thread Maxime Ripard
On Wed, Jan 18, 2017 at 04:09:32AM +0800, Chen-Yu Tsai wrote: > Hi, > > On Wed, Jan 18, 2017 at 4:06 AM, Maxime Ripard > wrote: > > On Wed, Jan 18, 2017 at 12:57:08AM +0800, Icenowy Zheng wrote: > >> > >> > >> 17.01.2017, 16:06, "Maxime Ripard"

Re: [PATCH] arm: davinci: Make the usb20 clock available to PM runtime

2017-01-19 Thread Sekhar Nori
On Thursday 19 January 2017 07:39 PM, Alexandre Bailon wrote: > Add usb20 to the list of clock supported by PM runtime. > > Signed-off-by: Alexandre Bailon > --- > arch/arm/mach-davinci/pm_domain.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH] tools: usb usbip - update README USB/IP driver location

2017-01-19 Thread Shuah Khan
On 01/19/2017 02:35 AM, Greg KH wrote: > On Fri, Jan 13, 2017 at 04:38:32PM -0700, Shuah Khan wrote: >> Update USB/IP driver location in README. >> >> Signed-off-by: Shuah Khan >> Reviewed-by: Krzysztof Opasiak >> --- >> tools/usb/usbip/README | 2

Re: [PATCH v11 08/14] usb: otg: add OTG/dual-role core

2017-01-19 Thread Roger Quadros
Vivek, On 19/01/17 13:56, Vivek Gautam wrote: > Hi, > > > On Wed, Jun 22, 2016 at 2:00 PM, Roger Quadros wrote: > > Luckily hit this thread while checking about DRD role functionality for DWC3. > >> On 22/06/16 11:14, Felipe Balbi wrote: >>> >>> Hi, >>> >>> Roger Quadros

[PATCH] ARM: dts: da850: Add the CPPI 4.1 DMA to the USB OTG controller

2017-01-19 Thread Alexandre Bailon
This adds the CPPI 4.1 DMA controller to the USB OTG controller. Changes since v2: - Fixed the the property reg-names (had glue register defined) - Removed few useless property Signed-off-by: Alexandre Bailon --- arch/arm/boot/dts/da850.dtsi | 25 +

[PATCH v3 5/5] usb: musb: da8xx: Add a primary support of PM runtime

2017-01-19 Thread Alexandre Bailon
Currently, DA8xx doesn't support PM runtime. In addition, the glue driver is managing the clock itself. But the CPPI DMA needs to manage this clock too. Add support to PM runtime and use the callback to enable / disable the clock. And because the CPPI 4.1 is a child of Da8xx USB, it will be able

[PATCH] arm: davinci: Make the usb20 clock available to PM runtime

2017-01-19 Thread Alexandre Bailon
Add usb20 to the list of clock supported by PM runtime. Signed-off-by: Alexandre Bailon --- arch/arm/mach-davinci/pm_domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-davinci/pm_domain.c b/arch/arm/mach-davinci/pm_domain.c index

[PATCH v3 4/5] usb: musb: musb_cppi41: Workaround DMA stall issue during teardown

2017-01-19 Thread Alexandre Bailon
The DMA may hung up if a teardown is initiated while an endpoint is still active (Advisory 2.3.27 of DA8xx errata). To workaround this issue, add a delay before to initiate the teardown. Signed-off-by: Alexandre Bailon --- drivers/usb/musb/da8xx.c | 2 +-

[PATCH v3 2/5] usb: musb: Use shared irq

2017-01-19 Thread Alexandre Bailon
In the DA8xx, USB and CPPI 4.1 are sharing the same interrupt line. Update the driver to request a shared irq. Signed-off-by: Alexandre Bailon --- drivers/usb/musb/musb_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/musb/musb_core.c

[PATCH v3 3/5] usb: musb: Add support of CPPI 4.1 DMA controller to DA8xx

2017-01-19 Thread Alexandre Bailon
Currently, only the PIO mode is supported. This add support of CPPI 4.1 to DA8xx. As the In DA8xx the CPPI 4.1 DMA is a part of the USB. Create the CPPI 4.1 device as a child of USB. Signed-off-by: Alexandre Bailon --- drivers/usb/musb/Kconfig | 4 ++--

[PATCH v3 0/5] usb: musb: da8xx: Add DMA support

2017-01-19 Thread Alexandre Bailon
This series update MUSB driver to add DMA support to DA8xx. It should be applied on top of "[PATCH v3 0/3] usb: musb: cppi41: Add a way to manage DMA irq" but "[PATCH v3 0/3] dmaengine: cppi41: Add dma support to da8xx" and "[PATCH] arm: davinci: Make the usb20 clock available to PM runtime" are

[PATCH v3 1/5] usb: musb: da8xx: Remove CPPI 3.0 quirk and methods

2017-01-19 Thread Alexandre Bailon
DA8xx driver is registering and using the CPPI 3.0 DMA controller but actually, the DA8xx has a CPPI 4.1 DMA controller. Remove the CPPI 3.0 quirk and methods. Fixes: f8e9f34f80a2 ("usb: musb: Fix up DMA related macros") Fixes: 7f6283ed6fe8 ("usb: musb: Set up function pointers for DMA")

Re: [PATCH v2] Documentation: usb: fix wrong documentation paths

2017-01-19 Thread Rob Herring
On Sun, Jan 15, 2017 at 01:14:28PM +0100, Yegor Yefremov wrote: > Fixes wrong spelled "pinctrl-bindings.txt" and "qcom-dwc3-usb-phy.txt" > file names as also wrong specified "mt8173-mtu3.txt" file name. > > Signed-off-by: Yegor Yefremov > --- > Changes: > v1 ->

Re: [PATCH 4/6] arm64: dts: mt8173: add reference clock for usb

2017-01-19 Thread Matthias Brugger
On 19/01/17 10:37, Greg Kroah-Hartman wrote: On Wed, Jan 18, 2017 at 02:08:25PM +0800, Chunfeng Yun wrote: add 26M reference clock for ssusb and xhci nodes Signed-off-by: Chunfeng Yun --- arch/arm64/boot/dts/mediatek/mt8173.dtsi |6 -- 1 file changed, 4

Re: [PATCH 2/6] usb: mtu3: add reference clock

2017-01-19 Thread Matthias Brugger
On 18/01/17 07:08, Chunfeng Yun wrote: usually, the reference clock comes from 26M oscillator directly, but some SoCs are not, add it for compatibility. Signed-off-by: Chunfeng Yun --- drivers/usb/mtu3/mtu3.h |1 + drivers/usb/mtu3/mtu3_plat.c | 21

[PATCH resend v5 3/4] usb: ehci: fsl: use bus->sysdev for DMA configuration

2017-01-19 Thread Mathias Nyman
From: Arnd Bergmann For the dual role ehci fsl driver, sysdev will handle the dma config. Signed-off-by: Arnd Bergmann Signed-off-by: Sriram Dash Signed-off-by: Mathias Nyman --- drivers/usb/host/ehci-fsl.c |

[PATCH resend v5 4/4] usb: xhci: use bus->sysdev for DMA configuration

2017-01-19 Thread Mathias Nyman
From: Arnd Bergmann For xhci-hcd platform device, all the DMA parameters are not configured properly, notably dma ops for dwc3 devices. So, set the dma for xhci from sysdev. sysdev is pointing to device that is known to the system firmware or hardware. Signed-off-by: Arnd

[PATCH resend v5 2/4] usb: chipidea: use bus->sysdev for DMA configuration

2017-01-19 Thread Mathias Nyman
From: Arnd Bergmann Set the dma for chipidea from sysdev. This is inherited from its parent node. Also, do not set dma mask for child as it is not required now. Signed-off-by: Arnd Bergmann Signed-off-by: Sriram Dash Acked-by: Peter Chen

[PATCH resend v5 0/4] xhci fixes for usb-linus

2017-01-19 Thread Mathias Nyman
Hi Greg This series by Arnd Bergmann was originally six patches, but last two of them were already taken to 4.10. Without the rest of them there will be a regression in 4.10. Original cover letter says: For xhci-hcd platform device, all the DMA parameters are not configured properly, notably

[PATCH resend v5 1/4] usb: separate out sysdev pointer from usb_bus

2017-01-19 Thread Mathias Nyman
From: Arnd Bergmann For xhci-hcd platform device, all the DMA parameters are not configured properly, notably dma ops for dwc3 devices. The idea here is that you pass in the parent of_node along with the child device pointer, so it would behave exactly like the parent already

Re: dwc3 gadget breaks on system suspend/resume

2017-01-19 Thread Roger Quadros
On 19/01/17 13:59, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: >> Hi Felipe, >> >> We have system suspend resume working on dra7-evm in v4.10-rc but >> dwc3 gadget breaks after system suspend resume. >> >> Any hints how to fix it? Full backtrace below. > > from a quick

Re: dwc3 gadget breaks on system suspend/resume

2017-01-19 Thread Felipe Balbi
Hi, Roger Quadros writes: > Hi Felipe, > > We have system suspend resume working on dra7-evm in v4.10-rc but > dwc3 gadget breaks after system suspend resume. > > Any hints how to fix it? Full backtrace below. from a quick look. END_TRANSFER is timing out, most likely.

Re: [PATCH v11 08/14] usb: otg: add OTG/dual-role core

2017-01-19 Thread Vivek Gautam
Hi, On Wed, Jun 22, 2016 at 2:00 PM, Roger Quadros wrote: Luckily hit this thread while checking about DRD role functionality for DWC3. > On 22/06/16 11:14, Felipe Balbi wrote: >> >> Hi, >> >> Roger Quadros writes: >>> For the real use case, some Carplay

dwc3 gadget breaks on system suspend/resume

2017-01-19 Thread Roger Quadros
Hi Felipe, We have system suspend resume working on dra7-evm in v4.10-rc but dwc3 gadget breaks after system suspend resume. Any hints how to fix it? Full backtrace below. Another message that looks worry-some is "[ 61.495313] omap-dwc3 4888.omap_dwc3_1: runtime PM trying to suspend

[PATCH] usb: dwc3: gadget: skip Set/Clear Halt when invalid

2017-01-19 Thread Felipe Balbi
At least macOS seems to be sending ClearFeature(ENDPOINT_HALT) to endpoints which aren't Halted. This makes DWC3's CLEARSTALL command time out which causes several issues for the driver. Instead, let's just return 0 and bail out early. Cc: Signed-off-by: Felipe Balbi

Re: [PATCH v5 4/6] usb: xhci: use bus->sysdev for DMA configuration

2017-01-19 Thread Mathias Nyman
On 19.01.2017 11:22, Greg KH wrote: On Wed, Jan 18, 2017 at 01:58:28PM +0200, Mathias Nyman wrote: On 12.01.2017 10:38, Roger Quadros wrote: Mathias, On 11/01/17 17:08, Alan Stern wrote: On Wed, 11 Jan 2017, Mathias Nyman wrote: On 17.11.2016 13:43, Sriram Dash wrote: From: Arnd Bergmann

Re: [PATCH v5 3/4] usb: serial: usb_debug: add support for dbc debug device

2017-01-19 Thread Ingo Molnar
* Lu Baolu wrote: > This patch add dbc debug device support in usb_debug driver. s/add dbc debug device support in usb_debug driver /adds dbc debug device support to the usb_debug driver Please fix the title as well. Thanks, Ingo -- To unsubscribe from

Re: [PATCH v5 0/4] usb: early: add support for early printk through USB3 debug port

2017-01-19 Thread Mathias Nyman
On 19.01.2017 11:09, Ingo Molnar wrote: * Greg Kroah-Hartman wrote: On Wed, Jan 18, 2017 at 02:20:30PM +0800, Lu Baolu wrote: Hi Greg, This patch series has been there for 2 months without further comments. Will you consider it for usb-next? I needed acks from

[PATCH v3 2/3] dmaengine: cppi41: Add support of DA8xx to CPPI 4.1

2017-01-19 Thread Alexandre Bailon
The DA8xx has a CPPI 4.1 DMA controller. This is add the glue layer required to make it work on DA8xx. Signed-off-by: Alexandre Bailon --- drivers/dma/Kconfig | 6 +++--- drivers/dma/cppi41.c | 24 2 files changed, 27 insertions(+), 3

[PATCH v3 0/3] dmaengine: cppi41: Add dma support to da8xx

2017-01-19 Thread Alexandre Bailon
This series add support of DA8xx to CPPI 4.1 driver. As the CPPI 4.1 is now generic, we only had to add the glue for DA8xx. This serie should applied on top of "[PATCH v3 0/4] dmaengine: cppi41: Make CPPI 4.1 driver more generic". Changes in v3: - Removed some useless property from DT bindings.

[PATCH v3 3/3] dmaengine: cppi41: Fix teardown warnings

2017-01-19 Thread Alexandre Bailon
During the teardown of a RX channel, because there is only one completion queue available for RX channel, descriptor of another channel may be popped which will cause 2 warnings: - the first one because we popped a wrong descriptor (neither the channel's descriptor, nor the teardown descriptor).

[PATCH v3 1/3] dt/bindings: da8xx-usb: Add binding for the CPPI 4.1 DMA controller

2017-01-19 Thread Alexandre Bailon
DT binding for the TI DA8xx/OMAP-L1x/AM17xx/AM18xx CPPI 4.1 DMA controller. Signed-off-by: Alexandre Bailon --- .../devicetree/bindings/usb/da8xx-usb.txt | 39 ++ 1 file changed, 39 insertions(+) diff --git

Re: [PATCH v3 4/4] dmaengine: cppi41: init_sched(): Get number of channels from DT

2017-01-19 Thread Sergei Shtylyov
On 1/19/2017 1:37 PM, Alexandre Bailon wrote: Despite the driver is already using DT to get the number of channels, init_sched() is using an hardcoded value to get it. Use DT to get the number of channels. Signed-off-by: Alexandre Bailon --- drivers/dma/cppi41.c | 26

Re: [RFC v2 1/5] UDC: Split the driver into amd (pci) and Synopsys core driver

2017-01-19 Thread Raviteja Garimella
Hi, On Thu, Jan 19, 2017 at 12:15 AM, Florian Fainelli wrote: > On 01/17/2017 12:05 AM, Raviteja Garimella wrote: >> This patch splits the amd5536udc driver into two -- one that does >> pci device registration and the other file that does the rest of >> the driver tasks

Re: [PATCH v3 1/3] usb: musb: dma: Add a DMA completion platform callback

2017-01-19 Thread Sergei Shtylyov
Hello! On 1/19/2017 1:06 PM, Alexandre Bailon wrote: Currently, the CPPI 4.1 driver is not completely generic and only work on dsps. This is because of IRQ management. Works. DSPS. Add a callback to dma_controller that could be invoked on DMA completion to acknodlege the IRQ.

[PATCH v3 1/4] dmaengine: cppi41: Remove usbss_mem

2017-01-19 Thread Alexandre Bailon
In order to make CPPI 4.1 DMA driver more generic, accesses to USBSS have been removed. So it is not required anymore to map the "glue" register's. Remove usbss_mem. Signed-off-by: Alexandre Bailon --- drivers/dma/cppi41.c | 18 ++ 1 file changed, 10

[PATCH v3 0/4] dmaengine: cppi41: Make CPPI 4.1 driver more generic

2017-01-19 Thread Alexandre Bailon
Most of the patch of this series were part of "[PATCH 00/11] dmaengine: cppi41: Add dma support to da8xx" This series intend to make the CPPI 4.1 more generic in order to add a new platform (the DA8xx). To achieve that, all the IRQ code present in CPPI 4.1 driver has been moved to MUSB DSPS

[PATCH v3 2/4] dmaengine: cppi41: rename platform variables

2017-01-19 Thread Alexandre Bailon
Currently, only the AM335x is supported by the driver. Though the driver has a glue layer to support different platforms, some platform variable names are not prefixed with the platform name. To facilitate the addition of a new platform, rename some variables owned by the AM335x glue.

[PATCH v3 3/4] dmaengine: cppi41: Move some constants to glue layer

2017-01-19 Thread Alexandre Bailon
Some constants are defined and use by the driver whereas they are specifics to AM335x. Add new variables to the glue layer, initialize them with the constants, and use them in the driver. Signed-off-by: Alexandre Bailon --- drivers/dma/cppi41.c | 20 ++-- 1

[PATCH v3 4/4] dmaengine: cppi41: init_sched(): Get number of channels from DT

2017-01-19 Thread Alexandre Bailon
Despite the driver is already using DT to get the number of channels, init_sched() is using an hardcoded value to get it. Use DT to get the number of channels. Signed-off-by: Alexandre Bailon --- drivers/dma/cppi41.c | 26 +++--- 1 file changed, 15

Re: [PATCH v5 0/4] usb: early: add support for early printk through USB3 debug port

2017-01-19 Thread Ingo Molnar
* Greg Kroah-Hartman wrote: > On Wed, Jan 18, 2017 at 02:20:30PM +0800, Lu Baolu wrote: > > Hi Greg, > > > > This patch series has been there for 2 months without > > further comments. Will you consider it for usb-next? > > I needed acks from the x86 maintainers

[PATCH v3 2/3] usb: musb: cppi41: Detect aborted transfers in cppi41_dma_callback()

2017-01-19 Thread Alexandre Bailon
Update cppi41_dma_callback() to detect an aborted transfer. This was not required before because cppi41_dma_callback() was only invoked on transfer completion. In order to make CPPI 4.1 driver more generic, cppi41_dma_callback() will be invoked after a transfer abort in order to let the MUSB

[PATCH v3 3/3] usb: musb: dsps: Manage CPPI 4.1 DMA interrupt in dsps

2017-01-19 Thread Alexandre Bailon
Despite the CPPI 4.1 is a generic DMA, it is tied to USB. On the dsps, CPPI 4.1 interrupt's registers are in USBSS (the MUSB glue). Currently, to enable / disable and clear interrupts, the CPPI 4.1 driver maps and accesses to USBSS's register, which making CPPI 4.1 driver not really generic. Move

[PATCH v3 1/3] usb: musb: dma: Add a DMA completion platform callback

2017-01-19 Thread Alexandre Bailon
Currently, the CPPI 4.1 driver is not completely generic and only work on dsps. This is because of IRQ management. Add a callback to dma_controller that could be invoked on DMA completion to acknodlege the IRQ. Signed-off-by: Alexandre Bailon ---

  1   2   >