Re: [PATCH v3 1/3] lib/string: introduce ascii2utf16le() helper

2017-02-08 Thread Richard Leitner
On 02/06/2017 05:48 PM, Sergei Shtylyov wrote: > Hello! > > On 02/06/2017 05:03 PM, Richard Leitner wrote: > >> For USB string descriptors we need to convert ASCII strings to UTF16-LE. >> Therefore make a simple helper function (based on ascii2desc from >> drivers/usb/core/hcd.c) for that purpose

[PATCH v4] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

2017-02-08 Thread Richard Leitner
From: Richard Leitner This patch adds a driver for configuration of the Microchip USB251xB/xBi USB 2.0 hub controller series with USB 2.0 upstream connectivity, SMBus configuration interface and two to four USB 2.0 downstream ports. Furthermore add myself as a maintainer for this driver. The da

Re: [PATCH v4] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

2017-02-08 Thread Richard Leitner
On 02/08/2017 09:52 AM, Richard Leitner wrote: > From: Richard Leitner Please drop/ignore that "From". This patch is from: Richard Leitner > > This patch adds a driver for configuration of the Microchip USB251xB/xBi > USB 2.0 hub controller series with USB 2.0 upstream connectivity, SM

Re: [PATCH 1/2] drivers: usb: gadget: udc: add missing break in switch

2017-02-08 Thread Felipe Balbi
Hi, "Gustavo A. R. Silva" writes: > Add missing break in switch. > > Addresses-Coverity-ID: 201385 > Signed-off-by: Gustavo A. R. Silva > --- > drivers/usb/gadget/udc/mv_udc_core.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/gadget/udc/mv_udc_core.c > b/drivers/usb/ga

Re: [PATCH v3 1/2] sierra_net: Add support for IPv6 and Dual-Stack Link Sense Indications

2017-02-08 Thread Bjørn Mork
Stefan Brüns writes: > If a context is configured as dualstack ("IPv4v6"), the modem indicates > the context activation with a slightly different indication message. > The dual-stack indication omits the link_type (IPv4/v6) and adds > additional address fields. Great! > IPv6 LSIs are identical

[PATCH 1/1] xhci: add USB2 test mode support

2017-02-08 Thread Alexander Stein
This patch adds support for USB2 test mode (Test_J, Test_K, Test_SE0_NAK and Test_Packet) per XHCI spec 4.19.6. Signed-off-by: "Wang, Yu" Signed-off-by: "Li, Guanglei" Signed-off-by: "Wu, Hao" Signed-off-by: Alexander Stein --- This patch was taken from https://github.com/01org/ProductionKern

Re: [PATCH 1/2] drivers: usb: gadget: udc: add missing break in switch

2017-02-08 Thread Gustavo A. R. Silva
Hello Felipe, Quoting Felipe Balbi : Hi, "Gustavo A. R. Silva" writes: Add missing break in switch. Addresses-Coverity-ID: 201385 Signed-off-by: Gustavo A. R. Silva --- drivers/usb/gadget/udc/mv_udc_core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/gadget/udc/mv_udc_c

Periodic reconnects of USB mouse on Dell PowerEdge R730

2017-02-08 Thread Paul Menzel
Dear Linux folks, On the server Dell PowerEdge R730 with firmware 2.3.4, and Linux 4.9.2, the connected USB mouse disconnects and connects again periodically. This can be reproduced with two different (Logitech) mice. ``` $ more /proc/version Linux version 4.9.0-1-amd64 (debian-ker...@lists.

Re: [PATCH v12 6/9] usb: xhci: use bus->sysdev for DMA configuration

2017-02-08 Thread Vivek Gautam
Hi, On Mon, Feb 6, 2017 at 2:43 PM, Peter Chen wrote: > From: Arnd Bergmann > > For xhci-hcd platform device, all the DMA parameters are not > configured properly, notably dma ops for dwc3 devices. So, set > the dma for xhci from sysdev. sysdev is pointing to device that > is known to the syste

Re: USB SUBSYSTEM - drivers/usb/core/config.c

2017-02-08 Thread John Skelton
> From: "Alan Stern" > On Tue, 7 Feb 2017, John Skelton wrote: > > > What happens after that? Does the cdc-acm driver refuse to bind? Any > > > other types of error/warning messages? > > > Along the lines of: > > usb 2-1.2: >new low-speed USB device number 95 using ehci_hcd > > usb 2-1.2: >device

RE: net2280 Driver Bug

2017-02-08 Thread Raz Manor
-Original Message- From: Felipe Balbi [mailto:ba...@kernel.org] Sent: Monday, February 6, 2017 10:26 AM To: Raz Manor ; Greg Kroah-Hartman Cc: Alan Stern ; Linus Torvalds ; USB list ; Tim Harvey ; Heikki Krogerus ; Jussi Kivilinna ; Colin Ian King Subject: RE: net2280 Driver Bug

Re: [PATCH 1/1] xhci: add USB2 test mode support

2017-02-08 Thread Greg Kroah-Hartman
On Wed, Feb 08, 2017 at 11:26:35AM +0100, Alexander Stein wrote: > This patch adds support for USB2 test mode (Test_J, Test_K, > Test_SE0_NAK and Test_Packet) per XHCI spec 4.19.6. What does that mean "in English"? In other words, why do we want this? What does it provide for a user? Why do we c

Re: Periodic reconnects of USB mouse on Dell PowerEdge R730

2017-02-08 Thread Greg KH
On Wed, Feb 08, 2017 at 12:16:44PM +0100, Paul Menzel wrote: > Dear Linux folks, > > > On the server Dell PowerEdge R730 with firmware 2.3.4, and Linux 4.9.2, the > connected USB mouse disconnects and connects again periodically. This can be > reproduced with two different (Logitech) mice. > > `

Re: [PATCH v4] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

2017-02-08 Thread Greg KH
On Wed, Feb 08, 2017 at 09:58:48AM +0100, Richard Leitner wrote: > On 02/08/2017 09:52 AM, Richard Leitner wrote: > > From: Richard Leitner > > Please drop/ignore that "From". This patch is from: > Richard Leitner v5? :) -- To unsubscribe from this list: send the line "unsubscribe linux-

Re: [PATCH 1/2] drivers: usb: gadget: udc: add missing break in switch

2017-02-08 Thread Greg KH
On Wed, Feb 08, 2017 at 02:05:35PM +0200, Felipe Balbi wrote: > > Hi, > > "Gustavo A. R. Silva" writes: > >> "Gustavo A. R. Silva" writes: > >>> Add missing break in switch. > >>> > >>> Addresses-Coverity-ID: 201385 > >>> Signed-off-by: Gustavo A. R. Silva > >>> --- > >>> drivers/usb/gadget/u

Re: [PATCH 1/1] xhci: add USB2 test mode support

2017-02-08 Thread Alexander Stein
On Wednesday 08 February 2017 13:53:30, Greg Kroah-Hartman wrote: > On Wed, Feb 08, 2017 at 11:26:35AM +0100, Alexander Stein wrote: > > This patch adds support for USB2 test mode (Test_J, Test_K, > > Test_SE0_NAK and Test_Packet) per XHCI spec 4.19.6. > > What does that mean "in English"? In oth

RE: net2280 Driver Bug

2017-02-08 Thread Felipe Balbi
Hi, Raz Manor writes: > Raz Manor writes: >> Got it. Then I'm resending the patch, and looking forward to your replay. > > please read Documentation/SubmittingPatches :-) > > you need a commit log, a Signed-off-by line, etc etc. Please send a proper > patch otherwise we can't apply it, sorry.

Re: [PATCH 1/2] drivers: usb: gadget: udc: add missing break in switch

2017-02-08 Thread Felipe Balbi
Hi, Greg KH writes: > On Wed, Feb 08, 2017 at 02:05:35PM +0200, Felipe Balbi wrote: >> >> Hi, >> >> "Gustavo A. R. Silva" writes: >> >> "Gustavo A. R. Silva" writes: >> >>> Add missing break in switch. >> >>> >> >>> Addresses-Coverity-ID: 201385 >> >>> Signed-off-by: Gustavo A. R. Silva >>

[PATCH 0/4] USB: serial: metro-usb: various clean ups

2017-02-08 Thread Johan Hovold
These patches clean up the metro-usb driver somewhat by removing redundant code and some unnecessary dev_dbgs. Johan Johan Hovold (4): USB: serial: metro-usb: drop unused interrupt-out callback USB: serial: metro-usb: drop redundant URB unlink USB: serial: metro-usb: drop function-tracing

[PATCH 4/4] USB: serial: metro-usb: drop redundant URB reinitialisation

2017-02-08 Thread Johan Hovold
No need to reinitialise the interrupt-in URB with values that have not changed before (some) resubmissions. This also allows the interrupt-in callback to have a single path for URB resubmission. Signed-off-by: Johan Hovold --- drivers/usb/serial/metro-usb.c | 20 ++-- 1 file cha

Re: [PATCH 1/2] drivers: usb: gadget: udc: add missing break in switch

2017-02-08 Thread Michal Nazarewicz
On Wed, Feb 08 2017, Felipe Balbi wrote: > Hi, > > "Gustavo A. R. Silva" writes: >> Add missing break in switch. >> >> Addresses-Coverity-ID: 201385 >> Signed-off-by: Gustavo A. R. Silva >> --- >> drivers/usb/gadget/udc/mv_udc_core.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/dr

Re: [PATCH v4] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

2017-02-08 Thread Andy Shevchenko
On Wed, 2017-02-08 at 09:52 +0100, Richard Leitner wrote: > From: Richard Leitner If you want to fix the above you have to fix your Git configuration. > This patch adds a driver for configuration of the Microchip > USB251xB/xBi > USB 2.0 hub controller series with USB 2.0 upstream connectivity,

Re: [PATCH 1/2] drivers: usb: gadget: udc: add missing break in switch

2017-02-08 Thread Greg KH
On Wed, Feb 08, 2017 at 02:16:27PM +0100, Michal Nazarewicz wrote: > On Wed, Feb 08 2017, Felipe Balbi wrote: > > Hi, > > > > "Gustavo A. R. Silva" writes: > >> Add missing break in switch. > >> > >> Addresses-Coverity-ID: 201385 > >> Signed-off-by: Gustavo A. R. Silva > >> --- > >> drivers/usb/

Re: [PATCH 1/1] xhci: add USB2 test mode support

2017-02-08 Thread Greg Kroah-Hartman
On Wed, Feb 08, 2017 at 02:10:39PM +0100, Alexander Stein wrote: > On Wednesday 08 February 2017 13:53:30, Greg Kroah-Hartman wrote: > > On Wed, Feb 08, 2017 at 11:26:35AM +0100, Alexander Stein wrote: > > > This patch adds support for USB2 test mode (Test_J, Test_K, > > > Test_SE0_NAK and Test_Pac

Re: [PATCH v2 1/1] xhci: add USB2 test mode support

2017-02-08 Thread Greg Kroah-Hartman
On Wed, Feb 08, 2017 at 02:44:44PM +0100, Alexander Stein wrote: > This patch adds support for USB2 test mode (Test_J, Test_K, > Test_SE0_NAK and Test_Packet) per XHCI spec 4.19.6. > > USB2 test mode is a required hardware feature for system integrators > validating their hardware according to USB

[PATCH v2 1/1] xhci: add USB2 test mode support

2017-02-08 Thread Alexander Stein
This patch adds support for USB2 test mode (Test_J, Test_K, Test_SE0_NAK and Test_Packet) per XHCI spec 4.19.6. USB2 test mode is a required hardware feature for system integrators validating their hardware according to USB spec, regarding signal strength and stuff. It is purely a hardware test fe

Re: [PATCH v4] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

2017-02-08 Thread Greg KH
On Wed, Feb 08, 2017 at 03:21:08PM +0200, Andy Shevchenko wrote: > On Wed, 2017-02-08 at 09:52 +0100, Richard Leitner wrote: > > From: Richard Leitner > > If you want to fix the above you have to fix your Git configuration. > > > > This patch adds a driver for configuration of the Microchip > >

[PATCH 3/4] USB: serial: metro-usb: drop function-tracing debugging

2017-02-08 Thread Johan Hovold
Drop some unnecessary debug printks. Signed-off-by: Johan Hovold --- drivers/usb/serial/metro-usb.c | 12 1 file changed, 12 deletions(-) diff --git a/drivers/usb/serial/metro-usb.c b/drivers/usb/serial/metro-usb.c index b0c7746438df..f220a470197a 100644 --- a/drivers/usb/serial/me

[PATCH 1/4] USB: serial: metro-usb: drop unused interrupt-out callback

2017-02-08 Thread Johan Hovold
Drop the unused interrupt-out callback. Signed-off-by: Johan Hovold --- drivers/usb/serial/metro-usb.c | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers/usb/serial/metro-usb.c b/drivers/usb/serial/metro-usb.c index 39e683096e94..4f7cd30b5424 100644 --- a/drivers/usb/serial/metr

Re: [PATCH v2 1/1] xhci: add USB2 test mode support

2017-02-08 Thread Mathias Nyman
On 08.02.2017 15:44, Alexander Stein wrote: This patch adds support for USB2 test mode (Test_J, Test_K, Test_SE0_NAK and Test_Packet) per XHCI spec 4.19.6. USB2 test mode is a required hardware feature for system integrators validating their hardware according to USB spec, regarding signal stren

Re: [PATCH 1/2] drivers: usb: gadget: udc: add missing break in switch

2017-02-08 Thread Felipe Balbi
Hi, "Gustavo A. R. Silva" writes: >> "Gustavo A. R. Silva" writes: >>> Add missing break in switch. >>> >>> Addresses-Coverity-ID: 201385 >>> Signed-off-by: Gustavo A. R. Silva >>> --- >>> drivers/usb/gadget/udc/mv_udc_core.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/driv

[PATCH 2/4] USB: serial: metro-usb: drop redundant URB unlink

2017-02-08 Thread Johan Hovold
Drop redundant URB unlink as there's no need to unlink an URB which is about to be killed synchronously. Signed-off-by: Johan Hovold --- drivers/usb/serial/metro-usb.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/serial/metro-usb.c b/drivers/usb/serial/metro-usb.c index 4f7cd30

[PATCH] usb: gadget: mv_udc: clarify a switch with an implicit fall-through

2017-02-08 Thread Michal Nazarewicz
Rearrange statements in mv_ep_enable function so that it’s obvious what the switch does and how zlt, ios and mult variables are initialised. Most notably, this gets rid of an implicit fall-through so people don’t have to wonder whether it was intenional or not. Addresses-Coverity-ID: 201385 Repor

[PATCH] usb: gadget: f_fs: simplify ffs_dev name handling

2017-02-08 Thread Michal Nazarewicz
Currently ffs_dev::name can be either allocated by the client of the ffs_dev structure or by the f_fs.c core itself. The former is used by g_ffs while the latter happens with configfs. Historically, g_ffs did not need to allocate separate buffer for the name so what is now f_fs.c core never cared

Re: Periodic reconnects of USB mouse on Dell PowerEdge R730

2017-02-08 Thread Paul Menzel
Dear Greg, On 02/08/17 14:02, Greg KH wrote: On Wed, Feb 08, 2017 at 12:16:44PM +0100, Paul Menzel wrote: On the server Dell PowerEdge R730 with firmware 2.3.4, and Linux 4.9.2, the connected USB mouse disconnects and connects again periodically. This can be reproduced with two different (Lo

Re: [PATCH v3 1/2] sierra_net: Add support for IPv6 and Dual-Stack Link Sense Indications

2017-02-08 Thread David Miller
From: Bjørn Mork Date: Wed, 08 Feb 2017 10:55:50 +0100 > Stefan Brüns writes: > >> If a context is configured as dualstack ("IPv4v6"), the modem indicates >> the context activation with a slightly different indication message. >> The dual-stack indication omits the link_type (IPv4/v6) and adds

Re: [PATCH v4] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

2017-02-08 Thread Richard Leitner
On 02/08/2017 02:59 PM, Greg KH wrote: > On Wed, Feb 08, 2017 at 03:21:08PM +0200, Andy Shevchenko wrote: >> On Wed, 2017-02-08 at 09:52 +0100, Richard Leitner wrote: >>> From: Richard Leitner >> >> If you want to fix the above you have to fix your Git configuration. My git config is fine, just c

RE: [PATCH resend v5 0/4] xhci fixes for usb-linus

2017-02-08 Thread Alan Stern
On Wed, 8 Feb 2017, Peter Chen wrote: > >> On Thu, Jan 19, 2017 at 02:21:26PM +0200, Mathias Nyman wrote: > >> > Hi Greg > >> > > >> > This series by Arnd Bergmann was originally six patches, but last > >> > two of them were already taken to 4.10. Without the rest of them > >> > there will be a re

Re: Periodic reconnects of USB mouse on Dell PowerEdge R730

2017-02-08 Thread Johan Hovold
On Wed, Feb 08, 2017 at 04:15:02PM +0100, Paul Menzel wrote: > On 02/08/17 14:02, Greg KH wrote: > > On Wed, Feb 08, 2017 at 12:16:44PM +0100, Paul Menzel wrote: > >> On the server Dell PowerEdge R730 with firmware 2.3.4, and Linux 4.9.2, the > >> connected USB mouse disconnects and connects again

Re: Periodic reconnects of USB mouse on Dell PowerEdge R730

2017-02-08 Thread Alan Stern
On Wed, 8 Feb 2017, Paul Menzel wrote: > Dear Greg, > > > On 02/08/17 14:02, Greg KH wrote: > > On Wed, Feb 08, 2017 at 12:16:44PM +0100, Paul Menzel wrote: > > >> On the server Dell PowerEdge R730 with firmware 2.3.4, and Linux 4.9.2, the > >> connected USB mouse disconnects and connects again

[PATCH 2/2] net2280: Fix tmp reusage in net2280 driver

2017-02-08 Thread Raz Manor
In the function scan_dma_completions() there is a reusage of tmp variable. That coused a wrong value being used in some case when reading a short packet terminated transaction from an endpoint, in 2 concecutive reads. This was my logic for the patch: The req->td->dmadesc equals to 0 iff: -- There

Re: [PATCH net-next v2 00/12] net: dsa: remove unnecessary phy.h include

2017-02-08 Thread David Miller
From: Florian Fainelli Date: Tue, 7 Feb 2017 15:02:53 -0800 > I'm hoping this doesn't conflict with what's already in net-next... > > David, this should probably go via your tree considering the diffstat. I think you need one more respin. Are you doing an allmodconfig build? If not, for somet

Re: How to resolve "Waited 2000ms for CONNECT" in system resuming?

2017-02-08 Thread Alan Stern
On Wed, 8 Feb 2017, Yoshihiro Shimoda wrote: > Hi, > > In my environment, it causes the following message during system resume if > debug messages are enabled: > > usb 2-1: Waited 2000ms for CONNECT This message indicates that the port was connected to a device when the system suspended

Re: [PATCH 2/2] net2280: Fix tmp reusage in net2280 driver

2017-02-08 Thread Alan Stern
On Wed, 8 Feb 2017, Raz Manor wrote: > In the function scan_dma_completions() there is a reusage of tmp > variable. That coused a wrong value being used in some case when > reading a short packet terminated transaction from an endpoint, > in 2 concecutive reads. > > This was my logic for the patc

Re: Periodic reconnects of USB mouse on Dell PowerEdge R730

2017-02-08 Thread Paul Menzel
Dear Johan, On 02/08/17 16:50, Johan Hovold wrote: On Wed, Feb 08, 2017 at 04:15:02PM +0100, Paul Menzel wrote: On 02/08/17 14:02, Greg KH wrote: On Wed, Feb 08, 2017 at 12:16:44PM +0100, Paul Menzel wrote: On the server Dell PowerEdge R730 with firmware 2.3.4, and Linux 4.9.2, the connected

Re: [PATCH net-next v2 00/12] net: dsa: remove unnecessary phy.h include

2017-02-08 Thread Kalle Valo
David Miller writes: > From: Florian Fainelli > Date: Tue, 7 Feb 2017 15:02:53 -0800 > >> I'm hoping this doesn't conflict with what's already in net-next... >> >> David, this should probably go via your tree considering the diffstat. > > I think you need one more respin. Are you doing an all

[PATCH] ohci-hub: fix typo in dbg_port macro

2017-02-08 Thread Jelle Martijn Kok
The "dbg_port" macro uses the "outside" parameter (="temp") instead of the parameters (="value") given in the macro. As the macro can look outside its definition this causes no direct problem. Signed-off-by: Jelle Martijn Kok Acked-by: Alan Stern --- drivers/usb/host/ohci-hub.c | 26 ++

Re: [PATCH v4] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

2017-02-08 Thread Andy Shevchenko
On Wed, 2017-02-08 at 16:17 +0100, Richard Leitner wrote: > On 02/08/2017 02:59 PM, Greg KH wrote: > > On Wed, Feb 08, 2017 at 03:21:08PM +0200, Andy Shevchenko wrote: > > > On Wed, 2017-02-08 at 09:52 +0100, Richard Leitner wrote: > > > > From: Richard Leitner > > > > > > If you want to fix the

xhci: USB streams not working on some newer (skylake + cht) intel chipsets breaking uas ?

2017-02-08 Thread Hans de Goede
Hi All, A while ago I submitted a patch with the following commit msg: "usb: xhci: Disable streams on Intel Cherrytrail controllers Using an UAS device (and thus USB-3 streams) on an Intel Cherrytrail device, results in the following error: xhci_hcd :00:14.0: ERROR Transfer event for disab

Re: Periodic reconnects of USB mouse on Dell PowerEdge R730

2017-02-08 Thread Johan Hovold
On Wed, Feb 08, 2017 at 05:41:33PM +0100, Paul Menzel wrote: > On 02/08/17 16:50, Johan Hovold wrote: > > On Wed, Feb 08, 2017 at 04:15:02PM +0100, Paul Menzel wrote: > >> On 02/08/17 14:02, Greg KH wrote: > >>> On Wed, Feb 08, 2017 at 12:16:44PM +0100, Paul Menzel wrote: > On the server Dell

[PATCH 2/2] USB: serial: console: clean up sanity checks

2017-02-08 Thread Johan Hovold
Drop two redundant NULL checks from usb_serial_console_disconnect(). The usb_serial_console_disconnect function is called from the USB-serial-device disconnect callback when a device is going away. Hence there is no need to check for the serial-device pointer being NULL. The serial-device port po

[PATCH 1/2] USB: serial: console: fix uninitialised spinlock

2017-02-08 Thread Johan Hovold
Since commit 4a510969374a ("tty: Make tty_files_lock per-tty") a new tty_struct spin lock is taken in the tty release path, but the USB-serial-console hack was never updated hence leaving the lock of its "fake" tty uninitialised. This was eventually detected by lockdep. Make sure to initialise the

Re: [PATCH 2/4] USB: serial: metro-usb: drop redundant URB unlink

2017-02-08 Thread Greg KH
On Wed, Feb 08, 2017 at 01:49:17PM +0100, Johan Hovold wrote: > Drop redundant URB unlink as there's no need to unlink an URB which is > about to be killed synchronously. > > Signed-off-by: Johan Hovold Reviewed-by: Greg Kroah-Hartman -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH 1/4] USB: serial: metro-usb: drop unused interrupt-out callback

2017-02-08 Thread Greg KH
On Wed, Feb 08, 2017 at 01:49:16PM +0100, Johan Hovold wrote: > Drop the unused interrupt-out callback. > > Signed-off-by: Johan Hovold Reviewed-by: Greg Kroah-Hartman -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org

Re: [PATCH 4/4] USB: serial: metro-usb: drop redundant URB reinitialisation

2017-02-08 Thread Greg KH
On Wed, Feb 08, 2017 at 01:49:19PM +0100, Johan Hovold wrote: > No need to reinitialise the interrupt-in URB with values that have not > changed before (some) resubmissions. > > This also allows the interrupt-in callback to have a single path for URB > resubmission. > > Signed-off-by: Johan Hovol

Re: [PATCH 3/4] USB: serial: metro-usb: drop function-tracing debugging

2017-02-08 Thread Greg KH
On Wed, Feb 08, 2017 at 01:49:18PM +0100, Johan Hovold wrote: > Drop some unnecessary debug printks. > > Signed-off-by: Johan Hovold Reviewed-by: Greg Kroah-Hartman -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org Mor

[PATCH 0/2] USB: serial: console: fix tty-lock regression

2017-02-08 Thread Johan Hovold
Testing a simple clean-up patch resulted in a lockdep splat, which turned out to be due to an uninitialised spin lock after a tty change that went into 4.6. Makes you wonder how many people actually use this code... Johan Johan Hovold (2): USB: serial: console: fix uninitialised spinlock USB

Re: [RFC 08/19] scsi: be2iscsi: Replace PCI pool old API

2017-02-08 Thread Peter Senna Tschudin
On Wed, Feb 08, 2017 at 05:34:46PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. > Tested by compilation only. Acked-by: Peter Senna Tschudin Tested-by: Peter Senna Tschudin > Signed

Re: [RFC 09/19] scsi: csiostor: Replace PCI pool old API

2017-02-08 Thread Peter Senna Tschudin
On Wed, Feb 08, 2017 at 05:34:47PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. > > Signed-off-by: Romain Perier > --- > drivers/scsi/csiostor/csio_hw.h | 2 +- > drivers/scsi/csio

Re: [RFC 07/19] wireless: ipw2200: Replace PCI pool old API

2017-02-08 Thread Peter Senna Tschudin
On Wed, Feb 08, 2017 at 05:34:45PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. > > Signed-off-by: Romain Perier > --- > drivers/net/wireless/intel/ipw2x00/ipw2200.c | 12 ++--

Re: [RFC 06/19] mlx5: Replace PCI pool old API

2017-02-08 Thread Peter Senna Tschudin
On Wed, Feb 08, 2017 at 05:34:44PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. > > Signed-off-by: Romain Perier > --- > drivers/net/ethernet/mellanox/mlx5/core/cmd.c | 10 +--

Re: [RFC 01/19] block: DAC960: Replace PCI pool old API

2017-02-08 Thread Peter Senna Tschudin
On Wed, Feb 08, 2017 at 05:34:39PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. > > Signed-off-by: Romain Perier Tested by compilation only. Some whitespace errors, but the patch do

Re: [RFC 03/19] IB/mthca: Replace PCI pool old API

2017-02-08 Thread Peter Senna Tschudin
On Wed, Feb 08, 2017 at 05:34:41PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. Tested by compilation only. Acked-by: Peter Senna Tschudin Tested-by: Peter Senna Tschudin > > Signe

Re: [PATCH 4/4] USB: serial: metro-usb: drop redundant URB reinitialisation

2017-02-08 Thread Johan Hovold
On Wed, Feb 08, 2017 at 07:05:50PM +0100, Greg Kroah-Hartman wrote: > On Wed, Feb 08, 2017 at 01:49:19PM +0100, Johan Hovold wrote: > > No need to reinitialise the interrupt-in URB with values that have not > > changed before (some) resubmissions. > > > > This also allows the interrupt-in callback

Re: [RFC 13/19] scsi: mvsas: Replace PCI pool old API

2017-02-08 Thread Peter Senna Tschudin
On Wed, Feb 08, 2017 at 05:34:51PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. > > Signed-off-by: Romain Perier > --- > drivers/scsi/mvsas/mv_init.c | 4 ++-- > drivers/scsi/mvsas/m

Re: [RFC 12/19] scsi: mpt3sas: Replace PCI pool old API

2017-02-08 Thread Peter Senna Tschudin
On Wed, Feb 08, 2017 at 05:34:50PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. > > Signed-off-by: Romain Perier > --- > drivers/scsi/mpt3sas/mpt3sas_base.c | 64 > +

Re: [RFC 16/19] usb: gadget: net2280: Replace PCI pool old API

2017-02-08 Thread Peter Senna Tschudin
On Wed, Feb 08, 2017 at 05:34:54PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. > Tested by compilation only. Acked-by: Peter Senna Tschudin Tested-by: Peter Senna Tschudin > Signed

Re: [RFC 02/19] dmaengine: pch_dma: Replace PCI pool old API

2017-02-08 Thread Peter Senna Tschudin
On Wed, Feb 08, 2017 at 05:34:40PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. > Tested by compilation only. Acked-by: Peter Senna Tschudin Tested-by: Peter Senna Tschudin > Signe

Re: [RFC 17/19] usb: gadget: pch_udc: Replace PCI pool old API

2017-02-08 Thread Peter Senna Tschudin
On Wed, Feb 08, 2017 at 05:34:55PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. > > Signed-off-by: Romain Perier > --- > drivers/usb/gadget/udc/pch_udc.c | 28 ++-

Re: [RFC 15/19] usb: gadget: amd5536udc: Replace PCI pool old API

2017-02-08 Thread Peter Senna Tschudin
On Wed, Feb 08, 2017 at 05:34:53PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. > Tested by compilation only. Acked-by: Peter Senna Tschudin Tested-by: Peter Senna Tschudin > Signed

Re: [RFC 04/19] net: e100: Replace PCI pool old API

2017-02-08 Thread Peter Senna Tschudin
On Wed, Feb 08, 2017 at 05:34:42PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. Tested by compilation only. Acked-by: Peter Senna Tschudin Tested-by: Peter Senna Tschudin > Signed-o

Re: [RFC 18/19] PCI: Remove PCI pool macro functions

2017-02-08 Thread Peter Senna Tschudin
On Wed, Feb 08, 2017 at 05:34:56PM +0100, Romain Perier wrote: > Now that all the drivers use dma pool API, we can remove the macro > functions for PCI pool. Good news: make allyesconfig;make succeed after the changes until this point, but: $ grep -R pci_pool ... drivers/usb/gadget/udc/pch_udc.c:

Re: [RFC 05/19] mlx4: Replace PCI pool old API

2017-02-08 Thread Peter Senna Tschudin
On Wed, Feb 08, 2017 at 05:34:43PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. Tested by compilation only. Acked-by: Peter Senna Tschudin Tested-by: Peter Senna Tschudin > Signed-o

Re: [RFC 00/19] Replace PCI pool by DMA pool API

2017-02-08 Thread Peter Senna Tschudin
On Wed, Feb 08, 2017 at 05:34:38PM +0100, Romain Perier wrote: Hi Romain, Nice set of patches! Thank you. I sent a few comments, but basically you missed to run checkpatch.pl on your patches. Also you can take the chance to fix some white space issues that are on the lines you are changing like s

Re: [RFC 19/19] checkpatch: warn for use of old PCI pool API

2017-02-08 Thread Peter Senna Tschudin
On Wed, Feb 08, 2017 at 05:34:57PM +0100, Romain Perier wrote: > pci_pool_*() functions should be replaced by the corresponding functions > in the DMA pool API. This adds support to check for use of these pci > functions and display a warning when it is the case. Don't know if relevant, but did no

Re: [RFC 14/19] scsi: pmcraid: Replace PCI pool old API

2017-02-08 Thread Peter Senna Tschudin
On Wed, Feb 08, 2017 at 05:34:52PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. > Tested by compilation only. Acked-by: Peter Senna Tschudin Tested-by: Peter Senna Tschudin > Signed

Re: [RFC 10/19] scsi: lpfc: Replace PCI pool old API

2017-02-08 Thread Peter Senna Tschudin
On Wed, Feb 08, 2017 at 05:34:48PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. > > Signed-off-by: Romain Perier > --- > drivers/scsi/lpfc/lpfc.h | 10 +++ > drivers/scsi/lp

Re: [RFC 11/19] scsi: megaraid: Replace PCI pool old API

2017-02-08 Thread Peter Senna Tschudin
On Wed, Feb 08, 2017 at 05:34:49PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. > > Signed-off-by: Romain Perier > --- > drivers/scsi/megaraid/megaraid_mbox.c | 30 ++--

Re: [PATCH v4] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

2017-02-08 Thread Andy Shevchenko
On Wed, 2017-02-08 at 19:45 +0100, Richard Leitner wrote: > On 02/08/2017 05:40 PM, Andy Shevchenko wrote: > > On Wed, 2017-02-08 at 16:17 +0100, Richard Leitner wrote: > > > On 02/08/2017 02:59 PM, Greg KH wrote: > > > > On Wed, Feb 08, 2017 at 03:21:08PM +0200, Andy Shevchenko wrote: > > > > > On

Re: [PATCH] drivers: usb: gadget: udc: remove pointer dereference after free

2017-02-08 Thread Andy Shevchenko
On Wed, 2017-02-08 at 13:15 -0600, Gustavo A. R. Silva wrote: > Remove pointer dereference and write after free. It's wrong description. There is no write after free. The memory is still in pool and one may access it. Though the access is *formally* illegal. Code itself looks interesting. > > A

Re: [PATCH v4] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

2017-02-08 Thread Richard Leitner
On 02/08/2017 05:40 PM, Andy Shevchenko wrote: On Wed, 2017-02-08 at 16:17 +0100, Richard Leitner wrote: On 02/08/2017 02:59 PM, Greg KH wrote: On Wed, Feb 08, 2017 at 03:21:08PM +0200, Andy Shevchenko wrote: On Wed, 2017-02-08 at 09:52 +0100, Richard Leitner wrote: From: Richard Leitner

Re: [PATCH net-next v2 00/12] net: dsa: remove unnecessary phy.h include

2017-02-08 Thread Florian Fainelli
On 02/08/2017 08:11 AM, Kalle Valo wrote: > David Miller writes: > >> From: Florian Fainelli >> Date: Tue, 7 Feb 2017 15:02:53 -0800 >> >>> I'm hoping this doesn't conflict with what's already in net-next... >>> >>> David, this should probably go via your tree considering the diffstat. >> >> I

Re: [RFC 19/19] checkpatch: warn for use of old PCI pool API

2017-02-08 Thread Joe Perches
On Wed, 2017-02-08 at 19:55 +0100, Peter Senna Tschudin wrote: > On Wed, Feb 08, 2017 at 05:34:57PM +0100, Romain Perier wrote: > > pci_pool_*() functions should be replaced by the corresponding functions > > in the DMA pool API. This adds support to check for use of these pci > > functions and dis

[PATCH 1/3] usb: host: fotg2: add devicetree probing

2017-02-08 Thread Hans Ulli Kroll
Signed-off-by: Hans Ulli Kroll --- drivers/usb/host/fotg210-hcd.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/drivers/usb/host/fotg210-hcd.c b/drivers/usb/host/fotg210-hcd.c index 9d0b0518290a..2acc51b0be5a 100644 --- a/drivers/usb/host/fotg210-hcd.c +++ b/drivers/usb

[PATCH 0/3] usb: add device tree support for fotg2-hcd driver

2017-02-08 Thread Hans Ulli Kroll
Add device tree binding and DT driver support for fotg2-hcd controller The device is used on Gemini SoC. striped down dmesg fotg210_hcd: FOTG210 Host Controller (EHCI) Driver fotg210-hcd 6800.usb: Faraday USB2.0 Host Controller fotg210-hcd 6800.usb: new USB bus registered, assigned bus nu

[PATCH 3/3] DT: add Faraday Tec. as vendor

2017-02-08 Thread Hans Ulli Kroll
add Faraday Technology Corporation as vendor faraday for DT Signed-off-by: Hans Ulli Kroll --- Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vend

[PATCH 2/3] usb: add DT bindings for farady fotg2 host controller

2017-02-08 Thread Hans Ulli Kroll
This adds DT bindings for the Faraday FOTG2 host controller. Signed-off-by: Hans Ulli Kroll --- Documentation/devicetree/bindings/usb/fotg2-host.txt | 15 +++ 1 file changed, 15 insertions(+) create mode 100644 Documentation/devicetree/bindings/usb/fotg2-host.txt diff --git a/Docum

Re: [PATCH 0/2] USB: serial: console: fix tty-lock regression

2017-02-08 Thread Greg KH
On Wed, Feb 08, 2017 at 06:51:31PM +0100, Johan Hovold wrote: > Testing a simple clean-up patch resulted in a lockdep splat, which > turned out to be due to an uninitialised spin lock after a tty change > that went into 4.6. Makes you wonder how many people actually use this > code... USB serial c

Re: [PATCH 1/2] USB: serial: console: fix uninitialised spinlock

2017-02-08 Thread Greg KH
On Wed, Feb 08, 2017 at 06:53:08PM +0100, Johan Hovold wrote: > Since commit 4a510969374a ("tty: Make tty_files_lock per-tty") a new > tty_struct spin lock is taken in the tty release path, but the > USB-serial-console hack was never updated hence leaving the lock of its > "fake" tty uninitialised.

Re: [PATCH v4] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

2017-02-08 Thread Andy Shevchenko
On Wed, 2017-02-08 at 21:03 +0100, Richard Leitner wrote: > On 02/08/2017 08:20 PM, Andy Shevchenko wrote: > > On Wed, 2017-02-08 at 19:45 +0100, Richard Leitner wrote: > > > On 02/08/2017 05:40 PM, Andy Shevchenko wrote: > > > > On Wed, 2017-02-08 at 16:17 +0100, Richard Leitner wrote: > > > > > O

Re: [PATCH 2/2] USB: serial: console: clean up sanity checks

2017-02-08 Thread Greg KH
On Wed, Feb 08, 2017 at 06:53:09PM +0100, Johan Hovold wrote: > Drop two redundant NULL checks from usb_serial_console_disconnect(). > > The usb_serial_console_disconnect function is called from the > USB-serial-device disconnect callback when a device is going away. Hence > there is no need to ch

Re: [PATCH v4] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

2017-02-08 Thread Richard Leitner
On 02/08/2017 08:20 PM, Andy Shevchenko wrote: On Wed, 2017-02-08 at 19:45 +0100, Richard Leitner wrote: On 02/08/2017 05:40 PM, Andy Shevchenko wrote: On Wed, 2017-02-08 at 16:17 +0100, Richard Leitner wrote: On 02/08/2017 02:59 PM, Greg KH wrote: On Wed, Feb 08, 2017 at 03:21:08PM +0200, An

Re: [PATCH v12 6/9] usb: xhci: use bus->sysdev for DMA configuration

2017-02-08 Thread Jack Pham
Hi Peter, Sriram, Arnd, On Mon, Feb 06, 2017 at 05:13:38PM +0800, Peter Chen wrote: > From: Arnd Bergmann > > For xhci-hcd platform device, all the DMA parameters are not > configured properly, notably dma ops for dwc3 devices. So, set > the dma for xhci from sysdev. sysdev is pointing to device

[PATCH] drivers: usb: gadget: udc: remove pointer dereference after free

2017-02-08 Thread Gustavo A. R. Silva
Remove pointer dereference and write after free. Addresses-Coverity-ID: 1091173 Signed-off-by: Gustavo A. R. Silva --- drivers/usb/gadget/udc/pch_udc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/gadget/udc/pch_udc.c b/drivers/usb/gadget/udc/pch_udc.c index a97da64..8a365aa 10

Re: [PATCH 0/2] USB: serial: console: fix tty-lock regression

2017-02-08 Thread Johan Hovold
On Wed, Feb 08, 2017 at 09:16:02PM +0100, Greg Kroah-Hartman wrote: > On Wed, Feb 08, 2017 at 06:51:31PM +0100, Johan Hovold wrote: > > Testing a simple clean-up patch resulted in a lockdep splat, which > > turned out to be due to an uninitialised spin lock after a tty change > > that went into 4.6

Re: [PATCH V2] usb: xhci: add support for performing fake doorbell

2017-02-08 Thread Jon Mason
On Mon, Jan 16, 2017 at 2:32 AM, Rafał Miłecki wrote: > On 21 November 2016 at 16:31, Mathias Nyman > wrote: >> On 21.11.2016 09:57, Rafał Miłecki wrote: >>> >>> Hi Mathias, >>> >>> On 17 October 2016 at 22:30, Rafał Miłecki wrote: From: Rafał Miłecki Broadcom's Northstar XH

Re: [PATCH v2 1/1] xhci: add USB2 test mode support

2017-02-08 Thread Alexander Stein
On Wednesday 08 February 2017 16:17:45, Mathias Nyman wrote: > On 08.02.2017 15:44, Alexander Stein wrote: > > This patch adds support for USB2 test mode (Test_J, Test_K, > > Test_SE0_NAK and Test_Packet) per XHCI spec 4.19.6. > > > > USB2 test mode is a required hardware feature for system integr

Re: [PATCH] drivers: usb: gadget: udc: remove pointer dereference after free

2017-02-08 Thread Gustavo A. R. Silva
Hi Andy, Quoting Andy Shevchenko : On Wed, 2017-02-08 at 13:15 -0600, Gustavo A. R. Silva wrote: Remove pointer dereference and write after free. It's wrong description. There is no write after free. The memory is still in pool and one may access it. Though the access is *formally* illegal.

Re: [PATCH 1/3] usb: host: fotg2: add devicetree probing

2017-02-08 Thread kbuild test robot
Hi Hans, [auto build test ERROR on usb/usb-testing] [also build test ERROR on v4.10-rc7 next-20170208] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Hans-Ulli-Kroll/usb-host-fotg2-add

Re: [PATCH resend v5 0/4] xhci fixes for usb-linus

2017-02-08 Thread Peter Chen
On Wed, Feb 08, 2017 at 10:12:59AM -0500, Alan Stern wrote: > On Wed, 8 Feb 2017, Peter Chen wrote: > > > >> On Thu, Jan 19, 2017 at 02:21:26PM +0200, Mathias Nyman wrote: > > >> > Hi Greg > > >> > > > >> > This series by Arnd Bergmann was originally six patches, but last > > >> > two of them were

  1   2   >