Re: [PATCH v5] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

On 02/16/2017 03:30 AM, Rob Herring wrote: On Fri, Feb 10, 2017 at 09:19:27AM +0100, Richard Leitner wrote: This patch adds a driver for configuration of the Microchip USB251xB/xBi USB 2.0 hub controller series with USB 2.0 upstream connectivity, SMBus configuration interface and two to four

Re: [PATCH v5 0/5] dmaengine: cppi41: Make CPPI 4.1 driver more generic

On Wed, Feb 15, 2017 at 02:56:31PM +0100, Alexandre Bailon wrote: > This series intend to make the CPPI 4.1 more generic in order to > add a new platform (the DA8xx). > To achieve that, all the IRQ code present in CPPI 4.1 driver has been moved > to MUSB DSPS driver. > Other changes mainly update

Re: [RFC][PATCH] usb: dwc2: Make sure we disconnect the gadget state

On 2/13/2017 8:08 PM, John Stultz wrote: > Just wanted to get some early feedback on this before I submit > it for real for the 4.12 timeframe. This is the last patch, that > isn't already queued, which I need to get hikey's USB working > properly. > > Feedback would be greatly appreciated! > It

Re: [PATCH v5] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

On Fri, Feb 10, 2017 at 09:19:27AM +0100, Richard Leitner wrote: > This patch adds a driver for configuration of the Microchip USB251xB/xBi > USB 2.0 hub controller series with USB 2.0 upstream connectivity, SMBus > configuration interface and two to four USB 2.0 downstream ports. > > Furthermore

Re: [RESEND PATCH v2 1/2] Documentation: dt: dwc2: amend clocks property

On Fri, Feb 10, 2017 at 11:06:26AM +0800, Frank Wang wrote: > Move 'clocks' to optional properties since not every platform > is going to need to specify it and add pmu/utmi/ulpi/utmifs > optional clocks into 'clock-names' list. > > Signed-off-by: Frank Wang > --- >

Re: [PATCH 1/1] extcon: ext-usb-gpio: do not enable USB as wakeup source by default

On 2017년 02월 13일 18:21, Peter Chen wrote: > Whether the USB port as a wakeup source should be determined by user, > but not enabled by default. > > Signed-off-by: Peter Chen > --- > drivers/extcon/extcon-usb-gpio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: v4.10-rc8 (-rc6) boot regression on Intel desktop, does not boot after cold boots, boots after reboot

On Wed, Feb 15, 2017 at 3:20 PM, Pavel Machek wrote: > 4.10-rc4 broken > 4.10-rc3 ok Hmm. If those actually end up being reliable, then there's not a whole lot in between them wrt PCI or USB. What looked like the most likely candidate seems to be xhci-specific, though. But maybe

Re: v4.10-rc8 (-rc6) boot regression on Intel desktop, does not boot after cold boots, boots after reboot

On Wed 2017-02-15 18:23:03, Pavel Machek wrote: > On Tue 2017-02-14 11:12:26, Linus Torvalds wrote: > > On Feb 14, 2017 9:59 AM, "Pavel Machek" wrote: > > > > Hi! > > > > > > > > > > Booting to grub, then hitting ctrl-alt-del is enough to make it work. > > Ouch. > > > > > > > > It

Re: [PATCH 2/3] usb: add DT bindings for farady fotg2 host controller

On Wed, Feb 08, 2017 at 09:00:09PM +0100, Hans Ulli Kroll wrote: > This adds DT bindings for the Faraday FOTG2 host controller. > > Signed-off-by: Hans Ulli Kroll > --- > Documentation/devicetree/bindings/usb/fotg2-host.txt | 15 +++ > 1 file changed, 15

Re: [PATCH 3/3] DT: add Faraday Tec. as vendor

On Sun, Feb 12, 2017 at 09:37:37PM +0100, Linus Walleij wrote: > On Wed, Feb 8, 2017 at 9:00 PM, Hans Ulli Kroll > wrote: > > > add Faraday Technology Corporation as vendor faraday for DT > > > > Signed-off-by: Hans Ulli Kroll > > I

Re: v4.10-rc8 (-rc6) boot regression on Intel desktop, does not boot after cold boots, boots after reboot

On Tue 2017-02-14 11:12:26, Linus Torvalds wrote: > On Feb 14, 2017 9:59 AM, "Pavel Machek" wrote: > > Hi! > > > > > > > Booting to grub, then hitting ctrl-alt-del is enough to make it work. > Ouch. > > > > > > It happens with current Linus' tree. > > > > v4.10-rc6-feb3 : broken >

Re: [PATCH 2/2] USB: serial: keyspan: drop header file

On Wed, Feb 15, 2017 at 06:39:52AM -0800, Greg Kroah-Hartman wrote: > On Wed, Feb 15, 2017 at 11:09:51AM +0100, Johan Hovold wrote: > > Move all declarations and definitions in keyspan.h to keyspan.c, which > > is the only place were they are used. > > > > This specifically moves the driver

Re: Periodic reconnects of USB mouse on Dell PowerEdge R730

On Wed, Feb 15, 2017 at 03:31:28PM +0100, Oliver Neukum wrote: > Am Mittwoch, den 08.02.2017, 17:54 +0100 schrieb Johan Hovold: > > > Also, I am unable to reproduce this problem with the *same* mice on > > a  > > > laptop with a USB3 – it’s blue – port. > > > > Ok, then the quirk is probably not

Re: [usb-storage] [PATCH] usb: storage: add missing pre-increment to variable

On Wed, 15 Feb 2017, Gustavo A. R. Silva wrote: > Add missing pre-increment to 'waitcount' variable used in do-while loop. > > Addresses-Coverity-ID: 1011631 > Signed-off-by: Gustavo A. R. Silva > --- > drivers/usb/storage/jumpshot.c | 2 +- > 1 file changed, 1

Re: [PATCH 2/3] usb: dwc3: use BIT() macro where possible

On 15/02/17 13:44, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: >> To avoid checkpatch warnings with new patches let's >> start using the BIT() macro wherever possible. >> >> Signed-off-by: Roger Quadros >> --- >> drivers/usb/dwc3/core.h | 192 >>

Re: [PATCH 2/2] USB: serial: keyspan: drop header file

On Wed, Feb 15, 2017 at 11:09:51AM +0100, Johan Hovold wrote: > Move all declarations and definitions in keyspan.h to keyspan.c, which > is the only place were they are used. > > This specifically moves the driver device-id tables and usb-serial > driver definitions to the source file where they

Re: [PATCH 1/2] USB: serial: io_edgeport: drop io-tables header file

On Wed, Feb 15, 2017 at 11:09:50AM +0100, Johan Hovold wrote: > Move the driver device-id tables and usb-serial driver definitions to > the source file where they are expected to be found. > > Signed-off-by: Johan Hovold Reviewed-by: Greg Kroah-Hartman

Re: Periodic reconnects of USB mouse on Dell PowerEdge R730

Am Mittwoch, den 08.02.2017, 17:54 +0100 schrieb Johan Hovold: > > Also, I am unable to reproduce this problem with the *same* mice on > a  > > laptop with a USB3 – it’s blue – port. > > Ok, then the quirk is probably not the right solution (even if it > could > possibly help with the

[PATCH v6 0/4] usb: musb: da8xx: Add DMA support

This series update MUSB driver to add DMA support to DA8xx. It should be applied on top of: "[PATCH v4 0/3] dmaengine: cppi41: Add dma support to da8xx" and "[PATCH v3] ARM: davinci: Make the usb20 clock available to PM runtime" Changes in v6: - Rebased on linux-next. Some patches were

[PATCH v6 4/4] usb: musb: da8xx: Add a primary support of PM runtime

Currently, MUSB DA8xx glue driver doesn't have PM runtime support. Because the CPPI 4.1 is using the same clock as MUSB DA8xx and CPPI 4.1 is a child of MUSB DA8xx glue, add support of PM runtime to the DA8xx glue driver in order to let the CPPI 4.1 driver manage the clock by using PM runtime.

[PATCH v6 3/4] usb: musb: musb_cppi41: Workaround DMA stall issue during teardown

The DMA may hang up if a teardown is initiated while an endpoint is still active (Advisory 2.3.27 of DA8xx errata). To workaround this issue, add a delay before to initiate the teardown. Signed-off-by: Alexandre Bailon --- drivers/usb/musb/da8xx.c | 2 +-

[PATCH v6 1/4] usb: musb: Use shared irq

In the DA8xx, USB and CPPI 4.1 are sharing the same interrupt line. Update the driver to request a shared irq. Signed-off-by: Alexandre Bailon --- drivers/usb/musb/musb_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/musb/musb_core.c

[PATCH v6 2/4] usb: musb: Add support of CPPI 4.1 DMA controller to DA8xx

Currently, only the PIO mode is supported. This add support of CPPI 4.1 to DA8xx. As the In DA8xx the CPPI 4.1 DMA is a part of the USB. Create the CPPI 4.1 device as a child of USB. Signed-off-by: Alexandre Bailon --- drivers/usb/musb/Kconfig | 4 ++--

[PATCH v5 3/5] dmaengine: cppi41: Move some constants to glue layer

Some constants are defined and use by the driver whereas they are specifics to AM335x. Add new variables to the glue layer, initialize them with the constants, and use them in the driver. Signed-off-by: Alexandre Bailon --- drivers/dma/cppi41.c | 20 ++-- 1

[PATCH v5 2/5] dmaengine: cppi41: rename platform variables

Currently, only the AM335x is supported by the driver. Though the driver has a glue layer to support different platforms, some platform variable names are not prefixed with the platform name. To facilitate the addition of a new platform, rename some variables owned by the AM335x glue.

[PATCH v5 4/5] dmaengine: cppi41: init_sched(): Get number of channels from DT

Despite the driver is already using DT to get the number of channels, init_sched() is using an hardcoded value to get it. Use DT to get the number of channels. Signed-off-by: Alexandre Bailon --- drivers/dma/cppi41.c | 20 1 file changed, 12

[PATCH v5 0/5] dmaengine: cppi41: Make CPPI 4.1 driver more generic

This series intend to make the CPPI 4.1 more generic in order to add a new platform (the DA8xx). To achieve that, all the IRQ code present in CPPI 4.1 driver has been moved to MUSB DSPS driver. Other changes mainly update the glue layer and platform code to make the whole driver more generic.

[PATCH v5 5/5] dmaengine: cppi41: Remove isr callback from glue layer

All the platform code to manage IRQ has been moved to MUSB, and now the interrupt handler is completely generic. Remove the isr callback that is not useful anymore. Signed-off-by: Alexandre Bailon --- drivers/dma/cppi41.c | 4 +--- 1 file changed, 1 insertion(+), 3

[PATCH] usb: add CONFIG_USB_PCI for system have both PCI HW and non-PCI based USB HW

From: yuan linyu a lot of embeded system SOC (e.g. freescale T2080) have both PCI and USB modules. But USB module is controlled by registers directly, it have no relationship with PCI module. when say N here it will not build PCI related code in USB driver. Cc:

[PATCH] usb: dwc3: gadget: Fix system suspend/resume on TI platforms

On TI platforms (dra7, am437x), the DWC3_DSTS_DEVCTRLHLT bit is not set after the device controller is stopped via DWC3_DCTL_RUN_STOP. If we don't disconnect and stop the gadget, it stops working after a system resume with the trace below. There is no point in preventing gadget disconnect and

Re: [PATCH v13 06/12] usb: xhci: use bus->sysdev for DMA configuration

Hi, Roger Quadros writes: Why are we using sysdev to read DT property? We should be using the XHCI device (>dev) here, no? >>> >>> If I remember correctly, this is one of the cases where pdev does not >>> have a device node attached to it because it

Re: [PATCH 2/3] usb: dwc3: use BIT() macro where possible

Hi, Roger Quadros writes: > To avoid checkpatch warnings with new patches let's > start using the BIT() macro wherever possible. > > Signed-off-by: Roger Quadros > --- > drivers/usb/dwc3/core.h | 192 > +-- >

[PATCH 3/3] usb: otg-fsm: Prevent build warning "VDBG" redefined

If usb/otg-fsm.h and usb/composite.h are included together then it results in the build warning [1]. Prevent that by defining VDBG locally. Also get rid of MPC_LOC which doesn't seem to be used by anyone. [1] - warning fixed by this patch: In file included from drivers/usb/dwc3/core.h:33,

[PATCH 1/3] usb: dwc3-omap: Fix missing break in dwc3_omap_set_mailbox()

We need to break from all cases if we want to treat each one of them separately. Reported-by: Gustavo A. R. Silva Fixes: d2728fb3e01f ("usb: dwc3: omap: Pass VBUS and ID events transparently") Cc: #v4.8+ Signed-off-by: Roger Quadros

[PATCH 2/3] usb: dwc3: use BIT() macro where possible

To avoid checkpatch warnings with new patches let's start using the BIT() macro wherever possible. Signed-off-by: Roger Quadros --- drivers/usb/dwc3/core.h | 192 +-- drivers/usb/dwc3/dwc3-omap.c | 48 +--

[PATCH 0/3] usb: dwc3: trivial fixes.

Hi Felipe, These are some trivial fixes. First patch is tagged for stable. You might want to pick it up for v4.11. Thanks. cheers, -roger Roger Quadros (3): usb: dwc3-omap: Fix missing break in dwc3_omap_set_mailbox() usb: dwc3: use BIT() macro where possible usb: otg-fsm: Prevent build

[PATCH 1/2] USB: serial: io_edgeport: drop io-tables header file

Move the driver device-id tables and usb-serial driver definitions to the source file where they are expected to be found. Signed-off-by: Johan Hovold --- drivers/usb/serial/io_edgeport.c | 217 +++- drivers/usb/serial/io_tables.h | 232

[PATCH 2/2] USB: serial: keyspan: drop header file

Move all declarations and definitions in keyspan.h to keyspan.c, which is the only place were they are used. This specifically moves the driver device-id tables and usb-serial driver definitions to the source file where they are expected to be found. While at it, fix up some multi-line comments

Re: [PATCH v13 06/12] usb: xhci: use bus->sysdev for DMA configuration

+Felipe, On 15/02/17 10:51, Peter Chen wrote: > On Wed, Feb 15, 2017 at 10:18:03AM +0200, Roger Quadros wrote: >> Peter, >> >> On 15/02/17 03:35, Peter Chen wrote: >>> On Tue, Feb 14, 2017 at 01:58:40PM +0100, Arnd Bergmann wrote: On Tue, Feb 14, 2017 at 1:26 PM, Roger Quadros

Re: How to get related device pointer via DT?

On Wed, Feb 15, 2017 at 02:21:55AM +, Yoshihiro Shimoda wrote: > Hi, > > I would like to get a related device pointer on usb EHCI drivers (or USB > framework) > because related device (e.g. OHCI or UHCI, called "companion controllers") > has to > finish resuming. I discussed this topic with

Re: [PATCH] usb: class: remove logically dead code

Am Dienstag, den 14.02.2017, 21:10 -0600 schrieb Gustavo A. R. Silva: > Remove logically dead code. > 'cntr' is always equal to zero when the following line of code is > executed: > rv = cntr ? cntr : -EAGAIN; > > Addresses-Coverity-ID: 113227 > Signed-off-by: Gustavo A. R. Silva

[PATCH v2] HID: hiddev: allocate minor number hiddev's USB interface is bound to

When HID device connected to the PC, HID device driver announces which driver is loaded with a kernel info message. In this case, hiddev's minor number is always '0' even though hiddev's real minor number is not zero. To display hiddev with minor number asked from usb core, we need to fill

Re: [PATCH 1/6] usb: xhci: add xhci_log_cmd trace events

Hi, On 02/15/2017 04:56 PM, Felipe Balbi wrote: > Hi, > > Lu Baolu writes: >>> Lu Baolu writes: diff --git a/drivers/usb/host/xhci-trace.h b/drivers/usb/host/xhci-trace.h index 1ac2cdf..c31eeaf 100644 ---

Re: [PATCH 0/4 linux-next] usb: gadget: udc: atmel: Endpoint allocation scheme fixes

Le 14/02/2017 à 17:09, cristian.bir...@microchip.com a écrit : > From: Cristian Birsan > > This patch series provides fixes, based on the feedback received on the > mailing list, for > the following: > - fifo table parameters validation against device tree

Re: [PATCH] usb: class: remove logically dead code

On Tue, Feb 14, 2017 at 09:10:52PM -0600, Gustavo A. R. Silva wrote: > Remove logically dead code. > 'cntr' is always equal to zero when the following line of code is executed: > rv = cntr ? cntr : -EAGAIN; > > Addresses-Coverity-ID: 113227 > Signed-off-by: Gustavo A. R. Silva

Re: [PATCH 1/6] usb: xhci: add xhci_log_cmd trace events

Hi, Lu Baolu writes: >> Lu Baolu writes: >>> diff --git a/drivers/usb/host/xhci-trace.h b/drivers/usb/host/xhci-trace.h >>> index 1ac2cdf..c31eeaf 100644 >>> --- a/drivers/usb/host/xhci-trace.h >>> +++ b/drivers/usb/host/xhci-trace.h >>> @@

Re: [PATCH v13 06/12] usb: xhci: use bus->sysdev for DMA configuration

On Wed, Feb 15, 2017 at 10:18:03AM +0200, Roger Quadros wrote: > Peter, > > On 15/02/17 03:35, Peter Chen wrote: > > On Tue, Feb 14, 2017 at 01:58:40PM +0100, Arnd Bergmann wrote: > >> On Tue, Feb 14, 2017 at 1:26 PM, Roger Quadros wrote: > >>> On 14/02/17 13:44, Arnd Bergmann

Re: [PATCH 2/6] usb: xhci: enhance xhci_log_ctx trace events

Hi, On 02/15/2017 04:00 PM, Felipe Balbi wrote: > Hi, > > Lu Baolu writes: >> XHCI driver has defined xhci_log_ctx trace events to trace >> the change of an xhci input or output context. This patch >> extends the trace class of xhci_log_ctx to print out the >> contents

Re: [PATCH 1/6] usb: xhci: add xhci_log_cmd trace events

Hi, On 02/15/2017 03:58 PM, Felipe Balbi wrote: > Hi, > > Lu Baolu writes: >> diff --git a/drivers/usb/host/xhci-trace.h b/drivers/usb/host/xhci-trace.h >> index 1ac2cdf..c31eeaf 100644 >> --- a/drivers/usb/host/xhci-trace.h >> +++ b/drivers/usb/host/xhci-trace.h >> @@

Re: [PATCH v13 06/12] usb: xhci: use bus->sysdev for DMA configuration

Peter, On 15/02/17 03:35, Peter Chen wrote: > On Tue, Feb 14, 2017 at 01:58:40PM +0100, Arnd Bergmann wrote: >> On Tue, Feb 14, 2017 at 1:26 PM, Roger Quadros wrote: >>> On 14/02/17 13:44, Arnd Bergmann wrote: On Tue, Feb 14, 2017 at 11:36 AM, Roger Quadros

[PATCH] usb: musb: cppi_dma.c: use DIV_ROUND_UP macro in cppi_next_(r|t)x_segment()

DIV_ROUND_UP is bit useful than series of "/" and "%" operations. Replace "/%" sequence with DIV_ROUND_UP macro. Signed-off-by: Ivan Safonov --- drivers/usb/musb/cppi_dma.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git

Re: [PATCH 2/6] usb: xhci: enhance xhci_log_ctx trace events

Hi, Lu Baolu writes: > XHCI driver has defined xhci_log_ctx trace events to trace > the change of an xhci input or output context. This patch > extends the trace class of xhci_log_ctx to print out the > contents of a context block in a human readable way. > > This