RE: [Xen-devel] [PATCH 29/29] drivers, xen: convert grant_map.users from atomic_t to refcount_t

> On 03/08/2017 08:49 AM, Reshetova, Elena wrote: > >> On 03/06/2017 09:21 AM, Elena Reshetova wrote: > >>> refcount_t type and corresponding API should be > >>> used instead of atomic_t when the variable is used as > >>> a reference counter. This allows to avoid accidental > >>> refcounter

RE: [PATCH 22/29] drivers, scsi: convert iscsi_task.refcount from atomic_t to refcount_t

> On Mon, Mar 06, 2017 at 04:21:09PM +0200, Elena Reshetova wrote: > > refcount_t type and corresponding API should be > > used instead of atomic_t when the variable is used as > > a reference counter. This allows to avoid accidental > > refcounter overflows that might lead to use-after-free > >

Re: [PATCH 1/3] usb: dwc3-omap: Fix missing break in dwc3_omap_set_mailbox()

Felipe, On 15/02/17 13:38, Roger Quadros wrote: > We need to break from all cases if we want to treat > each one of them separately. > > Reported-by: Gustavo A. R. Silva > Fixes: d2728fb3e01f ("usb: dwc3: omap: Pass VBUS and ID events transparently") > Cc:

Re: [PATCH v5 04/19] net: e100: Replace PCI pool old API

On Wed, Mar 08, 2017 at 02:40:25PM -0800, Jeff Kirsher wrote: > On Wed, 2017-03-08 at 17:19 +0100, Romain Perier wrote: > > The PCI pool API is deprecated. This commit replaces the PCI pool old > > API by the appropriate function with the DMA pool API. > > > > Signed-off-by: Romain Perier

[PATCH] usb: host: xhci-plat: Fix timeout on removal of hot pluggable xhci controllers

Upstream commit 98d74f9ceaef ("xhci: fix 10 second timeout on removal of PCI hotpluggable xhci controllers") fixes a problem with hot pluggable PCI xhci controllers which can result in excessive timeouts, to the point where the system reports a deadlock. The same problem is seen with hot

Re: [PATCH v19 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

Hi, On 9 March 2017 at 09:50, Jun Li wrote: > Hi, > >> -Original Message- >> From: Baolin Wang [mailto:baolin.w...@linaro.org] >> Sent: Tuesday, March 07, 2017 5:39 PM >> To: NeilBrown >> Cc: Felipe Balbi ; Greg KH

Re: [PATCH] lvs: fix race condition in disconnect handling

On Mon, Feb 20, 2017 at 03:38:42PM +0100, Oliver Neukum wrote: > There is a small window during which the an URB may > remain active after disconnect has returned. If in that case > already freed memory may be accessed and executed. > > The fix is to poison the URB befotre the work is flushed. >

Re: [solution] usb: gadget: uvc: configfs: fails to enumerate in HOST

Dne 8.3.2017 v 11:46 Ganesh Biradar napsal(a): > Hi Petr, > > I saw your patch and at the same time I saw Laurent suggestion. > > I have tried both patches both are working but I'm going with Laurent > suggestion > > UVC_ATTR(f_uvc_opts_, cname, cname). > That's OK, they are equivalent (as I

[PATCH] usb: hub: Fix error loop seen after hub communication errors

While stress testing a usb controller using a bind/unbind looop, the following error loop was observed. usb 7-1.2: new low-speed USB device number 3 using xhci-hcd usb 7-1.2: hub failed to enable device, error -108 usb 7-1-port2: cannot disable (err = -22) usb 7-1-port2: couldn't allocate

Re: [PATCH v17 2/3] usb: USB Type-C connector class

On Wed, Mar 08, 2017 at 06:44:47AM -0800, Guenter Roeck wrote: > On 03/07/2017 10:50 PM, Peter Chen wrote: > > > You mean type-C trigger an ACPI event, and this ACPI event can notify > related USB controller driver doing role switch? > >>> > >>>No (firmware programs the dual-role

RE: [PATCH v19 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

Hi, > -Original Message- > From: Baolin Wang [mailto:baolin.w...@linaro.org] > Sent: Tuesday, March 07, 2017 5:39 PM > To: NeilBrown > Cc: Felipe Balbi ; Greg KH ; > Sebastian Reichel ; Dmitry Eremin-Solenikov

[PATCH] e-mail update in drivers/usb/storage/unusual_devs.h

Updates the e-mail address of Phillip Potter, updater of the Nokia 6288 entry in drivers/usb/storage/unusual_devs.h Signed-off-by: Phillip Potter --- --- a/drivers/usb/storage/unusual_devs.h2017-03-08 21:47:45.878007300 + +++

Re: [PATCH v5 04/19] net: e100: Replace PCI pool old API

On Wed, 2017-03-08 at 17:19 +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commit replaces the PCI pool old > API by the appropriate function with the DMA pool API. > > Signed-off-by: Romain Perier > Acked-by: Peter Senna Tschudin

Re: [PATCH] e-mail address change in drivers/usb/storage/unusual_devs.h

Dear Alan, Apologies. I will make the necessary changes and resubmit. Regards, Phil Potter On 08/03/2017 20:04, Alan Stern wrote: On Wed, 8 Mar 2017, Phillip Potter wrote: Dear all, Just submitting a very minor patch to update my e-mail address in this file - I sent a patch years ago to

Requeste to add Quectel EC21 in USB:serial:qcserial

Hi guys, I’w working with a Quectel EC21 modem and i ran into an issue that the qcserial driver is not getting installed for it. Previously i was working with the Quectel EC20 which was working properly but the cell carrier requested LTE Cat 1 modem so that’s why the switch to EC21. Can you

Re: [PATCH 1/3] usb: orion-echi: Add support for the Armada 3700

Hello, On Wed, 8 Mar 2017 17:24:21 +0100, Gregory CLEMENT wrote: > Signed-off-by: jinghua I think you need a full first name + last name for this Signed-off-by. Best regards, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering

Re: Dell Inspiron 5558/0VNM2T hangs at resume from suspend when USB 3 is enabled

Hi Greg, On Wed, Mar 8, 2017 at 5:15 PM, Greg KH wrote: > On Wed, Mar 08, 2017 at 03:49:19PM -0300, Diego Viola wrote: >> It hangs on resume from suspend if I have USB 3.0 enabled on the BIOS, >> it works fine with ehci_hcd or USB 2.0. >> >> The way I reproduce the

Re: Dell Inspiron 5558/0VNM2T hangs at resume from suspend when USB 3 is enabled

On Wed, Mar 08, 2017 at 03:49:19PM -0300, Diego Viola wrote: > It hangs on resume from suspend if I have USB 3.0 enabled on the BIOS, > it works fine with ehci_hcd or USB 2.0. > > The way I reproduce the problem is with this command: > > $ i3lock && systemctl suspend > > This is what I see on

Re: Dell Inspiron 5558/0VNM2T hangs at resume from suspend when USB 3 is enabled

On Wed, Mar 8, 2017 at 3:49 PM, Diego Viola wrote: > It hangs on resume from suspend if I have USB 3.0 enabled on the BIOS, > it works fine with ehci_hcd or USB 2.0. > > The way I reproduce the problem is with this command: > > $ i3lock && systemctl suspend > > This is what

Re: [PATCH] e-mail address change in drivers/usb/storage/unusual_devs.h

On Wed, 8 Mar 2017, Phillip Potter wrote: > Dear all, > > Just submitting a very minor patch to update my e-mail address in this file - > I sent > a patch years ago to update the listed firmware version to make newer > versions of the > Nokia 6288 mountable as mass storage devices. I hope my

Re: usb: gadget: uvc: configfs: fails to enumerate in HOST

Hi Felipe, I'm using TI latest vision sdk which has support for 4.4 kernel. i'm not getting much help from TI e2e that's why i am asking here. can't try v4.10 or any other kernel as it has dependencies with respect to SDK. regards, grbesd1 On Wed, Mar 8, 2017 at 2:54 PM, Felipe Balbi

Re: usb: gadget: uvc: configfs: fails to enumerate in HOST

On Wed, Mar 08, 2017 at 11:24:16PM +0530, Ganesh Biradar wrote: > Hi Bin, > > Just wanted to clarify, > > I have created already a thread(more then 2 weeks ago) which was > based on dual configuration support(mass storage and uvc > device(g_webcam)). in which i asked question based on 3.14

Re: usb: gadget: uvc: configfs: fails to enumerate in HOST

Hi Bin, Just wanted to clarify, I have created already a thread(more then 2 weeks ago) which was based on dual configuration support(mass storage and uvc device(g_webcam)). in which i asked question based on 3.14 kernel but confgifs support for uvc was added in 4.0 kernel. so i updated to

[PATCH] usb: hub: Fix crash after failure to read BOS descriptor

If usb_get_bos_descriptor() returns an error, usb->bos will be NULL. Nevertheless, it is dereferenced unconditionally in hub_set_initial_usb2_lpm_policy() if usb2_hw_lpm_capable is set. This results in a crash. usb 5-1: unable to get BOS descriptor ... Unable to handle kernel NULL pointer

Re: [PATCH] usb: musb: dsps: fix iounmap in error and exit paths

On Wed, Mar 08, 2017 at 08:02:59PM +0100, Johan Hovold wrote: > On Wed, Mar 08, 2017 at 10:24:31AM -0600, Bin Liu wrote: > > Cleanly iounmap the pointer in error and exit paths. > > > > Signed-off-by: Bin Liu > > --- > > drivers/usb/musb/musb_dsps.c | 5 - > > 1 file changed,

Re: [PATCH] usb: musb: dsps: fix iounmap in error and exit paths

On Wed, Mar 08, 2017 at 10:24:31AM -0600, Bin Liu wrote: > Cleanly iounmap the pointer in error and exit paths. > > Signed-off-by: Bin Liu > --- > drivers/usb/musb/musb_dsps.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git

[PATCH] usb: musb: fix possible spinlock deadlock

The DSPS glue calls del_timer_sync() in its musb_platform_disable() implementation, which requires the caller to not hold a lock. But musb_remove() calls musb_platform_disable() will musb->lock held. This could causes spinlock deadlock. So change musb_remove() to call musb_platform_disable()

Dell Inspiron 5558/0VNM2T hangs at resume from suspend when USB 3 is enabled

It hangs on resume from suspend if I have USB 3.0 enabled on the BIOS, it works fine with ehci_hcd or USB 2.0. The way I reproduce the problem is with this command: $ i3lock && systemctl suspend This is what I see on the screen when it hangs:

Re: [PATCH 22/29] drivers, scsi: convert iscsi_task.refcount from atomic_t to refcount_t

On Mon, Mar 06, 2017 at 04:21:09PM +0200, Elena Reshetova wrote: > refcount_t type and corresponding API should be > used instead of atomic_t when the variable is used as > a reference counter. This allows to avoid accidental > refcounter overflows that might lead to use-after-free > situations. >

[PATCH] usb: musb: dsps: fix iounmap in error and exit paths

Cleanly iounmap the pointer in error and exit paths. Signed-off-by: Bin Liu --- drivers/usb/musb/musb_dsps.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c index 7c047c4a2565..c84f32d0dd4d 100644

Re: Subject: [PATCH v4] USB:Core: BugFix: Proper handling of Race Condition when two USB class drivers try to call init_usb_class simultaneously

On Tue, Mar 07, 2017 at 04:35:37AM +, Ajay Kaher wrote: >   >   >   > > On Fri, 3 Mar 2017, Ajay Kaher wrote: > >  > > > > usb_class->kref is not accessible outside the file.c > > > > as usb_class is _static_ inside the file.c and > > > > pointer of usb_class->kref is not passed anywhere. > >

Re: [Xen-devel] [PATCH 29/29] drivers, xen: convert grant_map.users from atomic_t to refcount_t

On 03/08/2017 08:49 AM, Reshetova, Elena wrote: >> On 03/06/2017 09:21 AM, Elena Reshetova wrote: >>> refcount_t type and corresponding API should be >>> used instead of atomic_t when the variable is used as >>> a reference counter. This allows to avoid accidental >>> refcounter overflows that

Re: [PATCH 2/3] usb: host: Allow to build ehci orion with mvebu SoCs

On Wed, Mar 08, 2017 at 05:24:22PM +0100, Gregory CLEMENT wrote: > The mvebu ARM64 SoCs no more select PLAT_ORION but some of them as the > Armada 37xx use the EHCI orion controller. This patch allow to build > the driver when ARCH_MVEBU is selected. The mvebu ARM64 SoCs no longer selects

Re: [PATCH 1/3] usb: orion-echi: Add support for the Armada 3700

Hi Gregory > - Add a new compatoble string for the Armada 3700 SoCs compatible > > - add sbuscfg support for orion usb controller driver. For the SoCs > without hlock, need to program BAWR/BARD/AHBBRST fields in the sbuscfg > register to guarantee the AHB master's burst would not overrun

Re: [PATCH] usb: musb: fix possible spinlock deadlock

* Bin Liu [170308 08:26]: > The DSPS glue calls del_timer_sync() in its musb_platform_disable() > implementation, which requires the caller to not hold a lock. But > musb_remove() calls musb_platform_disable() will musb->lock held. This > could causes spinlock deadlock. > > So

Re: [PATCH 2/3] usb: host: Allow to build ehci orion with mvebu SoCs

Hi Andrew, On mer., mars 08 2017, Andrew Lunn wrote: > On Wed, Mar 08, 2017 at 05:24:22PM +0100, Gregory CLEMENT wrote: >> The mvebu ARM64 SoCs no more select PLAT_ORION but some of them as the >> Armada 37xx use the EHCI orion controller. This patch allow to build >> the

Re: [PATCH 1/3] usb: orion-echi: Add support for the Armada 3700

Hi Andrew, On mer., mars 08 2017, Andrew Lunn wrote: > Hi Gregory [...] Thanks for your comments I will fix the typos and the wording. >> +#define USB_SBUSCFG 0x90 >> +#define USB_SBUSCFG_BAWR0x6 >> +#define USB_SBUSCFG_BARD0x3 >>

[PATCH] e-mail address change in drivers/usb/storage/unusual_devs.h

Dear all, Just submitting a very minor patch to update my e-mail address in this file - I sent a patch years ago to update the listed firmware version to make newer versions of the Nokia 6288 mountable as mass storage devices. I hope my patch is in the right format, I've tried to pay

[PATCH v5 04/19] net: e100: Replace PCI pool old API

The PCI pool API is deprecated. This commit replaces the PCI pool old API by the appropriate function with the DMA pool API. Signed-off-by: Romain Perier Acked-by: Peter Senna Tschudin Tested-by: Peter Senna Tschudin

[PATCH v5 02/19] dmaengine: pch_dma: Replace PCI pool old API

The PCI pool API is deprecated. This commit replaces the PCI pool old API by the appropriate function with the DMA pool API. Signed-off-by: Romain Perier Acked-by: Peter Senna Tschudin Tested-by: Peter Senna Tschudin

[PATCH v5 03/19] IB/mthca: Replace PCI pool old API

The PCI pool API is deprecated. This commit replaces the PCI pool old API by the appropriate function with the DMA pool API. Signed-off-by: Romain Perier Acked-by: Peter Senna Tschudin Tested-by: Peter Senna Tschudin

[PATCH v5 00/19] Replace PCI pool by DMA pool API

by the dma pool API and remove the defines. Changes in v5: - Re-worded the cover letter (remove sentence about checkpatch.pl) - Rebased series onto next-20170308 - Fix typos in commit message - Added Acked-by Tags Changes in v4: - Rebased series onto next-20170301 - Removed patch 20/20: checks done

[PATCH v5 01/19] block: DAC960: Replace PCI pool old API

The PCI pool API is deprecated. This commit replaces the PCI pool old API by the appropriate function with the DMA pool API. Signed-off-by: Romain Perier Acked-by: Peter Senna Tschudin Tested-by: Peter Senna Tschudin

[PATCH v5 06/19] mlx5: Replace PCI pool old API

The PCI pool API is deprecated. This commit replaces the PCI pool old API by the appropriate function with the DMA pool API. Signed-off-by: Romain Perier Reviewed-by: Peter Senna Tschudin --- drivers/net/ethernet/mellanox/mlx5/core/cmd.c

[PATCH v5 05/19] mlx4: Replace PCI pool old API

The PCI pool API is deprecated. This commit replaces the PCI pool old API by the appropriate function with the DMA pool API. Signed-off-by: Romain Perier Acked-by: Peter Senna Tschudin Tested-by: Peter Senna Tschudin

[PATCH 0/3] Add EHCI support for Armada 37xx

Hi, The EHCI controller in the Armada 37xx SoCs is the one used on many other mvebu SoCs such as the orion5x, the kirkwood, or the armada. However, for Armada 37xx an extra initialization step is needed: this is the purpose of the first patch. The second patch allows to build the driver for the

[PATCH v5 07/19] wireless: ipw2200: Replace PCI pool old API

The PCI pool API is deprecated. This commit replaces the PCI pool old API by the appropriate function with the DMA pool API. Signed-off-by: Romain Perier Reviewed-by: Peter Senna Tschudin --- drivers/net/wireless/intel/ipw2x00/ipw2200.c |

[PATCH 3/3] ARM64: dts: marvell: armada-37xx: Add USB2 node

Armada 37xx SoC embedded an EHCI controller. This patch adds the device tree node enabling its support. Signed-off-by: Gregory CLEMENT --- arch/arm64/boot/dts/marvell/armada-3720-db.dts | 6 ++ arch/arm64/boot/dts/marvell/armada-37xx.dtsi | 7 +++ 2

[PATCH 2/3] usb: host: Allow to build ehci orion with mvebu SoCs

The mvebu ARM64 SoCs no more select PLAT_ORION but some of them as the Armada 37xx use the EHCI orion controller. This patch allow to build the driver when ARCH_MVEBU is selected. Signed-off-by: Gregory CLEMENT --- drivers/usb/host/Kconfig | 2 +- 1 file

[PATCH 1/3] usb: orion-echi: Add support for the Armada 3700

From: jinghua - Add a new compatoble string for the Armada 3700 SoCs - add sbuscfg support for orion usb controller driver. For the SoCs without hlock, need to program BAWR/BARD/AHBBRST fields in the sbuscfg register to guarantee the AHB master's burst would not overrun

[PATCH v2 0/5] USB: serial: ftdi_sio: latency timer and other stuff

Some patches to skip accessing the FTDI latency timer on chips that don't support it, detect "BM" chips with iSerialNumber bug, validate written device attribute values, and allow hex and octal "event_char" values. This is v2 of the patch series, incorporating changes suggested by Johan. The

[PATCH v2 4/5] USB: serial: ftdi_sio: only allow valid event_char values

The "event_char" device attribute value, when written, is interpreted as an enable bit in bit 8, and an "event character" in bits 7 to 0. Return an error -EINVAL for out-of-range values. Use kstrtouint() to parse the integer instead of the obsolete simple_strtoul(). Signed-off-by: Ian Abbott

[PATCH v2 3/5] USB: serial: ftdi_sio: only allow valid latency timer values

Valid latency timer values are between 1 ms and 255 ms in 1 ms steps. The store function for the "latency_timer" device attribute currently allows any value, although only the lower 16 bits will be sent to the device, and the device only stores the lower 8 bits. The hardware appears to accept the

[PATCH v2 1/5] USB: serial: ftdi_sio: don't access latency timer on old chips

The latency timer was introduced with the FT232BM and FT245BM chips. Do not bother attempting to read or write it for older chip versions. Signed-off-by: Ian Abbott --- v2: - No change. --- drivers/usb/serial/ftdi_sio.c | 6 ++ 1 file changed, 6 insertions(+) diff --git

[PATCH v2 5/5] USB: serial: ftdi_sio: allow other bases for "event_char"

The 'store' function for the "event_char" device attribute currently expects a base 10 value. The value is composed of an enable bit in bit 8 and an 8-bit "event character" code in bits 7 to 0. It seems reasonable to allow hexadecimal and octal numbers to be written to the device attribute in

[PATCH v2 2/5] USB: serial: ftdi_sio: detect BM chip with iSerialNumber bug

If a BM type chip has iSerialNumber set to 0 in its EEPROM, an incorrect value is read from the bcdDevice field of the USB descriptor, making it look like an AM type chip. Attempt to correct this in ftdi_determine_type() by attempting to read the latency timer for an AM type chip if it has

[solution] usb: gadget: uvc: configfs: fails to enumerate in HOST

Hi, I'm not subscribed to linux-usb mailing list so I found your post just by a pure luck. I've sent the patch for: streaming_maxburst streaming_maxpacket streaming_interval problem earlier this week. Try this patch [1]: BTW please CC me if you will have another discusion in your

[PATCH v5 09/19] scsi: csiostor: Replace PCI pool old API

The PCI pool API is deprecated. This commit replaces the PCI pool old API by the appropriate function with the DMA pool API. It also updates the name of some variables and the content of comments, accordingly. Signed-off-by: Romain Perier Reviewed-by: Peter Senna

[PATCH v5 08/19] scsi: be2iscsi: Replace PCI pool old API

The PCI pool API is deprecated. This commit replaces the PCI pool old API by the appropriate function with the DMA pool API. Signed-off-by: Romain Perier Acked-by: Peter Senna Tschudin Tested-by: Peter Senna Tschudin

[PATCH v5 10/19] scsi: lpfc: Replace PCI pool old API

The PCI pool API is deprecated. This commit replaces the PCI pool old API by the appropriate function with the DMA pool API. It also updates some comments, accordingly. Signed-off-by: Romain Perier Reviewed-by: Peter Senna Tschudin ---

[PATCH v5 13/19] scsi: mvsas: Replace PCI pool old API

The PCI pool API is deprecated. This commit replaces the PCI pool old API by the appropriate function with the DMA pool API. Signed-off-by: Romain Perier Reviewed-by: Peter Senna Tschudin --- drivers/scsi/mvsas/mv_init.c | 6 +++---

[PATCH v5 12/19] scsi: mpt3sas: Replace PCI pool old API

The PCI pool API is deprecated. This commit replaces the PCI pool old API by the appropriate function with the DMA pool API. Signed-off-by: Romain Perier Reviewed-by: Peter Senna Tschudin --- drivers/scsi/mpt3sas/mpt3sas_base.c | 73

[PATCH v5 14/19] scsi: pmcraid: Replace PCI pool old API

The PCI pool API is deprecated. This commit replaces the PCI pool old API by the appropriate function with the DMA pool API. Signed-off-by: Romain Perier Acked-by: Peter Senna Tschudin Tested-by: Peter Senna Tschudin

[PATCH v5 11/19] scsi: megaraid: Replace PCI pool old API

The PCI pool API is deprecated. This commit replaces the PCI pool old API by the appropriate function with the DMA pool API. Signed-off-by: Romain Perier Reviewed-by: Peter Senna Tschudin Acked-by: Sumit Saxena

[PATCH v5 18/19] usb: host: Remove remaining pci_pool in comments

This replaces remaining occurences of pci_pool by dma_pool, as this is the new API that could be used for that purpose. Signed-off-by: Romain Perier Reviewed-by: Peter Senna Tschudin --- drivers/usb/host/ehci-hcd.c | 2 +-

[PATCH v5 19/19] PCI: Remove PCI pool macro functions

Now that all the drivers use dma pool API, we can remove the macro functions for PCI pool. Signed-off-by: Romain Perier Reviewed-by: Peter Senna Tschudin --- include/linux/pci.h | 9 - 1 file changed, 9 deletions(-) diff --git

[PATCH v5 16/19] usb: gadget: net2280: Replace PCI pool old API

The PCI pool API is deprecated. This commit replaces the PCI pool old API by the appropriate function with the DMA pool API. Signed-off-by: Romain Perier Acked-by: Peter Senna Tschudin Tested-by: Peter Senna Tschudin

[PATCH v5 17/19] usb: gadget: pch_udc: Replace PCI pool old API

The PCI pool API is deprecated. This commit replaces the PCI pool old API by the appropriate function with the DMA pool API. Signed-off-by: Romain Perier Reviewed-by: Peter Senna Tschudin Acked-by: Felipe Balbi

[PATCH v5 15/19] usb: gadget: amd5536udc: Replace PCI pool old API

The PCI pool API is deprecated. This commit replaces the PCI pool old API by the appropriate function with the DMA pool API. Signed-off-by: Romain Perier Acked-by: Peter Senna Tschudin Tested-by: Peter Senna Tschudin

[PATCH 2/2] usb: gadget: f_uvc: Sanity check wMaxPacketSize for SuperSpeed

As per USB3.0 Specification "Table 9-20. Standard Endpoint Descriptor", for interrupt and isochronous endpoints, wMaxPacketSize must be set to 1024 if the endpoint defines bMaxBurst to be greater than zero. Signed-off-by: Roger Quadros --- drivers/usb/gadget/function/f_uvc.c | 8

Re: [PATCH 0/2] usb: gadget: f_uvc: SuperSpeed fixes

Hi Roger, Thank you for the patches. On Wednesday 08 Mar 2017 16:05:42 Roger Quadros wrote: > Hi Laurent & Felipe, > > These are some fixes for SuperSpeed case. For both patches, Reviewed-by: Laurent Pinchart > -- > cheers, > -roger > > Roger Quadros (2):

[PATCH 0/2] usb: gadget: f_uvc: SuperSpeed fixes

Hi Laurent & Felipe, These are some fixes for SuperSpeed case. -- cheers, -roger Roger Quadros (2): usb: gadget: f_uvc: Fix SuperSpeed companion descriptor's wBytesPerInterval usb: gadget: f_uvc: Sanity check wMaxPacketSize for SuperSpeed drivers/usb/gadget/function/f_uvc.c | 10

Re: [PATCH 6/6] USB: serial: ftdi_sio: allow other bases for "event_char"

On Wed, Mar 08, 2017 at 01:58:51PM +, Ian Abbott wrote: > On 02/03/17 14:37, Johan Hovold wrote: > > On Tue, Feb 28, 2017 at 12:51:28PM +, Ian Abbott wrote: > >> The 'store' function for the "event_char" device attribute currently > >> expects a base 10 value. The value is composed of an

Re: [PATCH 21/29] drivers, s390: convert fc_fcp_pkt.ref_cnt from atomic_t to refcount_t

On 03/08/2017 02:48 PM, Reshetova, Elena wrote: On 03/06/2017 03:21 PM, Elena Reshetova wrote: refcount_t type and corresponding API should be used instead of atomic_t when the variable is used as a reference counter. This allows to avoid accidental refcounter overflows that might lead to

Re: [PATCH v17 2/3] usb: USB Type-C connector class

On 03/07/2017 10:50 PM, Peter Chen wrote: You mean type-C trigger an ACPI event, and this ACPI event can notify related USB controller driver doing role switch? No (firmware programs the dual-role hw/registers), but never mind. That could be the case. If it is correct, there is a notifier

[PATCH 1/2] usb: gadget: f_uvc: Fix SuperSpeed companion descriptor's wBytesPerInterval

The streaming_maxburst module parameter is 0 offset (0..15) so we must add 1 while using it for wBytesPerInterval calculation for the SuperSpeed companion descriptor. Without this host uvcvideo driver will always see the wrong wBytesPerInterval for SuperSpeed uvc gadget and may not find a

Re: [PATCH 4/6] USB: serial: ftdi_sio: only allow valid event_char values

On Wed, Mar 08, 2017 at 01:46:12PM +, Ian Abbott wrote: > On 02/03/17 14:29, Johan Hovold wrote: > > On Tue, Feb 28, 2017 at 12:51:26PM +, Ian Abbott wrote: > >> The "event_char" device attribute value, when written, is interpreted as > >> an enable bit in bit 8, and an "event character"

Re: [PATCH 2/6] USB: serial: ftdi_sio: detect BM chip with iSerialNumber bug

On 02/03/17 14:17, Johan Hovold wrote: On Tue, Feb 28, 2017 at 12:51:24PM +, Ian Abbott wrote: If a BM type chip has iSerialNumber set to 0 in its EEPROM, an incorrect value is read from the bcdDevice field of the USB descriptor, making it look like an AM type chip. Attempt to correct this

Re: [PATCH v17 2/3] usb: USB Type-C connector class

On Tue, Mar 07, 2017 at 11:30:54PM +0100, Mats Karrman wrote: > > > So, both the DP controller and the USB PD phy are I2C devices, and now I > > > have to make them both > > > attach to the AM bus as well? > > The DP controller would provide the driver and the USB PD phy > > (actually, the typec

[PATCH v2] HID: remove initial reading of reports at connect

It looks like a bunch of devices do not like to be polled for their reports at init time. When you look into the details, it seems that for those that are requiring the quirk HID_QUIRK_NO_INIT_REPORTS, the driver fails to retrieve part of the features/inputs while others (more generic) work. IMO,

RE: [PATCH 21/29] drivers, s390: convert fc_fcp_pkt.ref_cnt from atomic_t to refcount_t

> On 03/06/2017 03:21 PM, Elena Reshetova wrote: > > refcount_t type and corresponding API should be > > used instead of atomic_t when the variable is used as > > a reference counter. This allows to avoid accidental > > refcounter overflows that might lead to use-after-free > > situations. > >

RE: [Xen-devel] [PATCH 29/29] drivers, xen: convert grant_map.users from atomic_t to refcount_t

> On 03/06/2017 09:21 AM, Elena Reshetova wrote: > > refcount_t type and corresponding API should be > > used instead of atomic_t when the variable is used as > > a reference counter. This allows to avoid accidental > > refcounter overflows that might lead to use-after-free > > situations. > > >

Re: usb: gadget: uvc: configfs: fails to enumerate in HOST

On Wed, Mar 08, 2017 at 01:59:50PM +0200, Felipe Balbi wrote: > > Hi, > > (no top-posting, please) > > Ganesh Biradar writes: > > Hi Felipe, > > > > I'm using TI latest vision sdk which has support for 4.4 kernel. i'm > > not getting much help from TI e2e that's why i am

Re: [PATCH 6/6] USB: serial: ftdi_sio: allow other bases for "event_char"

On 02/03/17 14:37, Johan Hovold wrote: On Tue, Feb 28, 2017 at 12:51:28PM +, Ian Abbott wrote: The 'store' function for the "event_char" device attribute currently expects a base 10 value. The value is composed of an enable bit in bit 8 and an 8-bit "event character" code in bits 7 to 0.

Re: [PATCH 4/6] USB: serial: ftdi_sio: only allow valid event_char values

On 02/03/17 14:29, Johan Hovold wrote: On Tue, Feb 28, 2017 at 12:51:26PM +, Ian Abbott wrote: The "event_char" device attribute value, when written, is interpreted as an enable bit in bit 8, and an "event character" in bits 7 to 0. Return an error for out-of-range values. Signed-off-by:

Re: [PATCH 3/6] USB: serial: ftdi_sio: only allow valid latency timer values

On 02/03/17 14:22, Johan Hovold wrote: On Tue, Feb 28, 2017 at 12:51:25PM +, Ian Abbott wrote: Valid latency timer values are between 1 ms and 255 ms in 1 ms steps. The store function for the "latency_timer" device attribute currently allows any value, although only the lower 8-bits will be

Re: Implementing MSI support on my platform

On 07/03/2017 17:47, Mason wrote: > As suggested by Marc, I'm trying to adapt > drivers/pci/host/pcie-altera-msi.c > to my platform. For my own reference, I have enabled verbose XHCI debug logs. I have highlighted suspicious output with * [0.00] Booting Linux on physical CPU 0x0 [

[PATCH] usb: dwc3: gadget: make to increment req->remaining in all cases

Sometimes, we might get a completion for a TRB which is left with HWO bit. Even in these cases, we should increment req->remaining to properly report total transferred size. I noticed this while debuggin a separate problem seen with MSC tests from USBCV. Sometimes we would erroneously report a

Re: [PATCH RESEND^2] usb: gadget: udc: atmel: fix debug output

Hi, Arnd Bergmann writes: > The debug output now contains the wrong variable, as seen from the compiler > warning: > > drivers/usb/gadget/udc/atmel_usba_udc.c: In function 'usba_ep_enable': > drivers/usb/gadget/udc/atmel_usba_udc.c:632:550: error: 'ept_cfg' may be used >

Re: usb: gadget: uvc: configfs: fails to enumerate in HOST

Hi, (no top-posting, please) Ganesh Biradar writes: > Hi Felipe, > > I'm using TI latest vision sdk which has support for 4.4 kernel. i'm > not getting much help from TI e2e that's why i am asking here. can't > try v4.10 or any other kernel as it has dependencies with

RE: [PATCH] usb: dwc3: gadget: skip Set/Clear Halt when invalid

Hi, Felipe Balbi writes: >>> I've been looking at this and based on sniffer and dwc3 tracepoints, it >>> seems like dwc3 is behaving properly. The real issue seems to be that >>> g_mass_storage isn't queueing a new request to IN endpoint. >>> >>> I'll continue

USB3.0 regression on ipq806x

Hi list! I'm running into a USB3.0 regression on ipq806x hardware. Consider one physical USB port as one linux-4.9 xHCI HC. It comes with two USB busses with one logical USB port each. One high-speed port and one superspeed port port. ] ehci_hcd: USB 2.0 'Enhanced' Host Controller (EHCI)

RE: [PATCH] usb: dwc3: gadget: skip Set/Clear Halt when invalid

Hi, Felipe Balbi writes: >> Thinh Nguyen writes: drivers/usb/dwc3/gadget.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index

Re: [solution] usb: gadget: uvc: configfs: fails to enumerate in HOST

Hi Petr, I saw your patch and at the same time I saw Laurent suggestion. I have tried both patches both are working but I'm going with Laurent suggestion UVC_ATTR(f_uvc_opts_, cname, cname). I'm going with unofficial uvc-gadget. Before I can test usb uvc gadget not enumerating. Regards,

Re: [PATCH 1/2] usb: xhci-mtk: check hcc_params after adding primary hcd

On 08.03.2017 02:51, Chunfeng Yun wrote: On Tue, 2017-03-07 at 17:10 +0200, Mathias Nyman wrote: On 07.03.2017 05:32, Chunfeng Yun wrote: hcc_params is set in xhci_gen_setup() called from usb_add_hcd(), so checks the Maximum Primary Stream Array Size in the hcc_params register after adding

Re: [PATCH 08/29] drivers, md: convert mddev.active from atomic_t to refcount_t

On Wed, Mar 08, 2017 at 09:42:09AM +, Reshetova, Elena wrote: > > On Mon, Mar 06, 2017 at 04:20:55PM +0200, Elena Reshetova wrote: > > > refcount_t type and corresponding API should be > > > used instead of atomic_t when the variable is used as > > > a reference counter. This allows to avoid

RE: [PATCH 08/29] drivers, md: convert mddev.active from atomic_t to refcount_t

> On Mon, Mar 06, 2017 at 04:20:55PM +0200, Elena Reshetova wrote: > > refcount_t type and corresponding API should be > > used instead of atomic_t when the variable is used as > > a reference counter. This allows to avoid accidental > > refcounter overflows that might lead to use-after-free > >

RE: [PATCH 10/29] drivers, md: convert stripe_head.count from atomic_t to refcount_t

> On Mon, Mar 06, 2017 at 04:20:57PM +0200, Elena Reshetova wrote: > > refcount_t type and corresponding API should be > > used instead of atomic_t when the variable is used as > > a reference counter. This allows to avoid accidental > > refcounter overflows that might lead to use-after-free > >

RE: [PATCH] usb: dwc3: gadget: skip Set/Clear Halt when invalid

Hi Thinh, Thinh Nguyen writes: >> drivers/usb/dwc3/gadget.c | 5 + >> 1 file changed, 5 insertions(+) >> >> diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c >> index 6faf484e5dfc..0a664d8eba3f 100644 >> --- a/drivers/usb/dwc3/gadget.c >> +++

RE: [PATCH] usb: dwc3: gadget: skip Set/Clear Halt when invalid

Felipe Balbi writes: > Hi Thinh, > > Thinh Nguyen writes: >>> drivers/usb/dwc3/gadget.c | 5 + >>> 1 file changed, 5 insertions(+) >>> >>> diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c >>> index

  1   2   >