Dne 31.3.2017 v 11:01 Laurent Pinchart napsal(a):
> Hi Felipe and Petr,
>
> On Tuesday 28 Mar 2017 16:48:46 Felipe Balbi wrote:
>> Petr Cvek writes:
>>> Dne 7.3.2017 v 06:58 Laurent Pinchart napsal(a):
On Tuesday 07 Mar 2017 00:57:20 Petr Cvek wrote:
> Commit 76e0da34c7ce ("usb-gadget/uv
Commit 76e0da34c7ce ("usb-gadget/uvc: use per-attribute show and store
methods") caused a stringification of an undefined macro argument "aname",
so three UVC parameters (streaming_interval, streaming_maxpacket and
streaming_maxburst) were named "aname".
Fix the definition to use "cname", name of
There are several inconsistencies in the error handling code.
1. If clk_get() fails, it goes to clk_put().
2. If pdata->phy_init() fails, it does not disable u3d->clk.
3. In case of failure after stopping u3d, it does pdata->phy_deinit()
and clk_disable(u3d->clk) twice.
4. It ignores failures i
ping
Le 19/03/2017 à 18:03, Romain Perier a écrit :
> The current PCI pool API are simple macro functions direct expanded to
> the appropriate dma pool functions. The prototypes are almost the same
> and semantically, they are very similar. I propose to use the DMA pool
> API directly and get rid
On Thu, 30 Mar 2017 11:20:14 +0200
Markus Heiser wrote:
> @Jon: what do you think about a bulk conversion?
I'm a bit leery of it, to tell the truth. We're trying to create a
better set of kernel docs, and I'm far from convinced that dumping a
bunch of unloved stuff there in a mechanical way wil
On Thu, 30 Mar 2017, Oliver Neukum wrote:
> Am Donnerstag, den 30.03.2017, 11:55 -0400 schrieb Alan Stern:
> >
> > I'm pretty sure that usb-storage does not do this, at least, not when
> > operating in its normal Bulk-Only-Transport mode. It never tries to
> > read the results of an earlier tr
In order to improve usability a tiny bit, we will return strings that
match what our tracepoints return.
Signed-off-by: Felipe Balbi
---
drivers/usb/dwc3/debugfs.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/dwc3/debugfs.c b/drivers/usb/dwc3/debugfs.c
That helper can be used from our tracepoint interface with very minor
edits. Let's do so.
Signed-off-by: Felipe Balbi
---
drivers/usb/dwc3/debug.h | 28
drivers/usb/dwc3/debugfs.c | 27 ++-
drivers/usb/dwc3/trace.h | 31 +--
Instead of redecoding link state into a string, use our helper.
Signed-off-by: Felipe Balbi
---
drivers/usb/dwc3/debugfs.c | 47 +-
1 file changed, 1 insertion(+), 46 deletions(-)
diff --git a/drivers/usb/dwc3/debugfs.c b/drivers/usb/dwc3/debugfs.c
in
On March 31, 2017 3:27:59 PM CEST, Greg Ungerer wrote:
>On 31/03/17 18:48, Bjørn Mork wrote:
>
>>> +void usbnet_get_stats64(struct net_device *net, struct
>rtnl_link_stats64 *stats)
>>> +{
>>> + struct usbnet *dev = netdev_priv(net);
>>> + unsigned int start;
>>> + int cpu;
>>> +
>>> + n
Hi Oliver,
On 31/03/17 19:39, Oliver Neukum wrote:
Am Freitag, den 31.03.2017, 10:48 +0200 schrieb Bjørn Mork:
You get *all* the "0" line drivers for free, not only "qmi_wwan". No
code changes needed, except for adding the single .ndo line to drivers
overriding the usbnet default net_device_op
Hi Bjorn,
On 31/03/17 18:48, Bjørn Mork wrote:
Greg Ungerer writes:
Add support for the net stats64 counters to the usbnet core and then to
the qmi_wwan driver.
This is a strait forward addition of 64bit counters for RX and TX packets
and byte counts. It is done in the same style as for the o
Resending PATCH v3 after rebasing with testing/next branch in
Felipe Balbi's git tree. Resolved few merge conflicts.
Tested applying all patches. Patch 1/7 can be ignored since it's
already applied.
Changes in PATCH v3:
===
1. Updated bindings documentation and platform driver to
Hi Felipe,
On Fri, Mar 31, 2017 at 3:19 PM, Felipe Balbi wrote:
>
> Hi,
>
> Raviteja Garimella writes:
>
>> This patch renames the amd5536udc.c that has the core driver
>> functionality of Synopsys UDC to snps_udc_core.c
>>
>> The symbols exported here can be used by any UDC driver that uses
>>
This patch adds platform driver support for Synopsys UDC.
A new driver file (snps_udc_plat.c) is created for this purpose
where the platform driver registration is done based on OF
node.
Currently, UDC integrated into Broadcom's iProc SoCs (Northstar2
and Cygnus) work with this driver.
New membe
Using dma_pool instead of pci_pool will make snps_udc_core driver
to be compatible with non-pci platforms.
Signed-off-by: Raviteja Garimella
---
drivers/usb/gadget/udc/snps_udc_core.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/gadget/udc/snps_udc_core
The device node is used for UDCs integrated into Broadcom's
iProc family of SoCs'. The UDC is based on Synopsys Designware
Cores AHB Subsystem USB Device Controller IP.
Signed-off-by: Raviteja Garimella
---
Documentation/devicetree/bindings/usb/iproc-udc.txt | 21 +
1 file ch
This patch adds a struct device member to UDC data structure and
makes changes to the arguments of dev_err and dev_dbg calls so that
the debug prints work for both pci and platform devices.
Signed-off-by: Raviteja Garimella
---
drivers/usb/gadget/udc/amd5536udc.h | 4 +++-
drivers/usb/gadge
Change the argument from NULL to a struct device for the
dma_pool_create call during dma init.
Signed-off-by: Raviteja Garimella
---
drivers/usb/gadget/udc/snps_udc_core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/gadget/udc/snps_udc_core.c
b/drivers/us
Hello.
On 03/31/2017 02:12 PM, Felipe Balbi wrote:
When writing, we expect the "otg" string. When showing, we return
"OTG". Let's downcase that word to avoid confusion.
Lowercase, maybe?
Signed-off-by: Felipe Balbi
[...]
MBR, Sergei
--
To unsubscribe from this list: send the line "u
Hi,
Roger Quadros writes:
> On 31/03/17 15:00, Felipe Balbi wrote:
>>
>> Hi,
>>
>> Roger Quadros writes:
>> Your first implementation could be just that. Refactoring what needs to
>> be refactored, then patching "mode" debugfs to work properly in that
>> case. Only add otg.c/drd.c
On 31/03/17 15:00, Felipe Balbi wrote:
>
> Hi,
>
> Roger Quadros writes:
> Your first implementation could be just that. Refactoring what needs to
> be refactored, then patching "mode" debugfs to work properly in that
> case. Only add otg.c/drd.c after "mode" debugfs file is stable
Hi,
Roger Quadros writes:
Your first implementation could be just that. Refactoring what needs to
be refactored, then patching "mode" debugfs to work properly in that
case. Only add otg.c/drd.c after "mode" debugfs file is stable, because
then you know what needs to be taken
+Mathias
On 31/03/17 10:46, Felipe Balbi wrote:
>
> Hi,
>
> Roger Quadros writes:
> Roger Quadros writes:
>> dra7 OTG core limits the host controller to USB2.0 (high-speed) mode
>> when we're operating in dual-role.
>
> yeah, that's not a quirk. DRA7 supports OTGv2, not OTG
When writing, we expect the "otg" string. When showing, we return
"OTG". Let's downcase that word to avoid confusion.
Signed-off-by: Felipe Balbi
---
drivers/usb/dwc3/debugfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/dwc3/debugfs.c b/drivers/usb/dwc3/debug
Hi,
Raviteja Garimella writes:
> This patch renames the amd5536udc.c that has the core driver
> functionality of Synopsys UDC to snps_udc_core.c
>
> The symbols exported here can be used by any UDC driver that uses
> the same Synopsys IP.
>
> Signed-off-by: Raviteja Garimella
unfortunately, t
Am Freitag, den 31.03.2017, 10:48 +0200 schrieb Bjørn Mork:
> You get *all* the "0" line drivers for free, not only "qmi_wwan". No
> code changes needed, except for adding the single .ndo line to drivers
> overriding the usbnet default net_device_ops. And even that only applies
> to a few of them.
Am Donnerstag, den 30.03.2017, 22:15 +0200 schrieb Tobias Herzog:
> write_used was introduced with commit 884b600f63dc ("[PATCH] USB: fix acm
> trouble with terminals") but never used since.
>
> Signed-off-by: Tobias Herzog
Acked-by: Oliver Neukum
--
To unsubscribe from this list: send the line
Am Donnerstag, den 30.03.2017, 22:15 +0200 schrieb Tobias Herzog:
> Adds a similar log message to USB_CDC_NOTIFY_SERIAL_STATE as it is
> already done with USB_CDC_NOTIFY_NETWORK_CONNECTION.
>
> Signed-off-by: Tobias Herzog
Acked-by: Oliver Neukum
--
To unsubscribe from this list: send the line
Am Donnerstag, den 30.03.2017, 22:15 +0200 schrieb Tobias Herzog:
> USB devices may have very limited endpoint packet sizes, so that
> notifications can not be transferred within one single usb packet.
> Reassembling of multiple packages may be necessary.
>
> Signed-off-by: Tobias Herzog
Acked-by
Am Donnerstag, den 30.03.2017, 22:15 +0200 schrieb Tobias Herzog:
> Notifications may only be 8 bytes long. Accessing the 9th and
> 10th byte of unimplemented/unknown notifications may be insecure.
> Also check the length of known notifications before accessing anything
> behind the 8th byte.
>
>
Hi Felipe and Petr,
On Tuesday 28 Mar 2017 16:48:46 Felipe Balbi wrote:
> Petr Cvek writes:
> > Dne 7.3.2017 v 06:58 Laurent Pinchart napsal(a):
> >> On Tuesday 07 Mar 2017 00:57:20 Petr Cvek wrote:
> >>> Commit 76e0da34c7ce ("usb-gadget/uvc: use per-attribute show and store
> >>> methods") cause
Greg Ungerer writes:
> Add support for the net stats64 counters to the usbnet core and then to
> the qmi_wwan driver.
>
> This is a strait forward addition of 64bit counters for RX and TX packets
> and byte counts. It is done in the same style as for the other net drivers
> that support stats64.
Signed-off-by: Yuyang Du
---
tools/usb/usbip/libsrc/vhci_driver.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/tools/usb/usbip/libsrc/vhci_driver.c
b/tools/usb/usbip/libsrc/vhci_driver.c
index f596ef4..d34a482 100644
--- a/tools/usb/usbip/libsrc/vhci_driver.c
+++ b/tools/usb/usbip/libsrc
parse_status() reads the status file one by one, so it can only
update the available and according vhci_driver->idev's.
Signed-off-by: Yuyang Du
---
tools/usb/usbip/libsrc/vhci_driver.c | 36 +++-
tools/usb/usbip/src/usbip_attach.c | 2 ++
2 files changed, 17 i
vhci_tx_urb() should be able to get the vhci_device from
its caller vhci_urb_enqueue(), instead of brutal-force
searching it.
Signed-off-by: Yuyang Du
---
drivers/usb/usbip/vhci_hcd.c | 32 ++--
1 file changed, 2 insertions(+), 30 deletions(-)
diff --git a/drivers/us
The commit 0775a9cbc694e8c7 ("usbip: vhci extension: modifications
to vhci driver") introduced multiple controllers, but the status
of the ports are only extracted from the first status file, fix it.
Signed-off-by: Yuyang Du
---
tools/usb/usbip/libsrc/vhci_driver.c | 27 +
The commit 0775a9cbc694e8c72 ("usbip: vhci extension: modifications
to vhci driver") introduced multiple controllers, and nports as a sys
file, and claimed to read the nports from it, but it didn't.
In addition, the get_nports() has been so wrong that even with 8 port
lines for instance, it gets 7
The commit 0775a9cbc694e8c7 ("usbip: vhci extension: modifications
to vhci driver") introduced several bugs relating to the number of
ports amd the port status. In addition, a small improvement is made
to the vhci_hcd module.
v2:
- Remove ncontrollers RO attr as suggested by Krzysztof
- As a res
A new field ncontrollers is added to the vhci_driver structure.
And this field is stored by scanning the vhci_hcd* dirs in the
platform udev.
Suggested-by: Krzysztof Opasiak
Signed-off-by: Yuyang Du
---
tools/usb/usbip/libsrc/vhci_driver.c | 32 +++-
tools/usb/usbip/
Hi Krzysztof,
On Mon, Mar 27, 2017 at 04:31:42PM +0200, Krzysztof Opasiak wrote:
>
>
> On 03/27/2017 07:25 AM, Yuyang Du wrote:
> >On Mon, Mar 27, 2017 at 09:07:50AM +0200, Krzysztof Opasiak wrote:
> >>
> >>As now we have multiple controllers I would be more than happy if we
> >>could fix functi
Hi,
Roger Quadros writes:
Roger Quadros writes:
> dra7 OTG core limits the host controller to USB2.0 (high-speed) mode
> when we're operating in dual-role.
yeah, that's not a quirk. DRA7 supports OTGv2, not OTGv3. There was no
USB3 when OTGv2 was written.
D
On Thu, Mar 30, 2017 at 03:46:30PM +0200, Johan Hovold wrote:
> Commit a65a6f14dc24 ("USB: serial: fix race between probe and open")
> fixed a race between probe and open, which could lead to crashes when a
> not yet fully initialised port was being opened.
>
> This race was later incidentally clo
Hi,
On 29/03/17 13:32, Felipe Balbi wrote:
>
> Hi,
>
> Roger Quadros writes:
>>> Roger Quadros writes:
dra7 OTG core limits the host controller to USB2.0 (high-speed) mode
when we're operating in dual-role.
>>>
>>> yeah, that's not a quirk. DRA7 supports OTGv2, not OTGv3. There was n
Currently usb3 port in fact includes two sub-ports, but it is not
flexible for some cases, such as following one:
usb3 port0 includes u2port0 and u3port0;
usb2 port0 includes u2port1;
If wants to support only HS, we can use u2port0 or u2port1, when
select u2port0, u3port0 is not needed;
If
The default value of RX detection stable time is 10us, and this
margin is too big for some critical cases which cause U3 link fail
and link to U2(probability is about 1%). So change it to 5us.
Signed-off-by: Chunfeng Yun
---
drivers/phy/phy-mt65xx-usb3.c | 18 ++
1 file changed
each port has its own reference clock, the HighSpeed port is 48M,
and the SuperSpeed port is usually 26M, put them into port node for
flexibility, this can close clock if the port is not used.
Signed-off-by: Chunfeng Yun
---
drivers/phy/phy-mt65xx-usb3.c | 27 +--
1 fil
There are some variations from mt2701 to mt2712:
1. banks shared by multiple ports are put back into each port,
such as SPLLC and U2FREQ;
2. add a new bank MISC for u2port, and CHIP for u3port;
3. bank's offset in each port are also rearranged;
Signed-off-by: Chunfeng Yun
---
drivers/phy/phy
add a new compatible string for "mt2712", and move reference clock
into each port node;
Signed-off-by: Chunfeng Yun
Acked-by: Rob Herring
---
.../devicetree/bindings/phy/phy-mt65xx-usb.txt | 93 +---
1 file changed, 80 insertions(+), 13 deletions(-)
diff --git a/Documenta
split the old SuperSpeed port node into a HighSpeed one and a new
SuperSpeed one.
Signed-off-by: Chunfeng Yun
---
arch/arm64/boot/dts/mediatek/mt8173.dtsi | 19 +--
1 file changed, 13 insertions(+), 6 deletions(-)
diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
b/arch/a
There will be a problem if SS port is diasbled and HS port extracts
100uA from SS port, so disable extract 100uA from SS port in the case,
when disable it, PA0_RG_USB20_INTR_EN should be set, otherwise HS port
only works on LS.
Signed-off-by: Chunfeng Yun
---
drivers/phy/phy-mt65xx-usb3.c | 24
there is a reference clock for each port, HighSpeed port is 48M,
and SuperSpeed port is usually 26M. it is flexible to move it
into port node, then unused clock can be disabled.
Signed-off-by: Chunfeng Yun
---
arch/arm64/boot/dts/mediatek/mt8173.dtsi |8 ++--
1 file changed, 6 insertions
Increase LFPS filter threshold to avoid some fake remote wakeup
signal which cause U3 link fail and link to U2 only at about
0.01% probability.
Signed-off-by: Chunfeng Yun
---
drivers/phy/phy-mt65xx-usb3.c |9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/phy/phy-mt65xx-usb
53 matches
Mail list logo
