Re: [PATCH v2 4/6] usb: usbip tool: Fix refresh_imported_device_list()

Hi Khan, On Tue, Apr 04, 2017 at 11:14:33AM -0600, Shuah Khan wrote: > On 03/30/2017 06:28 PM, Yuyang Du wrote: > > The commit 0775a9cbc694e8c7 ("usbip: vhci extension: modifications > > to vhci driver") introduced multiple controllers, but the status > > of the ports are only extracted from the

Re: [PATCH v2 3/6] usb: usbip tool: Add ncontrollers in vhci_driver structure

Hi Krzysztof, On Tue, Apr 04, 2017 at 04:52:32PM +0200, Krzysztof Opasiak wrote: > > > On 03/31/2017 02:28 AM, Yuyang Du wrote: > >A new field ncontrollers is added to the vhci_driver structure. > >And this field is stored by scanning the vhci_hcd* dirs in the > >platform udev. > > >

[PATCH net-next] net: usbnet: Remove unused driver_name variable

With GCC 6.3, we can get the following warning: drivers/net/usb/usbnet.c:85:19: warning: 'driver_name' defined but not used [-Wunused-const-variable=] static const char driver_name [] = "usbnet"; ^~~ Signed-off-by: Florian Fainelli ---

Re: usb: musb: regression since 4.9 on omap4-panda-es (caused by d8e5f0eca1e8)

* Tony Lindgren [170404 07:06]: > * Bin Liu [170404 05:30]: > > On Tue, Apr 04, 2017 at 10:09:50AM +0300, Peter Ujfalusi wrote: > > > Tony, > > > > > > since 4.9 (4.8 was fine) I can not boot omap4-panda-es if the musb > > > is compiled in. The kernel will stuck

Re: dwc2_hc_chhltd_intr_dma - ChHltd set errors?

On Tue, Apr 4, 2017 at 12:38 AM, Felipe Balbi wrote: > > Hi, > > Minas Harutyunyan writes: >>> We've noticed that when using usb ethernet adapters on HiKey, we >>> occasionally see errors like: >>> >>> dwc2

Re: [PATCH v6 1/4] dt-bindings: phy: Add support for QUSB2 phy

On 03/20, Vivek Gautam wrote: > diff --git a/Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt > b/Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt > new file mode 100644 > index ..a6d19acde9e0 > --- /dev/null > +++

Re: [PATCH v2 6/6] usb: usbip tool: Remove empty lines

On 03/30/2017 06:28 PM, Yuyang Du wrote: > Signed-off-by: Yuyang Du > --- > tools/usb/usbip/libsrc/vhci_driver.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/tools/usb/usbip/libsrc/vhci_driver.c > b/tools/usb/usbip/libsrc/vhci_driver.c > index f596ef4..d34a482

Re: [PATCH v2 5/6] usb: usbip tool: Fix parse_status()

On 03/30/2017 06:28 PM, Yuyang Du wrote: > parse_status() reads the status file one by one, so it can only > update the available and according vhci_driver->idev's. What are you fixing? This change log doesn't me what is the bug and what is being fixed. thanks, -- Shuah > > Signed-off-by:

Re: [PATCH v2 4/6] usb: usbip tool: Fix refresh_imported_device_list()

On 03/30/2017 06:28 PM, Yuyang Du wrote: > The commit 0775a9cbc694e8c7 ("usbip: vhci extension: modifications > to vhci driver") introduced multiple controllers, but the status > of the ports are only extracted from the first status file, fix it. Are sure this change is needed? What bug are you

Re: [PATCH] usb: dwc3: gadget: skip Set/Clear Halt when invalid

On 04/04/2017 01:09 AM, Felipe Balbi wrote: > > Hi John, > > Felipe Balbi writes: >> At least macOS seems to be sending >> ClearFeature(ENDPOINT_HALT) to endpoints which >> aren't Halted. This makes DWC3's CLEARSTALL command >> time out which causes several issues

Re: [PATCH v2 2/6] usb: usbip tool: Fix get_nports()

On 03/30/2017 06:28 PM, Yuyang Du wrote: > The commit 0775a9cbc694e8c72 ("usbip: vhci extension: modifications > to vhci driver") introduced multiple controllers, and nports as a sys > file, and claimed to read the nports from it, but it didn't. > > In addition, the get_nports() has been so wrong

Re: [PATCH v2 6/6] usb: usbip tool: Remove empty lines

On 03/31/2017 02:28 AM, Yuyang Du wrote: Signed-off-by: Yuyang Du --- Greg is probably not going to accept a commit without commit message so please fix this. At least for me it looks like this commit could be squashed with the previous one as they are both fixing

Re: [PATCH v2 5/6] usb: usbip tool: Fix parse_status()

On 03/31/2017 02:28 AM, Yuyang Du wrote: parse_status() reads the status file one by one, so it can only update the available and according vhci_driver->idev's. Signed-off-by: Yuyang Du --- tools/usb/usbip/libsrc/vhci_driver.c | 36 +++-

Re: [PATCH v2 1/6] usb: usbip: Remove unnecessary get_vdev()

On 04/04/2017 08:43 AM, Krzysztof Opasiak wrote: > > > On 03/31/2017 02:28 AM, Yuyang Du wrote: >> vhci_tx_urb() should be able to get the vhci_device from >> its caller vhci_urb_enqueue(), instead of brutal-force >> searching it. >> >> Signed-off-by: Yuyang Du >> --- >>

Re: [PATCH v2 4/6] usb: usbip tool: Fix refresh_imported_device_list()

On 03/31/2017 02:28 AM, Yuyang Du wrote: The commit 0775a9cbc694e8c7 ("usbip: vhci extension: modifications to vhci driver") introduced multiple controllers, but the status of the ports are only extracted from the first status file, fix it. Signed-off-by: Yuyang Du ---

Re: [PATCH v2 3/6] usb: usbip tool: Add ncontrollers in vhci_driver structure

On 03/31/2017 02:28 AM, Yuyang Du wrote: A new field ncontrollers is added to the vhci_driver structure. And this field is stored by scanning the vhci_hcd* dirs in the platform udev. Suggested-by: Krzysztof Opasiak Signed-off-by: Yuyang Du ---

Re: [PATCH v2 1/6] usb: usbip: Remove unnecessary get_vdev()

On 03/31/2017 02:28 AM, Yuyang Du wrote: vhci_tx_urb() should be able to get the vhci_device from its caller vhci_urb_enqueue(), instead of brutal-force searching it. Signed-off-by: Yuyang Du --- drivers/usb/usbip/vhci_hcd.c | 32 ++-- 1 file

[PATCH] fsl_udc_core: add support for devices provided by fsl-mph-dr-of

Currently the of glue code in fsl-mph-dr-of will create the platform device fsl-usb2-udc. As this driver should also be probed by this name, this patch adds it to the devtypes list. Signed-off-by: Michael Grzeschik --- drivers/usb/gadget/udc/fsl_udc_core.c | 2 ++ 1

Re: Ragentek usb-serial driver

On Tue, 2017-04-04 at 15:47 +0200, Johan Hovold wrote: > > cat /sys/bus/usb-serial/drivers/generic/new_id > > 0e8d 2000 > > You only enabled "0e8d 2000", you need to add also "0bb4 0c01" if you > want the driver to bind to that id. > Got it cat /sys/bus/usb-serial/drivers/generic/new_id 0e8d

Re: [PATCH v3 1/3] usb: udc: allow adding and removing the same gadget device

On Tue, 4 Apr 2017, Felipe Balbi wrote: > Hi, > > Alan Stern writes: > > On Mon, 3 Apr 2017, Roger Quadros wrote: > > > >> allow usb_del_gadget_udc() and usb add_gadget_udc() to be called > >> repeatedly on the same gadget->dev structure. > >> > >> We need to clear

Re: usb: musb: regression since 4.9 on omap4-panda-es (caused by d8e5f0eca1e8)

* Bin Liu [170404 05:30]: > On Tue, Apr 04, 2017 at 10:09:50AM +0300, Peter Ujfalusi wrote: > > Tony, > > > > since 4.9 (4.8 was fine) I can not boot omap4-panda-es if the musb > > is compiled in. The kernel will stuck printing: > > > > ** 206 printk messages dropped ** [

Re: Ragentek usb-serial driver

On Tue, Apr 04, 2017 at 03:26:41PM +0200, Alexander Kozyrev wrote: > On Tue, 2017-04-04 at 15:06 +0200, Johan Hovold wrote: > > How did you get the generic driver to bind to 0e8d:2000? You need to > > tell the generic driver to bind also to 0bb4:0c01, for example, > > > > echo 0bb4 0c01

Re: [PATCH v2 2/2] usb: misc: refactor code

On Mon, 3 Apr 2017, Gustavo A. R. Silva wrote: > Code refactoring to make the flow easier to follow. > > Cc: Alan Stern > Cc: Greg Kroah-Hartman > Signed-off-by: Gustavo A. R. Silva > --- > Changes in v2: >

Re: Ragentek usb-serial driver

On Tue, 2017-04-04 at 15:06 +0200, Johan Hovold wrote: > > SerialNumber=3 > > [73.663718] usb 1-1: Product: Android > > [73.663720] usb 1-1: Manufacturer: MediaTek > > [73.663722] usb 1-1: SerialNumber: X560I1ZR5A241388 > > And here it comes up with a new personality (if you didn't switch the >

Re: Ragentek usb-serial driver

On Tue, Apr 04, 2017 at 12:36:00PM +0200, Alexander Kozyrev wrote: > Hi all! > > Have troubles with Ragentek chip in Mediatek Leagoo Android phone. It's > tries to connect as ttyACM0 device and ttyUSB0 - unsuccessful. > > [2.219806] usb 1-1: new high-speed USB device number 36 using xhci_hcd >

[PATCH 23/24] usb: xhci: refine xhci_decode_trb()

From: Lu Baolu Replace 'TRB_FIELD_TO_TYPE(field3)' with 'type' to simplify code. Signed-off-by: Lu Baolu Signed-off-by: Mathias Nyman --- drivers/usb/host/xhci.h | 40

[PATCH 24/24] usb: xhci: bInterval quirk for TI TUSB73x0

From: Roger Quadros As per [1] issue #4, "The periodic EP scheduler always tries to schedule the EPs that have large intervals (interval equal to or greater than 128 microframes) into different microframes. So it maintains an internal counter and increments for each large interval

[PATCH 19/24] usb: xhci: remove ring debugging code

From: Lu Baolu XHCI ring changes have already been traced by the ring trace events. It's unnecessary to put the same messages in kernel log. This patch removes the debugging code for a ring. Signed-off-by: Lu Baolu Signed-off-by: Mathias

[PATCH 22/24] usb: xhci: fix link trb decoding

From: Lu Baolu xhci_decode_trb() treats a link trb in the same way as that for an event trb. This patch fixes this by decoding the link trb according to the spec. Signed-off-by: Lu Baolu Signed-off-by: Mathias Nyman

[PATCH 18/24] usb: xhci: remove enq_updates and deq_updates from ring

From: Lu Baolu enq_updates and deq_updates were introduced in the first place to check whether an xhci hardware is able to respond to trbs enqueued in the ring. We now have trb tracers to trace every single enqueue/dequeue trb. It's time to remove them and the

[PATCH 14/24] usb: xhci: add xhci_log_ring trace events

From: Lu Baolu This patch creates a new event class called xhci_log_ring, and defines the events used for tracing the change of all kinds of rings used by an xhci host. An xHCI ring is basically a memory block shared between software and hardware. By tracing changes of

[PATCH 17/24] usb: xhci: remove error messages for failed memory allocation

From: Lu Baolu Omit extra messages for memory allocation failure. Signed-off-by: Lu Baolu Signed-off-by: Mathias Nyman --- drivers/usb/host/xhci-hub.c | 4 +--- drivers/usb/host/xhci-mem.c | 1 -

[PATCH 21/24] usb: xhci: remove xhci_dbg_ctx()

From: Lu Baolu XHCI context changes have already been traced by the trace events. It's unnecessary to put the same message in kernel log. This patch removes the use of xhci_dbg_ctx(). Signed-off-by: Lu Baolu Signed-off-by: Mathias Nyman

[PATCH 20/24] usb: xhci: remove xhci_debug_trb()

From: Lu Baolu Every XHCI TRB has already been traced by the trb trace events. It is unnecessary to put the same message in kernel log. This patch removes xhci_debug_trb(). Signed-off-by: Lu Baolu Signed-off-by: Mathias Nyman

[PATCH 16/24] usb: xhci: make several functions static

From: Lu Baolu Several functions have a single user in the same file where it is defined. There's no need to expose it anywhere else. Signed-off-by: Lu Baolu Signed-off-by: Mathias Nyman ---

[PATCH 12/24] xhci: Do not halt the host until both HCD have disconnected their devices.

From: Joel Stanley We can't halt the host controller immediately when first HCD is removed as it will cause problems if we have devices attached to the second (primary) HCD, like a keyboard. We've been carrying this in our Linux-as-a-bootloader environment for a little while

[PATCH 13/24] xhci: Rework how we handle unresponsive or hoptlug removed hosts

Introduce a new xhci_hc_died() function that takes care of handling pending commands and URBs if a host controller becomes unresponsive. This addresses issues on hotpluggable xhci controllers that disappear from the bus suddenly, often while the bus (PCI) remove function is still being processed.

[PATCH 15/24] usb: xhci: remove xhci_dbg_ep_rings()

From: Lu Baolu xhci_dbg_ep_rings() isn't used in xhci driver anymore. Remove it to reduce the module binary size. Signed-off-by: Lu Baolu Signed-off-by: Mathias Nyman --- drivers/usb/host/xhci-dbg.c | 24

[PATCH 08/24] usb: host: xhci: extract xhci_slot_state_string()

From: Felipe Balbi By extracting and exposing xhci_slot_state_string() in a header file, we can re-use it to print Slot Context State from our tracepoints, which can aid in tracking down problems related to command execution. Signed-off-by: Felipe Balbi

[PATCH 09/24] usb: host: xhci: add Slot and EP Context tracers

From: Felipe Balbi With these, we can track what's happening with the HW while executing each and every command. It will give us visibility into how the different contexts are being modified by xHC which can bring insight into problems while debugging.

[PATCH 10/24] usb: host: xhci: fix up Control Transfer TRB decoder

From: Felipe Balbi Format for each TRB in each control transfer stage differs. Let's make sure we correctly pretty print these fields to avoid confusion. Signed-off-by: Felipe Balbi Signed-off-by: Mathias Nyman

[PATCH 07/24] usb: host: xhci: print device slot from URB tracers

From: Felipe Balbi This will help us figuring out which device $this URB belongs to while debugging. Signed-off-by: Felipe Balbi Signed-off-by: Mathias Nyman --- drivers/usb/host/xhci-trace.h | 8

[PATCH 06/24] usb: xhci: Add port test modes support for usb2.

From: Guoqing Zhang For usb2 ports, the port test mode Test_J_State, Test_K_State, Test_Packet, Test_SE0_NAK and Test_Force_En can be enabled as described in usb2 spec. USB2 test mode is a required hardware feature for system integrators validating their hardware

[PATCH 11/24] xhci: add slot and endpoint numbers to debug messages in handle_tx_event

From: Zhengjun Xing There's one annoyance in how xhci prints debug messages, we often get logs with messages but it's hard to say from which device and endpoint the message originates. Add slot_id, ep_index messages in handle_tx_event. Signed-off-by: Zhengjun Xing

[PATCH 05/24] usb: xhci: Expose xhci_start() function.

From: Guoqing Zhang Change the visability of xhci_start() so that it can be used when enabling test mode. Signed-off-by: Guoqing Zhang Signed-off-by: Mathias Nyman --- drivers/usb/host/xhci.c | 2 +-

[PATCH 04/24] usb: xhci: Add helper function xhci_disable_slot().

From: Guoqing Zhang Refactoring slot disable related code into a helper function xhci_disable_slot() which can be used when enabling test mode. Signed-off-by: Guoqing Zhang Signed-off-by: Mathias Nyman ---

[PATCH 00/24] xhci changes and fetures for usb-next

Hi Greg Among other small changes this series adds usb2 port test mode for xhci, reworks how we handle unresponsive (hotplug removed) hosts, and shifts debugging more towards tracing. -Mathias Andrew Bresticker (1): usb: xhci: plat: Enable async suspend/resume Felipe Balbi (4): usb: host:

[PATCH 02/24] usb: xhci: clear EINT bit in status correctly

From: Lu Baolu EINT(Event Interrupt) is a write-1-to-clear type of bit in xhci status register. It should be cleared by writing a 1. Writing 0 to this bit has no effect. Xhci driver tries to clear this bit by writing 0 to it. This is not the right way to go. This patch

[PATCH 01/24] usb: xhci: plat: Enable async suspend/resume

From: Andrew Bresticker USB host controllers can take a significant amount of time to suspend and resume, adding several hundred miliseconds to the kernel resume time. Since the XHCI controller has no outside dependencies (other than clocks, which are suspended

[PATCH 03/24] usb: xhci: Add helper function xhci_set_power_on().

From: Guoqing Zhang Refactoring port power on/off related code into a helper function xhci_set_power_on() which can be reused when enabling test mode. Signed-off-by: Guoqing Zhang Signed-off-by: Mathias Nyman ---

Re: [PATCH v2 2/4] reset: Add APIs to manage array of resets

Hi Vivek, On Tue, 2017-04-04 at 16:09 +0530, Vivek Gautam wrote: [...] > > I'd prefer to mirror the gpiod API a little, and to have the number > > contained in the array structure, similar to struct gpio_descs: [...] > Alright, i can update this. > I took regulator_bulk interface as the

Re: usb: musb: regression since 4.9 on omap4-panda-es (caused by d8e5f0eca1e8)

On Tue, Apr 04, 2017 at 10:09:50AM +0300, Peter Ujfalusi wrote: > Tony, > > since 4.9 (4.8 was fine) I can not boot omap4-panda-es if the musb > is compiled in. The kernel will stuck printing: > > ** 206 printk messages dropped ** [8.926727] musb_bus_suspend > 2584: trying to suspend as

Re: Fw: New Defects reported by Coverity Scan for Linux

Oliver Neukum writes: > Am Montag, den 03.04.2017, 12:48 -0700 schrieb Stephen Hemminger: >> Looks like new warnings in usbnet >> >> >> ** CID 751368: Null pointer dereferences (FORWARD_NULL) >> /drivers/net/usb/usbnet.c: 1925 in __usbnet_read_cmd() > > Hi Stephen, > > I am

Re: Ragentek usb-serial driver

Am Dienstag, den 04.04.2017, 13:02 +0200 schrieb Alexander Kozyrev: > $ lsusb -s 1:57 -v > > Bus 001 Device 057: ID 0bb4:0c01 HTC (High Tech Computer Corp.) Dream / > ADP1 / G1 / Magic / Tattoo > Device Descriptor: > bLength18 > bDescriptorType 1 > bcdUSB

Re: [PATCH 2/2] usb: misc: refactor code

Hello, Quoting Felipe Balbi : Hi, "Gustavo A. R. Silva" writes: Code refactoring to make the flow easier to follow. Cc: Alan Stern Cc: Greg Kroah-Hartman Signed-off-by: Gustavo

Re: Ragentek usb-serial driver

Am Dienstag, den 04.04.2017, 12:36 +0200 schrieb Alexander Kozyrev: > Hi all! > > Have troubles with Ragentek chip in Mediatek Leagoo Android phone. It's > tries to connect as ttyACM0 device and ttyUSB0 - unsuccessful. Hi, please post lsusb -v Regards Oliver -- To

Ragentek usb-serial driver

Hi all! Have troubles with Ragentek chip in Mediatek Leagoo Android phone. It's tries to connect as ttyACM0 device and ttyUSB0 - unsuccessful. [2.219806] usb 1-1: new high-speed USB device number 36 using xhci_hcd [2.385119] usb 1-1: New USB device found, idVendor=0e8d, idProduct=2008 [2.385125]

Re: [PATCH v2 2/4] reset: Add APIs to manage array of resets

Hi Philipp, On 04/03/2017 10:06 PM, Philipp Zabel wrote: Hi Vivek, thank you for the patch series. A few comments below: I'd like to reduce the API surface a bit and include the counting and array allocation in the _get functions, if possible. Thank you for reviewing the patch. Please find

Re: Fw: New Defects reported by Coverity Scan for Linux

Am Montag, den 03.04.2017, 12:48 -0700 schrieb Stephen Hemminger: > Looks like new warnings in usbnet > > > ** CID 751368: Null pointer dereferences (FORWARD_NULL) > /drivers/net/usb/usbnet.c: 1925 in __usbnet_read_cmd() Hi Stephen, I am afraid I don't see the problem. Yes, we are passing a

Re: [PATCH] usb: dwc3: gadget: skip Set/Clear Halt when invalid

Hi John, Felipe Balbi writes: > At least macOS seems to be sending > ClearFeature(ENDPOINT_HALT) to endpoints which > aren't Halted. This makes DWC3's CLEARSTALL command > time out which causes several issues for the driver. > > Instead, let's just return 0 and

Re: [PATCH v3 1/3] usb: udc: allow adding and removing the same gadget device

Hi, Alan Stern writes: > On Mon, 3 Apr 2017, Roger Quadros wrote: > >> allow usb_del_gadget_udc() and usb add_gadget_udc() to be called >> repeatedly on the same gadget->dev structure. >> >> We need to clear the gadget->dev structure so that kobject_init() >> doesn't

[PATCH v4 3/3] usb: dwc3: Add dual-role support

If dr_mode is "otg" then support dual role mode of operation. Currently this mode is only supported when an extcon handle is present in the dwc3 device tree node. This is needed to get the ID status events of the port. We're using a workqueue to manage the dual-role state transitions as the

Re: [PATCH 2/2] usb: misc: refactor code

Hi, "Gustavo A. R. Silva" writes: > Code refactoring to make the flow easier to follow. > > Cc: Alan Stern > Cc: Greg Kroah-Hartman > Signed-off-by: Gustavo A. R. Silva > --- >

Re: [PATCH v3 3/3] usb: dwc3: Add dual-role support

drop us a note to > help improve the system] > > url: > https://github.com/0day-ci/linux/commits/Roger-Quadros/usb-dwc3-dual-role-support/20170404-022401 > base: https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git next > config: i386-randconfig-x010-201714 (attac

Re: dwc2_hc_chhltd_intr_dma - ChHltd set errors?

Hi, Minas Harutyunyan writes: >> We've noticed that when using usb ethernet adapters on HiKey, we >> occasionally see errors like: >> >> dwc2 f72c.usb: dwc2_hc_chhltd_intr_dma: Channel 0 - ChHltd set, >> but reason is unknown >> dwc2

Re: dwc2_hc_chhltd_intr_dma - ChHltd set errors?

Hi, On 4/4/2017 7:04 AM, John Stultz wrote: > On Mon, Apr 3, 2017 at 5:54 AM, Minas Harutyunyan > wrote: >> On 4/3/2017 9:23 AM, John Youn wrote: >>> On 03/31/2017 04:04 PM, John Stultz wrote: On Thu, Mar 2, 2017 at 12:00 PM, John Stultz

usb: musb: regression since 4.9 on omap4-panda-es (caused by d8e5f0eca1e8)

Tony, since 4.9 (4.8 was fine) I can not boot omap4-panda-es if the musb is compiled in. The kernel will stuck printing: ** 206 printk messages dropped ** [8.926727] musb_bus_suspend 2584: trying to suspend as a_idle while active The bisect (log is [1]) points to: d8e5f0eca1e8 usb:

Re: [PATCH] ARM: davinci: Add the clock for the CPPI 4.1 DMA engine

On Wednesday 29 March 2017 09:39 PM, Alexandre Bailon wrote: > The CPPI 4.1 DMA is sharing its clock with the USB OTG, > and most of the time, the clock will be enabled by USB. > But during the init of the DMA, USB is not enabled (waiting for DMA), > and then we must enable the clock before to do